@typescript-deploys/pr-build 5.4.0-pr-56418-6 → 5.4.0-pr-55924-19

package/lib/lib.esnext.disposable.d.ts

@@ -43,7 +43,7 @@ interface SuppressedError extends Error {
     suppressed: any;
 }
 
-interface SuppressedErrorConstructor extends ErrorConstructor {
+interface SuppressedErrorConstructor {
     new (error: any, suppressed: any, message?: string): SuppressedError;
     (error: any, suppressed: any, message?: string): SuppressedError;
     readonly prototype: SuppressedError;

package/lib/tsc.js

@@ -18,7 +18,7 @@ and limitations under the License.
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.4";
-var version = `${versionMajorMinor}.0-insiders.20231115`;
+var version = `${versionMajorMinor}.0-insiders.20231116`;
 
 // src/compiler/core.ts
 var emptyArray = [];
@@ -6791,6 +6791,8 @@ var Diagnostics = {
   This_member_cannot_have_a_JSDoc_comment_with_an_override_tag_because_it_is_not_declared_in_the_base_class_0: diag(4122, 1 /* Error */, "This_member_cannot_have_a_JSDoc_comment_with_an_override_tag_because_it_is_not_declared_in_the_base__4122", "This member cannot have a JSDoc comment with an '@override' tag because it is not declared in the base class '{0}'."),
   This_member_cannot_have_a_JSDoc_comment_with_an_override_tag_because_it_is_not_declared_in_the_base_class_0_Did_you_mean_1: diag(4123, 1 /* Error */, "This_member_cannot_have_a_JSDoc_comment_with_an_override_tag_because_it_is_not_declared_in_the_base__4123", "This member cannot have a JSDoc comment with an 'override' tag because it is not declared in the base class '{0}'. Did you mean '{1}'?"),
   Compiler_option_0_of_value_1_is_unstable_Use_nightly_TypeScript_to_silence_this_error_Try_updating_with_npm_install_D_typescript_next: diag(4124, 1 /* Error */, "Compiler_option_0_of_value_1_is_unstable_Use_nightly_TypeScript_to_silence_this_error_Try_updating_w_4124", "Compiler option '{0}' of value '{1}' is unstable. Use nightly TypeScript to silence this error. Try updating with 'npm install -D typescript@next'."),
+  Each_declaration_of_0_1_differs_in_its_value_where_2_was_expected_but_3_was_given: diag(4125, 1 /* Error */, "Each_declaration_of_0_1_differs_in_its_value_where_2_was_expected_but_3_was_given_4125", "Each declaration of '{0}.{1}' differs in its value, where '{2}' was expected but '{3}' was given."),
+  Values_of_0_1_are_not_sufficiently_known: diag(4126, 1 /* Error */, "Values_of_0_1_are_not_sufficiently_known_4126", "Values of '{0}.{1}' are not sufficiently known."),
   The_current_host_does_not_support_the_0_option: diag(5001, 1 /* Error */, "The_current_host_does_not_support_the_0_option_5001", "The current host does not support the '{0}' option."),
   Cannot_find_the_common_subdirectory_path_for_the_input_files: diag(5009, 1 /* Error */, "Cannot_find_the_common_subdirectory_path_for_the_input_files_5009", "Cannot find the common subdirectory path for the input files."),
   File_specification_cannot_end_in_a_recursive_directory_wildcard_Asterisk_Asterisk_Colon_0: diag(5010, 1 /* Error */, "File_specification_cannot_end_in_a_recursive_directory_wildcard_Asterisk_Asterisk_Colon_0_5010", "File specification cannot end in a recursive directory wildcard ('**'): '{0}'."),
@@ -48268,6 +48270,8 @@ function createTypeChecker(host) {
           context.symbolDepth.set(id, depth + 1);
         }
         context.visitedTypes.add(typeId);
+        const prevTrackedSymbols = context.trackedSymbols;
+        context.trackedSymbols = void 0;
         const startLength = context.approximateLength;
         const result = transform(type2);
         const addedLength = context.approximateLength - startLength;
@@ -48283,6 +48287,7 @@ function createTypeChecker(host) {
         if (id) {
           context.symbolDepth.set(id, depth);
         }
+        context.trackedSymbols = prevTrackedSymbols;
         return result;
         function deepCloneOrReuseNode(node) {
           if (!nodeIsSynthesized(node) && getParseTreeNode(node) === node) {
@@ -48585,7 +48590,7 @@ function createTypeChecker(host) {
       context.approximateLength += symbolName(propertySymbol).length + 1;
       if (propertySymbol.flags & 98304 /* Accessor */) {
         const writeType = getWriteTypeOfSymbol(propertySymbol);
-        if (propertyType !== writeType) {
+        if (propertyType !== writeType && !isErrorType(propertyType) && !isErrorType(writeType)) {
           const getterDeclaration = getDeclarationOfKind(propertySymbol, 177 /* GetAccessor */);
           const getterSignature = getSignatureFromDeclaration(getterDeclaration);
           typeElements.push(
@@ -60152,12 +60157,12 @@ function createTypeChecker(host) {
       return !!(entry & 1 /* Succeeded */);
     }
     const targetEnumType = getTypeOfSymbol(targetSymbol);
-    for (const property of getPropertiesOfType(getTypeOfSymbol(sourceSymbol))) {
-      if (property.flags & 8 /* EnumMember */) {
-        const targetProperty = getPropertyOfType(targetEnumType, property.escapedName);
+    for (const sourceProperty of getPropertiesOfType(getTypeOfSymbol(sourceSymbol))) {
+      if (sourceProperty.flags & 8 /* EnumMember */) {
+        const targetProperty = getPropertyOfType(targetEnumType, sourceProperty.escapedName);
         if (!targetProperty || !(targetProperty.flags & 8 /* EnumMember */)) {
           if (errorReporter) {
-            errorReporter(Diagnostics.Property_0_is_missing_in_type_1, symbolName(property), typeToString(
+            errorReporter(Diagnostics.Property_0_is_missing_in_type_1, symbolName(sourceProperty), typeToString(
               getDeclaredTypeOfSymbol(targetSymbol),
               /*enclosingDeclaration*/
               void 0,
@@ -60169,6 +60174,22 @@ function createTypeChecker(host) {
           }
           return false;
         }
+        const sourceValue = getEnumMemberValue(getDeclarationOfKind(sourceProperty, 306 /* EnumMember */));
+        const targetValue = getEnumMemberValue(getDeclarationOfKind(targetProperty, 306 /* EnumMember */));
+        if (sourceValue !== targetValue || sourceValue === void 0 || targetValue === void 0) {
+          if (!errorReporter) {
+            enumRelation.set(id, 2 /* Failed */);
+          } else if (sourceValue !== targetValue && sourceValue !== void 0 && targetValue !== void 0) {
+            const escapedSource = typeof sourceValue === "string" ? `"${escapeString(sourceValue)}"` : sourceValue;
+            const escapedTarget = typeof targetValue === "string" ? `"${escapeString(targetValue)}"` : targetValue;
+            errorReporter(Diagnostics.Each_declaration_of_0_1_differs_in_its_value_where_2_was_expected_but_3_was_given, symbolName(targetSymbol), symbolName(targetProperty), escapedTarget, escapedSource);
+            enumRelation.set(id, 2 /* Failed */ | 4 /* Reported */);
+          } else {
+            errorReporter(Diagnostics.Values_of_0_1_are_not_sufficiently_known, symbolName(targetSymbol), symbolName(targetProperty));
+            enumRelation.set(id, 2 /* Failed */ | 4 /* Reported */);
+          }
+          return false;
+        }
       }
     }
     enumRelation.set(id, 1 /* Succeeded */);
@@ -75536,7 +75557,7 @@ function createTypeChecker(host) {
       const modifiers = getTypeParameterModifiers(typeParameter) & (8192 /* In */ | 16384 /* Out */);
       if (modifiers) {
         const symbol = getSymbolOfDeclaration(node.parent);
-        if (isTypeAliasDeclaration(node.parent) && !(getObjectFlags(getDeclaredTypeOfSymbol(symbol)) & (4 /* Reference */ | 16 /* Anonymous */ | 32 /* Mapped */))) {
+        if (isTypeAliasDeclaration(node.parent) && !(getObjectFlags(getDeclaredTypeOfSymbol(symbol)) & (16 /* Anonymous */ | 32 /* Mapped */))) {
           error(node, Diagnostics.Variance_annotations_are_only_supported_in_type_aliases_for_object_function_constructor_and_mapped_types);
         } else if (modifiers === 8192 /* In */ || modifiers === 16384 /* Out */) {
           (_a = tracing) == null ? void 0 : _a.push(tracing.Phase.CheckTypes, "checkTypeParameterDeferred", { parent: getTypeId(getDeclaredTypeOfSymbol(symbol)), id: getTypeId(typeParameter) });

package/lib/tsserver.js

@@ -2330,7 +2330,7 @@ module.exports = __toCommonJS(server_exports);
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.4";
-var version = `${versionMajorMinor}.0-insiders.20231115`;
+var version = `${versionMajorMinor}.0-insiders.20231116`;
 var Comparison = /* @__PURE__ */ ((Comparison3) => {
   Comparison3[Comparison3["LessThan"] = -1] = "LessThan";
   Comparison3[Comparison3["EqualTo"] = 0] = "EqualTo";
@@ -10323,6 +10323,8 @@ var Diagnostics = {
   This_member_cannot_have_a_JSDoc_comment_with_an_override_tag_because_it_is_not_declared_in_the_base_class_0: diag(4122, 1 /* Error */, "This_member_cannot_have_a_JSDoc_comment_with_an_override_tag_because_it_is_not_declared_in_the_base__4122", "This member cannot have a JSDoc comment with an '@override' tag because it is not declared in the base class '{0}'."),
   This_member_cannot_have_a_JSDoc_comment_with_an_override_tag_because_it_is_not_declared_in_the_base_class_0_Did_you_mean_1: diag(4123, 1 /* Error */, "This_member_cannot_have_a_JSDoc_comment_with_an_override_tag_because_it_is_not_declared_in_the_base__4123", "This member cannot have a JSDoc comment with an 'override' tag because it is not declared in the base class '{0}'. Did you mean '{1}'?"),
   Compiler_option_0_of_value_1_is_unstable_Use_nightly_TypeScript_to_silence_this_error_Try_updating_with_npm_install_D_typescript_next: diag(4124, 1 /* Error */, "Compiler_option_0_of_value_1_is_unstable_Use_nightly_TypeScript_to_silence_this_error_Try_updating_w_4124", "Compiler option '{0}' of value '{1}' is unstable. Use nightly TypeScript to silence this error. Try updating with 'npm install -D typescript@next'."),
+  Each_declaration_of_0_1_differs_in_its_value_where_2_was_expected_but_3_was_given: diag(4125, 1 /* Error */, "Each_declaration_of_0_1_differs_in_its_value_where_2_was_expected_but_3_was_given_4125", "Each declaration of '{0}.{1}' differs in its value, where '{2}' was expected but '{3}' was given."),
+  Values_of_0_1_are_not_sufficiently_known: diag(4126, 1 /* Error */, "Values_of_0_1_are_not_sufficiently_known_4126", "Values of '{0}.{1}' are not sufficiently known."),
   The_current_host_does_not_support_the_0_option: diag(5001, 1 /* Error */, "The_current_host_does_not_support_the_0_option_5001", "The current host does not support the '{0}' option."),
   Cannot_find_the_common_subdirectory_path_for_the_input_files: diag(5009, 1 /* Error */, "Cannot_find_the_common_subdirectory_path_for_the_input_files_5009", "Cannot find the common subdirectory path for the input files."),
   File_specification_cannot_end_in_a_recursive_directory_wildcard_Asterisk_Asterisk_Colon_0: diag(5010, 1 /* Error */, "File_specification_cannot_end_in_a_recursive_directory_wildcard_Asterisk_Asterisk_Colon_0_5010", "File specification cannot end in a recursive directory wildcard ('**'): '{0}'."),
@@ -52976,6 +52978,8 @@ function createTypeChecker(host) {
           context.symbolDepth.set(id, depth + 1);
         }
         context.visitedTypes.add(typeId);
+        const prevTrackedSymbols = context.trackedSymbols;
+        context.trackedSymbols = void 0;
         const startLength = context.approximateLength;
         const result = transform2(type2);
         const addedLength = context.approximateLength - startLength;
@@ -52991,6 +52995,7 @@ function createTypeChecker(host) {
         if (id) {
           context.symbolDepth.set(id, depth);
         }
+        context.trackedSymbols = prevTrackedSymbols;
         return result;
         function deepCloneOrReuseNode(node) {
           if (!nodeIsSynthesized(node) && getParseTreeNode(node) === node) {
@@ -53293,7 +53298,7 @@ function createTypeChecker(host) {
       context.approximateLength += symbolName(propertySymbol).length + 1;
       if (propertySymbol.flags & 98304 /* Accessor */) {
         const writeType = getWriteTypeOfSymbol(propertySymbol);
-        if (propertyType !== writeType) {
+        if (propertyType !== writeType && !isErrorType(propertyType) && !isErrorType(writeType)) {
           const getterDeclaration = getDeclarationOfKind(propertySymbol, 177 /* GetAccessor */);
           const getterSignature = getSignatureFromDeclaration(getterDeclaration);
           typeElements.push(
@@ -64860,12 +64865,12 @@ function createTypeChecker(host) {
       return !!(entry & 1 /* Succeeded */);
     }
     const targetEnumType = getTypeOfSymbol(targetSymbol);
-    for (const property of getPropertiesOfType(getTypeOfSymbol(sourceSymbol))) {
-      if (property.flags & 8 /* EnumMember */) {
-        const targetProperty = getPropertyOfType(targetEnumType, property.escapedName);
+    for (const sourceProperty of getPropertiesOfType(getTypeOfSymbol(sourceSymbol))) {
+      if (sourceProperty.flags & 8 /* EnumMember */) {
+        const targetProperty = getPropertyOfType(targetEnumType, sourceProperty.escapedName);
         if (!targetProperty || !(targetProperty.flags & 8 /* EnumMember */)) {
           if (errorReporter) {
-            errorReporter(Diagnostics.Property_0_is_missing_in_type_1, symbolName(property), typeToString(
+            errorReporter(Diagnostics.Property_0_is_missing_in_type_1, symbolName(sourceProperty), typeToString(
               getDeclaredTypeOfSymbol(targetSymbol),
               /*enclosingDeclaration*/
               void 0,
@@ -64877,6 +64882,22 @@ function createTypeChecker(host) {
           }
           return false;
         }
+        const sourceValue = getEnumMemberValue(getDeclarationOfKind(sourceProperty, 306 /* EnumMember */));
+        const targetValue = getEnumMemberValue(getDeclarationOfKind(targetProperty, 306 /* EnumMember */));
+        if (sourceValue !== targetValue || sourceValue === void 0 || targetValue === void 0) {
+          if (!errorReporter) {
+            enumRelation.set(id, 2 /* Failed */);
+          } else if (sourceValue !== targetValue && sourceValue !== void 0 && targetValue !== void 0) {
+            const escapedSource = typeof sourceValue === "string" ? `"${escapeString(sourceValue)}"` : sourceValue;
+            const escapedTarget = typeof targetValue === "string" ? `"${escapeString(targetValue)}"` : targetValue;
+            errorReporter(Diagnostics.Each_declaration_of_0_1_differs_in_its_value_where_2_was_expected_but_3_was_given, symbolName(targetSymbol), symbolName(targetProperty), escapedTarget, escapedSource);
+            enumRelation.set(id, 2 /* Failed */ | 4 /* Reported */);
+          } else {
+            errorReporter(Diagnostics.Values_of_0_1_are_not_sufficiently_known, symbolName(targetSymbol), symbolName(targetProperty));
+            enumRelation.set(id, 2 /* Failed */ | 4 /* Reported */);
+          }
+          return false;
+        }
       }
     }
     enumRelation.set(id, 1 /* Succeeded */);
@@ -80244,7 +80265,7 @@ function createTypeChecker(host) {
       const modifiers = getTypeParameterModifiers(typeParameter) & (8192 /* In */ | 16384 /* Out */);
       if (modifiers) {
         const symbol = getSymbolOfDeclaration(node.parent);
-        if (isTypeAliasDeclaration(node.parent) && !(getObjectFlags(getDeclaredTypeOfSymbol(symbol)) & (4 /* Reference */ | 16 /* Anonymous */ | 32 /* Mapped */))) {
+        if (isTypeAliasDeclaration(node.parent) && !(getObjectFlags(getDeclaredTypeOfSymbol(symbol)) & (16 /* Anonymous */ | 32 /* Mapped */))) {
           error2(node, Diagnostics.Variance_annotations_are_only_supported_in_type_aliases_for_object_function_constructor_and_mapped_types);
         } else if (modifiers === 8192 /* In */ || modifiers === 16384 /* Out */) {
           (_a = tracing) == null ? void 0 : _a.push(tracing.Phase.CheckTypes, "checkTypeParameterDeferred", { parent: getTypeId(getDeclaredTypeOfSymbol(symbol)), id: getTypeId(typeParameter) });
@@ -158921,6 +158942,9 @@ function getCompletionEntriesFromSymbols(symbols, entries, replacementToken, con
     if (!info || uniques.get(info.name) && (!origin || !originIsObjectLiteralMethod(origin)) || kind === 1 /* Global */ && symbolToSortTextMap && !shouldIncludeSymbol(symbol, symbolToSortTextMap)) {
       continue;
     }
+    if (!isTypeOnlyLocation && isInJSFile(sourceFile) && symbolAppearsToBeTypeOnly(symbol)) {
+      continue;
+    }
     const { name, needsConvertPropertyAccess } = info;
     const originalSortText = (symbolToSortTextMap == null ? void 0 : symbolToSortTextMap[getSymbolId(symbol)]) ?? SortText.LocationPriority;
     const sortText = isDeprecated(symbol, typeChecker) ? SortText.Deprecated(originalSortText) : originalSortText;
@@ -159000,6 +159024,10 @@ function getCompletionEntriesFromSymbols(symbols, entries, replacementToken, con
     }
     return !!(allFlags & 111551 /* Value */);
   }
+  function symbolAppearsToBeTypeOnly(symbol) {
+    var _a;
+    return !(symbol.flags & 111551 /* Value */) && (!isInJSFile((_a = symbol.declarations) == null ? void 0 : _a[0]) || !!(symbol.flags & 788968 /* Type */));
+  }
 }
 function getLabelCompletionAtPosition(node) {
   const entries = getLabelStatementCompletions(node);
@@ -175479,7 +175507,7 @@ var TypingsInstaller = class {
   }
   /** @internal */
   installPackage(req) {
-    const { fileName, packageName, projectName, projectRootPath } = req;
+    const { fileName, packageName, projectName, projectRootPath, id } = req;
     const cwd = forEachAncestorDirectory(getDirectoryPath(fileName), (directory) => {
       if (this.installTypingHost.fileExists(combinePaths(directory, "package.json"))) {
         return directory;
@@ -175491,6 +175519,7 @@ var TypingsInstaller = class {
         const response = {
           kind: ActionPackageInstalled,
           projectName,
+          id,
           success,
           message
         };
@@ -175500,6 +175529,7 @@ var TypingsInstaller = class {
       const response = {
         kind: ActionPackageInstalled,
         projectName,
+        id,
         success: false,
         message: "Could not determine a project root path."
       };
@@ -186695,6 +186725,7 @@ var _TypingsInstallerAdapter = class _TypingsInstallerAdapter {
     // Maps project name to newest requestQueue entry for that project
     /** We will lazily request the types registry on the first call to `isKnownTypesPackageName` and store it in `typesRegistryCache`. */
     this.requestedRegistry = false;
+    this.packageInstallId = 0;
   }
   isKnownTypesPackageName(name) {
     var _a;
@@ -186709,11 +186740,13 @@ var _TypingsInstallerAdapter = class _TypingsInstallerAdapter {
     return !!((_a = this.typesRegistryCache) == null ? void 0 : _a.has(name));
   }
   installPackage(options) {
-    this.installer.send({ kind: "installPackage", ...options });
-    Debug.assert(this.packageInstalledPromise === void 0);
-    return new Promise((resolve, reject) => {
-      this.packageInstalledPromise = { resolve, reject };
+    this.packageInstallId++;
+    const request = { kind: "installPackage", ...options, id: this.packageInstallId };
+    const promise = new Promise((resolve, reject) => {
+      (this.packageInstalledPromise ?? (this.packageInstalledPromise = /* @__PURE__ */ new Map())).set(this.packageInstallId, { resolve, reject });
     });
+    this.installer.send(request);
+    return promise;
   }
   attach(projectService) {
     this.projectService = projectService;
@@ -186738,6 +186771,7 @@ var _TypingsInstallerAdapter = class _TypingsInstallerAdapter {
     }
   }
   handleMessage(response) {
+    var _a, _b;
     if (this.logger.hasLevel(3 /* verbose */)) {
       this.logger.info(`TIAdapter:: Received response:${stringifyIndented(response)}`);
     }
@@ -186746,13 +186780,14 @@ var _TypingsInstallerAdapter = class _TypingsInstallerAdapter {
         this.typesRegistryCache = new Map(Object.entries(response.typesRegistry));
         break;
       case ActionPackageInstalled: {
-        const { success, message } = response;
-        if (success) {
-          this.packageInstalledPromise.resolve({ successMessage: message });
+        const promise = (_a = this.packageInstalledPromise) == null ? void 0 : _a.get(response.id);
+        Debug.assertIsDefined(promise, "Should find the promise for package install");
+        (_b = this.packageInstalledPromise) == null ? void 0 : _b.delete(response.id);
+        if (response.success) {
+          promise.resolve({ successMessage: response.message });
         } else {
-          this.packageInstalledPromise.reject(message);
+          promise.reject(response.message);
         }
-        this.packageInstalledPromise = void 0;
         this.projectService.updateTypingsForProject(response);
         this.event(response, "setTypings");
         break;

package/lib/typescript.d.ts

@@ -49,9 +49,11 @@ declare namespace ts {
             readonly fileName: Path;
             readonly packageName: string;
             readonly projectRootPath: Path;
+            readonly id: number;
         }
         interface PackageInstalledResponse extends ProjectResponse {
             readonly kind: ActionPackageInstalled;
+            readonly id: number;
             readonly success: boolean;
             readonly message: string;
         }

package/lib/typescript.js

@@ -35,7 +35,7 @@ var ts = (() => {
     "src/compiler/corePublic.ts"() {
       "use strict";
       versionMajorMinor = "5.4";
-      version = `${versionMajorMinor}.0-insiders.20231115`;
+      version = `${versionMajorMinor}.0-insiders.20231116`;
       Comparison = /* @__PURE__ */ ((Comparison3) => {
         Comparison3[Comparison3["LessThan"] = -1] = "LessThan";
         Comparison3[Comparison3["EqualTo"] = 0] = "EqualTo";
@@ -8103,6 +8103,8 @@ ${lanes.join("\n")}
         This_member_cannot_have_a_JSDoc_comment_with_an_override_tag_because_it_is_not_declared_in_the_base_class_0: diag(4122, 1 /* Error */, "This_member_cannot_have_a_JSDoc_comment_with_an_override_tag_because_it_is_not_declared_in_the_base__4122", "This member cannot have a JSDoc comment with an '@override' tag because it is not declared in the base class '{0}'."),
         This_member_cannot_have_a_JSDoc_comment_with_an_override_tag_because_it_is_not_declared_in_the_base_class_0_Did_you_mean_1: diag(4123, 1 /* Error */, "This_member_cannot_have_a_JSDoc_comment_with_an_override_tag_because_it_is_not_declared_in_the_base__4123", "This member cannot have a JSDoc comment with an 'override' tag because it is not declared in the base class '{0}'. Did you mean '{1}'?"),
         Compiler_option_0_of_value_1_is_unstable_Use_nightly_TypeScript_to_silence_this_error_Try_updating_with_npm_install_D_typescript_next: diag(4124, 1 /* Error */, "Compiler_option_0_of_value_1_is_unstable_Use_nightly_TypeScript_to_silence_this_error_Try_updating_w_4124", "Compiler option '{0}' of value '{1}' is unstable. Use nightly TypeScript to silence this error. Try updating with 'npm install -D typescript@next'."),
+        Each_declaration_of_0_1_differs_in_its_value_where_2_was_expected_but_3_was_given: diag(4125, 1 /* Error */, "Each_declaration_of_0_1_differs_in_its_value_where_2_was_expected_but_3_was_given_4125", "Each declaration of '{0}.{1}' differs in its value, where '{2}' was expected but '{3}' was given."),
+        Values_of_0_1_are_not_sufficiently_known: diag(4126, 1 /* Error */, "Values_of_0_1_are_not_sufficiently_known_4126", "Values of '{0}.{1}' are not sufficiently known."),
         The_current_host_does_not_support_the_0_option: diag(5001, 1 /* Error */, "The_current_host_does_not_support_the_0_option_5001", "The current host does not support the '{0}' option."),
         Cannot_find_the_common_subdirectory_path_for_the_input_files: diag(5009, 1 /* Error */, "Cannot_find_the_common_subdirectory_path_for_the_input_files_5009", "Cannot find the common subdirectory path for the input files."),
         File_specification_cannot_end_in_a_recursive_directory_wildcard_Asterisk_Asterisk_Colon_0: diag(5010, 1 /* Error */, "File_specification_cannot_end_in_a_recursive_directory_wildcard_Asterisk_Asterisk_Colon_0_5010", "File specification cannot end in a recursive directory wildcard ('**'): '{0}'."),
@@ -50741,6 +50743,8 @@ ${lanes.join("\n")}
             context.symbolDepth.set(id, depth + 1);
           }
           context.visitedTypes.add(typeId);
+          const prevTrackedSymbols = context.trackedSymbols;
+          context.trackedSymbols = void 0;
           const startLength = context.approximateLength;
           const result = transform2(type2);
           const addedLength = context.approximateLength - startLength;
@@ -50756,6 +50760,7 @@ ${lanes.join("\n")}
           if (id) {
             context.symbolDepth.set(id, depth);
           }
+          context.trackedSymbols = prevTrackedSymbols;
           return result;
           function deepCloneOrReuseNode(node) {
             if (!nodeIsSynthesized(node) && getParseTreeNode(node) === node) {
@@ -51058,7 +51063,7 @@ ${lanes.join("\n")}
         context.approximateLength += symbolName(propertySymbol).length + 1;
         if (propertySymbol.flags & 98304 /* Accessor */) {
           const writeType = getWriteTypeOfSymbol(propertySymbol);
-          if (propertyType !== writeType) {
+          if (propertyType !== writeType && !isErrorType(propertyType) && !isErrorType(writeType)) {
             const getterDeclaration = getDeclarationOfKind(propertySymbol, 177 /* GetAccessor */);
             const getterSignature = getSignatureFromDeclaration(getterDeclaration);
             typeElements.push(
@@ -62625,12 +62630,12 @@ ${lanes.join("\n")}
         return !!(entry & 1 /* Succeeded */);
       }
       const targetEnumType = getTypeOfSymbol(targetSymbol);
-      for (const property of getPropertiesOfType(getTypeOfSymbol(sourceSymbol))) {
-        if (property.flags & 8 /* EnumMember */) {
-          const targetProperty = getPropertyOfType(targetEnumType, property.escapedName);
+      for (const sourceProperty of getPropertiesOfType(getTypeOfSymbol(sourceSymbol))) {
+        if (sourceProperty.flags & 8 /* EnumMember */) {
+          const targetProperty = getPropertyOfType(targetEnumType, sourceProperty.escapedName);
           if (!targetProperty || !(targetProperty.flags & 8 /* EnumMember */)) {
             if (errorReporter) {
-              errorReporter(Diagnostics.Property_0_is_missing_in_type_1, symbolName(property), typeToString(
+              errorReporter(Diagnostics.Property_0_is_missing_in_type_1, symbolName(sourceProperty), typeToString(
                 getDeclaredTypeOfSymbol(targetSymbol),
                 /*enclosingDeclaration*/
                 void 0,
@@ -62642,6 +62647,22 @@ ${lanes.join("\n")}
             }
             return false;
           }
+          const sourceValue = getEnumMemberValue(getDeclarationOfKind(sourceProperty, 306 /* EnumMember */));
+          const targetValue = getEnumMemberValue(getDeclarationOfKind(targetProperty, 306 /* EnumMember */));
+          if (sourceValue !== targetValue || sourceValue === void 0 || targetValue === void 0) {
+            if (!errorReporter) {
+              enumRelation.set(id, 2 /* Failed */);
+            } else if (sourceValue !== targetValue && sourceValue !== void 0 && targetValue !== void 0) {
+              const escapedSource = typeof sourceValue === "string" ? `"${escapeString(sourceValue)}"` : sourceValue;
+              const escapedTarget = typeof targetValue === "string" ? `"${escapeString(targetValue)}"` : targetValue;
+              errorReporter(Diagnostics.Each_declaration_of_0_1_differs_in_its_value_where_2_was_expected_but_3_was_given, symbolName(targetSymbol), symbolName(targetProperty), escapedTarget, escapedSource);
+              enumRelation.set(id, 2 /* Failed */ | 4 /* Reported */);
+            } else {
+              errorReporter(Diagnostics.Values_of_0_1_are_not_sufficiently_known, symbolName(targetSymbol), symbolName(targetProperty));
+              enumRelation.set(id, 2 /* Failed */ | 4 /* Reported */);
+            }
+            return false;
+          }
         }
       }
       enumRelation.set(id, 1 /* Succeeded */);
@@ -78009,7 +78030,7 @@ ${lanes.join("\n")}
         const modifiers = getTypeParameterModifiers(typeParameter) & (8192 /* In */ | 16384 /* Out */);
         if (modifiers) {
           const symbol = getSymbolOfDeclaration(node.parent);
-          if (isTypeAliasDeclaration(node.parent) && !(getObjectFlags(getDeclaredTypeOfSymbol(symbol)) & (4 /* Reference */ | 16 /* Anonymous */ | 32 /* Mapped */))) {
+          if (isTypeAliasDeclaration(node.parent) && !(getObjectFlags(getDeclaredTypeOfSymbol(symbol)) & (16 /* Anonymous */ | 32 /* Mapped */))) {
             error2(node, Diagnostics.Variance_annotations_are_only_supported_in_type_aliases_for_object_function_constructor_and_mapped_types);
           } else if (modifiers === 8192 /* In */ || modifiers === 16384 /* Out */) {
             (_a = tracing) == null ? void 0 : _a.push(tracing.Phase.CheckTypes, "checkTypeParameterDeferred", { parent: getTypeId(getDeclaredTypeOfSymbol(symbol)), id: getTypeId(typeParameter) });
@@ -158144,6 +158165,9 @@ ${newComment.split("\n").map((c) => ` * ${c}`).join("\n")}
       if (!info || uniques.get(info.name) && (!origin || !originIsObjectLiteralMethod(origin)) || kind === 1 /* Global */ && symbolToSortTextMap && !shouldIncludeSymbol(symbol, symbolToSortTextMap)) {
         continue;
       }
+      if (!isTypeOnlyLocation && isInJSFile(sourceFile) && symbolAppearsToBeTypeOnly(symbol)) {
+        continue;
+      }
       const { name, needsConvertPropertyAccess } = info;
       const originalSortText = (symbolToSortTextMap == null ? void 0 : symbolToSortTextMap[getSymbolId(symbol)]) ?? SortText.LocationPriority;
       const sortText = isDeprecated(symbol, typeChecker) ? SortText.Deprecated(originalSortText) : originalSortText;
@@ -158223,6 +158247,10 @@ ${newComment.split("\n").map((c) => ` * ${c}`).join("\n")}
       }
       return !!(allFlags & 111551 /* Value */);
     }
+    function symbolAppearsToBeTypeOnly(symbol) {
+      var _a;
+      return !(symbol.flags & 111551 /* Value */) && (!isInJSFile((_a = symbol.declarations) == null ? void 0 : _a[0]) || !!(symbol.flags & 788968 /* Type */));
+    }
   }
   function getLabelCompletionAtPosition(node) {
     const entries = getLabelStatementCompletions(node);
@@ -172693,7 +172721,7 @@ ${options.prefix}` : "\n" : options.prefix
         }
         /** @internal */
         installPackage(req) {
-          const { fileName, packageName, projectName, projectRootPath } = req;
+          const { fileName, packageName, projectName, projectRootPath, id } = req;
           const cwd = forEachAncestorDirectory(getDirectoryPath(fileName), (directory) => {
             if (this.installTypingHost.fileExists(combinePaths(directory, "package.json"))) {
               return directory;
@@ -172705,6 +172733,7 @@ ${options.prefix}` : "\n" : options.prefix
               const response = {
                 kind: ActionPackageInstalled,
                 projectName,
+                id,
                 success,
                 message
               };
@@ -172714,6 +172743,7 @@ ${options.prefix}` : "\n" : options.prefix
             const response = {
               kind: ActionPackageInstalled,
               projectName,
+              id,
               success: false,
               message: "Could not determine a project root path."
             };
@@ -184034,6 +184064,7 @@ ${e.message}`;
           // Maps project name to newest requestQueue entry for that project
           /** We will lazily request the types registry on the first call to `isKnownTypesPackageName` and store it in `typesRegistryCache`. */
           this.requestedRegistry = false;
+          this.packageInstallId = 0;
         }
         isKnownTypesPackageName(name) {
           var _a;
@@ -184048,11 +184079,13 @@ ${e.message}`;
           return !!((_a = this.typesRegistryCache) == null ? void 0 : _a.has(name));
         }
         installPackage(options) {
-          this.installer.send({ kind: "installPackage", ...options });
-          Debug.assert(this.packageInstalledPromise === void 0);
-          return new Promise((resolve, reject) => {
-            this.packageInstalledPromise = { resolve, reject };
+          this.packageInstallId++;
+          const request = { kind: "installPackage", ...options, id: this.packageInstallId };
+          const promise = new Promise((resolve, reject) => {
+            (this.packageInstalledPromise ?? (this.packageInstalledPromise = /* @__PURE__ */ new Map())).set(this.packageInstallId, { resolve, reject });
           });
+          this.installer.send(request);
+          return promise;
         }
         attach(projectService) {
           this.projectService = projectService;
@@ -184077,6 +184110,7 @@ ${e.message}`;
           }
         }
         handleMessage(response) {
+          var _a, _b;
           if (this.logger.hasLevel(3 /* verbose */)) {
             this.logger.info(`TIAdapter:: Received response:${stringifyIndented(response)}`);
           }
@@ -184085,13 +184119,14 @@ ${e.message}`;
               this.typesRegistryCache = new Map(Object.entries(response.typesRegistry));
               break;
             case ActionPackageInstalled: {
-              const { success, message } = response;
-              if (success) {
-                this.packageInstalledPromise.resolve({ successMessage: message });
+              const promise = (_a = this.packageInstalledPromise) == null ? void 0 : _a.get(response.id);
+              Debug.assertIsDefined(promise, "Should find the promise for package install");
+              (_b = this.packageInstalledPromise) == null ? void 0 : _b.delete(response.id);
+              if (response.success) {
+                promise.resolve({ successMessage: response.message });
               } else {
-                this.packageInstalledPromise.reject(message);
+                promise.reject(response.message);
               }
-              this.packageInstalledPromise = void 0;
               this.projectService.updateTypingsForProject(response);
               this.event(response, "setTypings");
               break;

package/lib/typingsInstaller.js

@@ -54,7 +54,7 @@ var path = __toESM(require("path"));
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.4";
-var version = `${versionMajorMinor}.0-insiders.20231115`;
+var version = `${versionMajorMinor}.0-insiders.20231116`;
 
 // src/compiler/core.ts
 var emptyArray = [];
@@ -6168,6 +6168,8 @@ var Diagnostics = {
   This_member_cannot_have_a_JSDoc_comment_with_an_override_tag_because_it_is_not_declared_in_the_base_class_0: diag(4122, 1 /* Error */, "This_member_cannot_have_a_JSDoc_comment_with_an_override_tag_because_it_is_not_declared_in_the_base__4122", "This member cannot have a JSDoc comment with an '@override' tag because it is not declared in the base class '{0}'."),
   This_member_cannot_have_a_JSDoc_comment_with_an_override_tag_because_it_is_not_declared_in_the_base_class_0_Did_you_mean_1: diag(4123, 1 /* Error */, "This_member_cannot_have_a_JSDoc_comment_with_an_override_tag_because_it_is_not_declared_in_the_base__4123", "This member cannot have a JSDoc comment with an 'override' tag because it is not declared in the base class '{0}'. Did you mean '{1}'?"),
   Compiler_option_0_of_value_1_is_unstable_Use_nightly_TypeScript_to_silence_this_error_Try_updating_with_npm_install_D_typescript_next: diag(4124, 1 /* Error */, "Compiler_option_0_of_value_1_is_unstable_Use_nightly_TypeScript_to_silence_this_error_Try_updating_w_4124", "Compiler option '{0}' of value '{1}' is unstable. Use nightly TypeScript to silence this error. Try updating with 'npm install -D typescript@next'."),
+  Each_declaration_of_0_1_differs_in_its_value_where_2_was_expected_but_3_was_given: diag(4125, 1 /* Error */, "Each_declaration_of_0_1_differs_in_its_value_where_2_was_expected_but_3_was_given_4125", "Each declaration of '{0}.{1}' differs in its value, where '{2}' was expected but '{3}' was given."),
+  Values_of_0_1_are_not_sufficiently_known: diag(4126, 1 /* Error */, "Values_of_0_1_are_not_sufficiently_known_4126", "Values of '{0}.{1}' are not sufficiently known."),
   The_current_host_does_not_support_the_0_option: diag(5001, 1 /* Error */, "The_current_host_does_not_support_the_0_option_5001", "The current host does not support the '{0}' option."),
   Cannot_find_the_common_subdirectory_path_for_the_input_files: diag(5009, 1 /* Error */, "Cannot_find_the_common_subdirectory_path_for_the_input_files_5009", "Cannot find the common subdirectory path for the input files."),
   File_specification_cannot_end_in_a_recursive_directory_wildcard_Asterisk_Asterisk_Colon_0: diag(5010, 1 /* Error */, "File_specification_cannot_end_in_a_recursive_directory_wildcard_Asterisk_Asterisk_Colon_0_5010", "File specification cannot end in a recursive directory wildcard ('**'): '{0}'."),
@@ -31947,7 +31949,7 @@ var TypingsInstaller = class {
   }
   /** @internal */
   installPackage(req) {
-    const { fileName, packageName, projectName, projectRootPath } = req;
+    const { fileName, packageName, projectName, projectRootPath, id } = req;
     const cwd = forEachAncestorDirectory(getDirectoryPath(fileName), (directory) => {
       if (this.installTypingHost.fileExists(combinePaths(directory, "package.json"))) {
         return directory;
@@ -31959,6 +31961,7 @@ var TypingsInstaller = class {
         const response = {
           kind: ActionPackageInstalled,
           projectName,
+          id,
           success,
           message
         };
@@ -31968,6 +31971,7 @@ var TypingsInstaller = class {
       const response = {
         kind: ActionPackageInstalled,
         projectName,
+        id,
         success: false,
         message: "Could not determine a project root path."
       };

package/package.json

@@ -2,7 +2,7 @@
   "name": "@typescript-deploys/pr-build",
   "author": "Microsoft Corp.",
   "homepage": "https://www.typescriptlang.org/",
-  "version": "5.4.0-pr-56418-6",
+  "version": "5.4.0-pr-55924-19",
   "license": "Apache-2.0",
   "description": "TypeScript is a language for application scale JavaScript development",
   "keywords": [
@@ -115,5 +115,5 @@
     "node": "20.1.0",
     "npm": "8.19.4"
   },
-  "gitHead": "66b933eedd4e6149c1a51829ee6d2047ff00c8d2"
+  "gitHead": "36d8abbd73baf59639b0f1ee32c9295260063495"
 }