@typescript-deploys/pr-build 5.4.0-pr-49218-45 → 5.4.0-pr-55774-44

package/lib/tsc.js

@@ -54630,6 +54630,14 @@ function createTypeChecker(host) {
     return getCheckFlags(s) & 4096 /* Late */;
   }
   function forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType(type, include, stringsOnly, cb) {
+    if (isTupleType(type)) {
+      forEachType(getUnionType(getElementTypes(type).map((_, i) => getStringLiteralType("" + i))), cb);
+      return;
+    }
+    if (isArrayType(type)) {
+      cb(numberType);
+      return;
+    }
     for (const prop of getPropertiesOfType(type)) {
       cb(getLiteralTypeFromProperty(prop, include));
     }
@@ -56514,7 +56522,7 @@ function createTypeChecker(host) {
         if (constraint) {
           constraints = append(constraints, constraint);
         }
-      } else if (type.flags & 262144 /* TypeParameter */ && parent.kind === 200 /* MappedType */ && node === parent.type) {
+      } else if (type.flags & 262144 /* TypeParameter */ && parent.kind === 200 /* MappedType */ && (node === parent.type || node === parent.nameType)) {
         const mappedType = getTypeFromTypeNode(parent);
         if (getTypeParameterFromMappedType(mappedType) === getActualTypeVariable(type)) {
           const typeParameter = getHomomorphicTypeVariable(mappedType);
@@ -60529,37 +60537,7 @@ function createTypeChecker(host) {
     const restIndex = sourceRestType || targetRestType ? paramCount - 1 : -1;
     for (let i = 0; i < paramCount; i++) {
       const sourceType = i === restIndex ? getRestTypeAtPosition(source, i) : tryGetTypeAtPosition(source, i);
-      let targetType = i === restIndex ? getRestTypeAtPosition(target, i) : tryGetTypeAtPosition(target, i);
-      if (i === restIndex && targetType && sourceType && isTupleType(sourceType)) {
-        targetType = mapType(targetType, (t) => {
-          if (!isTupleType(t) || // When both sides are tuples of the same structure, we don't want to "propagate" types from elements of variable positions
-          // to the following positions as that would disallow signatures of the exact same structures when trailing fixed elements are involved:
-          //
-          // let fn: (...rest: [...string[], number]) => void = (...rest: [...string[], number]) => {}; // ok
-          //
-          // Since we want to allow contextual types to flow into paremeters, we don't need to differentiate between rest and variadic elements
-          // as that doesn't affect the contextual type of the parameter
-          isTupleTypeStructureMatching(sourceType, t, 2 /* MatchVariable */)) {
-            return t;
-          }
-          const elementTypes = [];
-          const elementFlags = [];
-          const sourceArity = getTypeReferenceArity(sourceType);
-          const targetArity = getTypeReferenceArity(t);
-          for (let i2 = 0; i2 < sourceArity; i2++) {
-            if (i2 >= targetArity) {
-              if (sourceType.target.elementFlags[i2] & 3 /* Fixed */) {
-                elementTypes.push(undefinedType);
-                elementFlags.push(sourceType.target.elementFlags[i2]);
-              }
-              continue;
-            }
-            elementTypes.push(getTupleElementType(t, i2));
-            elementFlags.push(sourceType.target.elementFlags[i2]);
-          }
-          return createTupleType(elementTypes, elementFlags);
-        });
-      }
+      const targetType = i === restIndex ? getRestTypeAtPosition(target, i) : tryGetTypeAtPosition(target, i);
       if (sourceType && targetType) {
         const sourceSig = checkMode & 3 /* Callback */ || isInstantiatedGenericParameter(source, i) ? void 0 : getSingleCallSignature(getNonNullableType(sourceType));
         const targetSig = checkMode & 3 /* Callback */ || isInstantiatedGenericParameter(target, i) ? void 0 : getSingleCallSignature(getNonNullableType(targetType));
@@ -63816,11 +63794,8 @@ function createTypeChecker(host) {
     }
     return void 0;
   }
-  function isTupleTypeStructureMatching(t1, t2, tupleStructureComparisonKind) {
-    return getTypeReferenceArity(t1) === getTypeReferenceArity(t2) && every(t1.target.elementFlags, (f1, i) => {
-      const f2 = t2.target.elementFlags[i];
-      return f1 === f2 || !!(tupleStructureComparisonKind & 1 /* MatchFixed */ && f1 & 3 /* Fixed */ && f2 & 3 /* Fixed */) || !!(tupleStructureComparisonKind & 2 /* MatchVariable */ && f1 & 12 /* Variable */ && f2 & 12 /* Variable */);
-    });
+  function isTupleTypeStructureMatching(t1, t2) {
+    return getTypeReferenceArity(t1) === getTypeReferenceArity(t2) && every(t1.target.elementFlags, (f, i) => (f & 12 /* Variable */) === (t2.target.elementFlags[i] & 12 /* Variable */));
   }
   function isZeroBigInt({ value }) {
     return value.base10Value === "0";
@@ -65028,7 +65003,7 @@ function createTypeChecker(host) {
             const targetArity = getTypeReferenceArity(target);
             const elementTypes = getTypeArguments(target);
             const elementFlags = target.target.elementFlags;
-            if (isTupleType(source) && isTupleTypeStructureMatching(source, target, 1 /* MatchFixed */)) {
+            if (isTupleType(source) && isTupleTypeStructureMatching(source, target)) {
               for (let i = 0; i < targetArity; i++) {
                 inferFromTypes(getTypeArguments(source)[i], elementTypes[i]);
               }
@@ -119634,7 +119609,7 @@ function createProgram(rootNamesOrOptions, _options, _host, _oldProgram, _config
         }
         const isFromNodeModulesSearch = resolution.isExternalLibraryImport;
         const isJsFile = !resolutionExtensionIsTSOrJson(resolution.extension);
-        const isJsFileFromNodeModules = isFromNodeModulesSearch && isJsFile;
+        const isJsFileFromNodeModules = isFromNodeModulesSearch && isJsFile && (!resolution.originalPath || pathContainsNodeModules(resolution.resolvedFileName));
         const resolvedFileName = resolution.resolvedFileName;
         if (isFromNodeModulesSearch) {
           currentNodeModulesDepth++;

package/lib/tsserver.js

@@ -59368,6 +59368,14 @@ function createTypeChecker(host) {
     return getCheckFlags(s) & 4096 /* Late */;
   }
   function forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType(type, include, stringsOnly, cb) {
+    if (isTupleType(type)) {
+      forEachType(getUnionType(getElementTypes(type).map((_, i) => getStringLiteralType("" + i))), cb);
+      return;
+    }
+    if (isArrayType(type)) {
+      cb(numberType);
+      return;
+    }
     for (const prop of getPropertiesOfType(type)) {
       cb(getLiteralTypeFromProperty(prop, include));
     }
@@ -61252,7 +61260,7 @@ function createTypeChecker(host) {
         if (constraint) {
           constraints = append(constraints, constraint);
         }
-      } else if (type.flags & 262144 /* TypeParameter */ && parent2.kind === 200 /* MappedType */ && node === parent2.type) {
+      } else if (type.flags & 262144 /* TypeParameter */ && parent2.kind === 200 /* MappedType */ && (node === parent2.type || node === parent2.nameType)) {
         const mappedType = getTypeFromTypeNode(parent2);
         if (getTypeParameterFromMappedType(mappedType) === getActualTypeVariable(type)) {
           const typeParameter = getHomomorphicTypeVariable(mappedType);
@@ -65267,37 +65275,7 @@ function createTypeChecker(host) {
     const restIndex = sourceRestType || targetRestType ? paramCount - 1 : -1;
     for (let i = 0; i < paramCount; i++) {
       const sourceType = i === restIndex ? getRestTypeAtPosition(source, i) : tryGetTypeAtPosition(source, i);
-      let targetType = i === restIndex ? getRestTypeAtPosition(target, i) : tryGetTypeAtPosition(target, i);
-      if (i === restIndex && targetType && sourceType && isTupleType(sourceType)) {
-        targetType = mapType(targetType, (t) => {
-          if (!isTupleType(t) || // When both sides are tuples of the same structure, we don't want to "propagate" types from elements of variable positions
-          // to the following positions as that would disallow signatures of the exact same structures when trailing fixed elements are involved:
-          //
-          // let fn: (...rest: [...string[], number]) => void = (...rest: [...string[], number]) => {}; // ok
-          //
-          // Since we want to allow contextual types to flow into paremeters, we don't need to differentiate between rest and variadic elements
-          // as that doesn't affect the contextual type of the parameter
-          isTupleTypeStructureMatching(sourceType, t, 2 /* MatchVariable */)) {
-            return t;
-          }
-          const elementTypes = [];
-          const elementFlags = [];
-          const sourceArity = getTypeReferenceArity(sourceType);
-          const targetArity = getTypeReferenceArity(t);
-          for (let i2 = 0; i2 < sourceArity; i2++) {
-            if (i2 >= targetArity) {
-              if (sourceType.target.elementFlags[i2] & 3 /* Fixed */) {
-                elementTypes.push(undefinedType);
-                elementFlags.push(sourceType.target.elementFlags[i2]);
-              }
-              continue;
-            }
-            elementTypes.push(getTupleElementType(t, i2));
-            elementFlags.push(sourceType.target.elementFlags[i2]);
-          }
-          return createTupleType(elementTypes, elementFlags);
-        });
-      }
+      const targetType = i === restIndex ? getRestTypeAtPosition(target, i) : tryGetTypeAtPosition(target, i);
       if (sourceType && targetType) {
         const sourceSig = checkMode & 3 /* Callback */ || isInstantiatedGenericParameter(source, i) ? void 0 : getSingleCallSignature(getNonNullableType(sourceType));
         const targetSig = checkMode & 3 /* Callback */ || isInstantiatedGenericParameter(target, i) ? void 0 : getSingleCallSignature(getNonNullableType(targetType));
@@ -68554,11 +68532,8 @@ function createTypeChecker(host) {
     }
     return void 0;
   }
-  function isTupleTypeStructureMatching(t1, t2, tupleStructureComparisonKind) {
-    return getTypeReferenceArity(t1) === getTypeReferenceArity(t2) && every(t1.target.elementFlags, (f1, i) => {
-      const f2 = t2.target.elementFlags[i];
-      return f1 === f2 || !!(tupleStructureComparisonKind & 1 /* MatchFixed */ && f1 & 3 /* Fixed */ && f2 & 3 /* Fixed */) || !!(tupleStructureComparisonKind & 2 /* MatchVariable */ && f1 & 12 /* Variable */ && f2 & 12 /* Variable */);
-    });
+  function isTupleTypeStructureMatching(t1, t2) {
+    return getTypeReferenceArity(t1) === getTypeReferenceArity(t2) && every(t1.target.elementFlags, (f, i) => (f & 12 /* Variable */) === (t2.target.elementFlags[i] & 12 /* Variable */));
   }
   function isZeroBigInt({ value }) {
     return value.base10Value === "0";
@@ -69766,7 +69741,7 @@ function createTypeChecker(host) {
             const targetArity = getTypeReferenceArity(target);
             const elementTypes = getTypeArguments(target);
             const elementFlags = target.target.elementFlags;
-            if (isTupleType(source) && isTupleTypeStructureMatching(source, target, 1 /* MatchFixed */)) {
+            if (isTupleType(source) && isTupleTypeStructureMatching(source, target)) {
               for (let i = 0; i < targetArity; i++) {
                 inferFromTypes(getTypeArguments(source)[i], elementTypes[i]);
               }
@@ -124597,7 +124572,7 @@ function createProgram(rootNamesOrOptions, _options, _host, _oldProgram, _config
         }
         const isFromNodeModulesSearch = resolution.isExternalLibraryImport;
         const isJsFile = !resolutionExtensionIsTSOrJson(resolution.extension);
-        const isJsFileFromNodeModules = isFromNodeModulesSearch && isJsFile;
+        const isJsFileFromNodeModules = isFromNodeModulesSearch && isJsFile && (!resolution.originalPath || pathContainsNodeModules(resolution.resolvedFileName));
         const resolvedFileName = resolution.resolvedFileName;
         if (isFromNodeModulesSearch) {
           currentNodeModulesDepth++;

package/lib/typescript.js

@@ -57123,6 +57123,14 @@ ${lanes.join("\n")}
       return getCheckFlags(s) & 4096 /* Late */;
     }
     function forEachMappedTypePropertyKeyTypeAndIndexSignatureKeyType(type, include, stringsOnly, cb) {
+      if (isTupleType(type)) {
+        forEachType(getUnionType(getElementTypes(type).map((_, i) => getStringLiteralType("" + i))), cb);
+        return;
+      }
+      if (isArrayType(type)) {
+        cb(numberType);
+        return;
+      }
       for (const prop of getPropertiesOfType(type)) {
         cb(getLiteralTypeFromProperty(prop, include));
       }
@@ -59007,7 +59015,7 @@ ${lanes.join("\n")}
           if (constraint) {
             constraints = append(constraints, constraint);
           }
-        } else if (type.flags & 262144 /* TypeParameter */ && parent2.kind === 200 /* MappedType */ && node === parent2.type) {
+        } else if (type.flags & 262144 /* TypeParameter */ && parent2.kind === 200 /* MappedType */ && (node === parent2.type || node === parent2.nameType)) {
           const mappedType = getTypeFromTypeNode(parent2);
           if (getTypeParameterFromMappedType(mappedType) === getActualTypeVariable(type)) {
             const typeParameter = getHomomorphicTypeVariable(mappedType);
@@ -63022,37 +63030,7 @@ ${lanes.join("\n")}
       const restIndex = sourceRestType || targetRestType ? paramCount - 1 : -1;
       for (let i = 0; i < paramCount; i++) {
         const sourceType = i === restIndex ? getRestTypeAtPosition(source, i) : tryGetTypeAtPosition(source, i);
-        let targetType = i === restIndex ? getRestTypeAtPosition(target, i) : tryGetTypeAtPosition(target, i);
-        if (i === restIndex && targetType && sourceType && isTupleType(sourceType)) {
-          targetType = mapType(targetType, (t) => {
-            if (!isTupleType(t) || // When both sides are tuples of the same structure, we don't want to "propagate" types from elements of variable positions
-            // to the following positions as that would disallow signatures of the exact same structures when trailing fixed elements are involved:
-            //
-            // let fn: (...rest: [...string[], number]) => void = (...rest: [...string[], number]) => {}; // ok
-            //
-            // Since we want to allow contextual types to flow into paremeters, we don't need to differentiate between rest and variadic elements
-            // as that doesn't affect the contextual type of the parameter
-            isTupleTypeStructureMatching(sourceType, t, 2 /* MatchVariable */)) {
-              return t;
-            }
-            const elementTypes = [];
-            const elementFlags = [];
-            const sourceArity = getTypeReferenceArity(sourceType);
-            const targetArity = getTypeReferenceArity(t);
-            for (let i2 = 0; i2 < sourceArity; i2++) {
-              if (i2 >= targetArity) {
-                if (sourceType.target.elementFlags[i2] & 3 /* Fixed */) {
-                  elementTypes.push(undefinedType);
-                  elementFlags.push(sourceType.target.elementFlags[i2]);
-                }
-                continue;
-              }
-              elementTypes.push(getTupleElementType(t, i2));
-              elementFlags.push(sourceType.target.elementFlags[i2]);
-            }
-            return createTupleType(elementTypes, elementFlags);
-          });
-        }
+        const targetType = i === restIndex ? getRestTypeAtPosition(target, i) : tryGetTypeAtPosition(target, i);
         if (sourceType && targetType) {
           const sourceSig = checkMode & 3 /* Callback */ || isInstantiatedGenericParameter(source, i) ? void 0 : getSingleCallSignature(getNonNullableType(sourceType));
           const targetSig = checkMode & 3 /* Callback */ || isInstantiatedGenericParameter(target, i) ? void 0 : getSingleCallSignature(getNonNullableType(targetType));
@@ -66309,11 +66287,8 @@ ${lanes.join("\n")}
       }
       return void 0;
     }
-    function isTupleTypeStructureMatching(t1, t2, tupleStructureComparisonKind) {
-      return getTypeReferenceArity(t1) === getTypeReferenceArity(t2) && every(t1.target.elementFlags, (f1, i) => {
-        const f2 = t2.target.elementFlags[i];
-        return f1 === f2 || !!(tupleStructureComparisonKind & 1 /* MatchFixed */ && f1 & 3 /* Fixed */ && f2 & 3 /* Fixed */) || !!(tupleStructureComparisonKind & 2 /* MatchVariable */ && f1 & 12 /* Variable */ && f2 & 12 /* Variable */);
-      });
+    function isTupleTypeStructureMatching(t1, t2) {
+      return getTypeReferenceArity(t1) === getTypeReferenceArity(t2) && every(t1.target.elementFlags, (f, i) => (f & 12 /* Variable */) === (t2.target.elementFlags[i] & 12 /* Variable */));
     }
     function isZeroBigInt({ value }) {
       return value.base10Value === "0";
@@ -67521,7 +67496,7 @@ ${lanes.join("\n")}
               const targetArity = getTypeReferenceArity(target);
               const elementTypes = getTypeArguments(target);
               const elementFlags = target.target.elementFlags;
-              if (isTupleType(source) && isTupleTypeStructureMatching(source, target, 1 /* MatchFixed */)) {
+              if (isTupleType(source) && isTupleTypeStructureMatching(source, target)) {
                 for (let i = 0; i < targetArity; i++) {
                   inferFromTypes(getTypeArguments(source)[i], elementTypes[i]);
                 }
@@ -122570,7 +122545,7 @@ ${lanes.join("\n")}
           }
           const isFromNodeModulesSearch = resolution.isExternalLibraryImport;
           const isJsFile = !resolutionExtensionIsTSOrJson(resolution.extension);
-          const isJsFileFromNodeModules = isFromNodeModulesSearch && isJsFile;
+          const isJsFileFromNodeModules = isFromNodeModulesSearch && isJsFile && (!resolution.originalPath || pathContainsNodeModules(resolution.resolvedFileName));
           const resolvedFileName = resolution.resolvedFileName;
           if (isFromNodeModulesSearch) {
             currentNodeModulesDepth++;

package/package.json

@@ -2,7 +2,7 @@
   "name": "@typescript-deploys/pr-build",
   "author": "Microsoft Corp.",
   "homepage": "https://www.typescriptlang.org/",
-  "version": "5.4.0-pr-49218-45",
+  "version": "5.4.0-pr-55774-44",
   "license": "Apache-2.0",
   "description": "TypeScript is a language for application scale JavaScript development",
   "keywords": [
@@ -114,5 +114,5 @@
     "node": "20.1.0",
     "npm": "8.19.4"
   },
-  "gitHead": "624e31924d903e31deffbf8358ff7d517e1a6ec3"
+  "gitHead": "2f017b81f44276be0e5b6b37fe6c609f52eae6c4"
 }