@typescript-deploys/pr-build 5.3.0-pr-55476-8 → 5.3.0-pr-55371-11

package/lib/tsc.js

@@ -18,7 +18,7 @@ and limitations under the License.
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.3";
-var version = `${versionMajorMinor}.0-insiders.20230823`;
+var version = `${versionMajorMinor}.0-insiders.20230824`;
 
 // src/compiler/core.ts
 var emptyArray = [];
@@ -11839,7 +11839,7 @@ var getScriptTargetFeatures = /* @__PURE__ */ memoize(
         "defineProperty",
         "deleteProperty",
         "get",
-        " getOwnPropertyDescriptor",
+        "getOwnPropertyDescriptor",
         "getPrototypeOf",
         "has",
         "isExtensible",
@@ -29967,7 +29967,9 @@ var Parser;
     let dotDotDotToken;
     let expression;
     if (token() !== 20 /* CloseBraceToken */) {
-      dotDotDotToken = parseOptionalToken(26 /* DotDotDotToken */);
+      if (!inExpressionContext) {
+        dotDotDotToken = parseOptionalToken(26 /* DotDotDotToken */);
+      }
       expression = parseExpression();
     }
     if (inExpressionContext) {
@@ -44418,6 +44420,9 @@ function createTypeChecker(host) {
       const sourceFiles = host.getSourceFiles();
       return sourceFiles.indexOf(declarationFile) <= sourceFiles.indexOf(useFile);
     }
+    if (!!(usage.flags & 16777216 /* JSDoc */) || isInTypeQuery(usage) || isInAmbientOrTypeNode(usage)) {
+      return true;
+    }
     if (declaration.pos <= usage.pos && !(isPropertyDeclaration(declaration) && isThisProperty(usage.parent) && !declaration.initializer && !declaration.exclamationToken)) {
       if (declaration.kind === 208 /* BindingElement */) {
         const errorBindingElement = getAncestor(usage, 208 /* BindingElement */);
@@ -44447,9 +44452,6 @@ function createTypeChecker(host) {
     if (usage.kind === 277 /* ExportAssignment */ && usage.isExportEquals) {
       return true;
     }
-    if (!!(usage.flags & 16777216 /* JSDoc */) || isInTypeQuery(usage) || isInAmbientOrTypeNode(usage)) {
-      return true;
-    }
     if (isUsedInFunctionOrInstanceProperty(usage, declaration)) {
       if (emitStandardClassFields && getContainingClass(declaration) && (isPropertyDeclaration(declaration) || isParameterPropertyDeclaration(declaration, declaration.parent))) {
         return !isPropertyImmediatelyReferencedWithinDeclaration(
@@ -50659,8 +50661,8 @@ function createTypeChecker(host) {
                   });
                 }
               });
-              Debug.assert(setter && isFunctionLikeDeclaration(setter));
-              const paramSymbol = getSignatureFromDeclaration(setter).parameters[0];
+              Debug.assert(!!setter);
+              const paramSymbol = isFunctionLikeDeclaration(setter) ? getSignatureFromDeclaration(setter).parameters[0] : void 0;
               result.push(setTextRange(
                 factory.createSetAccessorDeclaration(
                   factory.createModifiersFromModifierFlags(flag),
@@ -51436,7 +51438,7 @@ function createTypeChecker(host) {
     const pattern = declaration.parent;
     if (strictNullChecks && declaration.flags & 33554432 /* Ambient */ && isParameterDeclaration(declaration)) {
       parentType = getNonNullableType(parentType);
-    } else if (strictNullChecks && pattern.parent.initializer && !(getTypeFacts(getTypeOfInitializer(pattern.parent.initializer)) & 65536 /* EQUndefined */)) {
+    } else if (strictNullChecks && pattern.parent.initializer && !hasTypeFacts(getTypeOfInitializer(pattern.parent.initializer), 65536 /* EQUndefined */)) {
       parentType = getTypeWithFacts(parentType, 524288 /* NEUndefined */);
     }
     let type;
@@ -51479,7 +51481,7 @@ function createTypeChecker(host) {
       return type;
     }
     if (getEffectiveTypeAnnotationNode(walkUpBindingElementsAndPatterns(declaration))) {
-      return strictNullChecks && !(getTypeFacts(checkDeclarationInitializer(declaration, 0 /* Normal */)) & 16777216 /* IsUndefined */) ? getNonUndefinedType(type) : type;
+      return strictNullChecks && !hasTypeFacts(checkDeclarationInitializer(declaration, 0 /* Normal */), 16777216 /* IsUndefined */) ? getNonUndefinedType(type) : type;
     }
     return widenTypeInferredFromInitializer(declaration, getUnionType([getNonUndefinedType(type), checkDeclarationInitializer(declaration, 0 /* Normal */)], 2 /* Subtype */));
   }
@@ -59587,7 +59589,7 @@ function createTypeChecker(host) {
       if (sourceType && targetType) {
         const sourceSig = checkMode & 3 /* Callback */ ? void 0 : getSingleCallSignature(getNonNullableType(sourceType));
         const targetSig = checkMode & 3 /* Callback */ ? void 0 : getSingleCallSignature(getNonNullableType(targetType));
-        const callbacks = sourceSig && targetSig && !getTypePredicateOfSignature(sourceSig) && !getTypePredicateOfSignature(targetSig) && (getTypeFacts(sourceType) & 50331648 /* IsUndefinedOrNull */) === (getTypeFacts(targetType) & 50331648 /* IsUndefinedOrNull */);
+        const callbacks = sourceSig && targetSig && !getTypePredicateOfSignature(sourceSig) && !getTypePredicateOfSignature(targetSig) && getTypeFacts(sourceType, 50331648 /* IsUndefinedOrNull */) === getTypeFacts(targetType, 50331648 /* IsUndefinedOrNull */);
         let related = callbacks ? compareSignaturesRelated(targetSig, sourceSig, checkMode & 8 /* StrictArity */ | (strictVariance ? 2 /* StrictCallback */ : 1 /* BivariantCallback */), reportErrors2, errorReporter, incompatibleErrorReporter, compareTypes, reportUnreliableMarkers) : !(checkMode & 3 /* Callback */) && !strictVariance && compareTypes(
           sourceType,
           targetType,
@@ -61223,6 +61225,9 @@ function createTypeChecker(host) {
           }
           instantiateType(source2, reportUnreliableMapper);
         }
+        if (isTemplateLiteralTypeWithSinglePlaceholderAndNoExtraTexts(target2) && isTypeAssignableTo(source2, stringType) && isTypeAssignableTo(target2.types[0], stringType)) {
+          return isRelatedTo(source2, target2.types[0], 3 /* Both */, reportErrors2);
+        }
         if (isTypeMatchedByTemplateLiteralType(source2, target2)) {
           return -1 /* True */;
         }
@@ -61273,6 +61278,9 @@ function createTypeChecker(host) {
         }
       } else if (sourceFlags & 134217728 /* TemplateLiteral */ && !(targetFlags & 524288 /* Object */)) {
         if (!(targetFlags & 134217728 /* TemplateLiteral */)) {
+          if (isTemplateLiteralTypeWithSinglePlaceholderAndNoExtraTexts(source2) && isTypeAssignableTo(source2.types[0], stringType) && isTypeAssignableTo(target2, stringType)) {
+            return isRelatedTo(source2.types[0], target2, 3 /* Both */, reportErrors2);
+          }
           const constraint = getBaseConstraintOfType(source2);
           if (constraint && constraint !== source2 && (result2 = isRelatedTo(constraint, target2, 1 /* Source */, reportErrors2))) {
             return result2;
@@ -62744,7 +62752,7 @@ function createTypeChecker(host) {
     return value.base10Value === "0";
   }
   function removeDefinitelyFalsyTypes(type) {
-    return filterType(type, (t) => !!(getTypeFacts(t) & 4194304 /* Truthy */));
+    return filterType(type, (t) => hasTypeFacts(t, 4194304 /* Truthy */));
   }
   function extractDefinitelyFalsyTypes(type) {
     return mapType(type, getDefinitelyFalsyPartOfType);
@@ -63397,6 +63405,13 @@ function createTypeChecker(host) {
     }
     return false;
   }
+  function isTemplateLiteralTypeWithSinglePlaceholderAndNoExtraTexts(type) {
+    if (!(type.flags & 134217728 /* TemplateLiteral */)) {
+      return false;
+    }
+    const texts = type.texts;
+    return texts.length === 2 && texts[0] === "" && texts[1] === "";
+  }
   function isValidTypeForTemplateLiteralPlaceholder(source, target) {
     if (source === target || target.flags & (1 /* Any */ | 4 /* String */)) {
       return true;
@@ -63416,9 +63431,8 @@ function createTypeChecker(host) {
         false
       ) || target.flags & (512 /* BooleanLiteral */ | 98304 /* Nullable */) && value === target.intrinsicName || target.flags & 268435456 /* StringMapping */ && isMemberOfStringMapping(getStringLiteralType(value), target) || target.flags & 134217728 /* TemplateLiteral */ && isTypeMatchedByTemplateLiteralType(source, target));
     }
-    if (source.flags & 134217728 /* TemplateLiteral */) {
-      const texts = source.texts;
-      return texts.length === 2 && texts[0] === "" && texts[1] === "" && isTypeAssignableTo(source.types[0], target);
+    if (isTemplateLiteralTypeWithSinglePlaceholderAndNoExtraTexts(source)) {
+      return isTypeAssignableTo(source.types[0], target);
     }
     return isTypeAssignableTo(source, target);
   }
@@ -64489,7 +64503,13 @@ function createTypeChecker(host) {
     const resolved = resolveStructuredTypeMembers(type);
     return !!(resolved.callSignatures.length || resolved.constructSignatures.length || resolved.members.get("bind") && isTypeSubtypeOf(type, globalFunctionType));
   }
-  function getTypeFacts(type) {
+  function getTypeFacts(type, mask) {
+    return getTypeFactsWorker(type, mask) & mask;
+  }
+  function hasTypeFacts(type, mask) {
+    return getTypeFacts(type, mask) !== 0;
+  }
+  function getTypeFactsWorker(type, callerOnlyNeeds) {
     if (type.flags & (2097152 /* Intersection */ | 465829888 /* Instantiable */)) {
       type = getBaseConstraintOfType(type) || unknownType;
     }
@@ -64522,6 +64542,10 @@ function createTypeChecker(host) {
       return strictNullChecks ? type === falseType || type === regularFalseType ? 12121864 /* FalseStrictFacts */ : 7927560 /* TrueStrictFacts */ : type === falseType || type === regularFalseType ? 12580616 /* FalseFacts */ : 16774920 /* TrueFacts */;
     }
     if (flags & 524288 /* Object */) {
+      const possibleFacts = strictNullChecks ? 83427327 /* EmptyObjectStrictFacts */ | 7880640 /* FunctionStrictFacts */ | 7888800 /* ObjectStrictFacts */ : 83886079 /* EmptyObjectFacts */ | 16728e3 /* FunctionFacts */ | 16736160 /* ObjectFacts */;
+      if ((callerOnlyNeeds & possibleFacts) === 0) {
+        return 0;
+      }
       return getObjectFlags(type) & 16 /* Anonymous */ && isEmptyObjectType(type) ? strictNullChecks ? 83427327 /* EmptyObjectStrictFacts */ : 83886079 /* EmptyObjectFacts */ : isFunctionObjectType(type) ? strictNullChecks ? 7880640 /* FunctionStrictFacts */ : 16728e3 /* FunctionFacts */ : strictNullChecks ? 7888800 /* ObjectStrictFacts */ : 16736160 /* ObjectFacts */;
     }
     if (flags & 16384 /* Void */) {
@@ -64543,20 +64567,20 @@ function createTypeChecker(host) {
       return 0 /* None */;
     }
     if (flags & 1048576 /* Union */) {
-      return reduceLeft(type.types, (facts, t) => facts | getTypeFacts(t), 0 /* None */);
+      return reduceLeft(type.types, (facts, t) => facts | getTypeFactsWorker(t, callerOnlyNeeds), 0 /* None */);
     }
     if (flags & 2097152 /* Intersection */) {
-      return getIntersectionTypeFacts(type);
+      return getIntersectionTypeFacts(type, callerOnlyNeeds);
     }
     return 83886079 /* UnknownFacts */;
   }
-  function getIntersectionTypeFacts(type) {
+  function getIntersectionTypeFacts(type, callerOnlyNeeds) {
     const ignoreObjects = maybeTypeOfKind(type, 402784252 /* Primitive */);
     let oredFacts = 0 /* None */;
     let andedFacts = 134217727 /* All */;
     for (const t of type.types) {
       if (!(ignoreObjects && t.flags & 524288 /* Object */)) {
-        const f = getTypeFacts(t);
+        const f = getTypeFactsWorker(t, callerOnlyNeeds);
         oredFacts |= f;
         andedFacts &= f;
       }
@@ -64564,19 +64588,19 @@ function createTypeChecker(host) {
     return oredFacts & 8256 /* OrFactsMask */ | andedFacts & 134209471 /* AndFactsMask */;
   }
   function getTypeWithFacts(type, include) {
-    return filterType(type, (t) => (getTypeFacts(t) & include) !== 0);
+    return filterType(type, (t) => hasTypeFacts(t, include));
   }
   function getAdjustedTypeWithFacts(type, facts) {
     const reduced = recombineUnknownType(getTypeWithFacts(strictNullChecks && type.flags & 2 /* Unknown */ ? unknownUnionType : type, facts));
     if (strictNullChecks) {
       switch (facts) {
         case 524288 /* NEUndefined */:
-          return mapType(reduced, (t) => getTypeFacts(t) & 65536 /* EQUndefined */ ? getIntersectionType([t, getTypeFacts(t) & 131072 /* EQNull */ && !maybeTypeOfKind(reduced, 65536 /* Null */) ? getUnionType([emptyObjectType, nullType]) : emptyObjectType]) : t);
+          return mapType(reduced, (t) => hasTypeFacts(t, 65536 /* EQUndefined */) ? getIntersectionType([t, hasTypeFacts(t, 131072 /* EQNull */) && !maybeTypeOfKind(reduced, 65536 /* Null */) ? getUnionType([emptyObjectType, nullType]) : emptyObjectType]) : t);
         case 1048576 /* NENull */:
-          return mapType(reduced, (t) => getTypeFacts(t) & 131072 /* EQNull */ ? getIntersectionType([t, getTypeFacts(t) & 65536 /* EQUndefined */ && !maybeTypeOfKind(reduced, 32768 /* Undefined */) ? getUnionType([emptyObjectType, undefinedType]) : emptyObjectType]) : t);
+          return mapType(reduced, (t) => hasTypeFacts(t, 131072 /* EQNull */) ? getIntersectionType([t, hasTypeFacts(t, 65536 /* EQUndefined */) && !maybeTypeOfKind(reduced, 32768 /* Undefined */) ? getUnionType([emptyObjectType, undefinedType]) : emptyObjectType]) : t);
         case 2097152 /* NEUndefinedOrNull */:
         case 4194304 /* Truthy */:
-          return mapType(reduced, (t) => getTypeFacts(t) & 262144 /* EQUndefinedOrNull */ ? getGlobalNonNullableTypeInstantiation(t) : t);
+          return mapType(reduced, (t) => hasTypeFacts(t, 262144 /* EQUndefinedOrNull */) ? getGlobalNonNullableTypeInstantiation(t) : t);
       }
     }
     return reduced;
@@ -65913,14 +65937,14 @@ function createTypeChecker(host) {
         // the constituent based on its type facts. We use the strict subtype relation because it treats `object`
         // as a subtype of `{}`, and we need the type facts check because function types are subtypes of `object`,
         // but are classified as "function" according to `typeof`.
-        isTypeRelatedTo(t, impliedType, strictSubtypeRelation) ? getTypeFacts(t) & facts ? t : neverType : (
+        isTypeRelatedTo(t, impliedType, strictSubtypeRelation) ? hasTypeFacts(t, facts) ? t : neverType : (
           // We next check if the consituent is a supertype of the implied type. If so, we substitute the implied
           // type. This handles top types like `unknown` and `{}`, and supertypes like `{ toString(): string }`.
           isTypeSubtypeOf(impliedType, t) ? impliedType : (
             // Neither the constituent nor the implied type is a subtype of the other, however their domains may still
             // overlap. For example, an unconstrained type parameter and type `string`. If the type facts indicate
             // possible overlap, we form an intersection. Otherwise, we eliminate the constituent.
-            getTypeFacts(t) & facts ? getIntersectionType([t, impliedType]) : neverType
+            hasTypeFacts(t, facts) ? getIntersectionType([t, impliedType]) : neverType
           )
         )
       ));
@@ -65934,7 +65958,7 @@ function createTypeChecker(host) {
       const hasDefaultClause = clauseStart === clauseEnd || defaultIndex >= clauseStart && defaultIndex < clauseEnd;
       if (hasDefaultClause) {
         const notEqualFacts = getNotEqualFactsFromTypeofSwitch(clauseStart, clauseEnd, witnesses);
-        return filterType(type, (t) => (getTypeFacts(t) & notEqualFacts) === notEqualFacts);
+        return filterType(type, (t) => getTypeFacts(t, notEqualFacts) === notEqualFacts);
       }
       const clauseWitnesses = witnesses.slice(clauseStart, clauseEnd);
       return getUnionType(map(clauseWitnesses, (text) => text ? narrowTypeByTypeName(type, text) : neverType));
@@ -66072,7 +66096,7 @@ function createTypeChecker(host) {
               false
             );
           }
-          if (strictNullChecks && assumeTrue && optionalChainContainsReference(predicateArgument, reference) && !(getTypeFacts(predicate.type) & 65536 /* EQUndefined */)) {
+          if (strictNullChecks && assumeTrue && optionalChainContainsReference(predicateArgument, reference) && !hasTypeFacts(predicate.type, 65536 /* EQUndefined */)) {
             type = getAdjustedTypeWithFacts(type, 2097152 /* NEUndefinedOrNull */);
           }
           const access = getDiscriminantPropertyAccess(predicateArgument, type);
@@ -66206,7 +66230,7 @@ function createTypeChecker(host) {
         reportCircularityError(declaration.symbol);
         return true;
       }
-      const containsUndefined = !!(getTypeFacts(checkDeclarationInitializer(declaration, 0 /* Normal */)) & 16777216 /* IsUndefined */);
+      const containsUndefined = !!hasTypeFacts(checkDeclarationInitializer(declaration, 0 /* Normal */), 16777216 /* IsUndefined */);
       if (!popTypeResolution()) {
         reportCircularityError(declaration.symbol);
         return true;
@@ -66216,7 +66240,7 @@ function createTypeChecker(host) {
     return links.parameterInitializerContainsUndefined;
   }
   function removeOptionalityFromDeclaredType(declaredType, declaration) {
-    const removeUndefined = strictNullChecks && declaration.kind === 169 /* Parameter */ && declaration.initializer && getTypeFacts(declaredType) & 16777216 /* IsUndefined */ && !parameterInitializerContainsUndefined(declaration);
+    const removeUndefined = strictNullChecks && declaration.kind === 169 /* Parameter */ && declaration.initializer && hasTypeFacts(declaredType, 16777216 /* IsUndefined */) && !parameterInitializerContainsUndefined(declaration);
     return removeUndefined ? getTypeWithFacts(declaredType, 524288 /* NEUndefined */) : declaredType;
   }
   function isConstraintPosition(type, node) {
@@ -69046,7 +69070,7 @@ function createTypeChecker(host) {
     return checkNonNullType(checkExpression(node), node);
   }
   function isNullableType(type) {
-    return !!(getTypeFacts(type) & 50331648 /* IsUndefinedOrNull */);
+    return hasTypeFacts(type, 50331648 /* IsUndefinedOrNull */);
   }
   function getNonNullableTypeIfNeeded(type) {
     return isNullableType(type) ? getNonNullableType(type) : type;
@@ -69092,7 +69116,7 @@ function createTypeChecker(host) {
       error(node, Diagnostics.Object_is_of_type_unknown);
       return errorType;
     }
-    const facts = getTypeFacts(type);
+    const facts = getTypeFacts(type, 50331648 /* IsUndefinedOrNull */);
     if (facts & 50331648 /* IsUndefinedOrNull */) {
       reportError(node, facts);
       const t = getNonNullableType(type);
@@ -72872,7 +72896,7 @@ function createTypeChecker(host) {
       if (operandConstraint.flags & 3 /* AnyOrUnknown */) {
         return (556800 /* AllTypeofNE */ & notEqualFacts) === 556800 /* AllTypeofNE */;
       }
-      return !someType(operandConstraint, (t) => (getTypeFacts(t) & notEqualFacts) === notEqualFacts);
+      return !someType(operandConstraint, (t) => getTypeFacts(t, notEqualFacts) === notEqualFacts);
     }
     const type = checkExpressionCached(node.expression);
     if (!isLiteralType(type)) {
@@ -73190,14 +73214,15 @@ function createTypeChecker(host) {
     if (symbol) {
       if (isReadonlySymbol(symbol)) {
         error(expr, Diagnostics.The_operand_of_a_delete_operator_cannot_be_a_read_only_property);
+      } else {
+        checkDeleteExpressionMustBeOptional(expr, symbol);
       }
-      checkDeleteExpressionMustBeOptional(expr, symbol);
     }
     return booleanType;
   }
   function checkDeleteExpressionMustBeOptional(expr, symbol) {
     const type = getTypeOfSymbol(symbol);
-    if (strictNullChecks && !(type.flags & (3 /* AnyOrUnknown */ | 131072 /* Never */)) && !(exactOptionalPropertyTypes ? symbol.flags & 16777216 /* Optional */ : getTypeFacts(type) & 16777216 /* IsUndefined */)) {
+    if (strictNullChecks && !(type.flags & (3 /* AnyOrUnknown */ | 131072 /* Never */)) && !(exactOptionalPropertyTypes ? symbol.flags & 16777216 /* Optional */ : hasTypeFacts(type, 16777216 /* IsUndefined */))) {
       error(expr, Diagnostics.The_operand_of_a_delete_operator_must_be_optional);
     }
   }
@@ -73332,7 +73357,7 @@ function createTypeChecker(host) {
         return getUnaryResultType(operandType);
       case 54 /* ExclamationToken */:
         checkTruthinessOfType(operandType, node.operand);
-        const facts = getTypeFacts(operandType) & (4194304 /* Truthy */ | 8388608 /* Falsy */);
+        const facts = getTypeFacts(operandType, 4194304 /* Truthy */ | 8388608 /* Falsy */);
         return facts === 4194304 /* Truthy */ ? falseType : facts === 8388608 /* Falsy */ ? trueType : booleanType;
       case 46 /* PlusPlusToken */:
       case 47 /* MinusMinusToken */:
@@ -73563,7 +73588,7 @@ function createTypeChecker(host) {
     if (exprOrAssignment.kind === 304 /* ShorthandPropertyAssignment */) {
       const prop = exprOrAssignment;
       if (prop.objectAssignmentInitializer) {
-        if (strictNullChecks && !(getTypeFacts(checkExpression(prop.objectAssignmentInitializer)) & 16777216 /* IsUndefined */)) {
+        if (strictNullChecks && !hasTypeFacts(checkExpression(prop.objectAssignmentInitializer), 16777216 /* IsUndefined */)) {
           sourceType = getTypeWithFacts(sourceType, 524288 /* NEUndefined */);
         }
         checkBinaryLikeExpression(prop.name, prop.equalsToken, prop.objectAssignmentInitializer, checkMode);
@@ -73975,7 +74000,7 @@ function createTypeChecker(host) {
         return checkInExpression(left, right, leftType, rightType);
       case 56 /* AmpersandAmpersandToken */:
       case 77 /* AmpersandAmpersandEqualsToken */: {
-        const resultType2 = getTypeFacts(leftType) & 4194304 /* Truthy */ ? getUnionType([extractDefinitelyFalsyTypes(strictNullChecks ? leftType : getBaseTypeOfLiteralType(rightType)), rightType]) : leftType;
+        const resultType2 = hasTypeFacts(leftType, 4194304 /* Truthy */) ? getUnionType([extractDefinitelyFalsyTypes(strictNullChecks ? leftType : getBaseTypeOfLiteralType(rightType)), rightType]) : leftType;
         if (operator === 77 /* AmpersandAmpersandEqualsToken */) {
           checkAssignmentOperator(rightType);
         }
@@ -73983,7 +74008,7 @@ function createTypeChecker(host) {
       }
       case 57 /* BarBarToken */:
       case 76 /* BarBarEqualsToken */: {
-        const resultType2 = getTypeFacts(leftType) & 8388608 /* Falsy */ ? getUnionType([getNonNullableType(removeDefinitelyFalsyTypes(leftType)), rightType], 2 /* Subtype */) : leftType;
+        const resultType2 = hasTypeFacts(leftType, 8388608 /* Falsy */) ? getUnionType([getNonNullableType(removeDefinitelyFalsyTypes(leftType)), rightType], 2 /* Subtype */) : leftType;
         if (operator === 76 /* BarBarEqualsToken */) {
           checkAssignmentOperator(rightType);
         }
@@ -73991,7 +74016,7 @@ function createTypeChecker(host) {
       }
       case 61 /* QuestionQuestionToken */:
       case 78 /* QuestionQuestionEqualsToken */: {
-        const resultType2 = getTypeFacts(leftType) & 262144 /* EQUndefinedOrNull */ ? getUnionType([getNonNullableType(leftType), rightType], 2 /* Subtype */) : leftType;
+        const resultType2 = hasTypeFacts(leftType, 262144 /* EQUndefinedOrNull */) ? getUnionType([getNonNullableType(leftType), rightType], 2 /* Subtype */) : leftType;
         if (operator === 78 /* QuestionQuestionEqualsToken */) {
           checkAssignmentOperator(rightType);
         }
@@ -77308,7 +77333,7 @@ function createTypeChecker(host) {
       }
       const type = location === condExpr2 ? condType : checkTruthinessExpression(location);
       const isPropertyExpressionCast = isPropertyAccessExpression(location) && isTypeAssertion(location.expression);
-      if (!(getTypeFacts(type) & 4194304 /* Truthy */) || isPropertyExpressionCast)
+      if (!hasTypeFacts(type, 4194304 /* Truthy */) || isPropertyExpressionCast)
         return;
       const callSignatures = getSignaturesOfType(type, 0 /* Call */);
       const isPromise = !!getAwaitedTypeOfPromise(type);

package/lib/tsserver.js

@@ -2333,7 +2333,7 @@ module.exports = __toCommonJS(server_exports);
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.3";
-var version = `${versionMajorMinor}.0-insiders.20230823`;
+var version = `${versionMajorMinor}.0-insiders.20230824`;
 var Comparison = /* @__PURE__ */ ((Comparison3) => {
   Comparison3[Comparison3["LessThan"] = -1] = "LessThan";
   Comparison3[Comparison3["EqualTo"] = 0] = "EqualTo";
@@ -15609,7 +15609,7 @@ var getScriptTargetFeatures = /* @__PURE__ */ memoize(
         "defineProperty",
         "deleteProperty",
         "get",
-        " getOwnPropertyDescriptor",
+        "getOwnPropertyDescriptor",
         "getPrototypeOf",
         "has",
         "isExtensible",
@@ -34369,7 +34369,9 @@ var Parser;
     let dotDotDotToken;
     let expression;
     if (token() !== 20 /* CloseBraceToken */) {
-      dotDotDotToken = parseOptionalToken(26 /* DotDotDotToken */);
+      if (!inExpressionContext) {
+        dotDotDotToken = parseOptionalToken(26 /* DotDotDotToken */);
+      }
       expression = parseExpression();
     }
     if (inExpressionContext) {
@@ -49126,6 +49128,9 @@ function createTypeChecker(host) {
       const sourceFiles = host.getSourceFiles();
       return sourceFiles.indexOf(declarationFile) <= sourceFiles.indexOf(useFile);
     }
+    if (!!(usage.flags & 16777216 /* JSDoc */) || isInTypeQuery(usage) || isInAmbientOrTypeNode(usage)) {
+      return true;
+    }
     if (declaration.pos <= usage.pos && !(isPropertyDeclaration(declaration) && isThisProperty(usage.parent) && !declaration.initializer && !declaration.exclamationToken)) {
       if (declaration.kind === 208 /* BindingElement */) {
         const errorBindingElement = getAncestor(usage, 208 /* BindingElement */);
@@ -49155,9 +49160,6 @@ function createTypeChecker(host) {
     if (usage.kind === 277 /* ExportAssignment */ && usage.isExportEquals) {
       return true;
     }
-    if (!!(usage.flags & 16777216 /* JSDoc */) || isInTypeQuery(usage) || isInAmbientOrTypeNode(usage)) {
-      return true;
-    }
     if (isUsedInFunctionOrInstanceProperty(usage, declaration)) {
       if (emitStandardClassFields && getContainingClass(declaration) && (isPropertyDeclaration(declaration) || isParameterPropertyDeclaration(declaration, declaration.parent))) {
         return !isPropertyImmediatelyReferencedWithinDeclaration(
@@ -55367,8 +55369,8 @@ function createTypeChecker(host) {
                   });
                 }
               });
-              Debug.assert(setter && isFunctionLikeDeclaration(setter));
-              const paramSymbol = getSignatureFromDeclaration(setter).parameters[0];
+              Debug.assert(!!setter);
+              const paramSymbol = isFunctionLikeDeclaration(setter) ? getSignatureFromDeclaration(setter).parameters[0] : void 0;
               result.push(setTextRange(
                 factory.createSetAccessorDeclaration(
                   factory.createModifiersFromModifierFlags(flag),
@@ -56144,7 +56146,7 @@ function createTypeChecker(host) {
     const pattern = declaration.parent;
     if (strictNullChecks && declaration.flags & 33554432 /* Ambient */ && isParameterDeclaration(declaration)) {
       parentType = getNonNullableType(parentType);
-    } else if (strictNullChecks && pattern.parent.initializer && !(getTypeFacts(getTypeOfInitializer(pattern.parent.initializer)) & 65536 /* EQUndefined */)) {
+    } else if (strictNullChecks && pattern.parent.initializer && !hasTypeFacts(getTypeOfInitializer(pattern.parent.initializer), 65536 /* EQUndefined */)) {
       parentType = getTypeWithFacts(parentType, 524288 /* NEUndefined */);
     }
     let type;
@@ -56187,7 +56189,7 @@ function createTypeChecker(host) {
       return type;
     }
     if (getEffectiveTypeAnnotationNode(walkUpBindingElementsAndPatterns(declaration))) {
-      return strictNullChecks && !(getTypeFacts(checkDeclarationInitializer(declaration, 0 /* Normal */)) & 16777216 /* IsUndefined */) ? getNonUndefinedType(type) : type;
+      return strictNullChecks && !hasTypeFacts(checkDeclarationInitializer(declaration, 0 /* Normal */), 16777216 /* IsUndefined */) ? getNonUndefinedType(type) : type;
     }
     return widenTypeInferredFromInitializer(declaration, getUnionType([getNonUndefinedType(type), checkDeclarationInitializer(declaration, 0 /* Normal */)], 2 /* Subtype */));
   }
@@ -64295,7 +64297,7 @@ function createTypeChecker(host) {
       if (sourceType && targetType) {
         const sourceSig = checkMode & 3 /* Callback */ ? void 0 : getSingleCallSignature(getNonNullableType(sourceType));
         const targetSig = checkMode & 3 /* Callback */ ? void 0 : getSingleCallSignature(getNonNullableType(targetType));
-        const callbacks = sourceSig && targetSig && !getTypePredicateOfSignature(sourceSig) && !getTypePredicateOfSignature(targetSig) && (getTypeFacts(sourceType) & 50331648 /* IsUndefinedOrNull */) === (getTypeFacts(targetType) & 50331648 /* IsUndefinedOrNull */);
+        const callbacks = sourceSig && targetSig && !getTypePredicateOfSignature(sourceSig) && !getTypePredicateOfSignature(targetSig) && getTypeFacts(sourceType, 50331648 /* IsUndefinedOrNull */) === getTypeFacts(targetType, 50331648 /* IsUndefinedOrNull */);
         let related = callbacks ? compareSignaturesRelated(targetSig, sourceSig, checkMode & 8 /* StrictArity */ | (strictVariance ? 2 /* StrictCallback */ : 1 /* BivariantCallback */), reportErrors2, errorReporter, incompatibleErrorReporter, compareTypes, reportUnreliableMarkers) : !(checkMode & 3 /* Callback */) && !strictVariance && compareTypes(
           sourceType,
           targetType,
@@ -65931,6 +65933,9 @@ function createTypeChecker(host) {
           }
           instantiateType(source2, reportUnreliableMapper);
         }
+        if (isTemplateLiteralTypeWithSinglePlaceholderAndNoExtraTexts(target2) && isTypeAssignableTo(source2, stringType) && isTypeAssignableTo(target2.types[0], stringType)) {
+          return isRelatedTo(source2, target2.types[0], 3 /* Both */, reportErrors2);
+        }
         if (isTypeMatchedByTemplateLiteralType(source2, target2)) {
           return -1 /* True */;
         }
@@ -65981,6 +65986,9 @@ function createTypeChecker(host) {
         }
       } else if (sourceFlags & 134217728 /* TemplateLiteral */ && !(targetFlags & 524288 /* Object */)) {
         if (!(targetFlags & 134217728 /* TemplateLiteral */)) {
+          if (isTemplateLiteralTypeWithSinglePlaceholderAndNoExtraTexts(source2) && isTypeAssignableTo(source2.types[0], stringType) && isTypeAssignableTo(target2, stringType)) {
+            return isRelatedTo(source2.types[0], target2, 3 /* Both */, reportErrors2);
+          }
           const constraint = getBaseConstraintOfType(source2);
           if (constraint && constraint !== source2 && (result2 = isRelatedTo(constraint, target2, 1 /* Source */, reportErrors2))) {
             return result2;
@@ -67452,7 +67460,7 @@ function createTypeChecker(host) {
     return value.base10Value === "0";
   }
   function removeDefinitelyFalsyTypes(type) {
-    return filterType(type, (t) => !!(getTypeFacts(t) & 4194304 /* Truthy */));
+    return filterType(type, (t) => hasTypeFacts(t, 4194304 /* Truthy */));
   }
   function extractDefinitelyFalsyTypes(type) {
     return mapType(type, getDefinitelyFalsyPartOfType);
@@ -68105,6 +68113,13 @@ function createTypeChecker(host) {
     }
     return false;
   }
+  function isTemplateLiteralTypeWithSinglePlaceholderAndNoExtraTexts(type) {
+    if (!(type.flags & 134217728 /* TemplateLiteral */)) {
+      return false;
+    }
+    const texts = type.texts;
+    return texts.length === 2 && texts[0] === "" && texts[1] === "";
+  }
   function isValidTypeForTemplateLiteralPlaceholder(source, target) {
     if (source === target || target.flags & (1 /* Any */ | 4 /* String */)) {
       return true;
@@ -68124,9 +68139,8 @@ function createTypeChecker(host) {
         false
       ) || target.flags & (512 /* BooleanLiteral */ | 98304 /* Nullable */) && value === target.intrinsicName || target.flags & 268435456 /* StringMapping */ && isMemberOfStringMapping(getStringLiteralType(value), target) || target.flags & 134217728 /* TemplateLiteral */ && isTypeMatchedByTemplateLiteralType(source, target));
     }
-    if (source.flags & 134217728 /* TemplateLiteral */) {
-      const texts = source.texts;
-      return texts.length === 2 && texts[0] === "" && texts[1] === "" && isTypeAssignableTo(source.types[0], target);
+    if (isTemplateLiteralTypeWithSinglePlaceholderAndNoExtraTexts(source)) {
+      return isTypeAssignableTo(source.types[0], target);
     }
     return isTypeAssignableTo(source, target);
   }
@@ -69197,7 +69211,13 @@ function createTypeChecker(host) {
     const resolved = resolveStructuredTypeMembers(type);
     return !!(resolved.callSignatures.length || resolved.constructSignatures.length || resolved.members.get("bind") && isTypeSubtypeOf(type, globalFunctionType));
   }
-  function getTypeFacts(type) {
+  function getTypeFacts(type, mask2) {
+    return getTypeFactsWorker(type, mask2) & mask2;
+  }
+  function hasTypeFacts(type, mask2) {
+    return getTypeFacts(type, mask2) !== 0;
+  }
+  function getTypeFactsWorker(type, callerOnlyNeeds) {
     if (type.flags & (2097152 /* Intersection */ | 465829888 /* Instantiable */)) {
       type = getBaseConstraintOfType(type) || unknownType;
     }
@@ -69230,6 +69250,10 @@ function createTypeChecker(host) {
       return strictNullChecks ? type === falseType || type === regularFalseType ? 12121864 /* FalseStrictFacts */ : 7927560 /* TrueStrictFacts */ : type === falseType || type === regularFalseType ? 12580616 /* FalseFacts */ : 16774920 /* TrueFacts */;
     }
     if (flags & 524288 /* Object */) {
+      const possibleFacts = strictNullChecks ? 83427327 /* EmptyObjectStrictFacts */ | 7880640 /* FunctionStrictFacts */ | 7888800 /* ObjectStrictFacts */ : 83886079 /* EmptyObjectFacts */ | 16728e3 /* FunctionFacts */ | 16736160 /* ObjectFacts */;
+      if ((callerOnlyNeeds & possibleFacts) === 0) {
+        return 0;
+      }
       return getObjectFlags(type) & 16 /* Anonymous */ && isEmptyObjectType(type) ? strictNullChecks ? 83427327 /* EmptyObjectStrictFacts */ : 83886079 /* EmptyObjectFacts */ : isFunctionObjectType(type) ? strictNullChecks ? 7880640 /* FunctionStrictFacts */ : 16728e3 /* FunctionFacts */ : strictNullChecks ? 7888800 /* ObjectStrictFacts */ : 16736160 /* ObjectFacts */;
     }
     if (flags & 16384 /* Void */) {
@@ -69251,20 +69275,20 @@ function createTypeChecker(host) {
       return 0 /* None */;
     }
     if (flags & 1048576 /* Union */) {
-      return reduceLeft(type.types, (facts, t) => facts | getTypeFacts(t), 0 /* None */);
+      return reduceLeft(type.types, (facts, t) => facts | getTypeFactsWorker(t, callerOnlyNeeds), 0 /* None */);
     }
     if (flags & 2097152 /* Intersection */) {
-      return getIntersectionTypeFacts(type);
+      return getIntersectionTypeFacts(type, callerOnlyNeeds);
     }
     return 83886079 /* UnknownFacts */;
   }
-  function getIntersectionTypeFacts(type) {
+  function getIntersectionTypeFacts(type, callerOnlyNeeds) {
     const ignoreObjects = maybeTypeOfKind(type, 402784252 /* Primitive */);
     let oredFacts = 0 /* None */;
     let andedFacts = 134217727 /* All */;
     for (const t of type.types) {
       if (!(ignoreObjects && t.flags & 524288 /* Object */)) {
-        const f = getTypeFacts(t);
+        const f = getTypeFactsWorker(t, callerOnlyNeeds);
         oredFacts |= f;
         andedFacts &= f;
       }
@@ -69272,19 +69296,19 @@ function createTypeChecker(host) {
     return oredFacts & 8256 /* OrFactsMask */ | andedFacts & 134209471 /* AndFactsMask */;
   }
   function getTypeWithFacts(type, include) {
-    return filterType(type, (t) => (getTypeFacts(t) & include) !== 0);
+    return filterType(type, (t) => hasTypeFacts(t, include));
   }
   function getAdjustedTypeWithFacts(type, facts) {
     const reduced = recombineUnknownType(getTypeWithFacts(strictNullChecks && type.flags & 2 /* Unknown */ ? unknownUnionType : type, facts));
     if (strictNullChecks) {
       switch (facts) {
         case 524288 /* NEUndefined */:
-          return mapType(reduced, (t) => getTypeFacts(t) & 65536 /* EQUndefined */ ? getIntersectionType([t, getTypeFacts(t) & 131072 /* EQNull */ && !maybeTypeOfKind(reduced, 65536 /* Null */) ? getUnionType([emptyObjectType, nullType]) : emptyObjectType]) : t);
+          return mapType(reduced, (t) => hasTypeFacts(t, 65536 /* EQUndefined */) ? getIntersectionType([t, hasTypeFacts(t, 131072 /* EQNull */) && !maybeTypeOfKind(reduced, 65536 /* Null */) ? getUnionType([emptyObjectType, nullType]) : emptyObjectType]) : t);
         case 1048576 /* NENull */:
-          return mapType(reduced, (t) => getTypeFacts(t) & 131072 /* EQNull */ ? getIntersectionType([t, getTypeFacts(t) & 65536 /* EQUndefined */ && !maybeTypeOfKind(reduced, 32768 /* Undefined */) ? getUnionType([emptyObjectType, undefinedType]) : emptyObjectType]) : t);
+          return mapType(reduced, (t) => hasTypeFacts(t, 131072 /* EQNull */) ? getIntersectionType([t, hasTypeFacts(t, 65536 /* EQUndefined */) && !maybeTypeOfKind(reduced, 32768 /* Undefined */) ? getUnionType([emptyObjectType, undefinedType]) : emptyObjectType]) : t);
         case 2097152 /* NEUndefinedOrNull */:
         case 4194304 /* Truthy */:
-          return mapType(reduced, (t) => getTypeFacts(t) & 262144 /* EQUndefinedOrNull */ ? getGlobalNonNullableTypeInstantiation(t) : t);
+          return mapType(reduced, (t) => hasTypeFacts(t, 262144 /* EQUndefinedOrNull */) ? getGlobalNonNullableTypeInstantiation(t) : t);
       }
     }
     return reduced;
@@ -70621,14 +70645,14 @@ function createTypeChecker(host) {
         // the constituent based on its type facts. We use the strict subtype relation because it treats `object`
         // as a subtype of `{}`, and we need the type facts check because function types are subtypes of `object`,
         // but are classified as "function" according to `typeof`.
-        isTypeRelatedTo(t, impliedType, strictSubtypeRelation) ? getTypeFacts(t) & facts ? t : neverType : (
+        isTypeRelatedTo(t, impliedType, strictSubtypeRelation) ? hasTypeFacts(t, facts) ? t : neverType : (
           // We next check if the consituent is a supertype of the implied type. If so, we substitute the implied
           // type. This handles top types like `unknown` and `{}`, and supertypes like `{ toString(): string }`.
           isTypeSubtypeOf(impliedType, t) ? impliedType : (
             // Neither the constituent nor the implied type is a subtype of the other, however their domains may still
             // overlap. For example, an unconstrained type parameter and type `string`. If the type facts indicate
             // possible overlap, we form an intersection. Otherwise, we eliminate the constituent.
-            getTypeFacts(t) & facts ? getIntersectionType([t, impliedType]) : neverType
+            hasTypeFacts(t, facts) ? getIntersectionType([t, impliedType]) : neverType
           )
         )
       ));
@@ -70642,7 +70666,7 @@ function createTypeChecker(host) {
       const hasDefaultClause = clauseStart === clauseEnd || defaultIndex >= clauseStart && defaultIndex < clauseEnd;
       if (hasDefaultClause) {
         const notEqualFacts = getNotEqualFactsFromTypeofSwitch(clauseStart, clauseEnd, witnesses);
-        return filterType(type, (t) => (getTypeFacts(t) & notEqualFacts) === notEqualFacts);
+        return filterType(type, (t) => getTypeFacts(t, notEqualFacts) === notEqualFacts);
       }
       const clauseWitnesses = witnesses.slice(clauseStart, clauseEnd);
       return getUnionType(map(clauseWitnesses, (text) => text ? narrowTypeByTypeName(type, text) : neverType));
@@ -70780,7 +70804,7 @@ function createTypeChecker(host) {
               false
             );
           }
-          if (strictNullChecks && assumeTrue && optionalChainContainsReference(predicateArgument, reference) && !(getTypeFacts(predicate.type) & 65536 /* EQUndefined */)) {
+          if (strictNullChecks && assumeTrue && optionalChainContainsReference(predicateArgument, reference) && !hasTypeFacts(predicate.type, 65536 /* EQUndefined */)) {
             type = getAdjustedTypeWithFacts(type, 2097152 /* NEUndefinedOrNull */);
           }
           const access = getDiscriminantPropertyAccess(predicateArgument, type);
@@ -70914,7 +70938,7 @@ function createTypeChecker(host) {
         reportCircularityError(declaration.symbol);
         return true;
       }
-      const containsUndefined = !!(getTypeFacts(checkDeclarationInitializer(declaration, 0 /* Normal */)) & 16777216 /* IsUndefined */);
+      const containsUndefined = !!hasTypeFacts(checkDeclarationInitializer(declaration, 0 /* Normal */), 16777216 /* IsUndefined */);
       if (!popTypeResolution()) {
         reportCircularityError(declaration.symbol);
         return true;
@@ -70924,7 +70948,7 @@ function createTypeChecker(host) {
     return links.parameterInitializerContainsUndefined;
   }
   function removeOptionalityFromDeclaredType(declaredType, declaration) {
-    const removeUndefined = strictNullChecks && declaration.kind === 169 /* Parameter */ && declaration.initializer && getTypeFacts(declaredType) & 16777216 /* IsUndefined */ && !parameterInitializerContainsUndefined(declaration);
+    const removeUndefined = strictNullChecks && declaration.kind === 169 /* Parameter */ && declaration.initializer && hasTypeFacts(declaredType, 16777216 /* IsUndefined */) && !parameterInitializerContainsUndefined(declaration);
     return removeUndefined ? getTypeWithFacts(declaredType, 524288 /* NEUndefined */) : declaredType;
   }
   function isConstraintPosition(type, node) {
@@ -73754,7 +73778,7 @@ function createTypeChecker(host) {
     return checkNonNullType(checkExpression(node), node);
   }
   function isNullableType(type) {
-    return !!(getTypeFacts(type) & 50331648 /* IsUndefinedOrNull */);
+    return hasTypeFacts(type, 50331648 /* IsUndefinedOrNull */);
   }
   function getNonNullableTypeIfNeeded(type) {
     return isNullableType(type) ? getNonNullableType(type) : type;
@@ -73800,7 +73824,7 @@ function createTypeChecker(host) {
       error2(node, Diagnostics.Object_is_of_type_unknown);
       return errorType;
     }
-    const facts = getTypeFacts(type);
+    const facts = getTypeFacts(type, 50331648 /* IsUndefinedOrNull */);
     if (facts & 50331648 /* IsUndefinedOrNull */) {
       reportError(node, facts);
       const t = getNonNullableType(type);
@@ -77580,7 +77604,7 @@ function createTypeChecker(host) {
       if (operandConstraint.flags & 3 /* AnyOrUnknown */) {
         return (556800 /* AllTypeofNE */ & notEqualFacts) === 556800 /* AllTypeofNE */;
       }
-      return !someType(operandConstraint, (t) => (getTypeFacts(t) & notEqualFacts) === notEqualFacts);
+      return !someType(operandConstraint, (t) => getTypeFacts(t, notEqualFacts) === notEqualFacts);
     }
     const type = checkExpressionCached(node.expression);
     if (!isLiteralType(type)) {
@@ -77898,14 +77922,15 @@ function createTypeChecker(host) {
     if (symbol) {
       if (isReadonlySymbol(symbol)) {
         error2(expr, Diagnostics.The_operand_of_a_delete_operator_cannot_be_a_read_only_property);
+      } else {
+        checkDeleteExpressionMustBeOptional(expr, symbol);
       }
-      checkDeleteExpressionMustBeOptional(expr, symbol);
     }
     return booleanType;
   }
   function checkDeleteExpressionMustBeOptional(expr, symbol) {
     const type = getTypeOfSymbol(symbol);
-    if (strictNullChecks && !(type.flags & (3 /* AnyOrUnknown */ | 131072 /* Never */)) && !(exactOptionalPropertyTypes ? symbol.flags & 16777216 /* Optional */ : getTypeFacts(type) & 16777216 /* IsUndefined */)) {
+    if (strictNullChecks && !(type.flags & (3 /* AnyOrUnknown */ | 131072 /* Never */)) && !(exactOptionalPropertyTypes ? symbol.flags & 16777216 /* Optional */ : hasTypeFacts(type, 16777216 /* IsUndefined */))) {
       error2(expr, Diagnostics.The_operand_of_a_delete_operator_must_be_optional);
     }
   }
@@ -78040,7 +78065,7 @@ function createTypeChecker(host) {
         return getUnaryResultType(operandType);
       case 54 /* ExclamationToken */:
         checkTruthinessOfType(operandType, node.operand);
-        const facts = getTypeFacts(operandType) & (4194304 /* Truthy */ | 8388608 /* Falsy */);
+        const facts = getTypeFacts(operandType, 4194304 /* Truthy */ | 8388608 /* Falsy */);
         return facts === 4194304 /* Truthy */ ? falseType : facts === 8388608 /* Falsy */ ? trueType : booleanType;
       case 46 /* PlusPlusToken */:
       case 47 /* MinusMinusToken */:
@@ -78271,7 +78296,7 @@ function createTypeChecker(host) {
     if (exprOrAssignment.kind === 304 /* ShorthandPropertyAssignment */) {
       const prop = exprOrAssignment;
       if (prop.objectAssignmentInitializer) {
-        if (strictNullChecks && !(getTypeFacts(checkExpression(prop.objectAssignmentInitializer)) & 16777216 /* IsUndefined */)) {
+        if (strictNullChecks && !hasTypeFacts(checkExpression(prop.objectAssignmentInitializer), 16777216 /* IsUndefined */)) {
           sourceType = getTypeWithFacts(sourceType, 524288 /* NEUndefined */);
         }
         checkBinaryLikeExpression(prop.name, prop.equalsToken, prop.objectAssignmentInitializer, checkMode);
@@ -78683,7 +78708,7 @@ function createTypeChecker(host) {
         return checkInExpression(left, right, leftType, rightType);
       case 56 /* AmpersandAmpersandToken */:
       case 77 /* AmpersandAmpersandEqualsToken */: {
-        const resultType2 = getTypeFacts(leftType) & 4194304 /* Truthy */ ? getUnionType([extractDefinitelyFalsyTypes(strictNullChecks ? leftType : getBaseTypeOfLiteralType(rightType)), rightType]) : leftType;
+        const resultType2 = hasTypeFacts(leftType, 4194304 /* Truthy */) ? getUnionType([extractDefinitelyFalsyTypes(strictNullChecks ? leftType : getBaseTypeOfLiteralType(rightType)), rightType]) : leftType;
         if (operator === 77 /* AmpersandAmpersandEqualsToken */) {
           checkAssignmentOperator(rightType);
         }
@@ -78691,7 +78716,7 @@ function createTypeChecker(host) {
       }
       case 57 /* BarBarToken */:
       case 76 /* BarBarEqualsToken */: {
-        const resultType2 = getTypeFacts(leftType) & 8388608 /* Falsy */ ? getUnionType([getNonNullableType(removeDefinitelyFalsyTypes(leftType)), rightType], 2 /* Subtype */) : leftType;
+        const resultType2 = hasTypeFacts(leftType, 8388608 /* Falsy */) ? getUnionType([getNonNullableType(removeDefinitelyFalsyTypes(leftType)), rightType], 2 /* Subtype */) : leftType;
         if (operator === 76 /* BarBarEqualsToken */) {
           checkAssignmentOperator(rightType);
         }
@@ -78699,7 +78724,7 @@ function createTypeChecker(host) {
       }
       case 61 /* QuestionQuestionToken */:
       case 78 /* QuestionQuestionEqualsToken */: {
-        const resultType2 = getTypeFacts(leftType) & 262144 /* EQUndefinedOrNull */ ? getUnionType([getNonNullableType(leftType), rightType], 2 /* Subtype */) : leftType;
+        const resultType2 = hasTypeFacts(leftType, 262144 /* EQUndefinedOrNull */) ? getUnionType([getNonNullableType(leftType), rightType], 2 /* Subtype */) : leftType;
         if (operator === 78 /* QuestionQuestionEqualsToken */) {
           checkAssignmentOperator(rightType);
         }
@@ -82016,7 +82041,7 @@ function createTypeChecker(host) {
       }
       const type = location === condExpr2 ? condType : checkTruthinessExpression(location);
       const isPropertyExpressionCast = isPropertyAccessExpression(location) && isTypeAssertion(location.expression);
-      if (!(getTypeFacts(type) & 4194304 /* Truthy */) || isPropertyExpressionCast)
+      if (!hasTypeFacts(type, 4194304 /* Truthy */) || isPropertyExpressionCast)
         return;
       const callSignatures = getSignaturesOfType(type, 0 /* Call */);
       const isPromise = !!getAwaitedTypeOfPromise(type);
@@ -167714,11 +167739,12 @@ function getSymbolDisplayPartsDocumentationAndSymbolKindWorker(typeChecker, symb
   if (documentation.length === 0 && isIdentifier(location) && symbol.valueDeclaration && isBindingElement(symbol.valueDeclaration)) {
     const declaration = symbol.valueDeclaration;
     const parent2 = declaration.parent;
-    if (isIdentifier(declaration.name) && isObjectBindingPattern(parent2)) {
-      const name = getTextOfIdentifierOrLiteral(declaration.name);
+    const name = declaration.propertyName || declaration.name;
+    if (isIdentifier(name) && isObjectBindingPattern(parent2)) {
+      const propertyName = getTextOfIdentifierOrLiteral(name);
       const objectType = typeChecker.getTypeAtLocation(parent2);
       documentation = firstDefined(objectType.isUnion() ? objectType.types : [objectType], (t) => {
-        const prop = t.getProperty(name);
+        const prop = t.getProperty(propertyName);
         return prop ? prop.getDocumentationComment(typeChecker) : void 0;
       }) || emptyArray;
     }

package/lib/typescript.js

@@ -35,7 +35,7 @@ var ts = (() => {
     "src/compiler/corePublic.ts"() {
       "use strict";
       versionMajorMinor = "5.3";
-      version = `${versionMajorMinor}.0-insiders.20230823`;
+      version = `${versionMajorMinor}.0-insiders.20230824`;
       Comparison = /* @__PURE__ */ ((Comparison3) => {
         Comparison3[Comparison3["LessThan"] = -1] = "LessThan";
         Comparison3[Comparison3["EqualTo"] = 0] = "EqualTo";
@@ -18985,7 +18985,7 @@ ${lanes.join("\n")}
               "defineProperty",
               "deleteProperty",
               "get",
-              " getOwnPropertyDescriptor",
+              "getOwnPropertyDescriptor",
               "getPrototypeOf",
               "has",
               "isExtensible",
@@ -32436,7 +32436,9 @@ ${lanes.join("\n")}
           let dotDotDotToken;
           let expression;
           if (token() !== 20 /* CloseBraceToken */) {
-            dotDotDotToken = parseOptionalToken(26 /* DotDotDotToken */);
+            if (!inExpressionContext) {
+              dotDotDotToken = parseOptionalToken(26 /* DotDotDotToken */);
+            }
             expression = parseExpression();
           }
           if (inExpressionContext) {
@@ -46887,6 +46889,9 @@ ${lanes.join("\n")}
         const sourceFiles = host.getSourceFiles();
         return sourceFiles.indexOf(declarationFile) <= sourceFiles.indexOf(useFile);
       }
+      if (!!(usage.flags & 16777216 /* JSDoc */) || isInTypeQuery(usage) || isInAmbientOrTypeNode(usage)) {
+        return true;
+      }
       if (declaration.pos <= usage.pos && !(isPropertyDeclaration(declaration) && isThisProperty(usage.parent) && !declaration.initializer && !declaration.exclamationToken)) {
         if (declaration.kind === 208 /* BindingElement */) {
           const errorBindingElement = getAncestor(usage, 208 /* BindingElement */);
@@ -46916,9 +46921,6 @@ ${lanes.join("\n")}
       if (usage.kind === 277 /* ExportAssignment */ && usage.isExportEquals) {
         return true;
       }
-      if (!!(usage.flags & 16777216 /* JSDoc */) || isInTypeQuery(usage) || isInAmbientOrTypeNode(usage)) {
-        return true;
-      }
       if (isUsedInFunctionOrInstanceProperty(usage, declaration)) {
         if (emitStandardClassFields && getContainingClass(declaration) && (isPropertyDeclaration(declaration) || isParameterPropertyDeclaration(declaration, declaration.parent))) {
           return !isPropertyImmediatelyReferencedWithinDeclaration(
@@ -53128,8 +53130,8 @@ ${lanes.join("\n")}
                     });
                   }
                 });
-                Debug.assert(setter && isFunctionLikeDeclaration(setter));
-                const paramSymbol = getSignatureFromDeclaration(setter).parameters[0];
+                Debug.assert(!!setter);
+                const paramSymbol = isFunctionLikeDeclaration(setter) ? getSignatureFromDeclaration(setter).parameters[0] : void 0;
                 result.push(setTextRange(
                   factory.createSetAccessorDeclaration(
                     factory.createModifiersFromModifierFlags(flag),
@@ -53905,7 +53907,7 @@ ${lanes.join("\n")}
       const pattern = declaration.parent;
       if (strictNullChecks && declaration.flags & 33554432 /* Ambient */ && isParameterDeclaration(declaration)) {
         parentType = getNonNullableType(parentType);
-      } else if (strictNullChecks && pattern.parent.initializer && !(getTypeFacts(getTypeOfInitializer(pattern.parent.initializer)) & 65536 /* EQUndefined */)) {
+      } else if (strictNullChecks && pattern.parent.initializer && !hasTypeFacts(getTypeOfInitializer(pattern.parent.initializer), 65536 /* EQUndefined */)) {
         parentType = getTypeWithFacts(parentType, 524288 /* NEUndefined */);
       }
       let type;
@@ -53948,7 +53950,7 @@ ${lanes.join("\n")}
         return type;
       }
       if (getEffectiveTypeAnnotationNode(walkUpBindingElementsAndPatterns(declaration))) {
-        return strictNullChecks && !(getTypeFacts(checkDeclarationInitializer(declaration, 0 /* Normal */)) & 16777216 /* IsUndefined */) ? getNonUndefinedType(type) : type;
+        return strictNullChecks && !hasTypeFacts(checkDeclarationInitializer(declaration, 0 /* Normal */), 16777216 /* IsUndefined */) ? getNonUndefinedType(type) : type;
       }
       return widenTypeInferredFromInitializer(declaration, getUnionType([getNonUndefinedType(type), checkDeclarationInitializer(declaration, 0 /* Normal */)], 2 /* Subtype */));
     }
@@ -62056,7 +62058,7 @@ ${lanes.join("\n")}
         if (sourceType && targetType) {
           const sourceSig = checkMode & 3 /* Callback */ ? void 0 : getSingleCallSignature(getNonNullableType(sourceType));
           const targetSig = checkMode & 3 /* Callback */ ? void 0 : getSingleCallSignature(getNonNullableType(targetType));
-          const callbacks = sourceSig && targetSig && !getTypePredicateOfSignature(sourceSig) && !getTypePredicateOfSignature(targetSig) && (getTypeFacts(sourceType) & 50331648 /* IsUndefinedOrNull */) === (getTypeFacts(targetType) & 50331648 /* IsUndefinedOrNull */);
+          const callbacks = sourceSig && targetSig && !getTypePredicateOfSignature(sourceSig) && !getTypePredicateOfSignature(targetSig) && getTypeFacts(sourceType, 50331648 /* IsUndefinedOrNull */) === getTypeFacts(targetType, 50331648 /* IsUndefinedOrNull */);
           let related = callbacks ? compareSignaturesRelated(targetSig, sourceSig, checkMode & 8 /* StrictArity */ | (strictVariance ? 2 /* StrictCallback */ : 1 /* BivariantCallback */), reportErrors2, errorReporter, incompatibleErrorReporter, compareTypes, reportUnreliableMarkers) : !(checkMode & 3 /* Callback */) && !strictVariance && compareTypes(
             sourceType,
             targetType,
@@ -63692,6 +63694,9 @@ ${lanes.join("\n")}
             }
             instantiateType(source2, reportUnreliableMapper);
           }
+          if (isTemplateLiteralTypeWithSinglePlaceholderAndNoExtraTexts(target2) && isTypeAssignableTo(source2, stringType) && isTypeAssignableTo(target2.types[0], stringType)) {
+            return isRelatedTo(source2, target2.types[0], 3 /* Both */, reportErrors2);
+          }
           if (isTypeMatchedByTemplateLiteralType(source2, target2)) {
             return -1 /* True */;
           }
@@ -63742,6 +63747,9 @@ ${lanes.join("\n")}
           }
         } else if (sourceFlags & 134217728 /* TemplateLiteral */ && !(targetFlags & 524288 /* Object */)) {
           if (!(targetFlags & 134217728 /* TemplateLiteral */)) {
+            if (isTemplateLiteralTypeWithSinglePlaceholderAndNoExtraTexts(source2) && isTypeAssignableTo(source2.types[0], stringType) && isTypeAssignableTo(target2, stringType)) {
+              return isRelatedTo(source2.types[0], target2, 3 /* Both */, reportErrors2);
+            }
             const constraint = getBaseConstraintOfType(source2);
             if (constraint && constraint !== source2 && (result2 = isRelatedTo(constraint, target2, 1 /* Source */, reportErrors2))) {
               return result2;
@@ -65213,7 +65221,7 @@ ${lanes.join("\n")}
       return value.base10Value === "0";
     }
     function removeDefinitelyFalsyTypes(type) {
-      return filterType(type, (t) => !!(getTypeFacts(t) & 4194304 /* Truthy */));
+      return filterType(type, (t) => hasTypeFacts(t, 4194304 /* Truthy */));
     }
     function extractDefinitelyFalsyTypes(type) {
       return mapType(type, getDefinitelyFalsyPartOfType);
@@ -65866,6 +65874,13 @@ ${lanes.join("\n")}
       }
       return false;
     }
+    function isTemplateLiteralTypeWithSinglePlaceholderAndNoExtraTexts(type) {
+      if (!(type.flags & 134217728 /* TemplateLiteral */)) {
+        return false;
+      }
+      const texts = type.texts;
+      return texts.length === 2 && texts[0] === "" && texts[1] === "";
+    }
     function isValidTypeForTemplateLiteralPlaceholder(source, target) {
       if (source === target || target.flags & (1 /* Any */ | 4 /* String */)) {
         return true;
@@ -65885,9 +65900,8 @@ ${lanes.join("\n")}
           false
         ) || target.flags & (512 /* BooleanLiteral */ | 98304 /* Nullable */) && value === target.intrinsicName || target.flags & 268435456 /* StringMapping */ && isMemberOfStringMapping(getStringLiteralType(value), target) || target.flags & 134217728 /* TemplateLiteral */ && isTypeMatchedByTemplateLiteralType(source, target));
       }
-      if (source.flags & 134217728 /* TemplateLiteral */) {
-        const texts = source.texts;
-        return texts.length === 2 && texts[0] === "" && texts[1] === "" && isTypeAssignableTo(source.types[0], target);
+      if (isTemplateLiteralTypeWithSinglePlaceholderAndNoExtraTexts(source)) {
+        return isTypeAssignableTo(source.types[0], target);
       }
       return isTypeAssignableTo(source, target);
     }
@@ -66958,7 +66972,13 @@ ${lanes.join("\n")}
       const resolved = resolveStructuredTypeMembers(type);
       return !!(resolved.callSignatures.length || resolved.constructSignatures.length || resolved.members.get("bind") && isTypeSubtypeOf(type, globalFunctionType));
     }
-    function getTypeFacts(type) {
+    function getTypeFacts(type, mask2) {
+      return getTypeFactsWorker(type, mask2) & mask2;
+    }
+    function hasTypeFacts(type, mask2) {
+      return getTypeFacts(type, mask2) !== 0;
+    }
+    function getTypeFactsWorker(type, callerOnlyNeeds) {
       if (type.flags & (2097152 /* Intersection */ | 465829888 /* Instantiable */)) {
         type = getBaseConstraintOfType(type) || unknownType;
       }
@@ -66991,6 +67011,10 @@ ${lanes.join("\n")}
         return strictNullChecks ? type === falseType || type === regularFalseType ? 12121864 /* FalseStrictFacts */ : 7927560 /* TrueStrictFacts */ : type === falseType || type === regularFalseType ? 12580616 /* FalseFacts */ : 16774920 /* TrueFacts */;
       }
       if (flags & 524288 /* Object */) {
+        const possibleFacts = strictNullChecks ? 83427327 /* EmptyObjectStrictFacts */ | 7880640 /* FunctionStrictFacts */ | 7888800 /* ObjectStrictFacts */ : 83886079 /* EmptyObjectFacts */ | 16728e3 /* FunctionFacts */ | 16736160 /* ObjectFacts */;
+        if ((callerOnlyNeeds & possibleFacts) === 0) {
+          return 0;
+        }
         return getObjectFlags(type) & 16 /* Anonymous */ && isEmptyObjectType(type) ? strictNullChecks ? 83427327 /* EmptyObjectStrictFacts */ : 83886079 /* EmptyObjectFacts */ : isFunctionObjectType(type) ? strictNullChecks ? 7880640 /* FunctionStrictFacts */ : 16728e3 /* FunctionFacts */ : strictNullChecks ? 7888800 /* ObjectStrictFacts */ : 16736160 /* ObjectFacts */;
       }
       if (flags & 16384 /* Void */) {
@@ -67012,20 +67036,20 @@ ${lanes.join("\n")}
         return 0 /* None */;
       }
       if (flags & 1048576 /* Union */) {
-        return reduceLeft(type.types, (facts, t) => facts | getTypeFacts(t), 0 /* None */);
+        return reduceLeft(type.types, (facts, t) => facts | getTypeFactsWorker(t, callerOnlyNeeds), 0 /* None */);
       }
       if (flags & 2097152 /* Intersection */) {
-        return getIntersectionTypeFacts(type);
+        return getIntersectionTypeFacts(type, callerOnlyNeeds);
       }
       return 83886079 /* UnknownFacts */;
     }
-    function getIntersectionTypeFacts(type) {
+    function getIntersectionTypeFacts(type, callerOnlyNeeds) {
       const ignoreObjects = maybeTypeOfKind(type, 402784252 /* Primitive */);
       let oredFacts = 0 /* None */;
       let andedFacts = 134217727 /* All */;
       for (const t of type.types) {
         if (!(ignoreObjects && t.flags & 524288 /* Object */)) {
-          const f = getTypeFacts(t);
+          const f = getTypeFactsWorker(t, callerOnlyNeeds);
           oredFacts |= f;
           andedFacts &= f;
         }
@@ -67033,19 +67057,19 @@ ${lanes.join("\n")}
       return oredFacts & 8256 /* OrFactsMask */ | andedFacts & 134209471 /* AndFactsMask */;
     }
     function getTypeWithFacts(type, include) {
-      return filterType(type, (t) => (getTypeFacts(t) & include) !== 0);
+      return filterType(type, (t) => hasTypeFacts(t, include));
     }
     function getAdjustedTypeWithFacts(type, facts) {
       const reduced = recombineUnknownType(getTypeWithFacts(strictNullChecks && type.flags & 2 /* Unknown */ ? unknownUnionType : type, facts));
       if (strictNullChecks) {
         switch (facts) {
           case 524288 /* NEUndefined */:
-            return mapType(reduced, (t) => getTypeFacts(t) & 65536 /* EQUndefined */ ? getIntersectionType([t, getTypeFacts(t) & 131072 /* EQNull */ && !maybeTypeOfKind(reduced, 65536 /* Null */) ? getUnionType([emptyObjectType, nullType]) : emptyObjectType]) : t);
+            return mapType(reduced, (t) => hasTypeFacts(t, 65536 /* EQUndefined */) ? getIntersectionType([t, hasTypeFacts(t, 131072 /* EQNull */) && !maybeTypeOfKind(reduced, 65536 /* Null */) ? getUnionType([emptyObjectType, nullType]) : emptyObjectType]) : t);
           case 1048576 /* NENull */:
-            return mapType(reduced, (t) => getTypeFacts(t) & 131072 /* EQNull */ ? getIntersectionType([t, getTypeFacts(t) & 65536 /* EQUndefined */ && !maybeTypeOfKind(reduced, 32768 /* Undefined */) ? getUnionType([emptyObjectType, undefinedType]) : emptyObjectType]) : t);
+            return mapType(reduced, (t) => hasTypeFacts(t, 131072 /* EQNull */) ? getIntersectionType([t, hasTypeFacts(t, 65536 /* EQUndefined */) && !maybeTypeOfKind(reduced, 32768 /* Undefined */) ? getUnionType([emptyObjectType, undefinedType]) : emptyObjectType]) : t);
           case 2097152 /* NEUndefinedOrNull */:
           case 4194304 /* Truthy */:
-            return mapType(reduced, (t) => getTypeFacts(t) & 262144 /* EQUndefinedOrNull */ ? getGlobalNonNullableTypeInstantiation(t) : t);
+            return mapType(reduced, (t) => hasTypeFacts(t, 262144 /* EQUndefinedOrNull */) ? getGlobalNonNullableTypeInstantiation(t) : t);
         }
       }
       return reduced;
@@ -68382,14 +68406,14 @@ ${lanes.join("\n")}
           // the constituent based on its type facts. We use the strict subtype relation because it treats `object`
           // as a subtype of `{}`, and we need the type facts check because function types are subtypes of `object`,
           // but are classified as "function" according to `typeof`.
-          isTypeRelatedTo(t, impliedType, strictSubtypeRelation) ? getTypeFacts(t) & facts ? t : neverType : (
+          isTypeRelatedTo(t, impliedType, strictSubtypeRelation) ? hasTypeFacts(t, facts) ? t : neverType : (
             // We next check if the consituent is a supertype of the implied type. If so, we substitute the implied
             // type. This handles top types like `unknown` and `{}`, and supertypes like `{ toString(): string }`.
             isTypeSubtypeOf(impliedType, t) ? impliedType : (
               // Neither the constituent nor the implied type is a subtype of the other, however their domains may still
               // overlap. For example, an unconstrained type parameter and type `string`. If the type facts indicate
               // possible overlap, we form an intersection. Otherwise, we eliminate the constituent.
-              getTypeFacts(t) & facts ? getIntersectionType([t, impliedType]) : neverType
+              hasTypeFacts(t, facts) ? getIntersectionType([t, impliedType]) : neverType
             )
           )
         ));
@@ -68403,7 +68427,7 @@ ${lanes.join("\n")}
         const hasDefaultClause = clauseStart === clauseEnd || defaultIndex >= clauseStart && defaultIndex < clauseEnd;
         if (hasDefaultClause) {
           const notEqualFacts = getNotEqualFactsFromTypeofSwitch(clauseStart, clauseEnd, witnesses);
-          return filterType(type, (t) => (getTypeFacts(t) & notEqualFacts) === notEqualFacts);
+          return filterType(type, (t) => getTypeFacts(t, notEqualFacts) === notEqualFacts);
         }
         const clauseWitnesses = witnesses.slice(clauseStart, clauseEnd);
         return getUnionType(map(clauseWitnesses, (text) => text ? narrowTypeByTypeName(type, text) : neverType));
@@ -68541,7 +68565,7 @@ ${lanes.join("\n")}
                 false
               );
             }
-            if (strictNullChecks && assumeTrue && optionalChainContainsReference(predicateArgument, reference) && !(getTypeFacts(predicate.type) & 65536 /* EQUndefined */)) {
+            if (strictNullChecks && assumeTrue && optionalChainContainsReference(predicateArgument, reference) && !hasTypeFacts(predicate.type, 65536 /* EQUndefined */)) {
               type = getAdjustedTypeWithFacts(type, 2097152 /* NEUndefinedOrNull */);
             }
             const access = getDiscriminantPropertyAccess(predicateArgument, type);
@@ -68675,7 +68699,7 @@ ${lanes.join("\n")}
           reportCircularityError(declaration.symbol);
           return true;
         }
-        const containsUndefined = !!(getTypeFacts(checkDeclarationInitializer(declaration, 0 /* Normal */)) & 16777216 /* IsUndefined */);
+        const containsUndefined = !!hasTypeFacts(checkDeclarationInitializer(declaration, 0 /* Normal */), 16777216 /* IsUndefined */);
         if (!popTypeResolution()) {
           reportCircularityError(declaration.symbol);
           return true;
@@ -68685,7 +68709,7 @@ ${lanes.join("\n")}
       return links.parameterInitializerContainsUndefined;
     }
     function removeOptionalityFromDeclaredType(declaredType, declaration) {
-      const removeUndefined = strictNullChecks && declaration.kind === 169 /* Parameter */ && declaration.initializer && getTypeFacts(declaredType) & 16777216 /* IsUndefined */ && !parameterInitializerContainsUndefined(declaration);
+      const removeUndefined = strictNullChecks && declaration.kind === 169 /* Parameter */ && declaration.initializer && hasTypeFacts(declaredType, 16777216 /* IsUndefined */) && !parameterInitializerContainsUndefined(declaration);
       return removeUndefined ? getTypeWithFacts(declaredType, 524288 /* NEUndefined */) : declaredType;
     }
     function isConstraintPosition(type, node) {
@@ -71515,7 +71539,7 @@ ${lanes.join("\n")}
       return checkNonNullType(checkExpression(node), node);
     }
     function isNullableType(type) {
-      return !!(getTypeFacts(type) & 50331648 /* IsUndefinedOrNull */);
+      return hasTypeFacts(type, 50331648 /* IsUndefinedOrNull */);
     }
     function getNonNullableTypeIfNeeded(type) {
       return isNullableType(type) ? getNonNullableType(type) : type;
@@ -71561,7 +71585,7 @@ ${lanes.join("\n")}
         error2(node, Diagnostics.Object_is_of_type_unknown);
         return errorType;
       }
-      const facts = getTypeFacts(type);
+      const facts = getTypeFacts(type, 50331648 /* IsUndefinedOrNull */);
       if (facts & 50331648 /* IsUndefinedOrNull */) {
         reportError(node, facts);
         const t = getNonNullableType(type);
@@ -75341,7 +75365,7 @@ ${lanes.join("\n")}
         if (operandConstraint.flags & 3 /* AnyOrUnknown */) {
           return (556800 /* AllTypeofNE */ & notEqualFacts) === 556800 /* AllTypeofNE */;
         }
-        return !someType(operandConstraint, (t) => (getTypeFacts(t) & notEqualFacts) === notEqualFacts);
+        return !someType(operandConstraint, (t) => getTypeFacts(t, notEqualFacts) === notEqualFacts);
       }
       const type = checkExpressionCached(node.expression);
       if (!isLiteralType(type)) {
@@ -75659,14 +75683,15 @@ ${lanes.join("\n")}
       if (symbol) {
         if (isReadonlySymbol(symbol)) {
           error2(expr, Diagnostics.The_operand_of_a_delete_operator_cannot_be_a_read_only_property);
+        } else {
+          checkDeleteExpressionMustBeOptional(expr, symbol);
         }
-        checkDeleteExpressionMustBeOptional(expr, symbol);
       }
       return booleanType;
     }
     function checkDeleteExpressionMustBeOptional(expr, symbol) {
       const type = getTypeOfSymbol(symbol);
-      if (strictNullChecks && !(type.flags & (3 /* AnyOrUnknown */ | 131072 /* Never */)) && !(exactOptionalPropertyTypes ? symbol.flags & 16777216 /* Optional */ : getTypeFacts(type) & 16777216 /* IsUndefined */)) {
+      if (strictNullChecks && !(type.flags & (3 /* AnyOrUnknown */ | 131072 /* Never */)) && !(exactOptionalPropertyTypes ? symbol.flags & 16777216 /* Optional */ : hasTypeFacts(type, 16777216 /* IsUndefined */))) {
         error2(expr, Diagnostics.The_operand_of_a_delete_operator_must_be_optional);
       }
     }
@@ -75801,7 +75826,7 @@ ${lanes.join("\n")}
           return getUnaryResultType(operandType);
         case 54 /* ExclamationToken */:
           checkTruthinessOfType(operandType, node.operand);
-          const facts = getTypeFacts(operandType) & (4194304 /* Truthy */ | 8388608 /* Falsy */);
+          const facts = getTypeFacts(operandType, 4194304 /* Truthy */ | 8388608 /* Falsy */);
           return facts === 4194304 /* Truthy */ ? falseType : facts === 8388608 /* Falsy */ ? trueType : booleanType;
         case 46 /* PlusPlusToken */:
         case 47 /* MinusMinusToken */:
@@ -76032,7 +76057,7 @@ ${lanes.join("\n")}
       if (exprOrAssignment.kind === 304 /* ShorthandPropertyAssignment */) {
         const prop = exprOrAssignment;
         if (prop.objectAssignmentInitializer) {
-          if (strictNullChecks && !(getTypeFacts(checkExpression(prop.objectAssignmentInitializer)) & 16777216 /* IsUndefined */)) {
+          if (strictNullChecks && !hasTypeFacts(checkExpression(prop.objectAssignmentInitializer), 16777216 /* IsUndefined */)) {
             sourceType = getTypeWithFacts(sourceType, 524288 /* NEUndefined */);
           }
           checkBinaryLikeExpression(prop.name, prop.equalsToken, prop.objectAssignmentInitializer, checkMode);
@@ -76444,7 +76469,7 @@ ${lanes.join("\n")}
           return checkInExpression(left, right, leftType, rightType);
         case 56 /* AmpersandAmpersandToken */:
         case 77 /* AmpersandAmpersandEqualsToken */: {
-          const resultType2 = getTypeFacts(leftType) & 4194304 /* Truthy */ ? getUnionType([extractDefinitelyFalsyTypes(strictNullChecks ? leftType : getBaseTypeOfLiteralType(rightType)), rightType]) : leftType;
+          const resultType2 = hasTypeFacts(leftType, 4194304 /* Truthy */) ? getUnionType([extractDefinitelyFalsyTypes(strictNullChecks ? leftType : getBaseTypeOfLiteralType(rightType)), rightType]) : leftType;
           if (operator === 77 /* AmpersandAmpersandEqualsToken */) {
             checkAssignmentOperator(rightType);
           }
@@ -76452,7 +76477,7 @@ ${lanes.join("\n")}
         }
         case 57 /* BarBarToken */:
         case 76 /* BarBarEqualsToken */: {
-          const resultType2 = getTypeFacts(leftType) & 8388608 /* Falsy */ ? getUnionType([getNonNullableType(removeDefinitelyFalsyTypes(leftType)), rightType], 2 /* Subtype */) : leftType;
+          const resultType2 = hasTypeFacts(leftType, 8388608 /* Falsy */) ? getUnionType([getNonNullableType(removeDefinitelyFalsyTypes(leftType)), rightType], 2 /* Subtype */) : leftType;
           if (operator === 76 /* BarBarEqualsToken */) {
             checkAssignmentOperator(rightType);
           }
@@ -76460,7 +76485,7 @@ ${lanes.join("\n")}
         }
         case 61 /* QuestionQuestionToken */:
         case 78 /* QuestionQuestionEqualsToken */: {
-          const resultType2 = getTypeFacts(leftType) & 262144 /* EQUndefinedOrNull */ ? getUnionType([getNonNullableType(leftType), rightType], 2 /* Subtype */) : leftType;
+          const resultType2 = hasTypeFacts(leftType, 262144 /* EQUndefinedOrNull */) ? getUnionType([getNonNullableType(leftType), rightType], 2 /* Subtype */) : leftType;
           if (operator === 78 /* QuestionQuestionEqualsToken */) {
             checkAssignmentOperator(rightType);
           }
@@ -79777,7 +79802,7 @@ ${lanes.join("\n")}
         }
         const type = location === condExpr2 ? condType : checkTruthinessExpression(location);
         const isPropertyExpressionCast = isPropertyAccessExpression(location) && isTypeAssertion(location.expression);
-        if (!(getTypeFacts(type) & 4194304 /* Truthy */) || isPropertyExpressionCast)
+        if (!hasTypeFacts(type, 4194304 /* Truthy */) || isPropertyExpressionCast)
           return;
         const callSignatures = getSignaturesOfType(type, 0 /* Call */);
         const isPromise = !!getAwaitedTypeOfPromise(type);
@@ -167149,11 +167174,12 @@ ${newComment.split("\n").map((c) => ` * ${c}`).join("\n")}
     if (documentation.length === 0 && isIdentifier(location) && symbol.valueDeclaration && isBindingElement(symbol.valueDeclaration)) {
       const declaration = symbol.valueDeclaration;
       const parent2 = declaration.parent;
-      if (isIdentifier(declaration.name) && isObjectBindingPattern(parent2)) {
-        const name = getTextOfIdentifierOrLiteral(declaration.name);
+      const name = declaration.propertyName || declaration.name;
+      if (isIdentifier(name) && isObjectBindingPattern(parent2)) {
+        const propertyName = getTextOfIdentifierOrLiteral(name);
         const objectType = typeChecker.getTypeAtLocation(parent2);
         documentation = firstDefined(objectType.isUnion() ? objectType.types : [objectType], (t) => {
-          const prop = t.getProperty(name);
+          const prop = t.getProperty(propertyName);
           return prop ? prop.getDocumentationComment(typeChecker) : void 0;
         }) || emptyArray;
       }

package/lib/typingsInstaller.js

@@ -54,7 +54,7 @@ var path = __toESM(require("path"));
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.3";
-var version = `${versionMajorMinor}.0-insiders.20230823`;
+var version = `${versionMajorMinor}.0-insiders.20230824`;
 
 // src/compiler/core.ts
 var emptyArray = [];
@@ -21824,7 +21824,9 @@ var Parser;
     let dotDotDotToken;
     let expression;
     if (token() !== 20 /* CloseBraceToken */) {
-      dotDotDotToken = parseOptionalToken(26 /* DotDotDotToken */);
+      if (!inExpressionContext) {
+        dotDotDotToken = parseOptionalToken(26 /* DotDotDotToken */);
+      }
       expression = parseExpression();
     }
     if (inExpressionContext) {

package/package.json

@@ -2,7 +2,7 @@
   "name": "@typescript-deploys/pr-build",
   "author": "Microsoft Corp.",
   "homepage": "https://www.typescriptlang.org/",
-  "version": "5.3.0-pr-55476-8",
+  "version": "5.3.0-pr-55371-11",
   "license": "Apache-2.0",
   "description": "TypeScript is a language for application scale JavaScript development",
   "keywords": [
@@ -42,7 +42,6 @@
     "@esfx/canceltoken": "^1.0.0",
     "@octokit/rest": "^19.0.13",
     "@types/chai": "^4.3.4",
-    "@types/fs-extra": "^9.0.13",
     "@types/glob": "^8.1.0",
     "@types/microsoft__typescript-etw": "^0.1.1",
     "@types/minimist": "^1.2.2",
@@ -59,7 +58,6 @@
     "chai": "^4.3.7",
     "chalk": "^4.1.2",
     "chokidar": "^3.5.3",
-    "del": "^6.1.1",
     "diff": "^5.1.0",
     "dprint": "^0.40.2",
     "esbuild": "^0.19.0",
@@ -69,7 +67,6 @@
     "eslint-plugin-no-null": "^1.0.2",
     "eslint-plugin-simple-import-sort": "^10.0.0",
     "fast-xml-parser": "^4.0.11",
-    "fs-extra": "^9.1.0",
     "glob": "^8.1.0",
     "hereby": "^1.6.4",
     "jsonc-parser": "^3.2.0",
@@ -116,5 +113,5 @@
     "node": "20.1.0",
     "npm": "8.19.4"
   },
-  "gitHead": "247e45aa5d8ebb7f055841b6531d95ad51f25132"
+  "gitHead": "a9de88c08e82e6143ae36b4260ed04a83636078a"
 }