@typescript-deploys/pr-build 5.2.0-pr-55052-3 → 5.2.0-pr-55028-5

package/lib/tsserver.js

@@ -2327,7 +2327,7 @@ module.exports = __toCommonJS(server_exports);
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.2";
-var version = `${versionMajorMinor}.0-insiders.20230718`;
+var version = `${versionMajorMinor}.0-insiders.20230720`;
 var Comparison = /* @__PURE__ */ ((Comparison3) => {
   Comparison3[Comparison3["LessThan"] = -1] = "LessThan";
   Comparison3[Comparison3["EqualTo"] = 0] = "EqualTo";
@@ -6810,7 +6810,8 @@ var SignatureFlags = /* @__PURE__ */ ((SignatureFlags5) => {
   SignatureFlags5[SignatureFlags5["IsOuterCallChain"] = 16] = "IsOuterCallChain";
   SignatureFlags5[SignatureFlags5["IsUntypedSignatureInJSFile"] = 32] = "IsUntypedSignatureInJSFile";
   SignatureFlags5[SignatureFlags5["IsNonInferrable"] = 64] = "IsNonInferrable";
-  SignatureFlags5[SignatureFlags5["PropagatingFlags"] = 39] = "PropagatingFlags";
+  SignatureFlags5[SignatureFlags5["IsSignatureCandidateForOverloadFailure"] = 128] = "IsSignatureCandidateForOverloadFailure";
+  SignatureFlags5[SignatureFlags5["PropagatingFlags"] = 167] = "PropagatingFlags";
   SignatureFlags5[SignatureFlags5["CallChainFlags"] = 24] = "CallChainFlags";
   return SignatureFlags5;
 })(SignatureFlags || {});
@@ -10189,9 +10190,6 @@ var Diagnostics = {
   await_using_statements_are_only_allowed_within_async_functions_and_at_the_top_levels_of_modules: diag(2852, 1 /* Error */, "await_using_statements_are_only_allowed_within_async_functions_and_at_the_top_levels_of_modules_2852", "'await using' statements are only allowed within async functions and at the top levels of modules."),
   await_using_statements_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_this_file_has_no_imports_or_exports_Consider_adding_an_empty_export_to_make_this_file_a_module: diag(2853, 1 /* Error */, "await_using_statements_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_th_2853", "'await using' statements are only allowed at the top level of a file when that file is a module, but this file has no imports or exports. Consider adding an empty 'export {}' to make this file a module."),
   Top_level_await_using_statements_are_only_allowed_when_the_module_option_is_set_to_es2022_esnext_system_node16_or_nodenext_and_the_target_option_is_set_to_es2017_or_higher: diag(2854, 1 /* Error */, "Top_level_await_using_statements_are_only_allowed_when_the_module_option_is_set_to_es2022_esnext_sys_2854", "Top-level 'await using' statements are only allowed when the 'module' option is set to 'es2022', 'esnext', 'system', 'node16', or 'nodenext', and the 'target' option is set to 'es2017' or higher."),
-  The_left_hand_side_of_an_instanceof_expression_must_be_assignable_to_the_first_argument_of_the_right_hand_side_s_Symbol_hasInstance_method: diag(2855, 1 /* Error */, "The_left_hand_side_of_an_instanceof_expression_must_be_assignable_to_the_first_argument_of_the_right_2855", "The left-hand side of an 'instanceof' expression must be assignable to the first argument of the right-hand side's '[Symbol.hasInstance]' method."),
-  An_object_s_Symbol_hasInstance_method_must_return_a_boolean_value_for_it_to_be_used_on_the_right_hand_side_of_an_instanceof_expression: diag(2856, 1 /* Error */, "An_object_s_Symbol_hasInstance_method_must_return_a_boolean_value_for_it_to_be_used_on_the_right_han_2856", "An object's '[Symbol.hasInstance]' method must return a boolean value for it to be used on the right-hand side of an 'instanceof' expression."),
-  The_right_hand_side_of_an_instanceof_expression_must_be_either_of_type_any_an_object_type_with_a_Symbol_hasInstance_method_or_a_type_assignable_to_the_Function_interface_type: diag(2857, 1 /* Error */, "The_right_hand_side_of_an_instanceof_expression_must_be_either_of_type_any_an_object_type_with_a_Sym_2857", "The right-hand side of an 'instanceof' expression must be either of type 'any', an object type with a '[Symbol.hasInstance]()' method, or a type assignable to the 'Function' interface type."),
   Import_declaration_0_is_using_private_name_1: diag(4e3, 1 /* Error */, "Import_declaration_0_is_using_private_name_1_4000", "Import declaration '{0}' is using private name '{1}'."),
   Type_parameter_0_of_exported_class_has_or_is_using_private_name_1: diag(4002, 1 /* Error */, "Type_parameter_0_of_exported_class_has_or_is_using_private_name_1_4002", "Type parameter '{0}' of exported class has or is using private name '{1}'."),
   Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1: diag(4004, 1 /* Error */, "Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1_4004", "Type parameter '{0}' of exported interface has or is using private name '{1}'."),
@@ -14665,7 +14663,6 @@ function isLeftHandSideExpressionKind(kind) {
     case 236 /* MetaProperty */:
     case 102 /* ImportKeyword */:
     case 282 /* MissingDeclaration */:
-    case 237 /* SyntheticExpression */:
       return true;
     default:
       return false;
@@ -48574,7 +48571,6 @@ function createTypeChecker(host) {
   var potentialReflectCollisions = [];
   var potentialUnusedRenamedBindingElementsInTypes = [];
   var awaitedTypeStack = [];
-  var hasGlobalSymbolHasInstanceProperty;
   var diagnostics = createDiagnosticCollection();
   var suggestionDiagnostics = createDiagnosticCollection();
   var typeofType = createTypeofType();
@@ -49086,7 +49082,7 @@ function createTypeChecker(host) {
           false
         );
       } else if (isParameterPropertyDeclaration(declaration, declaration.parent)) {
-        return !(getEmitScriptTarget(compilerOptions) === 99 /* ESNext */ && useDefineForClassFields && getContainingClass(declaration) === getContainingClass(usage) && isUsedInFunctionOrInstanceProperty(usage, declaration));
+        return !(useDefineForClassFields && getContainingClass(declaration) === getContainingClass(usage) && isUsedInFunctionOrInstanceProperty(usage, declaration));
       }
       return true;
     }
@@ -49100,7 +49096,7 @@ function createTypeChecker(host) {
       return true;
     }
     if (isUsedInFunctionOrInstanceProperty(usage, declaration)) {
-      if (getEmitScriptTarget(compilerOptions) >= 9 /* ES2022 */ && useDefineForClassFields && getContainingClass(declaration) && (isPropertyDeclaration(declaration) || isParameterPropertyDeclaration(declaration, declaration.parent))) {
+      if (useDefineForClassFields && getContainingClass(declaration) && (isPropertyDeclaration(declaration) || isParameterPropertyDeclaration(declaration, declaration.parent))) {
         return !isPropertyImmediatelyReferencedWithinDeclaration(
           declaration,
           usage,
@@ -49224,7 +49220,7 @@ function createTypeChecker(host) {
           return requiresScopeChangeWorker(node.name);
         case 172 /* PropertyDeclaration */:
           if (hasStaticModifier(node)) {
-            return target < 99 /* ESNext */ || !useDefineForClassFields;
+            return !useDefineForClassFields;
           }
           return requiresScopeChangeWorker(node.name);
         default:
@@ -49263,7 +49259,7 @@ function createTypeChecker(host) {
         if (name === "const" && isConstAssertion(location)) {
           return void 0;
         }
-        if (isModuleDeclaration(location) && lastLocation && location.name === lastLocation) {
+        if (isModuleOrEnumDeclaration(location) && lastLocation && location.name === lastLocation) {
           lastLocation = location;
           location = location.parent;
         }
@@ -49495,7 +49491,7 @@ function createTypeChecker(host) {
       }
     }
     function checkAndReportErrorForInvalidInitializer() {
-      if (propertyWithInvalidInitializer && !(useDefineForClassFields && getEmitScriptTarget(compilerOptions) >= 9 /* ES2022 */)) {
+      if (propertyWithInvalidInitializer && !useDefineForClassFields) {
         error2(
           errorLocation,
           errorLocation && propertyWithInvalidInitializer.type && textRangeContainsPositionInclusive(propertyWithInvalidInitializer.type, errorLocation.pos) ? Diagnostics.Type_of_instance_member_variable_0_cannot_reference_identifier_1_declared_in_the_constructor : Diagnostics.Initializer_of_instance_member_variable_0_cannot_reference_identifier_1_declared_in_the_constructor,
@@ -56285,7 +56281,7 @@ function createTypeChecker(host) {
       false,
       definedInMethod && !definedInConstructor
     ));
-    if (symbol.valueDeclaration && filterType(widened, (t) => !!(t.flags & ~98304 /* Nullable */)) === neverType) {
+    if (symbol.valueDeclaration && isInJSFile(symbol.valueDeclaration) && filterType(widened, (t) => !!(t.flags & ~98304 /* Nullable */)) === neverType) {
       reportImplicitAny(symbol.valueDeclaration, anyType);
       return anyType;
     }
@@ -57645,6 +57641,7 @@ function createTypeChecker(host) {
     return links.resolvedSymbol;
   }
   function getResolvedMembersOrExportsOfSymbol(symbol, resolutionKind) {
+    var _a, _b, _c;
     const links = getSymbolLinks(symbol);
     if (!links[resolutionKind]) {
       const isStatic2 = resolutionKind === "resolvedExports" /* resolvedExports */;
@@ -57663,7 +57660,7 @@ function createTypeChecker(host) {
           }
         }
       }
-      const assignments = symbol.assignmentDeclarationMembers;
+      const assignments = (((_a = symbol.valueDeclaration) == null ? void 0 : _a.kind) === 219 /* ArrowFunction */ || ((_b = symbol.valueDeclaration) == null ? void 0 : _b.kind) === 218 /* FunctionExpression */) && ((_c = getSymbolOfNode(symbol.valueDeclaration.parent)) == null ? void 0 : _c.assignmentDeclarationMembers) || symbol.assignmentDeclarationMembers;
       if (assignments) {
         const decls = arrayFrom(assignments.values());
         for (const member of decls) {
@@ -57792,7 +57789,7 @@ function createTypeChecker(host) {
       /*resolvedTypePredicate*/
       void 0,
       sig.minArgumentCount,
-      sig.flags & 39 /* PropagatingFlags */
+      sig.flags & 167 /* PropagatingFlags */
     );
     result.target = sig.target;
     result.mapper = sig.mapper;
@@ -58093,7 +58090,7 @@ function createTypeChecker(host) {
       /*resolvedTypePredicate*/
       void 0,
       minArgCount,
-      (left.flags | right.flags) & 39 /* PropagatingFlags */
+      (left.flags | right.flags) & 167 /* PropagatingFlags */
     );
     result.compositeKind = 1048576 /* Union */;
     result.compositeSignatures = concatenate(left.compositeKind !== 2097152 /* Intersection */ && left.compositeSignatures || [left], [right]);
@@ -58303,7 +58300,7 @@ function createTypeChecker(host) {
             /*resolvedTypePredicate*/
             void 0,
             sig.minArgumentCount,
-            sig.flags & 39 /* PropagatingFlags */
+            sig.flags & 167 /* PropagatingFlags */
           ) : void 0
         ));
       }
@@ -63086,7 +63083,7 @@ function createTypeChecker(host) {
       /*resolvedTypePredicate*/
       void 0,
       signature.minArgumentCount,
-      signature.flags & 39 /* PropagatingFlags */
+      signature.flags & 167 /* PropagatingFlags */
     );
     result.target = signature;
     result.mapper = mapper;
@@ -70347,12 +70344,15 @@ function createTypeChecker(host) {
             return narrowTypeByPrivateIdentifierInInExpression(type, expr, assumeTrue);
           }
           const target = getReferenceCandidate(expr.right);
-          const leftType = getTypeOfExpression(expr.left);
-          if (leftType.flags & 8576 /* StringOrNumberLiteralOrUnique */) {
-            if (containsMissingType(type) && isAccessExpression(reference) && isMatchingReference(reference.expression, target) && getAccessedPropertyName(reference) === getPropertyNameFromType(leftType)) {
+          if (containsMissingType(type) && isAccessExpression(reference) && isMatchingReference(reference.expression, target)) {
+            const leftType = getTypeOfExpression(expr.left);
+            if (isTypeUsableAsPropertyName(leftType) && getAccessedPropertyName(reference) === getPropertyNameFromType(leftType)) {
               return getTypeWithFacts(type, assumeTrue ? 524288 /* NEUndefined */ : 65536 /* EQUndefined */);
             }
-            if (isMatchingReference(reference, target)) {
+          }
+          if (isMatchingReference(reference, target)) {
+            const leftType = getTypeOfExpression(expr.left);
+            if (isTypeUsableAsPropertyName(leftType)) {
               return narrowTypeByInKeyword(type, leftType, assumeTrue);
             }
           }
@@ -70617,15 +70617,6 @@ function createTypeChecker(host) {
         return type;
       }
       const rightType = getTypeOfExpression(expr.right);
-      const hasInstanceMethodType = getSymbolHasInstanceMethodOfObjectType(rightType);
-      if (hasInstanceMethodType) {
-        const syntheticCall = createSyntheticHasInstanceMethodCall(left, expr.right, type, hasInstanceMethodType);
-        const signature = getEffectsSignature(syntheticCall);
-        const predicate = signature && getTypePredicateOfSignature(signature);
-        if (predicate && (predicate.kind === 0 /* This */ || predicate.kind === 1 /* Identifier */)) {
-          return narrowTypeByTypePredicate(type, predicate, syntheticCall, assumeTrue);
-        }
-      }
       if (!isTypeDerivedFrom(rightType, globalFunctionType)) {
         return type;
       }
@@ -70705,12 +70696,8 @@ function createTypeChecker(host) {
     }
     function narrowTypeByTypePredicate(type, predicate, callExpression, assumeTrue) {
       if (predicate.type && !(isTypeAny(type) && (predicate.type === globalObjectType || predicate.type === globalFunctionType))) {
-        let predicateArgument = getTypePredicateArgument(predicate, callExpression);
+        const predicateArgument = getTypePredicateArgument(predicate, callExpression);
         if (predicateArgument) {
-          if (isSyntheticExpression(predicateArgument) && predicate.parameterIndex === 0 && isSyntheticHasInstanceMethodCall(callExpression)) {
-            Debug.assertNode(predicateArgument.parent, isExpression);
-            predicateArgument = predicateArgument.parent;
-          }
           if (isMatchingReference(reference, predicateArgument)) {
             return getNarrowedType(
               type,
@@ -72548,7 +72535,7 @@ function createTypeChecker(host) {
       /*resolvedTypePredicate*/
       void 0,
       minArgCount,
-      (left.flags | right.flags) & 39 /* PropagatingFlags */
+      (left.flags | right.flags) & 167 /* PropagatingFlags */
     );
     result.compositeKind = 2097152 /* Intersection */;
     result.compositeSignatures = concatenate(left.compositeKind === 2097152 /* Intersection */ && left.compositeSignatures || [left], [right]);
@@ -74082,7 +74069,7 @@ function createTypeChecker(host) {
     }
     let diagnosticMessage;
     const declarationName = idText(right);
-    if (isInPropertyInitializerOrClassStaticBlock(node) && !isOptionalPropertyDeclaration(valueDeclaration) && !(isAccessExpression(node) && isAccessExpression(node.expression)) && !isBlockScopedNameDeclaredBeforeUse(valueDeclaration, right) && !(isMethodDeclaration(valueDeclaration) && getCombinedModifierFlagsCached(valueDeclaration) & 32 /* Static */) && (compilerOptions.useDefineForClassFields || !isPropertyDeclaredInAncestorClass(prop))) {
+    if (isInPropertyInitializerOrClassStaticBlock(node) && !isOptionalPropertyDeclaration(valueDeclaration) && !(isAccessExpression(node) && isAccessExpression(node.expression)) && !isBlockScopedNameDeclaredBeforeUse(valueDeclaration, right) && !(isMethodDeclaration(valueDeclaration) && getCombinedModifierFlagsCached(valueDeclaration) & 32 /* Static */) && (useDefineForClassFields || !isPropertyDeclaredInAncestorClass(prop))) {
       diagnosticMessage = error2(right, Diagnostics.Property_0_is_used_before_its_initialization, declarationName);
     } else if (valueDeclaration.kind === 263 /* ClassDeclaration */ && node.parent.kind !== 183 /* TypeReference */ && !(valueDeclaration.flags & 33554432 /* Ambient */) && !isBlockScopedNameDeclaredBeforeUse(valueDeclaration, right)) {
       diagnosticMessage = error2(right, Diagnostics.Class_0_used_before_its_declaration, declarationName);
@@ -75287,7 +75274,7 @@ function createTypeChecker(host) {
     }
     return createDiagnosticForNodeArray(getSourceFileOfNode(node), typeArguments, Diagnostics.Expected_0_type_arguments_but_got_1, belowArgCount === -Infinity ? aboveArgCount : belowArgCount, argCount);
   }
-  function resolveCall(node, signatures, candidatesOutArray, checkMode, callChainFlags, headMessageCallback) {
+  function resolveCall(node, signatures, candidatesOutArray, checkMode, callChainFlags, headMessage) {
     const isTaggedTemplate = node.kind === 215 /* TaggedTemplateExpression */;
     const isDecorator2 = node.kind === 170 /* Decorator */;
     const isJsxOpeningOrSelfClosingElement = isJsxOpeningLikeElement(node);
@@ -75330,7 +75317,6 @@ function createTypeChecker(host) {
             chain = chainDiagnosticMessages(chain, Diagnostics.The_last_overload_gave_the_following_error);
             chain = chainDiagnosticMessages(chain, Diagnostics.No_overload_matches_this_call);
           }
-          const headMessage = headMessageCallback == null ? void 0 : headMessageCallback();
           if (headMessage) {
             chain = chainDiagnosticMessages(chain, headMessage);
           }
@@ -75398,7 +75384,6 @@ function createTypeChecker(host) {
             map(diags, createDiagnosticMessageChainFromDiagnostic),
             Diagnostics.No_overload_matches_this_call
           );
-          const headMessage = headMessageCallback == null ? void 0 : headMessageCallback();
           if (headMessage) {
             chain = chainDiagnosticMessages(chain, headMessage);
           }
@@ -75414,21 +75399,21 @@ function createTypeChecker(host) {
           diagnostics.add(diag2);
         }
       } else if (candidateForArgumentArityError) {
-        diagnostics.add(getArgumentArityError(node, [candidateForArgumentArityError], args, headMessageCallback == null ? void 0 : headMessageCallback()));
+        diagnostics.add(getArgumentArityError(node, [candidateForArgumentArityError], args, headMessage));
       } else if (candidateForTypeArgumentError) {
         checkTypeArguments(
           candidateForTypeArgumentError,
           node.typeArguments,
           /*reportErrors*/
           true,
-          headMessageCallback == null ? void 0 : headMessageCallback()
+          headMessage
         );
       } else {
         const signaturesWithCorrectTypeArgumentArity = filter(signatures, (s) => hasCorrectTypeArgumentArity(s, typeArguments));
         if (signaturesWithCorrectTypeArgumentArity.length === 0) {
-          diagnostics.add(getTypeArgumentArityError(node, signatures, typeArguments, headMessageCallback == null ? void 0 : headMessageCallback()));
+          diagnostics.add(getTypeArgumentArityError(node, signatures, typeArguments, headMessage));
         } else {
-          diagnostics.add(getArgumentArityError(node, signaturesWithCorrectTypeArgumentArity, args, headMessageCallback == null ? void 0 : headMessageCallback()));
+          diagnostics.add(getArgumentArityError(node, signaturesWithCorrectTypeArgumentArity, args, headMessage));
         }
       }
     }
@@ -75579,7 +75564,7 @@ function createTypeChecker(host) {
       parameters.push(createCombinedSymbolFromTypes(symbols, mapDefined(candidates, (candidate) => tryGetTypeAtPosition(candidate, i))));
     }
     const restParameterSymbols = mapDefined(candidates, (c) => signatureHasRestParameter(c) ? last(c.parameters) : void 0);
-    let flags = 0 /* None */;
+    let flags = 128 /* IsSignatureCandidateForOverloadFailure */;
     if (restParameterSymbols.length !== 0) {
       const type = createArrayType(getUnionType(mapDefined(candidates, tryGetRestTypeOfSignature), 2 /* Subtype */));
       parameters.push(createCombinedSymbolForOverloadFailure(restParameterSymbols, type));
@@ -75736,7 +75721,7 @@ function createTypeChecker(host) {
       error2(node, Diagnostics.Value_of_type_0_is_not_callable_Did_you_mean_to_include_new, typeToString(funcType));
       return resolveErrorCall(node);
     }
-    return resolveCall(node, callSignatures, candidatesOutArray, checkMode, callChainFlags, () => isSyntheticHasInstanceMethodCall(node) ? Diagnostics.The_left_hand_side_of_an_instanceof_expression_must_be_assignable_to_the_first_argument_of_the_right_hand_side_s_Symbol_hasInstance_method : void 0);
+    return resolveCall(node, callSignatures, candidatesOutArray, checkMode, callChainFlags);
   }
   function isGenericFunctionReturningFunction(signature) {
     return !!(signature.typeParameters && isFunctionType(getReturnTypeOfSignature(signature)));
@@ -76033,7 +76018,7 @@ function createTypeChecker(host) {
       invocationErrorRecovery(apparentType, 0 /* Call */, diag2);
       return resolveErrorCall(node);
     }
-    return resolveCall(node, callSignatures, candidatesOutArray, checkMode, 0 /* None */, () => headMessage);
+    return resolveCall(node, callSignatures, candidatesOutArray, checkMode, 0 /* None */, headMessage);
   }
   function createSignatureForJSXIntrinsic(node, result) {
     const namespace = getJsxNamespaceAt(node);
@@ -76303,6 +76288,8 @@ function createTypeChecker(host) {
     return returnType;
   }
   function checkDeprecatedSignature(signature, node) {
+    if (signature.flags & 128 /* IsSignatureCandidateForOverloadFailure */)
+      return;
     if (signature.declaration && signature.declaration.flags & 536870912 /* Deprecated */) {
       const suggestionNode = getDeprecatedSuggestionNode(node);
       const name = tryGetPropertyAccessOrIdentifierToString(getInvokedExpression(node));
@@ -78066,32 +78053,6 @@ function createTypeChecker(host) {
   function isConstEnumSymbol(symbol) {
     return (symbol.flags & 128 /* ConstEnum */) !== 0;
   }
-  function getSymbolHasInstanceMethodOfObjectType(type) {
-    const hasInstancePropertyName = getPropertyNameForKnownSymbolName("hasInstance");
-    const hasInstanceProperty = getPropertyOfObjectType(type, hasInstancePropertyName);
-    if (hasInstanceProperty) {
-      const hasInstancePropertyType = getTypeOfSymbol(hasInstanceProperty);
-      if (hasInstancePropertyType && getSignaturesOfType(hasInstancePropertyType, 0 /* Call */).length !== 0) {
-        return hasInstancePropertyType;
-      }
-    }
-  }
-  function createSyntheticHasInstanceMethodCall(left, right, leftType, hasInstanceMethodType) {
-    const syntheticExpression = createSyntheticExpression(right, hasInstanceMethodType);
-    const syntheticArgument = createSyntheticExpression(left, leftType);
-    const syntheticCall = parseNodeFactory.createCallExpression(
-      syntheticExpression,
-      /*typeArguments*/
-      void 0,
-      [syntheticArgument]
-    );
-    setParent(syntheticCall, left.parent);
-    setTextRange(syntheticCall, left.parent);
-    return syntheticCall;
-  }
-  function isSyntheticHasInstanceMethodCall(node) {
-    return isSyntheticExpression(node.expression) && node.arguments.length === 1 && isSyntheticExpression(node.arguments[0]) && isBinaryExpression(node.parent) && node.parent.operatorToken.kind === 104 /* InstanceOfKeyword */ && node.parent.right === node.expression.parent && node.parent.left === node.arguments[0].parent;
-  }
   function checkInstanceOfExpression(left, right, leftType, rightType) {
     if (leftType === silentNeverType || rightType === silentNeverType) {
       return silentNeverType;
@@ -78099,31 +78060,8 @@ function createTypeChecker(host) {
     if (!isTypeAny(leftType) && allTypesAssignableToKind(leftType, 402784252 /* Primitive */)) {
       error2(left, Diagnostics.The_left_hand_side_of_an_instanceof_expression_must_be_of_type_any_an_object_type_or_a_type_parameter);
     }
-    if (!isTypeAny(rightType)) {
-      const hasInstanceMethodType = getSymbolHasInstanceMethodOfObjectType(rightType);
-      if (hasInstanceMethodType) {
-        const cache = hasInstanceMethodType;
-        if (cache.hasSimpleUnrestrictedSingleCallSignature === void 0) {
-          const signature = getSingleCallSignature(hasInstanceMethodType);
-          cache.hasSimpleUnrestrictedSingleCallSignature = !!signature && signature.parameters.length === 1 && !!(getTypeOfSymbol(signature.parameters[0]).flags & 3 /* AnyOrUnknown */) && !!signature.resolvedReturnType && !!(signature.resolvedReturnType.flags & 16 /* Boolean */);
-        }
-        if (!cache.hasSimpleUnrestrictedSingleCallSignature) {
-          const syntheticCall = createSyntheticHasInstanceMethodCall(left, right, leftType, hasInstanceMethodType);
-          const returnType = getReturnTypeOfSignature(getResolvedSignature(syntheticCall));
-          checkTypeAssignableTo(returnType, booleanType, right, Diagnostics.An_object_s_Symbol_hasInstance_method_must_return_a_boolean_value_for_it_to_be_used_on_the_right_hand_side_of_an_instanceof_expression);
-        }
-      }
-      if (!(hasInstanceMethodType || typeHasCallOrConstructSignatures(rightType) || isTypeSubtypeOf(rightType, globalFunctionType))) {
-        if (hasGlobalSymbolHasInstanceProperty === void 0) {
-          const globalESSymbolConstructorSymbol = getGlobalESSymbolConstructorTypeSymbol(
-            /*reportErrors*/
-            false
-          );
-          hasGlobalSymbolHasInstanceProperty = !!globalESSymbolConstructorSymbol && getMembersOfSymbol(globalESSymbolConstructorSymbol).has("hasInstance");
-        }
-        const message = hasGlobalSymbolHasInstanceProperty ? Diagnostics.The_right_hand_side_of_an_instanceof_expression_must_be_either_of_type_any_an_object_type_with_a_Symbol_hasInstance_method_or_a_type_assignable_to_the_Function_interface_type : Diagnostics.The_right_hand_side_of_an_instanceof_expression_must_be_of_type_any_or_of_a_type_assignable_to_the_Function_interface_type;
-        error2(right, message);
-      }
+    if (!(isTypeAny(rightType) || typeHasCallOrConstructSignatures(rightType) || isTypeSubtypeOf(rightType, globalFunctionType))) {
+      error2(right, Diagnostics.The_right_hand_side_of_an_instanceof_expression_must_be_of_type_any_or_of_a_type_assignable_to_the_Function_interface_type);
     }
     return booleanType;
   }
@@ -79825,7 +79763,7 @@ function createTypeChecker(host) {
           case "length":
           case "caller":
           case "arguments":
-            if (compilerOptions.useDefineForClassFields) {
+            if (useDefineForClassFields) {
               break;
             }
           case "prototype":
@@ -79973,7 +79911,7 @@ function createTypeChecker(host) {
           if (classExtendsNull) {
             error2(superCall, Diagnostics.A_constructor_cannot_contain_a_super_call_when_its_class_extends_null);
           }
-          const superCallShouldBeRootLevel = (getEmitScriptTarget(compilerOptions) !== 99 /* ESNext */ || !useDefineForClassFields) && (some(node.parent.members, isInstancePropertyWithInitializerOrPrivateIdentifierProperty) || some(node.parameters, (p) => hasSyntacticModifier(p, 16476 /* ParameterPropertyModifier */)));
+          const superCallShouldBeRootLevel = !useDefineForClassFields && (some(node.parent.members, isInstancePropertyWithInitializerOrPrivateIdentifierProperty) || some(node.parameters, (p) => hasSyntacticModifier(p, 16476 /* ParameterPropertyModifier */)));
           if (superCallShouldBeRootLevel) {
             if (!superCallIsRootLevelInConstructor(superCall, node.body)) {
               error2(superCall, Diagnostics.A_super_call_must_be_a_root_level_statement_within_a_constructor_of_a_derived_class_that_contains_initialized_properties_parameter_properties_or_private_identifiers);
@@ -83243,7 +83181,7 @@ function createTypeChecker(host) {
       node
     );
     const willTransformPrivateElementsOrClassStaticBlocks = languageVersion <= 9 /* ES2022 */;
-    const willTransformInitializers = !useDefineForClassFields || languageVersion < 9 /* ES2022 */;
+    const willTransformInitializers = !useDefineForClassFields;
     if (willTransformStaticElementsOfDecoratedClass || willTransformPrivateElementsOrClassStaticBlocks) {
       for (const member of node.members) {
         if (willTransformStaticElementsOfDecoratedClass && classElementOrClassElementParameterIsDecorated(
@@ -159202,7 +159140,8 @@ function getCompletionData(program, log, sourceFile, compilerOptions, position,
       const leftMostName = getLeftMostName(computedPropertyName.expression);
       const nameSymbol = leftMostName && typeChecker.getSymbolAtLocation(leftMostName);
       const firstAccessibleSymbol = nameSymbol && getFirstSymbolInChain(nameSymbol, contextToken, typeChecker);
-      if (firstAccessibleSymbol && addToSeen(seenPropertySymbols, getSymbolId(firstAccessibleSymbol))) {
+      const firstAccessibleSymbolId = firstAccessibleSymbol && getSymbolId(firstAccessibleSymbol);
+      if (firstAccessibleSymbolId && addToSeen(seenPropertySymbols, firstAccessibleSymbolId)) {
         const index = symbols.length;
         symbols.push(firstAccessibleSymbol);
         const moduleSymbol = firstAccessibleSymbol.parent;
@@ -159232,6 +159171,9 @@ function getCompletionData(program, log, sourceFile, compilerOptions, position,
           }
         }
       } else if (preferences.includeCompletionsWithInsertText) {
+        if (firstAccessibleSymbolId && seenPropertySymbols.has(firstAccessibleSymbolId)) {
+          return;
+        }
         addSymbolOriginInfo(symbol);
         addSymbolSortInfo(symbol);
         symbols.push(symbol);

package/lib/tsserverlibrary.d.ts

@@ -5139,7 +5139,7 @@ declare namespace ts {
         readonly asteriskToken?: AsteriskToken;
         readonly expression?: Expression;
     }
-    interface SyntheticExpression extends LeftHandSideExpression {
+    interface SyntheticExpression extends Expression {
         readonly kind: SyntaxKind.SyntheticExpression;
         readonly isSpread: boolean;
         readonly type: Type;