@typescript-deploys/pr-build 5.2.0-pr-55052-3 → 5.2.0-pr-52095-16

package/lib/tsc.js

@@ -18,7 +18,7 @@ and limitations under the License.
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.2";
-var version = `${versionMajorMinor}.0-insiders.20230718`;
+var version = `${versionMajorMinor}.0-insiders.20230725`;
 
 // src/compiler/core.ts
 var emptyArray = [];
@@ -3762,7 +3762,8 @@ var SignatureFlags = /* @__PURE__ */ ((SignatureFlags4) => {
   SignatureFlags4[SignatureFlags4["IsOuterCallChain"] = 16] = "IsOuterCallChain";
   SignatureFlags4[SignatureFlags4["IsUntypedSignatureInJSFile"] = 32] = "IsUntypedSignatureInJSFile";
   SignatureFlags4[SignatureFlags4["IsNonInferrable"] = 64] = "IsNonInferrable";
-  SignatureFlags4[SignatureFlags4["PropagatingFlags"] = 39] = "PropagatingFlags";
+  SignatureFlags4[SignatureFlags4["IsSignatureCandidateForOverloadFailure"] = 128] = "IsSignatureCandidateForOverloadFailure";
+  SignatureFlags4[SignatureFlags4["PropagatingFlags"] = 167] = "PropagatingFlags";
   SignatureFlags4[SignatureFlags4["CallChainFlags"] = 24] = "CallChainFlags";
   return SignatureFlags4;
 })(SignatureFlags || {});
@@ -6668,9 +6669,6 @@ var Diagnostics = {
   await_using_statements_are_only_allowed_within_async_functions_and_at_the_top_levels_of_modules: diag(2852, 1 /* Error */, "await_using_statements_are_only_allowed_within_async_functions_and_at_the_top_levels_of_modules_2852", "'await using' statements are only allowed within async functions and at the top levels of modules."),
   await_using_statements_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_this_file_has_no_imports_or_exports_Consider_adding_an_empty_export_to_make_this_file_a_module: diag(2853, 1 /* Error */, "await_using_statements_are_only_allowed_at_the_top_level_of_a_file_when_that_file_is_a_module_but_th_2853", "'await using' statements are only allowed at the top level of a file when that file is a module, but this file has no imports or exports. Consider adding an empty 'export {}' to make this file a module."),
   Top_level_await_using_statements_are_only_allowed_when_the_module_option_is_set_to_es2022_esnext_system_node16_or_nodenext_and_the_target_option_is_set_to_es2017_or_higher: diag(2854, 1 /* Error */, "Top_level_await_using_statements_are_only_allowed_when_the_module_option_is_set_to_es2022_esnext_sys_2854", "Top-level 'await using' statements are only allowed when the 'module' option is set to 'es2022', 'esnext', 'system', 'node16', or 'nodenext', and the 'target' option is set to 'es2017' or higher."),
-  The_left_hand_side_of_an_instanceof_expression_must_be_assignable_to_the_first_argument_of_the_right_hand_side_s_Symbol_hasInstance_method: diag(2855, 1 /* Error */, "The_left_hand_side_of_an_instanceof_expression_must_be_assignable_to_the_first_argument_of_the_right_2855", "The left-hand side of an 'instanceof' expression must be assignable to the first argument of the right-hand side's '[Symbol.hasInstance]' method."),
-  An_object_s_Symbol_hasInstance_method_must_return_a_boolean_value_for_it_to_be_used_on_the_right_hand_side_of_an_instanceof_expression: diag(2856, 1 /* Error */, "An_object_s_Symbol_hasInstance_method_must_return_a_boolean_value_for_it_to_be_used_on_the_right_han_2856", "An object's '[Symbol.hasInstance]' method must return a boolean value for it to be used on the right-hand side of an 'instanceof' expression."),
-  The_right_hand_side_of_an_instanceof_expression_must_be_either_of_type_any_an_object_type_with_a_Symbol_hasInstance_method_or_a_type_assignable_to_the_Function_interface_type: diag(2857, 1 /* Error */, "The_right_hand_side_of_an_instanceof_expression_must_be_either_of_type_any_an_object_type_with_a_Sym_2857", "The right-hand side of an 'instanceof' expression must be either of type 'any', an object type with a '[Symbol.hasInstance]()' method, or a type assignable to the 'Function' interface type."),
   Import_declaration_0_is_using_private_name_1: diag(4e3, 1 /* Error */, "Import_declaration_0_is_using_private_name_1_4000", "Import declaration '{0}' is using private name '{1}'."),
   Type_parameter_0_of_exported_class_has_or_is_using_private_name_1: diag(4002, 1 /* Error */, "Type_parameter_0_of_exported_class_has_or_is_using_private_name_1_4002", "Type parameter '{0}' of exported class has or is using private name '{1}'."),
   Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1: diag(4004, 1 /* Error */, "Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1_4004", "Type parameter '{0}' of exported interface has or is using private name '{1}'."),
@@ -10994,7 +10992,6 @@ function isLeftHandSideExpressionKind(kind) {
     case 236 /* MetaProperty */:
     case 102 /* ImportKeyword */:
     case 282 /* MissingDeclaration */:
-    case 237 /* SyntheticExpression */:
       return true;
     default:
       return false;
@@ -17407,6 +17404,18 @@ function getTextOfJsxNamespacedName(node) {
 function intrinsicTagNameToString(node) {
   return isIdentifier(node) ? idText(node) : getTextOfJsxNamespacedName(node);
 }
+function isTypeUsableAsPropertyName(type) {
+  return !!(type.flags & 8576 /* StringOrNumberLiteralOrUnique */);
+}
+function getPropertyNameFromType(type) {
+  if (type.flags & 8192 /* UniqueESSymbol */) {
+    return type.escapedName;
+  }
+  if (type.flags & (128 /* StringLiteral */ | 256 /* NumberLiteral */)) {
+    return escapeLeadingUnderscores("" + type.value);
+  }
+  return Debug.fail();
+}
 
 // src/compiler/factory/baseNodeFactory.ts
 function createBaseNodeFactory() {
@@ -24275,9 +24284,6 @@ function isNonNullExpression(node) {
 function isMetaProperty(node) {
   return node.kind === 236 /* MetaProperty */;
 }
-function isSyntheticExpression(node) {
-  return node.kind === 237 /* SyntheticExpression */;
-}
 function isPartiallyEmittedExpression(node) {
   return node.kind === 360 /* PartiallyEmittedExpression */;
 }
@@ -30717,10 +30723,14 @@ var Parser;
         case 124 /* ProtectedKeyword */:
         case 125 /* PublicKeyword */:
         case 148 /* ReadonlyKeyword */:
+          const previousToken = token();
           nextToken();
           if (scanner.hasPrecedingLineBreak()) {
             return false;
           }
+          if (previousToken === 138 /* DeclareKeyword */ && token() === 156 /* TypeKeyword */) {
+            return true;
+          }
           continue;
         case 162 /* GlobalKeyword */:
           nextToken();
@@ -31085,14 +31095,14 @@ var Parser;
   function parseObjectBindingPattern() {
     const pos = getNodePos();
     parseExpected(19 /* OpenBraceToken */);
-    const elements = parseDelimitedList(9 /* ObjectBindingElements */, parseObjectBindingElement);
+    const elements = allowInAnd(() => parseDelimitedList(9 /* ObjectBindingElements */, parseObjectBindingElement));
     parseExpected(20 /* CloseBraceToken */);
     return finishNode(factory2.createObjectBindingPattern(elements), pos);
   }
   function parseArrayBindingPattern() {
     const pos = getNodePos();
     parseExpected(23 /* OpenBracketToken */);
-    const elements = parseDelimitedList(10 /* ArrayBindingElements */, parseArrayBindingElement);
+    const elements = allowInAnd(() => parseDelimitedList(10 /* ArrayBindingElements */, parseArrayBindingElement));
     parseExpected(24 /* CloseBracketToken */);
     return finishNode(factory2.createArrayBindingPattern(elements), pos);
   }
@@ -31610,6 +31620,9 @@ var Parser;
   }
   function parseTypeAliasDeclaration(pos, hasJSDoc, modifiers) {
     parseExpected(156 /* TypeKeyword */);
+    if (scanner.hasPrecedingLineBreak()) {
+      parseErrorAtCurrentToken(Diagnostics.Line_break_not_permitted_here);
+    }
     const name = parseIdentifier();
     const typeParameters = parseTypeParameters();
     parseExpected(64 /* EqualsToken */);
@@ -33511,7 +33524,7 @@ function getNamedArgRegEx(name) {
   return result;
 }
 var tripleSlashXMLCommentStartRegEx = /^\/\/\/\s*<(\S+)\s.*?\/>/im;
-var singleLinePragmaRegEx = /^\/\/\/?\s*@(\S+)\s*(.*)\s*$/im;
+var singleLinePragmaRegEx = /^\/\/\/?\s*@([^\s:]+)(.*)\s*$/im;
 function extractPragmas(pragmas, range, text) {
   const tripleSlash = range.kind === 2 /* SingleLineCommentTrivia */ && tripleSlashXMLCommentStartRegEx.exec(text);
   if (tripleSlash) {
@@ -39229,6 +39242,9 @@ function getModuleInstanceStateForAliasTarget(specifier, visited) {
           if (found === 1 /* Instantiated */) {
             return found;
           }
+          if (statement.kind === 271 /* ImportEqualsDeclaration */) {
+            found = 1 /* Instantiated */;
+          }
         }
       }
       if (found !== void 0) {
@@ -43117,7 +43133,7 @@ function createTypeChecker(host) {
       return node ? getTypeFromTypeNode(node) : errorType;
     },
     getParameterType: getTypeAtPosition,
-    getParameterIdentifierNameAtPosition,
+    getParameterIdentifierInfoAtPosition,
     getPromisedTypeOfPromise,
     getAwaitedType: (type) => getAwaitedType(type),
     getReturnTypeOfSignature,
@@ -43870,7 +43886,6 @@ function createTypeChecker(host) {
   var potentialReflectCollisions = [];
   var potentialUnusedRenamedBindingElementsInTypes = [];
   var awaitedTypeStack = [];
-  var hasGlobalSymbolHasInstanceProperty;
   var diagnostics = createDiagnosticCollection();
   var suggestionDiagnostics = createDiagnosticCollection();
   var typeofType = createTypeofType();
@@ -44559,7 +44574,7 @@ function createTypeChecker(host) {
         if (name === "const" && isConstAssertion(location)) {
           return void 0;
         }
-        if (isModuleDeclaration(location) && lastLocation && location.name === lastLocation) {
+        if (isModuleOrEnumDeclaration(location) && lastLocation && location.name === lastLocation) {
           lastLocation = location;
           location = location.parent;
         }
@@ -46175,7 +46190,7 @@ function createTypeChecker(host) {
     return isStringLiteralLike(moduleReferenceExpression) ? resolveExternalModule(location, moduleReferenceExpression.text, moduleNotFoundError, moduleReferenceExpression, isForAugmentation) : void 0;
   }
   function resolveExternalModule(location, moduleReference, moduleNotFoundError, errorNode, isForAugmentation = false) {
-    var _a, _b, _c, _d, _e, _f, _g, _h, _i;
+    var _a, _b, _c, _d, _e, _f, _g, _h, _i, _j;
     if (startsWith(moduleReference, "@types/")) {
       const diag2 = Diagnostics.Cannot_import_type_declaration_files_Consider_importing_0_instead_of_1;
       const withoutAtTypePrefix = removePrefix(moduleReference, "@types/");
@@ -46210,8 +46225,11 @@ function createTypeChecker(host) {
           );
         }
       } else if (resolvedModule.resolvedUsingTsExtension && !shouldAllowImportingTsExtension(compilerOptions, currentSourceFile.fileName)) {
-        const tsExtension = Debug.checkDefined(tryExtractTSExtension(moduleReference));
-        error(errorNode, Diagnostics.An_import_path_can_only_end_with_a_0_extension_when_allowImportingTsExtensions_is_enabled, tsExtension);
+        const importOrExport = ((_h = findAncestor(location, isImportDeclaration)) == null ? void 0 : _h.importClause) || findAncestor(location, or(isImportEqualsDeclaration, isExportDeclaration));
+        if (!((importOrExport == null ? void 0 : importOrExport.isTypeOnly) || findAncestor(location, isImportTypeNode))) {
+          const tsExtension = Debug.checkDefined(tryExtractTSExtension(moduleReference));
+          error(errorNode, Diagnostics.An_import_path_can_only_end_with_a_0_extension_when_allowImportingTsExtensions_is_enabled, tsExtension);
+        }
       }
       if (sourceFile.symbol) {
         if (resolvedModule.isExternalLibraryImport && !resolutionExtensionIsTSOrJson(resolvedModule.extension)) {
@@ -46228,7 +46246,7 @@ function createTypeChecker(host) {
         if (moduleResolutionKind === 3 /* Node16 */ || moduleResolutionKind === 99 /* NodeNext */) {
           const isSyncImport = currentSourceFile.impliedNodeFormat === 1 /* CommonJS */ && !findAncestor(location, isImportCall) || !!findAncestor(location, isImportEqualsDeclaration);
           const overrideClauseHost = findAncestor(location, (l) => isImportTypeNode(l) || isExportDeclaration(l) || isImportDeclaration(l));
-          const overrideClause = overrideClauseHost && isImportTypeNode(overrideClauseHost) ? (_h = overrideClauseHost.assertions) == null ? void 0 : _h.assertClause : overrideClauseHost == null ? void 0 : overrideClauseHost.assertClause;
+          const overrideClause = overrideClauseHost && isImportTypeNode(overrideClauseHost) ? (_i = overrideClauseHost.assertions) == null ? void 0 : _i.assertClause : overrideClauseHost == null ? void 0 : overrideClauseHost.assertClause;
           if (isSyncImport && sourceFile.impliedNodeFormat === 99 /* ESNext */ && !getResolutionModeOverrideForClause(overrideClause)) {
             if (findAncestor(location, isImportEqualsDeclaration)) {
               error(errorNode, Diagnostics.Module_0_cannot_be_imported_using_this_construct_The_specifier_only_resolves_to_an_ES_module_which_cannot_be_imported_with_require_Use_an_ECMAScript_import_instead, moduleReference);
@@ -46331,7 +46349,7 @@ function createTypeChecker(host) {
           error(errorNode, Diagnostics.Cannot_find_module_0_Consider_using_resolveJsonModule_to_import_module_with_json_extension, moduleReference);
         } else if (mode === 99 /* ESNext */ && resolutionIsNode16OrNext && isExtensionlessRelativePathImport) {
           const absoluteRef = getNormalizedAbsolutePath(moduleReference, getDirectoryPath(currentSourceFile.path));
-          const suggestedExt = (_i = suggestedExtensions.find(([actualExt, _importExt]) => host.fileExists(absoluteRef + actualExt))) == null ? void 0 : _i[1];
+          const suggestedExt = (_j = suggestedExtensions.find(([actualExt, _importExt]) => host.fileExists(absoluteRef + actualExt))) == null ? void 0 : _j[1];
           if (suggestedExt) {
             error(
               errorNode,
@@ -47767,11 +47785,13 @@ function createTypeChecker(host) {
         return !!type2.target && isMappedTypeHomomorphic(type2.target) && !isMappedTypeHomomorphic(type2);
       }
       function createMappedTypeNodeFromType(type2) {
+        var _a2;
         Debug.assert(!!(type2.flags & 524288 /* Object */));
         const readonlyToken = type2.declaration.readonlyToken ? factory.createToken(type2.declaration.readonlyToken.kind) : void 0;
         const questionToken = type2.declaration.questionToken ? factory.createToken(type2.declaration.questionToken.kind) : void 0;
         let appropriateConstraintTypeNode;
         let newTypeVariable;
+        const needsModifierPreservingWrapper = !isMappedTypeWithKeyofConstraintDeclaration(type2) && !(getModifiersTypeFromMappedType(type2).flags & 2 /* Unknown */) && context.flags & 4 /* GenerateNamesForShadowedTypeParams */ && !(getConstraintTypeFromMappedType(type2).flags & 262144 /* TypeParameter */ && ((_a2 = getConstraintOfTypeParameter(getConstraintTypeFromMappedType(type2))) == null ? void 0 : _a2.flags) & 4194304 /* Index */);
         if (isMappedTypeWithKeyofConstraintDeclaration(type2)) {
           if (isHomomorphicMappedTypeWithNonHomomorphicInstantiation(type2) && context.flags & 4 /* GenerateNamesForShadowedTypeParams */) {
             const newParam = createTypeParameter(createSymbol(262144 /* TypeParameter */, "T"));
@@ -47779,6 +47799,11 @@ function createTypeChecker(host) {
             newTypeVariable = factory.createTypeReferenceNode(name);
           }
           appropriateConstraintTypeNode = factory.createTypeOperatorNode(143 /* KeyOfKeyword */, newTypeVariable || typeToTypeNodeHelper(getModifiersTypeFromMappedType(type2), context));
+        } else if (needsModifierPreservingWrapper) {
+          const newParam = createTypeParameter(createSymbol(262144 /* TypeParameter */, "T"));
+          const name = typeParameterToName(newParam, context);
+          newTypeVariable = factory.createTypeReferenceNode(name);
+          appropriateConstraintTypeNode = newTypeVariable;
         } else {
           appropriateConstraintTypeNode = typeToTypeNodeHelper(getConstraintTypeFromMappedType(type2), context);
         }
@@ -47809,6 +47834,18 @@ function createTypeChecker(host) {
             result,
             factory.createKeywordTypeNode(146 /* NeverKeyword */)
           );
+        } else if (needsModifierPreservingWrapper) {
+          return factory.createConditionalTypeNode(
+            typeToTypeNodeHelper(getConstraintTypeFromMappedType(type2), context),
+            factory.createInferTypeNode(factory.createTypeParameterDeclaration(
+              /*modifiers*/
+              void 0,
+              factory.cloneNode(newTypeVariable.typeName),
+              factory.createTypeOperatorNode(143 /* KeyOfKeyword */, typeToTypeNodeHelper(getModifiersTypeFromMappedType(type2), context))
+            )),
+            result,
+            factory.createKeywordTypeNode(146 /* NeverKeyword */)
+          );
         }
         return result;
       }
@@ -51581,7 +51618,7 @@ function createTypeChecker(host) {
       false,
       definedInMethod && !definedInConstructor
     ));
-    if (symbol.valueDeclaration && filterType(widened, (t) => !!(t.flags & ~98304 /* Nullable */)) === neverType) {
+    if (symbol.valueDeclaration && isInJSFile(symbol.valueDeclaration) && filterType(widened, (t) => !!(t.flags & ~98304 /* Nullable */)) === neverType) {
       reportImplicitAny(symbol.valueDeclaration, anyType);
       return anyType;
     }
@@ -52860,9 +52897,6 @@ function createTypeChecker(host) {
     }
     return type;
   }
-  function isTypeUsableAsPropertyName(type) {
-    return !!(type.flags & 8576 /* StringOrNumberLiteralOrUnique */);
-  }
   function isLateBindableName(node) {
     if (!isComputedPropertyName(node) && !isElementAccessExpression(node)) {
       return false;
@@ -52883,15 +52917,6 @@ function createTypeChecker(host) {
   function isNonBindableDynamicName(node) {
     return isDynamicName(node) && !isLateBindableName(node);
   }
-  function getPropertyNameFromType(type) {
-    if (type.flags & 8192 /* UniqueESSymbol */) {
-      return type.escapedName;
-    }
-    if (type.flags & (128 /* StringLiteral */ | 256 /* NumberLiteral */)) {
-      return escapeLeadingUnderscores("" + type.value);
-    }
-    return Debug.fail();
-  }
   function addDeclarationToLateBoundSymbol(symbol, member, symbolFlags) {
     Debug.assert(!!(getCheckFlags(symbol) & 4096 /* Late */), "Expected a late-bound symbol.");
     symbol.flags |= symbolFlags;
@@ -52941,6 +52966,7 @@ function createTypeChecker(host) {
     return links.resolvedSymbol;
   }
   function getResolvedMembersOrExportsOfSymbol(symbol, resolutionKind) {
+    var _a, _b, _c;
     const links = getSymbolLinks(symbol);
     if (!links[resolutionKind]) {
       const isStatic2 = resolutionKind === "resolvedExports" /* resolvedExports */;
@@ -52959,7 +52985,7 @@ function createTypeChecker(host) {
           }
         }
       }
-      const assignments = symbol.assignmentDeclarationMembers;
+      const assignments = (((_a = symbol.valueDeclaration) == null ? void 0 : _a.kind) === 219 /* ArrowFunction */ || ((_b = symbol.valueDeclaration) == null ? void 0 : _b.kind) === 218 /* FunctionExpression */) && ((_c = getSymbolOfNode(symbol.valueDeclaration.parent)) == null ? void 0 : _c.assignmentDeclarationMembers) || symbol.assignmentDeclarationMembers;
       if (assignments) {
         const decls = arrayFrom(assignments.values());
         for (const member of decls) {
@@ -53088,7 +53114,7 @@ function createTypeChecker(host) {
       /*resolvedTypePredicate*/
       void 0,
       sig.minArgumentCount,
-      sig.flags & 39 /* PropagatingFlags */
+      sig.flags & 167 /* PropagatingFlags */
     );
     result.target = sig.target;
     result.mapper = sig.mapper;
@@ -53389,7 +53415,7 @@ function createTypeChecker(host) {
       /*resolvedTypePredicate*/
       void 0,
       minArgCount,
-      (left.flags | right.flags) & 39 /* PropagatingFlags */
+      (left.flags | right.flags) & 167 /* PropagatingFlags */
     );
     result.compositeKind = 1048576 /* Union */;
     result.compositeSignatures = concatenate(left.compositeKind !== 2097152 /* Intersection */ && left.compositeSignatures || [left], [right]);
@@ -53537,20 +53563,17 @@ function createTypeChecker(host) {
       setStructuredTypeMembers(type, members2, callSignatures, constructSignatures, indexInfos2);
       return;
     }
-    let members = emptySymbols;
+    let members = getExportsOfSymbol(symbol);
     let indexInfos;
-    if (symbol.exports) {
-      members = getExportsOfSymbol(symbol);
-      if (symbol === globalThisSymbol) {
-        const varsOnly = /* @__PURE__ */ new Map();
-        members.forEach((p) => {
-          var _a;
-          if (!(p.flags & 418 /* BlockScoped */) && !(p.flags & 512 /* ValueModule */ && ((_a = p.declarations) == null ? void 0 : _a.length) && every(p.declarations, isAmbientModule))) {
-            varsOnly.set(p.escapedName, p);
-          }
-        });
-        members = varsOnly;
-      }
+    if (symbol === globalThisSymbol) {
+      const varsOnly = /* @__PURE__ */ new Map();
+      members.forEach((p) => {
+        var _a;
+        if (!(p.flags & 418 /* BlockScoped */) && !(p.flags & 512 /* ValueModule */ && ((_a = p.declarations) == null ? void 0 : _a.length) && every(p.declarations, isAmbientModule))) {
+          varsOnly.set(p.escapedName, p);
+        }
+      });
+      members = varsOnly;
     }
     let baseConstructorIndexInfo;
     setStructuredTypeMembers(type, members, emptyArray, emptyArray, emptyArray);
@@ -53599,7 +53622,7 @@ function createTypeChecker(host) {
             /*resolvedTypePredicate*/
             void 0,
             sig.minArgumentCount,
-            sig.flags & 39 /* PropagatingFlags */
+            sig.flags & 167 /* PropagatingFlags */
           ) : void 0
         ));
       }
@@ -58382,7 +58405,7 @@ function createTypeChecker(host) {
       /*resolvedTypePredicate*/
       void 0,
       signature.minArgumentCount,
-      signature.flags & 39 /* PropagatingFlags */
+      signature.flags & 167 /* PropagatingFlags */
     );
     result.target = signature;
     result.mapper = mapper;
@@ -65643,12 +65666,15 @@ function createTypeChecker(host) {
             return narrowTypeByPrivateIdentifierInInExpression(type, expr, assumeTrue);
           }
           const target = getReferenceCandidate(expr.right);
-          const leftType = getTypeOfExpression(expr.left);
-          if (leftType.flags & 8576 /* StringOrNumberLiteralOrUnique */) {
-            if (containsMissingType(type) && isAccessExpression(reference) && isMatchingReference(reference.expression, target) && getAccessedPropertyName(reference) === getPropertyNameFromType(leftType)) {
+          if (containsMissingType(type) && isAccessExpression(reference) && isMatchingReference(reference.expression, target)) {
+            const leftType = getTypeOfExpression(expr.left);
+            if (isTypeUsableAsPropertyName(leftType) && getAccessedPropertyName(reference) === getPropertyNameFromType(leftType)) {
               return getTypeWithFacts(type, assumeTrue ? 524288 /* NEUndefined */ : 65536 /* EQUndefined */);
             }
-            if (isMatchingReference(reference, target)) {
+          }
+          if (isMatchingReference(reference, target)) {
+            const leftType = getTypeOfExpression(expr.left);
+            if (isTypeUsableAsPropertyName(leftType)) {
               return narrowTypeByInKeyword(type, leftType, assumeTrue);
             }
           }
@@ -65913,15 +65939,6 @@ function createTypeChecker(host) {
         return type;
       }
       const rightType = getTypeOfExpression(expr.right);
-      const hasInstanceMethodType = getSymbolHasInstanceMethodOfObjectType(rightType);
-      if (hasInstanceMethodType) {
-        const syntheticCall = createSyntheticHasInstanceMethodCall(left, expr.right, type, hasInstanceMethodType);
-        const signature = getEffectsSignature(syntheticCall);
-        const predicate = signature && getTypePredicateOfSignature(signature);
-        if (predicate && (predicate.kind === 0 /* This */ || predicate.kind === 1 /* Identifier */)) {
-          return narrowTypeByTypePredicate(type, predicate, syntheticCall, assumeTrue);
-        }
-      }
       if (!isTypeDerivedFrom(rightType, globalFunctionType)) {
         return type;
       }
@@ -66001,12 +66018,8 @@ function createTypeChecker(host) {
     }
     function narrowTypeByTypePredicate(type, predicate, callExpression, assumeTrue) {
       if (predicate.type && !(isTypeAny(type) && (predicate.type === globalObjectType || predicate.type === globalFunctionType))) {
-        let predicateArgument = getTypePredicateArgument(predicate, callExpression);
+        const predicateArgument = getTypePredicateArgument(predicate, callExpression);
         if (predicateArgument) {
-          if (isSyntheticExpression(predicateArgument) && predicate.parameterIndex === 0 && isSyntheticHasInstanceMethodCall(callExpression)) {
-            Debug.assertNode(predicateArgument.parent, isExpression);
-            predicateArgument = predicateArgument.parent;
-          }
           if (isMatchingReference(reference, predicateArgument)) {
             return getNarrowedType(
               type,
@@ -67259,41 +67272,75 @@ function createTypeChecker(host) {
     return mapType(
       type,
       (t) => {
-        var _a;
-        if (isGenericMappedType(t) && !t.declaration.nameType) {
-          const constraint = getConstraintTypeFromMappedType(t);
-          const constraintOfConstraint = getBaseConstraintOfType(constraint) || constraint;
-          const propertyNameType = nameType || getStringLiteralType(unescapeLeadingUnderscores(name));
-          if (isTypeAssignableTo(propertyNameType, constraintOfConstraint)) {
-            return substituteIndexedMappedType(t, propertyNameType);
-          }
-        } else if (t.flags & 3670016 /* StructuredType */) {
-          const prop = getPropertyOfType(t, name);
-          if (prop) {
-            return isCircularMappedProperty(prop) ? void 0 : getTypeOfSymbol(prop);
-          }
-          if (isTupleType(t) && isNumericLiteralName(name) && +name >= 0) {
-            const restType = getElementTypeOfSliceOfTupleType(
-              t,
-              t.target.fixedLength,
-              /*endSkipCount*/
-              0,
-              /*writing*/
-              false,
-              /*noReductions*/
-              true
-            );
-            if (restType) {
-              return restType;
+        if (!(t.flags & 3670016 /* StructuredType */)) {
+          return void 0;
+        }
+        if (t.flags & 2097152 /* Intersection */) {
+          const intersection = t;
+          let applicableIndexedMappedTypeSubstitions;
+          let concretePropertyTypes;
+          let applicableIndexInfoCandidates;
+          for (const t2 of intersection.types) {
+            if (isGenericMappedType(t2) && !t2.declaration.nameType) {
+              applicableIndexedMappedTypeSubstitions = append(applicableIndexedMappedTypeSubstitions, getTypeOfApplicableIndexedMappedTypeSubstitutionOfContextualType(t2));
+              continue;
+            }
+            const typeOfConcreteProperty = getTypeOfConcretePropertyOfContextualType(t2);
+            if (typeOfConcreteProperty) {
+              concretePropertyTypes = append(concretePropertyTypes, typeOfConcreteProperty);
+              continue;
             }
+            applicableIndexInfoCandidates = append(applicableIndexInfoCandidates, t2);
           }
-          return (_a = findApplicableIndexInfo(getIndexInfosOfStructuredType(t), nameType || getStringLiteralType(unescapeLeadingUnderscores(name)))) == null ? void 0 : _a.type;
+          if (concretePropertyTypes) {
+            return getIntersectionType(concatenate(concretePropertyTypes, applicableIndexedMappedTypeSubstitions));
+          }
+          const types = concatenate(mapDefined(applicableIndexInfoCandidates, getTypeOfApplicableIndexInfoOfContextualType), applicableIndexedMappedTypeSubstitions);
+          if (types.length > 0) {
+            return getIntersectionType(types);
+          }
+          return void 0;
         }
-        return void 0;
+        return isGenericMappedType(t) && !t.declaration.nameType ? getTypeOfApplicableIndexedMappedTypeSubstitutionOfContextualType(t) : getTypeOfConcretePropertyOfContextualType(t) || getTypeOfApplicableIndexInfoOfContextualType(t);
       },
       /*noReductions*/
       true
     );
+    function getTypeOfApplicableIndexedMappedTypeSubstitutionOfContextualType(t) {
+      const constraint = getConstraintTypeFromMappedType(t);
+      const constraintOfConstraint = getBaseConstraintOfType(constraint) || constraint;
+      const propertyNameType = nameType || getStringLiteralType(unescapeLeadingUnderscores(name));
+      if (isTypeAssignableTo(propertyNameType, constraintOfConstraint)) {
+        return substituteIndexedMappedType(t, propertyNameType);
+      }
+      return void 0;
+    }
+    function getTypeOfConcretePropertyOfContextualType(t) {
+      const prop = getPropertyOfType(t, name);
+      if (prop) {
+        return isCircularMappedProperty(prop) ? void 0 : getTypeOfSymbol(prop);
+      }
+      if (isTupleType(t) && isNumericLiteralName(name) && +name >= 0) {
+        const restType = getElementTypeOfSliceOfTupleType(
+          t,
+          t.target.fixedLength,
+          /*endSkipCount*/
+          0,
+          /*writing*/
+          false,
+          /*noReductions*/
+          true
+        );
+        if (restType) {
+          return restType;
+        }
+      }
+      return void 0;
+    }
+    function getTypeOfApplicableIndexInfoOfContextualType(t) {
+      var _a;
+      return (_a = findApplicableIndexInfo(getIndexInfosOfStructuredType(t), nameType || getStringLiteralType(unescapeLeadingUnderscores(name)))) == null ? void 0 : _a.type;
+    }
   }
   function getContextualTypeForObjectLiteralMethod(node, contextFlags) {
     Debug.assert(isObjectLiteralMethod(node));
@@ -67844,7 +67891,7 @@ function createTypeChecker(host) {
       /*resolvedTypePredicate*/
       void 0,
       minArgCount,
-      (left.flags | right.flags) & 39 /* PropagatingFlags */
+      (left.flags | right.flags) & 167 /* PropagatingFlags */
     );
     result.compositeKind = 2097152 /* Intersection */;
     result.compositeSignatures = concatenate(left.compositeKind === 2097152 /* Intersection */ && left.compositeSignatures || [left], [right]);
@@ -70583,7 +70630,7 @@ function createTypeChecker(host) {
     }
     return createDiagnosticForNodeArray(getSourceFileOfNode(node), typeArguments, Diagnostics.Expected_0_type_arguments_but_got_1, belowArgCount === -Infinity ? aboveArgCount : belowArgCount, argCount);
   }
-  function resolveCall(node, signatures, candidatesOutArray, checkMode, callChainFlags, headMessageCallback) {
+  function resolveCall(node, signatures, candidatesOutArray, checkMode, callChainFlags, headMessage) {
     const isTaggedTemplate = node.kind === 215 /* TaggedTemplateExpression */;
     const isDecorator2 = node.kind === 170 /* Decorator */;
     const isJsxOpeningOrSelfClosingElement = isJsxOpeningLikeElement(node);
@@ -70626,7 +70673,6 @@ function createTypeChecker(host) {
             chain = chainDiagnosticMessages(chain, Diagnostics.The_last_overload_gave_the_following_error);
             chain = chainDiagnosticMessages(chain, Diagnostics.No_overload_matches_this_call);
           }
-          const headMessage = headMessageCallback == null ? void 0 : headMessageCallback();
           if (headMessage) {
             chain = chainDiagnosticMessages(chain, headMessage);
           }
@@ -70694,7 +70740,6 @@ function createTypeChecker(host) {
             map(diags, createDiagnosticMessageChainFromDiagnostic),
             Diagnostics.No_overload_matches_this_call
           );
-          const headMessage = headMessageCallback == null ? void 0 : headMessageCallback();
           if (headMessage) {
             chain = chainDiagnosticMessages(chain, headMessage);
           }
@@ -70710,21 +70755,21 @@ function createTypeChecker(host) {
           diagnostics.add(diag2);
         }
       } else if (candidateForArgumentArityError) {
-        diagnostics.add(getArgumentArityError(node, [candidateForArgumentArityError], args, headMessageCallback == null ? void 0 : headMessageCallback()));
+        diagnostics.add(getArgumentArityError(node, [candidateForArgumentArityError], args, headMessage));
       } else if (candidateForTypeArgumentError) {
         checkTypeArguments(
           candidateForTypeArgumentError,
           node.typeArguments,
           /*reportErrors*/
           true,
-          headMessageCallback == null ? void 0 : headMessageCallback()
+          headMessage
         );
       } else {
         const signaturesWithCorrectTypeArgumentArity = filter(signatures, (s) => hasCorrectTypeArgumentArity(s, typeArguments));
         if (signaturesWithCorrectTypeArgumentArity.length === 0) {
-          diagnostics.add(getTypeArgumentArityError(node, signatures, typeArguments, headMessageCallback == null ? void 0 : headMessageCallback()));
+          diagnostics.add(getTypeArgumentArityError(node, signatures, typeArguments, headMessage));
         } else {
-          diagnostics.add(getArgumentArityError(node, signaturesWithCorrectTypeArgumentArity, args, headMessageCallback == null ? void 0 : headMessageCallback()));
+          diagnostics.add(getArgumentArityError(node, signaturesWithCorrectTypeArgumentArity, args, headMessage));
         }
       }
     }
@@ -70875,7 +70920,7 @@ function createTypeChecker(host) {
       parameters.push(createCombinedSymbolFromTypes(symbols, mapDefined(candidates, (candidate) => tryGetTypeAtPosition(candidate, i))));
     }
     const restParameterSymbols = mapDefined(candidates, (c) => signatureHasRestParameter(c) ? last(c.parameters) : void 0);
-    let flags = 0 /* None */;
+    let flags = 128 /* IsSignatureCandidateForOverloadFailure */;
     if (restParameterSymbols.length !== 0) {
       const type = createArrayType(getUnionType(mapDefined(candidates, tryGetRestTypeOfSignature), 2 /* Subtype */));
       parameters.push(createCombinedSymbolForOverloadFailure(restParameterSymbols, type));
@@ -71032,7 +71077,7 @@ function createTypeChecker(host) {
       error(node, Diagnostics.Value_of_type_0_is_not_callable_Did_you_mean_to_include_new, typeToString(funcType));
       return resolveErrorCall(node);
     }
-    return resolveCall(node, callSignatures, candidatesOutArray, checkMode, callChainFlags, () => isSyntheticHasInstanceMethodCall(node) ? Diagnostics.The_left_hand_side_of_an_instanceof_expression_must_be_assignable_to_the_first_argument_of_the_right_hand_side_s_Symbol_hasInstance_method : void 0);
+    return resolveCall(node, callSignatures, candidatesOutArray, checkMode, callChainFlags);
   }
   function isGenericFunctionReturningFunction(signature) {
     return !!(signature.typeParameters && isFunctionType(getReturnTypeOfSignature(signature)));
@@ -71329,7 +71374,7 @@ function createTypeChecker(host) {
       invocationErrorRecovery(apparentType, 0 /* Call */, diag2);
       return resolveErrorCall(node);
     }
-    return resolveCall(node, callSignatures, candidatesOutArray, checkMode, 0 /* None */, () => headMessage);
+    return resolveCall(node, callSignatures, candidatesOutArray, checkMode, 0 /* None */, headMessage);
   }
   function createSignatureForJSXIntrinsic(node, result) {
     const namespace = getJsxNamespaceAt(node);
@@ -71599,6 +71644,8 @@ function createTypeChecker(host) {
     return returnType;
   }
   function checkDeprecatedSignature(signature, node) {
+    if (signature.flags & 128 /* IsSignatureCandidateForOverloadFailure */)
+      return;
     if (signature.declaration && signature.declaration.flags & 536870912 /* Deprecated */) {
       const suggestionNode = getDeprecatedSuggestionNode(node);
       const name = tryGetPropertyAccessOrIdentifierToString(getInvokedExpression(node));
@@ -72072,7 +72119,7 @@ function createTypeChecker(host) {
     }
     return restParameter.escapedName;
   }
-  function getParameterIdentifierNameAtPosition(signature, pos) {
+  function getParameterIdentifierInfoAtPosition(signature, pos) {
     var _a;
     if (((_a = signature.declaration) == null ? void 0 : _a.kind) === 324 /* JSDocFunctionType */) {
       return void 0;
@@ -72080,10 +72127,16 @@ function createTypeChecker(host) {
     const paramCount = signature.parameters.length - (signatureHasRestParameter(signature) ? 1 : 0);
     if (pos < paramCount) {
       const param = signature.parameters[pos];
-      return isParameterDeclarationWithIdentifierName(param) ? [param.escapedName, false] : void 0;
+      const paramIdent = getParameterDeclarationIdentifier(param);
+      return paramIdent ? {
+        parameter: paramIdent,
+        parameterName: param.escapedName,
+        isRestParameter: false
+      } : void 0;
     }
     const restParameter = signature.parameters[paramCount] || unknownSymbol;
-    if (!isParameterDeclarationWithIdentifierName(restParameter)) {
+    const restIdent = getParameterDeclarationIdentifier(restParameter);
+    if (!restIdent) {
       return void 0;
     }
     const restType = getTypeOfSymbol(restParameter);
@@ -72092,18 +72145,19 @@ function createTypeChecker(host) {
       const index = pos - paramCount;
       const associatedName = associatedNames == null ? void 0 : associatedNames[index];
       const isRestTupleElement = !!(associatedName == null ? void 0 : associatedName.dotDotDotToken);
-      return associatedName ? [
-        getTupleElementLabel(associatedName),
-        isRestTupleElement
-      ] : void 0;
+      if (associatedName) {
+        Debug.assert(isIdentifier(associatedName.name));
+        return { parameter: associatedName.name, parameterName: associatedName.name.escapedText, isRestParameter: isRestTupleElement };
+      }
+      return void 0;
     }
     if (pos === paramCount) {
-      return [restParameter.escapedName, true];
+      return { parameter: restIdent, parameterName: restParameter.escapedName, isRestParameter: true };
     }
     return void 0;
   }
-  function isParameterDeclarationWithIdentifierName(symbol) {
-    return symbol.valueDeclaration && isParameter(symbol.valueDeclaration) && isIdentifier(symbol.valueDeclaration.name);
+  function getParameterDeclarationIdentifier(symbol) {
+    return symbol.valueDeclaration && isParameter(symbol.valueDeclaration) && isIdentifier(symbol.valueDeclaration.name) && symbol.valueDeclaration.name;
   }
   function isValidDeclarationForTupleLabel(d) {
     return d.kind === 202 /* NamedTupleMember */ || isParameter(d) && d.name && isIdentifier(d.name);
@@ -73362,32 +73416,6 @@ function createTypeChecker(host) {
   function isConstEnumSymbol(symbol) {
     return (symbol.flags & 128 /* ConstEnum */) !== 0;
   }
-  function getSymbolHasInstanceMethodOfObjectType(type) {
-    const hasInstancePropertyName = getPropertyNameForKnownSymbolName("hasInstance");
-    const hasInstanceProperty = getPropertyOfObjectType(type, hasInstancePropertyName);
-    if (hasInstanceProperty) {
-      const hasInstancePropertyType = getTypeOfSymbol(hasInstanceProperty);
-      if (hasInstancePropertyType && getSignaturesOfType(hasInstancePropertyType, 0 /* Call */).length !== 0) {
-        return hasInstancePropertyType;
-      }
-    }
-  }
-  function createSyntheticHasInstanceMethodCall(left, right, leftType, hasInstanceMethodType) {
-    const syntheticExpression = createSyntheticExpression(right, hasInstanceMethodType);
-    const syntheticArgument = createSyntheticExpression(left, leftType);
-    const syntheticCall = parseNodeFactory.createCallExpression(
-      syntheticExpression,
-      /*typeArguments*/
-      void 0,
-      [syntheticArgument]
-    );
-    setParent(syntheticCall, left.parent);
-    setTextRange(syntheticCall, left.parent);
-    return syntheticCall;
-  }
-  function isSyntheticHasInstanceMethodCall(node) {
-    return isSyntheticExpression(node.expression) && node.arguments.length === 1 && isSyntheticExpression(node.arguments[0]) && isBinaryExpression(node.parent) && node.parent.operatorToken.kind === 104 /* InstanceOfKeyword */ && node.parent.right === node.expression.parent && node.parent.left === node.arguments[0].parent;
-  }
   function checkInstanceOfExpression(left, right, leftType, rightType) {
     if (leftType === silentNeverType || rightType === silentNeverType) {
       return silentNeverType;
@@ -73395,31 +73423,8 @@ function createTypeChecker(host) {
     if (!isTypeAny(leftType) && allTypesAssignableToKind(leftType, 402784252 /* Primitive */)) {
       error(left, Diagnostics.The_left_hand_side_of_an_instanceof_expression_must_be_of_type_any_an_object_type_or_a_type_parameter);
     }
-    if (!isTypeAny(rightType)) {
-      const hasInstanceMethodType = getSymbolHasInstanceMethodOfObjectType(rightType);
-      if (hasInstanceMethodType) {
-        const cache = hasInstanceMethodType;
-        if (cache.hasSimpleUnrestrictedSingleCallSignature === void 0) {
-          const signature = getSingleCallSignature(hasInstanceMethodType);
-          cache.hasSimpleUnrestrictedSingleCallSignature = !!signature && signature.parameters.length === 1 && !!(getTypeOfSymbol(signature.parameters[0]).flags & 3 /* AnyOrUnknown */) && !!signature.resolvedReturnType && !!(signature.resolvedReturnType.flags & 16 /* Boolean */);
-        }
-        if (!cache.hasSimpleUnrestrictedSingleCallSignature) {
-          const syntheticCall = createSyntheticHasInstanceMethodCall(left, right, leftType, hasInstanceMethodType);
-          const returnType = getReturnTypeOfSignature(getResolvedSignature(syntheticCall));
-          checkTypeAssignableTo(returnType, booleanType, right, Diagnostics.An_object_s_Symbol_hasInstance_method_must_return_a_boolean_value_for_it_to_be_used_on_the_right_hand_side_of_an_instanceof_expression);
-        }
-      }
-      if (!(hasInstanceMethodType || typeHasCallOrConstructSignatures(rightType) || isTypeSubtypeOf(rightType, globalFunctionType))) {
-        if (hasGlobalSymbolHasInstanceProperty === void 0) {
-          const globalESSymbolConstructorSymbol = getGlobalESSymbolConstructorTypeSymbol(
-            /*reportErrors*/
-            false
-          );
-          hasGlobalSymbolHasInstanceProperty = !!globalESSymbolConstructorSymbol && getMembersOfSymbol(globalESSymbolConstructorSymbol).has("hasInstance");
-        }
-        const message = hasGlobalSymbolHasInstanceProperty ? Diagnostics.The_right_hand_side_of_an_instanceof_expression_must_be_either_of_type_any_an_object_type_with_a_Symbol_hasInstance_method_or_a_type_assignable_to_the_Function_interface_type : Diagnostics.The_right_hand_side_of_an_instanceof_expression_must_be_of_type_any_or_of_a_type_assignable_to_the_Function_interface_type;
-        error(right, message);
-      }
+    if (!(isTypeAny(rightType) || typeHasCallOrConstructSignatures(rightType) || isTypeSubtypeOf(rightType, globalFunctionType))) {
+      error(right, Diagnostics.The_right_hand_side_of_an_instanceof_expression_must_be_of_type_any_or_of_a_type_assignable_to_the_Function_interface_type);
     }
     return booleanType;
   }
@@ -122102,7 +122107,6 @@ function createWatchProgram(host) {
     if (hasChangedCompilerOptions) {
       newLine = updateNewLine();
       if (program && changesAffectModuleResolution(program.getCompilerOptions(), compilerOptions)) {
-        debugger;
         resolutionCache.onChangesAffectModuleResolution();
       }
     }