@typescript-deploys/pr-build 5.2.0-pr-54316-2 → 5.2.0-pr-54377-7

package/lib/tsserverlibrary.js

@@ -35,7 +35,7 @@ var ts = (() => {
     "src/compiler/corePublic.ts"() {
       "use strict";
       versionMajorMinor = "5.2";
-      version = `${versionMajorMinor}.0-insiders.20230518`;
+      version = `${versionMajorMinor}.0-insiders.20230524`;
       Comparison = /* @__PURE__ */ ((Comparison3) => {
         Comparison3[Comparison3["LessThan"] = -1] = "LessThan";
         Comparison3[Comparison3["EqualTo"] = 0] = "EqualTo";
@@ -37258,6 +37258,7 @@ ${lanes.join("\n")}
         ["es2015.symbol", "lib.es2015.symbol.d.ts"],
         ["es2015.symbol.wellknown", "lib.es2015.symbol.wellknown.d.ts"],
         ["es2016.array.include", "lib.es2016.array.include.d.ts"],
+        ["es2017.date", "lib.es2017.date.d.ts"],
         ["es2017.object", "lib.es2017.object.d.ts"],
         ["es2017.sharedmemory", "lib.es2017.sharedmemory.d.ts"],
         ["es2017.string", "lib.es2017.string.d.ts"],
@@ -50343,32 +50344,34 @@ ${lanes.join("\n")}
             const methodDeclaration = signatureToSignatureDeclarationHelper(signature, 172 /* MethodSignature */, context, { name: propertyName, questionToken: optionalToken });
             typeElements.push(preserveCommentsOn(methodDeclaration));
           }
+          if (signatures.length || !optionalToken) {
+            return;
+          }
+        }
+        let propertyTypeNode;
+        if (shouldUsePlaceholderForProperty(propertySymbol, context)) {
+          propertyTypeNode = createElidedInformationPlaceholder(context);
         } else {
-          let propertyTypeNode;
-          if (shouldUsePlaceholderForProperty(propertySymbol, context)) {
-            propertyTypeNode = createElidedInformationPlaceholder(context);
-          } else {
-            if (propertyIsReverseMapped) {
-              context.reverseMappedStack || (context.reverseMappedStack = []);
-              context.reverseMappedStack.push(propertySymbol);
-            }
-            propertyTypeNode = propertyType ? serializeTypeForDeclaration(context, propertyType, propertySymbol, saveEnclosingDeclaration) : factory.createKeywordTypeNode(133 /* AnyKeyword */);
-            if (propertyIsReverseMapped) {
-              context.reverseMappedStack.pop();
-            }
+          if (propertyIsReverseMapped) {
+            context.reverseMappedStack || (context.reverseMappedStack = []);
+            context.reverseMappedStack.push(propertySymbol);
           }
-          const modifiers = isReadonlySymbol(propertySymbol) ? [factory.createToken(148 /* ReadonlyKeyword */)] : void 0;
-          if (modifiers) {
-            context.approximateLength += 9;
+          propertyTypeNode = propertyType ? serializeTypeForDeclaration(context, propertyType, propertySymbol, saveEnclosingDeclaration) : factory.createKeywordTypeNode(133 /* AnyKeyword */);
+          if (propertyIsReverseMapped) {
+            context.reverseMappedStack.pop();
           }
-          const propertySignature = factory.createPropertySignature(
-            modifiers,
-            propertyName,
-            optionalToken,
-            propertyTypeNode
-          );
-          typeElements.push(preserveCommentsOn(propertySignature));
         }
+        const modifiers = isReadonlySymbol(propertySymbol) ? [factory.createToken(148 /* ReadonlyKeyword */)] : void 0;
+        if (modifiers) {
+          context.approximateLength += 9;
+        }
+        const propertySignature = factory.createPropertySignature(
+          modifiers,
+          propertyName,
+          optionalToken,
+          propertyTypeNode
+        );
+        typeElements.push(preserveCommentsOn(propertySignature));
         function preserveCommentsOn(node) {
           var _a2;
           if (some(propertySymbol.declarations, (d) => d.kind === 354 /* JSDocPropertyTag */)) {
@@ -56431,7 +56434,7 @@ ${lanes.join("\n")}
         } else if (type !== firstType) {
           checkFlags |= 64 /* HasNonUniformType */;
         }
-        if (isLiteralType(type) || isPatternLiteralType(type) || type === uniqueLiteralType) {
+        if (isLiteralType(type) || isPatternLiteralType(type)) {
           checkFlags |= 128 /* HasLiteralType */;
         }
         if (type.flags & 131072 /* Never */ && type !== uniqueLiteralType) {
@@ -58658,31 +58661,28 @@ ${lanes.join("\n")}
       return getUnionTypeFromSortedList(typeSet, objectFlags, aliasSymbol, aliasTypeArguments, origin);
     }
     function getUnionOrIntersectionTypePredicate(signatures, kind) {
-      let first2;
+      let last2;
       const types = [];
       for (const sig of signatures) {
         const pred = getTypePredicateOfSignature(sig);
-        if (!pred || pred.kind === 2 /* AssertsThis */ || pred.kind === 3 /* AssertsIdentifier */) {
-          if (kind !== 2097152 /* Intersection */) {
-            continue;
-          } else {
-            return;
-          }
-        }
-        if (first2) {
-          if (!typePredicateKindsMatch(first2, pred)) {
+        if (pred) {
+          if (pred.kind !== 0 /* This */ && pred.kind !== 1 /* Identifier */ || last2 && !typePredicateKindsMatch(last2, pred)) {
             return void 0;
           }
+          last2 = pred;
+          types.push(pred.type);
         } else {
-          first2 = pred;
+          const returnType = kind !== 2097152 /* Intersection */ ? getReturnTypeOfSignature(sig) : void 0;
+          if (returnType !== falseType && returnType !== regularFalseType) {
+            return void 0;
+          }
         }
-        types.push(pred.type);
       }
-      if (!first2) {
+      if (!last2) {
         return void 0;
       }
       const compositeType = getUnionOrIntersectionType(types, kind);
-      return createTypePredicate(first2.kind, first2.parameterName, first2.parameterIndex, compositeType);
+      return createTypePredicate(last2.kind, last2.parameterName, last2.parameterIndex, compositeType);
     }
     function typePredicateKindsMatch(a, b) {
       return a.kind === b.kind && a.parameterIndex === b.parameterIndex;
@@ -59724,9 +59724,9 @@ ${lanes.join("\n")}
           );
           if (freshMapper) {
             const freshCombinedMapper = combineTypeMappers(mapper, freshMapper);
-            for (const p of freshParams) {
-              if (root.inferTypeParameters.indexOf(p) === -1) {
-                p.mapper = freshCombinedMapper;
+            for (let i = 0; i < freshParams.length; i++) {
+              if (freshParams[i] !== root.inferTypeParameters[i]) {
+                freshParams[i].mapper = freshCombinedMapper;
               }
             }
           }
@@ -60563,18 +60563,19 @@ ${lanes.join("\n")}
           case 185 /* TypeQuery */:
             const entityName = node2.exprName;
             const firstIdentifier = getFirstIdentifier(entityName);
-            const firstIdentifierSymbol = getResolvedSymbol(firstIdentifier);
-            const tpDeclaration = tp.symbol.declarations[0];
-            let tpScope;
-            if (tpDeclaration.kind === 167 /* TypeParameter */) {
-              tpScope = tpDeclaration.parent;
-            } else if (tp.isThisType) {
-              tpScope = tpDeclaration;
-            } else {
-              return true;
-            }
-            if (firstIdentifierSymbol.declarations) {
-              return some(firstIdentifierSymbol.declarations, (idDecl) => isNodeDescendantOf(idDecl, tpScope)) || some(node2.typeArguments, containsReference);
+            if (!isThisIdentifier(firstIdentifier)) {
+              const firstIdentifierSymbol = getResolvedSymbol(firstIdentifier);
+              const tpDeclaration = tp.symbol.declarations[0];
+              const tpScope = tpDeclaration.kind === 167 /* TypeParameter */ ? tpDeclaration.parent : (
+                // Type parameter is a regular type parameter, e.g. foo<T>
+                tp.isThisType ? tpDeclaration : (
+                  // Type parameter is the this type, and its declaration is the class declaration.
+                  void 0
+                )
+              );
+              if (firstIdentifierSymbol.declarations && tpScope) {
+                return some(firstIdentifierSymbol.declarations, (idDecl) => isNodeDescendantOf(idDecl, tpScope)) || some(node2.typeArguments, containsReference);
+              }
             }
             return true;
           case 173 /* MethodDeclaration */:
@@ -60628,6 +60629,9 @@ ${lanes.join("\n")}
       const elementFlags = tupleType.target.elementFlags;
       const elementTypes = map(getElementTypes(tupleType), (t, i) => {
         const singleton = elementFlags[i] & 8 /* Variadic */ ? t : elementFlags[i] & 4 /* Rest */ ? createArrayType(t) : createTupleType([t], [elementFlags[i]]);
+        if (singleton === typeVariable) {
+          return mappedType;
+        }
         return instantiateMappedType(mappedType, prependTypeMapping(typeVariable, singleton, mapper));
       });
       const newReadonly = getModifiedReadonlyState(tupleType.target.readonly, getMappedTypeModifiers(mappedType));
@@ -64416,7 +64420,7 @@ ${lanes.join("\n")}
     }
     function getRecursionIdentity(type) {
       if (type.flags & 524288 /* Object */ && !isObjectOrArrayLiteralType(type)) {
-        if (getObjectFlags(type) && 4 /* Reference */ && type.node) {
+        if (getObjectFlags(type) & 4 /* Reference */ && type.node) {
           return type.node;
         }
         if (type.symbol && !(getObjectFlags(type) & 16 /* Anonymous */ && type.symbol.flags & 32 /* Class */)) {
@@ -65191,6 +65195,8 @@ ${lanes.join("\n")}
       return context && context.mapper;
     }
     function couldContainTypeVariables(type) {
+      if (type.flags & 67359327 /* Intrinsic */)
+        return false;
       const objectFlags = getObjectFlags(type);
       if (objectFlags & 524288 /* CouldContainTypeVariablesComputed */) {
         return !!(objectFlags & 1048576 /* CouldContainTypeVariables */);
@@ -76684,7 +76690,7 @@ ${lanes.join("\n")}
       if (getIsolatedModules(compilerOptions)) {
         Debug.assert(!!(type.symbol.flags & 128 /* ConstEnum */));
         const constEnumDeclaration = type.symbol.valueDeclaration;
-        if (constEnumDeclaration.flags & 16777216 /* Ambient */) {
+        if (constEnumDeclaration.flags & 16777216 /* Ambient */ && !isValidTypeOnlyAliasUseSite(node)) {
           error(node, Diagnostics.Cannot_access_ambient_const_enums_when_0_is_enabled, isolatedModulesLikeFlagName);
         }
       }
@@ -77113,6 +77119,9 @@ ${lanes.join("\n")}
             case "length":
             case "caller":
             case "arguments":
+              if (compilerOptions.useDefineForClassFields) {
+                break;
+              }
             case "prototype":
               const message = Diagnostics.Static_property_0_conflicts_with_built_in_property_Function_0_of_constructor_function_1;
               const className = getNameOfSymbolAsWritten(getSymbolOfDeclaration(node));
@@ -84119,7 +84128,7 @@ ${lanes.join("\n")}
                   if (requestedExternalEmitHelperNames.has(name))
                     continue;
                   requestedExternalEmitHelperNames.add(name);
-                  const symbol = getSymbol2(helpersModule.exports, escapeLeadingUnderscores(name), 111551 /* Value */);
+                  const symbol = getSymbol2(getExportsOfModule(helpersModule), escapeLeadingUnderscores(name), 111551 /* Value */);
                   if (!symbol) {
                     error(location, Diagnostics.This_syntax_requires_an_imported_helper_named_1_which_does_not_exist_in_0_Consider_upgrading_your_version_of_0, externalHelpersModuleNameText, name);
                   } else if (helper & 524288 /* ClassPrivateFieldGet */) {
@@ -121831,7 +121840,7 @@ ${lanes.join("\n")}
     let filesWithChangedSetOfUnresolvedImports;
     let filesWithInvalidatedResolutions;
     let filesWithInvalidatedNonRelativeUnresolvedImports;
-    const nonRelativeExternalModuleResolutions = /* @__PURE__ */ new Set();
+    const nonRelativeExternalModuleResolutions = createMultiMap();
     const resolutionsWithFailedLookups = /* @__PURE__ */ new Set();
     const resolutionsWithOnlyAffectingLocations = /* @__PURE__ */ new Set();
     const resolvedFileToResolution = /* @__PURE__ */ new Map();
@@ -121965,7 +121974,8 @@ ${lanes.join("\n")}
       moduleResolutionCache.clearAllExceptPackageJsonInfoCache();
       typeReferenceDirectiveResolutionCache.clearAllExceptPackageJsonInfoCache();
       libraryResolutionCache.clearAllExceptPackageJsonInfoCache();
-      watchFailedLookupLocationOfNonRelativeModuleResolutions();
+      nonRelativeExternalModuleResolutions.forEach(watchFailedLookupLocationOfNonRelativeModuleResolutions);
+      nonRelativeExternalModuleResolutions.clear();
     }
     function cleanupLibResolutionWatching(newProgram) {
       resolvedLibraries.forEach((resolution, libFileName) => {
@@ -121983,7 +121993,8 @@ ${lanes.join("\n")}
     function finishCachingPerDirectoryResolution(newProgram, oldProgram) {
       filesWithInvalidatedNonRelativeUnresolvedImports = void 0;
       allModuleAndTypeResolutionsAreInvalidated = false;
-      watchFailedLookupLocationOfNonRelativeModuleResolutions();
+      nonRelativeExternalModuleResolutions.forEach(watchFailedLookupLocationOfNonRelativeModuleResolutions);
+      nonRelativeExternalModuleResolutions.clear();
       if (newProgram !== oldProgram) {
         cleanupLibResolutionWatching(newProgram);
         newProgram == null ? void 0 : newProgram.getSourceFiles().forEach((newFile) => {
@@ -122264,7 +122275,7 @@ ${lanes.join("\n")}
         if (!deferWatchingNonRelativeResolution || isExternalModuleNameRelative(name)) {
           watchFailedLookupLocationOfResolution(resolution);
         } else {
-          nonRelativeExternalModuleResolutions.add(resolution);
+          nonRelativeExternalModuleResolutions.add(name, resolution);
         }
         const resolved = getResolutionWithResolvedFileName(resolution);
         if (resolved && resolved.resolvedFileName) {
@@ -122394,9 +122405,17 @@ ${lanes.join("\n")}
         paths.add(affectingLocation);
       }
     }
-    function watchFailedLookupLocationOfNonRelativeModuleResolutions() {
-      nonRelativeExternalModuleResolutions.forEach(watchFailedLookupLocationOfResolution);
-      nonRelativeExternalModuleResolutions.clear();
+    function watchFailedLookupLocationOfNonRelativeModuleResolutions(resolutions, name) {
+      const program = resolutionHost.getCurrentProgram();
+      if (!program || !program.getTypeChecker().tryFindAmbientModuleWithoutAugmentations(name)) {
+        resolutions.forEach(watchFailedLookupLocationOfResolution);
+      } else {
+        resolutions.forEach((resolution) => watchAffectingLocationsOfResolution(
+          resolution,
+          /*addToResolutionsWithOnlyAffectingLocations*/
+          true
+        ));
+      }
     }
     function setDirectoryWatcher(dir, dirPath, nonRecursive) {
       const dirWatcher = directoryWatchesOfFailedLookups.get(dirPath);
@@ -134873,10 +134892,9 @@ ${lanes.join("\n")}
 
   // src/services/refactors/moveToFile.ts
   function doChange4(context, oldFile, targetFile, program, toMove, changes, host, preferences) {
-    var _a;
     const checker = program.getTypeChecker();
     const usage = getUsageInfo(oldFile, toMove.all, checker);
-    if (!host.fileExists(targetFile) || host.fileExists(targetFile) && ((_a = program.getSourceFile(targetFile)) == null ? void 0 : _a.statements.length) === 0) {
+    if (!host.fileExists(targetFile)) {
       changes.createNewFile(oldFile, targetFile, getNewStatementsAndRemoveFromOldFile2(oldFile, targetFile, usage, changes, toMove, program, host, preferences));
       addNewFileToTsconfig(program, changes, oldFile.fileName, targetFile, hostGetCanonicalFileName(host));
     } else {
@@ -134914,6 +134932,13 @@ ${lanes.join("\n")}
     if (typeof targetFile !== "string") {
       if (targetFile.statements.length > 0) {
         changes.insertNodesAfter(targetFile, targetFile.statements[targetFile.statements.length - 1], body);
+      } else {
+        changes.insertNodesAtEndOfFile(
+          targetFile,
+          body,
+          /*blankLineBetween*/
+          false
+        );
       }
       if (imports.length > 0) {
         insertImports(
@@ -165869,6 +165894,17 @@ ${newComment.split("\n").map((c) => ` * ${c}`).join("\n")}
             this.insertNodeAt(sourceFile, pos, insert, options);
           }
         }
+        insertNodesAtEndOfFile(sourceFile, newNodes, blankLineBetween) {
+          this.insertAtEndOfFile(sourceFile, newNodes, blankLineBetween);
+        }
+        insertAtEndOfFile(sourceFile, insert, blankLineBetween) {
+          const pos = sourceFile.end + 1;
+          const options = {
+            prefix: this.newLineCharacter,
+            suffix: this.newLineCharacter + (blankLineBetween ? this.newLineCharacter : "")
+          };
+          this.insertNodesAt(sourceFile, pos, insert, options);
+        }
         insertStatementsInNewFile(fileName, statements, oldFile) {
           if (!this.newFileChanges) {
             this.newFileChanges = createMultiMap();

package/lib/typescript.d.ts

@@ -6227,7 +6227,7 @@ declare namespace ts {
          * arguments for any interactive action before offering it.
          */
         getApplicableRefactors(fileName: string, positionOrRange: number | TextRange, preferences: UserPreferences | undefined, triggerReason?: RefactorTriggerReason, kind?: string, includeInteractiveActions?: boolean): ApplicableRefactorInfo[];
-        getEditsForRefactor(fileName: string, formatOptions: FormatCodeSettings, positionOrRange: number | TextRange, refactorName: string, actionName: string, preferences: UserPreferences | undefined, includeInteractiveActions?: InteractiveRefactorArguments): RefactorEditInfo | undefined;
+        getEditsForRefactor(fileName: string, formatOptions: FormatCodeSettings, positionOrRange: number | TextRange, refactorName: string, actionName: string, preferences: UserPreferences | undefined, interactiveRefactorArguments?: InteractiveRefactorArguments): RefactorEditInfo | undefined;
         getMoveToRefactoringFileSuggestions(fileName: string, positionOrRange: number | TextRange, preferences: UserPreferences | undefined, triggerReason?: RefactorTriggerReason, kind?: string): {
             newFileName: string;
             files: string[];