@typescript-deploys/pr-build 5.1.0-pr-53323-7 → 5.1.0-pr-49863-30

package/lib/tsc.js

@@ -6657,7 +6657,6 @@ var Diagnostics = {
   This_condition_will_always_return_0: diag(2845, 1 /* Error */, "This_condition_will_always_return_0_2845", "This condition will always return '{0}'."),
   A_declaration_file_cannot_be_imported_without_import_type_Did_you_mean_to_import_an_implementation_file_0_instead: diag(2846, 1 /* Error */, "A_declaration_file_cannot_be_imported_without_import_type_Did_you_mean_to_import_an_implementation_f_2846", "A declaration file cannot be imported without 'import type'. Did you mean to import an implementation file '{0}' instead?"),
   A_function_whose_declared_type_is_neither_undefined_void_nor_any_must_return_a_value: diag(2847, 1 /* Error */, "A_function_whose_declared_type_is_neither_undefined_void_nor_any_must_return_a_value_2847", "A function whose declared type is neither 'undefined', 'void', nor 'any' must return a value."),
-  The_right_hand_side_of_an_instanceof_expression_must_not_be_an_instantiation_expression: diag(2848, 1 /* Error */, "The_right_hand_side_of_an_instanceof_expression_must_not_be_an_instantiation_expression_2848", "The right-hand side of an 'instanceof' expression must not be an instantiation expression."),
   Import_declaration_0_is_using_private_name_1: diag(4e3, 1 /* Error */, "Import_declaration_0_is_using_private_name_1_4000", "Import declaration '{0}' is using private name '{1}'."),
   Type_parameter_0_of_exported_class_has_or_is_using_private_name_1: diag(4002, 1 /* Error */, "Type_parameter_0_of_exported_class_has_or_is_using_private_name_1_4002", "Type parameter '{0}' of exported class has or is using private name '{1}'."),
   Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1: diag(4004, 1 /* Error */, "Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1_4004", "Type parameter '{0}' of exported interface has or is using private name '{1}'."),
@@ -7335,6 +7334,7 @@ var Diagnostics = {
   Specify_emit_Slashchecking_behavior_for_imports_that_are_only_used_for_types: diag(6718, 3 /* Message */, "Specify_emit_Slashchecking_behavior_for_imports_that_are_only_used_for_types_6718", "Specify emit/checking behavior for imports that are only used for types."),
   Default_catch_clause_variables_as_unknown_instead_of_any: diag(6803, 3 /* Message */, "Default_catch_clause_variables_as_unknown_instead_of_any_6803", "Default catch clause variables as 'unknown' instead of 'any'."),
   Do_not_transform_or_elide_any_imports_or_exports_not_marked_as_type_only_ensuring_they_are_written_in_the_output_file_s_format_based_on_the_module_setting: diag(6804, 3 /* Message */, "Do_not_transform_or_elide_any_imports_or_exports_not_marked_as_type_only_ensuring_they_are_written_i_6804", "Do not transform or elide any imports or exports not marked as type-only, ensuring they are written in the output file's format based on the 'module' setting."),
+  Default_type_arguments_to_parameter_constraint_or_unknown_instead_of_any_for_instance_checks: diag(6805, 3 /* Message */, "Default_type_arguments_to_parameter_constraint_or_unknown_instead_of_any_for_instance_checks_6805", "Default type arguments to parameter constraint or 'unknown' instead of 'any' for instance checks."),
   one_of_Colon: diag(6900, 3 /* Message */, "one_of_Colon_6900", "one of:"),
   one_or_more_Colon: diag(6901, 3 /* Message */, "one_or_more_Colon_6901", "one or more:"),
   type_Colon: diag(6902, 3 /* Message */, "type_Colon_6902", "type:"),
@@ -33860,6 +33860,16 @@ var commandOptionsWithoutBuild = [
     description: Diagnostics.Default_catch_clause_variables_as_unknown_instead_of_any,
     defaultValueDescription: false
   },
+  {
+    name: "strictInstanceOfTypeParameters",
+    type: "boolean",
+    affectsSemanticDiagnostics: true,
+    affectsBuildInfo: true,
+    strictFlag: true,
+    category: Diagnostics.Type_Checking,
+    description: Diagnostics.Default_type_arguments_to_parameter_constraint_or_unknown_instead_of_any_for_instance_checks,
+    defaultValueDescription: false
+  },
   {
     name: "alwaysStrict",
     type: "boolean",
@@ -42663,6 +42673,7 @@ function createTypeChecker(host) {
   var noImplicitAny = getStrictOptionValue(compilerOptions, "noImplicitAny");
   var noImplicitThis = getStrictOptionValue(compilerOptions, "noImplicitThis");
   var useUnknownInCatchVariables = getStrictOptionValue(compilerOptions, "useUnknownInCatchVariables");
+  var strictInstanceOfTypeParameters = getStrictOptionValue(compilerOptions, "strictInstanceOfTypeParameters");
   var keyofStringsOnly = !!compilerOptions.keyofStringsOnly;
   var defaultIndexFlags = keyofStringsOnly ? 1 /* StringsOnly */ : 0 /* None */;
   var freshObjectLiteralFlag = compilerOptions.suppressExcessPropertyErrors ? 0 : 8192 /* FreshLiteral */;
@@ -50629,9 +50640,30 @@ function createTypeChecker(host) {
       }
     }).parent;
   }
+  function getInstanceTypeOfClassSymbol(classSymbol) {
+    const classType = getDeclaredTypeOfSymbol(classSymbol);
+    const objectFlags = getObjectFlags(classType);
+    if (!(objectFlags & 3 /* ClassOrInterface */) || !classType.typeParameters) {
+      return classType;
+    }
+    const variances = getVariances(classType);
+    const typeArguments = map(classType.typeParameters, (typeParameter, i) => {
+      if (!strictInstanceOfTypeParameters) {
+        return anyType;
+      }
+      const variance = variances[i];
+      switch (variance & 7 /* VarianceMask */) {
+        case 2 /* Contravariant */:
+        case 3 /* Bivariant */:
+          return neverType;
+      }
+      return getBaseConstraintOfType(typeParameter) || unknownType;
+    });
+    return createTypeReference(classType, typeArguments);
+  }
   function getTypeOfPrototypeProperty(prototype) {
-    const classType = getDeclaredTypeOfSymbol(getParentOfSymbol(prototype));
-    return classType.typeParameters ? createTypeReference(classType, map(classType.typeParameters, (_) => anyType)) : classType;
+    const classSymbol = getParentOfSymbol(prototype);
+    return getInstanceTypeOfClassSymbol(classSymbol);
   }
   function getTypeOfPropertyOfType(type, name) {
     const prop = getPropertyOfType(type, name);
@@ -65077,8 +65109,8 @@ function createTypeChecker(host) {
       if (symbol === void 0) {
         return type;
       }
-      const classSymbol = symbol.parent;
-      const targetType = hasStaticModifier(Debug.checkDefined(symbol.valueDeclaration, "should always have a declaration")) ? getTypeOfSymbol(classSymbol) : getDeclaredTypeOfSymbol(classSymbol);
+      const classSymbol = getParentOfSymbol(symbol);
+      const targetType = hasStaticModifier(Debug.checkDefined(symbol.valueDeclaration, "should always have a declaration")) ? getTypeOfSymbol(classSymbol) : getInstanceTypeOfClassSymbol(classSymbol);
       return getNarrowedType(
         type,
         targetType,
@@ -71133,12 +71165,6 @@ function createTypeChecker(host) {
   function checkExpressionWithTypeArguments(node) {
     checkGrammarExpressionWithTypeArguments(node);
     forEach(node.typeArguments, checkSourceElement);
-    if (node.kind === 231 /* ExpressionWithTypeArguments */) {
-      const parent = walkUpParenthesizedExpressions(node.parent);
-      if (parent.kind === 224 /* BinaryExpression */ && parent.operatorToken.kind === 103 /* InstanceOfKeyword */ && isNodeDescendantOf(node, parent.right)) {
-        error(node, Diagnostics.The_right_hand_side_of_an_instanceof_expression_must_not_be_an_instantiation_expression);
-      }
-    }
     const exprType = node.kind === 231 /* ExpressionWithTypeArguments */ ? checkExpression(node.expression) : isThisIdentifier(node.exprName) ? checkThisExpression(node.exprName) : checkExpression(node.exprName);
     return getInstantiationExpressionType(exprType, node);
   }

package/lib/tsserver.js

@@ -10119,7 +10119,6 @@ var Diagnostics = {
   This_condition_will_always_return_0: diag(2845, 1 /* Error */, "This_condition_will_always_return_0_2845", "This condition will always return '{0}'."),
   A_declaration_file_cannot_be_imported_without_import_type_Did_you_mean_to_import_an_implementation_file_0_instead: diag(2846, 1 /* Error */, "A_declaration_file_cannot_be_imported_without_import_type_Did_you_mean_to_import_an_implementation_f_2846", "A declaration file cannot be imported without 'import type'. Did you mean to import an implementation file '{0}' instead?"),
   A_function_whose_declared_type_is_neither_undefined_void_nor_any_must_return_a_value: diag(2847, 1 /* Error */, "A_function_whose_declared_type_is_neither_undefined_void_nor_any_must_return_a_value_2847", "A function whose declared type is neither 'undefined', 'void', nor 'any' must return a value."),
-  The_right_hand_side_of_an_instanceof_expression_must_not_be_an_instantiation_expression: diag(2848, 1 /* Error */, "The_right_hand_side_of_an_instanceof_expression_must_not_be_an_instantiation_expression_2848", "The right-hand side of an 'instanceof' expression must not be an instantiation expression."),
   Import_declaration_0_is_using_private_name_1: diag(4e3, 1 /* Error */, "Import_declaration_0_is_using_private_name_1_4000", "Import declaration '{0}' is using private name '{1}'."),
   Type_parameter_0_of_exported_class_has_or_is_using_private_name_1: diag(4002, 1 /* Error */, "Type_parameter_0_of_exported_class_has_or_is_using_private_name_1_4002", "Type parameter '{0}' of exported class has or is using private name '{1}'."),
   Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1: diag(4004, 1 /* Error */, "Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1_4004", "Type parameter '{0}' of exported interface has or is using private name '{1}'."),
@@ -10797,6 +10796,7 @@ var Diagnostics = {
   Specify_emit_Slashchecking_behavior_for_imports_that_are_only_used_for_types: diag(6718, 3 /* Message */, "Specify_emit_Slashchecking_behavior_for_imports_that_are_only_used_for_types_6718", "Specify emit/checking behavior for imports that are only used for types."),
   Default_catch_clause_variables_as_unknown_instead_of_any: diag(6803, 3 /* Message */, "Default_catch_clause_variables_as_unknown_instead_of_any_6803", "Default catch clause variables as 'unknown' instead of 'any'."),
   Do_not_transform_or_elide_any_imports_or_exports_not_marked_as_type_only_ensuring_they_are_written_in_the_output_file_s_format_based_on_the_module_setting: diag(6804, 3 /* Message */, "Do_not_transform_or_elide_any_imports_or_exports_not_marked_as_type_only_ensuring_they_are_written_i_6804", "Do not transform or elide any imports or exports not marked as type-only, ensuring they are written in the output file's format based on the 'module' setting."),
+  Default_type_arguments_to_parameter_constraint_or_unknown_instead_of_any_for_instance_checks: diag(6805, 3 /* Message */, "Default_type_arguments_to_parameter_constraint_or_unknown_instead_of_any_for_instance_checks_6805", "Default type arguments to parameter constraint or 'unknown' instead of 'any' for instance checks."),
   one_of_Colon: diag(6900, 3 /* Message */, "one_of_Colon_6900", "one of:"),
   one_or_more_Colon: diag(6901, 3 /* Message */, "one_or_more_Colon_6901", "one or more:"),
   type_Colon: diag(6902, 3 /* Message */, "type_Colon_6902", "type:"),
@@ -38196,6 +38196,16 @@ var commandOptionsWithoutBuild = [
     description: Diagnostics.Default_catch_clause_variables_as_unknown_instead_of_any,
     defaultValueDescription: false
   },
+  {
+    name: "strictInstanceOfTypeParameters",
+    type: "boolean",
+    affectsSemanticDiagnostics: true,
+    affectsBuildInfo: true,
+    strictFlag: true,
+    category: Diagnostics.Type_Checking,
+    description: Diagnostics.Default_type_arguments_to_parameter_constraint_or_unknown_instead_of_any_for_instance_checks,
+    defaultValueDescription: false
+  },
   {
     name: "alwaysStrict",
     type: "boolean",
@@ -47260,6 +47270,7 @@ function createTypeChecker(host) {
   var noImplicitAny = getStrictOptionValue(compilerOptions, "noImplicitAny");
   var noImplicitThis = getStrictOptionValue(compilerOptions, "noImplicitThis");
   var useUnknownInCatchVariables = getStrictOptionValue(compilerOptions, "useUnknownInCatchVariables");
+  var strictInstanceOfTypeParameters = getStrictOptionValue(compilerOptions, "strictInstanceOfTypeParameters");
   var keyofStringsOnly = !!compilerOptions.keyofStringsOnly;
   var defaultIndexFlags = keyofStringsOnly ? 1 /* StringsOnly */ : 0 /* None */;
   var freshObjectLiteralFlag = compilerOptions.suppressExcessPropertyErrors ? 0 : 8192 /* FreshLiteral */;
@@ -55226,9 +55237,30 @@ function createTypeChecker(host) {
       }
     }).parent;
   }
+  function getInstanceTypeOfClassSymbol(classSymbol) {
+    const classType = getDeclaredTypeOfSymbol(classSymbol);
+    const objectFlags = getObjectFlags(classType);
+    if (!(objectFlags & 3 /* ClassOrInterface */) || !classType.typeParameters) {
+      return classType;
+    }
+    const variances = getVariances(classType);
+    const typeArguments = map(classType.typeParameters, (typeParameter, i) => {
+      if (!strictInstanceOfTypeParameters) {
+        return anyType;
+      }
+      const variance = variances[i];
+      switch (variance & 7 /* VarianceMask */) {
+        case 2 /* Contravariant */:
+        case 3 /* Bivariant */:
+          return neverType;
+      }
+      return getBaseConstraintOfType(typeParameter) || unknownType;
+    });
+    return createTypeReference(classType, typeArguments);
+  }
   function getTypeOfPrototypeProperty(prototype) {
-    const classType = getDeclaredTypeOfSymbol(getParentOfSymbol(prototype));
-    return classType.typeParameters ? createTypeReference(classType, map(classType.typeParameters, (_) => anyType)) : classType;
+    const classSymbol = getParentOfSymbol(prototype);
+    return getInstanceTypeOfClassSymbol(classSymbol);
   }
   function getTypeOfPropertyOfType(type, name) {
     const prop = getPropertyOfType(type, name);
@@ -69674,8 +69706,8 @@ function createTypeChecker(host) {
       if (symbol === void 0) {
         return type;
       }
-      const classSymbol = symbol.parent;
-      const targetType = hasStaticModifier(Debug.checkDefined(symbol.valueDeclaration, "should always have a declaration")) ? getTypeOfSymbol(classSymbol) : getDeclaredTypeOfSymbol(classSymbol);
+      const classSymbol = getParentOfSymbol(symbol);
+      const targetType = hasStaticModifier(Debug.checkDefined(symbol.valueDeclaration, "should always have a declaration")) ? getTypeOfSymbol(classSymbol) : getInstanceTypeOfClassSymbol(classSymbol);
       return getNarrowedType(
         type,
         targetType,
@@ -75730,12 +75762,6 @@ function createTypeChecker(host) {
   function checkExpressionWithTypeArguments(node) {
     checkGrammarExpressionWithTypeArguments(node);
     forEach(node.typeArguments, checkSourceElement);
-    if (node.kind === 231 /* ExpressionWithTypeArguments */) {
-      const parent2 = walkUpParenthesizedExpressions(node.parent);
-      if (parent2.kind === 224 /* BinaryExpression */ && parent2.operatorToken.kind === 103 /* InstanceOfKeyword */ && isNodeDescendantOf(node, parent2.right)) {
-        error(node, Diagnostics.The_right_hand_side_of_an_instanceof_expression_must_not_be_an_instantiation_expression);
-      }
-    }
     const exprType = node.kind === 231 /* ExpressionWithTypeArguments */ ? checkExpression(node.expression) : isThisIdentifier(node.exprName) ? checkThisExpression(node.exprName) : checkExpression(node.exprName);
     return getInstantiationExpressionType(exprType, node);
   }

package/lib/tsserverlibrary.d.ts

@@ -7141,6 +7141,7 @@ declare namespace ts {
         strictBindCallApply?: boolean;
         strictNullChecks?: boolean;
         strictPropertyInitialization?: boolean;
+        strictInstanceOfTypeParameters?: boolean;
         stripInternal?: boolean;
         suppressExcessPropertyErrors?: boolean;
         suppressImplicitAnyIndexErrors?: boolean;

package/lib/tsserverlibrary.js

@@ -7943,7 +7943,6 @@ ${lanes.join("\n")}
         This_condition_will_always_return_0: diag(2845, 1 /* Error */, "This_condition_will_always_return_0_2845", "This condition will always return '{0}'."),
         A_declaration_file_cannot_be_imported_without_import_type_Did_you_mean_to_import_an_implementation_file_0_instead: diag(2846, 1 /* Error */, "A_declaration_file_cannot_be_imported_without_import_type_Did_you_mean_to_import_an_implementation_f_2846", "A declaration file cannot be imported without 'import type'. Did you mean to import an implementation file '{0}' instead?"),
         A_function_whose_declared_type_is_neither_undefined_void_nor_any_must_return_a_value: diag(2847, 1 /* Error */, "A_function_whose_declared_type_is_neither_undefined_void_nor_any_must_return_a_value_2847", "A function whose declared type is neither 'undefined', 'void', nor 'any' must return a value."),
-        The_right_hand_side_of_an_instanceof_expression_must_not_be_an_instantiation_expression: diag(2848, 1 /* Error */, "The_right_hand_side_of_an_instanceof_expression_must_not_be_an_instantiation_expression_2848", "The right-hand side of an 'instanceof' expression must not be an instantiation expression."),
         Import_declaration_0_is_using_private_name_1: diag(4e3, 1 /* Error */, "Import_declaration_0_is_using_private_name_1_4000", "Import declaration '{0}' is using private name '{1}'."),
         Type_parameter_0_of_exported_class_has_or_is_using_private_name_1: diag(4002, 1 /* Error */, "Type_parameter_0_of_exported_class_has_or_is_using_private_name_1_4002", "Type parameter '{0}' of exported class has or is using private name '{1}'."),
         Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1: diag(4004, 1 /* Error */, "Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1_4004", "Type parameter '{0}' of exported interface has or is using private name '{1}'."),
@@ -8621,6 +8620,7 @@ ${lanes.join("\n")}
         Specify_emit_Slashchecking_behavior_for_imports_that_are_only_used_for_types: diag(6718, 3 /* Message */, "Specify_emit_Slashchecking_behavior_for_imports_that_are_only_used_for_types_6718", "Specify emit/checking behavior for imports that are only used for types."),
         Default_catch_clause_variables_as_unknown_instead_of_any: diag(6803, 3 /* Message */, "Default_catch_clause_variables_as_unknown_instead_of_any_6803", "Default catch clause variables as 'unknown' instead of 'any'."),
         Do_not_transform_or_elide_any_imports_or_exports_not_marked_as_type_only_ensuring_they_are_written_in_the_output_file_s_format_based_on_the_module_setting: diag(6804, 3 /* Message */, "Do_not_transform_or_elide_any_imports_or_exports_not_marked_as_type_only_ensuring_they_are_written_i_6804", "Do not transform or elide any imports or exports not marked as type-only, ensuring they are written in the output file's format based on the 'module' setting."),
+        Default_type_arguments_to_parameter_constraint_or_unknown_instead_of_any_for_instance_checks: diag(6805, 3 /* Message */, "Default_type_arguments_to_parameter_constraint_or_unknown_instead_of_any_for_instance_checks_6805", "Default type arguments to parameter constraint or 'unknown' instead of 'any' for instance checks."),
         one_of_Colon: diag(6900, 3 /* Message */, "one_of_Colon_6900", "one of:"),
         one_or_more_Colon: diag(6901, 3 /* Message */, "one_or_more_Colon_6901", "one or more:"),
         type_Colon: diag(6902, 3 /* Message */, "type_Colon_6902", "type:"),
@@ -37850,6 +37850,16 @@ ${lanes.join("\n")}
           description: Diagnostics.Default_catch_clause_variables_as_unknown_instead_of_any,
           defaultValueDescription: false
         },
+        {
+          name: "strictInstanceOfTypeParameters",
+          type: "boolean",
+          affectsSemanticDiagnostics: true,
+          affectsBuildInfo: true,
+          strictFlag: true,
+          category: Diagnostics.Type_Checking,
+          description: Diagnostics.Default_type_arguments_to_parameter_constraint_or_unknown_instead_of_any_for_instance_checks,
+          defaultValueDescription: false
+        },
         {
           name: "alwaysStrict",
           type: "boolean",
@@ -45070,6 +45080,7 @@ ${lanes.join("\n")}
     var noImplicitAny = getStrictOptionValue(compilerOptions, "noImplicitAny");
     var noImplicitThis = getStrictOptionValue(compilerOptions, "noImplicitThis");
     var useUnknownInCatchVariables = getStrictOptionValue(compilerOptions, "useUnknownInCatchVariables");
+    var strictInstanceOfTypeParameters = getStrictOptionValue(compilerOptions, "strictInstanceOfTypeParameters");
     var keyofStringsOnly = !!compilerOptions.keyofStringsOnly;
     var defaultIndexFlags = keyofStringsOnly ? 1 /* StringsOnly */ : 0 /* None */;
     var freshObjectLiteralFlag = compilerOptions.suppressExcessPropertyErrors ? 0 : 8192 /* FreshLiteral */;
@@ -53036,9 +53047,30 @@ ${lanes.join("\n")}
         }
       }).parent;
     }
+    function getInstanceTypeOfClassSymbol(classSymbol) {
+      const classType = getDeclaredTypeOfSymbol(classSymbol);
+      const objectFlags = getObjectFlags(classType);
+      if (!(objectFlags & 3 /* ClassOrInterface */) || !classType.typeParameters) {
+        return classType;
+      }
+      const variances = getVariances(classType);
+      const typeArguments = map(classType.typeParameters, (typeParameter, i) => {
+        if (!strictInstanceOfTypeParameters) {
+          return anyType;
+        }
+        const variance = variances[i];
+        switch (variance & 7 /* VarianceMask */) {
+          case 2 /* Contravariant */:
+          case 3 /* Bivariant */:
+            return neverType;
+        }
+        return getBaseConstraintOfType(typeParameter) || unknownType;
+      });
+      return createTypeReference(classType, typeArguments);
+    }
     function getTypeOfPrototypeProperty(prototype) {
-      const classType = getDeclaredTypeOfSymbol(getParentOfSymbol(prototype));
-      return classType.typeParameters ? createTypeReference(classType, map(classType.typeParameters, (_) => anyType)) : classType;
+      const classSymbol = getParentOfSymbol(prototype);
+      return getInstanceTypeOfClassSymbol(classSymbol);
     }
     function getTypeOfPropertyOfType(type, name) {
       const prop = getPropertyOfType(type, name);
@@ -67484,8 +67516,8 @@ ${lanes.join("\n")}
         if (symbol === void 0) {
           return type;
         }
-        const classSymbol = symbol.parent;
-        const targetType = hasStaticModifier(Debug.checkDefined(symbol.valueDeclaration, "should always have a declaration")) ? getTypeOfSymbol(classSymbol) : getDeclaredTypeOfSymbol(classSymbol);
+        const classSymbol = getParentOfSymbol(symbol);
+        const targetType = hasStaticModifier(Debug.checkDefined(symbol.valueDeclaration, "should always have a declaration")) ? getTypeOfSymbol(classSymbol) : getInstanceTypeOfClassSymbol(classSymbol);
         return getNarrowedType(
           type,
           targetType,
@@ -73540,12 +73572,6 @@ ${lanes.join("\n")}
     function checkExpressionWithTypeArguments(node) {
       checkGrammarExpressionWithTypeArguments(node);
       forEach(node.typeArguments, checkSourceElement);
-      if (node.kind === 231 /* ExpressionWithTypeArguments */) {
-        const parent2 = walkUpParenthesizedExpressions(node.parent);
-        if (parent2.kind === 224 /* BinaryExpression */ && parent2.operatorToken.kind === 103 /* InstanceOfKeyword */ && isNodeDescendantOf(node, parent2.right)) {
-          error(node, Diagnostics.The_right_hand_side_of_an_instanceof_expression_must_not_be_an_instantiation_expression);
-        }
-      }
       const exprType = node.kind === 231 /* ExpressionWithTypeArguments */ ? checkExpression(node.expression) : isThisIdentifier(node.exprName) ? checkThisExpression(node.exprName) : checkExpression(node.exprName);
       return getInstantiationExpressionType(exprType, node);
     }

package/lib/typescript.d.ts

@@ -3198,6 +3198,7 @@ declare namespace ts {
         strictBindCallApply?: boolean;
         strictNullChecks?: boolean;
         strictPropertyInitialization?: boolean;
+        strictInstanceOfTypeParameters?: boolean;
         stripInternal?: boolean;
         suppressExcessPropertyErrors?: boolean;
         suppressImplicitAnyIndexErrors?: boolean;

package/lib/typescript.js

@@ -7943,7 +7943,6 @@ ${lanes.join("\n")}
         This_condition_will_always_return_0: diag(2845, 1 /* Error */, "This_condition_will_always_return_0_2845", "This condition will always return '{0}'."),
         A_declaration_file_cannot_be_imported_without_import_type_Did_you_mean_to_import_an_implementation_file_0_instead: diag(2846, 1 /* Error */, "A_declaration_file_cannot_be_imported_without_import_type_Did_you_mean_to_import_an_implementation_f_2846", "A declaration file cannot be imported without 'import type'. Did you mean to import an implementation file '{0}' instead?"),
         A_function_whose_declared_type_is_neither_undefined_void_nor_any_must_return_a_value: diag(2847, 1 /* Error */, "A_function_whose_declared_type_is_neither_undefined_void_nor_any_must_return_a_value_2847", "A function whose declared type is neither 'undefined', 'void', nor 'any' must return a value."),
-        The_right_hand_side_of_an_instanceof_expression_must_not_be_an_instantiation_expression: diag(2848, 1 /* Error */, "The_right_hand_side_of_an_instanceof_expression_must_not_be_an_instantiation_expression_2848", "The right-hand side of an 'instanceof' expression must not be an instantiation expression."),
         Import_declaration_0_is_using_private_name_1: diag(4e3, 1 /* Error */, "Import_declaration_0_is_using_private_name_1_4000", "Import declaration '{0}' is using private name '{1}'."),
         Type_parameter_0_of_exported_class_has_or_is_using_private_name_1: diag(4002, 1 /* Error */, "Type_parameter_0_of_exported_class_has_or_is_using_private_name_1_4002", "Type parameter '{0}' of exported class has or is using private name '{1}'."),
         Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1: diag(4004, 1 /* Error */, "Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1_4004", "Type parameter '{0}' of exported interface has or is using private name '{1}'."),
@@ -8621,6 +8620,7 @@ ${lanes.join("\n")}
         Specify_emit_Slashchecking_behavior_for_imports_that_are_only_used_for_types: diag(6718, 3 /* Message */, "Specify_emit_Slashchecking_behavior_for_imports_that_are_only_used_for_types_6718", "Specify emit/checking behavior for imports that are only used for types."),
         Default_catch_clause_variables_as_unknown_instead_of_any: diag(6803, 3 /* Message */, "Default_catch_clause_variables_as_unknown_instead_of_any_6803", "Default catch clause variables as 'unknown' instead of 'any'."),
         Do_not_transform_or_elide_any_imports_or_exports_not_marked_as_type_only_ensuring_they_are_written_in_the_output_file_s_format_based_on_the_module_setting: diag(6804, 3 /* Message */, "Do_not_transform_or_elide_any_imports_or_exports_not_marked_as_type_only_ensuring_they_are_written_i_6804", "Do not transform or elide any imports or exports not marked as type-only, ensuring they are written in the output file's format based on the 'module' setting."),
+        Default_type_arguments_to_parameter_constraint_or_unknown_instead_of_any_for_instance_checks: diag(6805, 3 /* Message */, "Default_type_arguments_to_parameter_constraint_or_unknown_instead_of_any_for_instance_checks_6805", "Default type arguments to parameter constraint or 'unknown' instead of 'any' for instance checks."),
         one_of_Colon: diag(6900, 3 /* Message */, "one_of_Colon_6900", "one of:"),
         one_or_more_Colon: diag(6901, 3 /* Message */, "one_or_more_Colon_6901", "one or more:"),
         type_Colon: diag(6902, 3 /* Message */, "type_Colon_6902", "type:"),
@@ -37850,6 +37850,16 @@ ${lanes.join("\n")}
           description: Diagnostics.Default_catch_clause_variables_as_unknown_instead_of_any,
           defaultValueDescription: false
         },
+        {
+          name: "strictInstanceOfTypeParameters",
+          type: "boolean",
+          affectsSemanticDiagnostics: true,
+          affectsBuildInfo: true,
+          strictFlag: true,
+          category: Diagnostics.Type_Checking,
+          description: Diagnostics.Default_type_arguments_to_parameter_constraint_or_unknown_instead_of_any_for_instance_checks,
+          defaultValueDescription: false
+        },
         {
           name: "alwaysStrict",
           type: "boolean",
@@ -45070,6 +45080,7 @@ ${lanes.join("\n")}
     var noImplicitAny = getStrictOptionValue(compilerOptions, "noImplicitAny");
     var noImplicitThis = getStrictOptionValue(compilerOptions, "noImplicitThis");
     var useUnknownInCatchVariables = getStrictOptionValue(compilerOptions, "useUnknownInCatchVariables");
+    var strictInstanceOfTypeParameters = getStrictOptionValue(compilerOptions, "strictInstanceOfTypeParameters");
     var keyofStringsOnly = !!compilerOptions.keyofStringsOnly;
     var defaultIndexFlags = keyofStringsOnly ? 1 /* StringsOnly */ : 0 /* None */;
     var freshObjectLiteralFlag = compilerOptions.suppressExcessPropertyErrors ? 0 : 8192 /* FreshLiteral */;
@@ -53036,9 +53047,30 @@ ${lanes.join("\n")}
         }
       }).parent;
     }
+    function getInstanceTypeOfClassSymbol(classSymbol) {
+      const classType = getDeclaredTypeOfSymbol(classSymbol);
+      const objectFlags = getObjectFlags(classType);
+      if (!(objectFlags & 3 /* ClassOrInterface */) || !classType.typeParameters) {
+        return classType;
+      }
+      const variances = getVariances(classType);
+      const typeArguments = map(classType.typeParameters, (typeParameter, i) => {
+        if (!strictInstanceOfTypeParameters) {
+          return anyType;
+        }
+        const variance = variances[i];
+        switch (variance & 7 /* VarianceMask */) {
+          case 2 /* Contravariant */:
+          case 3 /* Bivariant */:
+            return neverType;
+        }
+        return getBaseConstraintOfType(typeParameter) || unknownType;
+      });
+      return createTypeReference(classType, typeArguments);
+    }
     function getTypeOfPrototypeProperty(prototype) {
-      const classType = getDeclaredTypeOfSymbol(getParentOfSymbol(prototype));
-      return classType.typeParameters ? createTypeReference(classType, map(classType.typeParameters, (_) => anyType)) : classType;
+      const classSymbol = getParentOfSymbol(prototype);
+      return getInstanceTypeOfClassSymbol(classSymbol);
     }
     function getTypeOfPropertyOfType(type, name) {
       const prop = getPropertyOfType(type, name);
@@ -67484,8 +67516,8 @@ ${lanes.join("\n")}
         if (symbol === void 0) {
           return type;
         }
-        const classSymbol = symbol.parent;
-        const targetType = hasStaticModifier(Debug.checkDefined(symbol.valueDeclaration, "should always have a declaration")) ? getTypeOfSymbol(classSymbol) : getDeclaredTypeOfSymbol(classSymbol);
+        const classSymbol = getParentOfSymbol(symbol);
+        const targetType = hasStaticModifier(Debug.checkDefined(symbol.valueDeclaration, "should always have a declaration")) ? getTypeOfSymbol(classSymbol) : getInstanceTypeOfClassSymbol(classSymbol);
         return getNarrowedType(
           type,
           targetType,
@@ -73540,12 +73572,6 @@ ${lanes.join("\n")}
     function checkExpressionWithTypeArguments(node) {
       checkGrammarExpressionWithTypeArguments(node);
       forEach(node.typeArguments, checkSourceElement);
-      if (node.kind === 231 /* ExpressionWithTypeArguments */) {
-        const parent2 = walkUpParenthesizedExpressions(node.parent);
-        if (parent2.kind === 224 /* BinaryExpression */ && parent2.operatorToken.kind === 103 /* InstanceOfKeyword */ && isNodeDescendantOf(node, parent2.right)) {
-          error(node, Diagnostics.The_right_hand_side_of_an_instanceof_expression_must_not_be_an_instantiation_expression);
-        }
-      }
       const exprType = node.kind === 231 /* ExpressionWithTypeArguments */ ? checkExpression(node.expression) : isThisIdentifier(node.exprName) ? checkThisExpression(node.exprName) : checkExpression(node.exprName);
       return getInstantiationExpressionType(exprType, node);
     }

package/lib/typingsInstaller.js

@@ -6013,7 +6013,6 @@ var Diagnostics = {
   This_condition_will_always_return_0: diag(2845, 1 /* Error */, "This_condition_will_always_return_0_2845", "This condition will always return '{0}'."),
   A_declaration_file_cannot_be_imported_without_import_type_Did_you_mean_to_import_an_implementation_file_0_instead: diag(2846, 1 /* Error */, "A_declaration_file_cannot_be_imported_without_import_type_Did_you_mean_to_import_an_implementation_f_2846", "A declaration file cannot be imported without 'import type'. Did you mean to import an implementation file '{0}' instead?"),
   A_function_whose_declared_type_is_neither_undefined_void_nor_any_must_return_a_value: diag(2847, 1 /* Error */, "A_function_whose_declared_type_is_neither_undefined_void_nor_any_must_return_a_value_2847", "A function whose declared type is neither 'undefined', 'void', nor 'any' must return a value."),
-  The_right_hand_side_of_an_instanceof_expression_must_not_be_an_instantiation_expression: diag(2848, 1 /* Error */, "The_right_hand_side_of_an_instanceof_expression_must_not_be_an_instantiation_expression_2848", "The right-hand side of an 'instanceof' expression must not be an instantiation expression."),
   Import_declaration_0_is_using_private_name_1: diag(4e3, 1 /* Error */, "Import_declaration_0_is_using_private_name_1_4000", "Import declaration '{0}' is using private name '{1}'."),
   Type_parameter_0_of_exported_class_has_or_is_using_private_name_1: diag(4002, 1 /* Error */, "Type_parameter_0_of_exported_class_has_or_is_using_private_name_1_4002", "Type parameter '{0}' of exported class has or is using private name '{1}'."),
   Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1: diag(4004, 1 /* Error */, "Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1_4004", "Type parameter '{0}' of exported interface has or is using private name '{1}'."),
@@ -6691,6 +6690,7 @@ var Diagnostics = {
   Specify_emit_Slashchecking_behavior_for_imports_that_are_only_used_for_types: diag(6718, 3 /* Message */, "Specify_emit_Slashchecking_behavior_for_imports_that_are_only_used_for_types_6718", "Specify emit/checking behavior for imports that are only used for types."),
   Default_catch_clause_variables_as_unknown_instead_of_any: diag(6803, 3 /* Message */, "Default_catch_clause_variables_as_unknown_instead_of_any_6803", "Default catch clause variables as 'unknown' instead of 'any'."),
   Do_not_transform_or_elide_any_imports_or_exports_not_marked_as_type_only_ensuring_they_are_written_in_the_output_file_s_format_based_on_the_module_setting: diag(6804, 3 /* Message */, "Do_not_transform_or_elide_any_imports_or_exports_not_marked_as_type_only_ensuring_they_are_written_i_6804", "Do not transform or elide any imports or exports not marked as type-only, ensuring they are written in the output file's format based on the 'module' setting."),
+  Default_type_arguments_to_parameter_constraint_or_unknown_instead_of_any_for_instance_checks: diag(6805, 3 /* Message */, "Default_type_arguments_to_parameter_constraint_or_unknown_instead_of_any_for_instance_checks_6805", "Default type arguments to parameter constraint or 'unknown' instead of 'any' for instance checks."),
   one_of_Colon: diag(6900, 3 /* Message */, "one_of_Colon_6900", "one of:"),
   one_or_more_Colon: diag(6901, 3 /* Message */, "one_or_more_Colon_6901", "one or more:"),
   type_Colon: diag(6902, 3 /* Message */, "type_Colon_6902", "type:"),
@@ -25899,6 +25899,16 @@ var commandOptionsWithoutBuild = [
     description: Diagnostics.Default_catch_clause_variables_as_unknown_instead_of_any,
     defaultValueDescription: false
   },
+  {
+    name: "strictInstanceOfTypeParameters",
+    type: "boolean",
+    affectsSemanticDiagnostics: true,
+    affectsBuildInfo: true,
+    strictFlag: true,
+    category: Diagnostics.Type_Checking,
+    description: Diagnostics.Default_type_arguments_to_parameter_constraint_or_unknown_instead_of_any_for_instance_checks,
+    defaultValueDescription: false
+  },
   {
     name: "alwaysStrict",
     type: "boolean",

package/package.json

@@ -2,7 +2,7 @@
   "name": "@typescript-deploys/pr-build",
   "author": "Microsoft Corp.",
   "homepage": "https://www.typescriptlang.org/",
-  "version": "5.1.0-pr-53323-7",
+  "version": "5.1.0-pr-49863-30",
   "license": "Apache-2.0",
   "description": "TypeScript is a language for application scale JavaScript development",
   "keywords": [
@@ -114,5 +114,5 @@
     "node": "14.21.1",
     "npm": "8.19.3"
   },
-  "gitHead": "3d60ad2cd19401f448daf69a3403fbdb7fdfb4c8"
+  "gitHead": "d7bc48b2c37340e8455e02112a20d6fca773bbe7"
 }