@typescript-deploys/pr-build 4.7.0-pr-47461-10 → 4.7.0-pr-48861-7

package/lib/tsc.js

@@ -69,7 +69,7 @@ var __generator = (this && this.__generator) || function (thisArg, body) {
 var ts;
 (function (ts) {
     ts.versionMajorMinor = "4.7";
-    ts.version = ts.versionMajorMinor + ".0-insiders.20220425";
+    ts.version = ts.versionMajorMinor + ".0-insiders.20220427";
     var NativeCollections;
     (function (NativeCollections) {
         var globals = typeof globalThis !== "undefined" ? globalThis :
@@ -13561,19 +13561,11 @@ var ts;
         return !!name && isDynamicName(name);
     }
     ts.hasDynamicName = hasDynamicName;
-    function getComputedPropertyNameExpression(name) {
-        return ts.isElementAccessExpression(name.expression)
-            ? skipParentheses(name.expression.argumentExpression)
-            : name.expression;
-    }
-    ts.getComputedPropertyNameExpression = getComputedPropertyNameExpression;
     function isDynamicName(name) {
         if (!(name.kind === 162 || name.kind === 207)) {
             return false;
         }
-        var expr = ts.isElementAccessExpression(name)
-            ? skipParentheses(name.argumentExpression)
-            : getComputedPropertyNameExpression(name);
+        var expr = ts.isElementAccessExpression(name) ? skipParentheses(name.argumentExpression) : name.expression;
         return !isStringOrNumericLiteralLike(expr) &&
             !isSignedNumericLiteral(expr);
     }
@@ -13587,7 +13579,7 @@ var ts;
             case 8:
                 return ts.escapeLeadingUnderscores(name.text);
             case 162:
-                var nameExpression = getComputedPropertyNameExpression(name);
+                var nameExpression = name.expression;
                 if (isStringOrNumericLiteralLike(nameExpression)) {
                     return ts.escapeLeadingUnderscores(nameExpression.text);
                 }
@@ -36345,7 +36337,7 @@ var ts;
                     return (ts.isGlobalScopeAugmentation(node) ? "__global" : "\"" + moduleName + "\"");
                 }
                 if (name.kind === 162) {
-                    var nameExpression = ts.getComputedPropertyNameExpression(name);
+                    var nameExpression = name.expression;
                     if (ts.isStringOrNumericLiteralLike(nameExpression)) {
                         return ts.escapeLeadingUnderscores(nameExpression.text);
                     }
@@ -39576,6 +39568,7 @@ var ts;
         var keyofConstraintType = keyofStringsOnly ? stringType : stringNumberSymbolType;
         var numberOrBigIntType = getUnionType([numberType, bigintType]);
         var templateConstraintType = getUnionType([stringType, numberType, booleanType, bigintType, nullType, undefinedType]);
+        var numericStringType = getTemplateLiteralType(["", ""], [numberType]);
         var restrictiveMapper = makeFunctionTypeMapper(function (t) { return t.flags & 262144 ? getRestrictiveTypeParameter(t) : t; });
         var permissiveMapper = makeFunctionTypeMapper(function (t) { return t.flags & 262144 ? wildcardType : t; });
         var uniqueLiteralType = createIntrinsicType(131072, "never");
@@ -42170,7 +42163,7 @@ var ts;
             }
         }
         function getExportSymbolOfValueSymbolIfExported(symbol) {
-            return getMergedSymbol(symbol && (symbol.flags & 1048576) !== 0 ? symbol.exportSymbol : symbol);
+            return getMergedSymbol(symbol && (symbol.flags & 1048576) !== 0 && symbol.exportSymbol || symbol);
         }
         function symbolIsValue(symbol) {
             return !!(symbol.flags & 111551 || symbol.flags & 2097152 && resolveAlias(symbol).flags & 111551 && !getTypeOnlyAliasDeclaration(symbol));
@@ -48565,7 +48558,7 @@ var ts;
             var typeVariable = getHomomorphicTypeVariable(type);
             if (typeVariable && !type.declaration.nameType) {
                 var constraint = getConstraintOfTypeParameter(typeVariable);
-                if (constraint && (isArrayType(constraint) || isTupleType(constraint))) {
+                if (constraint && isArrayOrTupleType(constraint)) {
                     return instantiateType(type, prependTypeMapping(typeVariable, constraint, type.mapper));
                 }
             }
@@ -48874,7 +48867,7 @@ var ts;
         function isApplicableIndexType(source, target) {
             return isTypeAssignableTo(source, target) ||
                 target === stringType && isTypeAssignableTo(source, numberType) ||
-                target === numberType && !!(source.flags & 128) && ts.isNumericLiteralName(source.value);
+                target === numberType && (source === numericStringType || !!(source.flags & 128) && ts.isNumericLiteralName(source.value));
         }
         function getIndexInfosOfStructuredType(type) {
             if (type.flags & 3670016) {
@@ -49780,6 +49773,18 @@ var ts;
                         constraints = ts.append(constraints, constraint);
                     }
                 }
+                else if (type.flags & 262144 && parent.kind === 195 && node === parent.type) {
+                    var mappedType = getTypeFromTypeNode(parent);
+                    if (getTypeParameterFromMappedType(mappedType) === getActualTypeVariable(type)) {
+                        var typeParameter = getHomomorphicTypeVariable(mappedType);
+                        if (typeParameter) {
+                            var constraint = getConstraintOfTypeParameter(typeParameter);
+                            if (constraint && everyType(constraint, isArrayOrTupleType)) {
+                                constraints = ts.append(constraints, getUnionType([numberType, numericStringType]));
+                            }
+                        }
+                    }
+                }
                 node = parent;
             }
             return constraints ? getSubstitutionType(type, getIntersectionType(ts.append(constraints, type))) : type;
@@ -50666,7 +50671,7 @@ var ts;
             while (i > 0) {
                 i--;
                 var t = types[i];
-                var remove = t.flags & 4 && includes & 128 ||
+                var remove = t.flags & 4 && includes & (128 | 134217728 | 268435456) ||
                     t.flags & 8 && includes & 256 ||
                     t.flags & 64 && includes & 2048 ||
                     t.flags & 4096 && includes & 8192;
@@ -50789,7 +50794,7 @@ var ts;
             if (!strictNullChecks && includes & 98304) {
                 return includes & 32768 ? undefinedType : nullType;
             }
-            if (includes & 4 && includes & 128 ||
+            if (includes & 4 && includes & (128 | 134217728 | 268435456) ||
                 includes & 8 && includes & 256 ||
                 includes & 64 && includes & 2048 ||
                 includes & 4096 && includes & 8192) {
@@ -52457,7 +52462,7 @@ var ts;
                             if (!type.declaration.nameType) {
                                 var constraint = void 0;
                                 if (isArrayType(t) || t.flags & 1 && findResolutionCycleStartIndex(typeVariable, 4) < 0 &&
-                                    (constraint = getConstraintOfTypeParameter(typeVariable)) && everyType(constraint, ts.or(isArrayType, isTupleType))) {
+                                    (constraint = getConstraintOfTypeParameter(typeVariable)) && everyType(constraint, isArrayOrTupleType)) {
                                     return instantiateMappedArrayType(t, type, prependTypeMapping(typeVariable, t, mapper));
                                 }
                                 if (isGenericTupleType(t)) {
@@ -53752,7 +53757,7 @@ var ts;
                         }
                         return false;
                     }
-                    return isTupleType(target) || isArrayType(target);
+                    return isArrayOrTupleType(target);
                 }
                 if (isReadonlyArrayType(source) && isMutableArrayOrTuple(target)) {
                     if (reportErrors) {
@@ -53848,7 +53853,7 @@ var ts;
                         unionOrIntersectionRelatedTo(source, target, reportErrors, intersectionState) :
                         recursiveTypeRelatedTo(source, target, reportErrors, intersectionState, recursionFlags);
                     if (result_7 && !inPropertyCheck && (target.flags & 2097152 && (isPerformingExcessPropertyChecks || isPerformingCommonPropertyChecks) ||
-                        isNonGenericObjectType(target) && !isArrayType(target) && !isTupleType(target) && source.flags & 2097152 && getApparentType(source).flags & 3670016 && !ts.some(source.types, function (t) { return !!(ts.getObjectFlags(t) & 262144); }))) {
+                        isNonGenericObjectType(target) && !isArrayOrTupleType(target) && source.flags & 2097152 && getApparentType(source).flags & 3670016 && !ts.some(source.types, function (t) { return !!(ts.getObjectFlags(t) & 262144); }))) {
                         inPropertyCheck = true;
                         result_7 &= recursiveTypeRelatedTo(source, target, reportErrors, 4, recursionFlags);
                         inPropertyCheck = false;
@@ -54383,6 +54388,18 @@ var ts;
                             }
                         }
                     }
+                    if (relation === comparableRelation && sourceFlags & 262144) {
+                        var constraint = getConstraintOfTypeParameter(source);
+                        if (constraint && hasNonCircularBaseConstraint(source)) {
+                            while (constraint && constraint.flags & 262144) {
+                                if (result = isRelatedTo(constraint, target, 1, false)) {
+                                    return result;
+                                }
+                                constraint = getConstraintOfTypeParameter(constraint);
+                            }
+                        }
+                        return 0;
+                    }
                 }
                 else if (targetFlags & 4194304) {
                     var targetType_1 = target.type;
@@ -54533,18 +54550,18 @@ var ts;
                 }
                 if (sourceFlags & 8650752) {
                     if (!(sourceFlags & 8388608 && targetFlags & 8388608)) {
-                        var constraint = getConstraintOfType(source);
+                        var constraint = getConstraintOfType(source) || unknownType;
                         if (!strictNullChecks && (!constraint || (sourceFlags & 262144 && constraint.flags & 1))) {
                             if (result = isRelatedTo(emptyObjectType, extractTypesOfKind(target, ~67108864), 3)) {
                                 resetErrorInfo(saveErrorInfo);
                                 return result;
                             }
                         }
-                        else if (constraint && (result = isRelatedTo(constraint, target, 1, false, undefined, intersectionState))) {
+                        else if (result = isRelatedTo(constraint, target, 1, false, undefined, intersectionState)) {
                             resetErrorInfo(saveErrorInfo);
                             return result;
                         }
-                        else if (constraint && (result = isRelatedTo(getTypeWithThisArgument(constraint, source), target, 1, reportErrors && !(targetFlags & sourceFlags & 262144), undefined, intersectionState))) {
+                        else if (result = isRelatedTo(getTypeWithThisArgument(constraint, source), target, 1, reportErrors && !(targetFlags & sourceFlags & 262144), undefined, intersectionState)) {
                             resetErrorInfo(saveErrorInfo);
                             return result;
                         }
@@ -54667,7 +54684,7 @@ var ts;
                             return varianceResult;
                         }
                     }
-                    else if (isReadonlyArrayType(target) ? isArrayType(source) || isTupleType(source) : isArrayType(target) && isTupleType(source) && !source.target.readonly) {
+                    else if (isReadonlyArrayType(target) ? isArrayOrTupleType(source) : isArrayType(target) && isTupleType(source) && !source.target.readonly) {
                         if (relation !== identityRelation) {
                             return isRelatedTo(getIndexTypeOfType(source, numberType) || anyType, getIndexTypeOfType(target, numberType) || anyType, 3, reportErrors);
                         }
@@ -54961,7 +54978,7 @@ var ts;
                 }
                 var result = -1;
                 if (isTupleType(target)) {
-                    if (isArrayType(source) || isTupleType(source)) {
+                    if (isArrayOrTupleType(source)) {
                         if (!target.target.readonly && (isReadonlyArrayType(source) || isTupleType(source) && source.target.readonly)) {
                             return 0;
                         }
@@ -55808,6 +55825,9 @@ var ts;
         function isReadonlyArrayType(type) {
             return !!(ts.getObjectFlags(type) & 4) && type.target === globalReadonlyArrayType;
         }
+        function isArrayOrTupleType(type) {
+            return isArrayType(type) || isTupleType(type);
+        }
         function isMutableArrayOrTuple(type) {
             return isArrayType(type) && !isReadonlyArrayType(type) || isTupleType(type) && !type.target.readonly;
         }
@@ -56205,7 +56225,7 @@ var ts;
                 else if (type.flags & 2097152) {
                     result = getIntersectionType(ts.sameMap(type.types, getWidenedType));
                 }
-                else if (isArrayType(type) || isTupleType(type)) {
+                else if (isArrayOrTupleType(type)) {
                     result = createTypeReference(type.target, ts.sameMap(getTypeArguments(type), getWidenedType));
                 }
                 if (result && context === undefined) {
@@ -56231,7 +56251,7 @@ var ts;
                         }
                     }
                 }
-                if (isArrayType(type) || isTupleType(type)) {
+                if (isArrayOrTupleType(type)) {
                     for (var _b = 0, _c = getTypeArguments(type); _b < _c.length; _b++) {
                         var t = _c[_b];
                         if (reportWideningErrorsInType(t)) {
@@ -57133,7 +57153,7 @@ var ts;
                     }
                 }
                 if (!typesDefinitelyUnrelated(source, target)) {
-                    if (isArrayType(source) || isTupleType(source)) {
+                    if (isArrayOrTupleType(source)) {
                         if (isTupleType(target)) {
                             var sourceArity = getTypeReferenceArity(source);
                             var targetArity = getTypeReferenceArity(target);

package/lib/tsserver.js

@@ -100,7 +100,7 @@ var ts;
     // The following is baselined as a literal template type without intervention
     /** The version of the TypeScript compiler release */
     // eslint-disable-next-line @typescript-eslint/no-inferrable-types
-    ts.version = ts.versionMajorMinor + ".0-insiders.20220425";
+    ts.version = ts.versionMajorMinor + ".0-insiders.20220427";
     /* @internal */
     var Comparison;
     (function (Comparison) {
@@ -17307,19 +17307,11 @@ var ts;
         return !!name && isDynamicName(name);
     }
     ts.hasDynamicName = hasDynamicName;
-    function getComputedPropertyNameExpression(name) {
-        return ts.isElementAccessExpression(name.expression)
-            ? skipParentheses(name.expression.argumentExpression)
-            : name.expression;
-    }
-    ts.getComputedPropertyNameExpression = getComputedPropertyNameExpression;
     function isDynamicName(name) {
         if (!(name.kind === 162 /* ComputedPropertyName */ || name.kind === 207 /* ElementAccessExpression */)) {
             return false;
         }
-        var expr = ts.isElementAccessExpression(name)
-            ? skipParentheses(name.argumentExpression)
-            : getComputedPropertyNameExpression(name);
+        var expr = ts.isElementAccessExpression(name) ? skipParentheses(name.argumentExpression) : name.expression;
         return !isStringOrNumericLiteralLike(expr) &&
             !isSignedNumericLiteral(expr);
     }
@@ -17333,7 +17325,7 @@ var ts;
             case 8 /* NumericLiteral */:
                 return ts.escapeLeadingUnderscores(name.text);
             case 162 /* ComputedPropertyName */:
-                var nameExpression = getComputedPropertyNameExpression(name);
+                var nameExpression = name.expression;
                 if (isStringOrNumericLiteralLike(nameExpression)) {
                     return ts.escapeLeadingUnderscores(nameExpression.text);
                 }
@@ -44455,7 +44447,7 @@ var ts;
                     return (ts.isGlobalScopeAugmentation(node) ? "__global" : "\"" + moduleName + "\"");
                 }
                 if (name.kind === 162 /* ComputedPropertyName */) {
-                    var nameExpression = ts.getComputedPropertyNameExpression(name);
+                    var nameExpression = name.expression;
                     // treat computed property names where expression is string/numeric literal as just string/numeric literal
                     if (ts.isStringOrNumericLiteralLike(nameExpression)) {
                         return ts.escapeLeadingUnderscores(nameExpression.text);
@@ -48344,6 +48336,7 @@ var ts;
         var keyofConstraintType = keyofStringsOnly ? stringType : stringNumberSymbolType;
         var numberOrBigIntType = getUnionType([numberType, bigintType]);
         var templateConstraintType = getUnionType([stringType, numberType, booleanType, bigintType, nullType, undefinedType]);
+        var numericStringType = getTemplateLiteralType(["", ""], [numberType]); // The `${number}` type
         var restrictiveMapper = makeFunctionTypeMapper(function (t) { return t.flags & 262144 /* TypeParameter */ ? getRestrictiveTypeParameter(t) : t; });
         var permissiveMapper = makeFunctionTypeMapper(function (t) { return t.flags & 262144 /* TypeParameter */ ? wildcardType : t; });
         var uniqueLiteralType = createIntrinsicType(131072 /* Never */, "never"); // `uniqueLiteralType` is a special `never` flagged by union reduction to behave as a literal
@@ -51325,7 +51318,7 @@ var ts;
             }
         }
         function getExportSymbolOfValueSymbolIfExported(symbol) {
-            return getMergedSymbol(symbol && (symbol.flags & 1048576 /* ExportValue */) !== 0 ? symbol.exportSymbol : symbol);
+            return getMergedSymbol(symbol && (symbol.flags & 1048576 /* ExportValue */) !== 0 && symbol.exportSymbol || symbol);
         }
         function symbolIsValue(symbol) {
             return !!(symbol.flags & 111551 /* Value */ || symbol.flags & 2097152 /* Alias */ && resolveAlias(symbol).flags & 111551 /* Value */ && !getTypeOnlyAliasDeclaration(symbol));
@@ -58728,7 +58721,7 @@ var ts;
             var typeVariable = getHomomorphicTypeVariable(type);
             if (typeVariable && !type.declaration.nameType) {
                 var constraint = getConstraintOfTypeParameter(typeVariable);
-                if (constraint && (isArrayType(constraint) || isTupleType(constraint))) {
+                if (constraint && isArrayOrTupleType(constraint)) {
                     return instantiateType(type, prependTypeMapping(typeVariable, constraint, type.mapper));
                 }
             }
@@ -59090,10 +59083,10 @@ var ts;
         }
         function isApplicableIndexType(source, target) {
             // A 'string' index signature applies to types assignable to 'string' or 'number', and a 'number' index
-            // signature applies to types assignable to 'number' and numeric string literal types.
+            // signature applies to types assignable to 'number', `${number}` and numeric string literal types.
             return isTypeAssignableTo(source, target) ||
                 target === stringType && isTypeAssignableTo(source, numberType) ||
-                target === numberType && !!(source.flags & 128 /* StringLiteral */) && ts.isNumericLiteralName(source.value);
+                target === numberType && (source === numericStringType || !!(source.flags & 128 /* StringLiteral */) && ts.isNumericLiteralName(source.value));
         }
         function getIndexInfosOfStructuredType(type) {
             if (type.flags & 3670016 /* StructuredType */) {
@@ -60109,6 +60102,20 @@ var ts;
                         constraints = ts.append(constraints, constraint);
                     }
                 }
+                // Given a homomorphic mapped type { [K in keyof T]: XXX }, where T is constrained to an array or tuple type, in the
+                // template type XXX, K has an added constraint of number | `${number}`.
+                else if (type.flags & 262144 /* TypeParameter */ && parent.kind === 195 /* MappedType */ && node === parent.type) {
+                    var mappedType = getTypeFromTypeNode(parent);
+                    if (getTypeParameterFromMappedType(mappedType) === getActualTypeVariable(type)) {
+                        var typeParameter = getHomomorphicTypeVariable(mappedType);
+                        if (typeParameter) {
+                            var constraint = getConstraintOfTypeParameter(typeParameter);
+                            if (constraint && everyType(constraint, isArrayOrTupleType)) {
+                                constraints = ts.append(constraints, getUnionType([numberType, numericStringType]));
+                            }
+                        }
+                    }
+                }
                 node = parent;
             }
             return constraints ? getSubstitutionType(type, getIntersectionType(ts.append(constraints, type))) : type;
@@ -61076,7 +61083,7 @@ var ts;
             while (i > 0) {
                 i--;
                 var t = types[i];
-                var remove = t.flags & 4 /* String */ && includes & 128 /* StringLiteral */ ||
+                var remove = t.flags & 4 /* String */ && includes & (128 /* StringLiteral */ | 134217728 /* TemplateLiteral */ | 268435456 /* StringMapping */) ||
                     t.flags & 8 /* Number */ && includes & 256 /* NumberLiteral */ ||
                     t.flags & 64 /* BigInt */ && includes & 2048 /* BigIntLiteral */ ||
                     t.flags & 4096 /* ESSymbol */ && includes & 8192 /* UniqueESSymbol */;
@@ -61235,7 +61242,7 @@ var ts;
             if (!strictNullChecks && includes & 98304 /* Nullable */) {
                 return includes & 32768 /* Undefined */ ? undefinedType : nullType;
             }
-            if (includes & 4 /* String */ && includes & 128 /* StringLiteral */ ||
+            if (includes & 4 /* String */ && includes & (128 /* StringLiteral */ | 134217728 /* TemplateLiteral */ | 268435456 /* StringMapping */) ||
                 includes & 8 /* Number */ && includes & 256 /* NumberLiteral */ ||
                 includes & 64 /* BigInt */ && includes & 2048 /* BigIntLiteral */ ||
                 includes & 4096 /* ESSymbol */ && includes & 8192 /* UniqueESSymbol */) {
@@ -63119,7 +63126,7 @@ var ts;
                             if (!type.declaration.nameType) {
                                 var constraint = void 0;
                                 if (isArrayType(t) || t.flags & 1 /* Any */ && findResolutionCycleStartIndex(typeVariable, 4 /* ImmediateBaseConstraint */) < 0 &&
-                                    (constraint = getConstraintOfTypeParameter(typeVariable)) && everyType(constraint, ts.or(isArrayType, isTupleType))) {
+                                    (constraint = getConstraintOfTypeParameter(typeVariable)) && everyType(constraint, isArrayOrTupleType)) {
                                     return instantiateMappedArrayType(t, type, prependTypeMapping(typeVariable, t, mapper));
                                 }
                                 if (isGenericTupleType(t)) {
@@ -64557,7 +64564,7 @@ var ts;
                         }
                         return false;
                     }
-                    return isTupleType(target) || isArrayType(target);
+                    return isArrayOrTupleType(target);
                 }
                 if (isReadonlyArrayType(source) && isMutableArrayOrTuple(target)) {
                     if (reportErrors) {
@@ -64687,7 +64694,7 @@ var ts;
                     // We suppress recursive intersection property checks because they can generate lots of work when relating
                     // recursive intersections that are structurally similar but not exactly identical. See #37854.
                     if (result_7 && !inPropertyCheck && (target.flags & 2097152 /* Intersection */ && (isPerformingExcessPropertyChecks || isPerformingCommonPropertyChecks) ||
-                        isNonGenericObjectType(target) && !isArrayType(target) && !isTupleType(target) && source.flags & 2097152 /* Intersection */ && getApparentType(source).flags & 3670016 /* StructuredType */ && !ts.some(source.types, function (t) { return !!(ts.getObjectFlags(t) & 262144 /* NonInferrableType */); }))) {
+                        isNonGenericObjectType(target) && !isArrayOrTupleType(target) && source.flags & 2097152 /* Intersection */ && getApparentType(source).flags & 3670016 /* StructuredType */ && !ts.some(source.types, function (t) { return !!(ts.getObjectFlags(t) & 262144 /* NonInferrableType */); }))) {
                         inPropertyCheck = true;
                         result_7 &= recursiveTypeRelatedTo(source, target, reportErrors, 4 /* PropertyCheck */, recursionFlags);
                         inPropertyCheck = false;
@@ -65314,6 +65321,20 @@ var ts;
                             }
                         }
                     }
+                    if (relation === comparableRelation && sourceFlags & 262144 /* TypeParameter */) {
+                        // This is a carve-out in comparability to essentially forbid comparing a type parameter
+                        // with another type parameter unless one extends the other. (Remember: comparability is mostly bidirectional!)
+                        var constraint = getConstraintOfTypeParameter(source);
+                        if (constraint && hasNonCircularBaseConstraint(source)) {
+                            while (constraint && constraint.flags & 262144 /* TypeParameter */) {
+                                if (result = isRelatedTo(constraint, target, 1 /* Source */, /*reportErrors*/ false)) {
+                                    return result;
+                                }
+                                constraint = getConstraintOfTypeParameter(constraint);
+                            }
+                        }
+                        return 0 /* False */;
+                    }
                 }
                 else if (targetFlags & 4194304 /* Index */) {
                     var targetType_1 = target.type;
@@ -65517,7 +65538,7 @@ var ts;
                 if (sourceFlags & 8650752 /* TypeVariable */) {
                     // IndexedAccess comparisons are handled above in the `targetFlags & TypeFlage.IndexedAccess` branch
                     if (!(sourceFlags & 8388608 /* IndexedAccess */ && targetFlags & 8388608 /* IndexedAccess */)) {
-                        var constraint = getConstraintOfType(source);
+                        var constraint = getConstraintOfType(source) || unknownType;
                         if (!strictNullChecks && (!constraint || (sourceFlags & 262144 /* TypeParameter */ && constraint.flags & 1 /* Any */))) {
                             // A type variable with no constraint is not related to the non-primitive object type.
                             if (result = isRelatedTo(emptyObjectType, extractTypesOfKind(target, ~67108864 /* NonPrimitive */), 3 /* Both */)) {
@@ -65526,12 +65547,12 @@ var ts;
                             }
                         }
                         // hi-speed no-this-instantiation check (less accurate, but avoids costly `this`-instantiation when the constraint will suffice), see #28231 for report on why this is needed
-                        else if (constraint && (result = isRelatedTo(constraint, target, 1 /* Source */, /*reportErrors*/ false, /*headMessage*/ undefined, intersectionState))) {
+                        else if (result = isRelatedTo(constraint, target, 1 /* Source */, /*reportErrors*/ false, /*headMessage*/ undefined, intersectionState)) {
                             resetErrorInfo(saveErrorInfo);
                             return result;
                         }
                         // slower, fuller, this-instantiated check (necessary when comparing raw `this` types from base classes), see `subclassWithPolymorphicThisIsAssignable.ts` test for example
-                        else if (constraint && (result = isRelatedTo(getTypeWithThisArgument(constraint, source), target, 1 /* Source */, reportErrors && !(targetFlags & sourceFlags & 262144 /* TypeParameter */), /*headMessage*/ undefined, intersectionState))) {
+                        else if (result = isRelatedTo(getTypeWithThisArgument(constraint, source), target, 1 /* Source */, reportErrors && !(targetFlags & sourceFlags & 262144 /* TypeParameter */), /*headMessage*/ undefined, intersectionState)) {
                             resetErrorInfo(saveErrorInfo);
                             return result;
                         }
@@ -65675,7 +65696,7 @@ var ts;
                             return varianceResult;
                         }
                     }
-                    else if (isReadonlyArrayType(target) ? isArrayType(source) || isTupleType(source) : isArrayType(target) && isTupleType(source) && !source.target.readonly) {
+                    else if (isReadonlyArrayType(target) ? isArrayOrTupleType(source) : isArrayType(target) && isTupleType(source) && !source.target.readonly) {
                         if (relation !== identityRelation) {
                             return isRelatedTo(getIndexTypeOfType(source, numberType) || anyType, getIndexTypeOfType(target, numberType) || anyType, 3 /* Both */, reportErrors);
                         }
@@ -66051,7 +66072,7 @@ var ts;
                 }
                 var result = -1 /* True */;
                 if (isTupleType(target)) {
-                    if (isArrayType(source) || isTupleType(source)) {
+                    if (isArrayOrTupleType(source)) {
                         if (!target.target.readonly && (isReadonlyArrayType(source) || isTupleType(source) && source.target.readonly)) {
                             return 0 /* False */;
                         }
@@ -67012,6 +67033,9 @@ var ts;
         function isReadonlyArrayType(type) {
             return !!(ts.getObjectFlags(type) & 4 /* Reference */) && type.target === globalReadonlyArrayType;
         }
+        function isArrayOrTupleType(type) {
+            return isArrayType(type) || isTupleType(type);
+        }
         function isMutableArrayOrTuple(type) {
             return isArrayType(type) && !isReadonlyArrayType(type) || isTupleType(type) && !type.target.readonly;
         }
@@ -67463,7 +67487,7 @@ var ts;
                 else if (type.flags & 2097152 /* Intersection */) {
                     result = getIntersectionType(ts.sameMap(type.types, getWidenedType));
                 }
-                else if (isArrayType(type) || isTupleType(type)) {
+                else if (isArrayOrTupleType(type)) {
                     result = createTypeReference(type.target, ts.sameMap(getTypeArguments(type), getWidenedType));
                 }
                 if (result && context === undefined) {
@@ -67500,7 +67524,7 @@ var ts;
                         }
                     }
                 }
-                if (isArrayType(type) || isTupleType(type)) {
+                if (isArrayOrTupleType(type)) {
                     for (var _b = 0, _c = getTypeArguments(type); _b < _c.length; _b++) {
                         var t = _c[_b];
                         if (reportWideningErrorsInType(t)) {
@@ -68561,7 +68585,7 @@ var ts;
                 }
                 // Infer from the members of source and target only if the two types are possibly related
                 if (!typesDefinitelyUnrelated(source, target)) {
-                    if (isArrayType(source) || isTupleType(source)) {
+                    if (isArrayOrTupleType(source)) {
                         if (isTupleType(target)) {
                             var sourceArity = getTypeReferenceArity(source);
                             var targetArity = getTypeReferenceArity(target);