@typeonce/oxlint-plugin-ritmo 0.14.0 → 0.16.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (34) hide show
  1. package/CHANGELOG.md +69 -0
  2. package/README.md +86 -13
  3. package/dist/index.js +13 -8
  4. package/dist/index.js.map +1 -1
  5. package/dist/rules/handle-runtime-result.d.ts +8 -0
  6. package/dist/rules/handle-runtime-result.d.ts.map +1 -0
  7. package/dist/rules/handle-runtime-result.js +102 -0
  8. package/dist/rules/handle-runtime-result.js.map +1 -0
  9. package/dist/rules/no-brand-cast.d.ts +7 -0
  10. package/dist/rules/no-brand-cast.d.ts.map +1 -0
  11. package/dist/rules/no-brand-cast.js +195 -0
  12. package/dist/rules/no-brand-cast.js.map +1 -0
  13. package/dist/rules/no-float-timers.d.ts +8 -0
  14. package/dist/rules/no-float-timers.d.ts.map +1 -0
  15. package/dist/rules/no-float-timers.js +60 -0
  16. package/dist/rules/no-float-timers.js.map +1 -0
  17. package/dist/rules/use-clock-for-time.js +1 -1
  18. package/dist/rules/use-clock-for-time.js.map +1 -1
  19. package/dist/rules/use-ops-for-math.d.ts +2 -2
  20. package/dist/rules/use-ops-for-math.d.ts.map +1 -1
  21. package/dist/rules/use-ops-for-math.js +199 -35
  22. package/dist/rules/use-ops-for-math.js.map +1 -1
  23. package/package.json +1 -1
  24. package/src/index.ts +13 -8
  25. package/src/rules/handle-runtime-result.ts +108 -0
  26. package/src/rules/no-brand-cast.ts +195 -0
  27. package/src/rules/no-float-timers.ts +64 -0
  28. package/src/rules/use-clock-for-time.ts +1 -1
  29. package/src/rules/use-ops-for-math.ts +207 -35
  30. package/dist/rules/handle-tick-result.d.ts +0 -8
  31. package/dist/rules/handle-tick-result.d.ts.map +0 -1
  32. package/dist/rules/handle-tick-result.js +0 -56
  33. package/dist/rules/handle-tick-result.js.map +0 -1
  34. package/src/rules/handle-tick-result.ts +0 -61
@@ -1 +1 @@
1
- {"version":3,"file":"use-ops-for-math.js","sourceRoot":"","sources":["../../src/rules/use-ops-for-math.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,iBAAiB,CAAA;AAG5C,OAAO,EAAE,OAAO,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAA;AAE1D,iFAAiF;AACjF,MAAM,YAAY,GAAG,IAAI,GAAG,CAAC;IAC3B,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,OAAO;IACpD,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO;IACvE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,OAAO,EAAE,OAAO,EAAE,OAAO;CAClD,CAAC,CAAA;AAEF,qEAAqE;AACrE,MAAM,UAAU,GAAG,CAAC,OAAuB,EAAsB,EAAE;IACjE,KAAK,MAAM,SAAS,IAAI,OAAO,CAAC,IAAI,EAAE,CAAC;QACrC,IAAI,SAAS,CAAC,IAAI,KAAK,mBAAmB,IAAI,SAAS,CAAC,UAAU,KAAK,MAAM;YAAE,SAAQ;QACvF,MAAM,MAAM,GAAG,SAAS,CAAC,MAAM,CAAC,KAAK,CAAA;QACrC,KAAK,MAAM,SAAS,IAAI,SAAS,CAAC,UAAU,EAAE,CAAC;YAC7C,IAAI,MAAM,KAAK,sBAAsB,IAAI,SAAS,CAAC,IAAI,KAAK,iBAAiB,IAAI,SAAS,CAAC,UAAU,KAAK,MAAM;gBAC9G,SAAS,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY,IAAI,SAAS,CAAC,QAAQ,CAAC,IAAI,KAAK,KAAK;gBAAE,OAAO,SAAS,CAAC,KAAK,CAAC,IAAI,CAAA;YAC5G,IAAI,CAAC,MAAM,KAAK,0BAA0B,IAAI,mBAAmB,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,IAAI,SAAS,CAAC,IAAI,KAAK,0BAA0B,EAAE,CAAC;gBACjI,OAAO,SAAS,CAAC,KAAK,CAAC,IAAI,CAAA;YAC7B,CAAC;QACH,CAAC;IACH,CAAC;IACD,OAAO,SAAS,CAAA;AAClB,CAAC,CAAA;AAED;;;GAGG;AACH,eAAe,UAAU,CAAC;IACxB,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,WAAW,EAAE,sGAAsG;YACnH,GAAG,EAAE,OAAO,CAAC,kBAAkB,CAAC;SACjC;QACD,OAAO,EAAE,MAAM;QACf,QAAQ,EAAE;YACR,IAAI,EACF,oXAAoX;YACtX,KAAK,EACH,mTAAmT;SACtT;QACD,MAAM,EAAE,EAAE;KACX;IACD,MAAM,CAAC,OAAO;QACZ,IAAI,GAAuB,CAAA;QAC3B,OAAO;YACL,OAAO,CAAC,IAAI;gBACV,GAAG,GAAG,UAAU,CAAC,IAAI,CAAC,CAAA;YACxB,CAAC;YACD,gBAAgB,CAAC,IAAI;gBACnB,MAAM,IAAI,GAAG,YAAY,CAAC,OAAO,EAAE,IAAI,EAAE,MAAM,CAAC,CAAA;gBAChD,IAAI,IAAI,KAAK,SAAS,IAAI,CAAC,YAAY,CAAC,GAAG,CAAC,IAAI,CAAC;oBAAE,OAAM;gBACzD,MAAM,KAAK,GAAG,GAAG,CAAA;gBACjB,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI;oBACJ,SAAS,EAAE,MAAM;oBACjB,IAAI,EAAE,EAAE,IAAI,EAAE;oBACd,GAAG,CAAC,KAAK,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,GAAG,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,WAAW,CAAC,IAAI,EAAE,GAAG,KAAK,IAAI,IAAI,EAAE,CAAC,EAAE,CAAC;iBAChG,CAAC,CAAA;YACJ,CAAC;YACD,gBAAgB,CAAC,IAAI;gBACnB,IAAI,IAAI,CAAC,QAAQ,KAAK,IAAI;oBAAE,OAAM;gBAClC,IAAI,IAAI,CAAC,KAAK,CAAC,IAAI,KAAK,SAAS,IAAI,IAAI,CAAC,KAAK,CAAC,KAAK,KAAK,CAAC;oBAAE,OAAM;gBACnE,MAAM,KAAK,GAAG,GAAG,CAAA;gBACjB,MAAM,IAAI,GAAG,OAAO,CAAC,UAAU,CAAA;gBAC/B,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI;oBACJ,SAAS,EAAE,OAAO;oBAClB,IAAI,EAAE,EAAE,QAAQ,EAAE,QAAQ,EAAE;oBAC5B,GAAG,CAAC,KAAK,KAAK,SAAS;wBACrB,CAAC,CAAC,EAAE;wBACJ,CAAC,CAAC,EAAE,GAAG,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,WAAW,CAAC,IAAI,EAAE,GAAG,KAAK,QAAQ,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,KAAK,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,EAAE,CAAC;iBAC1H,CAAC,CAAA;YACJ,CAAC;YACD,oBAAoB,CAAC,IAAI;gBACvB,IAAI,IAAI,CAAC,QAAQ,KAAK,KAAK;oBAAE,OAAM;gBACnC,IAAI,IAAI,CAAC,KAAK,CAAC,IAAI,KAAK,SAAS,IAAI,IAAI,CAAC,KAAK,CAAC,KAAK,KAAK,CAAC;oBAAE,OAAM;gBACnE,OAAO,CAAC,MAAM,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,OAAO,EAAE,IAAI,EAAE,EAAE,QAAQ,EAAE,SAAS,EAAE,EAAE,CAAC,CAAA;YAC7E,CAAC;SACF,CAAA;IACH,CAAC;CACF,CAAC,CAAA"}
1
+ {"version":3,"file":"use-ops-for-math.js","sourceRoot":"","sources":["../../src/rules/use-ops-for-math.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,iBAAiB,CAAA;AAG5C,OAAO,EAAE,OAAO,EAAE,YAAY,EAAE,iBAAiB,EAAE,YAAY,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAA;AAExG,iFAAiF;AACjF,MAAM,YAAY,GAAG,IAAI,GAAG,CAAC;IAC3B,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,OAAO;IACpD,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO;IACvE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,OAAO,EAAE,OAAO,EAAE,OAAO;CAClD,CAAC,CAAA;AAEF,sEAAsE;AACtE,MAAM,aAAa,GAAG,IAAI,GAAG,CAAC,CAAC,aAAa,EAAE,iBAAiB,EAAE,iBAAiB,EAAE,mBAAmB,EAAE,qBAAqB,CAAC,CAAC,CAAA;AAEhI,qEAAqE;AACrE,MAAM,SAAS,GAAG,CAAC,IAAoC,EAAsB,EAAE,CAC7E,IAAI,EAAE,IAAI,KAAK,gBAAgB,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,SAAS,IAAI,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC;IACnI,CAAC,CAAC,WAAW,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;IAChC,CAAC,CAAC,SAAS,CAAA;AAEf,oGAAoG;AACpG,MAAM,UAAU,GAAG,CAAC,OAAuB,EAAwC,EAAE;IACnF,KAAK,MAAM,SAAS,IAAI,OAAO,CAAC,IAAI,EAAE,CAAC;QACrC,IAAI,SAAS,CAAC,IAAI,KAAK,mBAAmB,EAAE,CAAC;YAC3C,IAAI,SAAS,CAAC,UAAU,KAAK,MAAM;gBAAE,SAAQ;YAC7C,MAAM,MAAM,GAAG,SAAS,CAAC,MAAM,CAAC,KAAK,CAAA;YACrC,KAAK,MAAM,SAAS,IAAI,SAAS,CAAC,UAAU,EAAE,CAAC;gBAC7C,IAAI,MAAM,KAAK,iBAAiB,IAAI,SAAS,CAAC,IAAI,KAAK,iBAAiB,IAAI,SAAS,CAAC,UAAU,KAAK,MAAM;oBACzG,SAAS,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY,IAAI,SAAS,CAAC,QAAQ,CAAC,IAAI,KAAK,KAAK;oBAAE,OAAO,SAAS,CAAC,KAAK,CAAA;gBACvG,IAAI,CAAC,MAAM,KAAK,qBAAqB,IAAI,8BAA8B,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,IAAI,SAAS,CAAC,IAAI,KAAK,0BAA0B,EAAE,CAAC;oBACvI,OAAO,SAAS,CAAC,KAAK,CAAA;gBACxB,CAAC;YACH,CAAC;QACH,CAAC;QACD,IAAI,SAAS,CAAC,IAAI,KAAK,qBAAqB;YAAE,SAAQ;QACtD,KAAK,MAAM,UAAU,IAAI,SAAS,CAAC,YAAY,EAAE,CAAC;YAChD,MAAM,MAAM,GAAG,SAAS,CAAC,UAAU,CAAC,IAAI,CAAC,CAAA;YACzC,6CAA6C;YAC7C,IAAI,MAAM,KAAK,qBAAqB,IAAI,UAAU,CAAC,EAAE,CAAC,IAAI,KAAK,YAAY;gBAAE,OAAO,UAAU,CAAC,EAAE,CAAA;YACjG,6CAA6C;YAC7C,IAAI,MAAM,KAAK,iBAAiB,IAAI,UAAU,CAAC,EAAE,CAAC,IAAI,KAAK,eAAe;gBAAE,SAAQ;YACpF,KAAK,MAAM,QAAQ,IAAI,UAAU,CAAC,EAAE,CAAC,UAAU,EAAE,CAAC;gBAChD,IAAI,QAAQ,CAAC,IAAI,KAAK,UAAU,IAAI,WAAW,CAAC,QAAQ,CAAC,KAAK,KAAK,IAAI,QAAQ,CAAC,KAAK,CAAC,IAAI,KAAK,YAAY;oBAAE,OAAO,QAAQ,CAAC,KAAK,CAAA;YACpI,CAAC;QACH,CAAC;IACH,CAAC;IACD,OAAO,SAAS,CAAA;AAClB,CAAC,CAAA;AAED,4FAA4F;AAC5F,MAAM,WAAW,GAAG,CAAC,IAAsF,EAAsB,EAAE,CACjI,CAAC,IAAI,CAAC,QAAQ,IAAI,IAAI,CAAC,GAAG,CAAC,IAAI,KAAK,YAAY,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC,WAAW,CAAC,IAAI,CAAC,GAAG,CAAC,CAAA;AAE1F,6FAA6F;AAC7F,MAAM,OAAO,GAAG,CAAC,KAAoD,EAAE,IAAY,EAAE,EAAE;IACrF,KAAK,IAAI,OAAO,GAAwB,KAAK,EAAE,OAAO,KAAK,IAAI,EAAE,OAAO,GAAG,OAAO,CAAC,KAAK,EAAE,CAAC;QACzF,MAAM,QAAQ,GAAG,OAAO,CAAC,GAAG,CAAC,GAAG,CAAC,IAAI,CAAC,CAAA;QACtC,IAAI,QAAQ,KAAK,SAAS,IAAI,QAAQ,CAAC,IAAI,CAAC,MAAM,GAAG,CAAC;YAAE,OAAO,QAAQ,CAAA;IACzE,CAAC;IACD,OAAO,SAAS,CAAA;AAClB,CAAC,CAAA;AAED;;;GAGG;AACH,MAAM,UAAU,GAAG,CAAC,OAAgB,EAAE,OAAuB,EAAW,EAAE;IACxE,IAAI,WAAW,CAAC,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC;QAAE,OAAO,IAAI,CAAA;IACnD,IAAI,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,SAAS,CAAC,IAAI,KAAK,mBAAmB,IAAI,SAAS,CAAC,IAAI,CAAC,UAAU,CAAC,QAAQ,CAAC,CAAC;QAAE,OAAO,KAAK,CAAA;IACjI,OAAO,0DAA0D,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,CAAA;AACjG,CAAC,CAAA;AAeD;;;GAGG;AACH,eAAe,UAAU,CAAC;IACxB,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,WAAW,EAAE,iGAAiG;YAC9G,GAAG,EAAE,OAAO,CAAC,kBAAkB,CAAC;SACjC;QACD,OAAO,EAAE,MAAM;QACf,QAAQ,EAAE;YACR,IAAI,EACF,0WAA0W;YAC5W,KAAK,EACH,ySAAyS;YAC3S,KAAK,EACH,yjBAAyjB;SAC5jB;QACD,MAAM,EAAE,EAAE;KACX;IACD,MAAM,CAAC,OAAO;QACZ,MAAM,OAAO,GAAmB,EAAE,CAAA;QAElC,+FAA+F;QAC/F,MAAM,MAAM,GAAG,CAAC,IAAiB,EAAW,EAAE,CAC5C,IAAI,CAAC,IAAI,KAAK,YAAY;YACxB,CAAC,CAAC,IAAI,CAAC,IAAI,KAAK,MAAM,IAAI,iBAAiB,CAAC,OAAO,EAAE,IAAI,CAAC;YAC1D,CAAC,CAAC,IAAI,CAAC,IAAI,KAAK,kBAAkB,IAAI,YAAY,CAAC,OAAO,EAAE,IAAI,EAAE,YAAY,CAAC,KAAK,MAAM,CAAA;QAE9F,kFAAkF;QAClF,MAAM,cAAc,GAAG,CAAC,OAAoB,EAAW,EAAE,CACvD,OAAO,CAAC,IAAI,KAAK,eAAe,IAAI,OAAO,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,QAAQ,EAAE,EAAE;YACxE,IAAI,QAAQ,CAAC,IAAI,KAAK,UAAU;gBAAE,OAAO,KAAK,CAAA;YAC9C,MAAM,GAAG,GAAG,WAAW,CAAC,QAAQ,CAAC,CAAA;YACjC,OAAO,GAAG,KAAK,SAAS,IAAI,CAAC,YAAY,CAAC,GAAG,CAAC,GAAG,CAAC,CAAA;QACpD,CAAC,CAAC,CAAA;QAEJ,yCAAyC;QACzC,MAAM,SAAS,GAAG,CAAC,IAAiB,EAAQ,EAAE;YAC5C,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAA;YAC1B,IAAI,MAAM,KAAK,IAAI,IAAI,aAAa,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC;gBAAE,OAAM;YAC7D,IAAI,MAAM,CAAC,IAAI,KAAK,kBAAkB,IAAI,MAAM,CAAC,MAAM,KAAK,IAAI,EAAE,CAAC;gBACjE,MAAM,IAAI,GAAG,YAAY,CAAC,MAAM,CAAC,CAAA;gBACjC,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;oBACvB,OAAO,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,SAAS,EAAE,OAAO,EAAE,CAAC,CAAA;oBAClD,OAAM;gBACR,CAAC;gBACD,IAAI,CAAC,YAAY,CAAC,GAAG,CAAC,IAAI,CAAC;oBAAE,OAAM;gBACnC,OAAO,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,EAAE,OAAO,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,GAAG,IAAI,IAAI,EAAE,EAAE,CAAC,CAAA;gBACrG,OAAM;YACR,CAAC;YACD,IAAI,MAAM,CAAC,IAAI,KAAK,oBAAoB,IAAI,MAAM,CAAC,IAAI,KAAK,IAAI,IAAI,cAAc,CAAC,MAAM,CAAC,EAAE,CAAC;gBAAE,OAAM;YACrG,IAAI,MAAM,CAAC,IAAI,KAAK,sBAAsB,IAAI,MAAM,CAAC,KAAK,KAAK,IAAI,IAAI,cAAc,CAAC,MAAM,CAAC,IAAI,CAAC;gBAAE,OAAM;YAC1G,IAAI,MAAM,CAAC,IAAI,KAAK,kBAAkB,IAAI,MAAM,CAAC,QAAQ,KAAK,IAAI;gBAAE,OAAM;YAC1E,OAAO,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,OAAO,EAAE,CAAC,CAAA;QAC5C,CAAC,CAAA;QAED,OAAO;YACL,UAAU,CAAC,IAAI;gBACb,IAAI,MAAM,CAAC,IAAI,CAAC;oBAAE,SAAS,CAAC,IAAI,CAAC,CAAA;YACnC,CAAC;YACD,gBAAgB,CAAC,IAAI;gBACnB,IAAI,MAAM,CAAC,IAAI,CAAC;oBAAE,SAAS,CAAC,IAAI,CAAC,CAAA;YACnC,CAAC;YACD,gBAAgB,CAAC,IAAI;gBACnB,IAAI,IAAI,CAAC,QAAQ,KAAK,IAAI;oBAAE,OAAM;gBAClC,IAAI,IAAI,CAAC,KAAK,CAAC,IAAI,KAAK,SAAS,IAAI,IAAI,CAAC,KAAK,CAAC,KAAK,KAAK,CAAC;oBAAE,OAAM;gBACnE,OAAO,CAAC,IAAI,CAAC;oBACX,IAAI;oBACJ,SAAS,EAAE,OAAO;oBAClB,IAAI,EAAE,EAAE,QAAQ,EAAE,QAAQ,EAAE;oBAC5B,OAAO,EAAE,CAAC,GAAG,EAAE,IAAI,EAAE,EAAE,CAAC,GAAG,GAAG,QAAQ,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,KAAK,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG;iBAC9E,CAAC,CAAA;YACJ,CAAC;YACD,oBAAoB,CAAC,IAAI;gBACvB,IAAI,IAAI,CAAC,QAAQ,KAAK,KAAK;oBAAE,OAAM;gBACnC,IAAI,IAAI,CAAC,KAAK,CAAC,IAAI,KAAK,SAAS,IAAI,IAAI,CAAC,KAAK,CAAC,KAAK,KAAK,CAAC;oBAAE,OAAM;gBACnE,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAA;gBACxB,OAAO,CAAC,IAAI,CAAC;oBACX,IAAI;oBACJ,SAAS,EAAE,OAAO;oBAClB,IAAI,EAAE,EAAE,QAAQ,EAAE,SAAS,EAAE;oBAC7B,kFAAkF;oBAClF,GAAG,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY;wBAC9B,CAAC,CAAC,EAAE,OAAO,EAAE,CAAC,GAAW,EAAE,IAAoC,EAAE,EAAE,CAAC,GAAG,MAAM,CAAC,IAAI,MAAM,GAAG,QAAQ,MAAM,CAAC,IAAI,KAAK,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,EAAE;wBACxI,CAAC,CAAC,EAAE,CAAC;iBACR,CAAC,CAAA;YACJ,CAAC;YACD,cAAc,CAAC,OAAO;gBACpB,MAAM,OAAO,GAAG,UAAU,CAAC,OAAO,CAAC,CAAA;gBACnC,MAAM,GAAG,GAAG,OAAO,EAAE,IAAI,IAAI,KAAK,CAAA;gBAClC,uFAAuF;gBACvF,MAAM,SAAS,GAAG,CAAC,IAAiB,EAAW,EAAE;oBAC/C,MAAM,QAAQ,GAAG,OAAO,CAAC,OAAO,CAAC,UAAU,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,GAAG,CAAC,CAAA;oBAChE,OAAO,OAAO,KAAK,SAAS,CAAC,CAAC,CAAC,QAAQ,KAAK,SAAS,CAAC,CAAC,CAAC,QAAQ,EAAE,WAAW,CAAC,IAAI,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,CAAC,KAAK,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,IAAI,CAAA;gBACvJ,CAAC,CAAA;gBACD,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAA;gBAC9F,MAAM,OAAO,GAAG,OAAO,CAAC,MAAM,CAAC,CAAC,MAAM,EAAqB,EAAE,CAAC,MAAM,CAAC,OAAO,KAAK,SAAS,IAAI,SAAS,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,CAAA;gBACrH,2EAA2E;gBAC3E,MAAM,eAAe,GAAG,CAAC,IAAiB,EAAkB,EAAE;oBAC5D,MAAM,KAAK,GAAmB,EAAE,CAAA;oBAChC,KAAK,MAAM,MAAM,IAAI,OAAO,EAAE,CAAC;wBAC7B,MAAM,CAAC,KAAK,EAAE,GAAG,CAAC,GAAG,MAAM,CAAC,IAAI,CAAC,KAAK,CAAA;wBACtC,IAAI,MAAM,CAAC,IAAI,KAAK,IAAI,IAAI,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,GAAG,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC;4BAAE,SAAQ;wBAClF,MAAM,IAAI,GAAG,KAAK,CAAC,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC,CAAA;wBACpC,IAAI,IAAI,KAAK,SAAS,IAAI,KAAK,IAAI,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC;4BAAE,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,CAAA;oBAC3E,CAAC;oBACD,OAAO,KAAK,CAAA;gBACd,CAAC,CAAA;gBACD,qGAAqG;gBACrG,MAAM,IAAI,GAAG,CAAC,IAAiB,EAAU,EAAE;oBACzC,MAAM,GAAG,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,IAAI,KAAK,IAAI,CAAC,CAAA;oBAC1D,IAAI,GAAG,KAAK,SAAS;wBAAE,OAAO,SAAS,CAAC,GAAG,CAAC,CAAA;oBAC5C,MAAM,CAAC,KAAK,CAAC,GAAG,IAAI,CAAC,KAAK,CAAA;oBAC1B,IAAI,MAAM,GAAG,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,IAAI,CAAC,CAAA;oBAC7C,KAAK,MAAM,KAAK,IAAI,eAAe,CAAC,IAAI,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC;wBACpD,MAAM,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC,EAAE,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,GAAG,KAAK,CAAC,GAAG,SAAS,CAAC,KAAK,CAAC,GAAG,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,GAAG,KAAK,CAAC,CAAA;oBACtH,CAAC;oBACD,OAAO,IAAI,CAAC,IAAI,KAAK,oBAAoB,CAAC,CAAC,CAAC,IAAI,MAAM,GAAG,CAAC,CAAC,CAAC,MAAM,CAAA;gBACpE,CAAC,CAAA;gBACD,MAAM,SAAS,GAAG,CAAC,MAAe,EAAU,EAAE,CAAC,MAAM,CAAC,OAAO,CAAC,GAAG,EAAE,IAAI,CAAC,CAAA;gBACxE,MAAM,QAAQ,GAAG,IAAI,GAAG,CAAC,eAAe,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC,MAAM,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC,CAAC,CAAA;gBACzF,IAAI,WAAW,GAAG,OAAO,KAAK,SAAS,CAAA;gBACvC,KAAK,MAAM,EAAE,IAAI,EAAE,SAAS,EAAE,IAAI,EAAE,IAAI,OAAO,EAAE,CAAC;oBAChD,MAAM,MAAM,GAAG,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC,CAAA;oBACjC,wDAAwD;oBACxD,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;wBACzB,OAAO,CAAC,MAAM,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,GAAG,CAAC,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,CAAC,CAAA;wBAC5E,SAAQ;oBACV,CAAC;oBACD,oFAAoF;oBACpF,mEAAmE;oBACnE,MAAM,UAAU,GAAG,CAAC,WAAW,CAAA;oBAC/B,WAAW,GAAG,IAAI,CAAA;oBAClB,MAAM,OAAO,GAAG,CAAC,KAAY,EAAO,EAAE,CAAC,KAAK,CAAC,WAAW,CAAC,IAAI,EAAE,SAAS,CAAC,MAAM,CAAC,CAAC,CAAA;oBACjF,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI;wBACJ,SAAS;wBACT,GAAG,CAAC,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,CAAC;wBACvC,GAAG,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,OAAO,EAAE,KAAK,EAAE,OAAO,CAAC,EAAE,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,KAAK,CAAC;qBACnG,CAAC,CAAA;gBACJ,CAAC;YACH,CAAC;SACF,CAAA;IACH,CAAC;CACF,CAAC,CAAA;AAEF;;;;GAIG;AACH,MAAM,SAAS,GAAG,CAAC,OAAgB,EAAE,KAAY,EAAE,OAAuB,EAAO,EAAE;IACjF,MAAM,QAAQ,GAAG,UAAU,CAAC,OAAO,EAAE,OAAO,CAAC,CAAA;IAC7C,IAAI,QAAiC,CAAA;IACrC,IAAI,aAAsC,CAAA;IAC1C,KAAK,MAAM,SAAS,IAAI,OAAO,CAAC,IAAI,EAAE,CAAC;QACrC,IAAI,SAAS,CAAC,IAAI,KAAK,qBAAqB,IAAI,OAAO,SAAS,CAAC,SAAS,KAAK,QAAQ;YAAE,aAAa,GAAG,SAAS,CAAA;QAClH,MAAM,KAAK,GAAG,QAAQ;YACpB,CAAC,CAAC,SAAS,CAAC,IAAI,KAAK,qBAAqB,IAAI,SAAS,CAAC,YAAY,CAAC,IAAI,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,SAAS,CAAC,UAAU,CAAC,IAAI,CAAC,KAAK,SAAS,CAAC;YACnI,CAAC,CAAC,SAAS,CAAC,IAAI,KAAK,mBAAmB,CAAA;QAC1C,IAAI,KAAK;YAAE,QAAQ,GAAG,SAAS,CAAA;IACjC,CAAC;IACD,MAAM,MAAM,GAAG,QAAQ,IAAI,aAAa,CAAA;IACxC,MAAM,SAAS,GAAG,MAAM,IAAI,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;IAC3C,MAAM,SAAS,GAAG,SAAS,KAAK,SAAS,IAAI,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAA;IAC3G,MAAM,IAAI,GAAG,CAAC,QAAQ,CAAC,CAAC,CAAC,8CAA8C,CAAC,CAAC,CAAC,yCAAyC,CAAC,GAAG,SAAS,CAAA;IAChI,IAAI,MAAM,KAAK,SAAS;QAAE,OAAO,KAAK,CAAC,eAAe,CAAC,MAAM,EAAE,KAAK,IAAI,EAAE,CAAC,CAAA;IAC3E,MAAM,KAAK,GAAG,SAAS,EAAE,KAAK,CAAC,CAAC,CAAC,IAAI,CAAC,CAAA;IACtC,OAAO,KAAK,CAAC,qBAAqB,CAAC,CAAC,KAAK,EAAE,KAAK,CAAC,EAAE,GAAG,IAAI,IAAI,CAAC,CAAA;AACjE,CAAC,CAAA"}
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@typeonce/oxlint-plugin-ritmo",
3
- "version": "0.14.0",
3
+ "version": "0.16.0",
4
4
  "description": "Oxlint rules for Ritmo games: deterministic, headless simulation code and checked runtime results",
5
5
  "author": "Sandro Maglione",
6
6
  "license": "MIT",
package/src/index.ts CHANGED
@@ -3,10 +3,10 @@
3
3
  *
4
4
  * Types catch wrong calls and devtools catch wrong runs; these rules catch
5
5
  * the source patterns neither can see: simulation code that reads the wall
6
- * clock, `Math.random`, engine-dependent math, or the page, data that cannot
7
- * be saved, state values that keep a previous state's fields, and runtime
8
- * results that are dropped. Every report names the
9
- * Ritmo API to use instead.
6
+ * clock, `Math.random`, engine-dependent math, or the page, timers counted
7
+ * in floats, data that cannot be saved, casts that skip a brand's check,
8
+ * state values that keep a previous state's fields, and runtime results that
9
+ * are dropped. Every report names the Ritmo API to use instead.
10
10
  *
11
11
  * Register the plugin in `.oxlintrc.json` with `"jsPlugins":
12
12
  * ["@typeonce/oxlint-plugin-ritmo"]`. Its rules are named `ritmo/<rule>`.
@@ -16,8 +16,9 @@
16
16
  *
17
17
  * - Simulation files: `ritmo/use-clock-for-time`,
18
18
  * `ritmo/use-random-for-randomness`, `ritmo/use-ops-for-math`,
19
- * `ritmo/keep-simulation-headless`, `ritmo/no-infinity-in-simulation-data`.
20
- * - Every file: `ritmo/handle-tick-result`,
19
+ * `ritmo/keep-simulation-headless`, `ritmo/no-infinity-in-simulation-data`,
20
+ * `ritmo/no-float-timers`, `ritmo/no-brand-cast`.
21
+ * - Every file: `ritmo/handle-runtime-result`,
21
22
  * `ritmo/prefix-descriptor-and-system-names`, `ritmo/use-cell-value`,
22
23
  * `ritmo/no-state-spread`.
23
24
  *
@@ -25,8 +26,10 @@
25
26
  */
26
27
  import { definePlugin } from "@oxlint/plugins"
27
28
 
28
- import handleTickResult from "./rules/handle-tick-result.ts"
29
+ import handleRuntimeResult from "./rules/handle-runtime-result.ts"
29
30
  import keepSimulationHeadless from "./rules/keep-simulation-headless.ts"
31
+ import noBrandCast from "./rules/no-brand-cast.ts"
32
+ import noFloatTimers from "./rules/no-float-timers.ts"
30
33
  import noInfinityInSimulationData from "./rules/no-infinity-in-simulation-data.ts"
31
34
  import noStateSpread from "./rules/no-state-spread.ts"
32
35
  import prefixDescriptorAndSystemNames from "./rules/prefix-descriptor-and-system-names.ts"
@@ -43,7 +46,9 @@ export default definePlugin({
43
46
  "use-ops-for-math": useOpsForMath,
44
47
  "keep-simulation-headless": keepSimulationHeadless,
45
48
  "no-infinity-in-simulation-data": noInfinityInSimulationData,
46
- "handle-tick-result": handleTickResult,
49
+ "no-float-timers": noFloatTimers,
50
+ "no-brand-cast": noBrandCast,
51
+ "handle-runtime-result": handleRuntimeResult,
47
52
  "prefix-descriptor-and-system-names": prefixDescriptorAndSystemNames,
48
53
  "use-cell-value": useCellValue,
49
54
  "no-state-spread": noStateSpread
@@ -0,0 +1,108 @@
1
+ import { defineRule } from "@oxlint/plugins"
2
+ import type { ESTree } from "@oxlint/plugins"
3
+
4
+ import { calledMethod, docsUrl, receiverName } from "../internal/ast.ts"
5
+
6
+ interface Options {
7
+ readonly runtimePattern?: string
8
+ }
9
+
10
+ /** The runtime methods that return a `Result`, and whether they take arguments. */
11
+ const methods = new Map<string, "arguments" | "none">([
12
+ ["tick", "arguments"],
13
+ ["tryTick", "arguments"],
14
+ ["restore", "arguments"],
15
+ ["rewind", "arguments"],
16
+ ["snapshot", "none"],
17
+ ["checksum", "none"]
18
+ ])
19
+
20
+ /**
21
+ * Wrappers a result passes through on its way to where it is used: the
22
+ * check looks at where the wrapper goes (`x ?? runtime.snapshot()`,
23
+ * `runtime.snapshot() as unknown`).
24
+ */
25
+ const passesThrough = new Set(["ConditionalExpression", "LogicalExpression", "ParenthesizedExpression", "TSAsExpression", "TSSatisfiesExpression", "TSNonNullExpression", "ChainExpression"])
26
+
27
+ /**
28
+ * Where a result goes unchecked: handed to a function, printed, or put
29
+ * inside another value. A variable, a field, a return, `.ok`, and `void`
30
+ * keep it as a `Result` the code still has to look at.
31
+ */
32
+ const unchecked = new Set(["CallExpression", "NewExpression", "TemplateLiteral", "Property", "ArrayExpression", "SpreadElement", "BinaryExpression", "JSXExpressionContainer"])
33
+
34
+ /**
35
+ * The `Result` of `runtime.tick(...)`, `tryTick(...)`, `restore(...)`,
36
+ * `rewind(...)`, `snapshot()`, and `checksum()` is checked: dropping it, or
37
+ * passing it on where any value is accepted, hides the failure.
38
+ */
39
+ export default defineRule({
40
+ meta: {
41
+ type: "problem",
42
+ docs: {
43
+ description: "Check the Result of runtime.tick, tryTick, restore, rewind, snapshot, and checksum instead of dropping it or passing it on unchecked.",
44
+ url: docsUrl("handle-runtime-result")
45
+ },
46
+ messages: {
47
+ tick:
48
+ "The result of `{{call}}(...)` is dropped. A system that fails stops the tick and returns the failure here, so it goes unnoticed and the world is left half-updated. Check it: `const ran = {{call}}(...); if (!ran.ok) ...` (`ran.error` names the system and why). Write `void {{call}}(...)` to ignore it on purpose.",
49
+ restore:
50
+ "The result of `{{call}}(...)` is dropped. A save that fails to load leaves the previous world in place, unnoticed. Check it: `const restored = {{call}}(data); if (!restored.ok) ...` (`restored.error` says what was invalid). Write `void {{call}}(...)` to ignore it on purpose.",
51
+ rewind:
52
+ "The result of `{{call}}(...)` is dropped. A checkpoint the runtime let go of (older than its window, or taken before a rewind to an older one or a restore) changes nothing, so the ticks run next are run on top of the present instead of again, unnoticed. Check it: `const rewound = {{call}}(checkpoint); if (!rewound.ok) ...` (`rewound.error` says why), and resynchronize, for example by loading a peer's save. Write `void {{call}}(...)` to ignore it on purpose.",
53
+ dropped:
54
+ "The result of `{{call}}()` is dropped, so the call does nothing. Read it: `const saved = {{call}}(); if (saved.ok) ...`.",
55
+ unchecked:
56
+ "`{{call}}(...)` returns a `Result`, and it is passed on unchecked: code that accepts any value (a save, a log, `JSON.stringify`) gets the `{ ok, value }` wrapper instead of the value, and a failure goes unnoticed. Check it first: `const result = {{call}}(...); if (result.ok) use(result.value)`. A helper that takes the `Result` itself gets it once it is named: `const result = {{call}}(...); helper(result)`."
57
+ },
58
+ schema: [
59
+ {
60
+ type: "object",
61
+ properties: {
62
+ runtimePattern: {
63
+ type: "string",
64
+ description: "A regular expression (case-insensitive) the receiver's name must match to be treated as a Ritmo runtime. Defaults to `runtime$`."
65
+ }
66
+ },
67
+ additionalProperties: false
68
+ }
69
+ ]
70
+ },
71
+ create(context) {
72
+ const options = (context.options[0] ?? {}) as Options
73
+ const runtime = new RegExp(options.runtimePattern ?? "runtime$", "i")
74
+ return {
75
+ CallExpression(call) {
76
+ if (call.callee.type !== "MemberExpression") return
77
+ const method = calledMethod(call)
78
+ const takes = method === undefined ? undefined : methods.get(method)
79
+ if (takes === undefined) return
80
+ // `run.tick()` and `replay.rewind()` without arguments are other libraries' methods.
81
+ if (takes === "arguments" && call.arguments.length === 0) return
82
+ if (takes === "none" && call.arguments.length > 0) return
83
+ const receiver = receiverName(call.callee.object)
84
+ if (receiver === undefined || !runtime.test(receiver)) return
85
+ const data = { call: context.sourceCode.getText(call.callee) }
86
+
87
+ let node: ESTree.Node = call
88
+ let parent: ESTree.Node | null | undefined = node.parent
89
+ while (parent != null && passesThrough.has(parent.type)) {
90
+ node = parent
91
+ parent = node.parent
92
+ }
93
+ if (parent == null) return
94
+ if (parent.type === "ExpressionStatement") {
95
+ const messageId = takes === "none" ? "dropped" : method === "restore" || method === "rewind" ? method : "tick"
96
+ context.report({ node: parent, messageId, data })
97
+ return
98
+ }
99
+ if (!unchecked.has(parent.type)) return
100
+ // The callee of a call is a method read on the result, not a hand-off (`runtime.snapshot().toString()` would not compile anyway).
101
+ if (parent.type === "CallExpression" && parent.callee === node) return
102
+ // A property key is not a use of the value.
103
+ if (parent.type === "Property" && parent.value !== node) return
104
+ context.report({ node: call, messageId: "unchecked", data })
105
+ }
106
+ }
107
+ }
108
+ })
@@ -0,0 +1,195 @@
1
+ import { defineRule } from "@oxlint/plugins"
2
+ import type { ESTree } from "@oxlint/plugins"
3
+
4
+ import { docsUrl } from "../internal/ast.ts"
5
+
6
+ /** The type names that are brands wherever they come from: `Brand.Branded<...>`, Effect's `Brand.Brand<...>`, Zod's `z.BRAND<...>` / `z.$brand<...>`. */
7
+ const brandNames = new Set(["Brand", "Branded", "BRAND", "$brand"])
8
+
9
+ /** Property keys that only a brand declares (`T & { readonly __brand: "UserId" }`). */
10
+ const brandKey = /^(__?brand|__publicBrand|__type)$/
11
+
12
+ /** Ritmo's branded exports, by module: `Clock.Deadline`, `Random.State`, `Entity.Handle`, ... */
13
+ const ritmoBrands = new Map<string, ReadonlySet<string>>([
14
+ ["Clock", new Set(["Deadline", "Step", "Duration", "ClockResource"])],
15
+ ["Entity", new Set(["Handle", "EntityId"])],
16
+ ["Random", new Set(["State"])],
17
+ ["Checkpoint", new Set(["Checkpoint", "Rewindable"])]
18
+ ])
19
+
20
+ /** The type helpers that read the type out of a schema: `z.infer<typeof X>`, `Schema.Schema.Type<typeof X>`. */
21
+ const schemaTypeHelpers = new Set(["infer", "output", "TypeOf", "Infer", "Type"])
22
+
23
+ /** A schema built with a brand: Zod's `.brand(...)` / `.brand<"X">()`, Effect's `Schema.brand(...)` / `.pipe(Schema.brand(...))`. */
24
+ const brandsSchema = /\bbrand\s*(<[^>]*>\s*)?\(/
25
+
26
+ /** The dotted names of a type name or expression (`Clock.Deadline` gives `["Clock", "Deadline"]`). */
27
+ const segments = (node: ESTree.Node): Array<string> | undefined => {
28
+ if (node.type === "Identifier") return [node.name]
29
+ if (node.type === "TSQualifiedName") {
30
+ const left = segments(node.left)
31
+ return left === undefined ? undefined : [...left, node.right.name]
32
+ }
33
+ if (node.type === "MemberExpression" && !node.computed && node.property.type === "Identifier") {
34
+ const left = segments(node.object)
35
+ return left === undefined ? undefined : [...left, node.property.name]
36
+ }
37
+ return undefined
38
+ }
39
+
40
+ /** Where a local name imported from Ritmo points: `[]` for the package, `["Clock"]` for a module, `["Clock", "Deadline"]` for a type. */
41
+ const ritmoImport = (declaration: ESTree.ImportDeclaration, specifier: ESTree.ImportDeclarationSpecifier): Array<string> | undefined => {
42
+ const match = /^@typeonce\/ritmo(\/([A-Za-z0-9]+))?$/.exec(declaration.source.value)
43
+ if (match === null) return undefined
44
+ const module = match[2]
45
+ const base = module === undefined ? [] : [module]
46
+ if (specifier.type === "ImportNamespaceSpecifier") return base
47
+ if (specifier.type !== "ImportSpecifier") return undefined
48
+ const imported = specifier.imported.type === "Identifier" ? specifier.imported.name : specifier.imported.value
49
+ return [...base, imported]
50
+ }
51
+
52
+ /**
53
+ * Simulation code never casts a value to a branded type: a brand stands for a
54
+ * check, and the cast claims it without running it.
55
+ */
56
+ export default defineRule({
57
+ meta: {
58
+ type: "problem",
59
+ docs: {
60
+ description: "Make a branded value through its schema or constructor, not with `as` / `<T>` casts.",
61
+ url: docsUrl("no-brand-cast")
62
+ },
63
+ messages: {
64
+ cast:
65
+ "This casts to `{{type}}`, a branded type: a brand stands for a check the value passed, and the cast claims it without running the check, so an invalid value travels as a valid one (and a save holding it fails to load, or the simulation computes with it). Make the value through its check instead: decode it at the boundary with the schema that brands it (`UserId.parse(raw)` with Zod, `Schema.decodeUnknownSync(UserId)(raw)` with Effect), or with Ritmo's constructor or guard: `Random.seed(n)` / `Random.result(n)`, `Clock.deadline(time, duration)` / `Clock.isDeadline(step)`, `Game.Entity.handle(id)` / `Entity.isHandle(Root)`."
66
+ },
67
+ schema: []
68
+ },
69
+ create(context) {
70
+ const aliases = new Map<string, ESTree.TSType>()
71
+ const interfaces = new Map<string, ESTree.TSInterfaceDeclaration>()
72
+ const values = new Map<string, ESTree.Node>()
73
+ const uniqueSymbols = new Set<string>()
74
+ const imports = new Map<string, Array<string>>()
75
+ const casts: Array<ESTree.TSAsExpression | ESTree.TSTypeAssertion> = []
76
+
77
+ /** Whether the value named `name` is a schema built with a brand in this file. */
78
+ const isBrandedSchema = (name: string): boolean => {
79
+ const init = values.get(name)
80
+ return init !== undefined && brandsSchema.test(context.sourceCode.getText(init))
81
+ }
82
+
83
+ /** Whether a dotted name is a brand: a brand helper, Ritmo's branded export, or a local brand alias. */
84
+ const namesBrand = (names: Array<string>, hasArguments: boolean, seen: Set<string>): boolean => {
85
+ const [root, ...rest] = names
86
+ if (root === undefined) return false
87
+ const imported = imports.get(root)
88
+ if (imported !== undefined) {
89
+ const [module, type, ...more] = [...imported, ...rest]
90
+ if (module !== undefined && type !== undefined && more.length === 0 && ritmoBrands.get(module)?.has(type) === true) return true
91
+ }
92
+ const last = names[names.length - 1]!
93
+ if (names.length === 1) {
94
+ const alias = aliases.get(root)
95
+ if (alias !== undefined) return !seen.has(root) && isBrand(alias, new Set([...seen, root]))
96
+ const declared = interfaces.get(root)
97
+ if (declared !== undefined) return !seen.has(root) && interfaceIsBrand(declared, new Set([...seen, root]))
98
+ return hasArguments && brandNames.has(root)
99
+ }
100
+ return brandNames.has(last)
101
+ }
102
+
103
+ const interfaceIsBrand = (node: ESTree.TSInterfaceDeclaration, seen: Set<string>): boolean =>
104
+ node.body.body.some(memberIsBrand) ||
105
+ node.extends.some((heritage) => {
106
+ const names = segments(heritage.expression)
107
+ return names !== undefined && namesBrand(names, heritage.typeArguments !== null, seen)
108
+ })
109
+
110
+ const memberIsBrand = (member: ESTree.TSSignature): boolean => {
111
+ if (member.type !== "TSPropertySignature") return false
112
+ if (!member.computed) return member.key.type === "Identifier" ? brandKey.test(member.key.name) : false
113
+ if (member.key.type === "Identifier" && uniqueSymbols.has(member.key.name)) return true
114
+ return /brand/i.test(context.sourceCode.getText(member.key))
115
+ }
116
+
117
+ /** Whether `node` reads the type of a branded schema: `typeof X.Type`, `(typeof X)["Type"]`. */
118
+ const readsBrandedSchema = (node: ESTree.TSType): boolean => {
119
+ if (node.type === "TSTypeQuery") {
120
+ const names = segments(node.exprName)
121
+ return names !== undefined && names.length === 2 && names[1] === "Type" && isBrandedSchema(names[0]!)
122
+ }
123
+ if (node.type === "TSIndexedAccessType" && node.objectType.type === "TSTypeQuery") {
124
+ const names = segments(node.objectType.exprName)
125
+ const index = node.indexType
126
+ return names !== undefined && names.length === 1 && isBrandedSchema(names[0]!) &&
127
+ index.type === "TSLiteralType" && index.literal.type === "Literal" && index.literal.value === "Type"
128
+ }
129
+ return false
130
+ }
131
+
132
+ const isBrand = (node: ESTree.TSType, seen: Set<string>): boolean => {
133
+ switch (node.type) {
134
+ case "TSIntersectionType":
135
+ case "TSUnionType":
136
+ return node.types.some((type) => isBrand(type, seen))
137
+ case "TSArrayType":
138
+ return isBrand(node.elementType, seen)
139
+ case "TSTypeOperator":
140
+ return node.operator === "readonly" && isBrand(node.typeAnnotation, seen)
141
+ case "TSParenthesizedType":
142
+ return isBrand(node.typeAnnotation, seen)
143
+ case "TSTypeLiteral":
144
+ return node.members.some(memberIsBrand)
145
+ case "TSTypeReference": {
146
+ const names = segments(node.typeName)
147
+ if (names === undefined) return false
148
+ const schema = node.typeArguments?.params[0]
149
+ if (names.length > 1 && schemaTypeHelpers.has(names[names.length - 1]!) && schema?.type === "TSTypeQuery") {
150
+ const target = segments(schema.exprName)
151
+ if (target !== undefined && target.length === 1 && isBrandedSchema(target[0]!)) return true
152
+ }
153
+ return namesBrand(names, node.typeArguments !== null, seen)
154
+ }
155
+ default:
156
+ return readsBrandedSchema(node)
157
+ }
158
+ }
159
+
160
+ return {
161
+ ImportDeclaration(node) {
162
+ for (const specifier of node.specifiers) {
163
+ const target = ritmoImport(node, specifier)
164
+ if (target !== undefined) imports.set(specifier.local.name, target)
165
+ }
166
+ },
167
+ TSTypeAliasDeclaration(node) {
168
+ aliases.set(node.id.name, node.typeAnnotation)
169
+ },
170
+ TSInterfaceDeclaration(node) {
171
+ interfaces.set(node.id.name, node)
172
+ },
173
+ VariableDeclarator(node) {
174
+ if (node.id.type !== "Identifier") return
175
+ const annotation = node.id.typeAnnotation?.typeAnnotation
176
+ // `declare const brand: unique symbol` names a key no value has; a symbol made at runtime is a real key.
177
+ if (annotation?.type === "TSTypeOperator" && annotation.operator === "unique" && node.init === null) uniqueSymbols.add(node.id.name)
178
+ if (node.init !== null) values.set(node.id.name, node.init)
179
+ },
180
+ TSAsExpression(node) {
181
+ casts.push(node)
182
+ },
183
+ TSTypeAssertion(node) {
184
+ casts.push(node)
185
+ },
186
+ // Declarations may follow the casts that use them, so casts are checked once the file is read.
187
+ "Program:exit"() {
188
+ for (const cast of casts) {
189
+ if (!isBrand(cast.typeAnnotation, new Set())) continue
190
+ context.report({ node: cast, messageId: "cast", data: { type: context.sourceCode.getText(cast.typeAnnotation) } })
191
+ }
192
+ }
193
+ }
194
+ }
195
+ })
@@ -0,0 +1,64 @@
1
+ import { defineRule } from "@oxlint/plugins"
2
+ import type { ESTree } from "@oxlint/plugins"
3
+
4
+ import { calledMethod, docsUrl, propertyName } from "../internal/ast.ts"
5
+
6
+ // The names a tick's seconds go by: a local, a field (`time.dt`), or a resource read (`resources.deltaTime.get()`).
7
+ const deltaNames = ["dt", "deltaTime", "deltaSeconds"]
8
+
9
+ /** `node` without the type-only wrappers TypeScript adds (`dt as number`, `dt!`). */
10
+ const unwrap = (node: ESTree.Node): ESTree.Node =>
11
+ node.type === "TSAsExpression" || node.type === "TSNonNullExpression" || node.type === "TSSatisfiesExpression" ? unwrap(node.expression) : node
12
+
13
+ /** Whether `node` is a tick's seconds on their own: `dt`, `time.dt`, or `resources.deltaTime.get()`. */
14
+ const isDelta = (raw: ESTree.Node): boolean => {
15
+ const node = unwrap(raw)
16
+ if (node.type === "Identifier") return deltaNames.includes(node.name)
17
+ if (node.type === "MemberExpression") return deltaNames.includes(propertyName(node) ?? "")
18
+ if (node.type === "CallExpression" && calledMethod(node) === "get" && node.callee.type === "MemberExpression") {
19
+ const receiver = unwrap(node.callee.object)
20
+ return receiver.type === "MemberExpression" && deltaNames.includes(propertyName(receiver) ?? "")
21
+ }
22
+ return false
23
+ }
24
+
25
+ /** Whether `node` reads a stored value (a local or a field), the thing a timer counts. */
26
+ const isStored = (raw: ESTree.Node): boolean => {
27
+ const node = unwrap(raw)
28
+ return (node.type === "Identifier" || node.type === "MemberExpression") && !isDelta(node)
29
+ }
30
+
31
+ /**
32
+ * A timer in simulation code is a deadline in steps, never a float counted
33
+ * down (or up) by `dt`: the float drifts, and the value it saves means
34
+ * nothing once the fixed step changes.
35
+ */
36
+ export default defineRule({
37
+ meta: {
38
+ type: "problem",
39
+ docs: {
40
+ description: "Keep timers and cooldowns as Clock deadlines in steps, not floats counted by dt.",
41
+ url: docsUrl("no-float-timers")
42
+ },
43
+ messages: {
44
+ floatTimer:
45
+ "`{{text}}` counts a timer by `dt` in floating point: rounding error builds up each tick, so it ends a step early or late, and the float it saves means nothing once the fixed step changes. Store the step it ends on instead: `ready: Clock.deadline(time, Clock.duration(step, seconds))` in the component or resource (its schema narrows with `Clock.isDeadline(step)`), and check `Clock.reached(time, ready)` each tick (`Clock.remaining(time, ready)` for a readout, `Clock.every(time, duration)` for something that repeats, `Clock.elapsed(time)` for seconds since the start). A timer that must stop while the world clock runs (hit-stop, a menu over gameplay) is measured against a second clock that holds: `Clock.resource(\"Game/GameplayTime\", step)` advanced by `Clock.system(Game, { name, resource, hold: [paused] })`, so its deadlines wait with it. Only time scaled by a fraction (a 0.3x slow motion) is a real float: keep it and disable this line with the reason."
46
+ },
47
+ schema: []
48
+ },
49
+ create(context) {
50
+ const report = (node: ESTree.Node) =>
51
+ context.report({ node, messageId: "floatTimer", data: { text: context.sourceCode.getText(node) } })
52
+ return {
53
+ AssignmentExpression(node) {
54
+ // `timer -= dt`, `elapsed += time.dt`
55
+ if ((node.operator === "-=" || node.operator === "+=") && isDelta(node.right)) report(node)
56
+ },
57
+ BinaryExpression(node) {
58
+ // `cooldown.remaining - dt`, `time.dt + since`; `x + vx * dt` scales dt, so it is integration.
59
+ if (node.operator !== "-" && node.operator !== "+") return
60
+ if ((isDelta(node.right) && isStored(node.left)) || (isDelta(node.left) && isStored(node.right))) report(node)
61
+ }
62
+ }
63
+ }
64
+ })
@@ -19,7 +19,7 @@ export default defineRule({
19
19
  wallClock:
20
20
  "{{call}} reads the wall clock, so the simulation plays differently on every run and replays diverge. For time since the start, read the Clock resource (`Clock.elapsed(time)` in seconds, `time.step` in steps). For today's date, read it in host code and pass it in with `runtime.send(...)` or a resource, so the replay records it.",
21
21
  timer:
22
- "{{call}}() runs its callback outside the tick, at a moment a replay cannot reproduce. Count steps instead: store the step it fires at (`time.step + Clock.steps(Clock.duration(step, seconds))`) in a component or resource and compare it each tick, or use `Clock.every(time, duration)` for something that repeats."
22
+ "{{call}}() runs its callback outside the tick, at a moment a replay cannot reproduce. Count steps instead: store the step it fires at (`Clock.deadline(time, Clock.duration(step, seconds))`) in a component or resource and check it each tick with `Clock.reached(time, due)`, or use `Clock.every(time, duration)` for something that repeats."
23
23
  },
24
24
  schema: []
25
25
  },