@typeonce/oxlint-plugin-effect-machine 0.26.2 → 0.27.0

package/dist/internal/rules/noRedundantResolve.js

@@ -32,6 +32,19 @@ const isDefaultTargetConstruction = (node, binding) => node?.type === "CallExpre
     staticMemberName(node.callee) === "from" &&
     node.callee.object.type === "Identifier" &&
     node.callee.object.name === binding;
+const isEmptyResolver = (node) => node.body?.type === "BlockStatement" && node.body.body.length === 0;
+const isTargetlessReceiver = (node) => node.type === "MemberExpression" && staticMemberName(node) === "none";
+const isReenterOnlyOptions = (node) => {
+    if (node?.type !== "ObjectExpression" || node.properties.length !== 1)
+        return false;
+    const property = node.properties[0];
+    return property?.type === "Property" &&
+        !property.computed &&
+        property.key.type === "Identifier" &&
+        property.key.name === "reenter" &&
+        property.value.type === "Literal" &&
+        property.value.value === true;
+};
 export const noRedundantResolve = {
     meta: {
         type: "suggestion",
@@ -42,7 +55,9 @@ export const noRedundantResolve = {
         fixable: "code",
         schema: [],
         messages: {
-            redundantResolver: "Remove this resolver. The selected target already applies default construction."
+            redundantResolver: "Remove this resolver. The selected target already applies default construction, so use the target selector directly.",
+            redundantReenterResolver: "Replace this resolver with .reenter(). It applies the same default construction while explicitly reentering the selected state.",
+            redundantTargetlessResolver: "Remove this empty resolver. A targetless transition performs the same work as to.none; use to.none directly."
         }
     },
     create(context) {
@@ -51,7 +66,7 @@ export const noRedundantResolve = {
             ImportDeclaration: (node) => recordMachineImport(bindings, node),
             CallExpression(node) {
                 if (!hasMachineImport(bindings) ||
-                    node.arguments.length !== 1 ||
+                    (node.arguments.length !== 1 && node.arguments.length !== 2) ||
                     node.callee.type !== "MemberExpression" ||
                     staticMemberName(node.callee) !== "resolve")
                     return;
@@ -63,21 +78,32 @@ export const noRedundantResolve = {
                     return;
                 if (!isPlanningCallback(callback, bindings))
                     return;
+                const receiver = node.callee.object;
                 const binding = targetBinding(callback);
-                if (binding === undefined ||
-                    !isDefaultTargetConstruction(returnedExpression(callback), binding))
+                const defaultConstruction = binding !== undefined &&
+                    isDefaultTargetConstruction(returnedExpression(callback), binding);
+                const targetless = isTargetlessReceiver(receiver) && isEmptyResolver(callback);
+                if (!defaultConstruction && !targetless)
                     return;
-                const receiver = node.callee.object;
-                if (context.sourceCode.getCommentsInside(node).length === 0) {
-                    context.report({
-                        node,
-                        messageId: "redundantResolver",
-                        fix: (fixer) => fixer.replaceText(node, context.sourceCode.getText(receiver))
-                    });
-                }
-                else {
-                    context.report({ node, messageId: "redundantResolver" });
-                }
+                const options = node.arguments[1];
+                if (options?.type === "SpreadElement")
+                    return;
+                const reenter = options === undefined ? false : isReenterOnlyOptions(options);
+                if (options !== undefined && !reenter)
+                    return;
+                const messageId = reenter
+                    ? "redundantReenterResolver"
+                    : targetless
+                        ? "redundantTargetlessResolver"
+                        : "redundantResolver";
+                const replacement = `${context.sourceCode.getText(receiver)}${reenter ? ".reenter()" : ""}`;
+                context.report({
+                    node,
+                    messageId,
+                    ...(context.sourceCode.getCommentsInside(node).length === 0
+                        ? { fix: (fixer) => fixer.replaceText(node, replacement) }
+                        : undefined)
+                });
             },
             VariableDeclarator: (node) => recordMachineDefinition(bindings, node)
         };

package/dist/internal/rules/noRedundantResolve.js.map

@@ -1 +1 @@
-{"version":3,"file":"noRedundantResolve.js","sourceRoot":"","sources":["../../../src/internal/rules/noRedundantResolve.ts"],"names":[],"mappings":"AACA,OAAO,EACL,gBAAgB,EAChB,mBAAmB,EACnB,uBAAuB,EACvB,mBAAmB,EACnB,gBAAgB,EACjB,MAAM,eAAe,CAAA;AACtB,OAAO,EAAE,kBAAkB,EAAE,MAAM,gBAAgB,CAAA;AAEnD,MAAM,kBAAkB,GAAG,CACzB,IAAsD,EAChB,EAAE;IACxC,IAAI,IAAI,CAAC,IAAI,KAAK,IAAI;QAAE,OAAO,SAAS,CAAA;IACxC,IAAI,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,gBAAgB;QAAE,OAAO,IAAI,CAAC,IAAI,CAAA;IACzD,IAAI,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,MAAM,KAAK,CAAC,IAAI,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,IAAI,KAAK,iBAAiB,EAAE,CAAC;QACjF,OAAO,SAAS,CAAA;IAClB,CAAC;IACD,OAAO,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAA;AACnC,CAAC,CAAA;AAED,MAAM,aAAa,GAAG,CACpB,IAAsD,EAClC,EAAE;IACtB,IAAI,IAAI,CAAC,MAAM,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,SAAS,CAAA;IAC9C,MAAM,SAAS,GAAG,IAAI,CAAC,MAAM,CAAC,CAAC,CAAC,CAAA;IAChC,IAAI,SAAS,EAAE,IAAI,KAAK,eAAe,IAAI,SAAS,CAAC,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC7E,OAAO,SAAS,CAAA;IAClB,CAAC;IACD,MAAM,QAAQ,GAAG,SAAS,CAAC,UAAU,CAAC,CAAC,CAAC,CAAA;IACxC,IACE,QAAQ,EAAE,IAAI,KAAK,UAAU;QAC7B,QAAQ,CAAC,QAAQ;QACjB,QAAQ,CAAC,GAAG,CAAC,IAAI,KAAK,YAAY;QAClC,QAAQ,CAAC,GAAG,CAAC,IAAI,KAAK,QAAQ;QAC9B,QAAQ,CAAC,KAAK,CAAC,IAAI,KAAK,YAAY;QACpC,OAAO,SAAS,CAAA;IAClB,OAAO,QAAQ,CAAC,KAAK,CAAC,IAAI,CAAA;AAC5B,CAAC,CAAA;AAED,MAAM,2BAA2B,GAAG,CAClC,IAA0C,EAC1C,OAAe,EACN,EAAE,CACX,IAAI,EAAE,IAAI,KAAK,gBAAgB;IAC/B,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC;IAC3B,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB;IACvC,gBAAgB,CAAC,IAAI,CAAC,MAAM,CAAC,KAAK,MAAM;IACxC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY;IACxC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,OAAO,CAAA;AAErC,MAAM,CAAC,MAAM,kBAAkB,GAAS;IACtC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACJ,WAAW,EAAE,+DAA+D;YAC5E,WAAW,EAAE,IAAI;SAClB;QACD,OAAO,EAAE,MAAM;QACf,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,iBAAiB,EAAE,iFAAiF;SACrG;KACF;IACD,MAAM,CAAC,OAAO;QACZ,MAAM,QAAQ,GAAG,mBAAmB,EAAE,CAAA;QACtC,OAAO;YACL,iBAAiB,EAAE,CAAC,IAAI,EAAE,EAAE,CAAC,mBAAmB,CAAC,QAAQ,EAAE,IAAI,CAAC;YAChE,cAAc,CAAC,IAAI;gBACjB,IACE,CAAC,gBAAgB,CAAC,QAAQ,CAAC;oBAC3B,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC;oBAC3B,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB;oBACvC,gBAAgB,CAAC,IAAI,CAAC,MAAM,CAAC,KAAK,SAAS;oBAC3C,OAAM;gBAER,MAAM,QAAQ,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAA;gBAClC,IACE,QAAQ,EAAE,IAAI,KAAK,yBAAyB;oBAC5C,QAAQ,EAAE,IAAI,KAAK,oBAAoB;oBACvC,OAAM;gBACR,IAAI,QAAQ,CAAC,KAAK,IAAI,QAAQ,CAAC,SAAS;oBAAE,OAAM;gBAChD,IAAI,CAAC,kBAAkB,CAAC,QAAQ,EAAE,QAAQ,CAAC;oBAAE,OAAM;gBAEnD,MAAM,OAAO,GAAG,aAAa,CAAC,QAAQ,CAAC,CAAA;gBACvC,IACE,OAAO,KAAK,SAAS;oBACrB,CAAC,2BAA2B,CAAC,kBAAkB,CAAC,QAAQ,CAAC,EAAE,OAAO,CAAC;oBACnE,OAAM;gBAER,MAAM,QAAQ,GAAG,IAAI,CAAC,MAAM,CAAC,MAAM,CAAA;gBACnC,IAAI,OAAO,CAAC,UAAU,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;oBAC5D,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI;wBACJ,SAAS,EAAE,mBAAmB;wBAC9B,GAAG,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,WAAW,CAAC,IAAI,EAAE,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;qBAC9E,CAAC,CAAA;gBACJ,CAAC;qBAAM,CAAC;oBACN,OAAO,CAAC,MAAM,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,mBAAmB,EAAE,CAAC,CAAA;gBAC1D,CAAC;YACH,CAAC;YACD,kBAAkB,EAAE,CAAC,IAAI,EAAE,EAAE,CAAC,uBAAuB,CAAC,QAAQ,EAAE,IAAI,CAAC;SACtE,CAAA;IACH,CAAC;CACF,CAAA"}
+{"version":3,"file":"noRedundantResolve.js","sourceRoot":"","sources":["../../../src/internal/rules/noRedundantResolve.ts"],"names":[],"mappings":"AACA,OAAO,EACL,gBAAgB,EAChB,mBAAmB,EACnB,uBAAuB,EACvB,mBAAmB,EACnB,gBAAgB,EACjB,MAAM,eAAe,CAAA;AACtB,OAAO,EAAE,kBAAkB,EAAE,MAAM,gBAAgB,CAAA;AAEnD,MAAM,kBAAkB,GAAG,CACzB,IAAsD,EAChB,EAAE;IACxC,IAAI,IAAI,CAAC,IAAI,KAAK,IAAI;QAAE,OAAO,SAAS,CAAA;IACxC,IAAI,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,gBAAgB;QAAE,OAAO,IAAI,CAAC,IAAI,CAAA;IACzD,IAAI,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,MAAM,KAAK,CAAC,IAAI,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,IAAI,KAAK,iBAAiB,EAAE,CAAC;QACjF,OAAO,SAAS,CAAA;IAClB,CAAC;IACD,OAAO,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAA;AACnC,CAAC,CAAA;AAED,MAAM,aAAa,GAAG,CACpB,IAAsD,EAClC,EAAE;IACtB,IAAI,IAAI,CAAC,MAAM,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,SAAS,CAAA;IAC9C,MAAM,SAAS,GAAG,IAAI,CAAC,MAAM,CAAC,CAAC,CAAC,CAAA;IAChC,IAAI,SAAS,EAAE,IAAI,KAAK,eAAe,IAAI,SAAS,CAAC,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC7E,OAAO,SAAS,CAAA;IAClB,CAAC;IACD,MAAM,QAAQ,GAAG,SAAS,CAAC,UAAU,CAAC,CAAC,CAAC,CAAA;IACxC,IACE,QAAQ,EAAE,IAAI,KAAK,UAAU;QAC7B,QAAQ,CAAC,QAAQ;QACjB,QAAQ,CAAC,GAAG,CAAC,IAAI,KAAK,YAAY;QAClC,QAAQ,CAAC,GAAG,CAAC,IAAI,KAAK,QAAQ;QAC9B,QAAQ,CAAC,KAAK,CAAC,IAAI,KAAK,YAAY;QACpC,OAAO,SAAS,CAAA;IAClB,OAAO,QAAQ,CAAC,KAAK,CAAC,IAAI,CAAA;AAC5B,CAAC,CAAA;AAED,MAAM,2BAA2B,GAAG,CAClC,IAA0C,EAC1C,OAAe,EACN,EAAE,CACX,IAAI,EAAE,IAAI,KAAK,gBAAgB;IAC/B,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC;IAC3B,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB;IACvC,gBAAgB,CAAC,IAAI,CAAC,MAAM,CAAC,KAAK,MAAM;IACxC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY;IACxC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,OAAO,CAAA;AAErC,MAAM,eAAe,GAAG,CACtB,IAAsD,EAC7C,EAAE,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,KAAK,gBAAgB,IAAI,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,MAAM,KAAK,CAAC,CAAA;AAEjF,MAAM,oBAAoB,GAAG,CAAC,IAAuB,EAAW,EAAE,CAChE,IAAI,CAAC,IAAI,KAAK,kBAAkB,IAAI,gBAAgB,CAAC,IAAI,CAAC,KAAK,MAAM,CAAA;AAEvE,MAAM,oBAAoB,GAAG,CAAC,IAAmC,EAAW,EAAE;IAC5E,IAAI,IAAI,EAAE,IAAI,KAAK,kBAAkB,IAAI,IAAI,CAAC,UAAU,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,KAAK,CAAA;IACnF,MAAM,QAAQ,GAAG,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,CAAA;IACnC,OAAO,QAAQ,EAAE,IAAI,KAAK,UAAU;QAClC,CAAC,QAAQ,CAAC,QAAQ;QAClB,QAAQ,CAAC,GAAG,CAAC,IAAI,KAAK,YAAY;QAClC,QAAQ,CAAC,GAAG,CAAC,IAAI,KAAK,SAAS;QAC/B,QAAQ,CAAC,KAAK,CAAC,IAAI,KAAK,SAAS;QACjC,QAAQ,CAAC,KAAK,CAAC,KAAK,KAAK,IAAI,CAAA;AACjC,CAAC,CAAA;AAED,MAAM,CAAC,MAAM,kBAAkB,GAAS;IACtC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACJ,WAAW,EAAE,+DAA+D;YAC5E,WAAW,EAAE,IAAI;SAClB;QACD,OAAO,EAAE,MAAM;QACf,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,iBAAiB,EACf,sHAAsH;YACxH,wBAAwB,EACtB,iIAAiI;YACnI,2BAA2B,EACzB,8GAA8G;SACjH;KACF;IACD,MAAM,CAAC,OAAO;QACZ,MAAM,QAAQ,GAAG,mBAAmB,EAAE,CAAA;QACtC,OAAO;YACL,iBAAiB,EAAE,CAAC,IAAI,EAAE,EAAE,CAAC,mBAAmB,CAAC,QAAQ,EAAE,IAAI,CAAC;YAChE,cAAc,CAAC,IAAI;gBACjB,IACE,CAAC,gBAAgB,CAAC,QAAQ,CAAC;oBAC3B,CAAC,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC,IAAI,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC,CAAC;oBAC5D,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB;oBACvC,gBAAgB,CAAC,IAAI,CAAC,MAAM,CAAC,KAAK,SAAS;oBAC3C,OAAM;gBAER,MAAM,QAAQ,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAA;gBAClC,IACE,QAAQ,EAAE,IAAI,KAAK,yBAAyB;oBAC5C,QAAQ,EAAE,IAAI,KAAK,oBAAoB;oBACvC,OAAM;gBACR,IAAI,QAAQ,CAAC,KAAK,IAAI,QAAQ,CAAC,SAAS;oBAAE,OAAM;gBAChD,IAAI,CAAC,kBAAkB,CAAC,QAAQ,EAAE,QAAQ,CAAC;oBAAE,OAAM;gBAEnD,MAAM,QAAQ,GAAG,IAAI,CAAC,MAAM,CAAC,MAAM,CAAA;gBACnC,MAAM,OAAO,GAAG,aAAa,CAAC,QAAQ,CAAC,CAAA;gBACvC,MAAM,mBAAmB,GAAG,OAAO,KAAK,SAAS;oBAC/C,2BAA2B,CAAC,kBAAkB,CAAC,QAAQ,CAAC,EAAE,OAAO,CAAC,CAAA;gBACpE,MAAM,UAAU,GAAG,oBAAoB,CAAC,QAAQ,CAAC,IAAI,eAAe,CAAC,QAAQ,CAAC,CAAA;gBAC9E,IAAI,CAAC,mBAAmB,IAAI,CAAC,UAAU;oBAAE,OAAM;gBAE/C,MAAM,OAAO,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAA;gBACjC,IAAI,OAAO,EAAE,IAAI,KAAK,eAAe;oBAAE,OAAM;gBAC7C,MAAM,OAAO,GAAG,OAAO,KAAK,SAAS,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,oBAAoB,CAAC,OAAO,CAAC,CAAA;gBAC7E,IAAI,OAAO,KAAK,SAAS,IAAI,CAAC,OAAO;oBAAE,OAAM;gBAE7C,MAAM,SAAS,GAAG,OAAO;oBACvB,CAAC,CAAC,0BAA0B;oBAC5B,CAAC,CAAC,UAAU;wBACZ,CAAC,CAAC,6BAA6B;wBAC/B,CAAC,CAAC,mBAAmB,CAAA;gBACvB,MAAM,WAAW,GAAG,GAAG,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,QAAQ,CAAC,GAAG,OAAO,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,EAAE,EAAE,CAAA;gBAC3F,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI;oBACJ,SAAS;oBACT,GAAG,CAAC,OAAO,CAAC,UAAU,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC,MAAM,KAAK,CAAC;wBACzD,CAAC,CAAC,EAAE,GAAG,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,WAAW,CAAC,IAAI,EAAE,WAAW,CAAC,EAAE;wBAC1D,CAAC,CAAC,SAAS,CAAC;iBACf,CAAC,CAAA;YACJ,CAAC;YACD,kBAAkB,EAAE,CAAC,IAAI,EAAE,EAAE,CAAC,uBAAuB,CAAC,QAAQ,EAAE,IAAI,CAAC;SACtE,CAAA;IACH,CAAC;CACF,CAAA"}

package/dist/recommended.d.ts

@@ -1,6 +1,9 @@
 /** Rules recommended for every Effect Machine model. */
 export declare const recommended: {
     readonly "effect-machine/no-async-planning-callback": "error";
+    readonly "effect-machine/no-browser-api-in-planning": "error";
+    readonly "effect-machine/no-conflicting-invocation-identity": "error";
+    readonly "effect-machine/no-nondeterministic-planning": "error";
     readonly "effect-machine/no-redundant-resolve": "error";
     readonly "effect-machine/prefer-inline-handle": "error";
 };

package/dist/recommended.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"recommended.d.ts","sourceRoot":"","sources":["../src/recommended.ts"],"names":[],"mappings":"AAAA,wDAAwD;AACxD,eAAO,MAAM,WAAW;;;;CAId,CAAA"}
+{"version":3,"file":"recommended.d.ts","sourceRoot":"","sources":["../src/recommended.ts"],"names":[],"mappings":"AAAA,wDAAwD;AACxD,eAAO,MAAM,WAAW;;;;;;;CAOd,CAAA"}

package/dist/recommended.js

@@ -1,6 +1,9 @@
 /** Rules recommended for every Effect Machine model. */
 export const recommended = {
     "effect-machine/no-async-planning-callback": "error",
+    "effect-machine/no-browser-api-in-planning": "error",
+    "effect-machine/no-conflicting-invocation-identity": "error",
+    "effect-machine/no-nondeterministic-planning": "error",
     "effect-machine/no-redundant-resolve": "error",
     "effect-machine/prefer-inline-handle": "error"
 };

package/dist/recommended.js.map

@@ -1 +1 @@
-{"version":3,"file":"recommended.js","sourceRoot":"","sources":["../src/recommended.ts"],"names":[],"mappings":"AAAA,wDAAwD;AACxD,MAAM,CAAC,MAAM,WAAW,GAAG;IACzB,2CAA2C,EAAE,OAAO;IACpD,qCAAqC,EAAE,OAAO;IAC9C,qCAAqC,EAAE,OAAO;CACtC,CAAA"}
+{"version":3,"file":"recommended.js","sourceRoot":"","sources":["../src/recommended.ts"],"names":[],"mappings":"AAAA,wDAAwD;AACxD,MAAM,CAAC,MAAM,WAAW,GAAG;IACzB,2CAA2C,EAAE,OAAO;IACpD,2CAA2C,EAAE,OAAO;IACpD,mDAAmD,EAAE,OAAO;IAC5D,6CAA6C,EAAE,OAAO;IACtD,qCAAqC,EAAE,OAAO;IAC9C,qCAAqC,EAAE,OAAO;CACtC,CAAA"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typeonce/oxlint-plugin-effect-machine",
-  "version": "0.26.2",
+  "version": "0.27.0",
   "description": "Oxlint rules for Effect Machine models",
   "author": "Sandro Maglione",
   "repository": {

package/src/index.ts

@@ -1,5 +1,8 @@
 import type { Plugin } from "@oxlint/plugins"
 import { noAsyncPlanningCallback } from "./internal/rules/noAsyncPlanningCallback.js"
+import { noBrowserApiInPlanning } from "./internal/rules/noBrowserApiInPlanning.js"
+import { noConflictingInvocationIdentity } from "./internal/rules/noConflictingInvocationIdentity.js"
+import { noNondeterministicPlanning } from "./internal/rules/noNondeterministicPlanning.js"
 import { noRedundantResolve } from "./internal/rules/noRedundantResolve.js"
 import { preferInlineHandle } from "./internal/rules/preferInlineHandle.js"
 
@@ -9,6 +12,9 @@ const plugin = {
   },
   rules: {
     "no-async-planning-callback": noAsyncPlanningCallback,
+    "no-browser-api-in-planning": noBrowserApiInPlanning,
+    "no-conflicting-invocation-identity": noConflictingInvocationIdentity,
+    "no-nondeterministic-planning": noNondeterministicPlanning,
     "no-redundant-resolve": noRedundantResolve,
     "prefer-inline-handle": preferInlineHandle
   }

package/src/internal/ambient.ts

@@ -0,0 +1,134 @@
+import type { Context, ESTree } from "@oxlint/plugins"
+import { canonicalGlobalPath } from "./ast.js"
+
+const scheduledFunctions = new Set([
+  "fetch",
+  "queueMicrotask",
+  "requestAnimationFrame",
+  "requestIdleCallback",
+  "setImmediate",
+  "setInterval",
+  "setTimeout"
+])
+
+const promiseMethods = new Set([
+  "all",
+  "allSettled",
+  "any",
+  "race",
+  "reject",
+  "resolve",
+  "try"
+])
+
+export const asyncOperation = (
+  context: Context,
+  node: ESTree.CallExpression | ESTree.NewExpression
+): string | undefined => {
+  const path = canonicalGlobalPath(context, node.callee)
+  if (path === undefined) return undefined
+  if (node.type === "NewExpression") {
+    return path.length === 1 && path[0] === "Promise" ? "new Promise(...)" : undefined
+  }
+  if (path.length === 1 && scheduledFunctions.has(path[0]!)) return `${path[0]}(...)`
+  if (path.length === 2 && path[0] === "Promise" && promiseMethods.has(path[1]!)) {
+    return `Promise.${path[1]}(...)`
+  }
+  return path.length === 2 && path[0] === "process" && path[1] === "nextTick"
+    ? "process.nextTick(...)"
+    : undefined
+}
+
+export const nondeterministicOperation = (
+  context: Context,
+  node: ESTree.CallExpression | ESTree.NewExpression
+): string | undefined => {
+  const path = canonicalGlobalPath(context, node.callee)
+  if (path === undefined) return undefined
+  if (node.type === "NewExpression") {
+    return path.length === 1 && path[0] === "Date" && node.arguments.length === 0
+      ? "new Date()"
+      : undefined
+  }
+  if (path.length === 1 && path[0] === "Date") return "Date()"
+  if (path.length === 2 && path[0] === "Date" && path[1] === "now") return "Date.now()"
+  if (path.length === 2 && path[0] === "Math" && path[1] === "random") return "Math.random()"
+  if (
+    path.length === 2 &&
+    path[0] === "crypto" &&
+    (path[1] === "getRandomValues" || path[1] === "randomUUID")
+  ) return `crypto.${path[1]}(...)`
+  if (path.length === 2 && path[0] === "performance" && path[1] === "now") {
+    return "performance.now()"
+  }
+  if (path.length >= 3 && path[0] === "Temporal" && path[1] === "Now") {
+    return `${path.join(".")}()`
+  }
+  if (
+    path[0] === "process" &&
+    (path.join(".") === "process.hrtime" ||
+      path.join(".") === "process.hrtime.bigint" ||
+      path.join(".") === "process.uptime")
+  ) return `${path.join(".")}()`
+  return undefined
+}
+
+export const nondeterministicProperty = (
+  context: Context,
+  node: ESTree.MemberExpression
+): string | undefined => {
+  const path = canonicalGlobalPath(context, node)
+  return path?.length === 2 && path[0] === "performance" && path[1] === "timeOrigin"
+    ? "performance.timeOrigin"
+    : undefined
+}
+
+const browserRoots = new Set([
+  "caches",
+  "cookieStore",
+  "document",
+  "history",
+  "indexedDB",
+  "localStorage",
+  "location",
+  "navigator",
+  "screen",
+  "self",
+  "sessionStorage",
+  "visualViewport",
+  "window"
+])
+
+const browserFunctions = new Set([
+  "addEventListener",
+  "alert",
+  "confirm",
+  "dispatchEvent",
+  "getComputedStyle",
+  "matchMedia",
+  "open",
+  "postMessage",
+  "prompt",
+  "removeEventListener"
+])
+
+const browserConstructors = new Set([
+  "BroadcastChannel",
+  "EventSource",
+  "SharedWorker",
+  "WebSocket",
+  "Worker",
+  "XMLHttpRequest"
+])
+
+export const browserApi = (
+  context: Context,
+  node: ESTree.Expression
+): string | undefined => {
+  const path = canonicalGlobalPath(context, node)
+  if (path === undefined || path.length === 0) return undefined
+  if (browserRoots.has(path[0]!) || browserFunctions.has(path[0]!) || browserConstructors.has(path[0]!)) {
+    return path.join(".")
+  }
+  return undefined
+}

package/src/internal/ast.ts

@@ -0,0 +1,83 @@
+import type { Context, ESTree, Scope, Variable } from "@oxlint/plugins"
+import { staticMemberName } from "./imports.js"
+
+export const unwrapExpression = (node: ESTree.Expression): ESTree.Expression => {
+  let current = node
+  while (
+    current.type === "ChainExpression" ||
+    current.type === "ParenthesizedExpression" ||
+    current.type === "TSAsExpression" ||
+    current.type === "TSNonNullExpression" ||
+    current.type === "TSSatisfiesExpression" ||
+    current.type === "TSTypeAssertion"
+  ) current = current.expression
+  return current
+}
+
+const referenceIn = (
+  scope: Scope,
+  node: ESTree.IdentifierReference
+) =>
+  scope.references.find((reference) => reference.identifier === node) ??
+    scope.through.find((reference) => reference.identifier === node)
+
+export const resolvedVariable = (
+  context: Context,
+  node: ESTree.IdentifierReference
+): Variable | undefined => {
+  let scope: Scope | null = context.sourceCode.getScope(node)
+  while (scope !== null) {
+    const reference = referenceIn(scope, node)
+    if (reference !== undefined) return reference.resolved ?? undefined
+    scope = scope.upper
+  }
+  return undefined
+}
+
+export const isUnshadowedGlobal = (
+  context: Context,
+  node: ESTree.Expression,
+  name: string
+): node is ESTree.IdentifierReference => {
+  const expression = unwrapExpression(node)
+  if (expression.type !== "Identifier" || expression.name !== name) return false
+  if (context.sourceCode.isGlobalReference(expression)) return true
+
+  let scope: Scope | null = context.sourceCode.getScope(expression)
+  while (scope !== null) {
+    const reference = referenceIn(scope, expression)
+    if (reference !== undefined) return reference.resolved === null
+    scope = scope.upper
+  }
+  return false
+}
+
+export const globalPath = (
+  context: Context,
+  node: ESTree.Expression
+): ReadonlyArray<string> | undefined => {
+  const expression = unwrapExpression(node)
+  if (expression.type === "Identifier") {
+    return isUnshadowedGlobal(context, expression, expression.name)
+      ? [expression.name]
+      : undefined
+  }
+  if (expression.type !== "MemberExpression") return undefined
+
+  const member = staticMemberName(expression)
+  if (member === undefined) return undefined
+  const owner = globalPath(context, expression.object)
+  return owner === undefined ? undefined : [...owner, member]
+}
+
+const ambientQualifiers = new Set(["globalThis", "self", "window"])
+
+export const canonicalGlobalPath = (
+  context: Context,
+  node: ESTree.Expression
+): ReadonlyArray<string> | undefined => {
+  const path = globalPath(context, node)
+  return path !== undefined && path.length > 1 && ambientQualifiers.has(path[0]!)
+    ? path.slice(1)
+    : path
+}

package/src/internal/imports.ts

@@ -37,12 +37,16 @@ export const recordMachineImport = (
 export const hasMachineImport = (bindings: MachineBindings): boolean =>
   bindings.machine.size > 0 || bindings.namespaces.size > 0
 
-export const staticMemberName = (node: ESTree.Node): string | undefined =>
-  node.type === "MemberExpression" &&
-    !node.computed &&
-    node.property.type === "Identifier"
+export const staticMemberName = (node: ESTree.Node): string | undefined => {
+  if (node.type !== "MemberExpression") return undefined
+  return node.computed
+    ? node.property.type === "Literal" && typeof node.property.value === "string"
+      ? node.property.value
+      : undefined
+    : node.property.type === "Identifier"
     ? node.property.name
     : undefined
+}
 
 const isNamespaceMachine = (
   node: ESTree.Node,
@@ -55,6 +59,24 @@ const isNamespaceMachine = (
   node.property.type === "Identifier" &&
   node.property.name === "Machine"
 
+const isMachineReference = (
+  node: ESTree.Node,
+  bindings: MachineBindings
+): boolean =>
+  node.type === "Identifier"
+    ? bindings.machine.has(node.name)
+    : isNamespaceMachine(node, bindings)
+
+export const isMachineMemberCall = (
+  node: ESTree.Node,
+  member: string,
+  bindings: MachineBindings
+): node is ESTree.CallExpression =>
+  node.type === "CallExpression" &&
+  node.callee.type === "MemberExpression" &&
+  staticMemberName(node.callee) === member &&
+  isMachineReference(node.callee.object, bindings)
+
 export const isMachineMakeCall = (
   node: ESTree.CallExpression,
   bindings: MachineBindings
@@ -64,10 +86,7 @@ export const isMachineMakeCall = (
     staticMemberName(node.callee) !== "make"
   ) return false
 
-  const receiver = node.callee.object
-  return receiver.type === "Identifier"
-    ? bindings.machine.has(receiver.name)
-    : isNamespaceMachine(receiver, bindings)
+  return isMachineReference(node.callee.object, bindings)
 }
 
 export const recordMachineDefinition = (

package/src/internal/planning.ts

@@ -1,4 +1,5 @@
 import type { ESTree } from "@oxlint/plugins"
+import { unwrapExpression } from "./ast.js"
 import { isMachineHandleCall, isMachineMakeCall, type MachineBindings, staticMemberName } from "./imports.js"
 
 export type PlanningFunction = ESTree.ArrowFunctionExpression | ESTree.Function
@@ -16,7 +17,10 @@ const statePlanningProperties = new Set([
   "choice",
   "entry",
   "exit",
-  "invoke"
+  "initialize",
+  "invoke",
+  "onDone",
+  "output"
 ])
 
 const propertyName = (node: ESTree.Node): string | undefined => {
@@ -74,6 +78,26 @@ const isEventHandlerProperty = (
     isStateConfig(onProperty.parent, bindings)
 }
 
+const isHistoryDefaultProperty = (
+  node: ESTree.Node,
+  bindings: MachineBindings
+): boolean => {
+  if (node.type !== "Property" || propertyName(node) !== "default") return false
+  const historyEntry = node.parent
+  if (
+    historyEntry.type !== "ObjectExpression" ||
+    historyEntry.parent.type !== "Property" ||
+    historyEntry.parent.parent.type !== "ObjectExpression"
+  ) return false
+  const historyEntries = historyEntry.parent.parent
+  if (
+    historyEntries.parent.type !== "Property" ||
+    propertyName(historyEntries.parent) !== "history" ||
+    historyEntries.parent.parent.type !== "ObjectExpression"
+  ) return false
+  return isStateConfig(historyEntries.parent.parent, bindings)
+}
+
 const isPropertyPlanningCallback = (
   node: PlanningFunction,
   bindings: MachineBindings
@@ -89,10 +113,11 @@ const isPropertyPlanningCallback = (
   return name === "initial"
     ? isMachineMakeConfig(property.parent, bindings)
     : (name !== undefined && statePlanningProperties.has(name) && isStateConfig(property.parent, bindings)) ||
-      isEventHandlerProperty(property, bindings)
+      isEventHandlerProperty(property, bindings) ||
+      isHistoryDefaultProperty(property, bindings)
 }
 
-const enclosingFunction = (node: ESTree.Node): PlanningFunction | undefined => {
+export const enclosingFunction = (node: ESTree.Node): PlanningFunction | undefined => {
   let current: ESTree.Node | null = node.parent
   while (current !== null && current.type !== "Program") {
     if (
@@ -104,6 +129,40 @@ const enclosingFunction = (node: ESTree.Node): PlanningFunction | undefined => {
   return undefined
 }
 
+const selectorRoot = (node: ESTree.Expression): string | undefined => {
+  let expression = unwrapExpression(node)
+  while (expression.type === "CallExpression" || expression.type === "MemberExpression") {
+    expression = unwrapExpression(
+      expression.type === "CallExpression"
+        ? expression.callee
+        : expression.object
+    )
+  }
+  return expression.type === "Identifier" ? expression.name : undefined
+}
+
+export const enclosingPlanningCallback = (
+  node: ESTree.Node,
+  bindings: MachineBindings
+): PlanningFunction | undefined => {
+  const callback = enclosingFunction(node)
+  return callback !== undefined && isPlanningCallback(callback, bindings)
+    ? callback
+    : undefined
+}
+
+export const isInvokePlanningCallback = (
+  node: PlanningFunction,
+  bindings: MachineBindings
+): boolean => {
+  const property = node.parent
+  return property.type === "Property" &&
+    property.value === node &&
+    propertyName(property) === "invoke" &&
+    property.parent.type === "ObjectExpression" &&
+    isStateConfig(property.parent, bindings)
+}
+
 export const isPlanningCallback = (
   node: PlanningFunction,
   bindings: MachineBindings
@@ -112,12 +171,15 @@ export const isPlanningCallback = (
 
   const parent = node.parent
   if (parent.type === "CallExpression" && parent.arguments.includes(node)) {
-    const method = parent.callee.type === "MemberExpression"
-      ? staticMemberName(parent.callee)
-      : undefined
+    if (parent.callee.type !== "MemberExpression") return false
+    const method = staticMemberName(parent.callee)
     if (method !== undefined && directPlanningMethods.has(method)) {
       const owner = enclosingFunction(parent)
-      return owner !== undefined && isPlanningCallback(owner, bindings)
+      const selector = owner?.params[0]
+      return owner !== undefined &&
+        selector?.type === "Identifier" &&
+        selectorRoot(parent.callee.object) === selector.name &&
+        isPlanningCallback(owner, bindings)
     }
   }
   return false

package/src/internal/rules/noAsyncPlanningCallback.ts

@@ -1,6 +1,7 @@
-import type { Rule } from "@oxlint/plugins"
+import type { ESTree, Rule } from "@oxlint/plugins"
+import { asyncOperation } from "../ambient.js"
 import { hasMachineImport, makeMachineBindings, recordMachineDefinition, recordMachineImport } from "../imports.js"
-import { isPlanningCallback, type PlanningFunction } from "../planning.js"
+import { enclosingPlanningCallback, isPlanningCallback, type PlanningFunction } from "../planning.js"
 
 export const noAsyncPlanningCallback: Rule = {
   meta: {
@@ -11,7 +12,10 @@ export const noAsyncPlanningCallback: Rule = {
     },
     schema: [],
     messages: {
-      asyncPlanning: "Planning callbacks must be synchronous. Move asynchronous work into state-owned invocation."
+      asyncOperation:
+        "{{operation}} starts asynchronous work during synchronous planning. Move it into the owning state's invoke declaration using from.effect(...), from.stream(...), or from.timer(...), then handle completion or failure with onDone/onFailure.",
+      asyncPlanning:
+        "Planning callbacks must be synchronous. Remove async and move the asynchronous work into the owning state's invoke declaration, then transition from onDone/onFailure."
     }
   },
   create(context) {
@@ -25,11 +29,24 @@ export const noAsyncPlanningCallback: Rule = {
         context.report({ node, messageId: "asyncPlanning" })
       }
     }
+    const inspectOperation = (
+      node: ESTree.CallExpression | ESTree.NewExpression
+    ): void => {
+      if (!hasMachineImport(bindings)) return
+      const callback = enclosingPlanningCallback(node, bindings)
+      if (callback === undefined || callback.async) return
+      const operation = asyncOperation(context, node)
+      if (operation !== undefined) {
+        context.report({ node, messageId: "asyncOperation", data: { operation } })
+      }
+    }
     return {
       ImportDeclaration: (node) => recordMachineImport(bindings, node),
       VariableDeclarator: (node) => recordMachineDefinition(bindings, node),
       ArrowFunctionExpression: inspect,
-      FunctionExpression: inspect
+      FunctionExpression: inspect,
+      CallExpression: inspectOperation,
+      NewExpression: inspectOperation
     }
   }
 }

package/src/internal/rules/noBrowserApiInPlanning.ts

@@ -0,0 +1,57 @@
+import type { ESTree, Rule } from "@oxlint/plugins"
+import { browserApi } from "../ambient.js"
+import { hasMachineImport, makeMachineBindings, recordMachineDefinition, recordMachineImport } from "../imports.js"
+import { enclosingPlanningCallback } from "../planning.js"
+
+const isOutermostAccess = (node: ESTree.Expression): boolean => {
+  const parent = node.parent
+  if (parent.type === "MemberExpression" && parent.object === node) return false
+  if (
+    (parent.type === "CallExpression" || parent.type === "NewExpression") &&
+    parent.callee === node
+  ) return false
+  return true
+}
+
+export const noBrowserApiInPlanning: Rule = {
+  meta: {
+    type: "problem",
+    docs: {
+      description: "Keep browser state and side effects out of Effect Machine planning.",
+      recommended: true
+    },
+    schema: [],
+    messages: {
+      browserApi:
+        "{{api}} reads browser state or performs a browser side effect during synchronous planning. If it affects the workflow, run it in a state-owned invocation and transition from its outcome. If it only affects presentation, keep it in the UI adapter."
+    }
+  },
+  create(context) {
+    const bindings = makeMachineBindings()
+    const inspect = (node: ESTree.Expression): void => {
+      if (
+        !hasMachineImport(bindings) ||
+        !isOutermostAccess(node) ||
+        enclosingPlanningCallback(node, bindings) === undefined
+      ) return
+      const api = browserApi(context, node)
+      if (api !== undefined) context.report({ node, messageId: "browserApi", data: { api } })
+    }
+    const inspectOperation = (node: ESTree.CallExpression | ESTree.NewExpression): void => {
+      if (
+        !hasMachineImport(bindings) ||
+        enclosingPlanningCallback(node, bindings) === undefined
+      ) return
+      const api = browserApi(context, node.callee)
+      if (api !== undefined) context.report({ node, messageId: "browserApi", data: { api } })
+    }
+    return {
+      ImportDeclaration: (node) => recordMachineImport(bindings, node),
+      Identifier: (node) => inspect(node as ESTree.IdentifierReference),
+      MemberExpression: inspect,
+      CallExpression: inspectOperation,
+      NewExpression: inspectOperation,
+      VariableDeclarator: (node) => recordMachineDefinition(bindings, node)
+    }
+  }
+}