@typeonce/effect-machine 0.19.1 → 0.21.0

package/src/internal/machine/topology.ts

@@ -29,6 +29,8 @@ export const DeclinedTypeId: unique symbol = Symbol("effect/Machine/Declined")
 
 export const TargetSelectionTypeId: unique symbol = Symbol("effect/Machine/TargetSelection")
 
+export const StateUpdateTypeId: unique symbol = Symbol("effect/Machine/StateUpdate")
+
 export const SelectedBranchTypeId: unique symbol = Symbol("effect/Machine/SelectedBranch")
 
 interface StateInput {
@@ -73,7 +75,7 @@ export interface Declined {
   readonly [DeclinedTypeId]: typeof DeclinedTypeId
 }
 
-export type TargetSelectionKind = "state" | "initial" | "history" | "choice" | "none"
+export type TargetSelectionKind = "state" | "initial" | "history" | "choice" | "update" | "none"
 
 export type TargetSelectionScope = "local" | "branch" | "full" | "initial"
 
@@ -111,6 +113,21 @@ export const noneTargetSelection: TargetSelection = makeTargetSelection("none",
 
 export const isTargetSelection = (u: unknown): u is TargetSelection => hasProperty(u, TargetSelectionTypeId)
 
+export interface StateUpdate {
+  readonly [StateUpdateTypeId]: typeof StateUpdateTypeId
+  readonly path: string
+  readonly value: unknown
+}
+
+export const makeStateUpdate = (path: string, value: unknown): StateUpdate =>
+  Object.freeze({
+    [StateUpdateTypeId]: StateUpdateTypeId,
+    path,
+    value
+  })
+
+export const isStateUpdate = (u: unknown): u is StateUpdate => hasProperty(u, StateUpdateTypeId)
+
 export const makeSelectedBranch = (
   owner: object,
   branchIndex: number,

package/src/internal/testing/machine/verification.ts

@@ -475,7 +475,7 @@ const targetWithinSelection = (
   nodeByPath: ReadonlyMap<string, Machine.Machine.StateNode>
 ): boolean => {
   const selection = branch.selection
-  if (selection.kind === "none") return target === undefined
+  if (selection.kind === "none" || selection.kind === "update") return target === undefined
   if (target === undefined || selection.path === undefined) return false
   if (target === selection.path) return true
   const selectedNode = nodeByPath.get(selection.path)
@@ -564,6 +564,7 @@ export const coverage = <M extends AnyMachine>(
   const exitHits = new Set<number>()
 
   const transitionCoverage = makeTransitionCoverageCollector(machine)
+  const transitionDefinitions = Machine.transitionDefinitions(machine)
 
   const declaredEvents = publicEventTags(machine)
   const declaredEventTags = declaredEvents.tags
@@ -577,6 +578,7 @@ export const coverage = <M extends AnyMachine>(
   let microsteps = 0
   let changedMicrosteps = 0
   let targetlessTransitions = 0
+  let stateUpdates = 0
   let raisedEvents = 0
   let emittedEvents = 0
   let eventTriggered = 0
@@ -630,7 +632,13 @@ export const coverage = <M extends AnyMachine>(
     hitPaths(microstep.exitPaths, exitHits)
     observeSnapshot(microstep.next)
     for (const retained of microstep.transitions) {
-      if (retained.target === undefined) targetlessTransitions += 1
+      const definition = transitionDefinitions.find((candidate) =>
+        candidate.source === retained.source && candidate.reenter === retained.reenter &&
+        sameTransitionTrigger(candidate.trigger, retained.trigger)
+      )
+      const branch = definition?.branches[retained.branchIndex]
+      if (branch?.selection.kind === "update") stateUpdates += 1
+      else if (retained.target === undefined) targetlessTransitions += 1
       if (retained.trigger.type === "event") eventTriggered += 1
       else if (retained.trigger.type === "always") alwaysTriggered += 1
       else if (retained.trigger.type === "done") doneTriggered += 1
@@ -718,6 +726,7 @@ export const coverage = <M extends AnyMachine>(
       total: microsteps,
       changed: changedMicrosteps,
       targetless: targetlessTransitions,
+      updates: stateUpdates,
       raised: raisedEvents,
       emitted: emittedEvents,
       eventTriggered,
@@ -1598,7 +1607,11 @@ export const verify = <M extends AnyMachine>(
       const resolvedTarget = transition.resolvedTarget === undefined ? undefined : String(transition.resolvedTarget)
       const targetNode = target === undefined ? undefined : byPath.get(target)
       let expected = target
-      let explanation = target === undefined ? "an unresolved targetless transition" : `target "${target}"`
+      let explanation = branches[index]?.selection.kind === "update"
+        ? `update owner "${String(branches[index]?.selection.path)}"`
+        : target === undefined
+        ? "an unresolved targetless transition"
+        : `target "${target}"`
 
       if (transition.trigger.type === "choice") {
         explanation = target === undefined ? "a targetless choice edge" : `choice edge target "${target}"`

package/src/testing/MachineTest.ts

@@ -1822,6 +1822,8 @@ export interface MicrostepCoverageEvidence {
   readonly total: number
   readonly changed: number
   readonly targetless: number
+  /** Retained state-value update operations. */
+  readonly updates: number
   readonly raised: number
   readonly emitted: number
   readonly eventTriggered: number

package/src/unstable/reactivity/AtomMachine.ts

@@ -148,9 +148,9 @@ export interface MachineAtom<State, Event, Error = never, Output = never, StartE
   readonly stop: Atom.Writable<AsyncResult.AsyncResult<void, StartError | NotReadyError>, void>
 
   /**
-   * Creates a reactive bridge for a directly invoked child machine.
-   * Reusing the same descriptor returns the same live bridge while it remains
-   * referenced.
+   * Creates a reactive bridge for a directly owned child machine.
+   * Descriptors with the same id and machine definition return the same live
+   * bridge while it remains referenced.
    *
    * @since 0.4.0
    */
@@ -206,7 +206,8 @@ export const childEmissions: <Child extends Machine.ChildMachine.Any, StartError
 > = internal.childEmissions
 
 /**
- * Reactive access to one invoked child machine selected by its descriptor.
+ * Reactive access to one directly owned child machine selected by its
+ * descriptor.
  *
  * **Details**
  *
@@ -295,8 +296,9 @@ export interface ChildMachineAtom<Child extends Machine.ChildMachine.Any, StartE
     void
   >
   /**
-   * Creates a reactive bridge for a directly owned nested child. Reusing the
-   * same descriptor returns the same live bridge while it remains referenced.
+   * Creates a reactive bridge for a directly owned nested child. Descriptors
+   * with the same id and machine definition return the same live bridge while
+   * it remains referenced.
    *
    * @since 0.4.0
    */
@@ -418,7 +420,7 @@ export const selectSnapshot: <
 > = internal.selectSnapshot
 
 /**
- * Selects the typed value for an active state path in an invoked child.
+ * Selects the typed value for an active state path in a directly owned child.
  *
  * Valid paths and their selected value types are inferred from the child
  * bridge. An inactive child produces `Option.none()`. Keep the returned atom
@@ -513,7 +515,7 @@ export const matches: <
 ) => Atom.Atom<AsyncResult.AsyncResult<boolean, StartError | Error>> = internal.matches
 
 /**
- * Returns whether a state path is active in an invoked child.
+ * Returns whether a state path is active in a directly owned child.
  *
  * Valid paths are inferred from the child bridge snapshot.
  * An inactive child produces `false`. Keep the returned atom stable when