@twreporter/universal-header 2.2.0-rc.5 → 2.2.0-rc.6

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [2.2.0-rc.6](https://github.com/twreporter/twreporter-npm-packages/compare/@twreporter/universal-header@2.2.0-rc.5...@twreporter/universal-header@2.2.0-rc.6) (2021-09-28)
+
+
+### Bug Fixes
+
+* address review comment & lint error ([#212](https://github.com/twreporter/twreporter-npm-packages/issues/212)) ([c02800d](https://github.com/twreporter/twreporter-npm-packages/commit/c02800dd410ae08abbe617d31509ad18ba7cd3aa))
+
+
+
+
+
 # [2.2.0-rc.5](https://github.com/twreporter/twreporter-npm-packages/compare/@twreporter/universal-header@2.2.0-rc.4...@twreporter/universal-header@2.2.0-rc.5) (2021-09-28)
 
 

package/lib/containers/header.js

@@ -110,25 +110,6 @@ var DesktopAndAbove = /*#__PURE__*/_styledComponents["default"].div.withConfig({
   componentId: "narage-2"
 })(["display:none;", ""], _mediaQuery["default"].desktopAndAbove(_templateObject3 || (_templateObject3 = _taggedTemplateLiteral(["\n    display: block;\n    ", "\n  "])), stickyTop));
 
-function mergeTwoArraysInOrder() {
-  var arr1 = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : [];
-  var arr2 = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : [];
-  var rtn = [];
-  var maxLength = Math.max(arr1.length, arr2.length);
-
-  for (var i = 0; i < maxLength; i++) {
-    if (arr1[i]) {
-      rtn.push(arr1[i]);
-    }
-
-    if (arr2[i]) {
-      rtn.push(arr2[i]);
-    }
-  }
-
-  return rtn;
-}
-
 var Container = /*#__PURE__*/function (_React$PureComponent) {
   _inherits(Container, _React$PureComponent);
 
@@ -148,7 +129,7 @@ var Container = /*#__PURE__*/function (_React$PureComponent) {
 
     _this.currentY = 0;
     _this.readyY = 0;
-    _this.isTransformfasle = false;
+    _this.isTransforming = false;
     _this.transformTimer = null;
     return _this;
   }
@@ -164,6 +145,11 @@ var Container = /*#__PURE__*/function (_React$PureComponent) {
     key: "componentWillUnmount",
     value: function componentWillUnmount() {
       window.removeEventListener('scroll', this.handleScroll);
+      this.handleScroll = null;
+      this.currentY = null;
+      this.readyY = null;
+      this.isTransforming = null;
+      this.transformTimer = null;
     }
   }, {
     key: "__handleScroll",
@@ -188,7 +174,7 @@ var Container = /*#__PURE__*/function (_React$PureComponent) {
         return scrollState;
       }
 
-      scrollState.toUseNarrow = scrollTop > TRANSFORM_HEADER_THRESHOLD ? true : false;
+      scrollState.toUseNarrow = scrollTop > TRANSFORM_HEADER_THRESHOLD;
 
       if (scrollDirection === 'up') {
         this.readyY = scrollTop;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@twreporter/universal-header",
-  "version": "2.2.0-rc.5",
+  "version": "2.2.0-rc.6",
   "description": "Universal header of TWReporter sites",
   "main": "lib/index.js",
   "scripts": {
@@ -34,5 +34,5 @@
   "files": [
     "lib"
   ],
-  "gitHead": "90edfc2fc461434c447e618395d6dfbff19aaa97"
+  "gitHead": "fb8726c9e2b313d1c9198524c340f9ef5cfcdc1b"
 }