@twreporter/react-article-components 1.6.2-rc.0 → 1.6.2-rc.1

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.6.2-rc.1](https://github.com/twreporter/twreporter-npm-packages/compare/@twreporter/react-article-components@1.6.2-rc.0...@twreporter/react-article-components@1.6.2-rc.1) (2022-08-03)
+
+
+### Bug Fixes
+
+* update isLoaded initially for non-infogram embed ([#296](https://github.com/twreporter/twreporter-npm-packages/issues/296)) ([714b12e](https://github.com/twreporter/twreporter-npm-packages/commit/714b12ebff7b36f970813435f7b268a92fde0250))
+
+
+
+
+
 ## [1.6.2-rc.0](https://github.com/twreporter/twreporter-npm-packages/compare/@twreporter/react-article-components@1.6.1...@twreporter/react-article-components@1.6.2-rc.0) (2022-07-27)
 
 **Note:** Version bump only for package @twreporter/react-article-components

package/lib/components/body/embedded-code.js

@@ -202,7 +202,9 @@ var EmbeddedCode = /*#__PURE__*/function (_React$PureComponent) {
 
       // Delay loading infogram in loadEmbed()
       if (!((_this$_embeddedCodeWi = this._embeddedCodeWithoutScript) !== null && _this$_embeddedCodeWi !== void 0 && _this$_embeddedCodeWi.includes(infogramEmbed))) {
-        this.executeScript();
+        this.setState({
+          isLoaded: true
+        }, this.executeScript);
       }
     }
   }, {
@@ -278,13 +280,21 @@ var WayPointWrapper = function WayPointWrapper(props) {
     setIsInViewPort(false);
   };
 
-  return /*#__PURE__*/_react["default"].createElement(_reactWaypoint.Waypoint, {
-    onEnter: onEnter,
-    onLeave: onLeave,
-    fireOnRapidScroll: false
-  }, /*#__PURE__*/_react["default"].createElement("div", null, /*#__PURE__*/_react["default"].createElement(EmbeddedCode, _extends({}, props, {
-    ref: embedRef
-  }))));
+  return (
+    /*#__PURE__*/
+    // Note: When an anchor is exactly below an infogram embed, onLeave() is not fired
+    // when jumping to the anchor because infogram's bottom boundary is just overlapped
+    // with viewport's top boundary. Setting topOffset is to shorter infogram's boundary
+    // a little bit to make sure onLeave() fires.
+    _react["default"].createElement(_reactWaypoint.Waypoint, {
+      onEnter: onEnter,
+      onLeave: onLeave,
+      fireOnRapidScroll: false,
+      topOffset: 5
+    }, /*#__PURE__*/_react["default"].createElement("div", null, /*#__PURE__*/_react["default"].createElement(EmbeddedCode, _extends({}, props, {
+      ref: embedRef
+    }))))
+  );
 };
 
 WayPointWrapper.defaultProps = {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@twreporter/react-article-components",
-  "version": "1.6.2-rc.0",
+  "version": "1.6.2-rc.1",
   "description": "The Reporter react article components, which are used in article page",
   "main": "lib/components/article-page.js",
   "repository": "https://github.com/twreporter/twreporter-npm-packages.git",
@@ -40,5 +40,5 @@
   "files": [
     "lib"
   ],
-  "gitHead": "adbbd91639cb9a74438108b97083294acf57d8cf"
+  "gitHead": "5ecf776ab96cef00c58295783e230f483dc653d6"
 }