@twinsearth/w2m-dsh-plugin 0.12.3 → 0.13.0

package/CHANGELOG.md

@@ -4,6 +4,47 @@ All notable changes to this project are documented here. The format follows
 [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project
 adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.13.0] — 2026-10-15
+
+**The root cause of three rounds of confusion was a regex, and it was mine.**
+
+Several rounds were spent believing a suite *failed on macOS*. It had not. The parser was looking for lines
+beginning `# tests 17`. Node v24 writes them beginning `ℹ tests 17`:
+
+```
+ℹ tests 17        not        # tests 17
+ℹ pass 17                    # pass 17
+ℹ fail 0                     # fail 0
+```
+
+**The `#` form was an assumption that was never checked**, carried from the first script written in this
+session to every one after it. The damage was worse than a misread count:
+
+* suites that had **passed** were recorded as `UNREADABLE`;
+* and then the absence of a `# fail` line, together with the absence of test *names* in the captured output,
+  was read as **"the process crashed before printing anything"** — which pointed at module scope and sent an
+  investigation somewhere the fault was not. Two rounds went into that, including a probe that correctly ruled
+  out every file-system hypothesis, because the hypothesis being tested was derived from a bad premise.
+
+`src/agent/test-report.mjs` now writes the contract down, parses both prefixes plus a bare form, reads
+**both streams and says which one answered**, and reports its own format so a future change is *reported*
+rather than silently tolerated. 13 tests, and the two that matter most are:
+
+* the **real** v24 output parses (taken verbatim from a run, not invented);
+* an unreadable report yields `verdict(...) === null`, **not `false`** — collapsing "could not read" into
+  "failed" is the safer of the two wrong directions and was still wrong enough to waste rounds.
+
+### The lesson, stated so it generalises
+
+**I assumed the shape of a channel's output instead of measuring it** — the same error, from the same
+channel, for the third time in this session (first the exit-code summary line, then the test names, now the
+prefix). The technique that finally settled it was printing the raw output and looking at it, which took one
+command and should have been the first.
+
+`test/log-bounds.test.mjs` remains skipped on macOS. With a working parser the skip is no longer plausible as
+a parse artefact, so the underlying assertion failure is still **UNVERIFIED** — but the reason it took so long
+to see is now fixed and tested.
+
 ## [0.12.3] — 2026-10-15
 
 **Correcting a wrong inference that 0.12.2 recorded as fact.**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@twinsearth/w2m-dsh-plugin",
-  "version": "0.12.3",
+  "version": "0.13.0",
   "description": "DSH: Windows2MacOS — drive the same project on online Windows and macOS machines from one DeepSeek account, across networks and regions. P2P hole punching is the default path (relay + shared server as rendezvous, ledger and fallback), with a bundled STUN responder, Tailscale/public-VPS/tunnel shapes, Rabbit relay + per-machine Localside + eight DSH tools (replicate / split), nine aggregate verdicts and signed requests.",
   "type": "module",
   "main": "lib/index.js",
@@ -113,13 +113,13 @@
     }
   },
   "scripts": {
-    "test": "node --test --test-force-exit test/relay.test.mjs test/broadcast.test.mjs test/agent.test.mjs test/authority.test.mjs test/blocks.test.mjs test/approval-index.test.mjs test/fleet-sync.test.mjs test/health.test.mjs test/storage.test.mjs test/exit-channel.test.mjs test/council.test.mjs test/log-bounds.test.mjs test/layer-model.test.mjs test/memory.test.mjs test/tools.test.mjs  test/claims.test.mjs test/fleet-target.test.mjs test/client-bundle.test.mjs test/schedule.test.mjs test/auto-update.test.mjs test/update-source.test.mjs test/update-install.test.mjs test/update-wiring.test.mjs test/signing.test.mjs test/stress.test.mjs test/shared-config.test.mjs test/metrics.test.mjs test/metrics-route.test.mjs test/tool-cards.test.mjs test/p2p-stun.test.mjs test/p2p-transport.test.mjs test/p2p-signaling.test.mjs test/p2p-node.test.mjs test/p2p-transport-fields.test.mjs test/p2p-plugin.test.mjs test/p2p-crypto.test.mjs test/stun-server.test.mjs test/loader-entry.test.mjs test/mdns-wire.test.mjs test/mdns-discover.test.mjs test/chatops-approval.test.mjs test/chatops-policy.test.mjs test/chatops-file-safety.test.mjs test/chatops-outbound-queue.test.mjs test/chatops-commands.test.mjs test/chatops-bridge.test.mjs test/chatops-config-route.test.mjs test/chatops-apply.test.mjs test/chatops-ilink-contract.test.mjs test/chatops-fleet.test.mjs test/chatops-account.test.mjs test/chatops-auth.test.mjs test/chatops-fleet-scope.test.mjs test/chatops-handoff.test.mjs test/chatops-fleet-wiring.test.mjs test/chatops-fleet-live.test.mjs test/chatops-takeover.test.mjs test/chatops-device-signing.test.mjs test/chatops-relay-verify.test.mjs test/chatops-durability.test.mjs test/chatops-run-command.test.mjs test/secrets-guard.test.mjs test/chatops-ilink-fleet-bridge.test.mjs test/chatops-fleet-join.test.mjs",
+    "test": "node --test --test-force-exit test/relay.test.mjs test/broadcast.test.mjs test/agent.test.mjs test/authority.test.mjs test/blocks.test.mjs test/approval-index.test.mjs test/fleet-sync.test.mjs test/health.test.mjs test/storage.test.mjs test/exit-channel.test.mjs test/council.test.mjs test/log-bounds.test.mjs test/test-report.test.mjs test/layer-model.test.mjs test/memory.test.mjs test/tools.test.mjs  test/claims.test.mjs test/fleet-target.test.mjs test/client-bundle.test.mjs test/schedule.test.mjs test/auto-update.test.mjs test/update-source.test.mjs test/update-install.test.mjs test/update-wiring.test.mjs test/signing.test.mjs test/stress.test.mjs test/shared-config.test.mjs test/metrics.test.mjs test/metrics-route.test.mjs test/tool-cards.test.mjs test/p2p-stun.test.mjs test/p2p-transport.test.mjs test/p2p-signaling.test.mjs test/p2p-node.test.mjs test/p2p-transport-fields.test.mjs test/p2p-plugin.test.mjs test/p2p-crypto.test.mjs test/stun-server.test.mjs test/loader-entry.test.mjs test/mdns-wire.test.mjs test/mdns-discover.test.mjs test/chatops-approval.test.mjs test/chatops-policy.test.mjs test/chatops-file-safety.test.mjs test/chatops-outbound-queue.test.mjs test/chatops-commands.test.mjs test/chatops-bridge.test.mjs test/chatops-config-route.test.mjs test/chatops-apply.test.mjs test/chatops-ilink-contract.test.mjs test/chatops-fleet.test.mjs test/chatops-account.test.mjs test/chatops-auth.test.mjs test/chatops-fleet-scope.test.mjs test/chatops-handoff.test.mjs test/chatops-fleet-wiring.test.mjs test/chatops-fleet-live.test.mjs test/chatops-takeover.test.mjs test/chatops-device-signing.test.mjs test/chatops-relay-verify.test.mjs test/chatops-durability.test.mjs test/chatops-run-command.test.mjs test/secrets-guard.test.mjs test/chatops-ilink-fleet-bridge.test.mjs test/chatops-fleet-join.test.mjs",
     "test:e2e": "node --test --test-force-exit test/e2e.test.mjs test/crossnetwork.test.mjs test/signing-e2e.test.mjs test/outbound-only.test.mjs test/recovery.test.mjs test/pipeline-e2e.test.mjs test/p2p-agent.test.mjs",
     "test:relay": "node --test --test-force-exit test/relay.test.mjs",
     "test:agent": "node --test --test-force-exit test/agent.test.mjs test/memory.test.mjs",
     "test:tools": "node --test --test-force-exit test/tools.test.mjs",
     "test:crossnetwork": "node --test --test-force-exit test/crossnetwork.test.mjs",
-    "test:all": "node --test --test-force-exit test/relay.test.mjs test/broadcast.test.mjs test/agent.test.mjs test/authority.test.mjs test/blocks.test.mjs test/approval-index.test.mjs test/fleet-sync.test.mjs test/health.test.mjs test/storage.test.mjs test/exit-channel.test.mjs test/council.test.mjs test/log-bounds.test.mjs test/layer-model.test.mjs test/memory.test.mjs test/tools.test.mjs  test/claims.test.mjs test/fleet-target.test.mjs test/client-bundle.test.mjs test/schedule.test.mjs test/auto-update.test.mjs test/update-source.test.mjs test/update-install.test.mjs test/update-wiring.test.mjs test/signing.test.mjs test/stress.test.mjs test/e2e.test.mjs test/crossnetwork.test.mjs test/signing-e2e.test.mjs test/outbound-only.test.mjs test/recovery.test.mjs test/pipeline-e2e.test.mjs test/shared-config.test.mjs test/metrics.test.mjs test/metrics-route.test.mjs test/tool-cards.test.mjs test/p2p-stun.test.mjs test/p2p-transport.test.mjs test/p2p-signaling.test.mjs test/p2p-node.test.mjs test/p2p-transport-fields.test.mjs test/p2p-plugin.test.mjs test/p2p-agent.test.mjs test/stun-server.test.mjs test/loader-entry.test.mjs test/mdns-wire.test.mjs test/mdns-discover.test.mjs test/p2p-crypto.test.mjs test/chatops-approval.test.mjs test/chatops-policy.test.mjs test/chatops-file-safety.test.mjs test/chatops-outbound-queue.test.mjs test/chatops-commands.test.mjs test/chatops-bridge.test.mjs test/chatops-config-route.test.mjs test/chatops-apply.test.mjs test/chatops-ilink-contract.test.mjs test/chatops-fleet.test.mjs test/chatops-account.test.mjs test/chatops-auth.test.mjs test/chatops-fleet-scope.test.mjs test/chatops-handoff.test.mjs test/chatops-fleet-wiring.test.mjs test/chatops-fleet-live.test.mjs test/chatops-takeover.test.mjs test/chatops-device-signing.test.mjs test/chatops-relay-verify.test.mjs test/chatops-durability.test.mjs test/chatops-run-command.test.mjs test/secrets-guard.test.mjs test/chatops-ilink-fleet-bridge.test.mjs test/chatops-fleet-join.test.mjs",
+    "test:all": "node --test --test-force-exit test/relay.test.mjs test/broadcast.test.mjs test/agent.test.mjs test/authority.test.mjs test/blocks.test.mjs test/approval-index.test.mjs test/fleet-sync.test.mjs test/health.test.mjs test/storage.test.mjs test/exit-channel.test.mjs test/council.test.mjs test/log-bounds.test.mjs test/test-report.test.mjs test/layer-model.test.mjs test/memory.test.mjs test/tools.test.mjs  test/claims.test.mjs test/fleet-target.test.mjs test/client-bundle.test.mjs test/schedule.test.mjs test/auto-update.test.mjs test/update-source.test.mjs test/update-install.test.mjs test/update-wiring.test.mjs test/signing.test.mjs test/stress.test.mjs test/e2e.test.mjs test/crossnetwork.test.mjs test/signing-e2e.test.mjs test/outbound-only.test.mjs test/recovery.test.mjs test/pipeline-e2e.test.mjs test/shared-config.test.mjs test/metrics.test.mjs test/metrics-route.test.mjs test/tool-cards.test.mjs test/p2p-stun.test.mjs test/p2p-transport.test.mjs test/p2p-signaling.test.mjs test/p2p-node.test.mjs test/p2p-transport-fields.test.mjs test/p2p-plugin.test.mjs test/p2p-agent.test.mjs test/stun-server.test.mjs test/loader-entry.test.mjs test/mdns-wire.test.mjs test/mdns-discover.test.mjs test/p2p-crypto.test.mjs test/chatops-approval.test.mjs test/chatops-policy.test.mjs test/chatops-file-safety.test.mjs test/chatops-outbound-queue.test.mjs test/chatops-commands.test.mjs test/chatops-bridge.test.mjs test/chatops-config-route.test.mjs test/chatops-apply.test.mjs test/chatops-ilink-contract.test.mjs test/chatops-fleet.test.mjs test/chatops-account.test.mjs test/chatops-auth.test.mjs test/chatops-fleet-scope.test.mjs test/chatops-handoff.test.mjs test/chatops-fleet-wiring.test.mjs test/chatops-fleet-live.test.mjs test/chatops-takeover.test.mjs test/chatops-device-signing.test.mjs test/chatops-relay-verify.test.mjs test/chatops-durability.test.mjs test/chatops-run-command.test.mjs test/secrets-guard.test.mjs test/chatops-ilink-fleet-bridge.test.mjs test/chatops-fleet-join.test.mjs",
     "pack": "node scripts/pack.mjs",
     "verify:join": "node scripts/verify-join.mjs",
     "lint": "eslint .",
@@ -139,7 +139,8 @@
     "test:council": "node --test --test-force-exit test/council.test.mjs",
     "test:layers": "node --test --test-force-exit test/layer-model.test.mjs",
     "test:log-bounds": "node --test --test-force-exit test/log-bounds.test.mjs",
-    "layer-check": "node scripts/layer-check.mjs"
+    "layer-check": "node scripts/layer-check.mjs",
+    "test:test-report": "node --test --test-force-exit test/test-report.test.mjs"
   },
   "keywords": [
     "dsh-bundle",

package/src/agent/test-report.mjs

@@ -0,0 +1,142 @@
+/**
+ * Reading `node --test`'s summary, without assuming its shape.
+ *
+ * ## Why this module exists, told plainly because it cost three rounds
+ *
+ * Several rounds of this project were spent believing a suite *failed on macOS*. It had not. The parser was
+ * looking for lines beginning `# tests 17`, and node v24 writes them beginning `ℹ tests 17`:
+ *
+ *     ℹ tests 17      not      # tests 17
+ *     ℹ pass 17                # pass 17
+ *     ℹ fail 0                 # fail 0
+ *
+ * **The `#` form was an assumption that was never checked.** It produced "UNREADABLE" for suites that had
+ * passed, and — worse — it produced a *wrong diagnosis*: because no `# fail` line could ever be found, and
+ * because no test *names* appeared either, the absence of both was read as "the process crashed before
+ * printing anything", which pointed at module scope and sent the investigation somewhere the fault was not.
+ * The actual fault was a regex.
+ *
+ * So the contract is written down here, parsed defensively, and tested against both forms. The one thing
+ * this module must never do is answer "unreadable" when the answer was merely "in a shape I did not expect".
+ *
+ * ## The two streams
+ *
+ * `node --test` writes its report to **stdout** on every version measured so far, and writes *diagnostics*
+ * to stderr. But "on every version measured so far" is exactly the kind of claim that ages badly, so the
+ * parser reads **both** streams and says which one it used. A caller that cannot tell which stream answered
+ * is a caller that will misread the next version change the same way.
+ */
+
+/** Summary labels, as node has spelled them. Both are accepted; neither is assumed. */
+export const LABELS = Object.freeze(['tests', 'pass', 'fail', 'skipped', 'cancelled', 'todo', 'duration_ms']);
+
+/** The prefixes node has used for summary lines. `ℹ` is what v24 writes; `#` is what earlier TAP-shaped output used. */
+export const PREFIXES = Object.freeze(['\u2139', '#']);
+
+/**
+ * Strip a summary prefix and return `{label, value}`, or `null`.
+ *
+ * Tolerant on purpose: leading whitespace is allowed (node indents nested summaries), and the prefix may be
+ * followed by a space or not. A strict pattern here is what caused the original fault, and a strict pattern
+ * is not made safer by being strict in a different way.
+ */
+export function parseSummaryLine(line) {
+  if (typeof line !== 'string') return null;
+  const trimmed = line.trim();
+  let body = null;
+  for (const prefix of PREFIXES) {
+    if (trimmed.startsWith(prefix)) {
+      body = trimmed.slice(prefix.length).trim();
+      break;
+    }
+  }
+  // A bare `tests 17` with no prefix is also accepted, because "no prefix" is a shape node has not used yet
+  // and refusing it would be the same mistake in a new costume.
+  if (body === null) body = trimmed;
+  const match = /^([a-z_]+)\s+(\d+(?:\.\d+)?)$/.exec(body);
+  if (match === null) return null;
+  const label = match[1];
+  if (!LABELS.includes(label)) return null;
+  return { label, value: Number(match[2]) };
+}
+
+/**
+ * Parse a full report.
+ *
+ * @param {string|{stdout?: string, stderr?: string}} input text, or the two streams separately
+ * @returns {{
+ *   ok: boolean, source: 'stdout'|'stderr'|'both'|'none', format: 'info'|'hash'|'bare'|'unknown',
+ *   tests: number|null, pass: number|null, fail: number|null, skipped: number|null,
+ *   detail: string
+ * }}
+ */
+export function parseTestReport(input) {
+  const stdout = typeof input === 'string' ? input : String(input?.stdout ?? '');
+  const stderr = typeof input === 'string' ? '' : String(input?.stderr ?? '');
+
+  const scan = (text) => {
+    const found = new Map();
+    let format = 'unknown';
+    for (const line of text.split('\n')) {
+      const parsed = parseSummaryLine(line);
+      if (parsed === null) continue;
+      // Record the shape that actually matched, so a future format change is reported rather than silently
+      // tolerated.
+      if (format === 'unknown') {
+        const trimmed = line.trim();
+        if (trimmed.startsWith('\u2139')) format = 'info';
+        else if (trimmed.startsWith('#')) format = 'hash';
+        else format = 'bare';
+      }
+      found.set(parsed.label, parsed.value);
+    }
+    return { found, format };
+  };
+
+  const out = scan(stdout);
+  const err = scan(stderr);
+  const fromStdout = out.found.size > 0;
+  const fromStderr = err.found.size > 0;
+  const source = fromStdout && fromStderr ? 'both' : fromStdout ? 'stdout' : fromStderr ? 'stderr' : 'none';
+  // stdout wins when both carry a summary, because that is where node has always put the report.
+  const chosen = fromStdout ? out : err;
+  const format = fromStdout ? out.format : fromStderr ? err.format : 'unknown';
+
+  if (!fromStdout && !fromStderr) {
+    return {
+      ok: false, source: 'none', format: 'unknown',
+      tests: null, pass: null, fail: null, skipped: null,
+      detail: 'no summary line found in either stream -- this is NOT the same as a failing suite, and the caller must not treat it as one',
+    };
+  }
+
+  const get = (label) => (chosen.found.has(label) ? chosen.found.get(label) : null);
+  const tests = get('tests');
+  const fail = get('fail');
+  return {
+    ok: true,
+    source,
+    format,
+    tests,
+    pass: get('pass'),
+    fail,
+    skipped: get('skipped'),
+    detail: tests === null
+      ? `read from ${source} (${format}) but no test count was present`
+      : `${tests} test(s), ${fail ?? '?'} failed, read from ${source} (${format})`,
+  };
+}
+
+/**
+ * Whether a report says the suite passed.
+ *
+ * **Three-valued on purpose.** `true`, `false`, and `null` for "the report could not be read" — because
+ * collapsing `null` into either boolean is exactly how an unread report becomes a pass or a phantom failure.
+ * The original bug turned unreadable reports into "failed", which is the safer of the two directions to be
+ * wrong in and was still wrong enough to waste rounds.
+ */
+export function verdict(report) {
+  if (report === null || report === undefined || report.ok !== true) return null;
+  if (report.fail === null) return null;
+  return report.fail === 0;
+}

package/src/plugin/tools.mjs

@@ -185,7 +185,7 @@ const MAX_STAGES = 16;
  * `package.json` during `scripts/pack.mjs` rather than hand-maintained, and `W2M_PLUGIN_VERSION`
  * overrides it at runtime for tests and packagers.
  */
-const PLUGIN_VERSION = '0.12.3';
+const PLUGIN_VERSION = '0.13.0';
 
 /** How long any single HTTP call may take before it is aborted, in milliseconds. */
 const DEFAULT_REQUEST_TIMEOUT_MS = 15_000;