@twin.org/dataspace-control-plane-service 0.9.1-next.8 → 0.9.1

package/README.md

@@ -2,7 +2,7 @@
 
 This package implements agreement negotiation and transfer process lifecycle management for control plane operations. It coordinates protocol-compliant state transitions and persists transfer state that can be consumed by downstream data plane components.
 
-Its behaviour follows the [Eclipse Dataspace Protocol](https://eclipse-dataspace-protocol-base.github.io/DataspaceProtocol/) and is designed for policy-aware transfer orchestration.
+Its behaviour follows the [Eclipse Dataspace Protocol](https://eclipse-dataspace-protocol-base.github.io/DataspaceProtocol/) and is designed for policy-aware transfer orchestration. For the architectural context see the [dataspace architecture documentation](https://github.com/iotaledger/twin-dataspace/blob/next/docs/architecture/dataspace.mdx).
 
 ## Installation
 

package/dist/es/dataspaceControlPlaneService.js

@@ -445,13 +445,14 @@ export class DataspaceControlPlaneService {
      * @param trustPayload Trust payload for authenticating this call.
      * @returns The consumerPid of the newly created TransferProcess.
      *
-     * **Engine configuration requirement:** The outbound call to the provider uses
+     * **Engine configuration requirement (remote transfers only):** when `providerEndpoint` is a
+     * remote origin the outbound call uses
      * `ComponentFactory.create(remoteControlPlaneComponentType, { endpoint, pathPrefix })`.
      * For the runtime `providerEndpoint` to be forwarded correctly, the engine **must** register
      * the component type (default: `dataspace-control-plane-rest-client`) as a
      * **multi-instance** component (`isMultiInstance: true` in engine config). A singleton
      * registration ignores the runtime `endpoint` arg and silently POSTs to its
-     * static endpoint instead.
+     * static endpoint instead. Local-origin (same-node) transfers run in-process and are unaffected.
      */
     async prepareTransfer(agreementId, providerEndpoint, format, trustPayload) {
         Guards.stringValue(DataspaceControlPlaneService.CLASS_NAME, "agreementId", agreementId);
@@ -514,9 +515,10 @@ export class DataspaceControlPlaneService {
         });
         // Generate outbound trust token to authenticate this node to the provider.
         const outboundToken = await this._trustComponent.generate(organizationIdentity, this._overrideTrustGeneratorType, { subject: { consumerPid, agreementId } });
-        // Create a remote REST client pointed at the provider endpoint and call requestTransfer.
-        const remoteControlPlane = ComponentFactory.create(this._remoteControlPlaneComponentType, { endpoint: providerEndpoint, pathPrefix: "" });
-        const result = await remoteControlPlane.requestTransfer(transferRequestMessage, outboundToken);
+        // Call the provider's requestTransfer. When providerEndpoint resolves to a local origin this
+        // runs in-process (no loopback HTTP, no multi-instance client required); otherwise it uses a
+        // remote REST client. Mirrors how state-change deliveries route via withControlPlaneComponent.
+        const result = await this.withControlPlaneComponent(providerEndpoint, async (component) => component.requestTransfer(transferRequestMessage, outboundToken));
         if (getJsonLdType(result) === DataspaceProtocolTransferProcessTypes.TransferError) {
             const transferError = result;
             throw new GeneralError(DataspaceControlPlaneService.CLASS_NAME, "transferRequestRejectedByProvider", {
@@ -1538,7 +1540,7 @@ export class DataspaceControlPlaneService {
                 datasetId: id,
                 tenantId: existing.tenantId ?? "",
                 catalogErrorCode: removeResult.code
-            });
+            }, BaseError.expand(removeResult.reason));
         }
         await this._dataspaceAppDatasetStorage.remove(id);
         await MetricHelper.metricIncrement(this._telemetryComponent, DataspaceControlPlaneMetricIds.AppDatasetsDeleted);
@@ -2348,18 +2350,15 @@ export class DataspaceControlPlaneService {
         const tenantContextIds = { ...contextIds, [ContextIdKeys.Tenant]: appDataset.tenantId };
         await ContextIdStore.run(tenantContextIds, async () => {
             const datasetPayload = this.restampDatasetId(appDataset.dataset, appDataset.id);
-            const rawDatasets = [datasetPayload];
-            const datasets = await Promise.all(rawDatasets.map(async (d) => this.populateDefaults(d)));
-            for (const dataset of datasets) {
-                const publishResult = await this._federatedCatalogueComponent.set(dataset, localTrustPayload);
-                if (isCatalogError(publishResult)) {
-                    throw new GeneralError(DataspaceControlPlaneService.CLASS_NAME, "datasetPublishFailed", {
-                        datasetId: appDataset.id,
-                        appId: appDataset.appId,
-                        tenantId: appDataset.tenantId ?? "",
-                        catalogErrorCode: publishResult.code
-                    });
-                }
+            const dataset = await this.populateDefaults(datasetPayload);
+            const publishResult = await this._federatedCatalogueComponent.set(dataset, localTrustPayload);
+            if (isCatalogError(publishResult)) {
+                throw new GeneralError(DataspaceControlPlaneService.CLASS_NAME, "datasetPublishFailed", {
+                    datasetId: appDataset.id,
+                    appId: appDataset.appId,
+                    tenantId: appDataset.tenantId ?? "",
+                    catalogErrorCode: publishResult.code
+                }, BaseError.expand(publishResult.reason));
             }
         });
     }