@tuturuuu/ui 0.33.0 → 0.34.0

package/src/components/ui/finance/invoices/export-dialog-content.tsx

@@ -1,9 +1,5 @@
 'use client';
 
-import {
-  listFinanceInvoices,
-  listPendingFinanceInvoices,
-} from '@tuturuuu/internal-api/finance';
 import { Button } from '@tuturuuu/ui/button';
 import {
   DialogClose,
@@ -28,182 +24,16 @@ import { useId, useState } from 'react';
 import { jsonToCSV } from 'react-papaparse';
 import { useWorkspaceConfig } from '../../../../hooks/use-workspace-config';
 import { XLSX } from '../../../../xlsx';
-
-/**
- * Shape of invoice data as exported to CSV/Excel
- * Flattened structure with complex objects decomposed into primitive fields
- */
-interface InvoiceExportRow {
-  // Common fields
-  id: string;
-  ws_id: string;
-  created_at: string;
-  notice?: string;
-  note?: string;
-  price?: number | string;
-  total_diff?: number | string;
-
-  // Flattened customer fields
-  customer_name?: string;
-  customer_avatar_url?: string;
-
-  // Flattened creator fields (created invoices only)
-  creator_name?: string;
-  creator_email?: string;
-  creator_id?: string;
-
-  // Flattened wallet fields (created invoices only)
-  wallet_name?: string;
-
-  // Pending invoice specific fields
-  user_id?: string;
-  user_name?: string;
-  user_avatar_url?: string;
-  group_id?: string;
-  group_name?: string;
-  months_owed?: string;
-  attendance_days?: number;
-  total_sessions?: number;
-  potential_total?: number | string;
-}
-
-type PendingInvoiceExportData = {
-  attendance_days: number;
-  group_id: string;
-  group_name: string;
-  months_owed: string;
-  potential_total: number;
-  total_sessions: number;
-  user_avatar_url: string;
-  user_id: string;
-  user_name: string;
-  customer: {
-    full_name: string;
-    avatar_url: string;
-  } | null;
-  creator: null;
-  wallet: null;
-};
-
-type CreatedInvoiceExportData = InvoiceExportRow & {
-  customer?: {
-    full_name?: string | null;
-    avatar_url?: string | null;
-  } | null;
-  creator?: {
-    display_name?: string | null;
-    full_name?: string | null;
-    email?: string | null;
-  } | null;
-  wallet?: {
-    name?: string | null;
-  } | null;
-};
-
-type PendingInvoiceApiRow = Omit<
-  PendingInvoiceExportData,
-  'creator' | 'customer' | 'group_id' | 'group_name' | 'months_owed' | 'wallet'
-> & {
-  group_id?: string | null;
-  group_ids?: string[] | null;
-  group_name?: string | null;
-  group_names?: string[] | null;
-  months_owed?: string | string[] | null;
-};
-
-function normalizeQueryArray(value?: string | string[]) {
-  if (!value) return [];
-  return (Array.isArray(value) ? value : [value]).filter(Boolean);
-}
-
-// Helper function to fetch pending invoices data for export
-async function getPendingInvoicesData(
-  wsId: string,
-  {
-    page = '1',
-    pageSize = '10',
-    q,
-    userIds,
-    groupByUser = false,
-  }: {
-    page?: string;
-    pageSize?: string;
-    q?: string;
-    userIds?: string | string[];
-    groupByUser?: boolean;
-  }
-): Promise<{ data: PendingInvoiceExportData[]; count: number }> {
-  const payload = await listPendingFinanceInvoices(wsId, {
-    groupByUser,
-    page,
-    pageSize,
-    q: q || '',
-    userIds: normalizeQueryArray(userIds),
-  });
-
-  const rawData = (payload.data || []) as PendingInvoiceApiRow[];
-  const totalCount = payload.count || 0;
-
-  const transformedData = rawData.map((invoice): PendingInvoiceExportData => {
-    const monthsOwed = Array.isArray(invoice.months_owed)
-      ? invoice.months_owed.join(', ')
-      : typeof invoice.months_owed === 'string'
-        ? invoice.months_owed
-        : '';
-
-    const baseInvoice = {
-      ...invoice,
-      attendance_days: invoice.attendance_days ?? 0,
-      months_owed: monthsOwed,
-      potential_total: invoice.potential_total ?? 0,
-      total_sessions: invoice.total_sessions ?? 0,
-      user_avatar_url: invoice.user_avatar_url || '',
-      user_id: invoice.user_id || '',
-      user_name: invoice.user_name || '',
-    };
-
-    if (groupByUser) {
-      const groupNames = Array.isArray(invoice.group_names)
-        ? invoice.group_names.filter(Boolean)
-        : [];
-      const groupedName = groupNames.join(', ');
-      const groupIdValue = Array.isArray(invoice.group_ids)
-        ? invoice.group_ids.join(',')
-        : '';
-
-      return {
-        ...baseInvoice,
-        group_id: groupIdValue,
-        group_name: groupedName,
-        customer: {
-          full_name: invoice.user_name || '',
-          avatar_url: invoice.user_avatar_url || '',
-        },
-        creator: null,
-        wallet: null,
-      };
-    }
-
-    return {
-      ...baseInvoice,
-      group_id: invoice.group_id || '',
-      group_name: invoice.group_name || '',
-      customer: invoice.user_id
-        ? {
-            full_name: invoice.user_name || '',
-            avatar_url: invoice.user_avatar_url || '',
-          }
-        : {
-            full_name: invoice.group_name || '',
-            avatar_url: '',
-          },
-      creator: null,
-      wallet: null,
-    };
-  });
-
-  return { data: transformedData, count: totalCount };
-}
+import {
+  type CreatedInvoiceExportData,
+  getData,
+  getPendingInvoicesData,
+  type InvoiceExportRow,
+} from './export-data';
+import {
+  collectInvoiceExport,
+  IncompleteInvoiceExportError,
+} from './export-pagination';
 
 export default function ExportDialogContent({
   wsId,
@@ -236,12 +66,16 @@ export default function ExportDialogContent({
   const filenameId = useId();
   const fileTypeId = useId();
 
-  const { data: groupByUserConfig, isLoading: groupingLoading } =
-    useWorkspaceConfig<string>(
-      wsId,
-      'INVOICE_GROUP_PENDING_INVOICES_BY_USER',
-      'false'
-    );
+  const {
+    data: groupByUserConfig,
+    isLoading: groupingLoading,
+    isError: groupingError,
+    refetch: retryGrouping,
+  } = useWorkspaceConfig<string>(
+    wsId,
+    'INVOICE_GROUP_PENDING_INVOICES_BY_USER',
+    'false'
+  );
 
   const groupByUser = groupByUserConfig === 'true';
 
@@ -279,73 +113,73 @@ export default function ExportDialogContent({
   };
 
   const handleExport = async () => {
+    if (
+      isExporting ||
+      (invoiceType === 'pending' && (groupingLoading || groupingError))
+    )
+      return;
     setIsExporting(true);
     setProgress(0);
     setExportError(null);
 
-    const allData: InvoiceExportRow[] = [];
-    let currentPage = 1;
-    const pageSize = 1000;
-
     try {
-      while (true) {
-        const { data, count } =
-          invoiceType === 'pending'
-            ? await getPendingInvoicesData(wsId, {
-                page: currentPage.toString(),
-                pageSize: pageSize.toString(),
-                q: searchParams.q,
-                userIds: searchParams.userIds,
-                groupByUser,
-              })
-            : await getData(wsId, {
-                q: searchParams.q,
-                page: currentPage.toString(),
-                pageSize: pageSize.toString(),
-                userIds: searchParams.userIds,
-                walletId: searchParams.walletId,
-                walletIds: searchParams.walletIds,
-                start: searchParams.start,
-                end: searchParams.end,
-              });
-
-        const flattenedData: InvoiceExportRow[] = data.map((invoice) => {
-          // Destructure out complex objects to prevent [object Object] in exports
-          const { customer, creator, wallet, ...rest } =
-            invoice as CreatedInvoiceExportData;
-
-          // Only include creator & wallet fields for created invoices
-          if (invoiceType === 'created') {
-            return {
-              ...rest,
-              customer_name: customer?.full_name || '',
-              customer_avatar_url: customer?.avatar_url || '',
-              creator_name:
-                creator?.display_name ||
-                creator?.full_name ||
-                creator?.email ||
-                '',
-              creator_email: creator?.email || '',
-              wallet_name: wallet?.name || '',
-            } as InvoiceExportRow;
-          }
-
-          // For pending invoices, just return rest (user_name & user_avatar_url already included)
-          return rest as unknown as InvoiceExportRow;
-        });
-
-        allData.push(...flattenedData);
-
-        const totalPages = Math.max(1, Math.ceil(count / pageSize));
-        const progressValue = (currentPage / totalPages) * 100;
-        setProgress(progressValue);
-
-        if (data.length < pageSize) {
-          break;
+      const data = await collectInvoiceExport<CreatedInvoiceExportData>({
+        onProgress: setProgress,
+        getKey: (row) => {
+          if (invoiceType === 'created') return row.id;
+          if (!row.user_id || (!groupByUser && !row.group_id)) return '';
+          return groupByUser
+            ? row.user_id
+            : JSON.stringify([row.user_id, row.group_id]);
+        },
+        fetchPage: async (currentPage, pageSize) => {
+          const result =
+            invoiceType === 'pending'
+              ? await getPendingInvoicesData(wsId, {
+                  page: currentPage.toString(),
+                  pageSize: pageSize.toString(),
+                  q: searchParams.q,
+                  userIds: searchParams.userIds,
+                  groupByUser,
+                })
+              : await getData(wsId, {
+                  q: searchParams.q,
+                  page: currentPage.toString(),
+                  pageSize: pageSize.toString(),
+                  userIds: searchParams.userIds,
+                  walletId: searchParams.walletId,
+                  walletIds: searchParams.walletIds,
+                  start: searchParams.start,
+                  end: searchParams.end,
+                });
+
+          return result as { data: CreatedInvoiceExportData[]; count: number };
+        },
+      });
+      const allData: InvoiceExportRow[] = data.map((invoice) => {
+        // Destructure out complex objects to prevent [object Object] in exports
+        const { customer, creator, wallet, ...rest } =
+          invoice as CreatedInvoiceExportData;
+
+        // Only include creator & wallet fields for created invoices
+        if (invoiceType === 'created') {
+          return {
+            ...rest,
+            customer_name: customer?.full_name || '',
+            customer_avatar_url: customer?.avatar_url || '',
+            creator_name:
+              creator?.display_name ||
+              creator?.full_name ||
+              creator?.email ||
+              '',
+            creator_email: creator?.email || '',
+            wallet_name: wallet?.name || '',
+          } as InvoiceExportRow;
         }
 
-        currentPage++;
-      }
+        // For pending invoices, just return rest (user_name & user_avatar_url already included)
+        return rest as unknown as InvoiceExportRow;
+      });
 
       setProgress(100);
 
@@ -362,8 +196,12 @@ export default function ExportDialogContent({
       }
 
       toast.success(t('common.export-success'));
-    } catch {
-      const errorMessage = t('common.export-error');
+    } catch (error) {
+      const errorMessage = t(
+        error instanceof IncompleteInvoiceExportError
+          ? 'ws-invoices.export_incomplete'
+          : 'common.export-error'
+      );
       setExportError(errorMessage);
       toast.error(errorMessage);
     } finally {
@@ -390,6 +228,19 @@ export default function ExportDialogContent({
       </DialogHeader>
 
       <div className="grid gap-1">
+        {invoiceType === 'pending' && (
+          <p className="text-muted-foreground text-sm">
+            {t('ws-invoices.export_pending_scope')}
+          </p>
+        )}
+        {invoiceType === 'pending' && groupingError && (
+          <div role="alert">
+            <p>{t('ws-invoices.error_loading')}</p>
+            <Button variant="outline" onClick={() => retryGrouping()}>
+              {t('common.retry')}
+            </Button>
+          </div>
+        )}
         <div className="grid w-full max-w-sm items-center gap-2">
           <Label htmlFor={filenameId}>{t('common.file-name')}</Label>
           <Input
@@ -427,7 +278,10 @@ export default function ExportDialogContent({
         )}
 
         {exportError && (
-          <div className="mt-2 rounded-md bg-destructive/10 p-3 text-destructive text-sm">
+          <div
+            role="alert"
+            className="mt-2 rounded-md bg-destructive/10 p-3 text-destructive text-sm"
+          >
             {exportError}
           </div>
         )}
@@ -435,13 +289,16 @@ export default function ExportDialogContent({
 
       <DialogFooter className="justify-between">
         <DialogClose asChild>
-          <Button type="button" variant="secondary">
+          <Button type="button" variant="secondary" disabled={isExporting}>
             {t('common.cancel')}
           </Button>
         </DialogClose>
         <Button
           onClick={handleExport}
-          disabled={isExporting || groupingLoading}
+          disabled={
+            isExporting ||
+            (invoiceType === 'pending' && (groupingLoading || groupingError))
+          }
         >
           {isExporting ? t('common.loading') : t('common.export')}
         </Button>
@@ -449,44 +306,3 @@ export default function ExportDialogContent({
     </>
   );
 }
-
-async function getData(
-  wsId: string,
-  {
-    q,
-    page = '1',
-    pageSize = '10',
-    start,
-    end,
-    userIds,
-    walletId,
-    walletIds,
-  }: {
-    q?: string;
-    page?: string;
-    pageSize?: string;
-    start?: string;
-    end?: string;
-    userIds?: string | string[];
-    walletId?: string;
-    walletIds?: string | string[];
-  }
-) {
-  const walletFilterIds = [
-    ...(walletId ? [walletId] : []),
-    ...normalizeQueryArray(walletIds),
-  ];
-
-  return (await listFinanceInvoices(wsId, {
-    end,
-    page,
-    pageSize,
-    q,
-    start,
-    userIds: normalizeQueryArray(userIds),
-    walletIds: walletFilterIds,
-  })) as {
-    data: CreatedInvoiceExportData[];
-    count: number;
-  };
-}

package/src/components/ui/finance/invoices/export-pagination.test.ts

@@ -0,0 +1,131 @@
+import { describe, expect, it, vi } from 'vitest';
+import {
+  collectInvoiceExport,
+  IncompleteInvoiceExportError,
+} from './export-pagination';
+
+const getKey = (row: { id: string }) => row.id;
+const rows = (n: number) =>
+  Array.from({ length: n }, (_, i) => ({
+    id: `invoice-${i}`,
+    group: `class-${i % 7}`,
+  }));
+
+describe('complete invoice exports', () => {
+  it.each([0, 1, 999, 1000, 1001, 2000, 2507])(
+    'preserves every row and class for %i invoices',
+    async (count) => {
+      const data = rows(count);
+      const fetchPage = vi.fn(async (page: number, pageSize: number) => ({
+        count,
+        data: data.slice((page - 1) * pageSize, page * pageSize),
+      }));
+      const progress = vi.fn();
+      const actual = await collectInvoiceExport({
+        fetchPage,
+        getKey,
+        onProgress: progress,
+      });
+      expect(actual).toEqual(data);
+      expect(new Set(actual.map((row) => row.group))).toEqual(
+        new Set(data.map((row) => row.group))
+      );
+      expect(fetchPage).toHaveBeenCalledTimes(
+        Math.max(1, Math.ceil(count / 1000))
+      );
+      expect(progress).toHaveBeenLastCalledWith(100);
+      expect(
+        progress.mock.calls.every(([value]) => value >= 0 && value <= 100)
+      ).toBe(true);
+    }
+  );
+
+  it('keeps one student in multiple classes as distinct debt rows', async () => {
+    const data = [
+      { user: 'student', group: 'class-a' },
+      { user: 'student', group: 'class-b' },
+    ];
+    expect(
+      await collectInvoiceExport({
+        fetchPage: async () => ({ count: 2, data }),
+        getKey: (row) => JSON.stringify([row.user, row.group]),
+      })
+    ).toEqual(data);
+  });
+
+  it.each([
+    {
+      name: 'a truncated first page',
+      pages: [{ count: 1500, data: rows(100) }],
+    },
+    { name: 'an empty first page with debt', pages: [{ count: 20, data: [] }] },
+    {
+      name: 'an empty later page',
+      pages: [
+        { count: 1001, data: rows(1000) },
+        { count: 1001, data: [] },
+      ],
+    },
+    {
+      name: 'a shrinking dataset',
+      pages: [
+        { count: 1001, data: rows(1000) },
+        { count: 1000, data: [] },
+      ],
+    },
+    {
+      name: 'a growing dataset',
+      pages: [
+        { count: 1001, data: rows(1000) },
+        { count: 1002, data: rows(2) },
+      ],
+    },
+    {
+      name: 'duplicate page boundaries',
+      pages: [
+        { count: 1001, data: rows(1000) },
+        { count: 1001, data: [{ id: 'invoice-999' }] },
+      ],
+    },
+    {
+      name: 'duplicate rows within a page',
+      pages: [{ count: 2, data: [{ id: 'same' }, { id: 'same' }] }],
+    },
+    { name: 'rows beyond the count', pages: [{ count: 0, data: rows(1) }] },
+    { name: 'missing identities', pages: [{ count: 1, data: [{ id: '' }] }] },
+    { name: 'a missing count', pages: [{ data: [] }] },
+    { name: 'a missing row array', pages: [{ count: 0 }] },
+    { name: 'a negative count', pages: [{ count: -1, data: [] }] },
+    { name: 'a fractional count', pages: [{ count: 0.5, data: [] }] },
+    { name: 'an infinite count', pages: [{ count: Infinity, data: [] }] },
+  ])('rejects $name instead of producing a partial file', async ({ pages }) => {
+    const fetchPage = vi.fn(
+      async () => pages.shift() as { count: number; data: { id: string }[] }
+    );
+    await expect(
+      collectInvoiceExport({ fetchPage, getKey })
+    ).rejects.toBeInstanceOf(IncompleteInvoiceExportError);
+  });
+
+  it('propagates later request failures without returning partial rows', async () => {
+    const error = new Error('Request timed out');
+    const fetchPage = vi
+      .fn()
+      .mockResolvedValueOnce({ count: 1001, data: rows(1000) })
+      .mockRejectedValueOnce(error);
+    await expect(collectInvoiceExport({ fetchPage, getKey })).rejects.toBe(
+      error
+    );
+  });
+
+  it.each([0, -1, 1.5, Infinity])(
+    'rejects invalid page size %s',
+    async (pageSize) => {
+      const fetchPage = vi.fn();
+      await expect(
+        collectInvoiceExport({ fetchPage, getKey, pageSize })
+      ).rejects.toThrow(RangeError);
+      expect(fetchPage).not.toHaveBeenCalled();
+    }
+  );
+});

package/src/components/ui/finance/invoices/export-pagination.ts

@@ -0,0 +1,66 @@
+export class IncompleteInvoiceExportError extends Error {
+  constructor() {
+    super(
+      'Invoice export changed or returned incomplete data. Retry the export.'
+    );
+    this.name = 'IncompleteInvoiceExportError';
+  }
+}
+
+/** Never turn truncated, overlapping, or changing pages into a successful file. */
+export async function collectInvoiceExport<T>({
+  fetchPage,
+  getKey,
+  onProgress,
+  pageSize = 1000,
+}: {
+  fetchPage: (
+    page: number,
+    pageSize: number
+  ) => Promise<{
+    data: T[];
+    count: number;
+  }>;
+  getKey: (row: T) => string;
+  onProgress?: (progress: number) => void;
+  pageSize?: number;
+}): Promise<T[]> {
+  if (!Number.isSafeInteger(pageSize) || pageSize < 1) {
+    throw new RangeError('Invalid export page size');
+  }
+
+  const rows: T[] = [];
+  const keys = new Set<string>();
+  let expectedCount: number | undefined;
+
+  for (let page = 1; ; page++) {
+    const result = await fetchPage(page, pageSize);
+    if (
+      !result ||
+      !Array.isArray(result.data) ||
+      !Number.isSafeInteger(result.count) ||
+      result.count < 0 ||
+      (expectedCount !== undefined && result.count !== expectedCount)
+    ) {
+      throw new IncompleteInvoiceExportError();
+    }
+    expectedCount = result.count;
+
+    const expectedLength = Math.min(pageSize, expectedCount - rows.length);
+    if (result.data.length !== expectedLength) {
+      throw new IncompleteInvoiceExportError();
+    }
+
+    for (const row of result.data) {
+      const key = getKey(row);
+      if (!key || keys.has(key)) throw new IncompleteInvoiceExportError();
+      keys.add(key);
+      rows.push(row);
+    }
+
+    onProgress?.(
+      expectedCount === 0 ? 100 : (rows.length / expectedCount) * 100
+    );
+    if (rows.length === expectedCount) return rows;
+  }
+}