@tunghtml/strapi-plugin-filtered-relation 1.1.1 → 1.1.3

package/CHANGELOG.md

@@ -1,5 +1,45 @@
 # Changelog
 
+## [1.1.3] - 2024-12-02
+
+### Changed
+
+- **Package cleanup**: Added `files` field to package.json to only publish necessary files
+  - Removed unnecessary files from npm package (push-to-github.sh, PUBLISH.md, etc.)
+  - Reduces package size and keeps it clean
+  - Only includes: admin/, server/, strapi-admin.js, strapi-server.js, README.md, CHANGELOG.md
+
+## [1.1.2] - 2024-12-02
+
+### Fixed
+
+- **Critical Bug - Data Loss Prevention**: Fixed critical bug where disconnect operation happened before validating target record existence
+  - Previously: Disconnected investor first, then checked if target exists → data loss if target missing
+  - Now: Validates ALL conditions first (target exists, data valid), then performs disconnect/connect
+  - Prevents "Investor not found in current record" error on subsequent operations
+  - Users can now safely perform multiple status changes without page refresh
+- **Improved Error Notifications**: Changed error notification type from "warning" to "danger"
+  - Makes errors more visible and distinguishable from warnings
+  - Helps users quickly identify critical issues that need attention
+
+### Changed
+
+- Reordered `handleStatusChange` logic flow:
+  1. Get current record data
+  2. Find investor to move
+  3. **Validate target record exists** (NEW - moved before disconnect)
+  4. **Validate target data is valid** (NEW)
+  5. Disconnect from current record (only after validation passes)
+  6. Connect to target record
+  7. Refresh UI
+- All error notifications now use `type: "danger"` instead of `type: "warning"`
+
+### Technical Details
+
+- Added validation check for target record data integrity before any mutations
+- Prevents partial state updates that could leave data in inconsistent state
+- Follows transaction-like pattern: validate everything, then commit changes
+
 ## [1.1.1] - 2024-12-02
 
 ### Fixed

package/admin/src/components/FilteredRelationInput.jsx

@@ -172,35 +172,14 @@ const FilteredRelationInput = (props) => {
           "[FilteredRelation] Investor not found in current record"
         );
         toggleNotification({
-          type: "warning",
+          type: "danger",
           message:
             "Investor not found in current record. Please refresh the page.",
         });
         return;
       }
 
-      // Build full payload like UI admin does
-      const updatePayload = {
-        documentId: currentData.documentId,
-        [displayField]: {
-          connect: [],
-          disconnect: [
-            {
-              id: investorToRemove.id,
-              documentId: investorToRemove.documentId,
-            },
-          ],
-        },
-        participantStatus: currentData.participantStatus,
-      };
-
-      // Use disconnect with full payload
-      const removeResponse = await put(
-        `/content-manager/collection-types/${targetModel}/${itemId}`,
-        updatePayload
-      );
-
-      // Step 3: Find Meeting Participation Status with new status (same meeting)
+      // Step 3: VALIDATE target record EXISTS BEFORE disconnecting (critical fix)
       const newFilterParams = {};
       if (filterField1) {
         newFilterParams[filterField1] = newStatus;
@@ -229,16 +208,13 @@ const FilteredRelationInput = (props) => {
         searchResponse?.data ||
         [];
 
-      let targetRecordId;
-      let targetInvestors = [];
-
       if (targetRecords.length === 0) {
         console.error(
           "[FilteredRelation] No target record found with new status for this meeting."
         );
         const collectionDisplayName = targetModelInput || "record";
         toggleNotification({
-          type: "warning",
+          type: "danger",
           message: `No ${collectionDisplayName} found with status "${newStatus}" for this meeting. Please create one first.`,
         });
         return;
@@ -246,14 +222,44 @@ const FilteredRelationInput = (props) => {
 
       // Get full target record data
       const targetRecord = targetRecords[0];
-      targetRecordId = targetRecord.documentId || targetRecord.id;
+      const targetRecordId = targetRecord.documentId || targetRecord.id;
 
       // Get target record with all fields
       const targetRecordUrl = `/content-manager/collection-types/${targetModel}/${targetRecordId}?populate=*`;
       const targetRecordFull = await get(targetRecordUrl);
       const targetData = targetRecordFull?.data?.data || {};
 
-      // Step 4: Add investor to target record
+      if (!targetData || !targetData.documentId) {
+        console.error("[FilteredRelation] Target record data is invalid");
+        toggleNotification({
+          type: "danger",
+          message: "Target record not found. Please refresh and try again.",
+        });
+        return;
+      }
+
+      // Step 4: NOW disconnect from current record (after validation passed)
+      const updatePayload = {
+        documentId: currentData.documentId,
+        [displayField]: {
+          connect: [],
+          disconnect: [
+            {
+              id: investorToRemove.id,
+              documentId: investorToRemove.documentId,
+            },
+          ],
+        },
+        participantStatus: currentData.participantStatus,
+      };
+
+      // Use disconnect with full payload
+      const removeResponse = await put(
+        `/content-manager/collection-types/${targetModel}/${itemId}`,
+        updatePayload
+      );
+
+      // Step 5: Add investor to target record
       // Build full payload like UI admin does
       const addPayload = {
         documentId: targetData.documentId,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tunghtml/strapi-plugin-filtered-relation",
-  "version": "1.1.1",
+  "version": "1.1.3",
   "description": "A Strapi custom field plugin for displaying filtered relations with dynamic placeholder support and status change capability",
   "keywords": [
     "strapi",
@@ -10,6 +10,14 @@
     "filter",
     "strapi5"
   ],
+  "files": [
+    "admin",
+    "server",
+    "strapi-admin.js",
+    "strapi-server.js",
+    "README.md",
+    "CHANGELOG.md"
+  ],
   "strapi": {
     "name": "filtered-relation",
     "displayName": "Filtered Relation",

package/PUBLISH.md

@@ -1,94 +0,0 @@
-# Publishing Guide
-
-## Prerequisites
-
-1. Make sure you're logged in to npm:
-
-```bash
-npm login
-```
-
-2. Verify your npm account has access to publish `@tunghtml` scoped packages
-
-## Steps to Publish
-
-### 1. Test Locally First
-
-The plugin is already configured as a local plugin in `backend/config/plugins.js`:
-
-```javascript
-"filtered-relation": {
-  enabled: true,
-  resolve: "./src/plugins/filtered-relation",
-}
-```
-
-Test thoroughly in your local Strapi instance before publishing.
-
-### 2. Update Version
-
-Update version in `package.json`:
-
-- Patch: 1.1.0 -> 1.1.1 (bug fixes)
-- Minor: 1.1.0 -> 1.2.0 (new features, backward compatible)
-- Major: 1.1.0 -> 2.0.0 (breaking changes)
-
-### 3. Publish to NPM
-
-From the plugin directory:
-
-```bash
-cd backend/src/plugins/filtered-relation
-npm publish --access public
-```
-
-### 4. Update Project to Use NPM Package
-
-After publishing, you can switch back to using the npm package:
-
-1. Update `backend/package.json`:
-
-```json
-{
-  "dependencies": {
-    "@tunghtml/strapi-plugin-filtered-relation": "^1.1.0"
-  }
-}
-```
-
-2. Update `backend/config/plugins.js`:
-
-```javascript
-"filtered-relation": {
-  enabled: true,
-  // Remove the resolve line to use npm package
-}
-```
-
-3. Install the package:
-
-```bash
-cd backend
-yarn install
-```
-
-## Current Version
-
-Version 1.1.0 includes:
-
-- Status change dropdown feature
-- Dynamic status options from schema
-- Auto-refresh on status change
-- Backward compatible with 1.0.0
-
-## Testing Checklist
-
-Before publishing, verify:
-
-- [ ] Plugin loads without errors
-- [ ] Filtered relations display correctly
-- [ ] Status dropdown shows correct options
-- [ ] Status change updates the record
-- [ ] Lists refresh automatically after status change
-- [ ] Works with different content types (reusable)
-- [ ] No console errors

package/push-to-github.sh

@@ -1,52 +0,0 @@
-#!/bin/bash
-
-# Script to push plugin to GitHub
-# Usage: ./push-to-github.sh
-
-set -e
-
-echo "🚀 Pushing strapi-plugin-filtered-relation to GitHub..."
-
-# Check if we're in the right directory
-if [ ! -f "package.json" ]; then
-    echo "❌ Error: package.json not found. Are you in the plugin directory?"
-    exit 1
-fi
-
-# Check if git is initialized
-if [ ! -d ".git" ]; then
-    echo "📦 Initializing git repository..."
-    git init
-    git remote add origin https://github.com/finnwasabi/strapi-plugin-filtered-relation.git
-fi
-
-# Add all files
-echo "📝 Adding files..."
-git add .
-
-# Commit
-echo "💾 Committing changes..."
-git commit -m "Release v1.1.0 - Add status change dropdown feature
-
-- Add status change dropdown at end of each item
-- Dynamically fetch enum options from target model schema
-- Move items between records using connect/disconnect API
-- Dispatch custom events to refresh all fields without page reload
-- Remove all console.log statements
-- Update README with detailed options table and descriptions
-- Update CHANGELOG with technical details
-- Fully dynamic and reusable for any use case"
-
-# Tag the release
-echo "🏷️  Creating tag v1.1.0..."
-git tag -a v1.1.0 -m "Version 1.1.0"
-
-# Push to GitHub
-echo "⬆️  Pushing to GitHub..."
-git push origin main
-git push origin v1.1.0
-
-echo "✅ Successfully pushed to GitHub!"
-echo "📦 Package: @tunghtml/strapi-plugin-filtered-relation@1.1.0"
-echo "🔗 GitHub: https://github.com/finnwasabi/strapi-plugin-filtered-relation"
-echo "🔗 NPM: https://www.npmjs.com/package/@tunghtml/strapi-plugin-filtered-relation"