@tunghtml/strapi-plugin-filtered-relation 1.1.1 → 1.1.2

package/CHANGELOG.md

@@ -1,5 +1,36 @@
 # Changelog
 
+## [1.1.2] - 2024-12-02
+
+### Fixed
+
+- **Critical Bug - Data Loss Prevention**: Fixed critical bug where disconnect operation happened before validating target record existence
+  - Previously: Disconnected investor first, then checked if target exists → data loss if target missing
+  - Now: Validates ALL conditions first (target exists, data valid), then performs disconnect/connect
+  - Prevents "Investor not found in current record" error on subsequent operations
+  - Users can now safely perform multiple status changes without page refresh
+- **Improved Error Notifications**: Changed error notification type from "warning" to "danger"
+  - Makes errors more visible and distinguishable from warnings
+  - Helps users quickly identify critical issues that need attention
+
+### Changed
+
+- Reordered `handleStatusChange` logic flow:
+  1. Get current record data
+  2. Find investor to move
+  3. **Validate target record exists** (NEW - moved before disconnect)
+  4. **Validate target data is valid** (NEW)
+  5. Disconnect from current record (only after validation passes)
+  6. Connect to target record
+  7. Refresh UI
+- All error notifications now use `type: "danger"` instead of `type: "warning"`
+
+### Technical Details
+
+- Added validation check for target record data integrity before any mutations
+- Prevents partial state updates that could leave data in inconsistent state
+- Follows transaction-like pattern: validate everything, then commit changes
+
 ## [1.1.1] - 2024-12-02
 
 ### Fixed

package/admin/src/components/FilteredRelationInput.jsx

@@ -172,35 +172,14 @@ const FilteredRelationInput = (props) => {
           "[FilteredRelation] Investor not found in current record"
         );
         toggleNotification({
-          type: "warning",
+          type: "danger",
           message:
             "Investor not found in current record. Please refresh the page.",
         });
         return;
       }
 
-      // Build full payload like UI admin does
-      const updatePayload = {
-        documentId: currentData.documentId,
-        [displayField]: {
-          connect: [],
-          disconnect: [
-            {
-              id: investorToRemove.id,
-              documentId: investorToRemove.documentId,
-            },
-          ],
-        },
-        participantStatus: currentData.participantStatus,
-      };
-
-      // Use disconnect with full payload
-      const removeResponse = await put(
-        `/content-manager/collection-types/${targetModel}/${itemId}`,
-        updatePayload
-      );
-
-      // Step 3: Find Meeting Participation Status with new status (same meeting)
+      // Step 3: VALIDATE target record EXISTS BEFORE disconnecting (critical fix)
       const newFilterParams = {};
       if (filterField1) {
         newFilterParams[filterField1] = newStatus;
@@ -229,16 +208,13 @@ const FilteredRelationInput = (props) => {
         searchResponse?.data ||
         [];
 
-      let targetRecordId;
-      let targetInvestors = [];
-
       if (targetRecords.length === 0) {
         console.error(
           "[FilteredRelation] No target record found with new status for this meeting."
         );
         const collectionDisplayName = targetModelInput || "record";
         toggleNotification({
-          type: "warning",
+          type: "danger",
           message: `No ${collectionDisplayName} found with status "${newStatus}" for this meeting. Please create one first.`,
         });
         return;
@@ -246,14 +222,44 @@ const FilteredRelationInput = (props) => {
 
       // Get full target record data
       const targetRecord = targetRecords[0];
-      targetRecordId = targetRecord.documentId || targetRecord.id;
+      const targetRecordId = targetRecord.documentId || targetRecord.id;
 
       // Get target record with all fields
       const targetRecordUrl = `/content-manager/collection-types/${targetModel}/${targetRecordId}?populate=*`;
       const targetRecordFull = await get(targetRecordUrl);
       const targetData = targetRecordFull?.data?.data || {};
 
-      // Step 4: Add investor to target record
+      if (!targetData || !targetData.documentId) {
+        console.error("[FilteredRelation] Target record data is invalid");
+        toggleNotification({
+          type: "danger",
+          message: "Target record not found. Please refresh and try again.",
+        });
+        return;
+      }
+
+      // Step 4: NOW disconnect from current record (after validation passed)
+      const updatePayload = {
+        documentId: currentData.documentId,
+        [displayField]: {
+          connect: [],
+          disconnect: [
+            {
+              id: investorToRemove.id,
+              documentId: investorToRemove.documentId,
+            },
+          ],
+        },
+        participantStatus: currentData.participantStatus,
+      };
+
+      // Use disconnect with full payload
+      const removeResponse = await put(
+        `/content-manager/collection-types/${targetModel}/${itemId}`,
+        updatePayload
+      );
+
+      // Step 5: Add investor to target record
       // Build full payload like UI admin does
       const addPayload = {
         documentId: targetData.documentId,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tunghtml/strapi-plugin-filtered-relation",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "description": "A Strapi custom field plugin for displaying filtered relations with dynamic placeholder support and status change capability",
   "keywords": [
     "strapi",