@tunghtml/strapi-plugin-filtered-relation 1.1.0 → 1.1.2

package/CHANGELOG.md

@@ -1,5 +1,55 @@
 # Changelog
 
+## [1.1.2] - 2024-12-02
+
+### Fixed
+
+- **Critical Bug - Data Loss Prevention**: Fixed critical bug where disconnect operation happened before validating target record existence
+  - Previously: Disconnected investor first, then checked if target exists → data loss if target missing
+  - Now: Validates ALL conditions first (target exists, data valid), then performs disconnect/connect
+  - Prevents "Investor not found in current record" error on subsequent operations
+  - Users can now safely perform multiple status changes without page refresh
+- **Improved Error Notifications**: Changed error notification type from "warning" to "danger"
+  - Makes errors more visible and distinguishable from warnings
+  - Helps users quickly identify critical issues that need attention
+
+### Changed
+
+- Reordered `handleStatusChange` logic flow:
+  1. Get current record data
+  2. Find investor to move
+  3. **Validate target record exists** (NEW - moved before disconnect)
+  4. **Validate target data is valid** (NEW)
+  5. Disconnect from current record (only after validation passes)
+  6. Connect to target record
+  7. Refresh UI
+- All error notifications now use `type: "danger"` instead of `type: "warning"`
+
+### Technical Details
+
+- Added validation check for target record data integrity before any mutations
+- Prevents partial state updates that could leave data in inconsistent state
+- Follows transaction-like pattern: validate everything, then commit changes
+
+## [1.1.1] - 2024-12-02
+
+### Fixed
+
+- **State Refresh Issue**: Fixed "Investor not found in current record" error that occurred after status changes
+  - Now refreshes local state immediately after disconnect/connect operations
+  - Prevents stale data issues when performing multiple status changes without page reload
+  - Reordered refresh logic: local field first, then dispatch event to other fields
+- **User Experience**: Replaced browser `alert()` with Strapi's native notification system
+  - Success notifications for successful status changes
+  - Warning notifications for missing records or data issues
+  - Danger notifications for errors
+  - All notifications use `useNotification` hook from `@strapi/strapi/admin`
+
+### Changed
+
+- Improved notification messages to be more user-friendly
+- Enhanced error handling with proper notification types
+
 ## [1.1.0] - 2024-12-02
 
 ### Added

package/admin/src/components/FilteredRelationInput.jsx

@@ -8,12 +8,13 @@ import {
   SingleSelect,
   SingleSelectOption,
 } from "@strapi/design-system";
-import { useFetchClient } from "@strapi/strapi/admin";
+import { useFetchClient, useNotification } from "@strapi/strapi/admin";
 import { useLocation, useNavigate } from "react-router-dom";
 
 const FilteredRelationInput = (props) => {
   const { formatMessage } = useIntl();
   const { get, put } = useFetchClient();
+  const { toggleNotification } = useNotification();
   const location = useLocation();
   const navigate = useNavigate();
   const [items, setItems] = React.useState([]);
@@ -96,7 +97,7 @@ const FilteredRelationInput = (props) => {
           data: {
             [name]: newValue,
           },
-        },
+        }
       );
     } catch (err) {
       console.error("Error auto-saving filtered relation:", err);
@@ -116,7 +117,7 @@ const FilteredRelationInput = (props) => {
         // Try 1: Get from content-type-builder (most reliable for schema)
         try {
           const builderResponse = await get(
-            `/content-type-builder/content-types/${targetModel}`,
+            `/content-type-builder/content-types/${targetModel}`
           );
           const builderSchema = builderResponse?.data?.data?.schema;
           enumValues = builderSchema?.attributes?.[statusField]?.enum;
@@ -168,34 +169,17 @@ const FilteredRelationInput = (props) => {
 
       if (!investorToRemove) {
         console.error(
-          "[FilteredRelation] Investor not found in current record",
+          "[FilteredRelation] Investor not found in current record"
         );
-        alert("Investor not found in current record");
+        toggleNotification({
+          type: "danger",
+          message:
+            "Investor not found in current record. Please refresh the page.",
+        });
         return;
       }
 
-      // Build full payload like UI admin does
-      const updatePayload = {
-        documentId: currentData.documentId,
-        [displayField]: {
-          connect: [],
-          disconnect: [
-            {
-              id: investorToRemove.id,
-              documentId: investorToRemove.documentId,
-            },
-          ],
-        },
-        participantStatus: currentData.participantStatus,
-      };
-
-      // Use disconnect with full payload
-      const removeResponse = await put(
-        `/content-manager/collection-types/${targetModel}/${itemId}`,
-        updatePayload,
-      );
-
-      // Step 3: Find Meeting Participation Status with new status (same meeting)
+      // Step 3: VALIDATE target record EXISTS BEFORE disconnecting (critical fix)
       const newFilterParams = {};
       if (filterField1) {
         newFilterParams[filterField1] = newStatus;
@@ -224,30 +208,58 @@ const FilteredRelationInput = (props) => {
         searchResponse?.data ||
         [];
 
-      let targetRecordId;
-      let targetInvestors = [];
-
       if (targetRecords.length === 0) {
         console.error(
-          "[FilteredRelation] No target record found with new status for this meeting.",
+          "[FilteredRelation] No target record found with new status for this meeting."
         );
         const collectionDisplayName = targetModelInput || "record";
-        alert(
-          `No ${collectionDisplayName} found with status "${newStatus}" for this meeting. Please create one first.`,
-        );
+        toggleNotification({
+          type: "danger",
+          message: `No ${collectionDisplayName} found with status "${newStatus}" for this meeting. Please create one first.`,
+        });
         return;
       }
 
       // Get full target record data
       const targetRecord = targetRecords[0];
-      targetRecordId = targetRecord.documentId || targetRecord.id;
+      const targetRecordId = targetRecord.documentId || targetRecord.id;
 
       // Get target record with all fields
       const targetRecordUrl = `/content-manager/collection-types/${targetModel}/${targetRecordId}?populate=*`;
       const targetRecordFull = await get(targetRecordUrl);
       const targetData = targetRecordFull?.data?.data || {};
 
-      // Step 4: Add investor to target record
+      if (!targetData || !targetData.documentId) {
+        console.error("[FilteredRelation] Target record data is invalid");
+        toggleNotification({
+          type: "danger",
+          message: "Target record not found. Please refresh and try again.",
+        });
+        return;
+      }
+
+      // Step 4: NOW disconnect from current record (after validation passed)
+      const updatePayload = {
+        documentId: currentData.documentId,
+        [displayField]: {
+          connect: [],
+          disconnect: [
+            {
+              id: investorToRemove.id,
+              documentId: investorToRemove.documentId,
+            },
+          ],
+        },
+        participantStatus: currentData.participantStatus,
+      };
+
+      // Use disconnect with full payload
+      const removeResponse = await put(
+        `/content-manager/collection-types/${targetModel}/${itemId}`,
+        updatePayload
+      );
+
+      // Step 5: Add investor to target record
       // Build full payload like UI admin does
       const addPayload = {
         documentId: targetData.documentId,
@@ -266,21 +278,29 @@ const FilteredRelationInput = (props) => {
       // Use connect with full payload
       const addResponse = await put(
         `/content-manager/collection-types/${targetModel}/${targetRecordId}`,
-        addPayload,
+        addPayload
       );
 
-      // Dispatch custom event to trigger refresh of all filtered relation fields
+      // Refresh current field first to update local state
+      await fetchFilteredData();
+
+      // Then dispatch custom event to trigger refresh of all other filtered relation fields
       window.dispatchEvent(
         new CustomEvent("filtered-relation-updated", {
           detail: { documentId, targetModel },
-        }),
+        })
       );
 
-      // Refresh current field
-      await fetchFilteredData();
+      toggleNotification({
+        type: "success",
+        message: "Status changed successfully",
+      });
     } catch (err) {
       console.error("[FilteredRelation] Error moving investor:", err);
-      alert("Failed to change status. Check console for details.");
+      toggleNotification({
+        type: "danger",
+        message: "Failed to change status. Please try again.",
+      });
     } finally {
       setUpdatingStatus((prev) => ({ ...prev, [itemId]: false }));
     }
@@ -387,7 +407,7 @@ const FilteredRelationInput = (props) => {
 
         // Auto-save to database
         const documentIds = formattedItems.map(
-          (item) => item.relatedDocumentId || item.id,
+          (item) => item.relatedDocumentId || item.id
         );
         const newValue = JSON.stringify(documentIds);
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tunghtml/strapi-plugin-filtered-relation",
-  "version": "1.1.0",
+  "version": "1.1.2",
   "description": "A Strapi custom field plugin for displaying filtered relations with dynamic placeholder support and status change capability",
   "keywords": [
     "strapi",

package/push-to-github.sh

@@ -0,0 +1,52 @@
+#!/bin/bash
+
+# Script to push plugin to GitHub
+# Usage: ./push-to-github.sh
+
+set -e
+
+echo "🚀 Pushing strapi-plugin-filtered-relation to GitHub..."
+
+# Check if we're in the right directory
+if [ ! -f "package.json" ]; then
+    echo "❌ Error: package.json not found. Are you in the plugin directory?"
+    exit 1
+fi
+
+# Check if git is initialized
+if [ ! -d ".git" ]; then
+    echo "📦 Initializing git repository..."
+    git init
+    git remote add origin https://github.com/finnwasabi/strapi-plugin-filtered-relation.git
+fi
+
+# Add all files
+echo "📝 Adding files..."
+git add .
+
+# Commit
+echo "💾 Committing changes..."
+git commit -m "Release v1.1.0 - Add status change dropdown feature
+
+- Add status change dropdown at end of each item
+- Dynamically fetch enum options from target model schema
+- Move items between records using connect/disconnect API
+- Dispatch custom events to refresh all fields without page reload
+- Remove all console.log statements
+- Update README with detailed options table and descriptions
+- Update CHANGELOG with technical details
+- Fully dynamic and reusable for any use case"
+
+# Tag the release
+echo "🏷️  Creating tag v1.1.0..."
+git tag -a v1.1.0 -m "Version 1.1.0"
+
+# Push to GitHub
+echo "⬆️  Pushing to GitHub..."
+git push origin main
+git push origin v1.1.0
+
+echo "✅ Successfully pushed to GitHub!"
+echo "📦 Package: @tunghtml/strapi-plugin-filtered-relation@1.1.0"
+echo "🔗 GitHub: https://github.com/finnwasabi/strapi-plugin-filtered-relation"
+echo "🔗 NPM: https://www.npmjs.com/package/@tunghtml/strapi-plugin-filtered-relation"