@tuan_son.dinh/gsd 2.6.0

package/src/resources/extensions/gsd/tests/reassess-prompt.test.ts

@@ -0,0 +1,171 @@
+import { readFileSync } from "node:fs";
+import { join, dirname } from "node:path";
+import { fileURLToPath } from "node:url";
+
+// loadPrompt reads from ~/.gsd/agent/extensions/gsd/prompts/ (main checkout).
+// In a worktree the file may not exist there yet, so we resolve prompts
+// relative to this test file's location (the worktree copy).
+const __dirname = dirname(fileURLToPath(import.meta.url));
+const worktreePromptsDir = join(__dirname, "..", "prompts");
+
+let passed = 0;
+let failed = 0;
+
+function assert(condition: boolean, message: string): void {
+  if (condition) {
+    passed++;
+  } else {
+    failed++;
+    console.error(`  FAIL: ${message}`);
+  }
+}
+
+function assertEq<T>(actual: T, expected: T, message: string): void {
+  if (JSON.stringify(actual) === JSON.stringify(expected)) {
+    passed++;
+  } else {
+    failed++;
+    console.error(`  FAIL: ${message} — expected ${JSON.stringify(expected)}, got ${JSON.stringify(actual)}`);
+  }
+}
+
+/**
+ * Load a prompt template from the worktree prompts directory
+ * and apply variable substitution (mirrors loadPrompt logic).
+ */
+function loadPromptFromWorktree(name: string, vars: Record<string, string> = {}): string {
+  const path = join(worktreePromptsDir, `${name}.md`);
+  let content = readFileSync(path, "utf-8");
+  for (const [key, value] of Object.entries(vars)) {
+    content = content.replaceAll(`{{${key}}}`, value);
+  }
+  return content.trim();
+}
+
+// ═══════════════════════════════════════════════════════════════════════════
+// Tests
+// ═══════════════════════════════════════════════════════════════════════════
+
+async function main(): Promise<void> {
+
+  // ─── reassess-roadmap prompt loads and substitutes ─────────────────────
+  console.log("\n=== reassess-roadmap prompt loads and substitutes ===");
+  {
+    const testVars = {
+      milestoneId: "M099",
+      completedSliceId: "S03",
+      assessmentAbsPath: ".gsd/milestones/M099/slices/S03/S03-ASSESSMENT.md",
+      roadmapPath: ".gsd/milestones/M099/M099-ROADMAP.md",
+      inlinedContext: "--- test inlined context block ---",
+    };
+
+    let result: string;
+    let threw = false;
+    try {
+      result = loadPromptFromWorktree("reassess-roadmap", testVars);
+    } catch (err) {
+      threw = true;
+      result = "";
+      console.error(`  ERROR: loadPrompt threw: ${err}`);
+    }
+
+    assert(!threw, "loadPrompt does not throw for reassess-roadmap");
+    assert(typeof result === "string" && result.length > 0, "loadPrompt returns a non-empty string");
+
+    // Verify all test variables were substituted into the output
+    assert(result.includes("M099"), "prompt contains milestoneId 'M099'");
+    assert(result.includes("S03"), "prompt contains completedSliceId 'S03'");
+    assert(result.includes(".gsd/milestones/M099/slices/S03/S03-ASSESSMENT.md"), "prompt contains assessmentAbsPath");
+    assert(result.includes(".gsd/milestones/M099/M099-ROADMAP.md"), "prompt contains roadmapPath");
+    assert(result.includes("--- test inlined context block ---"), "prompt contains inlinedContext");
+
+    // Verify no un-substituted variables remain
+    assert(!result.includes("{{milestoneId}}"), "no un-substituted {{milestoneId}}");
+    assert(!result.includes("{{completedSliceId}}"), "no un-substituted {{completedSliceId}}");
+    assert(!result.includes("{{assessmentAbsPath}}"), "no un-substituted {{assessmentAbsPath}}");
+    assert(!result.includes("{{roadmapPath}}"), "no un-substituted {{roadmapPath}}");
+    assert(!result.includes("{{inlinedContext}}"), "no un-substituted {{inlinedContext}}");
+  }
+
+  // ─── reassess-roadmap contains coverage-check instruction ─────────────
+  console.log("\n=== reassess-roadmap contains coverage-check instruction ===");
+  {
+    const prompt = loadPromptFromWorktree("reassess-roadmap", {
+      milestoneId: "M001",
+      completedSliceId: "S01",
+      assessmentAbsPath: ".gsd/milestones/M001/slices/S01/S01-ASSESSMENT.md",
+      roadmapPath: ".gsd/milestones/M001/M001-ROADMAP.md",
+      inlinedContext: "context",
+    });
+
+    // Normalize to lowercase for case-insensitive matching
+    const lower = prompt.toLowerCase();
+
+    // The prompt must mention "each success criterion" or "every success criterion"
+    assert(
+      lower.includes("each success criterion") || lower.includes("every success criterion"),
+      "prompt contains 'each success criterion' or 'every success criterion'"
+    );
+
+    // The prompt must mention "owning slice" or "remaining slice"
+    assert(
+      lower.includes("owning slice") || lower.includes("remaining slice"),
+      "prompt contains 'owning slice' or 'remaining slice'"
+    );
+
+    // The prompt must mention "no remaining owner" or "no owner" or "no slice"
+    assert(
+      lower.includes("no remaining owner") || lower.includes("no owner") || lower.includes("no slice"),
+      "prompt contains 'no remaining owner', 'no owner', or 'no slice'"
+    );
+
+    // The prompt must mention "blocking issue" or "blocking"
+    assert(
+      lower.includes("blocking issue") || lower.includes("blocking"),
+      "prompt contains 'blocking issue' or 'blocking'"
+    );
+  }
+
+  // ─── coverage-check requires at-least-one semantics ───────────────────
+  console.log("\n=== coverage-check requires at-least-one semantics ===");
+  {
+    const prompt = loadPromptFromWorktree("reassess-roadmap", {
+      milestoneId: "M001",
+      completedSliceId: "S01",
+      assessmentAbsPath: ".gsd/milestones/M001/slices/S01/S01-ASSESSMENT.md",
+      roadmapPath: ".gsd/milestones/M001/M001-ROADMAP.md",
+      inlinedContext: "context",
+    });
+
+    const lower = prompt.toLowerCase();
+
+    // The instruction must use "at least one" or equivalent inclusive language
+    assert(
+      lower.includes("at least one") || lower.includes("at-least-one") || lower.includes("one or more"),
+      "prompt uses 'at least one' or equivalent inclusive language for slice ownership"
+    );
+
+    // The instruction must NOT require "exactly one" — that would be too rigid
+    assert(
+      !lower.includes("exactly one owner") && !lower.includes("exactly one slice"),
+      "prompt does NOT use 'exactly one' for slice ownership (would be too rigid)"
+    );
+  }
+
+  // ═════════════════════════════════════════════════════════════════════════
+  // Results
+  // ═════════════════════════════════════════════════════════════════════════
+
+  console.log(`\n${"=".repeat(40)}`);
+  console.log(`Results: ${passed} passed, ${failed} failed`);
+  if (failed > 0) {
+    process.exit(1);
+  } else {
+    console.log("All tests passed ✓");
+  }
+}
+
+main().catch((error) => {
+  console.error(error);
+  process.exit(1);
+});

package/src/resources/extensions/gsd/tests/remote-questions.test.ts

@@ -0,0 +1,155 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+import { parseSlackReply, parseDiscordResponse } from "../../remote-questions/format.ts";
+import { resolveRemoteConfig, isValidChannelId } from "../../remote-questions/config.ts";
+import { sanitizeError } from "../../remote-questions/manager.ts";
+
+test("parseSlackReply handles single-number single-question answers", () => {
+  const result = parseSlackReply("2", [{
+    id: "choice",
+    header: "Choice",
+    question: "Pick one",
+    allowMultiple: false,
+    options: [
+      { label: "Alpha", description: "A" },
+      { label: "Beta", description: "B" },
+    ],
+  }]);
+
+  assert.deepEqual(result, { answers: { choice: { answers: ["Beta"] } } });
+});
+
+test("parseSlackReply handles multiline multi-question answers", () => {
+  const result = parseSlackReply("1\ncustom note", [
+    {
+      id: "first",
+      header: "First",
+      question: "Pick one",
+      allowMultiple: false,
+      options: [
+        { label: "Alpha", description: "A" },
+        { label: "Beta", description: "B" },
+      ],
+    },
+    {
+      id: "second",
+      header: "Second",
+      question: "Explain",
+      allowMultiple: false,
+      options: [
+        { label: "Gamma", description: "G" },
+        { label: "Delta", description: "D" },
+      ],
+    },
+  ]);
+
+  assert.deepEqual(result, {
+    answers: {
+      first: { answers: ["Alpha"] },
+      second: { answers: [], user_note: "custom note" },
+    },
+  });
+});
+
+test("parseDiscordResponse handles single-question reactions", () => {
+  const result = parseDiscordResponse([{ emoji: "2️⃣", count: 1 }], null, [{
+    id: "choice",
+    header: "Choice",
+    question: "Pick one",
+    allowMultiple: false,
+    options: [
+      { label: "Alpha", description: "A" },
+      { label: "Beta", description: "B" },
+    ],
+  }]);
+
+  assert.deepEqual(result, { answers: { choice: { answers: ["Beta"] } } });
+});
+
+test("parseDiscordResponse rejects multi-question reaction parsing", () => {
+  const result = parseDiscordResponse([{ emoji: "1️⃣", count: 1 }], null, [
+    {
+      id: "first",
+      header: "First",
+      question: "Pick one",
+      allowMultiple: false,
+      options: [{ label: "Alpha", description: "A" }],
+    },
+    {
+      id: "second",
+      header: "Second",
+      question: "Pick one",
+      allowMultiple: false,
+      options: [{ label: "Beta", description: "B" }],
+    },
+  ]);
+
+  assert.match(String(result.answers.first.user_note), /single-question prompts/i);
+  assert.match(String(result.answers.second.user_note), /single-question prompts/i);
+});
+
+test("parseSlackReply truncates user_note longer than 500 chars", () => {
+  const longText = "x".repeat(600);
+  const result = parseSlackReply(longText, [{
+    id: "q1",
+    header: "Q1",
+    question: "Pick",
+    allowMultiple: false,
+    options: [{ label: "A", description: "a" }],
+  }]);
+
+  const note = result.answers.q1.user_note!;
+  assert.ok(note.length <= 502, `note should be truncated, got ${note.length} chars`);
+  assert.ok(note.endsWith("…"), "truncated note should end with ellipsis");
+});
+
+test("isValidChannelId rejects invalid Slack channel IDs", () => {
+  // Too short
+  assert.equal(isValidChannelId("slack", "C123"), false);
+  // Contains invalid chars (URL injection)
+  assert.equal(isValidChannelId("slack", "https://evil.com"), false);
+  // Lowercase
+  assert.equal(isValidChannelId("slack", "c12345678"), false);
+  // Too long
+  assert.equal(isValidChannelId("slack", "C1234567890AB"), false);
+  // Valid: 9-12 uppercase alphanumeric
+  assert.equal(isValidChannelId("slack", "C12345678"), true);
+  assert.equal(isValidChannelId("slack", "C12345678AB"), true);
+  assert.equal(isValidChannelId("slack", "C1234567890A"), true);
+});
+
+test("isValidChannelId rejects invalid Discord channel IDs", () => {
+  // Too short
+  assert.equal(isValidChannelId("discord", "12345"), false);
+  // Contains letters (not a snowflake)
+  assert.equal(isValidChannelId("discord", "abc12345678901234"), false);
+  // URL injection
+  assert.equal(isValidChannelId("discord", "https://evil.com"), false);
+  // Too long (21 digits)
+  assert.equal(isValidChannelId("discord", "123456789012345678901"), false);
+  // Valid: 17-20 digit snowflake
+  assert.equal(isValidChannelId("discord", "12345678901234567"), true);
+  assert.equal(isValidChannelId("discord", "11234567890123456789"), true);
+});
+
+test("sanitizeError strips Slack token patterns from error messages", () => {
+  assert.equal(
+    sanitizeError("Auth failed: xoxb-1234-5678-abcdef"),
+    "Auth failed: [REDACTED]",
+  );
+  assert.equal(
+    sanitizeError("Bad token xoxp-abc-def-ghi in request"),
+    "Bad token [REDACTED] in request",
+  );
+});
+
+test("sanitizeError strips long opaque secrets", () => {
+  const fakeDiscordToken = "MTIzNDU2Nzg5MDEyMzQ1Njc4OQ.G1x2y3.abcdefghijklmnop";
+  assert.ok(!sanitizeError(`Token: ${fakeDiscordToken}`).includes(fakeDiscordToken));
+});
+
+test("sanitizeError preserves short safe messages", () => {
+  assert.equal(sanitizeError("HTTP 401: Unauthorized"), "HTTP 401: Unauthorized");
+  assert.equal(sanitizeError("Connection refused"), "Connection refused");
+});
+

package/src/resources/extensions/gsd/tests/remote-status.test.ts

@@ -0,0 +1,99 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+import { mkdirSync, rmSync } from "node:fs";
+import { join } from "node:path";
+import { tmpdir } from "node:os";
+import { createPromptRecord, writePromptRecord } from "../../remote-questions/store.ts";
+import { getLatestPromptSummary } from "../../remote-questions/status.ts";
+
+function withTempHome(fn: (tempHome: string) => void | Promise<void>) {
+  return async () => {
+    const savedHome = process.env.HOME;
+    const savedUserProfile = process.env.USERPROFILE;
+    const tempHome = join(tmpdir(), `gsd-remote-status-${Date.now()}-${Math.random().toString(36).slice(2)}`);
+    mkdirSync(join(tempHome, ".gsd", "runtime", "remote-questions"), { recursive: true });
+    process.env.HOME = tempHome;
+    process.env.USERPROFILE = tempHome;
+    try {
+      await fn(tempHome);
+    } finally {
+      process.env.HOME = savedHome;
+      process.env.USERPROFILE = savedUserProfile;
+      rmSync(tempHome, { recursive: true, force: true });
+    }
+  };
+}
+
+test("getLatestPromptSummary returns latest stored prompt", withTempHome(() => {
+  const recordA = createPromptRecord({
+    id: "a-prompt",
+    channel: "slack",
+    createdAt: 1,
+    timeoutAt: 10,
+    pollIntervalMs: 5000,
+    questions: [],
+  });
+  recordA.updatedAt = 1;
+  writePromptRecord(recordA);
+
+  const recordB = createPromptRecord({
+    id: "z-prompt",
+    channel: "discord",
+    createdAt: 2,
+    timeoutAt: 10,
+    pollIntervalMs: 5000,
+    questions: [],
+  });
+  recordB.updatedAt = 2;
+  recordB.status = "answered";
+  writePromptRecord(recordB);
+
+  const latest = getLatestPromptSummary();
+  assert.equal(latest?.id, "z-prompt");
+  assert.equal(latest?.status, "answered");
+}));
+
+test("getLatestPromptSummary sorts by updatedAt, not filename", withTempHome(() => {
+  // Record with alphabetically-LAST id but OLDEST timestamp
+  const old = createPromptRecord({
+    id: "zzz-oldest",
+    channel: "slack",
+    createdAt: 1000,
+    timeoutAt: 9999,
+    pollIntervalMs: 5000,
+    questions: [],
+  });
+  old.updatedAt = 1000;
+  writePromptRecord(old);
+
+  // Record with alphabetically-FIRST id but NEWEST timestamp
+  const newest = createPromptRecord({
+    id: "aaa-newest",
+    channel: "discord",
+    createdAt: 3000,
+    timeoutAt: 9999,
+    pollIntervalMs: 5000,
+    questions: [],
+  });
+  newest.updatedAt = 3000;
+  newest.status = "answered";
+  writePromptRecord(newest);
+
+  // Record in between
+  const middle = createPromptRecord({
+    id: "mmm-middle",
+    channel: "slack",
+    createdAt: 2000,
+    timeoutAt: 9999,
+    pollIntervalMs: 5000,
+    questions: [],
+  });
+  middle.updatedAt = 2000;
+  writePromptRecord(middle);
+
+  const latest = getLatestPromptSummary();
+  // Should return "aaa-newest" (updatedAt=3000), NOT "zzz-oldest" (alphabetically last)
+  assert.equal(latest?.id, "aaa-newest", "should pick the most recently updated prompt, not the alphabetically last filename");
+  assert.equal(latest?.status, "answered");
+  assert.equal(latest?.updatedAt, 3000);
+}));