@ttsc/lint 0.33.1 → 0.34.0

package/linthost/project_engine.go

@@ -239,7 +239,7 @@ func (e *Engine) projectSources(files []*shimast.SourceFile) []*shimast.SourceFi
     if file == nil {
       continue
     }
-    if e != nil && e.config != nil && e.config.ResolveRules(file.FileName()).Ignored {
+    if e != nil && e.config != nil && e.config.ResolveRules(string(file.FileName())).Ignored {
       continue
     }
     sources = append(sources, file)

package/linthost/project_rule_sources_apply_only_global_ignores_test.go

@@ -34,7 +34,7 @@ func TestProjectRuleSourcesApplyOnlyGlobalIgnores(t *testing.T) {
     name: name,
     check: func(ctx *publicrule.ProjectContext) {
       for _, source := range ctx.Sources {
-        observed = append(observed, filepath.Clean(source.FileName()))
+        observed = append(observed, filepath.Clean(string(source.FileName())))
       }
     },
   })

package/linthost/project_rule_sources_include_imported_sibling_source_test.go

@@ -24,8 +24,8 @@ func (r importedSourcePopulationRule) Check(ctx *publicrule.ProjectContext) {
     if file == nil {
       continue
     }
-    *r.observed = append(*r.observed, filepath.Base(file.FileName()))
-    *r.paths = append(*r.paths, file.FileName())
+    *r.observed = append(*r.observed, filepath.Base(string(file.FileName())))
+    *r.paths = append(*r.paths, string(file.FileName()))
   }
 }
 

package/linthost/project_source_files_follow_tsconfig_selection_test.go

@@ -56,7 +56,7 @@ func TestProjectSourceFilesFollowTsconfigSelection(t *testing.T) {
   defer prog.close()
   imported := map[string]int{"src/extra.ts": 0, "src/data.json": 0}
   for _, file := range prog.tsProgram.SourceFiles() {
-    name := filepath.ToSlash(filepath.Clean(file.FileName()))
+    name := filepath.ToSlash(filepath.Clean(string(file.FileName())))
     for expected := range imported {
       if name == filepath.ToSlash(filepath.Join(root, expected)) {
         imported[expected]++
@@ -71,7 +71,7 @@ func TestProjectSourceFilesFollowTsconfigSelection(t *testing.T) {
 
   names := make([]string, 0)
   for _, file := range prog.projectSourceFiles() {
-    rel, err := filepath.Rel(root, file.FileName())
+    rel, err := filepath.Rel(root, string(file.FileName()))
     if err != nil {
       t.Fatal(err)
     }

package/linthost/project_source_selection_preserves_explicit_bundled_roots_test.go

@@ -9,6 +9,7 @@ import (
   "testing"
 
   "github.com/microsoft/typescript-go/shim/bundled"
+  shimtspath "github.com/microsoft/typescript-go/shim/tspath"
 )
 
 // TestProjectSourceSelectionPreservesExplicitBundledRoots verifies that an
@@ -21,10 +22,10 @@ import (
 // @evidence contracts/testing.md#execution-ownership This public Go unit requires embedded libraries and invokes both source projections and the writable guard in process over temporary config/source inputs, without an installed package, product subprocess or native build. Native noembed ownership belongs to the native source-selection units.
 func TestProjectSourceSelectionPreservesExplicitBundledRoots(t *testing.T) {
   root := t.TempDir()
-  library := bundled.LibPath() + "/lib.es5.d.ts"
+  library := shimtspath.ResolveFile(bundled.LibPath(), "lib.es5.d.ts")
   config, err := json.Marshal(map[string]any{
     "compilerOptions": map[string]any{"target": "ES2022", "strict": true},
-    "files":           []string{"main.ts", library},
+    "files":           []string{"main.ts", string(library)},
   })
   if err != nil {
     t.Fatal(err)
@@ -39,7 +40,7 @@ func TestProjectSourceSelectionPreservesExplicitBundledRoots(t *testing.T) {
   bundledFiles := 0
   var excluded *Finding
   for _, file := range prog.tsProgram.SourceFiles() {
-    if bundled.IsBundled(file.FileName()) {
+    if bundled.IsBundled(string(file.FileName())) {
       bundledFiles++
       if file.FileName() != library && excluded == nil {
         excluded = &Finding{File: file}
@@ -56,10 +57,10 @@ func TestProjectSourceSelectionPreservesExplicitBundledRoots(t *testing.T) {
       sources = prog.projectSourceFiles
     }
     for _, file := range sources() {
-      files = append(files, filepath.ToSlash(file.FileName()))
+      files = append(files, filepath.ToSlash(string(file.FileName())))
     }
     expectedMain := filepath.ToSlash(filepath.Join(root, "main.ts"))
-    if len(files) != 2 || !slices.Contains(files, expectedMain) || !slices.Contains(files, library) {
+    if len(files) != 2 || !slices.Contains(files, expectedMain) || !slices.Contains(files, string(library)) {
       t.Errorf("%s source membership=%v, want main.ts and explicit %s", name, files, library)
     }
   }

package/linthost/resident_whole_corpus_matches_cold_load_test.go

@@ -137,7 +137,7 @@ func fingerprintFindings(findings []*Finding) []string {
     }
     name := ""
     if finding.File != nil {
-      name = filepath.Base(finding.File.FileName())
+      name = filepath.Base(string(finding.File.FileName()))
     }
     out = append(out, finding.Rule+"|"+name+"|"+
       strconv.Itoa(finding.Pos)+"|"+strconv.Itoa(finding.End)+"|"+finding.Message)

package/linthost/rules_boundaries.go

@@ -38,7 +38,7 @@ func (boundariesElementTypes) Check(ctx *Context, node *shimast.Node) {
   if len(opts.Elements) == 0 {
     return
   }
-  source := classifyBoundaryFile(ctx.File.FileName(), opts.Elements)
+  source := classifyBoundaryFile(string(ctx.File.FileName()), opts.Elements)
   if source == nil {
     return
   }
@@ -46,7 +46,7 @@ func (boundariesElementTypes) Check(ctx *Context, node *shimast.Node) {
     if !dep.relative {
       continue
     }
-    targetPath, ok := resolveBoundaryImport(ctx.File.FileName(), dep.specifier)
+    targetPath, ok := resolveBoundaryImport(string(ctx.File.FileName()), dep.specifier)
     if !ok {
       continue
     }
@@ -96,12 +96,12 @@ func (boundariesEntryPoint) Check(ctx *Context, node *shimast.Node) {
   if len(opts.Elements) == 0 {
     return
   }
-  source := classifyBoundaryFile(ctx.File.FileName(), opts.Elements)
+  source := classifyBoundaryFile(string(ctx.File.FileName()), opts.Elements)
   for _, dep := range collectBoundaryDependencies(node) {
     if !dep.relative {
       continue
     }
-    targetPath, ok := resolveBoundaryImport(ctx.File.FileName(), dep.specifier)
+    targetPath, ok := resolveBoundaryImport(string(ctx.File.FileName()), dep.specifier)
     if !ok {
       continue
     }
@@ -128,7 +128,7 @@ func (boundariesNoPrivate) Check(ctx *Context, node *shimast.Node) {
   if len(opts.Elements) == 0 {
     return
   }
-  source := classifyBoundaryFile(ctx.File.FileName(), opts.Elements)
+  source := classifyBoundaryFile(string(ctx.File.FileName()), opts.Elements)
   if source == nil {
     return
   }
@@ -136,7 +136,7 @@ func (boundariesNoPrivate) Check(ctx *Context, node *shimast.Node) {
     if !dep.relative {
       continue
     }
-    targetPath, ok := resolveBoundaryImport(ctx.File.FileName(), dep.specifier)
+    targetPath, ok := resolveBoundaryImport(string(ctx.File.FileName()), dep.specifier)
     if !ok {
       continue
     }
@@ -160,7 +160,7 @@ func (boundariesNoUnknown) Check(ctx *Context, node *shimast.Node) {
     if !dep.relative {
       continue
     }
-    targetPath, ok := resolveBoundaryImport(ctx.File.FileName(), dep.specifier)
+    targetPath, ok := resolveBoundaryImport(string(ctx.File.FileName()), dep.specifier)
     if !ok {
       continue
     }

package/linthost/rules_boundaries_dependencies.go

@@ -107,7 +107,7 @@ func (boundariesDependencies) Check(ctx *Context, node *shimast.Node) {
   if err != nil {
     return
   }
-  source := classifyBoundaryFile(ctx.File.FileName(), options.Elements)
+  source := classifyBoundaryFile(string(ctx.File.FileName()), options.Elements)
   if source == nil {
     return
   }
@@ -595,12 +595,12 @@ func describeBoundaryDependency(
   source *boundaryFile,
   dependency boundaryDependency,
 ) boundaryDependenciesDescription {
-  from := boundaryDependenciesEntityFromFile(source, ctx.File.FileName(), "local")
+  from := boundaryDependenciesEntityFromFile(source, string(ctx.File.FileName()), "local")
   resolvedPath, resolved := resolveBoundaryDependencyPath(ctx, dependency)
   local := dependency.relative || (resolved && boundaryDependenciesProjectLocalPath(ctx.CurrentDirectory, resolvedPath))
   if local {
     if !resolved && dependency.relative {
-      resolvedPath = filepath.Clean(filepath.Join(filepath.Dir(ctx.File.FileName()), filepath.FromSlash(dependency.specifier)))
+      resolvedPath = filepath.Clean(filepath.Join(filepath.Dir(string(ctx.File.FileName())), filepath.FromSlash(dependency.specifier)))
     }
     target := classifyBoundaryFile(resolvedPath, options.Elements)
     to := boundaryDependenciesEntityFromFile(target, resolvedPath, "local")
@@ -648,21 +648,21 @@ func boundaryDependenciesEntityFromFile(file *boundaryFile, path, origin string)
 func resolveBoundaryDependencyPath(ctx *Context, dependency boundaryDependency) (string, bool) {
   if ctx != nil && ctx.Checker != nil && dependency.node != nil {
     symbol := ctx.Checker.GetSymbolAtLocation(dependency.node)
-    if symbol != nil && symbol.Flags&shimast.SymbolFlagsAlias != 0 {
+    if symbol != nil && shimast.SymbolFlagsOf(symbol)&shimast.SymbolFlagsAlias != 0 {
       symbol = ctx.Checker.GetAliasedSymbol(symbol)
     }
     if symbol != nil {
-      for _, declaration := range symbol.Declarations {
+      for _, declaration := range shimast.SymbolDeclarationsOf(symbol) {
         source := sourceFileForBoundaryDeclaration(declaration)
         if source == nil || source.FileName() == "" {
           continue
         }
-        return filepath.Clean(source.FileName()), true
+        return filepath.Clean(string(source.FileName())), true
       }
     }
   }
   if ctx != nil && ctx.File != nil {
-    return resolveBoundaryImport(ctx.File.FileName(), dependency.specifier)
+    return resolveBoundaryImport(string(ctx.File.FileName()), dependency.specifier)
   }
   return "", false
 }
@@ -715,9 +715,9 @@ func boundaryDependenciesShadowedRequire(ctx *Context, dependency boundaryDepend
   if symbol == nil {
     return false
   }
-  for _, declaration := range symbol.Declarations {
+  for _, declaration := range shimast.SymbolDeclarationsOf(symbol) {
     source := sourceFileForBoundaryDeclaration(declaration)
-    if source != nil && boundaryDependenciesProjectLocalPath(ctx.CurrentDirectory, source.FileName()) {
+    if source != nil && boundaryDependenciesProjectLocalPath(ctx.CurrentDirectory, string(source.FileName())) {
       return true
     }
   }

package/linthost/rules_format_declaration_header.go

@@ -504,12 +504,19 @@ func singleGenericHeritageHeader(src, base, prefix string, typeParams, heritage
   if typeNode == nil {
     return "", false
   }
-  ewta := typeNode.AsExpressionWithTypeArguments()
-  if ewta == nil || ewta.TypeArguments == nil || len(ewta.TypeArguments.Nodes) < 2 {
+  // An interface's `extends` and a class's `implements` element is a type
+  // reference when it names an entity; other elements keep the expression form.
+  var typeArguments *shimast.NodeList
+  if typeNode.Kind == shimast.KindTypeReference {
+    typeArguments = typeNode.AsTypeReferenceNode().TypeArguments
+  } else if ewta := typeNode.AsExpressionWithTypeArguments(); ewta != nil {
+    typeArguments = ewta.TypeArguments
+  }
+  if typeArguments == nil || len(typeArguments.Nodes) < 2 {
     return "", false
   }
   nameStart := shimscanner.SkipTrivia(src, typeNode.Pos())
-  ltPos := typeArgsStart(src, ewta.TypeArguments)
+  ltPos := typeArgsStart(src, typeArguments)
   if nameStart < 0 || ltPos <= nameStart {
     return "", false
   }
@@ -517,7 +524,7 @@ func singleGenericHeritageHeader(src, base, prefix string, typeParams, heritage
   if strings.ContainsRune(typeName, '\n') {
     return "", false
   }
-  args, ok := nodeListTexts(src, ewta.TypeArguments)
+  args, ok := nodeListTexts(src, typeArguments)
   if !ok {
     return "", false
   }

package/linthost/rules_gap.go

@@ -210,7 +210,7 @@ func requiresGenericArrowDisambiguation(
   }
   requiresDisambiguation := ctx.File.ScriptKind == shimcore.ScriptKindTSX
   if !requiresDisambiguation {
-    switch strings.ToLower(filepath.Ext(ctx.File.FileName())) {
+    switch strings.ToLower(filepath.Ext(string(ctx.File.FileName()))) {
     case ".mts", ".cts":
       requiresDisambiguation = true
     }

package/linthost/rules_jsdoc.go

@@ -70,7 +70,7 @@ func (r jsdocLintRule) Visits() []shimast.Kind {
 }
 
 func (r jsdocLintRule) Check(ctx *Context, node *shimast.Node) {
-  if ctx == nil || ctx.File == nil || r.check == nil || !isTypeScriptSourceName(ctx.File.FileName()) {
+  if ctx == nil || ctx.File == nil || r.check == nil || !isTypeScriptSourceName(string(ctx.File.FileName())) {
     return
   }
   src := ctx.File.Text()

package/linthost/rules_logic.go

@@ -84,7 +84,7 @@ func isGlobalBooleanConverter(ctx *Context, callee *shimast.Node) bool {
   // Binding retains this file's own runtime declaration even when a duplicate
   // global declaration is omitted from the checker's merged global symbol.
   if ctx.File != nil {
-    if local := ctx.File.AsNode().Locals()["Boolean"]; local != nil && local.Flags&shimast.SymbolFlagsValue != 0 {
+    if local := ctx.File.AsNode().Locals()["Boolean"]; local != nil && shimast.SymbolFlagsOf(local)&shimast.SymbolFlagsValue != 0 {
       return false
     }
   }
@@ -94,7 +94,7 @@ func isGlobalBooleanConverter(ctx *Context, callee *shimast.Node) bool {
     ctx.Checker.GetMergedSymbol(resolved) != ctx.Checker.GetMergedSymbol(global) {
     return false
   }
-  for _, declaration := range ctx.Checker.GetMergedSymbol(resolved).Declarations {
+  for _, declaration := range shimast.SymbolDeclarationsOf(ctx.Checker.GetMergedSymbol(resolved)) {
     if declaration == nil {
       continue
     }

package/linthost/rules_nextjs.go

@@ -698,7 +698,7 @@ func nextjsFilePath(file *shimast.SourceFile) string {
   if file == nil {
     return ""
   }
-  return filepath.ToSlash(file.FileName())
+  return filepath.ToSlash(string(file.FileName()))
 }
 
 func nextjsIsPagesFile(file *shimast.SourceFile) bool {

package/linthost/rules_no_loop_func.go

@@ -244,7 +244,7 @@ func (a *noLoopFuncAnalysis) isReferencedNamedIIFE(function *shimast.Node) bool
 }
 
 func (a *noLoopFuncAnalysis) symbolDeclaredInside(symbol *shimast.Symbol, function *shimast.Node) bool {
-  for _, declaration := range symbol.Declarations {
+  for _, declaration := range shimast.SymbolDeclarationsOf(symbol) {
     if declaration != nil && declaration.Pos() >= function.Pos() && declaration.End() <= function.End() {
       return true
     }
@@ -280,9 +280,9 @@ func (a *noLoopFuncAnalysis) binding(symbol *shimast.Symbol) noLoopFuncBinding {
     return binding
   }
   binding := noLoopFuncBinding{kind: noLoopFuncOtherBinding}
-  declarations := symbol.Declarations
-  if symbol.ValueDeclaration != nil {
-    declarations = append([]*shimast.Node{symbol.ValueDeclaration}, declarations...)
+  declarations := shimast.SymbolDeclarationsOf(symbol)
+  if shimast.SymbolValueDeclarationOf(symbol) != nil {
+    declarations = append([]*shimast.Node{shimast.SymbolValueDeclarationOf(symbol)}, declarations...)
   }
   for _, declaration := range declarations {
     root := noLoopFuncRootVariableDeclaration(declaration)

package/linthost/rules_no_promise_executor_return.go

@@ -75,7 +75,7 @@ func isGlobalPromiseConstructor(ctx *Context, callee *shimast.Node) bool {
   if resolved != global {
     return false
   }
-  for _, declaration := range resolved.Declarations {
+  for _, declaration := range shimast.SymbolDeclarationsOf(resolved) {
     if declaration != nil && shimast.GetSourceFileOfNode(declaration) == ctx.File &&
       promiseDeclarationIntroducesValue(declaration) {
       return false

package/linthost/rules_promise.go

@@ -389,7 +389,7 @@ func isCallableCallbackParameter(
   if callbackType == nil {
     return false
   }
-  if declaration := parameter.ValueDeclaration; declaration != nil {
+  if declaration := shimast.SymbolValueDeclarationOf(parameter); declaration != nil {
     if parameterDeclaration := declaration.AsParameterDeclaration(); parameterDeclaration != nil && parameterDeclaration.DotDotDotToken != nil {
       callbackType = checker.GetNumberIndexType(callbackType)
       if callbackType == nil {
@@ -540,7 +540,7 @@ func isNativePromiseConstructorLikeSeen(
   if symbol == nil {
     return false
   }
-  if symbol.Name == "PromiseConstructor" && checker.IsLibSymbolForHoverVerbosity(symbol) {
+  if shimast.SymbolNameOf(symbol) == "PromiseConstructor" && checker.IsLibSymbolForHoverVerbosity(symbol) {
     return true
   }
   declared := checker.GetDeclaredTypeOfSymbol(symbol)
@@ -1529,15 +1529,15 @@ func floatingPromiseCallableArgumentApplicability(
     return floatingPromiseCallUncertain
   }
   for _, expectedProperty := range shimchecker.Checker_getPropertiesOfType(checker, expectedType) {
-    expectedOptional := expectedProperty.Flags&shimast.SymbolFlagsOptional != 0
-    actualProperty := checker.GetPropertyOfType(actualType, expectedProperty.Name)
+    expectedOptional := shimast.SymbolFlagsOf(expectedProperty)&shimast.SymbolFlagsOptional != 0
+    actualProperty := checker.GetPropertyOfType(actualType, shimast.SymbolNameOf(expectedProperty))
     if actualProperty == nil {
       if expectedOptional {
         continue
       }
       return floatingPromiseCallIncompatible
     }
-    if !expectedOptional && actualProperty.Flags&shimast.SymbolFlagsOptional != 0 {
+    if !expectedOptional && shimast.SymbolFlagsOf(actualProperty)&shimast.SymbolFlagsOptional != 0 {
       return floatingPromiseCallIncompatible
     }
     if floatingPromiseSymbolHasNonPublicDeclaration(expectedProperty) ||
@@ -1672,10 +1672,10 @@ func floatingPromiseSymbolHasNonPublicDeclaration(symbol *shimast.Symbol) bool {
     return declaration != nil &&
       declaration.ModifierFlags()&(shimast.ModifierFlagsPrivate|shimast.ModifierFlagsProtected) != 0
   }
-  if hasNonPublicModifier(symbol.ValueDeclaration) {
+  if hasNonPublicModifier(shimast.SymbolValueDeclarationOf(symbol)) {
     return true
   }
-  for _, declaration := range symbol.Declarations {
+  for _, declaration := range shimast.SymbolDeclarationsOf(symbol) {
     if hasNonPublicModifier(declaration) {
       return true
     }
@@ -2409,7 +2409,7 @@ func isNativePromiseInstanceLikeSeen(
   if symbol == nil {
     return false
   }
-  if symbol.Name == "Promise" && checker.IsLibSymbolForHoverVerbosity(symbol) {
+  if shimast.SymbolNameOf(symbol) == "Promise" && checker.IsLibSymbolForHoverVerbosity(symbol) {
     return true
   }
   declared := checker.GetDeclaredTypeOfSymbol(symbol)
@@ -2497,7 +2497,7 @@ func promiseValueNameAndSymbol(
     }
   }
   symbol := checker.GetSymbolAtLocation(nameNode)
-  if symbol != nil && symbol.Flags&shimast.SymbolFlagsAlias != 0 {
+  if symbol != nil && shimast.SymbolFlagsOf(symbol)&shimast.SymbolFlagsAlias != 0 {
     symbol = checker.GetAliasedSymbol(symbol)
   }
   return staticName, symbol
@@ -2541,7 +2541,7 @@ func typeMatchesPromiseSpecifier(
   if symbol == nil {
     symbol = t.Symbol()
   }
-  if symbol != nil && symbol.Flags&shimast.SymbolFlagsAlias != 0 {
+  if symbol != nil && shimast.SymbolFlagsOf(symbol)&shimast.SymbolFlagsAlias != 0 {
     symbol = ctx.Checker.GetAliasedSymbol(symbol)
   }
   if promiseSpecifierMatchesSymbol(ctx, specifier, "", symbol) {
@@ -2565,7 +2565,7 @@ func promiseSpecifierMatchesSymbol(
 ) bool {
   symbolName := ""
   if symbol != nil {
-    symbolName = symbol.Name
+    symbolName = shimast.SymbolNameOf(symbol)
   }
   if !promiseSpecifierNameMatches(specifier.Names, staticName, symbolName) {
     return false
@@ -2600,18 +2600,18 @@ func promiseSymbolDeclaredInFile(ctx *Context, symbol *shimast.Symbol, configure
   if ctx == nil || ctx.File == nil || symbol == nil {
     return false
   }
-  for _, declaration := range symbol.Declarations {
+  for _, declaration := range shimast.SymbolDeclarationsOf(symbol) {
     source := sourceFileForPromiseDeclaration(declaration)
     if source == nil || ctx.Checker.IsLibSymbolForHoverVerbosity(symbol) {
       continue
     }
     if configuredPath == "" {
-      if ctx.CurrentDirectory == "" || promisePathWithin(ctx.CurrentDirectory, source.FileName()) {
+      if ctx.CurrentDirectory == "" || promisePathWithin(ctx.CurrentDirectory, string(source.FileName())) {
         return true
       }
       continue
     }
-    if promiseDeclarationPathMatches(ctx.CurrentDirectory, source.FileName(), configuredPath) {
+    if promiseDeclarationPathMatches(ctx.CurrentDirectory, string(source.FileName()), configuredPath) {
       return true
     }
   }
@@ -2652,7 +2652,7 @@ func promiseSymbolDeclaredInPackage(symbol *shimast.Symbol, packageName string)
   typesName := strings.TrimPrefix(packageName, "@")
   typesName = strings.Replace(typesName, "/", "__", 1)
   typesPath := "/node_modules/@types/" + typesName + "/"
-  for _, declaration := range symbol.Declarations {
+  for _, declaration := range shimast.SymbolDeclarationsOf(symbol) {
     for parent := declaration; parent != nil; parent = parent.Parent {
       if parent.Kind == shimast.KindModuleDeclaration {
         if name := parent.Name(); name != nil && stringLiteralText(name) == packageName {
@@ -2664,7 +2664,7 @@ func promiseSymbolDeclaredInPackage(symbol *shimast.Symbol, packageName string)
         if source == nil {
           break
         }
-        fileName := "/" + strings.TrimLeft(filepath.ToSlash(source.FileName()), "/")
+        fileName := "/" + strings.TrimLeft(filepath.ToSlash(string(source.FileName())), "/")
         if strings.Contains(fileName, packagePath) || strings.Contains(fileName, typesPath) {
           return true
         }

package/linthost/rules_react_perf.go

@@ -56,7 +56,7 @@ func reactPerfIsTSXFile(ctx *Context) bool {
   if ctx == nil || ctx.File == nil {
     return false
   }
-  return strings.EqualFold(filepath.Ext(ctx.File.FileName()), ".tsx")
+  return strings.EqualFold(filepath.Ext(string(ctx.File.FileName())), ".tsx")
 }
 
 func reactPerfAttributeExpression(initializer *shimast.Node) *shimast.Node {

package/linthost/rules_react_refresh.go

@@ -65,11 +65,11 @@ func (onlyExportComponents) Check(ctx *Context, node *shimast.Node) {
   if err := ctx.DecodeOptions(&options); err != nil {
     return
   }
-  if !shouldScanReactRefreshFile(ctx.File.FileName(), options.CheckJS) {
+  if !shouldScanReactRefreshFile(string(ctx.File.FileName()), options.CheckJS) {
     return
   }
 
-  scan := newReactRefreshScan(ctx, options, reactRefreshRequiresReactImport(ctx.File.FileName(), options.CheckJS))
+  scan := newReactRefreshScan(ctx, options, reactRefreshRequiresReactImport(string(ctx.File.FileName()), options.CheckJS))
   for _, stmt := range node.Statements() {
     scan.handleStatement(stmt)
   }

package/linthost/rules_security.go

@@ -442,10 +442,10 @@ func securityValueBindingModule(ctx *Context, identifier *shimast.Node) string {
   if target == nil {
     return ""
   }
-  if module := securityRequiredModuleFromDeclaration(target.ValueDeclaration); module != "" {
+  if module := securityRequiredModuleFromDeclaration(shimast.SymbolValueDeclarationOf(target)); module != "" {
     return module
   }
-  for _, declaration := range target.Declarations {
+  for _, declaration := range shimast.SymbolDeclarationsOf(target) {
     if module := securityRequiredModuleFromDeclaration(declaration); module != "" {
       return module
     }
@@ -545,10 +545,10 @@ func securitySymbolHasDeclarationInFile(symbol *shimast.Symbol, file *shimast.So
     }
     return false
   }
-  if belongs(symbol.ValueDeclaration) {
+  if belongs(shimast.SymbolValueDeclarationOf(symbol)) {
     return true
   }
-  for _, declaration := range symbol.Declarations {
+  for _, declaration := range shimast.SymbolDeclarationsOf(symbol) {
     if belongs(declaration) {
       return true
     }

package/linthost/rules_storybook.go

@@ -1361,7 +1361,7 @@ func storybookFindPackageJSON(file *shimast.SourceFile) string {
   if file == nil {
     return ""
   }
-  dir := filepath.Dir(file.FileName())
+  dir := filepath.Dir(string(file.FileName()))
   for {
     candidate := filepath.Join(dir, "package.json")
     if _, err := os.Stat(candidate); err == nil {

package/linthost/rules_testing_library.go

@@ -733,7 +733,7 @@ func (s *testingLibraryState) reportInconsistentDataTestIDs(ctx *Context) {
   if err := ctx.DecodeOptions(&opts); err != nil || opts.TestIDPattern == "" {
     return
   }
-  pattern := strings.ReplaceAll(opts.TestIDPattern, "{fileName}", testingLibraryFileName(ctx.File.FileName()))
+  pattern := strings.ReplaceAll(opts.TestIDPattern, "{fileName}", testingLibraryFileName(string(ctx.File.FileName())))
   re, err := regexp.Compile(pattern)
   if err != nil {
     return

package/linthost/rules_ts_no_base_to_string.go

@@ -180,7 +180,7 @@ func typeOverridesToString(checker *shimchecker.Checker, t *shimchecker.Type) bo
   if prop == nil {
     return false
   }
-  for _, decl := range prop.Declarations {
+  for _, decl := range shimast.SymbolDeclarationsOf(prop) {
     if decl == nil {
       continue
     }

package/linthost/rules_ts_no_deprecated.go

@@ -80,7 +80,7 @@ func (noDeprecated) Check(ctx *Context, node *shimast.Node) {
   }
   name := identifierText(node)
   if name == "" {
-    name = symbol.Name
+    name = shimast.SymbolNameOf(symbol)
   }
   message := "`" + name + "` is deprecated."
   if comment := jsdocDeprecatedComment(tag); comment != "" {
@@ -120,7 +120,7 @@ func noDeprecatedLocationIsDeclarationName(loc *shimast.Node, symbol *shimast.Sy
   if loc == nil || symbol == nil {
     return false
   }
-  for _, decl := range symbol.Declarations {
+  for _, decl := range shimast.SymbolDeclarationsOf(symbol) {
     if decl == nil {
       continue
     }
@@ -141,7 +141,7 @@ func findDeprecatedJSDocTag(symbol *shimast.Symbol) *shimast.Node {
   if symbol == nil {
     return nil
   }
-  for _, decl := range symbol.Declarations {
+  for _, decl := range shimast.SymbolDeclarationsOf(symbol) {
     if tag := deprecatedJSDocTagOnNodeOrAncestors(decl); tag != nil {
       return tag
     }

package/linthost/rules_ts_no_unnecessary_qualifier.go

@@ -123,7 +123,7 @@ func noUnnecessaryQualifierIsUnnecessary(ctx *Context, node *shimast.Node, head
   if accessedSymbol == nil {
     return false
   }
-  fromScope := noUnnecessaryQualifierSymbolInScope(ctx, head, accessedSymbol.Flags, identifierText(name))
+  fromScope := noUnnecessaryQualifierSymbolInScope(ctx, head, shimast.SymbolFlagsOf(accessedSymbol), identifierText(name))
   if fromScope == nil {
     return false
   }
@@ -158,14 +158,14 @@ func noUnnecessaryQualifierSymbolIsNamespaceInScope(ctx *Context, enclosing []*s
   if symbol == nil || depth > 16 {
     return false
   }
-  for _, decl := range symbol.Declarations {
+  for _, decl := range shimast.SymbolDeclarationsOf(symbol) {
     for _, ns := range enclosing {
       if decl == ns {
         return true
       }
     }
   }
-  if symbol.Flags&shimast.SymbolFlagsAlias != 0 {
+  if shimast.SymbolFlagsOf(symbol)&shimast.SymbolFlagsAlias != 0 {
     alias := ctx.Checker.GetAliasedSymbol(symbol)
     if alias != nil && alias != symbol {
       return noUnnecessaryQualifierSymbolIsNamespaceInScope(ctx, enclosing, alias, depth+1)
@@ -183,7 +183,7 @@ func noUnnecessaryQualifierSymbolInScope(ctx *Context, head *shimast.Node, flags
     return nil
   }
   for _, symbol := range ctx.Checker.GetSymbolsInScope(head, flags) {
-    if symbol != nil && symbol.Name == name {
+    if symbol != nil && shimast.SymbolNameOf(symbol) == name {
       return symbol
     }
   }

package/linthost/rules_ts_no_unnecessary_type_arguments.go

@@ -162,13 +162,13 @@ func noUnnecessaryTypeArgumentsResolveParameters(ctx *Context, node, nameNode *s
     target = qn.Right
   }
   symbol := ctx.Checker.GetSymbolAtLocation(target)
-  if symbol != nil && symbol.Flags&shimast.SymbolFlagsAlias != 0 {
+  if symbol != nil && shimast.SymbolFlagsOf(symbol)&shimast.SymbolFlagsAlias != 0 {
     symbol = ctx.Checker.GetAliasedSymbol(symbol)
   }
   if symbol == nil {
     return nil
   }
-  for _, decl := range symbol.Declarations {
+  for _, decl := range shimast.SymbolDeclarationsOf(symbol) {
     switch decl.Kind {
     case shimast.KindClassDeclaration, shimast.KindClassExpression,
       shimast.KindInterfaceDeclaration, shimast.KindTypeAliasDeclaration:

package/linthost/rules_ts_no_unsafe_assignment.go

@@ -511,7 +511,7 @@ func noUnsafeAssignmentCheckObjectDestructure(
     if symbol == nil {
       continue
     }
-    properties[symbol.Name] = shimchecker.Checker_getTypeOfSymbolAtLocation(
+    properties[shimast.SymbolNameOf(symbol)] = shimchecker.Checker_getTypeOfSymbolAtLocation(
       ctx.Checker,
       symbol,
       senderNode,

package/linthost/rules_ts_no_unsafe_enum_comparison.go

@@ -157,7 +157,7 @@ func noUnsafeEnumComparisonEnumDeclaration(t *shimchecker.Type) *shimast.Node {
     if sym == nil {
       return nil
     }
-    for _, decl := range sym.Declarations {
+    for _, decl := range shimast.SymbolDeclarationsOf(sym) {
       if decl == nil {
         continue
       }