@ttsc/lint 0.18.4 → 0.19.0

package/linthost/rules_self.go

@@ -72,7 +72,9 @@ func (noSelfCompare) Check(ctx *Context, node *shimast.Node) {
 }
 
 // isComparisonOperator reports whether kind is one of the eight standard
-// comparison operators: ==, ===, !=, !==, <, >, <=, >=.
+// comparison operators: ==, ===, !=, !==, <, >, <=, >=. Rules whose upstream
+// operator set spans both equality and ordering (no-self-compare, use-isnan,
+// no-compare-neg-zero, yoda) gate on this one.
 func isComparisonOperator(kind shimast.Kind) bool {
   switch kind {
   case
@@ -89,6 +91,24 @@ func isComparisonOperator(kind shimast.Kind) bool {
   return false
 }
 
+// isEqualityOperator reports whether kind is one of the four equality
+// operators: ==, ===, !=, !==. It is the sameness-testing half of
+// isComparisonOperator, for the rules whose upstream operator set stops at
+// equality (valid-typeof, security/detect-possible-timing-attacks): the four
+// relational operators order their operands instead of testing them for
+// identity.
+func isEqualityOperator(kind shimast.Kind) bool {
+  switch kind {
+  case
+    shimast.KindEqualsEqualsToken,
+    shimast.KindEqualsEqualsEqualsToken,
+    shimast.KindExclamationEqualsToken,
+    shimast.KindExclamationEqualsEqualsToken:
+    return true
+  }
+  return false
+}
+
 func init() {
   Register(noSelfAssign{})
   Register(noSelfCompare{})

package/linthost/rules_solid.go

@@ -15,9 +15,6 @@ func (r solidRule) Visits() []shimast.Kind {
   return []shimast.Kind{shimast.KindSourceFile}
 }
 func (r solidRule) Check(ctx *Context, node *shimast.Node) {
-  if r.name == "jsx-uses-vars" {
-    return
-  }
   state := collectSolidState(ctx)
   if !state.hasSolid && r.name != "jsx-no-undef" {
     return
@@ -191,7 +188,7 @@ func (s *solidState) collectVariable(node *shimast.Node) {
   }
   collectSolidBindingNames(decl.Name(), s.declared)
   init := stripParens(decl.Initializer)
-  if init == nil {
+  if init == nil || init.Kind != shimast.KindCallExpression {
     return
   }
   initCall := init.AsCallExpression()
@@ -206,7 +203,11 @@ func (s *solidState) collectVariable(node *shimast.Node) {
   if binding == nil || binding.Elements == nil || len(binding.Elements.Nodes) == 0 {
     return
   }
-  first := binding.Elements.Nodes[0].AsBindingElement()
+  firstNode := binding.Elements.Nodes[0]
+  if firstNode == nil || firstNode.Kind != shimast.KindBindingElement {
+    return
+  }
+  first := firstNode.AsBindingElement()
   if first == nil {
     return
   }
@@ -464,7 +465,7 @@ func (s *solidState) reportPreferClassList(ctx *Context) {
       continue
     }
     expr := solidJSXAttrExpression(attr)
-    if expr == nil {
+    if expr == nil || expr.Kind != shimast.KindCallExpression {
       continue
     }
     call := expr.AsCallExpression()
@@ -565,6 +566,9 @@ func (s *solidState) reportStyleProp(ctx *Context) {
       continue
     }
     for _, propNode := range obj.Properties.Nodes {
+      if propNode == nil || propNode.Kind != shimast.KindPropertyAssignment {
+        continue
+      }
       prop := propNode.AsPropertyAssignment()
       if prop == nil {
         continue
@@ -731,6 +735,9 @@ func collectSolidBindingNames(node *shimast.Node, out map[string]bool) {
       return
     }
     for _, elementNode := range pattern.Elements.Nodes {
+      if elementNode == nil || elementNode.Kind != shimast.KindBindingElement {
+        continue
+      }
       el := elementNode.AsBindingElement()
       if el != nil {
         collectSolidBindingNames(el.Name(), out)
@@ -1052,7 +1059,6 @@ func init() {
     "jsx-no-duplicate-props",
     "jsx-no-script-url",
     "jsx-no-undef",
-    "jsx-uses-vars",
     "no-array-handlers",
     "no-destructure",
     "no-innerhtml",

package/linthost/rules_storybook.go

@@ -215,7 +215,7 @@ func (storybookNoTitlePropertyInMeta) Check(ctx *Context, node *shimast.Node) {
   }
 }
 
-type storybookNoUninstalledAddons struct{}
+type storybookNoUninstalledAddons struct{ optionsRule }
 
 type storybookNoUninstalledAddonsOptions struct {
   PackageJSONLocation string   `json:"packageJsonLocation"`