@tt-a1i/openpi 0.4.0 → 0.5.0

package/extensions/workflows/dashboard.ts

@@ -18,15 +18,10 @@ import {
   getAgentDir,
   type KeybindingsManager,
 } from "@earendil-works/pi-coding-agent";
-import {
-  Key,
-  matchesKey,
-  type TUI,
-  truncateToWidth,
-  wrapTextWithAnsi,
-} from "@earendil-works/pi-tui";
-import { contextPercent } from "../shared/context-utilization.ts";
+import { type TUI, truncateToWidth } from "@earendil-works/pi-tui";
+import { AgentSessionPage } from "../shared/agent-session-page.ts";
 import { fitNavigationSides } from "../shared/below-editor-navigation.ts";
+import { contextPercent } from "../shared/context-utilization.ts";
 import {
   panelFrame,
   type ScreenHint,
@@ -68,10 +63,10 @@ import {
   workflowGraphRecords,
 } from "./model.ts";
 import { writeFileAtomic } from "./serialization.ts";
+import { WorkflowTranscriptAdapter } from "./transcript.ts";
 
 const NOTICE_TTL_MS = 4000;
 const MIN_HEIGHT = 10;
-const TRANSCRIPT_SCROLL_STEP = 20;
 
 function wrapSelection(index: number, delta: number, length: number): number {
   if (length === 0) return 0;
@@ -261,6 +256,10 @@ function normalizeTranscript(value: unknown): TranscriptEntry[] {
         typeof entry.name === "string"
           ? sanitizeLine(entry.name, 160) || undefined
           : undefined,
+      toolCallId:
+        typeof entry.toolCallId === "string"
+          ? sanitizeLine(entry.toolCallId, 1_024) || undefined
+          : undefined,
       isError: entry.isError === true,
       timestamp:
         typeof entry.timestamp === "number" ? entry.timestamp : undefined,
@@ -269,6 +268,35 @@ function normalizeTranscript(value: unknown): TranscriptEntry[] {
   return transcript;
 }
 
+function normalizeAgentState(value: unknown): AgentRecord["state"] {
+  switch (value) {
+    case "done":
+    case "completed":
+      return "done";
+    case "error":
+    case "failed":
+      return "error";
+    case "running":
+    case "uncertain":
+      return value;
+    default:
+      return "uncertain";
+  }
+}
+
+function normalizeWorkflowStatus(value: unknown): WorkflowDetails["status"] {
+  switch (value) {
+    case "running":
+    case "completed":
+    case "failed":
+    case "aborted":
+    case "uncertain":
+      return value;
+    default:
+      return "uncertain";
+  }
+}
+
 /** Leniently normalize a workflow.json (including runs from older tooling). */
 export function normalizePersistedWorkflowDetails(
   runId: string,
@@ -284,14 +312,7 @@ export function normalizePersistedWorkflowDetails(
   for (const item of rawAgents) {
     if (!item || typeof item !== "object") continue;
     const a = item as Record<string, unknown>;
-    const state =
-      a.state === "error" || a.state === "failed"
-        ? "error"
-        : a.state === "uncertain"
-          ? "uncertain"
-          : a.state === "running"
-            ? "running"
-            : "done";
+    const state = normalizeAgentState(a.state);
     const index = typeof a.index === "number" ? a.index : agents.length + 1;
     const decodedInvocation = decodeInvocationRecord(a.invocation);
     const invocation =
@@ -407,16 +428,23 @@ export function normalizePersistedWorkflowDetails(
     logs.push({
       at: typeof entry.at === "number" ? entry.at : startedAt,
       text: sanitizeLine(entry.text, MAX_LOG_TEXT),
+      ...(entry.kind === "pipeline-drop"
+        ? { kind: "pipeline-drop" as const }
+        : {}),
     });
   }
 
-  const status =
-    record.status === "running" ||
-    record.status === "failed" ||
-    record.status === "aborted" ||
-    record.status === "uncertain"
-      ? record.status
-      : "completed";
+  let status = normalizeWorkflowStatus(record.status);
+  if (status !== "running") {
+    for (const agent of agents) {
+      if (agent.state !== "running" && agent.state !== "uncertain") continue;
+      status = "uncertain";
+      agent.state = "uncertain";
+      agent.error =
+        agent.error ??
+        "Persisted terminal workflow contained an agent without terminal evidence";
+    }
+  }
 
   return {
     runId,
@@ -541,22 +569,31 @@ export function loadRunEntries(
   referencedRunIds: ReadonlySet<string>,
   /** Hide runs untouched by the current request; live runs always show. */
   startedSince = 0,
+  /** Bounded settled projections used only if canonical disk state is unreadable. */
+  retained: ReadonlyMap<string, WorkflowDetails> = new Map(),
 ): RunEntry[] {
   const entries: RunEntry[] = [];
-  for (const runId of listPersistedRunIds()) {
+  const runIds = new Set([...listPersistedRunIds(), ...retained.keys()]);
+  for (const runId of runIds) {
     const live = active.get(runId);
     if (live) {
       entries.push({ runId, details: live, live: true });
       continue;
     }
-    const details = readPersistedWorkflowDetails(runId, {
+    const persisted = readPersistedWorkflowDetails(runId, {
       hydrateArtifacts: true,
     });
+    const retainedDetails = retained.get(runId);
+    const details = persisted ?? retainedDetails;
     if (!details) continue;
+    const fromRetention =
+      persisted === undefined && retainedDetails !== undefined;
     const touchedAt = Math.max(details.startedAt, details.finishedAt ?? 0);
     if (
       touchedAt < startedSince ||
-      (details.sessionId !== sessionId && !referencedRunIds.has(runId))
+      (!fromRetention &&
+        details.sessionId !== sessionId &&
+        !referencedRunIds.has(runId))
     ) {
       continue;
     }
@@ -677,24 +714,24 @@ export class WorkflowDashboard {
   private phaseIndex = 0;
   private agentIndex = 0;
   private detailFocus: DetailFocus = "phases";
-  private transcriptScroll = 0;
-  private transcriptRowCount = 0;
-  private transcriptViewportSize = 1;
+  private transcriptPage?: AgentSessionPage;
   private current?: RunEntry;
   private openedDirectly = false;
   private notice?: string;
   private noticeAt = 0;
   private disposed = false;
-  private timer: ReturnType<typeof setInterval>;
+  private timer?: ReturnType<typeof setInterval>;
   private tui: TUI;
   private theme: Theme;
   private keybindings: KeybindingsManager;
   private getActive: () => Map<string, WorkflowDetails>;
+  private getRetained: () => ReadonlyMap<string, WorkflowDetails>;
   private sessionId: string;
   private referencedRunIds: ReadonlySet<string>;
   private startedSince: number;
   private close: () => void;
   private onAbort?: (runId: string) => boolean;
+  private initialToolsExpanded: boolean;
 
   constructor(
     tui: TUI,
@@ -707,16 +744,20 @@ export class WorkflowDashboard {
     close: () => void,
     initialRunId?: string,
     onAbort?: (runId: string) => boolean,
+    getRetained: () => ReadonlyMap<string, WorkflowDetails> = () => new Map(),
+    initialToolsExpanded = false,
   ) {
     this.tui = tui;
     this.theme = theme;
     this.keybindings = keybindings;
     this.getActive = getActive;
+    this.getRetained = getRetained;
     this.sessionId = sessionId;
     this.referencedRunIds = referencedRunIds;
     this.startedSince = startedSince;
     this.close = close;
     this.onAbort = onAbort;
+    this.initialToolsExpanded = initialToolsExpanded;
     this.refresh();
     if (initialRunId) {
       const resolution = resolveWorkflowRunTarget(
@@ -736,25 +777,44 @@ export class WorkflowDashboard {
         this.noticeAt = Date.now();
       }
     }
+    this.refreshTimer();
+  }
+
+  private refreshTimer() {
+    const active = Boolean(
+      this.notice ||
+        (this.view === "list"
+          ? this.entries.some(
+              (entry) => entry.live && entry.details.status === "running",
+            )
+          : this.view === "detail"
+            ? this.current?.live && this.current.details.status === "running"
+            : this.current?.live && this.selectedAgent()?.state === "running"),
+    );
+    if (!active) {
+      if (this.timer) clearInterval(this.timer);
+      this.timer = undefined;
+      return;
+    }
+    if (this.timer) return;
     this.timer = setInterval(() => {
-      if (
-        this.entries.some((e) => e.live) ||
-        this.current?.live ||
-        this.notice
-      ) {
-        this.refresh();
-        this.tui.requestRender();
-      }
+      this.refresh();
+      this.tui.requestRender();
+      this.refreshTimer();
     }, SPINNER_INTERVAL_MS);
   }
 
   dispose() {
     if (this.disposed) return;
     this.disposed = true;
-    clearInterval(this.timer);
+    if (this.timer) clearInterval(this.timer);
+    this.timer = undefined;
+    this.transcriptPage = undefined;
   }
 
-  invalidate() {}
+  invalidate() {
+    this.transcriptPage?.invalidate();
+  }
 
   private refresh() {
     const selected = this.entries[this.listIndex]?.runId;
@@ -763,6 +823,7 @@ export class WorkflowDashboard {
       this.sessionId,
       this.referencedRunIds,
       this.startedSince,
+      this.getRetained(),
     );
     if (selected) {
       const index = this.entries.findIndex((e) => e.runId === selected);
@@ -819,11 +880,12 @@ export class WorkflowDashboard {
     const target = path.join(runsDir(), entry.runId, "report.md");
     try {
       writeFileAtomic(target, buildWorkflowReport(entry.details));
-      this.notice = `saved ${shortenHome(target)}`;
+      this.setNotice(`saved ${shortenHome(target)}`);
     } catch (error) {
-      this.notice = `save failed: ${error instanceof Error ? error.message : String(error)}`;
+      this.setNotice(
+        `save failed: ${error instanceof Error ? error.message : String(error)}`,
+      );
     }
-    this.noticeAt = Date.now();
   }
 
   /** Request cancellation of a run by id, surfacing the outcome as a notice. */
@@ -842,6 +904,7 @@ export class WorkflowDashboard {
   private setNotice(text: string) {
     this.notice = text;
     this.noticeAt = Date.now();
+    this.refreshTimer();
   }
 
   handleInput(data: string) {
@@ -923,57 +986,27 @@ export class WorkflowDashboard {
         } else if (left || cancel) {
           this.detailFocus = "phases";
         } else if ((right || confirm) && this.selectedAgent()) {
-          this.transcriptScroll = 0;
-          this.view = "transcript";
+          this.openTranscriptPage();
         }
       }
       if (data === "s") this.saveReport();
       if (data === "x") this.abortRun(this.current);
     } else {
-      const maxScroll = Math.max(
-        0,
-        this.transcriptRowCount - this.transcriptViewportSize,
-      );
-      const scrollStep =
-        data === "j" || data === "k" ? TRANSCRIPT_SCROLL_STEP : 1;
-      const pageStep = Math.max(1, this.transcriptViewportSize - 2);
-      if (up) {
-        this.transcriptScroll = Math.max(0, this.transcriptScroll - scrollStep);
-      } else if (down) {
-        this.transcriptScroll = Math.min(
-          maxScroll,
-          this.transcriptScroll + scrollStep,
-        );
-      } else if (matchesKey(data, Key.ctrl("u"))) {
-        this.transcriptScroll = Math.max(0, this.transcriptScroll - pageStep);
-      } else if (matchesKey(data, Key.ctrl("d"))) {
-        this.transcriptScroll = Math.min(
-          maxScroll,
-          this.transcriptScroll + pageStep,
-        );
-      } else if (data === "g") {
-        this.transcriptScroll = 0;
-      } else if (data === "G") {
-        this.transcriptScroll = maxScroll;
-      } else if (cancel || left) {
-        this.view = "detail";
-        this.detailFocus = "agents";
-      }
+      this.transcriptPage?.handleInput(data);
+      this.refreshTimer();
+      return;
     }
+    this.refreshTimer();
     this.tui.requestRender();
   }
 
   render(width: number): string[] {
+    if (this.view === "transcript" && this.transcriptPage) {
+      return this.transcriptPage.render(width);
+    }
     const height = Math.max(MIN_HEIGHT, this.tui.terminal.rows - 1);
     let lines: string[];
-    if (this.view === "transcript" && this.current && this.selectedAgent()) {
-      lines = this.renderTranscript(
-        this.current.details,
-        this.selectedAgent()!,
-        width,
-        height,
-      );
-    } else if (this.view === "detail" && this.current) {
+    if (this.view === "detail" && this.current) {
       lines = this.renderDetail(this.current.details, width, height);
     } else {
       lines = this.renderList(width, height);
@@ -981,6 +1014,53 @@ export class WorkflowDashboard {
     return lines.map((line) => truncateToWidth(line, width, ""));
   }
 
+  private openTranscriptPage() {
+    const transcriptAdapter = new WorkflowTranscriptAdapter();
+    this.view = "transcript";
+    this.transcriptPage = new AgentSessionPage(
+      this.tui,
+      this.theme,
+      this.keybindings,
+      {
+        getState: () => {
+          const details = this.current?.details;
+          const agent = this.selectedAgent();
+          if (!details || !agent) return undefined;
+          return {
+            id: agent.callId ?? `agent-${agent.index}`,
+            title: agent.label,
+            status: agent.state,
+            document: transcriptAdapter.document(
+              agent.transcript,
+              agent.worktreePath,
+            ),
+            metadata: [
+              `${details.name ?? details.runId} · ${agent.phase ?? "unphased"}`,
+              agent.model,
+              agentContext(agent),
+              agent.acceptance
+                ? `acceptance:${agent.acceptance.status}`
+                : undefined,
+              formatElapsed(agent.startedAt, agent.finishedAt),
+            ],
+            errorText: agent.error,
+            emptyText:
+              "transcript unavailable (this run predates transcript capture)",
+          };
+        },
+        close: () => {
+          this.transcriptPage = undefined;
+          this.view = "detail";
+          this.detailFocus = "agents";
+          this.refreshTimer();
+          this.tui.requestRender();
+        },
+      },
+      { toolsExpanded: this.initialToolsExpanded },
+    );
+    this.tui.requestRender();
+  }
+
   /** Bordered panel with a title in the top border, padded to exact height. */
   private panel(
     title: string,
@@ -1313,117 +1393,6 @@ export class WorkflowDashboard {
     lines.push(this.hintLine(hints, width));
     return lines;
   }
-
-  private transcriptRows(agent: AgentRecord, width: number): string[] {
-    const theme = this.theme;
-    const rows: string[] = [];
-    if (agent.transcript.length === 0) {
-      return [
-        theme.fg(
-          "dim",
-          " transcript unavailable (this run predates transcript capture)",
-        ),
-      ];
-    }
-
-    for (const entry of agent.transcript) {
-      // Tool calls are one-liners: the arrow shows direction, the accent name
-      // says what ran, and the arguments collapse to a single compact line
-      // instead of a vertical JSON block.
-      if (entry.role === "tool") {
-        const name = entry.name ? sanitizeLine(entry.name, 160) : "unknown";
-        const args = compactInlineJson(entry.text);
-        rows.push(
-          ` ${theme.fg("muted", "→")} ${theme.fg("accent", name)}${args ? theme.fg("dim", ` ${args}`) : ""}`,
-        );
-        continue;
-      }
-      const label = transcriptLabel(entry);
-      const color = transcriptColor(entry);
-      const marker = entry.role === "toolResult" ? "←" : "●";
-      rows.push(
-        ` ${theme.fg(color, marker)} ${theme.bold(theme.fg(color, label))}`,
-      );
-      const contentWidth = Math.max(8, width - 4);
-      const styled = theme.fg(
-        entry.role === "thinking" || entry.role === "toolResult"
-          ? "dim"
-          : entry.isError
-            ? "error"
-            : "text",
-        sanitizeTerminalText(entry.text),
-      );
-      for (const line of wrapTextWithAnsi(styled, contentWidth)) {
-        rows.push(`   ${line}`);
-      }
-      rows.push("");
-    }
-    return rows;
-  }
-
-  private renderTranscript(
-    details: WorkflowDetails,
-    agent: AgentRecord,
-    width: number,
-    height: number,
-  ): string[] {
-    const theme = this.theme;
-    const lines: string[] = [];
-    const right = theme.fg(
-      "dim",
-      [
-        agent.model,
-        agentContext(agent),
-        agent.acceptance ? `acceptance:${agent.acceptance.status}` : undefined,
-        formatElapsed(agent.startedAt, agent.finishedAt),
-      ]
-        .filter(Boolean)
-        .join(" · ") + " ",
-    );
-    lines.push(
-      fitNavigationSides(
-        ` ${stateGlyph(agent.state, theme, Date.now())} ${theme.bold(theme.fg("accent", agent.label))}`,
-        right,
-        width,
-      ),
-    );
-    lines.push(
-      fitNavigationSides(
-        ` ${theme.fg("muted", `${details.name ?? details.runId} · ${agent.phase ?? "unphased"}`)}`,
-        theme.fg("dim", `${agent.transcript.length} entries `),
-        width,
-      ),
-    );
-
-    const panelHeight = height - 3;
-    const bodyHeight = Math.max(1, panelHeight - 2);
-    const rows = this.transcriptRows(agent, width - 2);
-    this.transcriptRowCount = rows.length;
-    this.transcriptViewportSize = bodyHeight;
-    const maxScroll = Math.max(0, rows.length - bodyHeight);
-    this.transcriptScroll = Math.min(this.transcriptScroll, maxScroll);
-    const visible = rows.slice(
-      this.transcriptScroll,
-      this.transcriptScroll + bodyHeight,
-    );
-    const position =
-      rows.length > bodyHeight
-        ? `Transcript · ${this.transcriptScroll + 1}-${Math.min(rows.length, this.transcriptScroll + bodyHeight)}/${rows.length}`
-        : "Transcript";
-    lines.push(...this.panel(position, visible, width, panelHeight));
-    lines.push(
-      this.hintLine(
-        [
-          ["j/k", "scroll"],
-          ["ctrl-u/d", "page"],
-          ["g/G", "top/bottom"],
-          ["h/left/esc", "back"],
-        ],
-        width,
-      ),
-    );
-    return lines;
-  }
 }
 
 /**
@@ -1438,39 +1407,6 @@ function displayError(error: string) {
   return clean;
 }
 
-function transcriptLabel(entry: TranscriptEntry): string {
-  if (entry.role === "user") return "user";
-  if (entry.role === "assistant") return "assistant";
-  if (entry.role === "thinking") return "thinking";
-  const name = entry.name ? sanitizeLine(entry.name, 160) : "unknown";
-  return name;
-}
-
-/**
- * Tool arguments arrive pretty-printed over many lines; the transcript shows
- * them inline. Non-JSON text passes through flattened.
- */
-function compactInlineJson(text: string) {
-  const flat = sanitizeTerminalText(text).trim();
-  if (!flat) return "";
-  try {
-    return JSON.stringify(JSON.parse(flat));
-  } catch {
-    return flat.replace(/\s+/g, " ");
-  }
-}
-
-function transcriptColor(
-  entry: TranscriptEntry,
-): "accent" | "success" | "dim" | "warning" | "error" | "muted" {
-  if (entry.isError) return "error";
-  if (entry.role === "user") return "accent";
-  if (entry.role === "assistant") return "success";
-  if (entry.role === "thinking") return "dim";
-  if (entry.role === "tool") return "warning";
-  return "muted";
-}
-
 function groupGlyph(group: PhaseGroup, theme: Theme) {
   if (group.agents.length === 0) return theme.fg("dim", "○");
   if (group.agents.some((a) => a.state === "running"))
@@ -1489,6 +1425,7 @@ export async function showWorkflowDashboard(
   initialRunId?: string,
   startedSince = 0,
   onAbort?: (runId: string) => boolean,
+  getRetained?: () => ReadonlyMap<string, WorkflowDetails>,
 ) {
   await ctx.ui.custom<void>(
     (tui, theme, keybindings, done) => {
@@ -1506,12 +1443,14 @@ export async function showWorkflowDashboard(
         },
         initialRunId,
         onAbort,
+        getRetained,
+        ctx.ui.getToolsExpanded(),
       );
       return dashboard;
     },
     {
       overlay: true,
-      overlayOptions: { anchor: "center", width: "100%", maxHeight: "100%" },
+      overlayOptions: { anchor: "top-left", width: "100%", maxHeight: "100%" },
     },
   );
 }