@tt-a1i/openpi 0.3.1 → 0.5.0

package/extensions/shared/screen-chrome.ts

@@ -0,0 +1,133 @@
+import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
+import { truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
+
+/**
+ * Only the two paint calls this chrome makes, following the footer's precedent:
+ * views that carry a narrowed theme object can use it without a cast.
+ */
+type Theme = Pick<ExtensionContext["ui"]["theme"], "fg" | "bold">;
+
+/**
+ * Some labels arrive already styled (a task census colours each state). Painting
+ * a colour over them would apply only up to their first inner reset, leaving the
+ * rest a different shade than the caller asked for, so pre-styled text is passed
+ * through untouched.
+ */
+const isStyled = (text: string) => text.includes("\u001b");
+
+/**
+ * The chrome every full-screen OpenPI view shares: a title line, one bordered
+ * panel, a hint line, and one way to say "there is more above/below".
+ *
+ * Three views had grown their own copy of this (`/subagents`, `/ps`,
+ * `/workflows`), and they had drifted apart in the details you notice without
+ * being able to name: one framed the body in `border`, another in
+ * `borderMuted`; one wrote `... 3 more` and another `… 3 more`; hints were a
+ * single dim run in which the keys you are supposed to press read exactly as
+ * faint as the prose describing them. Fixing that in one place is also the only
+ * way it stays fixed.
+ */
+
+/** Title left, quiet census right, with the same one-column inset as the panel. */
+export function screenTitleLine(
+  theme: Theme,
+  title: string,
+  meta: string,
+  width: number,
+) {
+  const left = ` ${theme.bold(theme.fg("accent", title))}`;
+  const right = meta ? `${isStyled(meta) ? meta : theme.fg("dim", meta)} ` : "";
+  const rightWidth = visibleWidth(right);
+  const fittedLeft = truncateToWidth(
+    left,
+    Math.max(0, width - rightWidth - 1),
+    "…",
+  );
+  const pad = Math.max(1, width - visibleWidth(fittedLeft) - rightWidth);
+  return truncateToWidth(fittedLeft + " ".repeat(pad) + right, width, "");
+}
+
+/**
+ * Bordered panel with an optional label set into the top edge, padded to an
+ * exact height so a view's overlay never changes size as content streams in.
+ */
+export function panelFrame(
+  theme: Theme,
+  options: {
+    label?: string;
+    rows: readonly string[];
+    width: number;
+    height: number;
+  },
+) {
+  const { label = "", rows, width, height } = options;
+  const inner = Math.max(0, width - 2);
+  const border = (text: string) => theme.fg("borderMuted", text);
+  // The label rides the border rather than sitting above it, so it reads as
+  // this panel's name instead of competing with the screen title.
+  const clippedLabel = label
+    ? truncateToWidth(` ${label} `, Math.max(0, inner - 2))
+    : "";
+  const labelText = clippedLabel
+    ? isStyled(clippedLabel)
+      ? clippedLabel
+      : theme.fg("muted", clippedLabel)
+    : "";
+  const dashes = Math.max(0, inner - visibleWidth(labelText) - 1);
+  const lines = [border("╭─") + labelText + border("─".repeat(dashes) + "╮")];
+  const bodyHeight = Math.max(0, height - 2);
+  for (let index = 0; index < bodyHeight; index += 1) {
+    const clipped = truncateToWidth(rows[index] ?? "", inner, "…");
+    const pad = Math.max(0, inner - visibleWidth(clipped));
+    lines.push(border("│") + clipped + " ".repeat(pad) + border("│"));
+  }
+  lines.push(border("╰" + "─".repeat(inner) + "╯"));
+  return lines;
+}
+
+/** One `keys label` pair of a hint line. */
+export type ScreenHint = readonly [keys: string, label: string];
+
+/**
+ * Keys read one step brighter than what they do, so the line scans as a
+ * keyboard legend instead of a sentence. A notice takes the whole line when
+ * there is one: it is the answer to what you just pressed, and the legend can
+ * wait a beat.
+ */
+export function hintLine(
+  theme: Theme,
+  hints: readonly (ScreenHint | undefined)[],
+  width: number,
+  notice?: string,
+) {
+  if (notice) {
+    return truncateToWidth(theme.fg("accent", ` ${notice}`), width, "…");
+  }
+  const parts = hints
+    .filter((hint): hint is ScreenHint => Boolean(hint))
+    .map(([keys, label]) => {
+      // An empty key slot is a plain status segment (a scroll position, say);
+      // an empty label is a bare key. Both stay dimmer than a real key.
+      if (!keys) return theme.fg("dim", label);
+      if (!label) return theme.fg("muted", keys);
+      return `${theme.fg("muted", keys)} ${theme.fg("dim", label)}`;
+    });
+  return truncateToWidth(
+    ` ${parts.join(theme.fg("dim", " · "))}`,
+    width,
+    theme.fg("dim", "…"),
+  );
+}
+
+/** Single vocabulary for a clipped list: `… 3 more agents`. */
+export function overflowNote(
+  theme: Theme,
+  count: number,
+  width: number,
+  noun = "",
+) {
+  return truncateToWidth(
+    theme.fg("dim", `   … ${count} more${noun ? ` ${noun}` : ""}`),
+    width,
+  );
+}

package/extensions/shared/setup-config.ts

@@ -69,7 +69,28 @@ export type CapabilityDiscoveryMode =
 
 /** Canonical default layout: one-line plain footer with flex alignment. */
 export const DEFAULT_FOOTER_LINES: FooterLines = [
-  ["cwd", "git", "pr", "flex", "model", "context", "cost"],
+  ["model", "context", "flex", "git", "pr", "cwd"],
+];
+
+/** Stable skeleton for the legacy flat-selection adapter. */
+const FLAT_FOOTER_ITEM_LINES: FooterLines = [
+  [
+    "model",
+    "thinking",
+    "context",
+    "cache",
+    "cost",
+    "throughput",
+    "flex",
+    "git",
+    "pr",
+    "cwd",
+  ],
+];
+
+/** The persisted canonical default before model/context moved to the left. */
+const LEGACY_DEFAULT_FOOTER_LINES: FooterLines = [
+  ["cwd", "git", "pr", "flex", "model", "context"],
 ];
 
 export const DEFAULT_FOOTER_STYLE: FooterStyle = "plain";
@@ -88,7 +109,7 @@ export const FOOTER_PRESET_DEFINITIONS: Record<
 > = {
   compact: {
     style: "plain",
-    lines: [["cwd", "model", "thinking", "context", "flex", "git", "pr"]],
+    lines: DEFAULT_FOOTER_LINES,
   },
   powerline: {
     style: "powerline",
@@ -131,9 +152,7 @@ export interface MyPiSetupConfig {
     readonly showHeader: boolean;
     readonly customFooter: boolean;
     readonly footerStyle: FooterStyle;
-    /** Canonical footer layout. `footerItems` is always derived from this. */
     readonly footerLines: FooterLines;
-    readonly footerItems: readonly FooterItem[];
     readonly subagentResultDisplay: DetailDisplay;
     readonly bashToolDisplay: DetailDisplay;
     readonly fileMutationDisplay: DetailDisplay;
@@ -164,8 +183,7 @@ export const DEFAULT_SETUP_CONFIG: MyPiSetupConfig = {
     customFooter: true,
     footerStyle: DEFAULT_FOOTER_STYLE,
     footerLines: DEFAULT_FOOTER_LINES,
-    footerItems: DEFAULT_FOOTER_ITEMS,
-    subagentResultDisplay: "full",
+    subagentResultDisplay: "compact",
     bashToolDisplay: "compact",
     fileMutationDisplay: "compact",
   },
@@ -256,13 +274,13 @@ export function normalizeFooterLines(value: unknown): FooterLines {
   return lines.length > 0 ? lines : DEFAULT_FOOTER_LINES;
 }
 
-/** Map a flat item list onto the default one-line skeleton (legacy compat). */
+/** Map a flat item list onto the stable one-line skeleton (legacy compat). */
 export function footerLinesFromItems(
   items: readonly FooterItem[],
 ): FooterLines {
   const selected = new Set(items);
   return normalizeFooterLines(
-    DEFAULT_FOOTER_LINES.map((line) =>
+    FLAT_FOOTER_ITEM_LINES.map((line) =>
       line.filter((item) => item === "flex" || selected.has(item)),
     ),
   );
@@ -330,7 +348,6 @@ export function applyFooterConfig(
   return {
     footerStyle: style,
     footerLines: normalized,
-    footerItems: flattenFooterItems(normalized),
   };
 }
 
@@ -340,19 +357,32 @@ function parseFooterItems(value: unknown): readonly FooterItem[] {
   return items.length > 0 ? items : DEFAULT_FOOTER_ITEMS;
 }
 
+function sameFooterLines(left: FooterLines, right: FooterLines) {
+  return (
+    left.length === right.length &&
+    left.every(
+      (line, lineIndex) =>
+        line.length === right[lineIndex]?.length &&
+        line.every((item, itemIndex) => item === right[lineIndex]?.[itemIndex]),
+    )
+  );
+}
+
 function parseUiFooter(
   ui: Record<string, unknown>,
-): Pick<MyPiSetupConfig["ui"], "footerStyle" | "footerLines" | "footerItems"> {
+): Pick<MyPiSetupConfig["ui"], "footerStyle" | "footerLines"> {
   const style = isFooterStyle(ui.footerStyle)
     ? ui.footerStyle
     : DEFAULT_FOOTER_STYLE;
 
   if (ui.footerLines !== undefined) {
-    const lines = normalizeFooterLines(ui.footerLines);
+    const normalized = normalizeFooterLines(ui.footerLines);
+    const lines = sameFooterLines(normalized, LEGACY_DEFAULT_FOOTER_LINES)
+      ? DEFAULT_FOOTER_LINES
+      : normalized;
     return {
       footerStyle: style,
       footerLines: lines,
-      footerItems: flattenFooterItems(lines),
     };
   }
 
@@ -363,14 +393,12 @@ function parseUiFooter(
     return {
       footerStyle: style,
       footerLines: lines,
-      footerItems: flattenFooterItems(lines),
     };
   }
 
   return {
     footerStyle: style,
     footerLines: DEFAULT_FOOTER_LINES,
-    footerItems: DEFAULT_FOOTER_ITEMS,
   };
 }
 
@@ -465,7 +493,7 @@ export function parseSetupConfig(value: unknown): MyPiSetupConfig {
         ui.subagentResultDisplay as DetailDisplay,
       )
         ? (ui.subagentResultDisplay as DetailDisplay)
-        : "full",
+        : "compact",
       bashToolDisplay: DETAIL_DISPLAYS.includes(
         ui.bashToolDisplay as DetailDisplay,
       )
@@ -485,9 +513,9 @@ export function parseSetupConfig(value: unknown): MyPiSetupConfig {
 /** An empty or invalid value disables the post-edit command (the safe default). */
 function parsePostEditCommand(value: unknown) {
   if (!isRecord(value)) return "";
-  return typeof value.command === "string"
-    ? value.command.trim().slice(0, POST_EDIT_COMMAND_MAX_CHARS)
-    : "";
+  if (typeof value.command !== "string") return "";
+  const command = value.command.trim();
+  return command.length <= POST_EDIT_COMMAND_MAX_CHARS ? command : "";
 }
 
 export function hasSavedSetupConfig() {
@@ -542,6 +570,9 @@ function replacedFields(
   ) {
     paths.push("summaries → suggestions");
   }
+  if (path === "ui" && "footerItems" in raw && "footerLines" in normalized) {
+    paths.push("ui.footerItems");
+  }
   for (const [key, value] of Object.entries(normalized)) {
     if (!(key in raw)) continue;
     const here = path ? `${path}.${key}` : key;
@@ -608,24 +639,55 @@ const sameOwner = (left: LockOwner, right: LockOwner) =>
 const sameFile = (left: Stats, right: Stats) =>
   left.dev === right.dev && left.ino === right.ino;
 
+const parsePowerShellProcessStartedAt = (stdout: string) => {
+  const startedAt = Number(stdout.trim());
+  return isPositiveInteger(startedAt) ? startedAt : undefined;
+};
+
+const parsePsProcessStartedAt = (stdout: string) => {
+  const startedAt = Date.parse(stdout.trim());
+  return Number.isFinite(startedAt) ? startedAt : undefined;
+};
+
+export function processStartedAtQuery(
+  pid: number,
+  platform = process.platform,
+) {
+  if (platform === "win32") {
+    const script = [
+      "$ErrorActionPreference='Stop'",
+      `$p=Get-Process -Id ${pid}`,
+      "[Console]::Out.Write(([DateTimeOffset]$p.StartTime).ToUnixTimeMilliseconds())",
+    ].join("; ");
+    return {
+      command: "powershell.exe",
+      args: ["-NoProfile", "-NonInteractive", "-Command", script],
+      env: undefined,
+      parseOutput: parsePowerShellProcessStartedAt,
+    };
+  }
+  return {
+    command: "ps",
+    args: ["-o", "lstart=", "-p", String(pid)],
+    env: { LC_ALL: "C" },
+    parseOutput: parsePsProcessStartedAt,
+  };
+}
+
 const queryProcessStartedAt = (pid: number) =>
   new Promise<number | undefined>((resolve) => {
-    if (process.platform === "win32") {
-      resolve(undefined);
-      return;
-    }
+    const query = processStartedAtQuery(pid);
     try {
       execFile(
-        "ps",
-        ["-o", "lstart=", "-p", String(pid)],
+        query.command,
+        query.args,
         {
           encoding: "utf8",
-          env: { ...process.env, LC_ALL: "C" },
+          env: query.env ? { ...process.env, ...query.env } : process.env,
           timeout: 1_000,
         },
         (error, stdout) => {
-          const startedAt = error ? Number.NaN : Date.parse(stdout.trim());
-          resolve(Number.isFinite(startedAt) ? startedAt : undefined);
+          resolve(error ? undefined : query.parseOutput(stdout));
         },
       );
     } catch {
@@ -919,13 +981,15 @@ async function withSetupConfigLock<A>(action: () => Promise<A>) {
 }
 
 async function writeSetupConfig(config: MyPiSetupConfig) {
+  const canonical = parseSetupConfig(config);
   const tempPath = `${SETUP_CONFIG_PATH}.${process.pid}.${randomUUID()}.tmp`;
   try {
-    await writeFile(tempPath, `${JSON.stringify(config, null, 2)}\n`, {
+    await writeFile(tempPath, `${JSON.stringify(canonical, null, 2)}\n`, {
       encoding: "utf8",
       mode: 0o600,
     });
     await rename(tempPath, SETUP_CONFIG_PATH);
+    return canonical;
   } catch (error) {
     await unlink(tempPath).catch(() => undefined);
     throw error;
@@ -939,10 +1003,7 @@ export async function saveSetupConfig(config: MyPiSetupConfig) {
   });
 }
 
-export function formatSetupConfig(
-  config = loadSetupConfig(),
-  integrationLines: readonly string[] = [],
-) {
+export function formatSetupConfig(config = loadSetupConfig()) {
   const suggestionModel = config.suggestions.model;
   const suggestions =
     !config.suggestions.enabled || !suggestionModel
@@ -957,11 +1018,10 @@ export function formatSetupConfig(
     `Workflows: ${config.workflows.concurrency} concurrent agents · ${config.workflows.maxAgentCalls} total calls`,
     `UI: large header ${config.ui.showHeader ? "on" : "off"} · custom footer ${footer}`,
     `Subagent results: ${config.ui.subagentResultDisplay === "full" ? "full by default" : "compact status summary (Ctrl+O expands full output)"}`,
-    `Bash operations: ${config.ui.bashToolDisplay === "full" ? "expanded by default" : "folded preview (Ctrl+O expands all)"}`,
-    `Write/Edit operations: ${config.ui.fileMutationDisplay === "full" ? "expanded by default" : "folded preview (Ctrl+O expands all)"}`,
-    `Post-edit command: ${config.postEdit.command ? config.postEdit.command : "off"}`,
+    `Bash operations: ${config.ui.bashToolDisplay === "full" ? "expanded by default" : "one-line activity summary (Ctrl+O restores native evidence)"}`,
+    `Write/Edit operations: ${config.ui.fileMutationDisplay === "full" ? "expanded by default" : "one-line activity summary (Ctrl+O restores native evidence)"}`,
+    `Post-edit command: ${config.postEdit.command ? "configured" : "off"}`,
     `Agent role models (Subagents + Workflows): ${SUBAGENT_ROLE_NAMES.map((role) => `${role} ${config.subagents.roleModels[role] ? `${config.subagents.roleModels[role].provider}/${config.subagents.roleModels[role].model}` : "inherit"}`).join(" · ")}`,
-    ...integrationLines,
   ].join("\n");
 }
 
@@ -979,8 +1039,7 @@ export async function updateSetupConfig(
   return withSetupConfigLock(async () => {
     const raw = readDocumentForWrite();
     const current = parseSetupConfig(raw);
-    const config = mutate(current);
-    await writeSetupConfig(config);
+    const config = await writeSetupConfig(mutate(current));
     return { config, replaced: replacedFields(raw, current) };
   });
 }

package/extensions/shared/setup-episode-state.ts

@@ -2,6 +2,6 @@
 export const OPENPI_SETUP_EPISODE_CHANNEL = "openpi:setup-episode";
 
 export interface OpenPiSetupEpisodeState {
-  /** True for both armed and actively running setup episodes. */
+  /** True only while the owned setup writer is active for a delivered request. */
   readonly active: boolean;
 }

package/extensions/shared/spinner.ts

@@ -0,0 +1,28 @@
+/**
+ * One braille spinner for every running-state indicator in the package:
+ * transcripts, takeover and dashboard headers, and the below-editor strips all
+ * advance on the same cadence so concurrent views animate in step.
+ */
+
+export const SPINNER_FRAMES = [
+  "⠋",
+  "⠙",
+  "⠹",
+  "⠸",
+  "⠼",
+  "⠴",
+  "⠦",
+  "⠧",
+  "⠇",
+  "⠏",
+] as const;
+
+/** Frame cadence, shared with the dashboard and takeover headers. */
+export const SPINNER_INTERVAL_MS = 120;
+
+export function spinnerFrame(now: number) {
+  const frame = Math.floor(now / SPINNER_INTERVAL_MS) % SPINNER_FRAMES.length;
+  return SPINNER_FRAMES[
+    (frame + SPINNER_FRAMES.length) % SPINNER_FRAMES.length
+  ];
+}

package/extensions/shared/terminal-text.ts

@@ -1,35 +1,122 @@
-// OSC may end in BEL or ST. DCS/SOS/PM/APC end only in ST; treating BEL as
-// their terminator would expose the rest of a still-hidden payload. Both
-// patterns consume an unterminated string through the bounded input's end.
-// eslint-disable-next-line no-control-regex
-const OSC_PATTERN =
-  /(?:\u001b\]|\u009d)(?:[^\u0007\u001b\u009c]|\u001b(?!\\))*(?:\u0007|\u001b\\|\u009c|$)/g;
-// eslint-disable-next-line no-control-regex
-const ST_STRING_PATTERN =
-  /(?:\u001b[PX^_]|[\u0090\u0098\u009e\u009f])(?:[^\u001b\u009c]|\u001b(?!\\))*(?:\u001b\\|\u009c|$)/g;
-// eslint-disable-next-line no-control-regex
-const CSI_PATTERN = /(?:\u001b\[|\u009b)[0-?]*[ -/]*[@-~]/g;
-// Remaining two-byte/charset escape forms (for example ESC ( 0).
-// eslint-disable-next-line no-control-regex
-const ESCAPE_PATTERN = /\u001b(?:[()][0-2A-Z]|[ -/]*[@-~])/g;
 // Invisible Unicode format controls can reorder or disguise untrusted text.
 // Keep only ZWNJ/ZWJ (U+200C/U+200D), which carry legitimate shaping and emoji
 // semantics; variation selectors are marks rather than Cf and remain intact.
-const UNSAFE_FORMAT_PATTERN = /(?![\u200c\u200d])\p{Cf}/gu;
+const UNSAFE_FORMAT_CHARACTER = /\p{Cf}/u;
 // eslint-disable-next-line no-control-regex
 const TERMINAL_CONTROL_PATTERN =
   /[\u0000-\u001f\u007f-\u009f]|(?:(?![\u200c\u200d])\p{Cf})/u;
 
+type SanitizerState =
+  | "text"
+  | "escape"
+  | "escape_intermediate"
+  | "csi"
+  | "osc"
+  | "st_string";
+
+/** Stateful terminal-text projection for streams whose retained head can move. */
+export class TerminalTextSanitizer {
+  private state: SanitizerState = "text";
+  private stringEscape = false;
+
+  push(text: string) {
+    let safe = "";
+    for (const character of text) {
+      const code = character.codePointAt(0)!;
+
+      if (this.state === "osc" || this.state === "st_string") {
+        if (character === "\u009c") {
+          this.state = "text";
+          this.stringEscape = false;
+        } else if (this.state === "osc" && character === "\u0007") {
+          this.state = "text";
+          this.stringEscape = false;
+        } else if (this.stringEscape && character === "\\") {
+          this.state = "text";
+          this.stringEscape = false;
+        } else {
+          this.stringEscape = character === "\u001b";
+        }
+        continue;
+      }
+
+      if (this.state === "csi") {
+        if (code >= 0x40 && code <= 0x7e) this.state = "text";
+        else if (code < 0x20 || code > 0x3f) {
+          this.state = "text";
+          safe += this.safeCharacter(character, code);
+        }
+        continue;
+      }
+
+      if (this.state === "escape" || this.state === "escape_intermediate") {
+        if (this.state === "escape") {
+          if (character === "[") {
+            this.state = "csi";
+            continue;
+          }
+          if (character === "]") {
+            this.state = "osc";
+            continue;
+          }
+          if (
+            character === "P" ||
+            character === "X" ||
+            character === "^" ||
+            character === "_"
+          ) {
+            this.state = "st_string";
+            continue;
+          }
+        }
+        if (code >= 0x20 && code <= 0x2f) {
+          this.state = "escape_intermediate";
+        } else if (code >= 0x30 && code <= 0x7e) {
+          this.state = "text";
+        } else {
+          this.state = "text";
+          safe += this.safeCharacter(character, code);
+        }
+        continue;
+      }
+
+      if (character === "\u001b") {
+        this.state = "escape";
+      } else if (character === "\u009b") {
+        this.state = "csi";
+      } else if (character === "\u009d") {
+        this.state = "osc";
+      } else if (
+        character === "\u0090" ||
+        character === "\u0098" ||
+        character === "\u009e" ||
+        character === "\u009f"
+      ) {
+        this.state = "st_string";
+      } else {
+        safe += this.safeCharacter(character, code);
+      }
+    }
+    return safe;
+  }
+
+  private safeCharacter(character: string, code: number) {
+    if (character === "\t") return "  ";
+    if (
+      character === "\n" ||
+      character === "\u200c" ||
+      character === "\u200d"
+    ) {
+      return character;
+    }
+    if (code <= 0x1f || (code >= 0x7f && code <= 0x9f)) return "";
+    return UNSAFE_FORMAT_CHARACTER.test(character) ? "" : character;
+  }
+}
+
 /** Strip terminal control sequences and direction-spoofing format controls. */
 export function sanitizeTerminalText(text: string) {
-  return text
-    .replace(OSC_PATTERN, "")
-    .replace(ST_STRING_PATTERN, "")
-    .replace(CSI_PATTERN, "")
-    .replace(ESCAPE_PATTERN, "")
-    .replace(UNSAFE_FORMAT_PATTERN, "")
-    .replaceAll("\t", "  ")
-    .replace(/[\u0000-\u0008\u000b-\u001f\u007f-\u009f]/g, "");
+  return new TerminalTextSanitizer().push(text);
 }
 
 /** Reject raw terminal or direction-spoofing controls in display patterns. */