@tstdl/base 0.93.147 → 0.93.148

package/authentication/client/authentication.service.js

@@ -23,6 +23,7 @@ import { Logger } from '../../logger/index.js';
 import { MessageBus } from '../../message-bus/index.js';
 import { computed, signal, toObservable } from '../../signals/api.js';
 import { currentTimestampSeconds } from '../../utils/date-time.js';
+import { clamp } from '../../utils/math.js';
 import { timeout } from '../../utils/timing.js';
 import { assertDefinedPass, isDefined, isInstanceOf, isNotFunction, isNullOrUndefined, isUndefined } from '../../utils/type-guards.js';
 import { millisecondsPerMinute, millisecondsPerSecond, secondsPerHour } from '../../utils/units.js';
@@ -36,6 +37,7 @@ const impersonatorAuthenticationDataStorageKey = 'AuthenticationService:imperson
 const tokenUpdateBusName = 'AuthenticationService:tokenUpdate';
 const loggedOutBusName = 'AuthenticationService:loggedOut';
 const refreshLockResource = 'AuthenticationService:refresh';
+const minRefreshDelay = millisecondsPerMinute;
 const maxRefreshDelay = 15 * millisecondsPerMinute;
 const lockTimeout = 10_000;
 const logoutTimeout = 150;
@@ -409,14 +411,16 @@ let AuthenticationClientService = class AuthenticationClientService {
                 const now = this.estimatedServerTimestampSeconds();
                 const forceRefresh = this.forceRefreshRequested();
                 const refreshBufferSeconds = calculateRefreshBufferSeconds(token);
-                const needsRefresh = forceRefresh || (now >= (token.exp - refreshBufferSeconds));
+                // Integer comparison consistency: floor the threshold to avoid busy loops when 'now' (in seconds) is slightly below a float threshold
+                const needsRefresh = forceRefresh || (now >= Math.floor(token.exp - refreshBufferSeconds));
                 if (needsRefresh) {
                     const lockResult = await this.lock.tryUse(undefined, async () => {
                         const currentToken = this.token();
                         const currentNow = this.estimatedServerTimestampSeconds();
                         const currentRefreshBufferSeconds = isDefined(currentToken) ? calculateRefreshBufferSeconds(currentToken) : 0;
                         // Passive Sync: Check if another tab refreshed the token while we were waiting for the lock (or trying to get it)
-                        const stillNeedsRefresh = isDefined(currentToken) && (this.forceRefreshRequested() || (currentNow >= (currentToken.exp - currentRefreshBufferSeconds)));
+                        // Integer comparison consistency: floor the threshold
+                        const stillNeedsRefresh = isDefined(currentToken) && (this.forceRefreshRequested() || (currentNow >= Math.floor(currentToken.exp - currentRefreshBufferSeconds)));
                         if (stillNeedsRefresh) {
                             await this.refresh();
                         }
@@ -438,11 +442,14 @@ let AuthenticationClientService = class AuthenticationClientService {
                     }
                 }
                 const currentToken = this.token();
-                const currentRefreshBufferSeconds = isDefined(currentToken) ? calculateRefreshBufferSeconds(currentToken) : 0;
-                const delay = Math.min(maxRefreshDelay, ((currentToken?.exp ?? 0) - this.estimatedServerTimestampSeconds() - currentRefreshBufferSeconds) * millisecondsPerSecond);
+                if (isUndefined(currentToken)) {
+                    continue;
+                }
+                const currentRefreshBufferSeconds = calculateRefreshBufferSeconds(currentToken);
+                const delay = clamp((currentToken.exp - this.estimatedServerTimestampSeconds() - currentRefreshBufferSeconds) * millisecondsPerSecond, minRefreshDelay, maxRefreshDelay);
                 const wakeUpSignals = [
                     from(this.disposeSignal),
-                    this.token$.pipe(filter((t) => t?.jti != currentToken?.jti)),
+                    this.token$.pipe(filter((t) => t?.jti != currentToken.jti)),
                 ];
                 if (!forceRefresh) {
                     wakeUpSignals.push(this.forceRefreshRequested$.pipe(filter((requested) => requested)));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tstdl/base",
-  "version": "0.93.147",
+  "version": "0.93.148",
   "author": "Patrick Hein",
   "publishConfig": {
     "access": "public"
@@ -190,13 +190,13 @@
     "@types/mjml": "4.7",
     "@types/node": "25",
     "@types/nodemailer": "7.0",
-    "@types/pg": "8.16",
+    "@types/pg": "8.18",
     "@vitest/coverage-v8": "4.0",
     "@vitest/ui": "4.0",
     "concurrently": "9.2",
     "drizzle-kit": "0.31",
     "eslint": "9.39",
-    "globals": "17.3",
+    "globals": "17.4",
     "tsc-alias": "1.8",
     "typedoc-github-wiki-theme": "2.1",
     "typedoc-plugin-markdown": "4.10",