@tscircuit/schematic-trace-solver 0.0.90 → 0.0.91

package/tests/repros/assets/small-variant-resistor-facing-direction.input.json

@@ -0,0 +1,297 @@
+{
+  "chips": [
+    {
+      "chipId": "schematic_component_0",
+      "center": {
+        "x": 10,
+        "y": 14
+      },
+      "width": 2.1999999999999993,
+      "height": 3.3999999999999986,
+      "pins": [
+        {
+          "pinId": "U_MCU.1",
+          "x": 8.9,
+          "y": 15.5,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "U_MCU.2",
+          "x": 8.9,
+          "y": 15.3,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "U_MCU.3",
+          "x": 8.9,
+          "y": 15.1,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "U_MCU.4",
+          "x": 8.9,
+          "y": 14.9,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "U_MCU.5",
+          "x": 8.9,
+          "y": 14.7,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "U_MCU.6",
+          "x": 8.9,
+          "y": 14.5,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "U_MCU.7",
+          "x": 8.9,
+          "y": 14.3,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "U_MCU.8",
+          "x": 8.9,
+          "y": 14.1,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "U_MCU.9",
+          "x": 8.9,
+          "y": 13.9,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "U_MCU.10",
+          "x": 8.9,
+          "y": 13.700000000000001,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "U_MCU.11",
+          "x": 8.9,
+          "y": 13.5,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "U_MCU.12",
+          "x": 8.9,
+          "y": 13.3,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "U_MCU.13",
+          "x": 8.9,
+          "y": 13.1,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "U_MCU.14",
+          "x": 8.9,
+          "y": 12.9,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "U_MCU.15",
+          "x": 8.9,
+          "y": 12.7,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "U_MCU.16",
+          "x": 8.9,
+          "y": 12.5,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "U_MCU.17",
+          "x": 11.1,
+          "y": 12.5,
+          "_facingDirection": "x+"
+        },
+        {
+          "pinId": "U_MCU.18",
+          "x": 11.1,
+          "y": 12.7,
+          "_facingDirection": "x+"
+        },
+        {
+          "pinId": "U_MCU.19",
+          "x": 11.1,
+          "y": 12.9,
+          "_facingDirection": "x+"
+        },
+        {
+          "pinId": "U_MCU.20",
+          "x": 11.1,
+          "y": 13.1,
+          "_facingDirection": "x+"
+        },
+        {
+          "pinId": "U_MCU.21",
+          "x": 11.1,
+          "y": 13.3,
+          "_facingDirection": "x+"
+        },
+        {
+          "pinId": "U_MCU.22",
+          "x": 11.1,
+          "y": 13.5,
+          "_facingDirection": "x+"
+        },
+        {
+          "pinId": "U_MCU.23",
+          "x": 11.1,
+          "y": 13.7,
+          "_facingDirection": "x+"
+        },
+        {
+          "pinId": "U_MCU.24",
+          "x": 11.1,
+          "y": 13.9,
+          "_facingDirection": "x+"
+        },
+        {
+          "pinId": "U_MCU.25",
+          "x": 11.1,
+          "y": 14.1,
+          "_facingDirection": "x+"
+        },
+        {
+          "pinId": "U_MCU.26",
+          "x": 11.1,
+          "y": 14.299999999999999,
+          "_facingDirection": "x+"
+        },
+        {
+          "pinId": "U_MCU.27",
+          "x": 11.1,
+          "y": 14.5,
+          "_facingDirection": "x+"
+        },
+        {
+          "pinId": "U_MCU.28",
+          "x": 11.1,
+          "y": 14.7,
+          "_facingDirection": "x+"
+        },
+        {
+          "pinId": "U_MCU.29",
+          "x": 11.1,
+          "y": 14.9,
+          "_facingDirection": "x+"
+        },
+        {
+          "pinId": "U_MCU.30",
+          "x": 11.1,
+          "y": 15.1,
+          "_facingDirection": "x+"
+        },
+        {
+          "pinId": "U_MCU.31",
+          "x": 11.1,
+          "y": 15.3,
+          "_facingDirection": "x+"
+        },
+        {
+          "pinId": "U_MCU.32",
+          "x": 11.1,
+          "y": 15.5,
+          "_facingDirection": "x+"
+        }
+      ]
+    },
+    {
+      "chipId": "schematic_component_1",
+      "center": {
+        "x": 14,
+        "y": 10
+      },
+      "width": 1.6799999999999997,
+      "height": 0.6799999999999997,
+      "pins": [
+        {
+          "pinId": "R_FAULT_PULLUP.1",
+          "x": 13.7,
+          "y": 10,
+          "_facingDirection": "x-"
+        },
+        {
+          "pinId": "R_FAULT_PULLUP.2",
+          "x": 14.3,
+          "y": 10,
+          "_facingDirection": "x+"
+        }
+      ]
+    }
+  ],
+  "directConnections": [],
+  "netConnections": [
+    {
+      "netId": "GND",
+      "pinIds": [
+        "U_MCU.3",
+        "U_MCU.5",
+        "U_MCU.21"
+      ],
+      "netLabelWidth": 0.42,
+      "netLabelHeight": 0.48
+    },
+    {
+      "netId": "VCC_3V3",
+      "pinIds": [
+        "U_MCU.4",
+        "U_MCU.6",
+        "U_MCU.18",
+        "R_FAULT_PULLUP.1"
+      ],
+      "netLabelWidth": 0.42,
+      "netLabelHeight": 0.96
+    },
+    {
+      "netId": "FAULT",
+      "pinIds": [
+        "U_MCU.32",
+        "R_FAULT_PULLUP.2"
+      ],
+      "netLabelWidth": 0.72
+    }
+  ],
+  "textBoxes": [
+    {
+      "chipId": "schematic_component_0",
+      "center": {
+        "x": 10.080000000000002,
+        "y": 12.17
+      },
+      "width": 1.5600000000000005,
+      "height": 0.17999999999999972,
+      "text": "ATMEGA328P_AU"
+    },
+    {
+      "chipId": "schematic_component_0",
+      "center": {
+        "x": 9.600000000000001,
+        "y": 15.815
+      },
+      "width": 0.7200000000000006,
+      "height": 0.25,
+      "text": "U_MCU"
+    }
+  ],
+  "availableNetLabelOrientations": {
+    "VCC_3V3": [
+      "y+"
+    ],
+    "GND": [
+      "y-"
+    ],
+    "FAULT": [
+      "x-",
+      "x+"
+    ]
+  },
+  "maxMspPairDistance": 2.4
+}

package/tests/repros/small-variant-resistor-facing-direction.test.ts

@@ -0,0 +1,35 @@
+import { expect, test } from "bun:test"
+import { SchematicTracePipelineSolver } from "lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver"
+import inputProblem from "./assets/small-variant-resistor-facing-direction.input.json"
+import "tests/fixtures/matcher"
+
+// Regression for a small-variant resistor (R_FAULT_PULLUP) whose wide
+// reference-designator text inflates its chip box, so its two ports sit *inside*
+// the box rather than on an edge.
+//
+// The input supplies each port's facing direction (as @tscircuit/core does from
+// the schematic symbol). The solver must snap such inside-pins to the box edge
+// ALONG that facing (correctPinsInsideChips) instead of guessing the nearest
+// edge — which, for a horizontal resistor whose ref text widened the box, is the
+// bottom edge, wrongly making both terminals face "y-" and routing downward.
+test("small-variant resistor with facing directions routes from the sides", () => {
+  const solver = new SchematicTracePipelineSolver(inputProblem as any)
+
+  solver.solve()
+
+  const resistor = solver.inputProblem.chips.find(
+    (c) => c.chipId === "schematic_component_1",
+  )!
+  // Terminals keep their symbol-provided facing instead of being re-detected as
+  // facing down, and are snapped to the left/right edges of the inflated box.
+  expect(resistor.pins.map((p) => p._facingDirection).sort()).toEqual([
+    "x+",
+    "x-",
+  ])
+  const left = resistor.pins.find((p) => p._facingDirection === "x-")!
+  const right = resistor.pins.find((p) => p._facingDirection === "x+")!
+  expect(left.x).toBeCloseTo(resistor.center.x - resistor.width / 2)
+  expect(right.x).toBeCloseTo(resistor.center.x + resistor.width / 2)
+
+  expect(solver).toMatchSolverSnapshot(import.meta.path)
+})