@tscircuit/schematic-trace-solver 0.0.179 → 0.0.181

package/tests/repros/repro-battery-management-bq24073.test.ts

@@ -5,6 +5,8 @@ import type { FacingDirection } from "lib/utils/dir"
 import "tests/fixtures/matcher"
 import inputProblem from "./assets/repro-battery-management-bq24073.input.json"
 
+const EXPECTED_BOTTOM_GROUND_LABEL_X = 1.1
+
 const getPinPair = (pinIds: string[]): [string, string] => {
   if (pinIds.length !== 2) {
     throw new Error(`Expected two pin IDs, received ${pinIds.length}`)
@@ -57,6 +59,21 @@ test("repro BatteryManagement_BQ24073 schematic traces", () => {
   const solver = new SchematicTracePipelineSolver(solverInput)
   solver.solve()
 
+  const output = solver.netLabelToTraceSolver!.getOutput()
+  const groundNetIds = new Set(
+    solverInput.netConnections
+      .filter((connection) => connection.isGround)
+      .map((connection) => connection.netId),
+  )
+  const bottomGroundLabel = output.netLabelPlacements
+    .filter(
+      (label) => label.netId !== undefined && groundNetIds.has(label.netId),
+    )
+    .sort((first, second) => first.anchorPoint.y - second.anchorPoint.y)[0]!
+
   expect(solver.inlineNetLabelSolver!.stats.pushedAnchoredNetLabelCount).toBe(1)
+  expect(bottomGroundLabel.anchorPoint.x).toBeCloseTo(
+    EXPECTED_BOTTOM_GROUND_LABEL_X,
+  )
   expect(solver).toMatchSolverSnapshot(import.meta.path)
 })

package/tests/repros/repro-board-8090-power-section.test.ts

@@ -0,0 +1,18 @@
+import { expect, test } from "bun:test"
+import { SchematicTracePipelineSolver } from "lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver"
+import type { InputProblem } from "lib/types/InputProblem"
+import "tests/fixtures/matcher"
+import inputProblem from "./assets/repro-board-8090-power-section.input.json"
+
+// Isolated from board 8090's power section: battery and solar inputs,
+// BAT54S selection, MCP1700 regulation, and the three local support components.
+test("board 8090 power section routing", () => {
+  const solver = new SchematicTracePipelineSolver(inputProblem as InputProblem)
+
+  solver.solve()
+
+  expect(
+    solver.sameNetJunctionAlignmentSolver?.stats.alignedJunctionCount,
+  ).toBe(1)
+  expect(solver).toMatchSolverSnapshot(import.meta.path)
+})

package/tests/repros/repro-hub-usb-sheet.test.ts

@@ -0,0 +1,56 @@
+import { expect, test } from "bun:test"
+import { tracePathContainsPoint } from "lib/solvers/RailNetLabelCornerPlacementSolver/geometry"
+import { SchematicTracePipelineSolver } from "lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver"
+import { isVertical } from "lib/solvers/TraceCleanupSolver/sameNetRailAlignment/geometry"
+import type { InputChip, InputProblem, PinId } from "lib/types/InputProblem"
+import "tests/fixtures/matcher"
+import inputProblemJson from "./assets/repro-hub-usb-sheet.input.json"
+
+// Captured from @tsci/mohan-bee.hub 1.0.12 using @tscircuit/core 0.0.1816.
+// Only opaque schematic component IDs were replaced with unique source names.
+test("repro hub USB sheet schematic trace routing", () => {
+  const inputProblem: InputProblem = JSON.parse(
+    JSON.stringify(inputProblemJson),
+  )
+  const solver = new SchematicTracePipelineSolver(inputProblem)
+
+  solver.solve()
+
+  const output = solver.netLabelToTraceSolver!.getOutput()
+  const groundNetIds = new Set(
+    inputProblem.netConnections
+      .filter((connection) => connection.isGround)
+      .map((connection) => connection.netId),
+  )
+  const pinChipMap = new Map<PinId, InputChip>(
+    inputProblem.chips.flatMap((chip) =>
+      chip.pins.map((pin) => [pin.pinId, chip] as const),
+    ),
+  )
+  const sameChipGroundLabel = output.netLabelPlacements.find((label) => {
+    if (
+      label.pinIds.length !== 2 ||
+      label.netId === undefined ||
+      !groundNetIds.has(label.netId)
+    ) {
+      return false
+    }
+    const firstChip = pinChipMap.get(label.pinIds[0]!)
+    const secondChip = pinChipMap.get(label.pinIds[1]!)
+    return firstChip === secondChip && (firstChip?.pins.length ?? 0) > 2
+  })!
+  const sameChipGroundHostTrace = output.traces.find((trace) =>
+    sameChipGroundLabel.mspConnectionPairIds.includes(trace.mspPairId),
+  )!
+  const verticalHostPoint = sameChipGroundHostTrace.tracePath.find(
+    (point, index, path) => index > 0 && isVertical(path[index - 1]!, point),
+  )!
+  const tracesAtSameChipGroundLabel = output.traces.filter((trace) =>
+    tracePathContainsPoint(trace.tracePath, sameChipGroundLabel.anchorPoint),
+  )
+
+  expect(sameChipGroundLabel.orientation).toBe("y-")
+  expect(sameChipGroundLabel.anchorPoint.x).toBeCloseTo(verticalHostPoint.x)
+  expect(tracesAtSameChipGroundLabel).toHaveLength(1)
+  expect(solver).toMatchSolverSnapshot(import.meta.path)
+})

package/tests/repros/repro-mcp73831-charger-traces.test.ts

@@ -0,0 +1,16 @@
+import { expect, test } from "bun:test"
+import { SchematicTracePipelineSolver } from "lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver"
+import "tests/fixtures/matcher"
+import inputProblem from "./assets/repro-mcp73831-charger-traces.input.json"
+
+// Captured from @tscircuit/core 0.0.1829 at commit b761dc8.
+// The source circuit contains only the MCP73831 charger, its programming and
+// LED resistors, VBAT capacitor, and LED. This preserves the long CHG_STAT path
+// needed to reproduce the VBAT label crossing it.
+test("repro VBAT label crossing the MCP73831 CHG_STAT trace", () => {
+  const solver = new SchematicTracePipelineSolver(inputProblem as any)
+
+  solver.solve()
+
+  expect(solver).toMatchSolverSnapshot(import.meta.path)
+})

package/tests/repros/repro-mouse-switch-ground-unnecessary-jog.test.ts

@@ -0,0 +1,15 @@
+import { expect, test } from "bun:test"
+import { SchematicTracePipelineSolver } from "lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver"
+import "tests/fixtures/matcher"
+import inputProblem from "./assets/repro-mouse-switch-ground-unnecessary-jog.input.json"
+
+// Captured from @tscircuit/core 0.0.1829 at commit b761dc8.
+// The GND route should use one straight vertical trunk between its terminal
+// stubs instead of adding the unnecessary horizontal step near the midpoint.
+test("repro unnecessary jog in mouse switch ground trunk", () => {
+  const solver = new SchematicTracePipelineSolver(inputProblem as any)
+
+  solver.solve()
+
+  expect(solver).toMatchSolverSnapshot(import.meta.path)
+})

package/tests/repros/repro-rf1-unnecessary-dogleg.test.ts

@@ -0,0 +1,15 @@
+import { expect, test } from "bun:test"
+import { SchematicTracePipelineSolver } from "lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver"
+import "tests/fixtures/matcher"
+import inputProblem from "./assets/repro-rf1-unnecessary-dogleg.input.json"
+
+// Captured from @tscircuit/core 0.0.1829 at commit b761dc8.
+// The nearly level RF1 endpoints should produce an effectively straight trace,
+// rather than a clearance-sized dogleg between the two inductors.
+test("repro RF1 unnecessary dogleg between aligned inductors", () => {
+  const solver = new SchematicTracePipelineSolver(inputProblem as any)
+
+  solver.solve()
+
+  expect(solver).toMatchSolverSnapshot(import.meta.path)
+})

package/tests/repros/repro-smartwatch-power-sheet.test.ts

@@ -1,9 +1,13 @@
 import { expect, test } from "bun:test"
+import { tracePathContainsPoint } from "lib/solvers/RailNetLabelCornerPlacementSolver/geometry"
 import { SchematicTracePipelineSolver } from "lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver"
+import { isVertical } from "lib/solvers/TraceCleanupSolver/sameNetRailAlignment/geometry"
 import type { InputProblem } from "lib/types/InputProblem"
 import "tests/fixtures/matcher"
 import inputProblem from "./assets/repro-smartwatch-power-sheet.input.json"
 
+const MIN_CONNECTOR_GROUND_RAIL_EXTENSION = 0.2
+
 test("smartwatch power sheet", () => {
   const solver = new SchematicTracePipelineSolver(
     inputProblem as unknown as InputProblem,
@@ -17,11 +21,33 @@ test("smartwatch power sheet", () => {
     "schematic_port_0",
     "schematic_port_11",
   ])
-  const connectorGroundLabels = solver
-    .netLabelToTraceSolver!.getOutput()
-    .netLabelPlacements.filter((label) =>
-      label.pinIds.some((pinId) => connectorGroundPinIds.has(pinId)),
-    )
+  const output = solver.netLabelToTraceSolver!.getOutput()
+  const connectorGroundLabels = output.netLabelPlacements.filter((label) =>
+    label.pinIds.some((pinId) => connectorGroundPinIds.has(pinId)),
+  )
   expect(connectorGroundLabels).toHaveLength(1)
+  const connectorGroundLabel = connectorGroundLabels[0]!
+  const connectorGroundPins = inputProblem.chips.flatMap((chip) =>
+    chip.pins.filter((pin) => connectorGroundPinIds.has(pin.pinId)),
+  )
+  const connectorGroundHostTrace = output.traces.find((trace) =>
+    connectorGroundLabel.mspConnectionPairIds.includes(trace.mspPairId),
+  )!
+  const verticalHostPoint = connectorGroundHostTrace.tracePath.find(
+    (point, index, path) => index > 0 && isVertical(path[index - 1]!, point),
+  )!
+  const lowestConnectorGroundPinY = Math.min(
+    ...connectorGroundPins.map((pin) => pin.y),
+  )
+  const tracesAtConnectorGroundLabel = output.traces.filter((trace) =>
+    tracePathContainsPoint(trace.tracePath, connectorGroundLabel.anchorPoint),
+  )
+
+  expect(connectorGroundLabel.orientation).toBe("y-")
+  expect(connectorGroundLabel.anchorPoint.x).toBeCloseTo(verticalHostPoint.x)
+  expect(connectorGroundLabel.anchorPoint.y).toBeCloseTo(
+    lowestConnectorGroundPinY - MIN_CONNECTOR_GROUND_RAIL_EXTENSION,
+  )
+  expect(tracesAtConnectorGroundLabel).toHaveLength(1)
   expect(solver).toMatchSolverSnapshot(import.meta.path)
 })