@tscircuit/schematic-trace-solver 0.0.160 → 0.0.162

package/tests/repros/repro-bluetooth-controller-ground-decoupling-groups.test.ts

@@ -0,0 +1,18 @@
+import { expect, test } from "bun:test"
+import { SchematicTracePipelineSolver } from "lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver"
+import type { InputProblem } from "lib/types/InputProblem"
+import "tests/fixtures/matcher"
+import inputProblem from "./assets/repro-bluetooth-controller-ground-decoupling-groups.input.json"
+
+test("repro Bluetooth controller GND trace between decoupling groups", () => {
+  const solver = new SchematicTracePipelineSolver(
+    inputProblem as InputProblem,
+    {
+      hideRatsNet: true,
+    },
+  )
+
+  solver.solve()
+
+  expect(solver).toMatchSolverSnapshot(import.meta.path)
+})

package/tests/repros/repro-core-ground-inline-label-fallback.test.ts

@@ -0,0 +1,34 @@
+import { expect, test } from "bun:test"
+import { SchematicTracePipelineSolver } from "lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver"
+import type { InputProblem } from "lib/types/InputProblem"
+import "tests/fixtures/matcher"
+import inputProblemJson from "./assets/repro-core-ground-inline-label-fallback.input.json"
+
+const signalNetIds = new Set(["step", "direction", "enable"])
+
+// Captured from @tscircuit/core's
+// ground-net-label-preserves-solver-orientation test. These three two-pin
+// signal nets opt into inline labels, but the neighboring shared LOGIC_3V3
+// and GND labels cause post-processing to fall them back to anchored labels.
+test("repro: core inline signal labels fall back near shared rail labels", () => {
+  const inputProblem: InputProblem = JSON.parse(
+    JSON.stringify(inputProblemJson),
+  )
+  const solver = new SchematicTracePipelineSolver(inputProblem)
+
+  solver.solve()
+
+  const inlineOutput = solver.inlineNetLabelSolver!.getOutput()
+  const signalInlineLabels = inlineOutput.inlineNetLabelPlacements.filter(
+    (placement) => signalNetIds.has(placement.netId ?? ""),
+  )
+  const signalAnchoredLabels = inlineOutput.netLabelPlacements.filter(
+    (placement) => signalNetIds.has(placement.netId ?? ""),
+  )
+
+  expect(signalInlineLabels).toHaveLength(0)
+  expect(
+    signalAnchoredLabels.map((placement) => placement.netId).sort(),
+  ).toEqual(["direction", "direction", "enable", "enable", "step", "step"])
+  expect(solver).toMatchSolverSnapshot(import.meta.path)
+})

package/tests/repros/repro-hdc2080-ground-label-alignment.test.ts

@@ -0,0 +1,239 @@
+import { expect, test } from "bun:test"
+import { SchematicTracePipelineSolver } from "lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver"
+import type { InputProblem } from "lib/types/InputProblem"
+import "tests/fixtures/matcher"
+
+const inputProblem: InputProblem = {
+  chips: [
+    {
+      chipId: "schematic_component_0",
+      center: { x: 4.5, y: 0 },
+      width: 3.4000000000000004,
+      height: 4.6,
+      pins: [
+        {
+          pinId: "schematic_port_0",
+          displayName: "VDD",
+          x: 2.8,
+          y: 0.8500000000000001,
+        },
+        {
+          pinId: "schematic_port_1",
+          displayName: "SCL",
+          x: 2.8,
+          y: 0.4000000000000001,
+        },
+        {
+          pinId: "schematic_port_2",
+          displayName: "SDA",
+          x: 2.8,
+          y: 0.20000000000000007,
+        },
+        {
+          pinId: "schematic_port_3",
+          displayName: "GPIO",
+          x: 2.8,
+          y: 0,
+        },
+        {
+          pinId: "schematic_port_4",
+          displayName: "GND",
+          x: 2.8,
+          y: -0.8500000000000001,
+        },
+      ],
+    },
+    {
+      chipId: "schematic_component_1",
+      center: { x: -2.1, y: 0 },
+      width: 4,
+      height: 4,
+      pins: [
+        {
+          pinId: "schematic_port_5",
+          displayName: "I2C_SDA",
+          x: -0.10000000000000009,
+          y: 0.5499999999999998,
+        },
+        {
+          pinId: "schematic_port_6",
+          displayName: "GND",
+          x: -0.10000000000000009,
+          y: -1.2000000000000002,
+        },
+        {
+          pinId: "schematic_port_7",
+          displayName: "I2C_ADDR",
+          x: -0.10000000000000009,
+          y: -0.5500000000000002,
+        },
+        {
+          pinId: "schematic_port_8",
+          displayName: "DRDY_INT",
+          x: -0.10000000000000009,
+          y: 0.09999999999999987,
+        },
+        {
+          pinId: "schematic_port_9",
+          displayName: "VDD",
+          x: -0.10000000000000009,
+          y: 1.2000000000000002,
+        },
+        {
+          pinId: "schematic_port_10",
+          displayName: "I2C_SCL",
+          x: -0.10000000000000009,
+          y: 0.7499999999999998,
+        },
+      ],
+    },
+    {
+      chipId: "schematic_component_2",
+      center: { x: 0.7949999999999999, y: 1.3 },
+      width: 1.0899999999999999,
+      height: 0.6000000000000001,
+      pins: [
+        {
+          pinId: "schematic_port_11",
+          displayName: "anode",
+          x: 0.7,
+          y: 1.6,
+          _facingDirection: "y+",
+        },
+        {
+          pinId: "schematic_port_12",
+          displayName: "cathode",
+          x: 0.7,
+          y: 1,
+          _facingDirection: "y-",
+        },
+      ],
+    },
+    {
+      chipId: "schematic_component_3",
+      center: { x: 1.5949999999999998, y: 1.3 },
+      width: 1.0899999999999996,
+      height: 0.6000000000000001,
+      pins: [
+        {
+          pinId: "schematic_port_13",
+          displayName: "anode",
+          x: 1.5,
+          y: 1.6,
+          _facingDirection: "y+",
+        },
+        {
+          pinId: "schematic_port_14",
+          displayName: "cathode",
+          x: 1.5,
+          y: 1,
+          _facingDirection: "y-",
+        },
+      ],
+    },
+  ],
+  directConnections: [],
+  netConnections: [
+    {
+      netId: "VDD",
+      netLabelWidth: 0.42,
+      netLabelHeight: 0.48,
+      pinIds: [
+        "schematic_port_0",
+        "schematic_port_9",
+        "schematic_port_11",
+        "schematic_port_13",
+      ],
+    },
+    {
+      netId: "SCL",
+      netLabelWidth: 0.48,
+      pinIds: ["schematic_port_1", "schematic_port_10", "schematic_port_12"],
+    },
+    {
+      netId: "SDA",
+      netLabelWidth: 0.48,
+      pinIds: ["schematic_port_2", "schematic_port_5", "schematic_port_14"],
+    },
+    {
+      netId: "DRDY_INT",
+      netLabelWidth: 1.08,
+      anchoredNetLabelWidth: 1.08,
+      allowInlineNetLabel: true,
+      inlineNetLabelHeight: 0.12,
+      inlineNetLabelWidth: 0.72,
+      pinIds: ["schematic_port_3", "schematic_port_8"],
+    },
+    {
+      netId: "GND",
+      netLabelWidth: 0.42,
+      netLabelHeight: 0.48,
+      pinIds: ["schematic_port_4", "schematic_port_6", "schematic_port_7"],
+    },
+  ],
+  textBoxes: [
+    {
+      chipId: "schematic_component_0",
+      center: { x: 3.38, y: -2.4299999999999997 },
+      width: 0.3599999999999999,
+      height: 0.17999999999999972,
+      text: "MCU",
+    },
+    {
+      chipId: "schematic_component_0",
+      center: { x: 3.3200000000000003, y: 2.415 },
+      width: 0.3600000000000003,
+      height: 0.24999999999999956,
+      text: "U2",
+    },
+    {
+      chipId: "schematic_component_1",
+      center: { x: -3.04, y: -2.13 },
+      width: 1.3199999999999998,
+      height: 0.17999999999999972,
+      text: "HDC2080DMBR",
+    },
+    {
+      chipId: "schematic_component_1",
+      center: { x: -3.58, y: 2.1149999999999998 },
+      width: 0.3600000000000003,
+      height: 0.24999999999999978,
+      text: "U1",
+    },
+  ],
+  availableNetLabelOrientations: {
+    VDD: ["y+"],
+    SCL: ["x-", "x+"],
+    SDA: ["x-", "x+"],
+    DRDY_INT: ["x-", "x+"],
+    GND: ["y-"],
+  },
+  maxMspPairDistance: 2.4,
+  _hideRatsNet: false,
+}
+
+test("aligns the HDC2080 GND label with its vertical rail", () => {
+  const solver = new SchematicTracePipelineSolver(inputProblem)
+
+  solver.solve()
+
+  const orientationOutput = solver.availableNetOrientationSolver!.getOutput()
+  const groundLabel = orientationOutput.netLabelPlacements.find(
+    (label) =>
+      label.netId === "GND" && label.pinIds.includes("schematic_port_6"),
+  )
+  const groundRailTrace = orientationOutput.traces.find(
+    (trace) => trace.mspPairId === "schematic_port_7-schematic_port_6",
+  )
+  const matchingGroundTraces = orientationOutput.traces.filter(
+    (trace) =>
+      trace.userNetId === "GND" &&
+      trace.pinIds.includes("schematic_port_6") &&
+      trace.pinIds.includes("schematic_port_7"),
+  )
+
+  expect(groundLabel?.anchorPoint.x).toBeCloseTo(0.1)
+  expect(groundRailTrace?.tracePath[1]?.x).toBeCloseTo(0.1)
+  expect(matchingGroundTraces).toHaveLength(1)
+  expect(solver).toMatchSolverSnapshot(import.meta.path)
+})

package/tests/repros/repro-tida010076-j4-ground-bus.test.ts

@@ -59,20 +59,24 @@ test("repro TIDA-010076 J4 ground pins should share one vertical bus", () => {
   solver.solve()
 
   const output = solver.sameNetJunctionAlignmentSolver!.getOutput()
+  const groundConnection = inputProblem.netConnections[0]!
+  const groundPinIds = new Set(groundConnection.pinIds)
   const groundTraces = output.traces.filter(
     (trace) =>
-      trace.userNetId === "NET_AGND" &&
-      trace.pinIds.every((pinId) => pinId.startsWith("J4.")),
+      trace.userNetId === groundConnection.netId &&
+      trace.pinIds.every((pinId) => groundPinIds.has(pinId)),
   )
-  const verticalBranchOffsets = new Set(
-    groundTraces.map((trace) => trace.tracePath[1]!.x.toFixed(3)),
+  const verticalRailXs = groundTraces.map((trace) => trace.tracePath[1]!.x)
+  const groundLabel = output.netLabelPlacements.find(
+    (label) => label.netId === groundConnection.netId,
   )
 
-  // Current mismatch: the first three GND pins use one vertical offset while
-  // the final pair detours around the manufacturer text at a second offset.
-  expect(verticalBranchOffsets.size).toBe(2)
-  expect(
-    output.netLabelPlacements.filter((label) => label.netId === "NET_AGND"),
-  ).toHaveLength(1)
+  expect(new Set(verticalRailXs.map((x) => x.toFixed(3))).size).toBe(1)
+  expect(verticalRailXs[0]).toBeCloseTo(0.975)
+  expect(groundLabel?.anchorPoint.x).toBeCloseTo(verticalRailXs[0]!)
+  const productTextBox = inputProblem.textBoxes![0]!
+  expect(groundLabel?.anchorPoint.y).toBeLessThan(
+    productTextBox.center.y - productTextBox.height / 2,
+  )
   expect(solver).toMatchSolverSnapshot(import.meta.path)
 })

package/tests/repros/repro-tida010076-page02.test.ts

@@ -39,8 +39,8 @@ test("repro TIDA-010076 page 02 net-label placement", () => {
     )!
 
   expect(j5AgndLabel.orientation).toBe("y-")
-  expect(j5AgndLabel.anchorPoint.y).toBeCloseTo(
-    Math.min(...j5GroundPins.map((pin) => pin.y)),
+  expect(Math.abs(j5AgndLabel.anchorPoint.x - j5GroundPins[0]!.x)).toBeCloseTo(
+    0.2,
   )
 
   const powerConnectorPinPairs = [

package/tests/solvers/InlineNetLabelSolver/__snapshots__/inline-net-label02.snap.svg

@@ -70,6 +70,6 @@ USER_LED_ANODE" data-x="1.5175" data-y="0" cx="324.7058823529412" cy="336.134453
               .port-label { fill: rgb(0, 100, 100); }
               .component-name { fill: rgb(0, 100, 100); }
 
-            </style><rect class="boundary" x="0" y="0" width="1200" height="800"/><g class="trace sch-trace" data-layer="base" data-circuit-json-type="schematic_trace" data-schematic-trace-id="schematic_trace_0__stack1"><path d="M 461.18251928022 464.78149100256 L 602.6992287917735 464.78149100256 L 602.6992287917735 418.5089974293 L 744.215938303327 418.5089974293" class="trace-invisible-hover-outline sch-trace-hitbox" stroke="rgb(0, 150, 0)" fill="none" stroke-width="24.678663239071998px" stroke-linecap="round" opacity="0" stroke-linejoin="round"/><path class="sch-trace-path" d="M 461.18251928022 464.78149100256 L 602.6992287917735 464.78149100256 L 602.6992287917735 418.5089974293 L 744.215938303327 418.5089974293" stroke="rgb(0, 150, 0)" fill="none" stroke-width="3.0848329048839997px" stroke-linecap="round" stroke-linejoin="round"/></g><g class="trace-overlays sch-trace-overlays" data-layer="overlay" data-circuit-json-type="schematic_trace" data-schematic-trace-id="schematic_trace_0__stack1"/><g class="sch-component" data-circuit-json-type="schematic_component" data-schematic-component-id="schematic_component_0__stack1"><rect class="component chip sch-component-body" x="337.78920308486" y="341.3881748072" width="61.69665809768003" height="154.24164524419996" stroke-width="3.0848329048839997px" fill="rgb(255, 255, 194)" stroke="rgb(132, 0, 0)"/><rect class="component-overlay sch-component-overlay" x="337.78920308486" y="341.3881748072" width="61.69665809768003" height="154.24164524419996" fill="transparent"/><text class="sch-text" x="368.6375321337" y="418.5089974293" fill="#0f172a" text-anchor="middle" dominant-baseline="middle" font-family="sans-serif" font-size="27.763496143955997px" transform="rotate(0, 368.6375321337, 418.5089974293)">schematic_component_0</text><line class="component-pin sch-component-pin sch-port-line" x1="337.78920308486" y1="372.23650385604" x2="279.177377892064" y2="372.23650385604" stroke-width="3.0848329048839997px"/><g class="sch-port" data-schematic-port-id="source_port_0_0__stack1"><circle class="component-pin sch-component-pin sch-port-terminal" cx="276.09254498718" cy="372.23650385604" r="3.0848329048839997" stroke-width="3.0848329048839997px"/><rect x="273.007712082296" y="369.15167095115595" width="6.1696658097679995" height="6.1696658097679995" opacity="0"/></g><text class="pin-number sch-pin-number" x="306.94087403602" y="369.151670951156" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="23.136246786629997px" transform=""></text><text class="pin-number sch-pin-label" x="353.21336760928" y="372.23650385604" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="start" dominant-baseline="middle" font-size="23.136246786629997px" transform="">schematic_port_0</text><line class="component-pin sch-component-pin sch-port-line" x1="337.78920308486" y1="403.08483290488" x2="279.177377892064" y2="403.08483290488" stroke-width="3.0848329048839997px"/><g class="sch-port" data-schematic-port-id="source_port_0_1__stack1"><circle class="component-pin sch-component-pin sch-port-terminal" cx="276.09254498718" cy="403.08483290488" r="3.0848329048839997" stroke-width="3.0848329048839997px"/><rect x="273.007712082296" y="399.99999999999596" width="6.1696658097679995" height="6.1696658097679995" opacity="0"/></g><text class="pin-number sch-pin-number" x="306.94087403602" y="399.999999999996" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="23.136246786629997px" transform=""></text><text class="pin-number sch-pin-label" x="353.21336760928" y="403.08483290488" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="start" dominant-baseline="middle" font-size="23.136246786629997px" transform="">schematic_port_1</text><line class="component-pin sch-component-pin sch-port-line" x1="337.78920308486" y1="433.93316195372" x2="279.177377892064" y2="433.93316195372" stroke-width="3.0848329048839997px"/><g class="sch-port" data-schematic-port-id="source_port_0_2__stack1"><circle class="component-pin sch-component-pin sch-port-terminal" cx="276.09254498718" cy="433.93316195372" r="3.0848329048839997" stroke-width="3.0848329048839997px"/><rect x="273.007712082296" y="430.848329048836" width="6.1696658097679995" height="6.1696658097679995" opacity="0"/></g><text class="pin-number sch-pin-number" x="306.94087403602" y="430.848329048836" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="23.136246786629997px" transform=""></text><text class="pin-number sch-pin-label" x="353.21336760928" y="433.93316195372" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="start" dominant-baseline="middle" font-size="23.136246786629997px" transform="">schematic_port_2</text><line class="component-pin sch-component-pin sch-port-line" x1="337.78920308486" y1="464.78149100256" x2="279.177377892064" y2="464.78149100256" stroke-width="3.0848329048839997px"/><g class="sch-port" data-schematic-port-id="source_port_0_3__stack1"><circle class="component-pin sch-component-pin sch-port-terminal" cx="276.09254498718" cy="464.78149100256" r="3.0848329048839997" stroke-width="3.0848329048839997px"/><rect x="273.007712082296" y="461.696658097676" width="6.1696658097679995" height="6.1696658097679995" opacity="0"/></g><text class="pin-number sch-pin-number" x="306.94087403602" y="461.696658097676" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="23.136246786629997px" transform=""></text><text class="pin-number sch-pin-label" x="353.21336760928" y="464.78149100256" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="start" dominant-baseline="middle" font-size="23.136246786629997px" transform="">schematic_port_3</text><line class="component-pin sch-component-pin sch-port-line" x1="399.48586118254" y1="464.78149100256" x2="461.18251928022" y2="464.78149100256" stroke-width="3.0848329048839997px"/><g class="sch-port" data-schematic-port-id="source_port_0_4__stack1"><rect x="458.09768637533597" y="461.696658097676" width="6.1696658097679995" height="6.1696658097679995" opacity="0"/></g><text class="pin-number sch-pin-number" x="430.33419023138003" y="461.696658097676" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="23.136246786629997px" transform=""></text><text class="pin-number sch-pin-label" x="384.06169665812" y="464.78149100256" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="end" dominant-baseline="middle" font-size="23.136246786629997px" transform="">schematic_port_4</text><line class="component-pin sch-component-pin sch-port-line" x1="399.48586118254" y1="433.93316195372" x2="458.097686375336" y2="433.93316195372" stroke-width="3.0848329048839997px"/><g class="sch-port" data-schematic-port-id="source_port_0_5__stack1"><circle class="component-pin sch-component-pin sch-port-terminal" cx="461.18251928022" cy="433.93316195372" r="3.0848329048839997" stroke-width="3.0848329048839997px"/><rect x="458.09768637533597" y="430.848329048836" width="6.1696658097679995" height="6.1696658097679995" opacity="0"/></g><text class="pin-number sch-pin-number" x="430.33419023138003" y="430.848329048836" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="23.136246786629997px" transform=""></text><text class="pin-number sch-pin-label" x="384.06169665812" y="433.93316195372" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="end" dominant-baseline="middle" font-size="23.136246786629997px" transform="">schematic_port_5</text><line class="component-pin sch-component-pin sch-port-line" x1="399.48586118254" y1="403.08483290488" x2="458.097686375336" y2="403.08483290488" stroke-width="3.0848329048839997px"/><g class="sch-port" data-schematic-port-id="source_port_0_6__stack1"><circle class="component-pin sch-component-pin sch-port-terminal" cx="461.18251928022" cy="403.08483290488" r="3.0848329048839997" stroke-width="3.0848329048839997px"/><rect x="458.09768637533597" y="399.99999999999596" width="6.1696658097679995" height="6.1696658097679995" opacity="0"/></g><text class="pin-number sch-pin-number" x="430.33419023138003" y="399.999999999996" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="23.136246786629997px" transform=""></text><text class="pin-number sch-pin-label" x="384.06169665812" y="403.08483290488" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="end" dominant-baseline="middle" font-size="23.136246786629997px" transform="">schematic_port_6</text><line class="component-pin sch-component-pin sch-port-line" x1="399.48586118254" y1="372.23650385604" x2="458.097686375336" y2="372.23650385604" stroke-width="3.0848329048839997px"/><g class="sch-port" data-schematic-port-id="source_port_0_7__stack1"><circle class="component-pin sch-component-pin sch-port-terminal" cx="461.18251928022" cy="372.23650385604" r="3.0848329048839997" stroke-width="3.0848329048839997px"/><rect x="458.09768637533597" y="369.15167095115595" width="6.1696658097679995" height="6.1696658097679995" opacity="0"/></g><text class="pin-number sch-pin-number" x="430.33419023138003" y="369.151670951156" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="23.136246786629997px" transform=""></text><text class="pin-number sch-pin-label" x="384.06169665812" y="372.23650385604" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="end" dominant-baseline="middle" font-size="23.136246786629997px" transform="">schematic_port_7</text></g><g class="sch-component" data-circuit-json-type="schematic_component" data-schematic-component-id="schematic_component_1__stack1"><rect class="component chip sch-component-body" x="805.912596401007" y="327.506426735222" width="50.899742930585944" height="141.13110539844297" stroke-width="3.0848329048839997px" fill="rgb(255, 255, 194)" stroke="rgb(132, 0, 0)"/><rect class="component-overlay sch-component-overlay" x="805.912596401007" y="327.506426735222" width="50.899742930585944" height="141.13110539844297" fill="transparent"/><text class="sch-text" x="831.3624678663" y="398.0719794344435" fill="#0f172a" text-anchor="middle" dominant-baseline="middle" font-family="sans-serif" font-size="27.763496143955997px" transform="rotate(0, 831.3624678663, 398.0719794344435)">schematic_component_1</text><line class="component-pin sch-component-pin sch-port-line" x1="805.912596401007" y1="418.5089974293" x2="744.215938303327" y2="418.5089974293" stroke-width="3.0848329048839997px"/><g class="sch-port" data-schematic-port-id="source_port_1_0__stack1"><rect x="741.131105398443" y="415.42416452441597" width="6.1696658097679995" height="6.1696658097679995" opacity="0"/></g><text class="pin-number sch-pin-number" x="775.064267352167" y="415.42416452441597" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="23.136246786629997px" transform=""></text><text class="pin-number sch-pin-label" x="821.3367609254269" y="418.5089974293" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="start" dominant-baseline="middle" font-size="23.136246786629997px" transform="">schematic_port_8</text><line class="component-pin sch-component-pin sch-port-line" x1="856.812339331593" y1="418.5089974293" x2="915.424164524389" y2="418.5089974293" stroke-width="3.0848329048839997px"/><g class="sch-port" data-schematic-port-id="source_port_1_1__stack1"><circle class="component-pin sch-component-pin sch-port-terminal" cx="918.508997429273" cy="418.5089974293" r="3.0848329048839997" stroke-width="3.0848329048839997px"/><rect x="915.424164524389" y="415.42416452441597" width="6.1696658097679995" height="6.1696658097679995" opacity="0"/></g><text class="pin-number sch-pin-number" x="887.660668380433" y="415.42416452441597" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="23.136246786629997px" transform=""></text><text class="pin-number sch-pin-label" x="841.388174807173" y="418.5089974293" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="end" dominant-baseline="middle" font-size="23.136246786629997px" transform="">schematic_port_9</text></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_0_0__stack1"><circle cx="276.09254498718" cy="372.23650385604" r="6.1696658097679995" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_0_1__stack1"><circle cx="276.09254498718" cy="403.08483290488" r="6.1696658097679995" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_0_2__stack1"><circle cx="276.09254498718" cy="433.93316195372" r="6.1696658097679995" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_0_3__stack1"><circle cx="276.09254498718" cy="464.78149100256" r="6.1696658097679995" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_0_4__stack1"><circle cx="461.18251928022" cy="464.78149100256" r="6.1696658097679995" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_0_5__stack1"><circle cx="461.18251928022" cy="433.93316195372" r="6.1696658097679995" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_0_6__stack1"><circle cx="461.18251928022" cy="403.08483290488" r="6.1696658097679995" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_0_7__stack1"><circle cx="461.18251928022" cy="372.23650385604" r="6.1696658097679995" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_1_0__stack1"><circle cx="744.215938303327" cy="418.5089974293" r="6.1696658097679995" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_1_1__stack1"><circle cx="918.508997429273" cy="418.5089974293" r="6.1696658097679995" fill="red" opacity="0"/></g><text class="sch-text" x="356.298200514164" y="323.650385604117" fill="#7e22ce" text-anchor="middle" dominant-baseline="middle" font-family="sans-serif" font-size="27.763496143955997px" transform="rotate(0, 356.298200514164, 323.650385604117)">U1</text><text class="sch-text" x="602.6992287917735" y="396.915167095112" fill="#047857" text-anchor="middle" dominant-baseline="middle" font-family="sans-serif" font-size="27.763496143955997px" transform="rotate(0, 602.6992287917735, 396.915167095112)">XXXXXXXXXXXXXX</text><rect class="schematic-box sch-box" x="328.53470437020803" y="304.370179948592" width="55.52699228791198" height="38.56041131105002" stroke-width="3.0848329048839997px" stroke="rgb(132, 0, 0)" fill="transparent" stroke-dasharray="24.678663239071998 12.339331619535999"/>
+            </style><rect class="boundary" x="0" y="0" width="1200" height="800"/><g class="trace sch-trace" data-layer="base" data-circuit-json-type="schematic_trace" data-schematic-trace-id="schematic_trace_0__stack1"><path d="M 402.60950605784 493.94221808017 L 607.8285181734233 493.94221808017 L 607.8285181734233 426.8406337372 L 813.0475302890065 426.8406337372" class="trace-invisible-hover-outline sch-trace-hitbox" stroke="rgb(0, 150, 0)" fill="none" stroke-width="35.787511649584px" stroke-linecap="round" opacity="0" stroke-linejoin="round"/><path class="sch-trace-path" d="M 402.60950605784 493.94221808017 L 607.8285181734233 493.94221808017 L 607.8285181734233 426.8406337372 L 813.0475302890065 426.8406337372" stroke="rgb(0, 150, 0)" fill="none" stroke-width="4.473438956198px" stroke-linecap="round" stroke-linejoin="round"/></g><g class="trace-overlays sch-trace-overlays" data-layer="overlay" data-circuit-json-type="schematic_trace" data-schematic-trace-id="schematic_trace_0__stack1"/><g class="sch-component" data-circuit-json-type="schematic_component" data-schematic-component-id="schematic_component_0__stack1"><rect class="component chip sch-component-body" x="223.67194780992" y="315.00465983225" width="89.46877912396005" height="223.67194780989996" stroke-width="4.473438956198px" fill="rgb(255, 255, 194)" stroke="rgb(132, 0, 0)"/><rect class="component-overlay sch-component-overlay" x="223.67194780992" y="315.00465983225" width="89.46877912396005" height="223.67194780989996" fill="transparent"/><line class="component-pin sch-component-pin sch-port-line" x1="223.67194780992" y1="359.73904939423" x2="138.676607642158" y2="359.73904939423" stroke-width="4.473438956198px"/><g class="sch-port" data-schematic-port-id="source_port_0_0__stack1"><circle class="component-pin sch-component-pin sch-port-terminal" cx="134.20316868596" cy="359.73904939423" r="4.473438956198" stroke-width="4.473438956198px"/><rect x="129.729729729762" y="355.265610438032" width="8.946877912396" height="8.946877912396" opacity="0"/></g><text class="pin-number sch-pin-number" x="178.93755824794" y="355.265610438032" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="33.550792171485px" transform=""></text><line class="component-pin sch-component-pin sch-port-line" x1="223.67194780992" y1="404.47343895621" x2="138.676607642158" y2="404.47343895621" stroke-width="4.473438956198px"/><g class="sch-port" data-schematic-port-id="source_port_0_1__stack1"><circle class="component-pin sch-component-pin sch-port-terminal" cx="134.20316868596" cy="404.47343895621" r="4.473438956198" stroke-width="4.473438956198px"/><rect x="129.729729729762" y="400.000000000012" width="8.946877912396" height="8.946877912396" opacity="0"/></g><text class="pin-number sch-pin-number" x="178.93755824794" y="400.000000000012" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="33.550792171485px" transform=""></text><line class="component-pin sch-component-pin sch-port-line" x1="223.67194780992" y1="449.20782851819" x2="138.676607642158" y2="449.20782851819" stroke-width="4.473438956198px"/><g class="sch-port" data-schematic-port-id="source_port_0_2__stack1"><circle class="component-pin sch-component-pin sch-port-terminal" cx="134.20316868596" cy="449.20782851819" r="4.473438956198" stroke-width="4.473438956198px"/><rect x="129.729729729762" y="444.73438956199203" width="8.946877912396" height="8.946877912396" opacity="0"/></g><text class="pin-number sch-pin-number" x="178.93755824794" y="444.734389561992" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="33.550792171485px" transform=""></text><line class="component-pin sch-component-pin sch-port-line" x1="223.67194780992" y1="493.94221808017" x2="138.676607642158" y2="493.94221808017" stroke-width="4.473438956198px"/><g class="sch-port" data-schematic-port-id="source_port_0_3__stack1"><circle class="component-pin sch-component-pin sch-port-terminal" cx="134.20316868596" cy="493.94221808017" r="4.473438956198" stroke-width="4.473438956198px"/><rect x="129.729729729762" y="489.468779123972" width="8.946877912396" height="8.946877912396" opacity="0"/></g><text class="pin-number sch-pin-number" x="178.93755824794" y="489.468779123972" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="33.550792171485px" transform=""></text><line class="component-pin sch-component-pin sch-port-line" x1="313.14072693388005" y1="493.94221808017" x2="402.60950605784" y2="493.94221808017" stroke-width="4.473438956198px"/><g class="sch-port" data-schematic-port-id="source_port_0_4__stack1"><rect x="398.136067101642" y="489.468779123972" width="8.946877912396" height="8.946877912396" opacity="0"/></g><text class="pin-number sch-pin-number" x="357.87511649586" y="489.468779123972" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="33.550792171485px" transform=""></text><line class="component-pin sch-component-pin sch-port-line" x1="313.14072693388005" y1="449.20782851819" x2="398.136067101642" y2="449.20782851819" stroke-width="4.473438956198px"/><g class="sch-port" data-schematic-port-id="source_port_0_5__stack1"><circle class="component-pin sch-component-pin sch-port-terminal" cx="402.60950605784" cy="449.20782851819" r="4.473438956198" stroke-width="4.473438956198px"/><rect x="398.136067101642" y="444.73438956199203" width="8.946877912396" height="8.946877912396" opacity="0"/></g><text class="pin-number sch-pin-number" x="357.87511649586" y="444.734389561992" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="33.550792171485px" transform=""></text><line class="component-pin sch-component-pin sch-port-line" x1="313.14072693388005" y1="404.47343895621" x2="398.136067101642" y2="404.47343895621" stroke-width="4.473438956198px"/><g class="sch-port" data-schematic-port-id="source_port_0_6__stack1"><circle class="component-pin sch-component-pin sch-port-terminal" cx="402.60950605784" cy="404.47343895621" r="4.473438956198" stroke-width="4.473438956198px"/><rect x="398.136067101642" y="400.000000000012" width="8.946877912396" height="8.946877912396" opacity="0"/></g><text class="pin-number sch-pin-number" x="357.87511649586" y="400.000000000012" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="33.550792171485px" transform=""></text><line class="component-pin sch-component-pin sch-port-line" x1="313.14072693388005" y1="359.73904939423" x2="398.136067101642" y2="359.73904939423" stroke-width="4.473438956198px"/><g class="sch-port" data-schematic-port-id="source_port_0_7__stack1"><circle class="component-pin sch-component-pin sch-port-terminal" cx="402.60950605784" cy="359.73904939423" r="4.473438956198" stroke-width="4.473438956198px"/><rect x="398.136067101642" y="355.265610438032" width="8.946877912396" height="8.946877912396" opacity="0"/></g><text class="pin-number sch-pin-number" x="357.87511649586" y="355.265610438032" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="33.550792171485px" transform=""></text></g><g class="sch-component" data-circuit-json-type="schematic_component" data-schematic-component-id="schematic_component_1__stack1"><rect class="component chip sch-component-body" x="902.5163094129665" y="294.874184529359" width="73.811742777267" height="204.6598322460585" stroke-width="4.473438956198px" fill="rgb(255, 255, 194)" stroke="rgb(132, 0, 0)"/><rect class="component-overlay sch-component-overlay" x="902.5163094129665" y="294.874184529359" width="73.811742777267" height="204.6598322460585" fill="transparent"/><line class="component-pin sch-component-pin sch-port-line" x1="902.5163094129665" y1="426.8406337372" x2="813.0475302890065" y2="426.8406337372" stroke-width="4.473438956198px"/><g class="sch-port" data-schematic-port-id="source_port_1_0__stack1"><rect x="808.5740913328085" y="422.367194781002" width="8.946877912396" height="8.946877912396" opacity="0"/></g><text class="pin-number sch-pin-number" x="857.7819198509866" y="422.367194781002" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="33.550792171485px" transform=""></text><line class="component-pin sch-component-pin sch-port-line" x1="976.3280521902335" y1="426.8406337372" x2="1061.3233923579955" y2="426.8406337372" stroke-width="4.473438956198px"/><g class="sch-port" data-schematic-port-id="source_port_1_1__stack1"><circle class="component-pin sch-component-pin sch-port-terminal" cx="1065.7968313141935" cy="426.8406337372" r="4.473438956198" stroke-width="4.473438956198px"/><rect x="1061.3233923579955" y="422.367194781002" width="8.946877912396" height="8.946877912396" opacity="0"/></g><text class="pin-number sch-pin-number" x="1021.0624417522134" y="422.367194781002" style="font-family: sans-serif;" fill="rgb(169, 0, 0)" text-anchor="middle" dominant-baseline="auto" font-size="33.550792171485px" transform=""></text></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_0_0__stack1"><circle cx="134.20316868596" cy="359.73904939423" r="8.946877912396" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_0_1__stack1"><circle cx="134.20316868596" cy="404.47343895621" r="8.946877912396" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_0_2__stack1"><circle cx="134.20316868596" cy="449.20782851819" r="8.946877912396" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_0_3__stack1"><circle cx="134.20316868596" cy="493.94221808017" r="8.946877912396" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_0_4__stack1"><circle cx="402.60950605784" cy="493.94221808017" r="8.946877912396" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_0_5__stack1"><circle cx="402.60950605784" cy="449.20782851819" r="8.946877912396" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_0_6__stack1"><circle cx="402.60950605784" cy="404.47343895621" r="8.946877912396" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_0_7__stack1"><circle cx="402.60950605784" cy="359.73904939423" r="8.946877912396" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_1_0__stack1"><circle cx="813.0475302890065" cy="426.8406337372" r="8.946877912396" fill="red" opacity="0"/></g><g class="schematic-port-hover sch-port-hover" data-schematic-port-id="source_port_1_1__stack1"><circle cx="1065.7968313141935" cy="426.8406337372" r="8.946877912396" fill="red" opacity="0"/></g><text class="sch-text" x="250.512581547108" y="289.2823858341115" fill="#7e22ce" text-anchor="middle" dominant-baseline="middle" font-family="sans-serif" font-size="40.260950605782px" transform="rotate(0, 250.512581547108, 289.2823858341115)">U1</text><text class="sch-text" x="607.8285181734233" y="395.526561043814" fill="#047857" text-anchor="middle" dominant-baseline="middle" font-family="sans-serif" font-size="40.260950605782px" transform="rotate(0, 607.8285181734233, 395.526561043814)">XXXXXXXXXXXXXX</text><rect class="schematic-box sch-box" x="210.251630941326" y="261.323392357874" width="80.52190121156403" height="55.91798695247496" stroke-width="4.473438956198px" stroke="rgb(132, 0, 0)" fill="transparent" stroke-dasharray="35.787511649584 17.893755824792"/>
   </g>
 </svg>

package/tests/solvers/MspConnectionPairSolver/msp-connection-pair-solver-ground-net-rows.test.ts

@@ -0,0 +1,57 @@
+import { expect, test } from "bun:test"
+import { MspConnectionPairSolver } from "lib/solvers/MspConnectionPairSolver/MspConnectionPairSolver"
+import type { InputNetConnection, InputProblem } from "lib/types/InputProblem"
+import inputProblemJson from "../../repros/assets/repro-bluetooth-controller-ground-decoupling-groups.input.json"
+
+function solveNetPairs({
+  inputProblem,
+  netConnection,
+}: {
+  inputProblem: InputProblem
+  netConnection: InputNetConnection
+}) {
+  const netPinIds = new Set(netConnection.pinIds)
+  const solver = new MspConnectionPairSolver({ inputProblem })
+
+  solver.solve()
+
+  return solver.mspConnectionPairs.filter((pair) =>
+    pair.pins.every((pin) => netPinIds.has(pin.pinId)),
+  )
+}
+
+test("keeps grouped ground rails in separate rows", () => {
+  const inputProblem = inputProblemJson as InputProblem
+  const groundConnection = inputProblem.netConnections.find(
+    (connection) => connection.isGround,
+  )!
+  const groundPairs = solveNetPairs({
+    inputProblem,
+    netConnection: groundConnection,
+  })
+  const crossRowPairs = groundPairs.filter(
+    (pair) => pair.pins[0].y !== pair.pins[1].y,
+  )
+
+  expect(groundPairs).toHaveLength(5)
+  expect(crossRowPairs).toHaveLength(0)
+})
+
+test("does not separate rows without ground metadata", () => {
+  const inputProblem = structuredClone(inputProblemJson) as InputProblem
+  const groundConnection = inputProblem.netConnections.find(
+    (connection) => connection.isGround,
+  )!
+  groundConnection.isGround = false
+
+  const netPairs = solveNetPairs({
+    inputProblem,
+    netConnection: groundConnection,
+  })
+  const crossRowPairs = netPairs.filter(
+    (pair) => pair.pins[0].y !== pair.pins[1].y,
+  )
+
+  expect(netPairs).toHaveLength(6)
+  expect(crossRowPairs).toHaveLength(1)
+})