@tscircuit/schematic-trace-solver 0.0.153 → 0.0.154

package/dist/index.js

@@ -12139,6 +12139,7 @@ var pathEntersAnyNetLabel = ({
 // lib/solvers/SameNetJunctionAlignmentSolver/alignSameNetJunctions.ts
 var MAX_ALIGNED_LOAD_PIN_OFFSET = 0.2;
 var MAX_SAME_NET_LABEL_BOUNDARY_RAIL_OFFSET = 0.2;
+var MAX_SHARED_PIN_RAIL_OFFSET = 0.05;
 var getSharedPin = ({
   donorTrace,
   branchTrace
@@ -12178,6 +12179,28 @@ var railIsOnFacingSide = ({
   if (pin._facingDirection === "y+") return railY > pin.y;
   return false;
 };
+var railIsOnSharedPinFacingSide = ({
+  railY,
+  pin
+}) => {
+  if (pin._facingDirection === "y+") return railY > pin.y;
+  if (pin._facingDirection === "y-") return railY < pin.y;
+  return false;
+};
+var getHorizontalPinApproachPoint = ({
+  branchTrace,
+  sharedPin,
+  otherPin
+}) => {
+  if (otherPin._facingDirection !== "x-" && otherPin._facingDirection !== "x+") {
+    return null;
+  }
+  const sharedToOtherPath = branchTrace.pins[0].pinId === sharedPin.pinId ? branchTrace.tracePath : [...branchTrace.tracePath].reverse();
+  const approachPoint = sharedToOtherPath.at(-2);
+  if (!approachPoint || !nearlyEqual(approachPoint.y, otherPin.y)) return null;
+  const approachesFromFacingSide = otherPin._facingDirection === "x-" ? approachPoint.x < otherPin.x : approachPoint.x > otherPin.x;
+  return approachesFromFacingSide ? approachPoint : null;
+};
 var getAttachedLabelIndexes = (trace, netLabelPlacements) => netLabelPlacements.flatMap((label, index) => {
   const labelOwnsTrace = label.mspConnectionPairIds.includes(trace.mspPairId) || label.mspConnectionPairIds.length === 0 && label.globalConnNetId === trace.globalConnNetId;
   return labelOwnsTrace && tracePathContainsPoint(trace.tracePath, label.anchorPoint) ? [index] : [];
@@ -12226,19 +12249,45 @@ var getAlignedBranchPath = ({
   if (branchRail && nearlyEqual(branchRail.start.y, donorRail.start.y)) {
     return null;
   }
-  if (!railIsOnFacingSide({ railY: donorRail.start.y, pin: otherPin })) {
+  const railFacesOtherPin = railIsOnFacingSide({
+    railY: donorRail.start.y,
+    pin: otherPin
+  });
+  const railFacesSharedPin = railIsOnSharedPinFacingSide({
+    railY: donorRail.start.y,
+    pin: sharedPin
+  }) && Math.abs(donorRail.start.y - sharedPin.y) <= MAX_SHARED_PIN_RAIL_OFFSET;
+  if (!railFacesOtherPin && !railFacesSharedPin) {
     return null;
   }
   const junction = getJunctionPoint({ segment: donorRail, sharedPin });
   const extendsDonorRail = donorOtherPin.x < junction.x && otherPin.x > junction.x || donorOtherPin.x > junction.x && otherPin.x < junction.x;
   if (!extendsDonorRail) return null;
-  const sharedToOther = simplifyPath([
-    { x: sharedPin.x, y: sharedPin.y },
-    { x: junction.x, y: sharedPin.y },
-    { x: junction.x, y: junction.y },
-    { x: otherPin.x, y: junction.y },
-    { x: otherPin.x, y: otherPin.y }
-  ]);
+  let sharedToOther;
+  if (!railFacesOtherPin && railFacesSharedPin) {
+    const approachPoint = getHorizontalPinApproachPoint({
+      branchTrace,
+      sharedPin,
+      otherPin
+    });
+    if (!approachPoint) return null;
+    sharedToOther = simplifyPath([
+      { x: sharedPin.x, y: sharedPin.y },
+      { x: junction.x, y: sharedPin.y },
+      { x: junction.x, y: junction.y },
+      { x: approachPoint.x, y: junction.y },
+      { x: approachPoint.x, y: otherPin.y },
+      { x: otherPin.x, y: otherPin.y }
+    ]);
+  } else {
+    sharedToOther = simplifyPath([
+      { x: sharedPin.x, y: sharedPin.y },
+      { x: junction.x, y: sharedPin.y },
+      { x: junction.x, y: junction.y },
+      { x: otherPin.x, y: junction.y },
+      { x: otherPin.x, y: otherPin.y }
+    ]);
+  }
   if (branchTrace.pins[0].pinId === sharedPin.pinId) return sharedToOther;
   return [...sharedToOther].reverse();
 };

package/lib/solvers/SameNetJunctionAlignmentSolver/alignSameNetJunctions.ts

@@ -34,6 +34,9 @@ interface HorizontalSegment {
 const MAX_ALIGNED_LOAD_PIN_OFFSET = 0.2
 // Limit label-boundary alignment to small corrections that cannot create spikes.
 const MAX_SAME_NET_LABEL_BOUNDARY_RAIL_OFFSET = 0.2
+// A shared vertical pin can anchor an existing rail when the rail is only a
+// symbol-stem correction away from the pin itself.
+const MAX_SHARED_PIN_RAIL_OFFSET = 0.05
 
 const getSharedPin = ({
   donorTrace,
@@ -96,6 +99,48 @@ const railIsOnFacingSide = ({
   return false
 }
 
+const railIsOnSharedPinFacingSide = ({
+  railY,
+  pin,
+}: {
+  railY: number
+  pin: InputPin
+}) => {
+  if (pin._facingDirection === "y+") return railY > pin.y
+  if (pin._facingDirection === "y-") return railY < pin.y
+  return false
+}
+
+const getHorizontalPinApproachPoint = ({
+  branchTrace,
+  sharedPin,
+  otherPin,
+}: {
+  branchTrace: SolvedTracePath
+  sharedPin: InputPin
+  otherPin: InputPin
+}): Point | null => {
+  if (
+    otherPin._facingDirection !== "x-" &&
+    otherPin._facingDirection !== "x+"
+  ) {
+    return null
+  }
+
+  const sharedToOtherPath =
+    branchTrace.pins[0].pinId === sharedPin.pinId
+      ? branchTrace.tracePath
+      : [...branchTrace.tracePath].reverse()
+  const approachPoint = sharedToOtherPath.at(-2)
+  if (!approachPoint || !nearlyEqual(approachPoint.y, otherPin.y)) return null
+
+  const approachesFromFacingSide =
+    otherPin._facingDirection === "x-"
+      ? approachPoint.x < otherPin.x
+      : approachPoint.x > otherPin.x
+  return approachesFromFacingSide ? approachPoint : null
+}
+
 const getAttachedLabelIndexes = (
   trace: SolvedTracePath,
   netLabelPlacements: NetLabelPlacement[],
@@ -165,7 +210,17 @@ const getAlignedBranchPath = ({
   if (branchRail && nearlyEqual(branchRail.start.y, donorRail.start.y)) {
     return null
   }
-  if (!railIsOnFacingSide({ railY: donorRail.start.y, pin: otherPin })) {
+  const railFacesOtherPin = railIsOnFacingSide({
+    railY: donorRail.start.y,
+    pin: otherPin,
+  })
+  const railFacesSharedPin =
+    railIsOnSharedPinFacingSide({
+      railY: donorRail.start.y,
+      pin: sharedPin,
+    }) &&
+    Math.abs(donorRail.start.y - sharedPin.y) <= MAX_SHARED_PIN_RAIL_OFFSET
+  if (!railFacesOtherPin && !railFacesSharedPin) {
     return null
   }
 
@@ -175,13 +230,31 @@ const getAlignedBranchPath = ({
     (donorOtherPin.x > junction.x && otherPin.x < junction.x)
   if (!extendsDonorRail) return null
 
-  const sharedToOther = simplifyPath([
-    { x: sharedPin.x, y: sharedPin.y },
-    { x: junction.x, y: sharedPin.y },
-    { x: junction.x, y: junction.y },
-    { x: otherPin.x, y: junction.y },
-    { x: otherPin.x, y: otherPin.y },
-  ])
+  let sharedToOther: Point[]
+  if (!railFacesOtherPin && railFacesSharedPin) {
+    const approachPoint = getHorizontalPinApproachPoint({
+      branchTrace,
+      sharedPin,
+      otherPin,
+    })
+    if (!approachPoint) return null
+    sharedToOther = simplifyPath([
+      { x: sharedPin.x, y: sharedPin.y },
+      { x: junction.x, y: sharedPin.y },
+      { x: junction.x, y: junction.y },
+      { x: approachPoint.x, y: junction.y },
+      { x: approachPoint.x, y: otherPin.y },
+      { x: otherPin.x, y: otherPin.y },
+    ])
+  } else {
+    sharedToOther = simplifyPath([
+      { x: sharedPin.x, y: sharedPin.y },
+      { x: junction.x, y: sharedPin.y },
+      { x: junction.x, y: junction.y },
+      { x: otherPin.x, y: junction.y },
+      { x: otherPin.x, y: otherPin.y },
+    ])
+  }
 
   if (branchTrace.pins[0].pinId === sharedPin.pinId) return sharedToOther
   return [...sharedToOther].reverse()

package/package.json

@@ -5,7 +5,7 @@
     "url": "https://github.com/tscircuit/schematic-trace-solver.git"
   },
   "main": "dist/index.js",
-  "version": "0.0.153",
+  "version": "0.0.154",
   "type": "module",
   "scripts": {
     "start": "cosmos",

package/site/bug-reports/bug-report-20260825T103621Z.page.tsx

@@ -0,0 +1,4 @@
+import { PipelineDebugger } from "site/components/PipelineDebugger"
+import inputProblem from "../../tests/bug-reports/bug-report-20260825T103621Z/bug-report-20260825T103621Z.json"
+
+export default () => <PipelineDebugger inputProblem={inputProblem as any} />