@tscircuit/schematic-trace-solver 0.0.119 → 0.0.121

package/tests/repros/assets/repro-bq25895-cross-net-trace-overlap.input.json

@@ -0,0 +1,498 @@
+{
+  "chips": [
+    {
+      "chipId": "schematic_component_0",
+      "center": {
+        "x": 0,
+        "y": 0
+      },
+      "width": 3.4000000000000004,
+      "height": 7.5,
+      "pins": [
+        {
+          "pinId": "schematic_port_0",
+          "x": -1.7000000000000002,
+          "y": 1.5000000000000004
+        },
+        {
+          "pinId": "schematic_port_1",
+          "x": -1.7000000000000002,
+          "y": 0.7500000000000004
+        },
+        {
+          "pinId": "schematic_port_2",
+          "x": -1.7000000000000002,
+          "y": 0.5000000000000004
+        },
+        {
+          "pinId": "schematic_port_3",
+          "x": -1.7000000000000002,
+          "y": -0.9500000000000002
+        },
+        {
+          "pinId": "schematic_port_4",
+          "x": -1.7000000000000002,
+          "y": -1.8500000000000005
+        },
+        {
+          "pinId": "schematic_port_5",
+          "x": -1.7000000000000002,
+          "y": -1.6000000000000005
+        },
+        {
+          "pinId": "schematic_port_6",
+          "x": -1.7000000000000002,
+          "y": -2.1000000000000005
+        },
+        {
+          "pinId": "schematic_port_7",
+          "x": -1.7000000000000002,
+          "y": -2.3500000000000005
+        },
+        {
+          "pinId": "schematic_port_8",
+          "x": -1.7000000000000002,
+          "y": -2.6000000000000005
+        },
+        {
+          "pinId": "schematic_port_9",
+          "x": -1.7000000000000002,
+          "y": -0.04999999999999982
+        },
+        {
+          "pinId": "schematic_port_10",
+          "x": 1.7000000000000002,
+          "y": -2.6950000000000003
+        },
+        {
+          "pinId": "schematic_port_11",
+          "x": 1.7000000000000002,
+          "y": -1.5450000000000004
+        },
+        {
+          "pinId": "schematic_port_12",
+          "x": 1.7000000000000002,
+          "y": -0.8950000000000005
+        },
+        {
+          "pinId": "schematic_port_13",
+          "x": 1.7000000000000002,
+          "y": -0.24500000000000055
+        },
+        {
+          "pinId": "schematic_port_14",
+          "x": 1.7000000000000002,
+          "y": 0.5549999999999997
+        },
+        {
+          "pinId": "schematic_port_15",
+          "x": 1.7000000000000002,
+          "y": 2.6950000000000003
+        },
+        {
+          "pinId": "schematic_port_16",
+          "x": 1.7000000000000002,
+          "y": 1.505
+        },
+        {
+          "pinId": "schematic_port_17",
+          "x": 1.7000000000000002,
+          "y": 1.255
+        },
+        {
+          "pinId": "schematic_port_18",
+          "x": -1.7000000000000002,
+          "y": 2.6000000000000005
+        }
+      ]
+    },
+    {
+      "chipId": "schematic_component_1",
+      "center": {
+        "x": -10.8,
+        "y": 1.4
+      },
+      "width": 2.3999999999999986,
+      "height": 1,
+      "pins": [
+        {
+          "pinId": "schematic_port_19",
+          "x": -9.600000000000001,
+          "y": 1.7
+        },
+        {
+          "pinId": "schematic_port_20",
+          "x": -9.600000000000001,
+          "y": 1.5
+        },
+        {
+          "pinId": "schematic_port_21",
+          "x": -9.600000000000001,
+          "y": 1.2999999999999998
+        },
+        {
+          "pinId": "schematic_port_22",
+          "x": -9.600000000000001,
+          "y": 1.0999999999999999
+        }
+      ]
+    },
+    {
+      "chipId": "schematic_component_2",
+      "center": {
+        "x": -4.5,
+        "y": 4.05
+      },
+      "width": 2.2,
+      "height": 0.5999999999999996,
+      "pins": [
+        {
+          "pinId": "schematic_port_23",
+          "x": -3.4,
+          "y": 4.1499999999999995
+        },
+        {
+          "pinId": "schematic_port_24",
+          "x": -3.4,
+          "y": 3.9499999999999997
+        }
+      ]
+    },
+    {
+      "chipId": "schematic_component_3",
+      "center": {
+        "x": -5.9875,
+        "y": 1.45
+      },
+      "width": 0.9250000000000007,
+      "height": 0.7599999999999998,
+      "pins": [
+        {
+          "pinId": "schematic_port_25",
+          "x": -6,
+          "y": 1.8299999999999998,
+          "_facingDirection": "y+"
+        },
+        {
+          "pinId": "schematic_port_26",
+          "x": -6,
+          "y": 1.07,
+          "_facingDirection": "y-"
+        }
+      ]
+    },
+    {
+      "chipId": "schematic_component_4",
+      "center": {
+        "x": -2.6375,
+        "y": 3.3
+      },
+      "width": 1.0250000000000004,
+      "height": 0.7600000000000007,
+      "pins": [
+        {
+          "pinId": "schematic_port_27",
+          "x": -2.7,
+          "y": 2.9199999999999995,
+          "_facingDirection": "y-"
+        },
+        {
+          "pinId": "schematic_port_28",
+          "x": -2.7,
+          "y": 3.68,
+          "_facingDirection": "y+"
+        }
+      ]
+    },
+    {
+      "chipId": "schematic_component_5",
+      "center": {
+        "x": -10.8,
+        "y": -3.25
+      },
+      "width": 2.3000000000000007,
+      "height": 1.4000000000000004,
+      "pins": [
+        {
+          "pinId": "schematic_port_29",
+          "x": -9.65,
+          "y": -2.75
+        },
+        {
+          "pinId": "schematic_port_30",
+          "x": -9.65,
+          "y": -2.95
+        },
+        {
+          "pinId": "schematic_port_31",
+          "x": -9.65,
+          "y": -3.15
+        },
+        {
+          "pinId": "schematic_port_32",
+          "x": -9.65,
+          "y": -3.35
+        },
+        {
+          "pinId": "schematic_port_33",
+          "x": -9.65,
+          "y": -3.55
+        },
+        {
+          "pinId": "schematic_port_34",
+          "x": -9.65,
+          "y": -3.75
+        }
+      ]
+    },
+    {
+      "chipId": "schematic_component_6",
+      "center": {
+        "x": -2.5,
+        "y": -0.05000000000000002
+      },
+      "width": 0.5999999999999996,
+      "height": 0.6799999999999999,
+      "pins": [
+        {
+          "pinId": "schematic_port_35",
+          "x": -2.2,
+          "y": -0.04999999999999997,
+          "_facingDirection": "x+"
+        },
+        {
+          "pinId": "schematic_port_36",
+          "x": -2.8,
+          "y": -0.05000000000000004,
+          "_facingDirection": "x-"
+        }
+      ]
+    },
+    {
+      "chipId": "schematic_component_7",
+      "center": {
+        "x": -5.705,
+        "y": -2.35
+      },
+      "width": 1.0899999999999999,
+      "height": 0.5999999999999996,
+      "pins": [
+        {
+          "pinId": "schematic_port_37",
+          "x": -5.8,
+          "y": -2.0500000000000003,
+          "_facingDirection": "y+"
+        },
+        {
+          "pinId": "schematic_port_38",
+          "x": -5.8,
+          "y": -2.65,
+          "_facingDirection": "y-"
+        }
+      ]
+    },
+    {
+      "chipId": "schematic_component_8",
+      "center": {
+        "x": -4.495,
+        "y": -0.75
+      },
+      "width": 1.2100000000000004,
+      "height": 0.6000000000000001,
+      "pins": [
+        {
+          "pinId": "schematic_port_39",
+          "x": -4.65,
+          "y": -0.44999999999999996,
+          "_facingDirection": "y+"
+        },
+        {
+          "pinId": "schematic_port_40",
+          "x": -4.65,
+          "y": -1.05,
+          "_facingDirection": "y-"
+        }
+      ]
+    },
+    {
+      "chipId": "schematic_component_9",
+      "center": {
+        "x": 4.35,
+        "y": 3.25
+      },
+      "width": 1.0558250000000005,
+      "height": 0.8677407000000006,
+      "pins": [
+        {
+          "pinId": "schematic_port_41",
+          "x": 3.8220874999999994,
+          "y": 3.2526245499999993
+        },
+        {
+          "pinId": "schematic_port_42",
+          "x": 4.8779125,
+          "y": 3.24737545
+        }
+      ]
+    }
+  ],
+  "directConnections": [
+    {
+      "netId": "R1.pin1 to U1.ILIM",
+      "pinIds": [
+        "schematic_port_35",
+        "schematic_port_9"
+      ]
+    },
+    {
+      "netId": "J3.pin4 to R4.pin2",
+      "pinIds": [
+        "schematic_port_32",
+        "schematic_port_38"
+      ]
+    },
+    {
+      "netId": "R4.pin2 to U1.INT",
+      "pinIds": [
+        "schematic_port_38",
+        "schematic_port_6"
+      ]
+    },
+    {
+      "netId": "J3.pin5 to U1.OTG",
+      "pinIds": [
+        "schematic_port_33",
+        "schematic_port_7"
+      ]
+    },
+    {
+      "netId": "J3.pin6 to U1.CE",
+      "pinIds": [
+        "schematic_port_34",
+        "schematic_port_8"
+      ]
+    },
+    {
+      "netId": "R5.pin1 to L1.pin2",
+      "pinIds": [
+        "schematic_port_39",
+        "schematic_port_42"
+      ]
+    }
+  ],
+  "netConnections": [
+    {
+      "netId": "GND",
+      "netLabelWidth": 0.42,
+      "netLabelHeight": 0.48,
+      "pinIds": [
+        "schematic_port_14",
+        "schematic_port_22",
+        "schematic_port_24",
+        "schematic_port_26",
+        "schematic_port_28",
+        "schematic_port_36"
+      ]
+    },
+    {
+      "netId": "VREF",
+      "netLabelWidth": 0.42,
+      "netLabelHeight": 0.6,
+      "pinIds": [
+        "schematic_port_29",
+        "schematic_port_37"
+      ]
+    }
+  ],
+  "textBoxes": [
+    {
+      "chipId": "schematic_component_0",
+      "center": {
+        "x": -0.6400000000000001,
+        "y": -3.88
+      },
+      "width": 1.3199999999999998,
+      "height": 0.17999999999999972,
+      "text": "BQ25895RTWR"
+    },
+    {
+      "chipId": "schematic_component_0",
+      "center": {
+        "x": -1.1800000000000002,
+        "y": 3.865
+      },
+      "width": 0.3600000000000001,
+      "height": 0.24999999999999956,
+      "text": "U1"
+    },
+    {
+      "chipId": "schematic_component_1",
+      "center": {
+        "x": -11.060000000000002,
+        "y": 0.7699999999999999
+      },
+      "width": 1.08,
+      "height": 0.17999999999999994,
+      "text": "USB Input"
+    },
+    {
+      "chipId": "schematic_component_1",
+      "center": {
+        "x": -11.48,
+        "y": 2.015
+      },
+      "width": 0.3600000000000012,
+      "height": 0.2500000000000002,
+      "text": "J1"
+    },
+    {
+      "chipId": "schematic_component_2",
+      "center": {
+        "x": -4.66,
+        "y": 3.62
+      },
+      "width": 1.08,
+      "height": 0.17999999999999972,
+      "text": "Phone OTG"
+    },
+    {
+      "chipId": "schematic_component_2",
+      "center": {
+        "x": -5.08,
+        "y": 4.465
+      },
+      "width": 0.35999999999999943,
+      "height": 0.2499999999999991,
+      "text": "J2"
+    },
+    {
+      "chipId": "schematic_component_5",
+      "center": {
+        "x": -11.31,
+        "y": -4.08
+      },
+      "width": 0.4800000000000004,
+      "height": 0.17999999999999972,
+      "text": "Host"
+    },
+    {
+      "chipId": "schematic_component_5",
+      "center": {
+        "x": -11.43,
+        "y": -2.4349999999999996
+      },
+      "width": 0.3600000000000012,
+      "height": 0.24999999999999956,
+      "text": "J3"
+    }
+  ],
+  "availableNetLabelOrientations": {
+    "GND": [
+      "y-"
+    ],
+    "VREF": [
+      "y+"
+    ]
+  },
+  "maxMspPairDistance": 20
+}

package/tests/repros/repro-bq25895-cross-net-trace-overlap.test.ts

@@ -0,0 +1,75 @@
+import { expect, test } from "bun:test"
+import { SchematicTracePipelineSolver } from "lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver"
+import type { SolvedTracePath } from "lib/solvers/SchematicTraceLinesSolver/SchematicTraceLinesSolver"
+import { SCHEMATIC_TRACE_MIN_VISUAL_CENTERLINE_CLEARANCE } from "lib/utils/doesPathCoincideWithTraces"
+import "tests/fixtures/matcher"
+import inputProblem from "./assets/repro-bq25895-cross-net-trace-overlap.input.json"
+
+const EPSILON = 1e-6
+
+const tracesHaveInsufficientParallelClearance = (
+  firstTrace: SolvedTracePath,
+  secondTrace: SolvedTracePath,
+) => {
+  for (
+    let firstPointIndex = 0;
+    firstPointIndex < firstTrace.tracePath.length - 1;
+    firstPointIndex++
+  ) {
+    const firstStart = firstTrace.tracePath[firstPointIndex]!
+    const firstEnd = firstTrace.tracePath[firstPointIndex + 1]!
+    const firstIsVertical = Math.abs(firstStart.x - firstEnd.x) < EPSILON
+    if (!firstIsVertical) continue
+
+    for (
+      let secondPointIndex = 0;
+      secondPointIndex < secondTrace.tracePath.length - 1;
+      secondPointIndex++
+    ) {
+      const secondStart = secondTrace.tracePath[secondPointIndex]!
+      const secondEnd = secondTrace.tracePath[secondPointIndex + 1]!
+      const secondIsVertical = Math.abs(secondStart.x - secondEnd.x) < EPSILON
+      if (!secondIsVertical) continue
+
+      const xSeparation = Math.abs(firstStart.x - secondStart.x)
+      const verticalOverlap =
+        Math.min(
+          Math.max(firstStart.y, firstEnd.y),
+          Math.max(secondStart.y, secondEnd.y),
+        ) -
+        Math.max(
+          Math.min(firstStart.y, firstEnd.y),
+          Math.min(secondStart.y, secondEnd.y),
+        )
+
+      if (
+        xSeparation + EPSILON <
+          SCHEMATIC_TRACE_MIN_VISUAL_CENTERLINE_CLEARANCE &&
+        verticalOverlap > EPSILON
+      ) {
+        return true
+      }
+    }
+  }
+
+  return false
+}
+
+test("BQ25895 CE and GND traces keep visible parallel clearance", () => {
+  const solver = new SchematicTracePipelineSolver(inputProblem as any)
+  solver.solve()
+
+  const traces = solver.netLabelTraceCollisionSolver!.getOutput().traces
+  const ceTraces = traces.filter(
+    (trace) => trace.userNetId === "J3.pin6 to U1.CE",
+  )
+  const groundTraces = traces.filter((trace) => trace.userNetId === "GND")
+  const hasInsufficientCeAndGroundClearance = ceTraces.some((ceTrace) =>
+    groundTraces.some((groundTrace) =>
+      tracesHaveInsufficientParallelClearance(ceTrace, groundTrace),
+    ),
+  )
+
+  expect(hasInsufficientCeAndGroundClearance).toBe(false)
+  expect(solver).toMatchSolverSnapshot(import.meta.path)
+})

package/tests/repros/repro-ground-label-on-lower-rail-end.test.ts

@@ -0,0 +1,84 @@
+import { expect, test } from "bun:test"
+import { SchematicTracePipelineSolver } from "lib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver"
+import type { InputProblem } from "lib/types/InputProblem"
+import "tests/fixtures/matcher"
+
+const inputProblem: InputProblem = {
+  chips: [
+    {
+      chipId: "PWR1",
+      center: { x: 0, y: 0 },
+      width: 2.1,
+      height: 1,
+      pins: [
+        { pinId: "PWR1.EP", x: 1.05, y: 0.2 },
+        { pinId: "PWR1.GND", x: -1.05, y: -0.1 },
+      ],
+    },
+    {
+      chipId: "R7",
+      center: { x: -3, y: -2 },
+      width: 0.6,
+      height: 0.68,
+      pins: [{ pinId: "R7.2", x: -2.7, y: -2, _facingDirection: "x+" }],
+    },
+    {
+      chipId: "C6",
+      center: { x: 3, y: -1.5 },
+      width: 0.6,
+      height: 0.84,
+      pins: [{ pinId: "C6.neg", x: 3.3, y: -1.5, _facingDirection: "x+" }],
+    },
+    {
+      chipId: "C7",
+      center: { x: 3, y: 0 },
+      width: 0.6,
+      height: 0.84,
+      pins: [{ pinId: "C7.neg", x: 3.3, y: 0, _facingDirection: "x+" }],
+    },
+    {
+      chipId: "LED1",
+      center: { x: 4, y: 3.1325 },
+      width: 1.13,
+      height: 0.915,
+      pins: [
+        {
+          pinId: "LED1.neg",
+          x: 4.565,
+          y: 3,
+          _facingDirection: "x+",
+        },
+      ],
+    },
+  ],
+  directConnections: [],
+  netConnections: [
+    {
+      netId: "gnd",
+      pinIds: ["PWR1.EP", "PWR1.GND", "R7.2", "C6.neg", "C7.neg", "LED1.neg"],
+      netLabelWidth: 0.42,
+      netLabelHeight: 0.48,
+    },
+  ],
+  textBoxes: [],
+  availableNetLabelOrientations: { gnd: ["y-"] },
+  maxMspPairDistance: 2.4,
+}
+
+test("places a shared capacitor GND label at the lower rail end", () => {
+  const solver = new SchematicTracePipelineSolver(inputProblem)
+
+  solver.solve()
+
+  const gndLabels = solver
+    .netLabelNetLabelCollisionSolver!.getOutput()
+    .netLabelPlacements.filter((label) => label.netId === "gnd")
+  const capacitorRailLabel = gndLabels.find(
+    (label) => Math.abs(label.anchorPoint.x - 3.3) < 1,
+  )!
+
+  expect(capacitorRailLabel.orientation).toBe("y-")
+  expect(capacitorRailLabel.anchorPoint.y).toBeCloseTo(-1.5)
+  expect(capacitorRailLabel.anchorPoint.x).toBeGreaterThan(3.3)
+  expect(solver).toMatchSolverSnapshot(import.meta.path)
+})