@tscircuit/core 0.0.829 → 0.0.830

package/dist/index.d.ts

@@ -1040,6 +1040,11 @@ declare class Port extends PrimitiveComponent<typeof portProps> {
     doInitialSourceParentAttachment(): void;
     doInitialPcbPortRender(): void;
     updatePcbPortRender(): void;
+    /**
+     * Get the best display label for this port based on port_hints
+     * Filters out generic patterns and applies showPinAliases logic
+     */
+    _getBestDisplayPinLabel(): string | undefined;
     doInitialSchematicPortRender(): void;
     _getSubcircuitConnectivityKey(): string | undefined;
     _setPositionFromLayout(newCenter: {
@@ -1189,6 +1194,10 @@ declare class NormalComponent<ZodProps extends z.ZodType = any, PortNames extend
      * appear on a schematic box, e.g. for a pin header
      */
     _getSchematicPortArrangement(): SchematicPortArrangement | null;
+    /**
+     * Extract pin labels from ports using existing Port logic
+     */
+    _getPinLabelsFromPorts(): Record<string, string>;
     _getSchematicBoxDimensions(): SchematicBoxDimensions | null;
     getFootprinterString(): string | null;
     doInitialCadModelRender(): void;

package/dist/index.js

@@ -3829,6 +3829,29 @@ var Port = class extends PrimitiveComponent2 {
     });
     this.pcb_port_id = pcb_port.pcb_port_id;
   }
+  /**
+   * Get the best display label for this port based on port_hints
+   * Filters out generic patterns and applies showPinAliases logic
+   */
+  _getBestDisplayPinLabel() {
+    const { db } = this.root;
+    const sourcePort = db.source_port.get(this.source_port_id);
+    const labelHints = [];
+    for (const portHint of sourcePort?.port_hints ?? []) {
+      if (portHint.match(/^(pin)?\d+$/)) continue;
+      if (portHint.match(/^(left|right)/) && !sourcePort?.name.match(/^(left|right)/))
+        continue;
+      labelHints.push(portHint);
+    }
+    const parentNormalComponent = this.getParentNormalComponent();
+    const showPinAliases = parentNormalComponent?.props?.showPinAliases;
+    if (showPinAliases && labelHints.length > 0) {
+      return labelHints.join("/");
+    } else if (labelHints.length > 0) {
+      return labelHints[0];
+    }
+    return void 0;
+  }
   doInitialSchematicPortRender() {
     const { db } = this.root;
     const { _parsedProps: props } = this;
@@ -3864,22 +3887,8 @@ var Port = class extends PrimitiveComponent2 {
         bottom: "down"
       }[localPortInfo.side];
     }
-    const sourcePort = db.source_port.get(this.source_port_id);
-    const labelHints = [];
-    for (const portHint of sourcePort?.port_hints ?? []) {
-      if (portHint.match(/^(pin)?\d+$/)) continue;
-      if (portHint.match(/^(left|right)/) && !sourcePort?.name.match(/^(left|right)/))
-        continue;
-      labelHints.push(portHint);
-    }
-    let bestDisplayPinLabel = void 0;
+    const bestDisplayPinLabel = this._getBestDisplayPinLabel();
     const parentNormalComponent = this.getParentNormalComponent();
-    const showPinAliases = parentNormalComponent?.props?.showPinAliases;
-    if (showPinAliases && labelHints.length > 0) {
-      bestDisplayPinLabel = labelHints.join("/");
-    } else if (labelHints.length > 0) {
-      bestDisplayPinLabel = labelHints[0];
-    }
     const schematicPortInsertProps = {
       type: "schematic_port",
       schematic_component_id: parentNormalComponent?.schematic_component_id,
@@ -3980,6 +3989,7 @@ var getSizeOfSidesFromPortArrangement = (pa) => {
 };
 
 // lib/utils/schematic/getAllDimensionsForSchematicBox.ts
+var DEFAULT_SCHEMATIC_BOX_PADDING_MM = 0.4;
 function isExplicitPinMappingArrangement(arrangement) {
   const a = arrangement;
   return a.leftSide !== void 0 || a.rightSide !== void 0 || a.topSide !== void 0 || a.bottomSide !== void 0;
@@ -4157,12 +4167,24 @@ var getAllDimensionsForSchematicBox = (params) => {
     }
     truePinIndex++;
   }
-  let schWidth = params.schWidth;
-  if (schWidth === void 0) {
-    schWidth = Math.max(
-      sideLengths.top + params.schPinSpacing * 2,
-      sideLengths.bottom + params.schPinSpacing * 2
+  let resolvedSchWidth = params.schWidth;
+  if (resolvedSchWidth === void 0) {
+    resolvedSchWidth = Math.max(
+      sideLengths.top + DEFAULT_SCHEMATIC_BOX_PADDING_MM,
+      sideLengths.bottom + DEFAULT_SCHEMATIC_BOX_PADDING_MM
     );
+    if (params.pinLabels) {
+      const leftRightPins = orderedTruePorts.filter(
+        (p) => p.side === "left" || p.side === "right"
+      );
+      const hasLeftRightLabels = leftRightPins.some(
+        (p) => params.pinLabels?.[`pin${p.pinNumber}`] || params.pinLabels?.[p.pinNumber]
+      );
+      if (hasLeftRightLabels) {
+        const MIN_WIDTH_FOR_SIDE_PINS = 0.5;
+        resolvedSchWidth = Math.max(resolvedSchWidth, MIN_WIDTH_FOR_SIDE_PINS);
+      }
+    }
     const labelWidth = params.pinLabels ? Math.max(
       ...Object.values(params.pinLabels).map(
         (label) => label.length * 0.1
@@ -4170,19 +4192,19 @@ var getAllDimensionsForSchematicBox = (params) => {
       )
     ) : 0;
     const LABEL_PADDING = labelWidth > 0 ? 1.1 : 0;
-    schWidth = Math.max(schWidth, labelWidth + LABEL_PADDING);
+    resolvedSchWidth = Math.max(resolvedSchWidth, labelWidth + LABEL_PADDING);
   }
   let schHeight = params.schHeight;
   if (!schHeight) {
     schHeight = Math.max(
-      sideLengths.left + params.schPinSpacing * 2,
-      sideLengths.right + params.schPinSpacing * 2
+      sideLengths.left + DEFAULT_SCHEMATIC_BOX_PADDING_MM,
+      sideLengths.right + DEFAULT_SCHEMATIC_BOX_PADDING_MM
     );
   }
   const trueEdgePositions = {
     // Top left corner
     left: {
-      x: -schWidth / 2 - portDistanceFromEdge,
+      x: -resolvedSchWidth / 2 - portDistanceFromEdge,
       y: sideLengths.left / 2
     },
     // bottom left corner
@@ -4192,7 +4214,7 @@ var getAllDimensionsForSchematicBox = (params) => {
     },
     // bottom right corner
     right: {
-      x: schWidth / 2 + portDistanceFromEdge,
+      x: resolvedSchWidth / 2 + portDistanceFromEdge,
       y: -sideLengths.right / 2
     },
     // top right corner
@@ -4228,11 +4250,11 @@ var getAllDimensionsForSchematicBox = (params) => {
       return port;
     },
     getSize() {
-      return { width: schWidth, height: schHeight };
+      return { width: resolvedSchWidth, height: schHeight };
     },
     getSizeIncludingPins() {
       return {
-        width: schWidth + (sidePinCounts.leftSize || sidePinCounts.rightSize ? 0.4 : 0),
+        width: resolvedSchWidth + (sidePinCounts.leftSize || sidePinCounts.rightSize ? 0.4 : 0),
         height: schHeight + (sidePinCounts.topSize || sidePinCounts.bottomSize ? 0.4 : 0)
       };
     },
@@ -8405,23 +8427,45 @@ var NormalComponent3 = class extends PrimitiveComponent2 {
   _getSchematicPortArrangement() {
     return this._parsedProps.schPinArrangement ?? this._parsedProps.schPortArrangement;
   }
+  /**
+   * Extract pin labels from ports using existing Port logic
+   */
+  _getPinLabelsFromPorts() {
+    const ports = this.selectAll("port");
+    const pinLabels = {};
+    for (const port of ports) {
+      const pinNumber = port.props.pinNumber;
+      if (pinNumber !== void 0) {
+        const bestLabel = port._getBestDisplayPinLabel();
+        if (bestLabel) {
+          pinLabels[`pin${pinNumber}`] = bestLabel;
+        }
+      }
+    }
+    return pinLabels;
+  }
   _getSchematicBoxDimensions() {
     if (this.getSchematicSymbol()) return null;
     if (!this.config.shouldRenderAsSchematicBox) return null;
     const { _parsedProps: props } = this;
     const pinCount = this._getPinCount();
     const pinSpacing = props.schPinSpacing ?? 0.2;
+    const pinLabelsFromPorts = this._getPinLabelsFromPorts();
+    const allPinLabels = {
+      ...pinLabelsFromPorts,
+      ...props.pinLabels
+    };
     const dimensions = getAllDimensionsForSchematicBox({
       schWidth: props.schWidth,
       schHeight: props.schHeight,
       schPinSpacing: pinSpacing,
       numericSchPinStyle: getNumericSchPinStyle(
         props.schPinStyle,
-        props.pinLabels
+        allPinLabels
       ),
       pinCount,
       schPortArrangement: this._getSchematicPortArrangement(),
-      pinLabels: props.pinLabels
+      pinLabels: allPinLabels
     });
     return dimensions;
   }
@@ -17365,7 +17409,7 @@ import { identity as identity6 } from "transformation-matrix";
 var package_default = {
   name: "@tscircuit/core",
   type: "module",
-  version: "0.0.828",
+  version: "0.0.829",
   types: "dist/index.d.ts",
   main: "dist/index.js",
   module: "dist/index.js",

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@tscircuit/core",
   "type": "module",
-  "version": "0.0.829",
+  "version": "0.0.830",
   "types": "dist/index.d.ts",
   "main": "dist/index.js",
   "module": "dist/index.js",