@tscircuit/core 0.0.32 → 0.0.33

package/dist/index.d.ts

@@ -3348,6 +3348,7 @@ declare class PlatedHole extends PrimitiveComponent<typeof platedHoleProps> {
                 name: "top" | "bottom" | "inner1" | "inner2" | "inner3" | "inner4" | "inner5" | "inner6";
             }>>;
         }, "pcbRotation" | "layer">, {
+            name: zod.ZodOptional<zod.ZodString>;
             shape: zod.ZodLiteral<"circle">;
             holeDiameter: zod.ZodEffects<zod.ZodUnion<[zod.ZodString, zod.ZodNumber]>, number, string | number>;
             outerDiameter: zod.ZodEffects<zod.ZodUnion<[zod.ZodString, zod.ZodNumber]>, number, string | number>;
@@ -3358,6 +3359,7 @@ declare class PlatedHole extends PrimitiveComponent<typeof platedHoleProps> {
             outerDiameter: number;
             pcbX?: number | undefined;
             pcbY?: number | undefined;
+            name?: string | undefined;
             portHints?: (string | number)[] | undefined;
         }, {
             shape: "circle";
@@ -3365,6 +3367,7 @@ declare class PlatedHole extends PrimitiveComponent<typeof platedHoleProps> {
             outerDiameter: string | number;
             pcbX?: string | number | undefined;
             pcbY?: string | number | undefined;
+            name?: string | undefined;
             portHints?: (string | number)[] | undefined;
         }>, zod.ZodObject<zod.objectUtil.extendShape<Omit<{
             pcbX: zod.ZodOptional<zod.ZodEffects<zod.ZodUnion<[zod.ZodString, zod.ZodNumber]>, number, string | number>>;
@@ -3380,6 +3383,7 @@ declare class PlatedHole extends PrimitiveComponent<typeof platedHoleProps> {
                 name: "top" | "bottom" | "inner1" | "inner2" | "inner3" | "inner4" | "inner5" | "inner6";
             }>>;
         }, "pcbRotation" | "layer">, {
+            name: zod.ZodOptional<zod.ZodString>;
             shape: zod.ZodLiteral<"oval">;
             outerWidth: zod.ZodEffects<zod.ZodUnion<[zod.ZodString, zod.ZodNumber]>, number, string | number>;
             outerHeight: zod.ZodEffects<zod.ZodUnion<[zod.ZodString, zod.ZodNumber]>, number, string | number>;
@@ -3394,6 +3398,7 @@ declare class PlatedHole extends PrimitiveComponent<typeof platedHoleProps> {
             innerHeight: number;
             pcbX?: number | undefined;
             pcbY?: number | undefined;
+            name?: string | undefined;
             portHints?: (string | number)[] | undefined;
         }, {
             shape: "oval";
@@ -3403,6 +3408,7 @@ declare class PlatedHole extends PrimitiveComponent<typeof platedHoleProps> {
             innerHeight: string | number;
             pcbX?: string | number | undefined;
             pcbY?: string | number | undefined;
+            name?: string | undefined;
             portHints?: (string | number)[] | undefined;
         }>]>;
     };
@@ -3410,6 +3416,24 @@ declare class PlatedHole extends PrimitiveComponent<typeof platedHoleProps> {
         width: number;
         height: number;
     };
+    _getCircuitJsonBounds(): {
+        center: {
+            x: number;
+            y: number;
+        };
+        bounds: {
+            left: number;
+            top: number;
+            right: number;
+            bottom: number;
+        };
+        width: number;
+        height: number;
+    };
+    _setPositionFromLayout(newCenter: {
+        x: number;
+        y: number;
+    }): void;
     doInitialPortMatching(): void;
     doInitialPcbPrimitiveRender(): void;
 }
@@ -3503,7 +3527,7 @@ declare class Hole extends PrimitiveComponent<typeof holeProps> {
     pcb_hole_id: string | null;
     isPcbPrimitive: boolean;
     get config(): {
-        zodProps: zod.ZodObject<zod.objectUtil.extendShape<Omit<{
+        zodProps: zod.ZodEffects<zod.ZodObject<zod.objectUtil.extendShape<Omit<{
             pcbX: zod.ZodOptional<zod.ZodEffects<zod.ZodUnion<[zod.ZodString, zod.ZodNumber]>, number, string | number>>;
             pcbY: zod.ZodOptional<zod.ZodEffects<zod.ZodUnion<[zod.ZodString, zod.ZodNumber]>, number, string | number>>;
             pcbRotation: zod.ZodOptional<zod.ZodEffects<zod.ZodUnion<[zod.ZodString, zod.ZodNumber]>, number, string | number>>;
@@ -3517,19 +3541,41 @@ declare class Hole extends PrimitiveComponent<typeof holeProps> {
                 name: "top" | "bottom" | "inner1" | "inner2" | "inner3" | "inner4" | "inner5" | "inner6";
             }>>;
         }, "pcbRotation">, {
-            holeDiameter: zod.ZodEffects<zod.ZodUnion<[zod.ZodString, zod.ZodNumber]>, number, string | number>;
+            name: zod.ZodOptional<zod.ZodString>;
+            diameter: zod.ZodOptional<zod.ZodEffects<zod.ZodUnion<[zod.ZodString, zod.ZodNumber]>, number, string | number>>;
+            radius: zod.ZodOptional<zod.ZodEffects<zod.ZodUnion<[zod.ZodString, zod.ZodNumber]>, number, string | number>>;
         }>, "strip", zod.ZodTypeAny, {
-            holeDiameter: number;
             pcbX?: number | undefined;
             pcbY?: number | undefined;
             layer?: "top" | "bottom" | "inner1" | "inner2" | "inner3" | "inner4" | "inner5" | "inner6" | undefined;
+            name?: string | undefined;
+            radius?: number | undefined;
+            diameter?: number | undefined;
         }, {
-            holeDiameter: string | number;
             pcbX?: string | number | undefined;
             pcbY?: string | number | undefined;
             layer?: "top" | "bottom" | "inner1" | "inner2" | "inner3" | "inner4" | "inner5" | "inner6" | {
                 name: "top" | "bottom" | "inner1" | "inner2" | "inner3" | "inner4" | "inner5" | "inner6";
             } | undefined;
+            name?: string | undefined;
+            radius?: string | number | undefined;
+            diameter?: string | number | undefined;
+        }>, {
+            diameter: number;
+            radius: number;
+            pcbX?: number | undefined;
+            pcbY?: number | undefined;
+            layer?: "top" | "bottom" | "inner1" | "inner2" | "inner3" | "inner4" | "inner5" | "inner6" | undefined;
+            name?: string | undefined;
+        }, {
+            pcbX?: string | number | undefined;
+            pcbY?: string | number | undefined;
+            layer?: "top" | "bottom" | "inner1" | "inner2" | "inner3" | "inner4" | "inner5" | "inner6" | {
+                name: "top" | "bottom" | "inner1" | "inner2" | "inner3" | "inner4" | "inner5" | "inner6";
+            } | undefined;
+            name?: string | undefined;
+            radius?: string | number | undefined;
+            diameter?: string | number | undefined;
         }>;
     };
     getPcbSize(): {
@@ -3537,6 +3583,24 @@ declare class Hole extends PrimitiveComponent<typeof holeProps> {
         height: number;
     };
     doInitialPcbPrimitiveRender(): void;
+    _getCircuitJsonBounds(): {
+        center: {
+            x: number;
+            y: number;
+        };
+        bounds: {
+            left: number;
+            top: number;
+            right: number;
+            bottom: number;
+        };
+        width: number;
+        height: number;
+    };
+    _setPositionFromLayout(newCenter: {
+        x: number;
+        y: number;
+    }): void;
 }
 
 declare global {

package/dist/index.js

@@ -535,16 +535,15 @@ var Footprint = class extends PrimitiveComponent {
     function getKVar(name) {
       if (!(name in kVars)) {
         kVars[name] = new kiwi.Variable(name);
+        solver.addEditVariable(kVars[name], kiwi.Strength.weak);
       }
       return kVars[name];
     }
-    for (const { selector, bounds } of involvedComponents) {
+    for (const { selector, bounds: bounds2 } of involvedComponents) {
       const kvx = getKVar(`${selector}_x`);
       const kvy = getKVar(`${selector}_y`);
-      solver.addEditVariable(kvx, kiwi.Strength.weak);
-      solver.addEditVariable(kvy, kiwi.Strength.weak);
-      solver.suggestValue(kvx, bounds.center.x);
-      solver.suggestValue(kvy, bounds.center.y);
+      solver.suggestValue(kvx, bounds2.center.x);
+      solver.suggestValue(kvy, bounds2.center.y);
     }
     for (const constraint of constraints) {
       const props = constraint._parsedProps;
@@ -567,7 +566,7 @@ var Footprint = class extends PrimitiveComponent {
         } else if (edgeToEdge) {
           const expr = new kiwi.Expression(
             rightVar,
-            rightBounds.width / 2,
+            -rightBounds.width / 2,
             [-1, leftVar],
             -leftBounds.width / 2
           );
@@ -580,50 +579,82 @@ var Footprint = class extends PrimitiveComponent {
             )
           );
         }
+      } else if ("ydist" in props) {
+        const { ydist, top, bottom, edgeToEdge, centerToCenter } = props;
+        const topVar = getKVar(`${top}_y`);
+        const bottomVar = getKVar(`${bottom}_y`);
+        const topBounds = getComponentDetails(top)?.bounds;
+        const bottomBounds = getComponentDetails(bottom)?.bounds;
+        if (centerToCenter) {
+          const expr = new kiwi.Expression(topVar, [-1, bottomVar]);
+          solver.addConstraint(
+            new kiwi.Constraint(
+              expr,
+              kiwi.Operator.Eq,
+              props.ydist,
+              kiwi.Strength.required
+            )
+          );
+        } else if (edgeToEdge) {
+          const expr = new kiwi.Expression(
+            topVar,
+            topBounds.height / 2,
+            [-1, bottomVar],
+            -bottomBounds.height / 2
+          );
+          solver.addConstraint(
+            new kiwi.Constraint(
+              expr,
+              kiwi.Operator.Eq,
+              props.ydist,
+              kiwi.Strength.required
+            )
+          );
+        }
       }
-      solver.updateVariables();
-      if (debug.enabled) {
-        console.log("Solution to layout constraints:");
-        console.table(
-          Object.entries(kVars).map(([key, kvar]) => ({
-            var: key,
-            val: kvar.value()
-          }))
-        );
-      }
-      const bounds = {
-        left: Infinity,
-        right: -Infinity,
-        top: -Infinity,
-        bottom: Infinity
-      };
-      for (const {
-        selector,
-        bounds: { width, height }
-      } of involvedComponents) {
-        const kvx = getKVar(`${selector}_x`);
-        const kvy = getKVar(`${selector}_y`);
-        const newLeft = kvx.value() - width / 2;
-        const newRight = kvx.value() + width / 2;
-        const newTop = kvy.value() + height / 2;
-        const newBottom = kvy.value() - height / 2;
-        bounds.left = Math.min(bounds.left, newLeft);
-        bounds.right = Math.max(bounds.right, newRight);
-        bounds.top = Math.max(bounds.top, newTop);
-        bounds.bottom = Math.min(bounds.bottom, newBottom);
-      }
-      const globalOffset = {
-        x: -(bounds.right + bounds.left) / 2,
-        y: -(bounds.top + bounds.bottom) / 2
-      };
-      for (const { component, selector } of involvedComponents) {
-        const kvx = getKVar(`${selector}_x`);
-        const kvy = getKVar(`${selector}_y`);
-        component._setPositionFromLayout({
-          x: kvx.value() + globalOffset.x,
-          y: kvy.value() + globalOffset.y
-        });
-      }
+    }
+    solver.updateVariables();
+    if (debug.enabled) {
+      console.log("Solution to layout constraints:");
+      console.table(
+        Object.entries(kVars).map(([key, kvar]) => ({
+          var: key,
+          val: kvar.value()
+        }))
+      );
+    }
+    const bounds = {
+      left: Infinity,
+      right: -Infinity,
+      top: -Infinity,
+      bottom: Infinity
+    };
+    for (const {
+      selector,
+      bounds: { width, height }
+    } of involvedComponents) {
+      const kvx = getKVar(`${selector}_x`);
+      const kvy = getKVar(`${selector}_y`);
+      const newLeft = kvx.value() - width / 2;
+      const newRight = kvx.value() + width / 2;
+      const newTop = kvy.value() + height / 2;
+      const newBottom = kvy.value() - height / 2;
+      bounds.left = Math.min(bounds.left, newLeft);
+      bounds.right = Math.max(bounds.right, newRight);
+      bounds.top = Math.max(bounds.top, newTop);
+      bounds.bottom = Math.min(bounds.bottom, newBottom);
+    }
+    const globalOffset = {
+      x: -(bounds.right + bounds.left) / 2,
+      y: -(bounds.top + bounds.bottom) / 2
+    };
+    for (const { component, selector } of involvedComponents) {
+      const kvx = getKVar(`${selector}_x`);
+      const kvy = getKVar(`${selector}_y`);
+      component._setPositionFromLayout({
+        x: kvx.value() + globalOffset.x,
+        y: kvy.value() + globalOffset.y
+      });
     }
   }
 };
@@ -1164,6 +1195,29 @@ var PlatedHole = class extends PrimitiveComponent {
       `getPcbSize for shape "${props.shape}" not implemented for ${this.componentName}`
     );
   }
+  _getCircuitJsonBounds() {
+    const { db } = this.root;
+    const platedHole = db.pcb_plated_hole.get(this.pcb_plated_hole_id);
+    const size = this.getPcbSize();
+    return {
+      center: { x: platedHole.x, y: platedHole.y },
+      bounds: {
+        left: platedHole.x - size.width / 2,
+        top: platedHole.y - size.height / 2,
+        right: platedHole.x + size.width / 2,
+        bottom: platedHole.y + size.height / 2
+      },
+      width: size.width,
+      height: size.height
+    };
+  }
+  _setPositionFromLayout(newCenter) {
+    const { db } = this.root;
+    db.pcb_plated_hole.update(this.pcb_plated_hole_id, {
+      x: newCenter.x,
+      y: newCenter.y
+    });
+  }
   doInitialPortMatching() {
     const parentPorts = (this.parent?.children ?? []).filter(
       (c) => c.componentName === "Port"
@@ -1185,19 +1239,19 @@ var PlatedHole = class extends PrimitiveComponent {
     if (!props.portHints) return;
     const position = this._getGlobalPcbPositionBeforeLayout();
     if (props.shape === "circle") {
-      const plated_hole_input = {
+      const pcb_plated_hole = db.pcb_plated_hole.insert({
         pcb_component_id: this.parent?.pcb_component_id,
         pcb_port_id: this.matchedPort?.pcb_port_id,
-        layers: ["top", "bottom"],
+        // @ts-ignore - some issue with @tscircuit/soup union type
         outer_diameter: props.outerDiameter,
         hole_diameter: props.holeDiameter,
         shape: "circle",
         port_hints: this.getNameAndAliases(),
         x: position.x,
         y: position.y,
-        type: "pcb_plated_hole"
-      };
-      const pcb_plated_hole = db.pcb_plated_hole.insert(plated_hole_input);
+        layers: ["top", "bottom"]
+      });
+      this.pcb_plated_hole_id = pcb_plated_hole.pcb_plated_hole_id;
     }
   }
 };
@@ -2934,20 +2988,43 @@ var Hole = class extends PrimitiveComponent {
   }
   getPcbSize() {
     const { _parsedProps: props } = this;
-    return { width: props.holeDiameter, height: props.holeDiameter };
+    return { width: props.diameter, height: props.diameter };
   }
   doInitialPcbPrimitiveRender() {
     const { db } = this.root;
     const { _parsedProps: props } = this;
     const position = this._getGlobalPcbPositionBeforeLayout();
-    const pcb_hole = {
-      type: "pcb_hole",
+    const inserted_hole = db.pcb_hole.insert({
       hole_shape: "round",
-      hole_diameter: props.holeDiameter,
+      // @ts-ignore
+      hole_diameter: props.diameter,
       x: position.x,
       y: position.y
+    });
+    this.pcb_hole_id = inserted_hole.pcb_hole_id;
+  }
+  _getCircuitJsonBounds() {
+    const { db } = this.root;
+    const hole = db.pcb_hole.get(this.pcb_hole_id);
+    const size = this.getPcbSize();
+    return {
+      center: { x: hole.x, y: hole.y },
+      bounds: {
+        left: hole.x - size.width / 2,
+        top: hole.y - size.height / 2,
+        right: hole.x + size.width / 2,
+        bottom: hole.y + size.height / 2
+      },
+      width: size.width,
+      height: size.height
     };
-    const inserted_hole = db.pcb_hole.insert(pcb_hole);
+  }
+  _setPositionFromLayout(newCenter) {
+    const { db } = this.root;
+    db.pcb_hole.update(this.pcb_hole_id, {
+      x: newCenter.x,
+      y: newCenter.y
+    });
   }
 };
 

package/lib/components/primitive-components/Footprint.ts

@@ -39,6 +39,7 @@ export class Footprint extends PrimitiveComponent<typeof footprintProps> {
     function getKVar(name: string) {
       if (!(name in kVars)) {
         kVars[name] = new kiwi.Variable(name)
+        solver.addEditVariable(kVars[name], kiwi.Strength.weak)
       }
       return kVars[name]
     }
@@ -47,8 +48,6 @@ export class Footprint extends PrimitiveComponent<typeof footprintProps> {
     for (const { selector, bounds } of involvedComponents) {
       const kvx = getKVar(`${selector}_x`)
       const kvy = getKVar(`${selector}_y`)
-      solver.addEditVariable(kvx, kiwi.Strength.weak)
-      solver.addEditVariable(kvy, kiwi.Strength.weak)
       solver.suggestValue(kvx, bounds.center.x)
       solver.suggestValue(kvy, bounds.center.y)
     }
@@ -77,10 +76,10 @@ export class Footprint extends PrimitiveComponent<typeof footprintProps> {
           )
         } else if (edgeToEdge) {
           // rightEdge - leftEdge = xdist
-          // right + rightBounds.width/2 - left - leftBounds.width/2 = xdist
+          // right - rightBounds.width/2 - left - leftBounds.width/2 = xdist
           const expr = new kiwi.Expression(
             rightVar,
-            rightBounds.width / 2,
+            -rightBounds.width / 2,
             [-1, leftVar],
             -leftBounds.width / 2,
           )
@@ -93,69 +92,107 @@ export class Footprint extends PrimitiveComponent<typeof footprintProps> {
             ),
           )
         }
-      }
+      } else if ("ydist" in props) {
+        const { ydist, top, bottom, edgeToEdge, centerToCenter } = props
+        const topVar = getKVar(`${top}_y`)
+        const bottomVar = getKVar(`${bottom}_y`)
+        const topBounds = getComponentDetails(top)?.bounds!
+        const bottomBounds = getComponentDetails(bottom)?.bounds!
 
-      // 3. Solve the system of equations
-      solver.updateVariables()
-      if (debug.enabled) {
-        console.log("Solution to layout constraints:")
-        console.table(
-          Object.entries(kVars).map(([key, kvar]) => ({
-            var: key,
-            val: kvar.value(),
-          })),
-        )
-      }
+        // Top - Bottom = ydist
 
-      // 3.1 Compute the global offset. There are different ways to do this:
-      // - If any component has a fixed position, then that can be used as the
-      //   origin to determine the offset of all other components
-      // - If no component has a fixed position, then we recenter everything
-      //   using the new bounds of all the involved components
-
-      // TODO determine if there's a fixed component
-
-      // Determine the new bounds all the involved components and compute the
-      // bounds of this footprint
-      const bounds = {
-        left: Infinity,
-        right: -Infinity,
-        top: -Infinity,
-        bottom: Infinity,
-      }
-      for (const {
-        selector,
-        bounds: { width, height },
-      } of involvedComponents) {
-        const kvx = getKVar(`${selector}_x`)
-        const kvy = getKVar(`${selector}_y`)
-
-        const newLeft = kvx.value() - width / 2
-        const newRight = kvx.value() + width / 2
-        const newTop = kvy.value() + height / 2
-        const newBottom = kvy.value() - height / 2
-
-        bounds.left = Math.min(bounds.left, newLeft)
-        bounds.right = Math.max(bounds.right, newRight)
-        bounds.top = Math.max(bounds.top, newTop)
-        bounds.bottom = Math.min(bounds.bottom, newBottom)
+        if (centerToCenter) {
+          // top - bottom = ydist
+          const expr = new kiwi.Expression(topVar, [-1, bottomVar])
+          solver.addConstraint(
+            new kiwi.Constraint(
+              expr,
+              kiwi.Operator.Eq,
+              props.ydist,
+              kiwi.Strength.required,
+            ),
+          )
+        } else if (edgeToEdge) {
+          // topElmBottomEdge - bottomElmTopEdge = ydist
+          // topElmCenterY - topElmHeight/2 - bottomElmCenterY - bottomElmHeight/2 = ydist
+          const expr = new kiwi.Expression(
+            topVar,
+            topBounds.height / 2,
+            [-1, bottomVar],
+            -bottomBounds.height / 2,
+          )
+          solver.addConstraint(
+            new kiwi.Constraint(
+              expr,
+              kiwi.Operator.Eq,
+              props.ydist,
+              kiwi.Strength.required,
+            ),
+          )
+        }
       }
+    }
 
-      // Compute the global offset, we can use this to recenter each component
-      const globalOffset = {
-        x: -(bounds.right + bounds.left) / 2,
-        y: -(bounds.top + bounds.bottom) / 2,
-      }
+    // 3. Solve the system of equations
+    solver.updateVariables()
+    if (debug.enabled) {
+      console.log("Solution to layout constraints:")
+      console.table(
+        Object.entries(kVars).map(([key, kvar]) => ({
+          var: key,
+          val: kvar.value(),
+        })),
+      )
+    }
 
-      // 4. Update the component positions
-      for (const { component, selector } of involvedComponents) {
-        const kvx = getKVar(`${selector}_x`)
-        const kvy = getKVar(`${selector}_y`)
-        component._setPositionFromLayout({
-          x: kvx.value() + globalOffset.x,
-          y: kvy.value() + globalOffset.y,
-        })
-      }
+    // 3.1 Compute the global offset. There are different ways to do this:
+    // - If any component has a fixed position, then that can be used as the
+    //   origin to determine the offset of all other components
+    // - If no component has a fixed position, then we recenter everything
+    //   using the new bounds of all the involved components
+
+    // TODO determine if there's a fixed component
+
+    // Determine the new bounds all the involved components and compute the
+    // bounds of this footprint
+    const bounds = {
+      left: Infinity,
+      right: -Infinity,
+      top: -Infinity,
+      bottom: Infinity,
+    }
+    for (const {
+      selector,
+      bounds: { width, height },
+    } of involvedComponents) {
+      const kvx = getKVar(`${selector}_x`)
+      const kvy = getKVar(`${selector}_y`)
+
+      const newLeft = kvx.value() - width / 2
+      const newRight = kvx.value() + width / 2
+      const newTop = kvy.value() + height / 2
+      const newBottom = kvy.value() - height / 2
+
+      bounds.left = Math.min(bounds.left, newLeft)
+      bounds.right = Math.max(bounds.right, newRight)
+      bounds.top = Math.max(bounds.top, newTop)
+      bounds.bottom = Math.min(bounds.bottom, newBottom)
+    }
+
+    // Compute the global offset, we can use this to recenter each component
+    const globalOffset = {
+      x: -(bounds.right + bounds.left) / 2,
+      y: -(bounds.top + bounds.bottom) / 2,
+    }
+
+    // 4. Update the component positions
+    for (const { component, selector } of involvedComponents) {
+      const kvx = getKVar(`${selector}_x`)
+      const kvy = getKVar(`${selector}_y`)
+      component._setPositionFromLayout({
+        x: kvx.value() + globalOffset.x,
+        y: kvy.value() + globalOffset.y,
+      })
     }
   }
 }

package/lib/components/primitive-components/Hole.ts

@@ -14,7 +14,7 @@ export class Hole extends PrimitiveComponent<typeof holeProps> {
 
   getPcbSize(): { width: number; height: number } {
     const { _parsedProps: props } = this
-    return { width: props.holeDiameter, height: props.holeDiameter }
+    return { width: props.diameter, height: props.diameter }
   }
 
   doInitialPcbPrimitiveRender(): void {
@@ -22,15 +22,44 @@ export class Hole extends PrimitiveComponent<typeof holeProps> {
     const { _parsedProps: props } = this
     const position = this._getGlobalPcbPositionBeforeLayout()
 
-    const pcb_hole: PCBHole = {
-      type: "pcb_hole",
+    const inserted_hole = db.pcb_hole.insert({
       hole_shape: "round",
-      hole_diameter: props.holeDiameter,
+      // @ts-ignore
+      hole_diameter: props.diameter,
       x: position.x,
       y: position.y,
+    })
+    this.pcb_hole_id = inserted_hole.pcb_hole_id!
+  }
+
+  _getCircuitJsonBounds(): {
+    center: { x: number; y: number }
+    bounds: { left: number; top: number; right: number; bottom: number }
+    width: number
+    height: number
+  } {
+    const { db } = this.root!
+    const hole = db.pcb_hole.get(this.pcb_hole_id!)!
+    const size = this.getPcbSize()
+
+    return {
+      center: { x: hole.x, y: hole.y },
+      bounds: {
+        left: hole.x - size.width / 2,
+        top: hole.y - size.height / 2,
+        right: hole.x + size.width / 2,
+        bottom: hole.y + size.height / 2,
+      },
+      width: size.width,
+      height: size.height,
     }
+  }
 
-    const inserted_hole = db.pcb_hole.insert(pcb_hole)
-    // this.pcb_hole_id = inserted_hole.pcb_hole_id!
+  _setPositionFromLayout(newCenter: { x: number; y: number }) {
+    const { db } = this.root!
+    db.pcb_hole.update(this.pcb_hole_id!, {
+      x: newCenter.x,
+      y: newCenter.y,
+    })
   }
 }

package/lib/components/primitive-components/PlatedHole.ts

@@ -27,6 +27,37 @@ export class PlatedHole extends PrimitiveComponent<typeof platedHoleProps> {
     )
   }
 
+  _getCircuitJsonBounds(): {
+    center: { x: number; y: number }
+    bounds: { left: number; top: number; right: number; bottom: number }
+    width: number
+    height: number
+  } {
+    const { db } = this.root!
+    const platedHole = db.pcb_plated_hole.get(this.pcb_plated_hole_id!)!
+    const size = this.getPcbSize()
+
+    return {
+      center: { x: platedHole.x, y: platedHole.y },
+      bounds: {
+        left: platedHole.x - size.width / 2,
+        top: platedHole.y - size.height / 2,
+        right: platedHole.x + size.width / 2,
+        bottom: platedHole.y + size.height / 2,
+      },
+      width: size.width,
+      height: size.height,
+    }
+  }
+
+  _setPositionFromLayout(newCenter: { x: number; y: number }) {
+    const { db } = this.root!
+    db.pcb_plated_hole.update(this.pcb_plated_hole_id!, {
+      x: newCenter.x,
+      y: newCenter.y,
+    })
+  }
+
   doInitialPortMatching(): void {
     const parentPorts = (this.parent?.children ?? []).filter(
       (c) => c.componentName === "Port",
@@ -51,23 +82,20 @@ export class PlatedHole extends PrimitiveComponent<typeof platedHoleProps> {
     if (!props.portHints) return
     const position = this._getGlobalPcbPositionBeforeLayout()
     if (props.shape === "circle") {
-      const plated_hole_input: PCBPlatedHoleInput = {
+      const pcb_plated_hole = db.pcb_plated_hole.insert({
         pcb_component_id: this.parent?.pcb_component_id!,
         pcb_port_id: this.matchedPort?.pcb_port_id!,
-        layers: ["top", "bottom"],
+        // @ts-ignore - some issue with @tscircuit/soup union type
         outer_diameter: props.outerDiameter,
         hole_diameter: props.holeDiameter,
-        shape: "circle",
+        shape: "circle" as const,
         port_hints: this.getNameAndAliases(),
         x: position.x,
         y: position.y,
-        type: "pcb_plated_hole",
-      }
-
-      // @ts-ignore - some issue with soup-util types it seems
-      const pcb_plated_hole = db.pcb_plated_hole.insert(plated_hole_input)
+        layers: ["top", "bottom"],
+      })
 
-      // this.pcb_plated_hole_id = pcb_plated_hole.pcb_plated_hole_id
+      this.pcb_plated_hole_id = pcb_plated_hole.pcb_plated_hole_id
     }
   }
 }

package/lib/soup/underscorifyPinStyles.ts

@@ -1,21 +1,23 @@
-import type { SchematicPinStyles } from "@tscircuit/props"
+import type { SchematicPinStyle } from "@tscircuit/props"
 import { schematic_component } from "@tscircuit/soup"
 import { z } from "zod"
 
 type UnderscorePinStyles = z.input<typeof schematic_component>["pin_styles"]
 
 export const underscorifyPinStyles = (
-  pinStyles: SchematicPinStyles | undefined,
+  pinStyles: Record<string, SchematicPinStyle> | undefined,
 ): UnderscorePinStyles | undefined => {
   if (!pinStyles) return undefined
   const underscorePinStyles: UnderscorePinStyles = {}
 
-  for (const [pinName, pinStyle] of Object.entries(pinStyles)) {
+  for (const [pinName, pinStyle] of Object.entries(pinStyles) as Array<
+    [string, SchematicPinStyle]
+  >) {
     underscorePinStyles[pinName] = {
-      bottom_margin: pinStyle.bottomMargin,
-      left_margin: pinStyle.leftMargin,
-      right_margin: pinStyle.rightMargin,
-      top_margin: pinStyle.topMargin,
+      bottom_margin: pinStyle.bottomMargin as number,
+      left_margin: pinStyle.leftMargin as number,
+      right_margin: pinStyle.rightMargin as number,
+      top_margin: pinStyle.topMargin as number,
     }
   }
 

package/package.json

@@ -2,7 +2,7 @@
   "name": "@tscircuit/core",
   "module": "index.ts",
   "type": "module",
-  "version": "0.0.32",
+  "version": "0.0.33",
   "types": "dist/index.d.ts",
   "main": "dist/index.js",
   "files": [
@@ -35,8 +35,8 @@
   "dependencies": {
     "@lume/kiwi": "^0.4.3",
     "@tscircuit/infgrid-ijump-astar": "^0.0.6",
-    "@tscircuit/props": "^0.0.58",
-    "@tscircuit/soup": "^0.0.58",
+    "@tscircuit/props": "^0.0.61",
+    "@tscircuit/soup": "^0.0.66",
     "@tscircuit/soup-util": "0.0.18",
     "footprinter": "^0.0.44",
     "react": "^18.3.1",