@tscircuit/core 0.0.1403 → 0.0.1405

package/dist/index.d.ts

@@ -319,6 +319,14 @@ type ReactSubtree = {
     component: NormalComponent;
 };
 
+type VerticalPortSideConfiguration = {
+    direction?: "top-to-bottom" | "bottom-to-top";
+    pins: number[];
+};
+type HorizontalPortSideConfiguration = {
+    direction?: "left-to-right" | "right-to-left";
+    pins: number[];
+};
 type SchematicBoxPortPositionWithMetadata = {
     trueIndex: number;
     pinNumber: number;
@@ -327,6 +335,26 @@ type SchematicBoxPortPositionWithMetadata = {
     x: number;
     y: number;
 };
+type ExplicitPinMappingArrangement = {
+    leftSide?: VerticalPortSideConfiguration;
+    rightSide?: VerticalPortSideConfiguration;
+    topSide?: HorizontalPortSideConfiguration;
+    bottomSide?: HorizontalPortSideConfiguration;
+};
+/** @deprecated prefer SidePinCounts */
+interface SideSizes {
+    leftSize?: number;
+    rightSize?: number;
+    topSize?: number;
+    bottomSize?: number;
+}
+interface SidePinCounts {
+    leftPinCount?: number;
+    rightPinCount?: number;
+    topPinCount?: number;
+    bottomPinCount?: number;
+}
+type PortArrangement = SideSizes | SidePinCounts | ExplicitPinMappingArrangement;
 interface SchematicBoxDimensions {
     pinCount: number;
     getPortPositionByPinNumber(pinNumber: number): SchematicBoxPortPositionWithMetadata | null;
@@ -2310,6 +2338,7 @@ declare class NormalComponent<ZodProps extends z.ZodType = any, PortNames extend
      * Extract pin labels from ports using existing Port logic
      */
     _getPinLabelsFromPorts(): Record<string, string>;
+    _getImplicitSparseSchematicPortArrangement(pinCount: number): PortArrangement | undefined;
     _getSchematicBoxDimensions(): SchematicBoxDimensions | null;
     getFootprinterString(): string | null;
     doInitialCadModelRender(): void;
@@ -53092,10 +53121,10 @@ declare class Led extends NormalComponent<typeof ledProps, PolarizedPassivePorts
     _getSchematicSymbolDisplayValue(): string | undefined;
     getFootprinterString(): string | null;
     doInitialSourceRender(): void;
-    pos: Port;
-    anode: Port;
-    neg: Port;
-    cathode: Port;
+    get pos(): Port;
+    get anode(): Port;
+    get neg(): Port;
+    get cathode(): Port;
 }
 
 declare class PowerSource extends NormalComponent<typeof powerSourceProps, PolarizedPassivePorts> {

package/dist/index.js

@@ -10980,7 +10980,6 @@ var createComponentsFromCircuitJson = ({
 };
 
 // lib/utils/filterPinLabels.ts
-import { chipProps } from "@tscircuit/props";
 function filterPinLabels(pinLabels) {
   if (!pinLabels)
     return {
@@ -11010,18 +11009,8 @@ function filterPinLabels(pinLabels) {
     invalidPinLabelsMessages
   };
 }
-function isValidPinLabel(pin, label) {
-  try {
-    const testProps = {
-      name: "test",
-      footprint: "test",
-      pinLabels: { [pin]: label }
-    };
-    const result = chipProps.safeParse(testProps);
-    return result.success;
-  } catch (error) {
-    return false;
-  }
+function isValidPinLabel(_pin, label) {
+  return /^[A-Za-z0-9_]+$/.test(label);
 }
 
 // lib/utils/get-bounds-of-pcb-components.ts
@@ -11229,7 +11218,7 @@ var getAllDimensionsForSchematicBox = (params) => {
       currentDistanceFromEdge += pinStyle.topMargin;
     }
     orderedTruePorts.push({
-      trueIndex: truePinIndex,
+      trueIndex: pinNumber - 1,
       pinNumber,
       side: "left",
       distanceFromOrthogonalEdge: currentDistanceFromEdge
@@ -11257,7 +11246,7 @@ var getAllDimensionsForSchematicBox = (params) => {
       currentDistanceFromEdge += pinStyle.leftMargin;
     }
     orderedTruePorts.push({
-      trueIndex: truePinIndex,
+      trueIndex: pinNumber - 1,
       pinNumber,
       side: "bottom",
       distanceFromOrthogonalEdge: currentDistanceFromEdge
@@ -11285,7 +11274,7 @@ var getAllDimensionsForSchematicBox = (params) => {
       currentDistanceFromEdge += pinStyle.bottomMargin;
     }
     orderedTruePorts.push({
-      trueIndex: truePinIndex,
+      trueIndex: pinNumber - 1,
       pinNumber,
       side: "right",
       distanceFromOrthogonalEdge: currentDistanceFromEdge
@@ -11313,7 +11302,7 @@ var getAllDimensionsForSchematicBox = (params) => {
       currentDistanceFromEdge += pinStyle.rightMargin;
     }
     orderedTruePorts.push({
-      trueIndex: truePinIndex,
+      trueIndex: pinNumber - 1,
       pinNumber,
       side: "top",
       distanceFromOrthogonalEdge: currentDistanceFromEdge
@@ -13237,7 +13226,9 @@ var NormalComponent3 = class extends PrimitiveComponent2 {
       for (const symPort of sym.ports) {
         const pinNumber = getPinNumberFromLabels(symPort.labels);
         if (!pinNumber) continue;
-        const existingPort = portsToCreate.find(
+        const existingPort = this._getAllPortsFromChildren().find(
+          (p) => p._parsedProps.pinNumber === Number(pinNumber)
+        ) ?? portsToCreate.find(
           (p) => p._parsedProps.pinNumber === Number(pinNumber)
         );
         if (existingPort) {
@@ -13290,6 +13281,9 @@ var NormalComponent3 = class extends PrimitiveComponent2 {
     const requiredPinCount = opts.pinCount ?? this._getPrimaryPinCount() ?? 0;
     for (let pn = 1; pn <= requiredPinCount; pn++) {
       if (portsToCreate.find((p) => p._parsedProps.pinNumber === pn)) continue;
+      if (!schPortArrangement && pinLabelsFromProps && !Array.isArray(propsPinLabels) && !pinLabelsFromProps[`pin${pn}`]) {
+        continue;
+      }
       if (!schPortArrangement) {
         portsToCreate.push(
           new Port({
@@ -14148,6 +14142,24 @@ var NormalComponent3 = class extends PrimitiveComponent2 {
     }
     return pinLabels;
   }
+  _getImplicitSparseSchematicPortArrangement(pinCount) {
+    const pinNumbers = Array.from(
+      new Set(
+        this._getAllPortsFromChildren().filter((port) => port._isPrimaryPort).map((port) => port._parsedProps.pinNumber).filter((pinNumber) => pinNumber !== void 0)
+      )
+    ).sort((a, b) => a - b);
+    if (pinNumbers.length !== pinCount) return void 0;
+    const hasSparsePinNumbers = pinNumbers.some(
+      (pinNumber, index) => pinNumber !== index + 1
+    );
+    if (!hasSparsePinNumbers) return void 0;
+    const rightSize = Math.floor(pinCount / 2);
+    const leftSize = pinCount - rightSize;
+    return {
+      leftSide: { pins: pinNumbers.slice(0, leftSize) },
+      rightSide: { pins: pinNumbers.slice(leftSize) }
+    };
+  }
   _getSchematicBoxDimensions() {
     if (this.getSchematicSymbol()) return null;
     if (!this.config.shouldRenderAsSchematicBox && !this._parsedProps?.showAsSchematicBox) {
@@ -14161,6 +14173,7 @@ var NormalComponent3 = class extends PrimitiveComponent2 {
       ...pinLabelsFromPorts,
       ...props.pinLabels
     };
+    const schPortArrangement = this._getSchematicPortArrangement() ?? this._getImplicitSparseSchematicPortArrangement(pinCount);
     const dimensions = getAllDimensionsForSchematicBox({
       schWidth: props.schWidth,
       schHeight: props.schHeight,
@@ -14170,7 +14183,7 @@ var NormalComponent3 = class extends PrimitiveComponent2 {
         allPinLabels
       ),
       pinCount,
-      schPortArrangement: this._getSchematicPortArrangement(),
+      schPortArrangement,
       pinLabels: allPinLabels
     });
     return dimensions;
@@ -14856,7 +14869,7 @@ function inflateSourceCapacitor(sourceElm, inflatorContext) {
 }
 
 // lib/components/normal-components/Chip.ts
-import { chipProps as chipProps2 } from "@tscircuit/props";
+import { chipProps } from "@tscircuit/props";
 import { pcb_component_invalid_layer_error as pcb_component_invalid_layer_error2 } from "circuit-json";
 var Chip = class extends NormalComponent3 {
   schematicBoxDimensions = null;
@@ -14866,7 +14879,7 @@ var Chip = class extends NormalComponent3 {
   get config() {
     return {
       componentName: "Chip",
-      zodProps: chipProps2,
+      zodProps: chipProps,
       shouldRenderAsSchematicBox: true
     };
   }
@@ -24378,10 +24391,18 @@ var Led = class extends NormalComponent3 {
     };
   }
   initPorts() {
+    const hasFootprintChild = this.children.some(
+      (child) => child.componentName === "Footprint"
+    );
+    const footprint = this.resolveFootprint();
+    const hasPinLabels = Boolean(this._resolvePinLabels());
+    const shouldAddDefaultAliases = !hasPinLabels && !hasFootprintChild && (!footprint || isFootprinterString(footprint));
     super.initPorts({
+      pinCount: 2,
+      ignoreSymbolPorts: !hasPinLabels && !shouldAddDefaultAliases,
       additionalAliases: {
-        pin1: ["anode", "pos", "left"],
-        pin2: ["cathode", "neg", "right"]
+        pin1: shouldAddDefaultAliases ? ["anode", "pos", "left"] : [],
+        pin2: shouldAddDefaultAliases ? ["cathode", "neg", "right"] : []
       }
     });
   }
@@ -24411,10 +24432,18 @@ var Led = class extends NormalComponent3 {
     });
     this.source_component_id = source_component.source_component_id;
   }
-  pos = this.portMap.pin1;
-  anode = this.portMap.pin1;
-  neg = this.portMap.pin2;
-  cathode = this.portMap.pin2;
+  get pos() {
+    return this.portMap.pos;
+  }
+  get anode() {
+    return this.portMap.anode;
+  }
+  get neg() {
+    return this.portMap.neg;
+  }
+  get cathode() {
+    return this.portMap.cathode;
+  }
 };
 
 // lib/components/primitive-components/Group/Subcircuit/inflators/inflateSourceLed.ts
@@ -25300,7 +25329,7 @@ import { identity as identity5 } from "transformation-matrix";
 var package_default = {
   name: "@tscircuit/core",
   type: "module",
-  version: "0.0.1402",
+  version: "0.0.1404",
   types: "dist/index.d.ts",
   main: "dist/index.js",
   module: "dist/index.js",

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@tscircuit/core",
   "type": "module",
-  "version": "0.0.1403",
+  "version": "0.0.1405",
   "types": "dist/index.d.ts",
   "main": "dist/index.js",
   "module": "dist/index.js",