@tscircuit/core 0.0.1070 → 0.0.1072

package/dist/index.d.ts

@@ -1619,7 +1619,19 @@ declare class NormalComponent<ZodProps extends z.ZodType = any, PortNames extend
     doInitialInitializePortsFromChildren(): void;
     doInitialReactSubtreesRender(): void;
     doInitialPcbFootprintStringRender(): void;
+    /**
+     * Get all ports from children, including ports inside Symbol.
+     * This doesn't use selectAll to avoid caching issues during initPorts.
+     */
+    _getAllPortsFromChildren(): Port[];
     _hasExistingPortExactly(port1: Port): boolean;
+    /**
+     * Check if a port with the same pinNumber already exists.
+     * This is used to prevent duplicate ports for the same physical pin.
+     * Note: We only check pinNumber, not aliases, because different physical pins
+     * can have the same alias (e.g., multiple GND pins).
+     */
+    _hasMatchingPort(port1: Port): boolean;
     add(componentOrElm: PrimitiveComponent | ReactElement): void;
     getPortsFromFootprint(opts?: {
         additionalAliases?: Record<string, string[]>;

package/dist/index.js

@@ -9997,12 +9997,24 @@ var NormalComponent3 = class extends PrimitiveComponent2 {
       this.addAll(portsToCreate);
     }
     if (!this._getSchematicPortArrangement()) {
-      const portsFromFootprint = this.getPortsFromFootprint(opts);
-      for (const port of portsFromFootprint) {
-        if (!portsToCreate.some(
-          (p) => p.isMatchingAnyOf(port.getNameAndAliases())
-        )) {
-          portsToCreate.push(port);
+      const hasReactSymbol = isValidElement(this.props.symbol);
+      const symbolAlreadyAdded = this.children.some(
+        (c) => c.componentName === "Symbol"
+      );
+      if (hasReactSymbol && !symbolAlreadyAdded) {
+      } else {
+        const portsFromFootprint = this.getPortsFromFootprint(opts);
+        const existingPorts = this._getAllPortsFromChildren();
+        for (const port of portsFromFootprint) {
+          const alreadyInPortsToCreate = portsToCreate.some(
+            (p) => p.isMatchingAnyOf(port.getNameAndAliases())
+          );
+          const alreadyInExistingPorts = existingPorts.some(
+            (p) => p.isMatchingAnyOf(port.getNameAndAliases())
+          );
+          if (!alreadyInPortsToCreate && !alreadyInExistingPorts) {
+            portsToCreate.push(port);
+          }
         }
       }
     }
@@ -10508,16 +10520,47 @@ var NormalComponent3 = class extends PrimitiveComponent2 {
       (name, effect) => this._queueAsyncEffect(name, effect)
     );
   }
+  /**
+   * Get all ports from children, including ports inside Symbol.
+   * This doesn't use selectAll to avoid caching issues during initPorts.
+   */
+  _getAllPortsFromChildren() {
+    const ports = [];
+    const collectPorts = (component) => {
+      if (component.componentName === "Port") {
+        ports.push(component);
+      }
+      for (const child of component.children) {
+        collectPorts(child);
+      }
+    };
+    for (const child of this.children) {
+      collectPorts(child);
+    }
+    return ports;
+  }
   _hasExistingPortExactly(port1) {
-    const existingPorts = this.children.filter(
-      (c) => c.componentName === "Port"
-    );
+    const existingPorts = this._getAllPortsFromChildren();
     return existingPorts.some((port2) => {
       const aliases1 = port1.getNameAndAliases();
       const aliases2 = port2.getNameAndAliases();
       return aliases1.length === aliases2.length && aliases1.every((alias) => aliases2.includes(alias));
     });
   }
+  /**
+   * Check if a port with the same pinNumber already exists.
+   * This is used to prevent duplicate ports for the same physical pin.
+   * Note: We only check pinNumber, not aliases, because different physical pins
+   * can have the same alias (e.g., multiple GND pins).
+   */
+  _hasMatchingPort(port1) {
+    const existingPorts = this._getAllPortsFromChildren();
+    const pinNumber1 = port1._parsedProps.pinNumber;
+    if (pinNumber1 === void 0) return false;
+    return existingPorts.some(
+      (port2) => port2._parsedProps.pinNumber === pinNumber1
+    );
+  }
   add(componentOrElm) {
     let component;
     if (isReactElement2(componentOrElm)) {
@@ -10529,16 +10572,11 @@ var NormalComponent3 = class extends PrimitiveComponent2 {
     }
     if (component.componentName === "Port") {
       if (this._hasExistingPortExactly(component)) return;
-      const existingPorts = this.children.filter(
-        (c) => c.componentName === "Port"
-      );
-      const conflictingPort = existingPorts.find(
-        (p) => p.isMatchingAnyOf(component.getNameAndAliases())
-      );
-      if (conflictingPort) {
+      if (this._hasMatchingPort(component)) {
         debug3(
-          `Similar ports added. Port 1: ${conflictingPort}, Port 2: ${component}`
+          `Skipping port ${component} because a matching port already exists`
         );
+        return;
       }
     }
     super.add(component);
@@ -18056,7 +18094,7 @@ import { identity as identity5 } from "transformation-matrix";
 var package_default = {
   name: "@tscircuit/core",
   type: "module",
-  version: "0.0.1069",
+  version: "0.0.1071",
   types: "dist/index.d.ts",
   main: "dist/index.js",
   module: "dist/index.js",
@@ -18089,7 +18127,7 @@ var package_default = {
     "@resvg/resvg-js": "^2.6.2",
     "@tscircuit/alphabet": "0.0.18",
     "@tscircuit/capacity-autorouter": "^0.0.299",
-    "@tscircuit/checks": "0.0.98",
+    "@tscircuit/checks": "0.0.99",
     "@tscircuit/circuit-json-util": "^0.0.80",
     "@tscircuit/common": "^0.0.20",
     "@tscircuit/copper-pour-solver": "^0.0.20",

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@tscircuit/core",
   "type": "module",
-  "version": "0.0.1070",
+  "version": "0.0.1072",
   "types": "dist/index.d.ts",
   "main": "dist/index.js",
   "module": "dist/index.js",
@@ -34,7 +34,7 @@
     "@resvg/resvg-js": "^2.6.2",
     "@tscircuit/alphabet": "0.0.18",
     "@tscircuit/capacity-autorouter": "^0.0.299",
-    "@tscircuit/checks": "0.0.98",
+    "@tscircuit/checks": "0.0.99",
     "@tscircuit/circuit-json-util": "^0.0.80",
     "@tscircuit/common": "^0.0.20",
     "@tscircuit/copper-pour-solver": "^0.0.20",