@tscircuit/cli 0.1.2049 → 0.1.2050

package/dist/cli/main.js

@@ -153260,7 +153260,7 @@ var package_default = {
     "@babel/standalone": "^7.26.9",
     "@biomejs/biome": "^1.9.4",
     "@tscircuit/check-shorts": "https://jscdn.tscircuit.com/@tscircuit/check-shorts/0.0.19.tgz",
-    "@tscircuit/circuit-json-placement-analysis": "^0.0.9",
+    "@tscircuit/circuit-json-placement-analysis": "^0.0.15",
     "@tscircuit/circuit-json-routing-analysis": "^0.0.8",
     "@tscircuit/circuit-json-schematic-placement-analysis": "github:tscircuit/circuit-json-schematic-placement-analysis#cb6059c8e2561967afad591b30251a915cab42e5",
     "@tscircuit/circuit-json-util": "^0.0.113",
@@ -172599,17 +172599,50 @@ var analyzeComponentPlacement = (circuitJson, componentName) => {
 `)
   };
 };
+var isPcbPort = (circuitElement) => {
+  if (circuitElement.type !== "pcb_port")
+    return false;
+  if (typeof circuitElement.pcb_port_id !== "string")
+    return false;
+  if (typeof circuitElement.source_port_id !== "string")
+    return false;
+  if (typeof circuitElement.x !== "number")
+    return false;
+  if (!Number.isFinite(circuitElement.x))
+    return false;
+  if (typeof circuitElement.y !== "number")
+    return false;
+  if (!Number.isFinite(circuitElement.y))
+    return false;
+  if (!Array.isArray(circuitElement.layers))
+    return false;
+  for (const layer of circuitElement.layers) {
+    if (typeof layer !== "string")
+      return false;
+  }
+  return true;
+};
 var TOP_ISSUE_LIMIT = 5;
 var CENTER_ANCHOR2 = "center";
 var LARGE_EMPTY_SPACE_THRESHOLD_RATIO = 0.05;
 var EMPTY_SPACE_SAMPLE_STEP_MM = 5;
 var GEOMETRY_EPSILON = 0.000001;
+var SUBOPTIMAL_ORIENTATION_SEVERITY = 100;
+var ORIENTATION_ANALYSIS_COMPONENT_TYPES = /* @__PURE__ */ new Set([
+  "simple_resistor",
+  "simple_capacitor",
+  "simple_inductor",
+  "simple_crystal",
+  "simple_diode",
+  "simple_chip"
+]);
 var ISSUE_TYPE_ORDER = [
   "pad_overlap",
   "off_board",
   "courtyard_collision",
   "connector_body_intrusion",
-  "footprint_intrusion"
+  "footprint_intrusion",
+  "suboptimal_orientation"
 ];
 var toNumber22 = (value) => typeof value === "number" && Number.isFinite(value) ? value : null;
 var getLayer = (value) => typeof value === "string" ? value : null;
@@ -172734,6 +172767,10 @@ var getSummaryLabel = (type, count) => {
       return `${count} connector-body intrusion${count === 1 ? "" : "s"}`;
     case "footprint_intrusion":
       return `${count} footprint intrusion${count === 1 ? "" : "s"}`;
+    case "suboptimal_orientation":
+      if (count === 1)
+        return "1 suboptimal orientation";
+      return `${count} suboptimal orientations`;
   }
 };
 var getMoveDirectionForEdge = (edge) => {
@@ -173303,7 +173340,174 @@ var buildBoardTopLayerReport = (components, boardBounds) => {
     largeEmptySpaces
   };
 };
-var buildIssues = (components, boardBounds) => {
+var buildConnectedSourcePortIdsBySourcePortId = (circuitJson) => {
+  const connectionGroupById = /* @__PURE__ */ new Map;
+  const sourcePortIds = /* @__PURE__ */ new Set;
+  for (const element of circuitJson) {
+    if (element.type !== "source_trace")
+      continue;
+    if (!Array.isArray(element.connected_source_port_ids))
+      continue;
+    const portIds = element.connected_source_port_ids.filter((id) => typeof id === "string");
+    for (const id of portIds)
+      sourcePortIds.add(id);
+    const netIds = Array.isArray(element.connected_source_net_ids) ? element.connected_source_net_ids.filter((id) => typeof id === "string") : [];
+    const connectionIds = [...portIds, ...netIds];
+    const group = new Set(connectionIds);
+    for (const id of connectionIds) {
+      const existingGroup = connectionGroupById.get(id);
+      if (!existingGroup)
+        continue;
+      for (const connectedId of existingGroup)
+        group.add(connectedId);
+    }
+    for (const id of group)
+      connectionGroupById.set(id, group);
+  }
+  const connectedPortIdsByPortId = /* @__PURE__ */ new Map;
+  for (const group of new Set(connectionGroupById.values())) {
+    const portIds = new Set([...group].filter((id) => sourcePortIds.has(id)));
+    for (const id of portIds)
+      connectedPortIdsByPortId.set(id, portIds);
+  }
+  return connectedPortIdsByPortId;
+};
+var buildPcbPortIndexes = (circuitJson) => {
+  const sourceComponentIdBySourcePortId = /* @__PURE__ */ new Map;
+  const pcbPortBySourcePortId = /* @__PURE__ */ new Map;
+  const pcbPortsBySourceComponentId = /* @__PURE__ */ new Map;
+  for (const element of circuitJson) {
+    if (element.type === "source_port" && typeof element.source_port_id === "string" && typeof element.source_component_id === "string") {
+      sourceComponentIdBySourcePortId.set(element.source_port_id, element.source_component_id);
+    }
+  }
+  for (const element of circuitJson) {
+    if (!isPcbPort(element))
+      continue;
+    const pcbPort = element;
+    const sourceComponentId = sourceComponentIdBySourcePortId.get(pcbPort.source_port_id);
+    if (!sourceComponentId)
+      continue;
+    pcbPortBySourcePortId.set(pcbPort.source_port_id, pcbPort);
+    let componentPcbPorts = pcbPortsBySourceComponentId.get(sourceComponentId);
+    if (!componentPcbPorts) {
+      componentPcbPorts = [];
+      pcbPortsBySourceComponentId.set(sourceComponentId, componentPcbPorts);
+    }
+    componentPcbPorts.push(pcbPort);
+  }
+  return {
+    pcbPortBySourcePortId,
+    pcbPortsBySourceComponentId,
+    sourceComponentIdBySourcePortId
+  };
+};
+var doesConnectionCrossPadCenterline = ({
+  pcbPort,
+  connectedPcbPort,
+  firstComponentPcbPort,
+  secondComponentPcbPort
+}) => {
+  const padCenterlineX = (firstComponentPcbPort.x + secondComponentPcbPort.x) / 2;
+  const padCenterlineY = (firstComponentPcbPort.y + secondComponentPcbPort.y) / 2;
+  const padAxisX = secondComponentPcbPort.x - firstComponentPcbPort.x;
+  const padAxisY = secondComponentPcbPort.y - firstComponentPcbPort.y;
+  const pcbPortSide = (pcbPort.x - padCenterlineX) * padAxisX + (pcbPort.y - padCenterlineY) * padAxisY;
+  const connectedPcbPortSide = (connectedPcbPort.x - padCenterlineX) * padAxisX + (connectedPcbPort.y - padCenterlineY) * padAxisY;
+  if (pcbPortSide > GEOMETRY_EPSILON) {
+    return connectedPcbPortSide <= GEOMETRY_EPSILON;
+  }
+  if (pcbPortSide < -GEOMETRY_EPSILON) {
+    return connectedPcbPortSide >= -GEOMETRY_EPSILON;
+  }
+  return false;
+};
+var buildSuboptimalOrientationIssues = (circuitJson, components) => {
+  const issues = [];
+  const pcbPortIndexes = buildPcbPortIndexes(circuitJson);
+  const connectedSourcePortIdsBySourcePortId = buildConnectedSourcePortIdsBySourcePortId(circuitJson);
+  for (const component of components) {
+    if (!ORIENTATION_ANALYSIS_COMPONENT_TYPES.has(String(component.sourceComponent.ftype))) {
+      continue;
+    }
+    if (component.centerX === null || component.centerY === null)
+      continue;
+    const componentPcbPorts = pcbPortIndexes.pcbPortsBySourceComponentId.get(component.sourceComponentId);
+    if (!componentPcbPorts || componentPcbPorts.length < 2)
+      continue;
+    const [firstComponentPcbPort, secondComponentPcbPort] = componentPcbPorts;
+    if (!firstComponentPcbPort || !secondComponentPcbPort)
+      continue;
+    const hasMultiplePins = componentPcbPorts.length > 2;
+    const centerX = component.centerX;
+    const centerY = component.centerY;
+    const movingPcbPorts = componentPcbPorts.filter((port) => !hasMultiplePins || Math.hypot(port.x - centerX, port.y - centerY) > GEOMETRY_EPSILON);
+    if (movingPcbPorts.length < 2)
+      continue;
+    let crossingConnectionCount = 0;
+    for (const pcbPort of movingPcbPorts) {
+      const connectedSourcePortIds = connectedSourcePortIdsBySourcePortId.get(pcbPort.source_port_id);
+      if (!connectedSourcePortIds)
+        break;
+      if (componentPcbPorts.every((port) => connectedSourcePortIds.has(port.source_port_id))) {
+        break;
+      }
+      const rotatedPosition = {
+        x: 2 * component.centerX - pcbPort.x,
+        y: 2 * component.centerY - pcbPort.y
+      };
+      let connectedPcbPort;
+      let nearestDistance = Infinity;
+      let rotatedNearestDistance = Infinity;
+      for (const connectedSourcePortId of connectedSourcePortIds) {
+        const candidate = pcbPortIndexes.pcbPortBySourcePortId.get(connectedSourcePortId);
+        if (!candidate)
+          continue;
+        if (pcbPortIndexes.sourceComponentIdBySourcePortId.get(connectedSourcePortId) === component.sourceComponentId) {
+          continue;
+        }
+        if (!pcbPort.layers.some((layer) => candidate.layers.includes(layer))) {
+          continue;
+        }
+        const distance = Math.hypot(candidate.x - pcbPort.x, candidate.y - pcbPort.y);
+        if (distance < nearestDistance) {
+          connectedPcbPort = candidate;
+          nearestDistance = distance;
+        }
+        rotatedNearestDistance = Math.min(rotatedNearestDistance, Math.hypot(candidate.x - rotatedPosition.x, candidate.y - rotatedPosition.y));
+      }
+      if (!connectedPcbPort)
+        break;
+      if (rotatedNearestDistance >= nearestDistance - GEOMETRY_EPSILON)
+        break;
+      const crossesPadCenterline = doesConnectionCrossPadCenterline({
+        pcbPort,
+        connectedPcbPort,
+        firstComponentPcbPort: hasMultiplePins ? pcbPort : firstComponentPcbPort,
+        secondComponentPcbPort: hasMultiplePins ? rotatedPosition : secondComponentPcbPort
+      });
+      if (!crossesPadCenterline)
+        break;
+      crossingConnectionCount += 1;
+    }
+    if (crossingConnectionCount !== movingPcbPorts.length)
+      continue;
+    issues.push(createIssue({
+      type: "suboptimal_orientation",
+      componentA: component.name,
+      clearance: 0,
+      severity: SUBOPTIMAL_ORIENTATION_SEVERITY,
+      summary: hasMultiplePins ? `${component.name} connections favor the opposite orientation` : `${component.name} connections cross the routing path between its pads`,
+      suggested_move: `rotate ${component.name} 180 degrees`
+    }));
+  }
+  return issues;
+};
+var buildIssues = ({
+  circuitJson,
+  components,
+  boardBounds
+}) => {
   const issues = [];
   for (const component of components) {
     const boardEdgeStatus = getBoardEdgeStatus(component.bounds, boardBounds, component.name);
@@ -173414,6 +173618,7 @@ var buildIssues = (components, boardBounds) => {
       }
     }
   }
+  issues.push(...buildSuboptimalOrientationIssues(circuitJson, components));
   return issues.sort((a, b) => b.severity - a.severity);
 };
 var buildClusters = (components, issues) => {
@@ -173606,7 +173811,7 @@ var formatPlacementAnalysisReport = (report) => {
 };
 var buildPlacementAnalysisReport = (circuitJson) => {
   const { components, boardBounds } = buildComponentContexts(circuitJson);
-  const issues = buildIssues(components, boardBounds);
+  const issues = buildIssues({ circuitJson, components, boardBounds });
   const clusters = buildClusters(components, issues);
   const countsByType = buildCountsByType(issues);
   const boardTopLayer = buildBoardTopLayerReport(components, boardBounds);

package/dist/lib/index.js

@@ -69126,7 +69126,7 @@ var package_default = {
     "@babel/standalone": "^7.26.9",
     "@biomejs/biome": "^1.9.4",
     "@tscircuit/check-shorts": "https://jscdn.tscircuit.com/@tscircuit/check-shorts/0.0.19.tgz",
-    "@tscircuit/circuit-json-placement-analysis": "^0.0.9",
+    "@tscircuit/circuit-json-placement-analysis": "^0.0.15",
     "@tscircuit/circuit-json-routing-analysis": "^0.0.8",
     "@tscircuit/circuit-json-schematic-placement-analysis": "github:tscircuit/circuit-json-schematic-placement-analysis#cb6059c8e2561967afad591b30251a915cab42e5",
     "@tscircuit/circuit-json-util": "^0.0.113",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tscircuit/cli",
-  "version": "0.1.2049",
+  "version": "0.1.2050",
   "repository": {
     "type": "git",
     "url": "https://github.com/tscircuit/cli"
@@ -14,7 +14,7 @@
     "@babel/standalone": "^7.26.9",
     "@biomejs/biome": "^1.9.4",
     "@tscircuit/check-shorts": "https://jscdn.tscircuit.com/@tscircuit/check-shorts/0.0.19.tgz",
-    "@tscircuit/circuit-json-placement-analysis": "^0.0.9",
+    "@tscircuit/circuit-json-placement-analysis": "^0.0.15",
     "@tscircuit/circuit-json-routing-analysis": "^0.0.8",
     "@tscircuit/circuit-json-schematic-placement-analysis": "github:tscircuit/circuit-json-schematic-placement-analysis#cb6059c8e2561967afad591b30251a915cab42e5",
     "@tscircuit/circuit-json-util": "^0.0.113",