@tscircuit/checks 0.0.181 → 0.0.183

package/dist/index.d.ts

@@ -1,5 +1,5 @@
 import * as circuit_json from 'circuit-json';
-import { AnyCircuitElement, PcbPortNotConnectedError, PcbTraceError, PcbPlacementError, PcbComponentOutsideBoardError, PcbViaClearanceError, PcbTraceWarning, PcbTraceMissingError, PcbFootprintOverlapError, PcbComponentMissingCourtyardWarning, PcbTraceTooLongWarning, PcbPadPadClearanceError, PcbPadTraceClearanceError, PcbViaTraceClearanceError, SourceComponentPinsUnderspecifiedWarning, SourceNoPowerPinDefinedWarning, SourceNoGroundPinDefinedWarning, SchematicComponentStylingWarning, PcbConnectorNotInAccessibleOrientationWarning } from 'circuit-json';
+import { AnyCircuitElement, PcbPortNotConnectedError, PcbTraceError, PcbPlacementError, PcbComponentOutsideBoardError, PcbViaClearanceError, PcbTraceWarning, PcbTraceMissingError, PcbFootprintOverlapError, PcbComponentMissingCourtyardWarning, PcbTraceTooLongWarning, PcbPadPadClearanceError, PcbPadTraceClearanceError, PcbViaTraceClearanceError, SourceComponentMisconfiguredError, SourceComponentPinsUnderspecifiedWarning, SourceNoPowerPinDefinedWarning, SourceNoGroundPinDefinedWarning, SchematicComponentStylingWarning, PcbConnectorNotInAccessibleOrientationWarning } from 'circuit-json';
 import { ConnectivityMap } from 'circuit-json-to-connectivity-map';
 
 declare function checkEachPcbPortConnectedToPcbTraces(circuitJson: AnyCircuitElement[]): PcbPortNotConnectedError[];
@@ -142,6 +142,8 @@ type SourcePinMustBeConnectedError = {
  */
 declare function checkPinMustBeConnected(circuitJson: AnyCircuitElement[]): SourcePinMustBeConnectedError[];
 
+declare function checkTwoTerminalSwitchContactsOnDifferentNets(circuitJson: AnyCircuitElement[]): SourceComponentMisconfiguredError[];
+
 /**
  * Check that each component with ports has at least one pin attribute
  * specified across its ports. Returns a warning when all pins are
@@ -182,7 +184,7 @@ declare function checkSchematicComponentMissingReferenceDesignatorText(circuitJs
 declare function checkSchematicComponentPortsOutsideBody(circuitJson: AnyCircuitElement[]): SchematicComponentStylingWarning[];
 
 declare function runAllPlacementChecks(circuitJson: AnyCircuitElement[]): Promise<(circuit_json.PcbPlacementError | circuit_json.PcbComponentOutsideBoardError | circuit_json.PcbFootprintOverlapError | circuit_json.PcbComponentMissingCourtyardWarning | circuit_json.PcbPadPadClearanceError | circuit_json.PcbConnectorNotInAccessibleOrientationWarning | circuit_json.PcbCourtyardOverlapError)[]>;
-declare function runAllNetlistChecks(circuitJson: AnyCircuitElement[]): Promise<{
+declare function runAllNetlistChecks(circuitJson: AnyCircuitElement[]): Promise<({
     type: "source_pin_must_be_connected_error";
     source_pin_must_be_connected_error_id: string;
     error_type: "source_pin_must_be_connected_error";
@@ -190,7 +192,7 @@ declare function runAllNetlistChecks(circuitJson: AnyCircuitElement[]): Promise<
     source_component_id: string;
     source_port_id: string;
     subcircuit_id?: string;
-}[]>;
+} | circuit_json.SourceComponentMisconfiguredError)[]>;
 declare function runAllSchematicChecks(circuitJson: AnyCircuitElement[]): Promise<circuit_json.SchematicComponentStylingWarning[]>;
 declare function runAllPinSpecificationChecks(circuitJson: AnyCircuitElement[]): Promise<(circuit_json.SourceComponentPinsUnderspecifiedWarning | circuit_json.SourceNoPowerPinDefinedWarning | circuit_json.SourceNoGroundPinDefinedWarning)[]>;
 declare function runAllRoutingChecks(circuitJson: AnyCircuitElement[]): Promise<(circuit_json.PcbPortNotConnectedError | circuit_json.PcbTraceError | circuit_json.PcbViaClearanceError | circuit_json.PcbTraceMissingError | circuit_json.PcbTraceTooLongWarning | circuit_json.PcbPadPadClearanceError | circuit_json.PcbPadTraceClearanceError | circuit_json.PcbViaTraceClearanceError)[]>;
@@ -202,7 +204,7 @@ declare function runAllChecks(circuitJson: AnyCircuitElement[]): Promise<(circui
     source_component_id: string;
     source_port_id: string;
     subcircuit_id?: string;
-} | circuit_json.SourceComponentPinsUnderspecifiedWarning | circuit_json.SourceNoPowerPinDefinedWarning | circuit_json.SourceNoGroundPinDefinedWarning | circuit_json.SchematicComponentStylingWarning | circuit_json.PcbConnectorNotInAccessibleOrientationWarning | circuit_json.PcbCourtyardOverlapError)[]>;
+} | circuit_json.SourceComponentMisconfiguredError | circuit_json.SourceComponentPinsUnderspecifiedWarning | circuit_json.SourceNoPowerPinDefinedWarning | circuit_json.SourceNoGroundPinDefinedWarning | circuit_json.SchematicComponentStylingWarning | circuit_json.PcbConnectorNotInAccessibleOrientationWarning | circuit_json.PcbCourtyardOverlapError)[]>;
 
 declare function checkConnectorAccessibleOrientation(circuitJson: AnyCircuitElement[]): PcbConnectorNotInAccessibleOrientationWarning[];
 
@@ -213,4 +215,4 @@ declare function checkConnectorAccessibleOrientation(circuitJson: AnyCircuitElem
  */
 declare function checkTestPointAccessibility(circuitJson: AnyCircuitElement[]): PcbPlacementError[];
 
-export { NetManager, checkAllPinsInComponentAreUnderspecified, checkConnectorAccessibleOrientation, checkCopperToBoardEdgeClearance, checkDifferentNetViaSpacing, checkEachPcbPortConnectedToPcbTraces, checkEachPcbTraceNonOverlapping, checkNoGroundPinDefined, checkNoPowerPinDefined, checkPadPadClearance, checkPadTraceClearance, checkPcbComponentOverCutout, checkPcbComponentOverlap, checkPcbComponentsMissingCourtyard, checkPcbComponentsOutOfBoard, checkPcbCopperOverKeepout, checkPcbTraceLengths, checkPcbTraceViaCounts, checkPcbTracesOutOfBoard, checkPinMustBeConnected, checkSameNetViaSpacing, checkSchematicComponentExcessiveVerticalPadding, checkSchematicComponentMissingReferenceDesignatorText, checkSchematicComponentPortsOutsideBody, checkSourceTracesHavePcbTraces, checkSourceTracesMatchPcbTraceThickness, checkTestPointAccessibility, checkTracesAreContiguous, checkViaPadClearance, checkViaTraceClearance, checkViasInPads, checkViasOffBoard, dedupePcbDrcErrors, runAllChecks, runAllNetlistChecks, runAllPinSpecificationChecks, runAllPlacementChecks, runAllRoutingChecks, runAllSchematicChecks };
+export { NetManager, checkAllPinsInComponentAreUnderspecified, checkConnectorAccessibleOrientation, checkCopperToBoardEdgeClearance, checkDifferentNetViaSpacing, checkEachPcbPortConnectedToPcbTraces, checkEachPcbTraceNonOverlapping, checkNoGroundPinDefined, checkNoPowerPinDefined, checkPadPadClearance, checkPadTraceClearance, checkPcbComponentOverCutout, checkPcbComponentOverlap, checkPcbComponentsMissingCourtyard, checkPcbComponentsOutOfBoard, checkPcbCopperOverKeepout, checkPcbTraceLengths, checkPcbTraceViaCounts, checkPcbTracesOutOfBoard, checkPinMustBeConnected, checkSameNetViaSpacing, checkSchematicComponentExcessiveVerticalPadding, checkSchematicComponentMissingReferenceDesignatorText, checkSchematicComponentPortsOutsideBody, checkSourceTracesHavePcbTraces, checkSourceTracesMatchPcbTraceThickness, checkTestPointAccessibility, checkTracesAreContiguous, checkTwoTerminalSwitchContactsOnDifferentNets, checkViaPadClearance, checkViaTraceClearance, checkViasInPads, checkViasOffBoard, dedupePcbDrcErrors, runAllChecks, runAllNetlistChecks, runAllPinSpecificationChecks, runAllPlacementChecks, runAllRoutingChecks, runAllSchematicChecks };

package/dist/index.js

@@ -607,6 +607,14 @@ var getBoardDrcValue = (board, key) => board?.[key];
 // lib/check-pad-clearance/common.ts
 var getPadBounds = (pad) => {
   if (pad.type === "pcb_keepout") {
+    if (pad.shape === "outline") {
+      return {
+        minX: Math.min(...pad.outline.map((point) => point.x)),
+        minY: Math.min(...pad.outline.map((point) => point.y)),
+        maxX: Math.max(...pad.outline.map((point) => point.x)),
+        maxY: Math.max(...pad.outline.map((point) => point.y))
+      };
+    }
     if (pad.shape === "circle") {
       return {
         minX: pad.center.x - pad.radius,
@@ -625,7 +633,7 @@ var getPadBounds = (pad) => {
   return getBoundsOfPcbElements2([pad]);
 };
 var getPadCenter = (pad) => {
-  if (pad.type === "pcb_keepout") return pad.center;
+  if (pad.type === "pcb_keepout" && pad.shape !== "outline") return pad.center;
   const bounds = getPadBounds(pad);
   return midpoint(
     { x: bounds.minX, y: bounds.minY },
@@ -650,6 +658,12 @@ var getCircleShape = (pad) => {
 };
 var getPolygonShape = (pad) => {
   if (pad.type === "pcb_keepout") {
+    if (pad.shape === "outline") {
+      return {
+        kind: "polygon",
+        points: pad.outline
+      };
+    }
     if (pad.shape !== "rect") {
       throw new Error(`Expected rectangular keepout, got ${pad.shape}`);
     }
@@ -2378,6 +2392,7 @@ function checkPcbComponentOverCutout(circuitJson) {
       height: component.height
     });
     for (const { cutout, polygon: cutoutPolygon } of cutoutPolygons) {
+      if (cutout.pcb_component_id === component.pcb_component_id) continue;
       if (!doPolygonsOverlap(componentPolygon, cutoutPolygon)) continue;
       const componentName = getReadableNameForComponent(
         circuitJson,
@@ -3899,6 +3914,51 @@ function checkPinMustBeConnected(circuitJson) {
   return errors;
 }
 
+// lib/check-two-terminal-switch-contacts-on-different-nets.ts
+import {
+  source_component_misconfigured_error
+} from "circuit-json";
+function checkTwoTerminalSwitchContactsOnDifferentNets(circuitJson) {
+  const switchingComponents = circuitJson.filter(
+    (element) => element.type === "source_component" && (element.ftype === "simple_push_button" || element.ftype === "simple_switch")
+  );
+  const sourcePorts = circuitJson.filter(
+    (element) => element.type === "source_port"
+  );
+  const schematicPorts = circuitJson.filter(
+    (element) => element.type === "schematic_port"
+  );
+  const errors = [];
+  for (const switchingComponent of switchingComponents) {
+    const schematicContactSourcePorts = schematicPorts.flatMap(
+      (schematicPort) => {
+        const sourcePort = sourcePorts.find(
+          (sourcePort2) => sourcePort2.source_port_id === schematicPort.source_port_id && sourcePort2.source_component_id === switchingComponent.source_component_id
+        );
+        if (!sourcePort) return [];
+        return [sourcePort];
+      }
+    );
+    if (schematicContactSourcePorts.length !== 2) continue;
+    const firstContactConnectivityKey = schematicContactSourcePorts[0].subcircuit_connectivity_map_key;
+    const secondContactConnectivityKey = schematicContactSourcePorts[1].subcircuit_connectivity_map_key;
+    if (!firstContactConnectivityKey) continue;
+    if (firstContactConnectivityKey !== secondContactConnectivityKey) continue;
+    errors.push(
+      source_component_misconfigured_error.parse({
+        type: "source_component_misconfigured_error",
+        message: `Switch ${switchingComponent.name} has both schematic contacts connected to the same net. Check internallyConnectedPins and the footprint pin mapping.`,
+        source_component_ids: [switchingComponent.source_component_id],
+        source_port_ids: schematicContactSourcePorts.map(
+          (sourcePort) => sourcePort.source_port_id
+        ),
+        is_fatal: true
+      })
+    );
+  }
+  return errors;
+}
+
 // lib/check-all-pins-in-component-are-underspecified.ts
 import { cju as cju7 } from "@tscircuit/circuit-json-util";
 var PIN_ATTRIBUTE_KEYS = [
@@ -4583,7 +4643,10 @@ async function runAllPlacementChecks(circuitJson) {
   ];
 }
 async function runAllNetlistChecks(circuitJson) {
-  return [...checkPinMustBeConnected(circuitJson)];
+  return [
+    ...checkPinMustBeConnected(circuitJson),
+    ...checkTwoTerminalSwitchContactsOnDifferentNets(circuitJson)
+  ];
 }
 async function runAllSchematicChecks(circuitJson) {
   return [
@@ -4653,6 +4716,7 @@ export {
   checkSourceTracesMatchPcbTraceThickness,
   checkTestPointAccessibility,
   checkTracesAreContiguous,
+  checkTwoTerminalSwitchContactsOnDifferentNets,
   checkViaPadClearance,
   checkViaTraceClearance,
   checkViasInPads,