@tscircuit/checks 0.0.171 → 0.0.172

package/dist/index.js

@@ -3605,6 +3605,7 @@ function checkViaPadClearance(circuitJson, {
 
 // lib/check-vias-in-pads.ts
 import { getPrimaryId as getPrimaryId7 } from "@tscircuit/circuit-json-util";
+import { getFullConnectivityMapFromCircuitJson as getFullConnectivityMapFromCircuitJson12 } from "circuit-json-to-connectivity-map";
 function checkViasInPads(circuitJson) {
   const board = getPcbBoard(circuitJson);
   if (board && "is_via_in_pad_allowed" in board && board.is_via_in_pad_allowed === true) {
@@ -3615,6 +3616,7 @@ function checkViasInPads(circuitJson) {
   );
   const pads = getPads(circuitJson);
   if (vias.length === 0 || pads.length === 0) return [];
+  const connMap = getFullConnectivityMapFromCircuitJson12(circuitJson);
   const padOrdinals = new Map(
     pads.map((pad, index) => [getPrimaryId7(pad), index])
   );
@@ -3625,18 +3627,14 @@ function checkViasInPads(circuitJson) {
   });
   const errors = [];
   for (const via of vias) {
-    const nearbyPads = padIndex.getObjectsInBounds({
-      minX: via.x,
-      minY: via.y,
-      maxX: via.x,
-      maxY: via.y
-    });
+    const nearbyPads = padIndex.getObjectsInBounds(getPadBounds(via));
     for (const pad of nearbyPads) {
+      const padId = getPrimaryId7(pad);
       const viaLayers = getLayersOfPcbElement(via);
       const padLayers = getLayersOfPcbElement(pad);
       if (!viaLayers.some((layer) => padLayers.includes(layer))) continue;
-      if (!isPointInPad(via, pad)) continue;
-      const padId = getPrimaryId7(pad);
+      if (connMap.areIdsConnected(via.pcb_via_id, padId)) continue;
+      if (getPadToPadGap(via, pad) > 0) continue;
       const padOrdinal = padOrdinals.get(padId) ?? 0;
       const padName = getReadableNameForFootprintPad(
         circuitJson,
@@ -3647,7 +3645,7 @@ function checkViasInPads(circuitJson) {
         type: "pcb_placement_error",
         pcb_placement_error_id: `via_in_pad_${via.pcb_via_id}_${padId}`,
         error_type: "pcb_placement_error",
-        message: `Via at (${via.x.toFixed(2)}mm, ${via.y.toFixed(2)}mm) is inside ${padName}`,
+        message: `Via copper at (${via.x.toFixed(2)}mm, ${via.y.toFixed(2)}mm) overlaps ${padName}`,
         subcircuit_id: via.subcircuit_id ?? pad.subcircuit_id
       });
     }