@ts-core/oauth 3.0.30 → 3.1.1

package/cjs/OAuthBase.d.ts

@@ -1,56 +1,32 @@
-import { PromiseHandler, ObservableData, LoggerWrapper, ILogger, TransportHttp } from "@ts-core/common";
-import { Observable, Subject } from "rxjs";
-export declare abstract class OAuthBase<T = any> extends LoggerWrapper {
+import { ILogger, TransportHttp, ExtendedError } from "@ts-core/common";
+import { PopUpBase } from "./PopUpBase";
+export declare abstract class OAuthBase<T = any> extends PopUpBase<IOAuthDto> {
     protected applicationId: string;
-    protected window?: Window;
-    static ERROR_WINDOW_CLOSED: string;
-    popUpWidth: number;
-    popUpHeight: number;
-    popUpTarget: string;
-    popUpOpener: IOAuthPopUpOpener;
-    popUpMessageParser: IOAuthPopUpMessageParser;
     redirectUri: string;
-    isRejectWhenPopUpClosed: boolean;
     protected http: TransportHttp;
-    protected subject: Subject<ObservableData<OAuthEvent, Window>>;
-    protected popUp: Window;
-    protected promise: PromiseHandler<IOAuthDto>;
     protected responseType: string;
-    protected _urlParams: Map<string, string>;
-    protected _popUpCheckCloseTimer: any;
     constructor(logger: ILogger, applicationId: string, window?: Window);
-    protected open(): Promise<IOAuthDto>;
-    protected popUpFocus(): void;
-    protected popUpCheckClose: () => void;
-    protected getUrlParams(): URLSearchParams;
-    protected popUpOpenHandler: () => Window;
-    protected popUpMessageHandler: (event: MessageEvent) => void;
-    abstract getPopUpUrl(): string;
-    getOriginUrl(): string;
-    getRedirectUri(): string;
+    protected getRedirectUri(): string;
+    protected getParams(): URLSearchParams;
+    protected parseMessageData(item: any): IOAuthDto;
+    protected isMessageError(item: any): boolean;
+    protected parseMessageError(item: any): ExtendedError;
     abstract getProfile(token: string, ...params: any[]): Promise<T>;
     abstract getTokenByCode(dto: IOAuthDto, secret: string): Promise<IOAuthToken>;
-    parseResponse(data: IOAuthPopUpDto): void;
     getCode(): Promise<IOAuthDto>;
     getToken(): Promise<IOAuthDto>;
-    close(): void;
+    parse(item: any): void;
     destroy(): void;
-    protected get isPopUpOpened(): boolean;
-    protected get popUpCheckCloseTimer(): any;
-    protected set popUpCheckCloseTimer(value: any);
-    get urlParams(): Map<string, string>;
     get state(): string;
-    get events(): Observable<ObservableData<OAuthEvent, Window>>;
-    get popUpClosed(): Observable<Window>;
-    get popUpOpened(): Observable<Window>;
 }
 export interface IOAuthDto {
     codeOrToken: string;
     redirectUri: string;
 }
 export interface IOAuthPopUpDto {
-    oAuthError: string;
-    oAuthCodeOrToken: string;
+    oauthError?: string;
+    oauthCodeOrToken?: string;
+    oauthErrorDescription?: string;
 }
 export interface IOAuthToken {
     expiresIn: number;
@@ -63,9 +39,3 @@ export interface IOAuthToken {
     refreshToken?: string;
     refreshExpiresIn?: string;
 }
-export declare enum OAuthEvent {
-    POPUP_OPENED = "POPUP_OPENED",
-    POPUP_CLOSED = "POPUP_CLOSED"
-}
-export type IOAuthPopUpOpener = <T extends OAuthBase>(item: T, window: Window) => Window;
-export type IOAuthPopUpMessageParser = <T extends OAuthBase>(item: T, event: MessageEvent) => IOAuthPopUpDto;

package/cjs/OAuthBase.js

@@ -9,80 +9,43 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
     });
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.OAuthEvent = exports.OAuthBase = void 0;
+exports.OAuthBase = void 0;
 const common_1 = require("@ts-core/common");
 const _ = require("lodash");
 const rxjs_1 = require("rxjs");
-const external_1 = require("./external");
-class OAuthBase extends common_1.LoggerWrapper {
+const PopUpBase_1 = require("./PopUpBase");
+const public_api_1 = require("./public-api");
+class OAuthBase extends PopUpBase_1.PopUpBase {
     constructor(logger, applicationId, window) {
-        super(logger);
+        super(logger, window);
         this.applicationId = applicationId;
-        this.window = window;
-        this.popUpCheckClose = () => {
-            if (!this.isPopUpOpened) {
-                this.close();
-            }
-        };
-        this.popUpOpenHandler = () => this.popUpOpener(this, this.window);
-        this.popUpMessageHandler = (event) => this.parseResponse(this.popUpMessageParser(this, event));
         this.http = new common_1.TransportHttp(logger, { method: 'get' });
         this.subject = new rxjs_1.Subject();
-        this.popUpWidth = 430;
-        this.popUpHeight = 520;
-        this.popUpTarget = '_blank';
-        this._urlParams = new Map();
-        this.urlParams.set('state', common_1.RandomUtil.randomString());
-        this.urlParams.set('display', 'popup');
-        (0, external_1.OAuthBrowserPropertiesSet)(this);
-    }
-    open() {
-        return __awaiter(this, void 0, void 0, function* () {
-            if (!_.isNil(this.promise)) {
-                this.popUpFocus();
-                return this.promise.promise;
-            }
-            this.promise = common_1.PromiseHandler.create();
-            this.popUp = this.popUpOpenHandler();
-            this.popUpFocus();
-            this.window.addEventListener('message', this.popUpMessageHandler, false);
-            this.subject.next(new common_1.ObservableData(OAuthEvent.POPUP_OPENED, this.popUp));
-            this.popUpCheckCloseTimer = setInterval(this.popUpCheckClose, common_1.DateUtil.MILLISECONDS_SECOND / 5);
-            return this.promise.promise;
-        });
+        this.params.set('state', common_1.RandomUtil.randomString());
+        this.params.set('display', 'popup');
+        (0, public_api_1.OAuthBrowserPropertiesSet)(this);
     }
-    popUpFocus() {
-        if (this.isPopUpOpened && _.isFunction(this.popUp.focus)) {
-            this.popUp.focus();
-        }
+    getRedirectUri() {
+        return !_.isNil(this.redirectUri) ? this.redirectUri : `${this.originUrl}/oauth`;
     }
-    getUrlParams() {
-        let item = new URLSearchParams();
+    getParams() {
+        let item = super.getParams();
         item.append('client_id', this.applicationId);
         item.append('redirect_uri', this.getRedirectUri());
         item.append('response_type', this.responseType);
-        this.urlParams.forEach((value, key) => item.append(key, value));
         return item;
     }
-    getOriginUrl() {
-        return this.window.location.origin;
+    parseMessageData(item) {
+        return {
+            codeOrToken: item.oauthCodeOrToken,
+            redirectUri: this.getRedirectUri()
+        };
     }
-    getRedirectUri() {
-        return !_.isNil(this.redirectUri) ? this.redirectUri : `${this.getOriginUrl()}/oauth`;
+    isMessageError(item) {
+        return !_.isNil(item.oauthError);
     }
-    parseResponse(data) {
-        if (_.isNil(data)) {
-            return;
-        }
-        if (!_.isEmpty(data.oAuthCodeOrToken)) {
-            this.promise.resolve({ redirectUri: this.getRedirectUri(), codeOrToken: data.oAuthCodeOrToken });
-            this.promise = null;
-        }
-        if (!_.isEmpty(data.oAuthError)) {
-            this.promise.reject(data.oAuthError);
-            this.promise = null;
-        }
-        this.close();
+    parseMessageError(item) {
+        return new common_1.ExtendedError(item.oauthError, item.oauthErrorDescription);
     }
     getCode() {
         return __awaiter(this, void 0, void 0, function* () {
@@ -96,76 +59,21 @@ class OAuthBase extends common_1.LoggerWrapper {
             return this.open();
         });
     }
-    close() {
-        this.window.removeEventListener('message', this.popUpMessageHandler, false);
-        this.popUpCheckCloseTimer = null;
-        if (_.isNil(this.popUp)) {
-            return;
-        }
-        this.subject.next(new common_1.ObservableData(OAuthEvent.POPUP_CLOSED, this.popUp));
-        this.popUp.close();
-        this.popUp = null;
-        if (this.isRejectWhenPopUpClosed && !_.isNil(this.promise)) {
-            this.promise.reject(OAuthBase.ERROR_WINDOW_CLOSED);
-            this.promise = null;
-        }
+    parse(item) {
+        super.popUpMessageParse(item);
     }
     destroy() {
         if (this.isDestroyed) {
             return;
         }
         super.destroy();
-        this.close();
-        if (!_.isNil(this.promise)) {
-            this.promise.reject(OAuthBase.ERROR_WINDOW_CLOSED);
-            this.promise = null;
-        }
-        if (!_.isNil(this.urlParams)) {
-            this.urlParams.clear();
-            this._urlParams = null;
-        }
         if (!_.isNil(this.http)) {
             this.http.destroy();
             this.http = null;
         }
-        if (!_.isNil(this.subject)) {
-            this.subject.complete();
-            this.subject = null;
-        }
-    }
-    get isPopUpOpened() {
-        return !_.isNil(this.popUp) && !this.popUp.closed;
-    }
-    get popUpCheckCloseTimer() {
-        return this._popUpCheckCloseTimer;
-    }
-    set popUpCheckCloseTimer(value) {
-        if (value === this._popUpCheckCloseTimer) {
-            return;
-        }
-        clearInterval(this._popUpCheckCloseTimer);
-        this._popUpCheckCloseTimer = value;
-    }
-    get urlParams() {
-        return this._urlParams;
     }
     get state() {
-        return !_.isNil(this.urlParams) ? this.urlParams.get('state') : null;
-    }
-    get events() {
-        return !_.isNil(this.subject) ? this.subject.asObservable() : null;
-    }
-    get popUpClosed() {
-        return this.events.pipe((0, rxjs_1.filter)(item => item.type === OAuthEvent.POPUP_CLOSED), (0, rxjs_1.map)(item => item.data));
-    }
-    get popUpOpened() {
-        return this.events.pipe((0, rxjs_1.filter)(item => item.type === OAuthEvent.POPUP_OPENED), (0, rxjs_1.map)(item => item.data));
+        return !_.isNil(this.params) ? this.params.get('state') : null;
     }
 }
 exports.OAuthBase = OAuthBase;
-OAuthBase.ERROR_WINDOW_CLOSED = 'WINDOW_CLOSED';
-var OAuthEvent;
-(function (OAuthEvent) {
-    OAuthEvent["POPUP_OPENED"] = "POPUP_OPENED";
-    OAuthEvent["POPUP_CLOSED"] = "POPUP_CLOSED";
-})(OAuthEvent = exports.OAuthEvent || (exports.OAuthEvent = {}));

package/cjs/OAuthParser.js

@@ -9,18 +9,21 @@ class OAuthParser {
         if (!_.isEmpty(fragment)) {
             new URLSearchParams(fragment).forEach((value, key) => item[key] = value);
         }
-        let oAuthError = null;
-        let oAuthCodeOrToken = null;
+        let oauthError = null;
+        let oauthCodeOrToken = null;
         for (let key in item) {
             let value = item[key];
             if (OAuthParser.NAMES.includes(key)) {
-                oAuthCodeOrToken = value;
+                oauthCodeOrToken = value;
             }
             else if (OAuthParser.ERRORS.includes(key)) {
-                oAuthError = value;
+                oauthError = value;
             }
-            if (!_.isEmpty(oAuthCodeOrToken) || !_.isEmpty(oAuthError)) {
-                return { oAuthCodeOrToken, oAuthError };
+            if (!_.isEmpty(oauthCodeOrToken)) {
+                return { oauthCodeOrToken };
+            }
+            else if (!_.isEmpty(oauthError)) {
+                return { oauthErrorDescription: item.error_description, oauthError };
             }
         }
         ;
@@ -29,4 +32,4 @@ class OAuthParser {
 }
 exports.OAuthParser = OAuthParser;
 OAuthParser.NAMES = ['code', 'access_token'];
-OAuthParser.ERRORS = ['error_description', 'error'];
+OAuthParser.ERRORS = ['error', 'error_description'];

package/cjs/PopUpBase.d.ts

@@ -0,0 +1,45 @@
+import { PromiseHandler, ObservableData, LoggerWrapper, ILogger, ExtendedError } from "@ts-core/common";
+import { Observable, Subject } from "rxjs";
+export declare abstract class PopUpBase<U> extends LoggerWrapper {
+    static ERROR_WINDOW_CLOSED: string;
+    popUpWidth: number;
+    popUpHeight: number;
+    popUpTarget: string;
+    popUpOpener: IPopUpOpener;
+    popUpMessageEventParser: IPopUpMessageEventParser;
+    protected popUp: Window;
+    protected window: Window;
+    protected subject: Subject<ObservableData<PopUpEvent, Window>>;
+    protected promise: PromiseHandler<U, ExtendedError>;
+    protected _params: Map<string, string>;
+    protected _popUpCheckCloseTimer: any;
+    isRejectWhenPopUpClosed: boolean;
+    constructor(logger: ILogger, window?: Window);
+    protected popUpFocus(): void;
+    protected popUpCheckClose: () => void;
+    protected getParams(): URLSearchParams;
+    protected popUpMessageHandler(event: MessageEvent): void;
+    protected popUpMessageParse(item: any): void;
+    protected popUpMessageHandlerProxy: (event: MessageEvent) => void;
+    protected abstract isMessageError(item: any): boolean;
+    protected abstract parseMessageData(item: any): U;
+    protected abstract parseMessageError(item: any): ExtendedError;
+    open(...params: any[]): Promise<U>;
+    close(): void;
+    destroy(): void;
+    abstract popUpUrl(): string;
+    protected get isPopUpOpened(): boolean;
+    protected get popUpCheckCloseTimer(): any;
+    protected set popUpCheckCloseTimer(value: any);
+    get originUrl(): string;
+    get params(): Map<string, string>;
+    get events(): Observable<ObservableData<PopUpEvent, Window>>;
+    get closed(): Observable<Window>;
+    get opened(): Observable<Window>;
+}
+export type IPopUpOpener = <T extends PopUpBase<U>, U>(popUp: T, window: Window) => Window;
+export type IPopUpMessageEventParser = (event: MessageEvent) => any;
+export declare enum PopUpEvent {
+    OPENED = "OPENED",
+    CLOSED = "CLOSED"
+}

package/cjs/PopUpBase.js

@@ -0,0 +1,145 @@
+"use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.PopUpEvent = exports.PopUpBase = void 0;
+const common_1 = require("@ts-core/common");
+const rxjs_1 = require("rxjs");
+const external_1 = require("./external");
+const _ = require("lodash");
+class PopUpBase extends common_1.LoggerWrapper {
+    constructor(logger, window) {
+        super(logger);
+        this.popUpCheckClose = () => {
+            if (!this.isPopUpOpened) {
+                this.close();
+            }
+        };
+        this.popUpMessageHandlerProxy = (event) => this.popUpMessageHandler(event);
+        this.window = window;
+        this.subject = new rxjs_1.Subject();
+        this._params = new Map();
+        this.popUpWidth = 430;
+        this.popUpHeight = 520;
+        this.popUpTarget = '_blank';
+        this.popUpOpener = external_1.popUpOpener;
+        this.isRejectWhenPopUpClosed = true;
+    }
+    popUpFocus() {
+        if (this.isPopUpOpened && _.isFunction(this.popUp.focus)) {
+            this.popUp.focus();
+        }
+    }
+    getParams() {
+        let item = new URLSearchParams();
+        this.params.forEach((value, key) => item.append(key, value));
+        return item;
+    }
+    popUpMessageHandler(event) {
+        if (event.origin === this.originUrl && !_.isNil(event.data)) {
+            this.popUpMessageParse(this.popUpMessageEventParser(event));
+        }
+    }
+    popUpMessageParse(item) {
+        if (_.isNil(item)) {
+            return;
+        }
+        if (this.isMessageError(item)) {
+            this.promise.reject(this.parseMessageError(item));
+        }
+        else {
+            this.promise.resolve(this.parseMessageData(item));
+        }
+        this.close();
+    }
+    open(...params) {
+        return __awaiter(this, void 0, void 0, function* () {
+            if (!_.isNil(this.promise)) {
+                this.popUpFocus();
+                return this.promise.promise;
+            }
+            this.promise = common_1.PromiseHandler.create();
+            this.popUp = this.popUpOpener(this, this.window);
+            this.popUpFocus();
+            this.window.addEventListener('message', this.popUpMessageHandlerProxy, false);
+            this.subject.next(new common_1.ObservableData(PopUpEvent.OPENED, this.popUp));
+            this.popUpCheckCloseTimer = setInterval(this.popUpCheckClose, common_1.DateUtil.MILLISECONDS_SECOND / 5);
+            return this.promise.promise;
+        });
+    }
+    close() {
+        this.window.removeEventListener('message', this.popUpMessageHandlerProxy, false);
+        this.popUpCheckCloseTimer = null;
+        if (_.isNil(this.popUp)) {
+            return;
+        }
+        this.subject.next(new common_1.ObservableData(PopUpEvent.CLOSED, this.popUp));
+        this.popUp.close();
+        this.popUp = null;
+        if (this.isRejectWhenPopUpClosed && !_.isNil(this.promise)) {
+            this.promise.reject(new common_1.ExtendedError(PopUpBase.ERROR_WINDOW_CLOSED, PopUpBase.ERROR_WINDOW_CLOSED));
+            this.promise = null;
+        }
+    }
+    destroy() {
+        if (this.isDestroyed) {
+            return;
+        }
+        super.destroy();
+        this.close();
+        if (!_.isNil(this.promise)) {
+            this.promise.reject(new common_1.ExtendedError(PopUpBase.ERROR_WINDOW_CLOSED, PopUpBase.ERROR_WINDOW_CLOSED));
+            this.promise = null;
+        }
+        if (!_.isNil(this.params)) {
+            this.params.clear();
+            this._params = null;
+        }
+        if (!_.isNil(this.subject)) {
+            this.subject.complete();
+            this.subject = null;
+        }
+    }
+    get isPopUpOpened() {
+        return !_.isNil(this.popUp) && !this.popUp.closed;
+    }
+    get popUpCheckCloseTimer() {
+        return this._popUpCheckCloseTimer;
+    }
+    set popUpCheckCloseTimer(value) {
+        if (value === this._popUpCheckCloseTimer) {
+            return;
+        }
+        clearInterval(this._popUpCheckCloseTimer);
+        this._popUpCheckCloseTimer = value;
+    }
+    get originUrl() {
+        return this.window.location.origin;
+    }
+    get params() {
+        return this._params;
+    }
+    get events() {
+        return !_.isNil(this.subject) ? this.subject.asObservable() : null;
+    }
+    get closed() {
+        return this.events.pipe((0, rxjs_1.filter)(item => item.type === PopUpEvent.CLOSED), (0, rxjs_1.map)(item => item.data));
+    }
+    get opened() {
+        return this.events.pipe((0, rxjs_1.filter)(item => item.type === PopUpEvent.OPENED), (0, rxjs_1.map)(item => item.data));
+    }
+}
+exports.PopUpBase = PopUpBase;
+PopUpBase.ERROR_WINDOW_CLOSED = 'WINDOW_CLOSED';
+var PopUpEvent;
+(function (PopUpEvent) {
+    PopUpEvent["OPENED"] = "OPENED";
+    PopUpEvent["CLOSED"] = "CLOSED";
+})(PopUpEvent = exports.PopUpEvent || (exports.PopUpEvent = {}));

package/cjs/external/browser.d.ts

@@ -1,2 +1,5 @@
 import { OAuthBase } from '../OAuthBase';
+import { PopUpBase } from '../PopUpBase';
 export declare const OAuthBrowserPropertiesSet: (item: OAuthBase) => void;
+export declare function popUpOpener<T extends PopUpBase<U>, U>(popUp: T, window: Window): Window;
+export declare function popUpMessageEventParser(event: MessageEvent): any;

package/cjs/external/browser.js

@@ -1,29 +1,20 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.OAuthBrowserPropertiesSet = void 0;
+exports.popUpMessageEventParser = exports.popUpOpener = exports.OAuthBrowserPropertiesSet = void 0;
 const _ = require("lodash");
-const common_1 = require("@ts-core/common");
 const OAuthBrowserPropertiesSet = (item) => {
     item.popUpOpener = popUpOpener;
-    item.popUpMessageParser = popUpMessageParser;
+    item.popUpMessageEventParser = popUpMessageEventParser;
     item.isRejectWhenPopUpClosed = true;
 };
 exports.OAuthBrowserPropertiesSet = OAuthBrowserPropertiesSet;
-function popUpOpener(item, window) {
-    let top = (window.screen.height - item.popUpHeight) / 2;
-    let left = (window.screen.width - item.popUpWidth) / 2;
-    return window.open(item.getPopUpUrl(), item.popUpTarget, `scrollbars=yes,width=${this.popUpWidth},height=${this.popUpHeight},top=${top},left=${left}`);
+function popUpOpener(popUp, window) {
+    let top = (window.screen.height - popUp.popUpHeight) / 2;
+    let left = (window.screen.width - popUp.popUpWidth) / 2;
+    return window.open(popUp.popUpUrl(), popUp.popUpTarget, `scrollbars=yes,width=${popUp.popUpWidth},height=${popUp.popUpHeight},top=${top},left=${left}`);
 }
-function popUpMessageParser(item, event) {
-    if (event.origin !== item.getOriginUrl()) {
-        return null;
-    }
-    let data = event.data;
-    if (!_.isObject(data)) {
-        return null;
-    }
-    if (!common_1.ObjectUtil.hasOwnProperty(data, 'oAuthCodeOrToken') && !common_1.ObjectUtil.hasOwnProperty(data, 'oAuthError')) {
-        return null;
-    }
-    return data;
+exports.popUpOpener = popUpOpener;
+function popUpMessageEventParser(event) {
+    return !_.isNil(event.data.oauthError) || !_.isNil(event.data.oauthCodeOrToken) ? event.data : null;
 }
+exports.popUpMessageEventParser = popUpMessageEventParser;

package/cjs/external/cordovaInAppBrowserPlugin.js

@@ -17,7 +17,7 @@ const common_1 = require("@ts-core/common");
 const OAuthCordovaInAppBrowserPluginPropertiesSet = (item, redirectUri, method) => {
     item.redirectUri = redirectUri;
     item.popUpOpener = popUpOpener;
-    item.popUpOpened.pipe((0, rxjs_1.takeUntil)(item.destroyed)).subscribe((popUp) => __awaiter(void 0, void 0, void 0, function* () {
+    item.opened.pipe((0, rxjs_1.takeUntil)(item.destroyed)).subscribe((popUp) => __awaiter(void 0, void 0, void 0, function* () {
         let popUpClosedHandler = () => {
             popUp.removeEventListener('exit', popUpClosedHandler);
             popUp.removeEventListener('loadstop', popUpLoadedHandler);
@@ -31,25 +31,25 @@ const OAuthCordovaInAppBrowserPluginPropertiesSet = (item, redirectUri, method)
             try {
                 data = yield method(item.state);
                 if (_.isEmpty(data)) {
-                    data = { oAuthError: OAuthBase_1.OAuthBase.ERROR_WINDOW_CLOSED, oAuthCodeOrToken: null };
+                    data = { oauthError: OAuthBase_1.OAuthBase.ERROR_WINDOW_CLOSED };
                 }
             }
             catch (error) {
-                data = { oAuthError: error.toString(), oAuthCodeOrToken: null };
+                data = { oauthError: error.toString() };
             }
-            item.parseResponse(data);
+            item.parse(data);
         });
         popUp.addEventListener('exit', popUpClosedHandler, false);
         popUp.addEventListener('loadstop', popUpLoadedHandler, false);
     }));
 };
 exports.OAuthCordovaInAppBrowserPluginPropertiesSet = OAuthCordovaInAppBrowserPluginPropertiesSet;
-function popUpOpener(item, window) {
-    let top = (window.screen.height - item.popUpHeight) / 2;
-    let left = (window.screen.width - item.popUpWidth) / 2;
+function popUpOpener(popUp, window) {
+    let top = (window.screen.height - popUp.popUpHeight) / 2;
+    let left = (window.screen.width - popUp.popUpWidth) / 2;
     let cordova = window['cordova'];
     if (_.isNil(cordova) || _.isNil(cordova.InAppBrowser)) {
         throw new common_1.ExtendedError(`Cordova InAppBrowser undefined, please check installed plugins`);
     }
-    return cordova.InAppBrowser.open(item.getPopUpUrl(), item.popUpTarget, `scrollbars=yes,width=${this.popUpWidth},height=${this.popUpHeight},top=${top},left=${left}`);
+    return cordova.InAppBrowser.open(popUp.popUpUrl(), popUp.popUpTarget, `scrollbars=yes,width=${this.popUpWidth},height=${this.popUpHeight},top=${top},left=${left}`);
 }

package/cjs/external/cordovaOAuthPlugin.js

@@ -6,22 +6,22 @@ const _ = require("lodash");
 const OAuthCordovaOAuthPluginPropertiesSet = (item, packageName) => {
     item.popUpTarget = 'oauth:cordova';
     item.popUpOpener = popUpOpener;
-    item.popUpMessageParser = popUpMessageParser;
+    item.popUpMessageEventParser = popUpMessageEventParser;
     item.redirectUri = `${packageName}://oauth_callback`;
     item.isRejectWhenPopUpClosed = false;
 };
 exports.OAuthCordovaOAuthPluginPropertiesSet = OAuthCordovaOAuthPluginPropertiesSet;
-function popUpOpener(item, window) {
-    let top = (window.screen.height - item.popUpHeight) / 2;
-    let left = (window.screen.width - item.popUpWidth) / 2;
-    let popUp = window.open(item.getPopUpUrl(), item.popUpTarget, `scrollbars=yes,width=${this.popUpWidth},height=${this.popUpHeight},top=${top},left=${left}`);
-    if (!_.isNil(popUp)) {
-        return popUp;
+function popUpOpener(popUp, window) {
+    let top = (window.screen.height - popUp.popUpHeight) / 2;
+    let left = (window.screen.width - popUp.popUpWidth) / 2;
+    let item = window.open(popUp.popUpUrl(), popUp.popUpTarget, `scrollbars=yes,width=${this.popUpWidth},height=${this.popUpHeight},top=${top},left=${left}`);
+    if (!_.isNil(item)) {
+        return item;
     }
     let fake = { close: () => { fake.closed = true; }, closed: false };
     return fake;
 }
-function popUpMessageParser(item, event) {
+function popUpMessageEventParser(event) {
     let data = event.data;
     let prefix = 'oauth::';
     return _.isString(data) && data.includes(prefix) ? OAuthParser_1.OAuthParser.parse(JSON.parse(data.substring(prefix.length)), '') : null;

package/cjs/go/GoAuth.d.ts

@@ -3,7 +3,7 @@ import { IOAuthDto, IOAuthToken, OAuthBase } from '../OAuthBase';
 import { ILogger } from '@ts-core/common';
 export declare class GoAuth<T extends GoUser = GoUser> extends OAuthBase<T> {
     constructor(logger: ILogger, applicationId: string, window?: Window);
-    getPopUpUrl(): string;
+    popUpUrl(): string;
     getProfile(token: string): Promise<T>;
     getTokenByCode(dto: IOAuthDto, secret: string): Promise<IOAuthToken>;
 }

package/cjs/go/GoAuth.js

@@ -15,10 +15,10 @@ const OAuthBase_1 = require("../OAuthBase");
 class GoAuth extends OAuthBase_1.OAuthBase {
     constructor(logger, applicationId, window) {
         super(logger, applicationId, window);
-        this.urlParams.set('scope', 'https://www.googleapis.com/auth/userinfo.profile https://www.googleapis.com/auth/userinfo.email');
+        this.params.set('scope', 'https://www.googleapis.com/auth/userinfo.profile https://www.googleapis.com/auth/userinfo.email');
     }
-    getPopUpUrl() {
-        return `https://accounts.google.com/o/oauth2/v2/auth?${this.getUrlParams().toString()}`;
+    popUpUrl() {
+        return `https://accounts.google.com/o/oauth2/v2/auth?${this.getParams().toString()}`;
     }
     getProfile(token) {
         return __awaiter(this, void 0, void 0, function* () {

package/cjs/keycloak/KeycloakAuth.d.ts

@@ -5,7 +5,7 @@ export declare class KeycloakAuth<T extends KeycloakUser = KeycloakUser> extends
     protected _settings: IKeycloakAuthSettings;
     constructor(logger: ILogger, settings: IKeycloakAuthSettings, window?: Window);
     protected getBaseUrl(): string;
-    getPopUpUrl(): string;
+    popUpUrl(): string;
     getProfile(token: string): Promise<T>;
     getTokenByCode(dto: IOAuthDto, secret: string): Promise<IOAuthToken>;
     destroy(): void;