@tryghost/zip 1.1.41 → 1.1.43

package/lib/extract.js

@@ -12,7 +12,15 @@ function throwOnSymlinks(entry) {
 
     if (symlink) {
         throw new errors.UnsupportedMediaTypeError({
-            message: 'Symlinks in ZIP-files are not allowed'
+            message: 'Symlinks are not allowed in the zip folder.'
+        });
+    }
+}
+
+function throwOnLargeFilenames(entry) {
+    if (Buffer.byteLength(entry.fileName, 'utf8') >= 254) {
+        throw new errors.UnsupportedMediaTypeError({
+            message: 'File names in the zip folder must be shorter than 254 characters.'
         });
     }
 }
@@ -36,14 +44,14 @@ module.exports = (zipToExtract, destination, options) => {
 
     opts.dir = destination;
 
-    if (opts.onEntry) {
-        opts.onEntry = (entry, zipfile) => {
-            throwOnSymlinks(entry);
-            options.onEntry(entry, zipfile);
-        };
-    } else {
-        opts.onEntry = throwOnSymlinks;
-    }
+    const originalOnEntry = opts.onEntry;
+    opts.onEntry = (entry, zipfile) => {
+        throwOnSymlinks(entry);
+        throwOnLargeFilenames(entry);
+        if (originalOnEntry) {
+            originalOnEntry(entry, zipfile);
+        }
+    };
 
     return extract(zipToExtract, opts).then(() => {
         return {path: destination};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tryghost/zip",
-  "version": "1.1.41",
+  "version": "1.1.43",
   "repository": "https://github.com/TryGhost/framework/tree/main/packages/zip",
   "author": "Ghost Foundation",
   "license": "MIT",
@@ -21,15 +21,15 @@
   "devDependencies": {
     "c8": "9.1.0",
     "folder-hash": "4.0.4",
-    "fs-extra": "11.1.1",
-    "mocha": "10.3.0",
+    "fs-extra": "11.2.0",
+    "mocha": "10.4.0",
     "should": "13.2.3",
-    "sinon": "17.0.1"
+    "sinon": "17.0.2"
   },
   "dependencies": {
-    "@tryghost/errors": "^1.3.1",
+    "@tryghost/errors": "^1.3.2",
     "archiver": "^5.0.0",
     "extract-zip": "^2.0.1"
   },
-  "gitHead": "46cfa9c0bc277226048af7c1b98c797bccc05db5"
+  "gitHead": "aa0d85a521ee8b5570ccba41d4aeb8942bdb1831"
 }