@tryghost/jest-snapshot 0.5.17 → 0.5.18

package/lib/SnapshotManager.js

@@ -7,26 +7,29 @@ const {makeMessageFromMatchMessage} = require('./utils');
 
 const DOT_EXTENSION = `.${EXTENSION}`;
 
+/**
+ * Determines whether to update all snapshots or only new ones
+ * @returns {string} e.g. 'all' or 'new'
+ */
+function willUpdate() {
+    const updateSnapshots = (
+        process.env.SNAPSHOT_UPDATE
+        || process.env.UPDATE_SNAPSHOT
+        || process.env.SNAPSHOTS_UPDATE
+        || process.env.UPDATE_SNAPSHOTS
+    );
+
+    return updateSnapshots ? 'all' : 'new';
+}
+
 class SnapshotManager {
     constructor() {
         this.registry = {};
         this.currentTest = {};
         this.defaultSnapshotRoot = '__snapshots__';
-    }
 
-    /**
-     * Determines whether to update all snapshots or only new ones
-     * @returns {string} e.g. 'all' or 'new'
-     */
-    _willUpdate() {
-        const updateSnapshots = (
-            process.env.SNAPSHOT_UPDATE
-            || process.env.UPDATE_SNAPSHOT
-            || process.env.SNAPSHOTS_UPDATE
-            || process.env.UPDATE_SNAPSHOTS
-        );
-
-        return updateSnapshots ? 'all' : 'new';
+        // Set willUpdate once, as it  can't change whilst we are running
+        this.willUpdate = willUpdate();
     }
 
     /**
@@ -79,12 +82,9 @@ class SnapshotManager {
         const {testPath, testTitle} = this.currentTest;
 
         const snapshotName = this._getNameForSnapshot(testPath, testTitle);
-        const willUpdate = this._willUpdate();
-
-        // Set full path
         const snapshotPath = this._resolveSnapshotFilePath(testPath);
 
-        return {snapshotPath, snapshotName, willUpdate};
+        return {snapshotPath, snapshotName};
     }
 
     /**
@@ -116,14 +116,13 @@ class SnapshotManager {
     /**
      * Gets a SnapshotState instance for the current test
      * @param {string} snapshotPath e.g. 'test/__snapshots__/my-fake.test.js.snap'
-     * @param {string} willUpdate e.g. 'new'
      * @returns {SnapshotState}
      */
-    getSnapshotState(snapshotPath, willUpdate) {
+    getSnapshotState(snapshotPath) {
         // Initialize the SnapshotState, it’s responsible for actually matching
         // actual snapshot with expected one and storing results
         return new SnapshotState(snapshotPath, {
-            updateSnapshot: willUpdate
+            updateSnapshot: this.willUpdate
         });
     }
 
@@ -182,9 +181,10 @@ class SnapshotManager {
      * @returns {Object} result of the match
      */
     match(received, properties = {}, hint) {
-        const {snapshotPath, snapshotName, willUpdate} = this._getConfig();
+        const {snapshotPath, snapshotName} = this._getConfig();
+
+        const snapshotState = this.getSnapshotState(snapshotPath);
 
-        const snapshotState = this.getSnapshotState(snapshotPath, willUpdate);
         const matcher = toMatchSnapshot.bind({
             snapshotState,
             currentTestName: snapshotName,

package/package.json

@@ -1,7 +1,11 @@
 {
   "name": "@tryghost/jest-snapshot",
-  "version": "0.5.17",
-  "repository": "https://github.com/TryGhost/framework/tree/main/packages/jest-snapshot",
+  "version": "0.5.18",
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/TryGhost/framework.git",
+    "directory": "packages/jest-snapshot"
+  },
   "author": "Ghost Foundation",
   "license": "MIT",
   "main": "index.js",
@@ -27,8 +31,8 @@
   "dependencies": {
     "@jest/expect": "^28.0.1",
     "@jest/expect-utils": "^28.0.1",
-    "@tryghost/errors": "^1.3.7",
+    "@tryghost/errors": "^1.3.8",
     "jest-snapshot": "^29.0.0"
   },
-  "gitHead": "b169bd1734b749c3abdaac134f030756b9a282bb"
+  "gitHead": "e395f1d79edee4aecc36e572bb402016a8ba9273"
 }