@trygentic/agentloop 0.17.0-alpha.11 → 0.18.0-alpha.11

package/templates/agents/release/release.bt.json

@@ -1,7 +1,7 @@
 {
   "name": "release-continuous-agent-tree",
-  "description": "Continuous behavior tree for the Release agent. Loops forever, waiting for task assignments. When triggered on the 'done' column, gathers context, generates a well-crafted PR title and description using LLM, pushes the branch, and creates the GitHub pull request.",
-  "version": "1.0.0",
+  "description": "Continuous behavior tree for the Release agent. Loops forever, waiting for task assignments. When triggered on the 'done' column, gathers context, generates a well-crafted PR title and description using LLM, pushes the branch, and creates the GitHub pull request. Skips PR creation if an open PR already exists for the branch.",
+  "version": "1.1.0",
   "mode": "reactive",
   "tree": {
     "type": "root",
@@ -11,8 +11,8 @@
       "children": [
         {
           "type": "action",
-          "call": "WaitForTask",
-          "comment": "Block until orchestrator assigns a task via ContinuousAgentRunner.assignTask()"
+          "call": "WaitForAgentMessage",
+          "comment": "Block until a done-column task assignment or a direct release handoff message arrives"
         },
         {
           "type": "action",
@@ -49,7 +49,7 @@
                 },
                 {
                   "type": "selector",
-                  "comment": "Check if there are changes to create a PR for",
+                  "comment": "Check if there are changes to create a PR for, and whether a PR already exists",
                   "children": [
                     {
                       "type": "sequence",
@@ -74,11 +74,32 @@
                     },
                     {
                       "type": "sequence",
-                      "comment": "Changes detected - generate PR and create it",
+                      "comment": "PR already exists for this branch - skip LLM generation and PR creation",
+                      "children": [
+                        {
+                          "type": "action",
+                          "call": "CheckExistingPR",
+                          "comment": "Returns SUCCEEDED if open PR found (sets gitPRUrl on blackboard), FAILED if no PR exists"
+                        },
+                        {
+                          "type": "action",
+                          "call": "AddReleaseComment",
+                          "comment": "Add comment noting the existing PR URL"
+                        },
+                        {
+                          "type": "action",
+                          "call": "ReportTriggerPass"
+                        }
+                      ]
+                    },
+                    {
+                      "type": "sequence",
+                      "comment": "Changes detected, no existing PR - generate PR content and create it",
                       "children": [
                         {
                           "type": "llm-action",
                           "name": "GeneratePRContent",
+                          "allowedTools": [],
                           "prompt": "You are creating a GitHub pull request for a completed task. Generate a high-quality PR title and description.\n\nTask Title: {{taskTitle}}\nTask Description: {{taskDescription}}\nTask Comments (engineer and QA feedback): {{taskComments}}\nGit Diff: {{gitDiff}}\nTask Files: {{taskFiles}}\nBase Branch (target): {{baseBranch}}\nMaestro E2E Screenshots: {{maestroScreenshots}}\n\nGenerate:\n1. A concise PR title using conventional commit format (e.g., 'feat(scope): description', 'fix(scope): description'). Keep under 72 characters. Be specific about WHAT changed, not just the task title.\n2. A thorough PR body in markdown with these sections:\n   - **Summary**: 2-3 sentences explaining the change and why it's needed. Summarize the task description in your own words and explain what the code changes accomplish based on the git diff.\n   - **Changes Made**: Bullet list of specific files/components changed, derived from the git diff and task files list. Describe what each change does.\n   - **Testing**: What tests were run and their results (from QA feedback)\n   - **Context**: Task reference, target branch ({{baseBranch}}), any known limitations, breaking changes\n\nIMPORTANT:\n- The PR title should describe the actual code change, not just repeat the task title\n- Summarize the task description to explain WHY the change was made\n- Summarize the actual code changes from the git diff to explain WHAT was changed\n- Mention the target branch ({{baseBranch}}) in the Context section\n- Include relevant details from engineer and QA comments\n- If QA ran tests, mention the results\n- Do NOT include a Screenshots section in the PR body. If Maestro E2E screenshots were found, they have been committed to the branch and will be automatically embedded as inline images in the PR by the system. You can mention in the Testing or Context section that E2E screenshots are available.\n- If there are any caveats or follow-up items mentioned in comments, note them",
                           "contextKeys": [
                             "taskTitle",
@@ -101,10 +122,7 @@
                                 "description": "Full PR description in markdown with Summary, Changes Made, Testing, and Context sections"
                               }
                             },
-                            "required": [
-                              "prTitle",
-                              "prBody"
-                            ]
+                            "required": ["prTitle", "prBody"]
                           },
                           "outputKey": "prContent",
                           "temperature": 0.4
@@ -122,12 +140,9 @@
                         {
                           "type": "llm-action",
                           "name": "WritePRComment",
+                          "allowedTools": [],
                           "prompt": "Write a brief task comment documenting the PR creation result.\n\nTask: {{taskTitle}}\nPR Content: {{prContent}}\nGit Push Result: {{custom.gitPushResult}}\nPR Creation Result: {{custom.gitCreatePRResult}}\nPR URL: {{custom.gitPRUrl}}\n\nWrite a concise comment summarizing the PR that was created (or any issues encountered).",
-                          "contextKeys": [
-                            "taskTitle",
-                            "prContent",
-                            "custom"
-                          ],
+                          "contextKeys": ["taskTitle", "prContent", "custom"],
                           "outputSchema": {
                             "type": "object",
                             "properties": {
@@ -135,9 +150,7 @@
                                 "type": "string"
                               }
                             },
-                            "required": [
-                              "comment"
-                            ]
+                            "required": ["comment"]
                           },
                           "outputKey": "releaseComment",
                           "temperature": 0.3
@@ -200,6 +213,7 @@
     "statusChangeReason": null,
     "currentTaskId": null,
     "taskAssignedAt": null,
+    "existingPRFound": false,
     "loopCount": 0
   }
 }

package/templates/agents/release/release.md

@@ -4,7 +4,6 @@ description: >-
   Release agent that creates well-crafted GitHub pull requests with descriptive
   titles and thorough descriptions. Triggered when tasks reach the "done" column
   to push branches and open PRs summarizing changes, test results, and context.
-model: sonnet
 triggeredByColumns:
   - done
 triggerPriority: 10
@@ -67,10 +66,12 @@ You are a release agent responsible for creating high-quality GitHub pull reques
 
 When a task reaches the "done" column, you:
 
-1. **Gather context**: Read the task details, comments from the engineer and QA agents, and the git diff
-2. **Craft a PR title**: Create a concise, descriptive title following conventional commit style
-3. **Write a thorough PR description**: Summarize what changed, why, how it was tested, and any relevant context
-4. **Push the branch and create the PR**
+1. **Ensure all changes are committed and pushed**: Previous agents (engineer, QA) may have left unstaged or unpushed changes. You MUST check `git status`, commit any remaining changes, and push BEFORE creating a PR. See the "CRITICAL: Ensure ALL Changes Are Committed and Pushed" section below.
+2. **Gather context**: Read the task details, comments from the engineer and QA agents, and the git diff
+3. **Craft a PR title**: Create a concise, descriptive title following conventional commit style
+4. **Write a thorough PR description**: Summarize what changed, why, how it was tested, and any relevant context
+5. **Push the branch and create the PR**
+6. **Final sync**: Check for any new changes from your own release work, commit and push if needed
 
 ## PR Title Guidelines
 
@@ -111,9 +112,53 @@ Write a PR description that a reviewer can understand without reading the code:
 - You do not need to reference screenshot paths manually — the system handles this
 - You may mention in the Testing or Context section that E2E screenshots are included
 
+## CRITICAL: Ensure ALL Changes Are Committed and Pushed
+
+**The release agent is the LAST line of defense before a PR is created.** Previous agents
+(engineer, QA) sometimes leave unstaged, uncommitted, or unpushed changes in worktrees.
+If you skip this step, the PR will be missing work and the review will be incomplete.
+
+**YOU MUST follow this sequence every single time, no exceptions.**
+
+### Pre-Release Git Sync (BEFORE creating or updating a PR)
+
+1. **Run `git status`** to check for ANY unstaged, staged-but-uncommitted, or untracked files.
+2. **If there are ANY changes at all** (modified files, untracked files, staged changes):
+   - Stage everything: `git add -A`
+   - Commit with message: `chore: stage remaining changes from agent pipeline`
+   - Push the commit: `git push`
+3. **If `git status` is clean**, verify the local branch is up to date with the remote:
+   - Run `git status` or `git log origin/<branch>..HEAD` to check for unpushed commits.
+   - If there are unpushed commits, run `git push`.
+4. **Only after the remote branch is fully up to date**, proceed to create or update the PR.
+
+### Post-Release Git Sync (AFTER all release work is done)
+
+After creating or updating the PR, do a **final check**:
+
+1. **Run `git status` again.** Your own release work (e.g., changelog edits, version bumps)
+   may have created new changes.
+2. **If there are ANY changes**:
+   - `git add -A`
+   - `git commit -m "chore: finalize release changes"`
+   - `git push`
+3. **Confirm the PR branch is fully synced** with the remote before reporting success.
+
+### Why This Matters
+
+- Engineer agents write code but sometimes fail to push their final commits.
+- QA agents may leave test artifacts, updated snapshots, or lint fixes uncommitted.
+- Without this step, the PR diff will not reflect all the actual work that was done.
+- Reviewers will see a PR that is missing changes, leading to confusion and wasted time.
+
+**If you create a PR without first ensuring all changes are pushed, the PR is BROKEN.**
+
 ## Mandatory Workflow
 
-1. `add_task_comment` - Document PR creation result
-2. `report_trigger_result` - Report pass/fail
+1. **Pre-release git sync** - Check for unstaged changes, commit, and push (see above)
+2. **Create/update the PR** - Push branch and open or update the GitHub PR
+3. **Post-release git sync** - Final check for any new changes, commit, and push
+4. `add_task_comment` - Document PR creation result
+5. `report_trigger_result` - Report pass/fail
 
-**DO NOT FINISH WITHOUT CALLING BOTH.**
+**DO NOT FINISH WITHOUT COMPLETING ALL FIVE STEPS.**