@trustify-da/trustify-da-javascript-client 0.3.0-ea.61444d4 → 0.3.0-ea.62b88e5

package/dist/src/remediate.d.ts

@@ -1,3 +1,14 @@
+/**
+ * Resolves a target path to the supported manifest files it contains: the single file
+ * if `targetPath` is a supported manifest, or every supported manifest discovered
+ * recursively if it's a directory. This is the single source of truth for what
+ * `runRemediation` will scan, so callers (e.g. the CLI) can reuse it to tell
+ * "no manifests here" apart from "manifests, but nothing to fix".
+ * @param {string} targetPath - path to a manifest file or directory
+ * @returns {string[]} absolute paths to supported manifests (empty for an empty directory)
+ * @throws if the path does not exist, or is a file of an unsupported manifest type
+ */
+export function findManifests(targetPath: string): string[];
 /**
  * Orchestrates the full remediation pipeline for a single manifest or directory:
  * discover manifests → scan via DA backend → extract remediations → apply or preview.
@@ -7,15 +18,90 @@
  * @param {boolean} [options.dryRun=false] - preview changes without modifying files (applies by default)
  * @param {string} [options.providers] - comma-separated provider list
  * @param {string} [options.sources] - comma-separated source list
- * @param {'dependency'|'bundle'} [options.groupBy='dependency'] - report grouping strategy
- * @returns {Promise<{exitCode: number, output: string}>}
+ * @param {string} [options.backendUrl] - Trustify DA backend URL
+ * @param {boolean} [options.perDependencyChanges=false] - when true, each remediation is populated with
+ *   a `changes` array describing the isolated, single-dependency edit (see {@link DependencyFix}). This lets
+ *   callers create one commit/PR per dependency without attributing diff hunks themselves.
+ * @returns {Promise<{exitCode: number, remediations: AppliedRemediation[], manifests: string[], appliedFiles: string[]}>}
+ *   exitCode is 2 for a dry-run that found remediations (nothing written), 0 otherwise. `remediations`
+ *   is the structured, per-manifest list of applicable updates — each entry carries the originating
+ *   manifest path(s) in `files` so callers can group and create per-dependency changes. `appliedFiles`
+ *   lists only the manifests actually written to disk (empty on a dry-run), so callers can report a
+ *   truthful "updated N files" count without conflating "had remediations" with "was written".
  */
 export function runRemediation(targetPath: string, options?: {
     dryRun?: boolean | undefined;
     providers?: string | undefined;
     sources?: string | undefined;
-    groupBy?: "dependency" | "bundle" | undefined;
+    backendUrl?: string | undefined;
+    perDependencyChanges?: boolean | undefined;
 }): Promise<{
     exitCode: number;
-    output: string;
+    remediations: AppliedRemediation[];
+    manifests: string[];
+    appliedFiles: string[];
 }>;
+/**
+ * A single version change requested from an updater: bump `groupId:artifactId` to `newVersion`.
+ * The input side of every updater; each updater's output side (its `applied` entries) is its own
+ * type — see {@link AppliedChange}.
+ */
+export type VersionChangeRequest = {
+    groupId: string;
+    artifactId: string;
+    newVersion: string;
+};
+/**
+ * One entry from an updater's `applied` list, describing where and how a version was changed.
+ * Owned by the updater layer: the union of each updater's applied-entry shape. `changeKey`
+ * (per {@link ManifestType}) turns one of these into a stable edit-site identifier.
+ */
+export type AppliedChange = import("./updaters/maven_updater.js").MavenAppliedChange | import("./updaters/toml_updater.js").TomlAppliedChange;
+/**
+ * The result of running an updater over a manifest's raw content.
+ */
+export type UpdaterResult = {
+    content: string;
+    applied: AppliedChange[];
+    skipped: Array<{
+        groupId: string;
+        artifactId: string;
+        newVersion: string;
+        reason: string;
+    }>;
+};
+/**
+ * A supported manifest type and the operations that act on it.
+ * `changeKey` builds a stable edit-site key from a single `applied` entry, so callers can detect
+ * inseparable remediations (same key => same commit/PR).
+ */
+export type ManifestType = {
+    test: (basename: string) => boolean;
+    updater: (content: string, versionChanges: VersionChangeRequest[]) => UpdaterResult;
+    label: ("maven" | "toml");
+    changeKey: (manifestPath: string, applied: AppliedChange) => string;
+};
+/**
+ * An isolated, single-dependency edit to one manifest file.
+ * - `after` is the *original* manifest content with only this dependency's fix applied, so a caller
+ *   can create an isolated commit by writing `after` to `path` on a branch cut from the base.
+ * - `changeKey` is a stable identifier for the underlying edit site. Two remediations that share a
+ *   `changeKey` are inseparable (e.g. two Maven deps whose versions resolve to the same `${property}`,
+ *   or two Gradle libraries sharing one `version.ref`) and MUST land in the same commit/PR — the
+ *   caller should union their CVEs/advisories.
+ */
+export type DependencyFix = {
+    path: string;
+    after: string;
+    changeKey: string;
+};
+/**
+ * A remediation grounded in the scanned workspace: the canonical
+ * {@link import ('./remediation.js').Remediation} base as produced by `extractRemediations`, enriched
+ * by `runRemediation` with the originating manifest path(s) in `files` (always present) and,
+ * optionally, the isolated per-dependency edits in `changes`.
+ */
+export type AppliedRemediation = import("./remediation.js").Remediation & {
+    files: string[];
+    changes?: DependencyFix[];
+};

package/dist/src/remediate.js

@@ -3,34 +3,113 @@ import path from 'node:path';
 import analysis from './analysis.js';
 import { availableProviders, match } from './provider.js';
 import { extractRemediations } from './remediation.js';
-import { generateReport } from './remediation_report.js';
-import { updateMavenVersions } from './updaters/maven_updater.js';
-import { updateTomlVersions } from './updaters/toml_updater.js';
+import { mavenChangeKey, updateMavenVersions } from './updaters/maven_updater.js';
+import { tomlChangeKey, updateTomlVersions } from './updaters/toml_updater.js';
 import { selectTrustifyDABackend } from './index.js';
 // Mirrors DEFAULT_WORKSPACE_DISCOVERY_IGNORE in workspace.js
 const SKIP_DIRS = new Set(['node_modules', '.git']);
+/**
+ * A single version change requested from an updater: bump `groupId:artifactId` to `newVersion`.
+ * The input side of every updater; each updater's output side (its `applied` entries) is its own
+ * type — see {@link AppliedChange}.
+ * @typedef {{groupId: string, artifactId: string, newVersion: string}} VersionChangeRequest
+ */
+/**
+ * One entry from an updater's `applied` list, describing where and how a version was changed.
+ * Owned by the updater layer: the union of each updater's applied-entry shape. `changeKey`
+ * (per {@link ManifestType}) turns one of these into a stable edit-site identifier.
+ * @typedef {import('./updaters/maven_updater.js').MavenAppliedChange
+ *   | import('./updaters/toml_updater.js').TomlAppliedChange} AppliedChange
+ */
+/**
+ * The result of running an updater over a manifest's raw content.
+ * @typedef {{content: string, applied: AppliedChange[], skipped: Array<{groupId: string, artifactId: string, newVersion: string, reason: string}>}} UpdaterResult
+ */
+/**
+ * A supported manifest type and the operations that act on it.
+ * `changeKey` builds a stable edit-site key from a single `applied` entry, so callers can detect
+ * inseparable remediations (same key => same commit/PR).
+ * @typedef {{
+ *   test: (basename: string) => boolean,
+ *   updater: (content: string, versionChanges: VersionChangeRequest[]) => UpdaterResult,
+ *   label: ('maven'|'toml'),
+ *   changeKey: (manifestPath: string, applied: AppliedChange) => string
+ * }} ManifestType
+ */
+/**
+ * An isolated, single-dependency edit to one manifest file.
+ * - `after` is the *original* manifest content with only this dependency's fix applied, so a caller
+ *   can create an isolated commit by writing `after` to `path` on a branch cut from the base.
+ * - `changeKey` is a stable identifier for the underlying edit site. Two remediations that share a
+ *   `changeKey` are inseparable (e.g. two Maven deps whose versions resolve to the same `${property}`,
+ *   or two Gradle libraries sharing one `version.ref`) and MUST land in the same commit/PR — the
+ *   caller should union their CVEs/advisories.
+ * @typedef {{ path: string, after: string, changeKey: string }} DependencyFix
+ */
+/**
+ * A remediation grounded in the scanned workspace: the canonical
+ * {@link import('./remediation.js').Remediation} base as produced by `extractRemediations`, enriched
+ * by `runRemediation` with the originating manifest path(s) in `files` (always present) and,
+ * optionally, the isolated per-dependency edits in `changes`.
+ * @typedef {import('./remediation.js').Remediation & {
+ *   files: string[],
+ *   changes?: DependencyFix[]
+ * }} AppliedRemediation
+ */
+/** @type {ManifestType[]} */
 const MANIFEST_TYPES = [
     {
         test: (basename) => basename === 'pom.xml',
         updater: updateMavenVersions,
         label: 'maven',
+        changeKey: mavenChangeKey
     },
     {
         test: (basename) => basename.endsWith('.versions.toml') || basename === 'libs.versions.toml',
         updater: updateTomlVersions,
         label: 'toml',
+        changeKey: tomlChangeKey
     },
 ];
 /**
- * Discovers supported manifest files recursively within a directory.
- * @param {string} dirPath - absolute path to the directory
- * @returns {string[]} array of absolute paths to supported manifest files
+ * Returns the manifest type descriptor for a given filename, or null if unsupported.
+ * @param {string} basename - the file name to check
+ * @returns {ManifestType|null}
+ */
+function getManifestType(basename) {
+    return MANIFEST_TYPES.find(t => t.test(basename)) || null;
+}
+/**
+ * Resolves a target path to the supported manifest files it contains: the single file
+ * if `targetPath` is a supported manifest, or every supported manifest discovered
+ * recursively if it's a directory. This is the single source of truth for what
+ * `runRemediation` will scan, so callers (e.g. the CLI) can reuse it to tell
+ * "no manifests here" apart from "manifests, but nothing to fix".
+ * @param {string} targetPath - path to a manifest file or directory
+ * @returns {string[]} absolute paths to supported manifests (empty for an empty directory)
+ * @throws if the path does not exist, or is a file of an unsupported manifest type
  */
-function discoverManifests(dirPath) {
+export function findManifests(targetPath) {
+    const resolvedPath = path.resolve(targetPath);
+    let stat;
+    try {
+        stat = fs.statSync(resolvedPath);
+    }
+    catch {
+        throw new Error(`Path not found: ${resolvedPath}`);
+    }
+    // A single file must itself be a supported manifest.
+    if (!stat.isDirectory()) {
+        const basename = path.basename(resolvedPath);
+        if (!getManifestType(basename)) {
+            throw new Error(`Unsupported manifest type: ${basename}`);
+        }
+        return [resolvedPath];
+    }
+    // A directory yields every supported manifest found recursively beneath it.
     const manifests = [];
     function walk(dir) {
-        const entries = fs.readdirSync(dir, { withFileTypes: true });
-        for (const entry of entries) {
+        for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
             if (SKIP_DIRS.has(entry.name)) {
                 continue;
             }
@@ -43,17 +122,9 @@ function discoverManifests(dirPath) {
             }
         }
     }
-    walk(dirPath);
+    walk(resolvedPath);
     return manifests;
 }
-/**
- * Returns the manifest type descriptor for a given filename, or null if unsupported.
- * @param {string} basename - the file name to check
- * @returns {{test: function, updater: function, label: string}|null}
- */
-function getManifestType(basename) {
-    return MANIFEST_TYPES.find(t => t.test(basename)) || null;
-}
 /**
  * Orchestrates the full remediation pipeline for a single manifest or directory:
  * discover manifests → scan via DA backend → extract remediations → apply or preview.
@@ -63,38 +134,31 @@ function getManifestType(basename) {
  * @param {boolean} [options.dryRun=false] - preview changes without modifying files (applies by default)
  * @param {string} [options.providers] - comma-separated provider list
  * @param {string} [options.sources] - comma-separated source list
- * @param {'dependency'|'bundle'} [options.groupBy='dependency'] - report grouping strategy
- * @returns {Promise<{exitCode: number, output: string}>}
+ * @param {string} [options.backendUrl] - Trustify DA backend URL
+ * @param {boolean} [options.perDependencyChanges=false] - when true, each remediation is populated with
+ *   a `changes` array describing the isolated, single-dependency edit (see {@link DependencyFix}). This lets
+ *   callers create one commit/PR per dependency without attributing diff hunks themselves.
+ * @returns {Promise<{exitCode: number, remediations: AppliedRemediation[], manifests: string[], appliedFiles: string[]}>}
+ *   exitCode is 2 for a dry-run that found remediations (nothing written), 0 otherwise. `remediations`
+ *   is the structured, per-manifest list of applicable updates — each entry carries the originating
+ *   manifest path(s) in `files` so callers can group and create per-dependency changes. `appliedFiles`
+ *   lists only the manifests actually written to disk (empty on a dry-run), so callers can report a
+ *   truthful "updated N files" count without conflating "had remediations" with "was written".
  */
 export async function runRemediation(targetPath, options = {}) {
-    const { dryRun = false, providers, sources, groupBy = 'dependency' } = options;
-    const resolvedPath = path.resolve(targetPath);
-    let manifestPaths;
-    let stat;
-    try {
-        stat = fs.statSync(resolvedPath);
-    }
-    catch {
-        throw new Error(`Path not found: ${resolvedPath}`);
-    }
-    if (stat.isDirectory()) {
-        manifestPaths = discoverManifests(resolvedPath);
-        if (manifestPaths.length === 0) {
-            return { exitCode: 0, output: 'No supported manifest files found.' };
-        }
-    }
-    else {
-        const basename = path.basename(resolvedPath);
-        if (!getManifestType(basename)) {
-            throw new Error(`Unsupported manifest type: ${basename}`);
-        }
-        manifestPaths = [resolvedPath];
+    const { dryRun = false, providers, sources, perDependencyChanges = false, backendUrl } = options;
+    const manifestPaths = findManifests(targetPath);
+    if (manifestPaths.length === 0) {
+        return { exitCode: 0, remediations: [], manifests: manifestPaths, appliedFiles: [] };
     }
     const opts = {};
-    if (providers) {
+    if (backendUrl !== undefined) {
+        opts.TRUSTIFY_DA_BACKEND_URL = backendUrl;
+    }
+    if (providers !== undefined) {
         opts.TRUSTIFY_DA_PROVIDERS = providers;
     }
-    if (sources) {
+    if (sources !== undefined) {
         opts.TRUSTIFY_DA_SOURCES = sources;
     }
     const url = selectTrustifyDABackend(opts);
@@ -120,15 +184,52 @@ export async function runRemediation(targetPath, options = {}) {
         if (remediations.length === 0) {
             continue;
         }
-        allRemediations.push(...remediations);
+        // Tag each remediation with the manifest it came from so callers can group
+        // changes per dependency across a multi-manifest workspace.
+        for (const remediation of /** @type {AppliedRemediation[]} */ (remediations)) {
+            remediation.files = [manifestPath];
+        }
+        // Read the pristine manifest once. Both the atomic apply and the per-dependency
+        // change computation must diff against the *original* content.
+        const needsContent = perDependencyChanges || !dryRun;
+        const originalContent = needsContent ? fs.readFileSync(manifestPath, 'utf-8') : null;
+        if (perDependencyChanges) {
+            // With per-dependency changes every returned remediation must carry an isolated
+            // edit. A dependency the updater cannot locate in this manifest — e.g. a vulnerable
+            // *transitive* dependency surfaced by analysis but not declared here — yields no
+            // applied change, so it is dropped rather than returned with an absent `changes`
+            // array (which would crash callers that iterate `remediation.changes` to build PRs).
+            const applicable = [];
+            for (const remediation of remediations) {
+                const isolated = manifestType.updater(originalContent, [{
+                        groupId: remediation.groupId,
+                        artifactId: remediation.artifactId,
+                        newVersion: remediation.fixedInVersion,
+                    }]);
+                if (isolated.applied.length === 0) {
+                    continue;
+                }
+                remediation.changes = [{
+                        path: manifestPath,
+                        after: isolated.content,
+                        changeKey: manifestType.changeKey(manifestPath, isolated.applied[0])
+                    }];
+                applicable.push(remediation);
+            }
+            allRemediations.push(...applicable);
+        }
+        else {
+            allRemediations.push(...remediations);
+        }
         if (!dryRun) {
-            const content = fs.readFileSync(manifestPath, 'utf-8');
-            const versionChanges = remediations.map(r => ({
+            // Disk receives the union of every dependency's fix. When
+            // perDependencyChanges is also set, each remediation's `changes[].after`
+            // deliberately stays isolated (single-dep) for branch-per-dep workflows.
+            const result = manifestType.updater(originalContent, remediations.map(r => ({
                 groupId: r.groupId,
                 artifactId: r.artifactId,
                 newVersion: r.fixedInVersion,
-            }));
-            const result = manifestType.updater(content, versionChanges);
+            })));
             if (result.applied.length > 0) {
                 fs.writeFileSync(manifestPath, result.content, 'utf-8');
                 appliedFiles.push(manifestPath);
@@ -136,14 +237,8 @@ export async function runRemediation(targetPath, options = {}) {
         }
     }
     if (allRemediations.length === 0) {
-        return { exitCode: 0, output: 'No remediations found.' };
-    }
-    const report = generateReport(allRemediations, { groupBy });
-    if (dryRun) {
-        return { exitCode: 2, output: report };
+        return { exitCode: 0, remediations: [], manifests: manifestPaths, appliedFiles };
     }
-    const summary = appliedFiles.length > 0
-        ? `Updated ${appliedFiles.length} file(s):\n${appliedFiles.map(f => `  ${f}`).join('\n')}\n\n${report}`
-        : report;
-    return { exitCode: 0, output: summary };
+    // Dry-run signals "changes available but not written" via exit code 2.
+    return { exitCode: dryRun ? 2 : 0, remediations: allRemediations, manifests: manifestPaths, appliedFiles };
 }

package/dist/src/remediation.d.ts

@@ -6,52 +6,76 @@
  * version selection strategy to resolve conflicts. Dependencies with no remediation
  * data are skipped.
  *
- * @param {object} analysisReport - raw DA AnalysisReport JSON response
+ * @param {import('@trustify-da/trustify-da-api-model/model/v5/AnalysisReport.ts').AnalysisReport} analysisReport - raw DA AnalysisReport JSON response
  * @param {object} [options] - extraction options
  * @param {string[]} [options.providerPriority] - provider names in descending priority order.
  *   The first entry has the highest priority. Providers not listed share the lowest priority.
  *   When omitted or empty, all providers are treated equally and the highest fix version wins.
- * @param {object} [options.versionStrategy] - version selection strategy with selectVersion
+ * @param {VersionStrategy} [options.versionStrategy] - version selection strategy with selectVersion
  *   and resolveConflict methods. Defaults to closestCoverageStrategy.
- * @returns {Array<{purl: string, groupId: string, artifactId: string, currentVersion: string, fixedInVersion: string, fixedInPurl: string, provider: string, source: string, advisories: Array<{id: string, url: string}>, severity: string, cves: string[]}>}
+ * @returns {Remediation[]} `vulnerabilities` is the sole source of vulnerability data — each entry
+ *   holds one CVE with its own severity and advisories. Use {@link maxSeverity} to derive a
+ *   dependency-level severity.
  */
-export function extractRemediations(analysisReport: object, options?: {
+export function extractRemediations(analysisReport: import("@trustify-da/trustify-da-api-model/model/v5/AnalysisReport.ts").AnalysisReport, options?: {
     providerPriority?: string[] | undefined;
-    versionStrategy?: object | undefined;
-}): Array<{
-    purl: string;
-    groupId: string;
-    artifactId: string;
-    currentVersion: string;
-    fixedInVersion: string;
-    fixedInPurl: string;
-    provider: string;
-    source: string;
-    advisories: Array<{
-        id: string;
-        url: string;
-    }>;
+    versionStrategy?: VersionStrategy | undefined;
+}): Remediation[];
+/**
+ * Derives a dependency-level severity as the max across a list of vulnerabilities.
+ * Returns 'UNKNOWN' for an empty or missing list.
+ * @param {Array<{severity: string}>} [vulnerabilities]
+ * @returns {string}
+ */
+export function maxSeverity(vulnerabilities?: Array<{
     severity: string;
-    cves: string[];
-}>;
+}>): string;
+/**
+ * @typedef {{selectVersion: (fixedInVersions: string[], currentVersion: string) => string, resolveConflict: (existing: ConflictCandidate, candidate: ConflictCandidate) => 'existing'|'candidate'}} VersionStrategy
+ */
 /**
  * Version selection strategy that prefers the closest compatible version
  * within the same major version stream. Falls back to the lowest cross-major
  * version when no same-major option exists.
- * @type {{selectVersion: function(string[], string): string, resolveConflict: function(object, object): string}}
+ * @type {VersionStrategy}
  */
-export const closestCoverageStrategy: {
-    selectVersion: (arg0: string[], arg1: string) => string;
-    resolveConflict: (arg0: object, arg1: object) => string;
-};
+export const closestCoverageStrategy: VersionStrategy;
 /**
  * Version selection strategy that always picks the highest version regardless
  * of major version distance. Guarantees maximum CVE coverage but may produce
  * large version jumps. This is the original behavior before pluggable strategies.
- * @type {{selectVersion: function(string[], string): string, resolveConflict: function(object, object): string}}
+ * @type {VersionStrategy}
  */
-export const highestStrategy: {
-    selectVersion: (arg0: string[], arg1: string) => string;
-    resolveConflict: (arg0: object, arg1: object) => string;
-};
+export const highestStrategy: VersionStrategy;
 export const SEVERITY_ORDER: string[];
+/**
+ * A single per-CVE vulnerability carried by a remediation: one CVE with its own severity and the
+ * advisories attributed to it.
+ */
+export type Vulnerability = {
+    id: string;
+    severity: string;
+    advisories: Array<{
+        id: string;
+        url: string;
+    }>;
+};
+/**
+ * A single applicable remediation as produced by {@link extractRemediations}: a dependency, the
+ * version that fixes it, and the per-CVE `vulnerabilities` it resolves.
+ */
+export type Remediation = {
+    purl: string;
+    groupId: string;
+    artifactId: string;
+    currentVersion: string;
+    fixedInVersion: string;
+    fixedInPurl: string;
+    provider: string;
+    source: string;
+    vulnerabilities: Vulnerability[];
+};
+export type VersionStrategy = {
+    selectVersion: (fixedInVersions: string[], currentVersion: string) => string;
+    resolveConflict: (existing: ConflictCandidate, candidate: ConflictCandidate) => "existing" | "candidate";
+};