@truenas/api-client 2.0.0 → 2.0.1

package/dist/index.cjs

@@ -3306,7 +3306,7 @@ var VersionDiscovery = class {
       operators.map((versionStrings) => this.selectVersion(hostname, versionStrings)),
       operators.catchError((error) => {
         this.versionCache.delete(hostname);
-        this.logger.error("Version discovery failed", { hostname, error });
+        this.logger.warn("Version discovery failed", { hostname, error });
         return rxjs.throwError(() => this.classify(error, hostname));
       }),
       operators.shareReplay(1)
@@ -3377,7 +3377,7 @@ var VersionDiscovery = class {
     });
     const parsedVersions = versionStrings.map(parseApiVersion).filter((v) => v !== null);
     if (parsedVersions.length === 0) {
-      this.logger.error("No valid versions in response", {
+      this.logger.warn("No valid versions in response", {
         hostname,
         versionStrings
       });
@@ -3479,29 +3479,34 @@ async function createTrueNasClient(opts) {
       `Cannot create client for system ${uuid}: hostnames array is empty`
     );
   }
-  const primaryHostname = hostnames[0];
   const versionDiscovery = new VersionDiscovery(logger);
   logger.info("Creating versioned API client", {
     uuid: uuid.slice(0, 8),
-    hostname: primaryHostname,
+    hostnames: hostnames.join(", "),
     systemName
   });
   let version;
   try {
-    version = await rxjs.firstValueFrom(
-      versionDiscovery.discoverVersion(primaryHostname)
+    const winner = await discoverVersionFromAnyHostname(
+      hostnames,
+      versionDiscovery
     );
+    version = winner.version;
     logger.info("API version discovered, instantiating client", {
       uuid: uuid.slice(0, 8),
+      // Which hostname answered is log context only. The client is built with
+      // the full hostname list regardless — the websocket connection races all
+      // of them anyway.
+      hostname: winner.hostname,
       version: version.version,
       websocketPath: version.websocketPath
     });
   } catch (error) {
     const errorMessage = errorMessageOrDefault(error, "Unknown error");
     if (!(error instanceof VersionDiscoveryNetworkError)) {
-      logger.error("Version discovery failed", {
+      logger.error("Version discovery failed on every hostname", {
         uuid: uuid.slice(0, 8),
-        hostname: primaryHostname,
+        hostnames: hostnames.join(", "),
         error: errorMessage,
         errorType: error instanceof Error ? error.constructor.name : typeof error
       });
@@ -3512,7 +3517,7 @@ async function createTrueNasClient(opts) {
     if (!fallbackVersion) {
       logger.error("Invalid fallback version configuration", {
         uuid: uuid.slice(0, 8),
-        hostname: primaryHostname,
+        hostnames: hostnames.join(", "),
         fallbackVersion: fallbackVersionString
       });
       throw error;
@@ -3521,7 +3526,7 @@ async function createTrueNasClient(opts) {
       "Version discovery failed with a network error (possible CORS or network issue), falling back to assumed version",
       {
         uuid: uuid.slice(0, 8),
-        hostname: primaryHostname,
+        hostnames: hostnames.join(", "),
         fallbackVersion: fallbackVersionString,
         originalError: errorMessage,
         warning: "A network error has multiple causes (CORS, network down, DNS failure). The connection may still fail during the WebSocket handshake."
@@ -3531,6 +3536,27 @@ async function createTrueNasClient(opts) {
   }
   return instantiateClientForVersion(version, opts, logger);
 }
+async function discoverVersionFromAnyHostname(hostnames, versionDiscovery) {
+  const attempts = hostnames.map(
+    (hostname) => rxjs.firstValueFrom(versionDiscovery.discoverVersion(hostname)).then(
+      (version) => ({ hostname, version })
+    )
+  );
+  try {
+    return await Promise.any(attempts);
+  } catch (error) {
+    const failures = error instanceof AggregateError ? error.errors : [error];
+    throw selectRepresentativeFailure(failures);
+  }
+}
+function selectRepresentativeFailure(failures) {
+  const isVersionError = (error) => (
+    // cases: valid response, but the given versions won't work for us
+    error instanceof VersionTooOldError || error instanceof VersionTooNewError || error instanceof NoCompatibleVersionsError || error instanceof VersionEndpointNotFoundError
+  );
+  const isNetworkError = (error) => error instanceof VersionDiscoveryNetworkError;
+  return failures.find(isVersionError) ?? failures.find(isNetworkError) ?? failures[0];
+}
 var CLIENT_BY_VERSION_KEY = {
   "25.10": TrueNasApiClientV2510,
   "26": TrueNasApiClientV26