@truedat/qx 8.3.5 → 8.4.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/qx",
-  "version": "8.3.5",
+  "version": "8.4.0",
   "description": "Truedat Web Quality Experience package",
   "sideEffects": false,
   "module": "src/index.js",
@@ -56,7 +56,7 @@
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
-    "@truedat/test": "8.3.5",
+    "@truedat/test": "8.3.6",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "redux-saga-test-plan": "^4.0.6"
@@ -89,5 +89,5 @@
     "semantic-ui-react": "^3.0.0-beta.2",
     "swr": "^2.3.3"
   },
-  "gitHead": "12d1969c3403861d360fbdc24fd270ab1fece070"
+  "gitHead": "d5bf6e90b3e11093255962cbd47534f2a67fe313"
 }

package/src/api.js

@@ -5,6 +5,7 @@ const API_FUNCTIONS = "/api/quality_functions";
 const API_QUALITY_CONTROL_DRAFT = "/api/quality_controls/:id/draft";
 const API_QUALITY_CONTROL_FILTERS = "/api/quality_controls/filters";
 const API_QUALITY_CONTROL_MAIN = "/api/quality_controls/:id/main";
+const API_QUALITY_CONTROL_DOMAIN = "/api/quality_controls/:id/domain";
 const API_QUALITY_CONTROL_PUBLISHED = "/api/quality_controls/:id/published";
 const API_QUALITY_CONTROL_QUERIES = "/api/quality_controls/:id/queries";
 const API_QUALITY_CONTROL_SEARCH = "/api/quality_controls/search";
@@ -33,6 +34,7 @@ export {
   API_QUALITY_CONTROL_DRAFT,
   API_QUALITY_CONTROL_FILTERS,
   API_QUALITY_CONTROL_MAIN,
+  API_QUALITY_CONTROL_DOMAIN,
   API_QUALITY_CONTROL_PUBLISHED,
   API_QUALITY_CONTROL_QUERIES,
   API_QUALITY_CONTROL_SEARCH,

package/src/components/qualityControls/QualityControl.js

@@ -37,7 +37,7 @@ const DomainPopup = () => {
 
 export default function QualityControl() {
   const { qualityControl, actions, loading } = use(QxContext);
-  const canUpdateDomain = _.includes("update_main")(actions);
+  const canUpdateDomain = _.includes("update_domain")(actions);
   return (
     <>
       {loading ? (

package/src/components/qualityControls/QualityControlActions.js

@@ -117,6 +117,7 @@ export default function QualityControlActions() {
       _.includes(action, [
         "delete_score",
         "update_main",
+        "update_domain",
         "execute",
         "link_to_business_concept",
         "link_to_data_structure",

package/src/components/qualityControls/QualityControlManageDomain.js

@@ -5,14 +5,14 @@ import { useForm, Controller } from "react-hook-form";
 import { useIntl } from "react-intl";
 import { DomainSelector } from "@truedat/core/components";
 import QxContext from "../QxContext";
-import { useQualityControlUpdateMain } from "../../hooks/useQualityControls";
+import { useQualityControlUpdateDomain } from "../../hooks/useQualityControls";
 
 export default function QualityControlManageDomain({ handleOpen }) {
   const { formatMessage } = useIntl();
   const { qualityControl, mutate } = use(QxContext);
 
-  const { trigger: updateMainQualityControl, isMutating: isMutatingMain } =
-    useQualityControlUpdateMain(qualityControl.id);
+  const { trigger: updateDomainQualityControl, isMutating: isMutatingMain } =
+    useQualityControlUpdateDomain(qualityControl.id);
 
   const domainIds = qualityControl.domain_ids;
   const [loading, setLoading] = useState(true);
@@ -24,7 +24,7 @@ export default function QualityControlManageDomain({ handleOpen }) {
   const { isDirty, isValid } = formState;
 
   const onSubmit = ({ domainIds }) => {
-    updateMainQualityControl({
+    updateDomainQualityControl({
       quality_control: { domain_ids: domainIds },
     }).then(() => {
       handleOpen(false);

package/src/components/qualityControls/__tests__/QualityControl.spec.js

@@ -45,7 +45,7 @@ describe("<QualityControl />", () => {
   it("matches the latest snapshot", async () => {
     const context = {
       qualityControl: qualityControlData(),
-      actions: ["update_main"],
+      actions: ["update_main", "update_domain"],
     };
     const rendered = render(
       <TestFormWrapper context={context}>
@@ -74,7 +74,7 @@ describe("<QualityControl />", () => {
   it("render popup when edit domain", async () => {
     const context = {
       qualityControl: qualityControlData(),
-      actions: ["update_main"],
+      actions: ["update_main", "update_domain"],
     };
     const rendered = render(
       <TestFormWrapper context={context}>

package/src/components/qualityControls/__tests__/QualityControlManageDomain.spec.js

@@ -1,10 +1,10 @@
 import { render } from "@truedat/test/render";
 import { waitFor } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
 import TestFormWrapper from "@truedat/qx/components/common/TestFormWrapper";
 import { messages } from "@truedat/qx/components/__tests__/__fixtures__/helper";
-import userEvent from "@testing-library/user-event";
 import { DOMAINS_QUERY } from "@truedat/core/api/queries";
-import { useQualityControlUpdateMain } from "@truedat/qx/hooks/useQualityControls";
+import { useQualityControlUpdateDomain } from "@truedat/qx/hooks/useQualityControls";
 import QualityControlManageDomain from "../QualityControlManageDomain";
 import { qualityControlData } from "./__fixtures__/qualityControlHelper";
 
@@ -14,7 +14,7 @@ jest.mock("@truedat/qx/hooks/useQualityControls", () => {
   );
 
   return {
-    useQualityControlUpdateMain: jest.fn(() => ({
+    useQualityControlUpdateDomain: jest.fn(() => ({
       trigger: jest.fn(() => Promise.resolve()),
       data: qualityControlData(),
       isMutating: false,
@@ -77,13 +77,14 @@ describe("<QualityControlManageDomain />", () => {
     expect(container).toMatchSnapshot();
   });
 
-  it("calls updateMain when update button is clicked", async () => {
+  it("calls updateDomain when update button is clicked", async () => {
     const trigger = jest.fn(() =>
       Promise.resolve({ data: { data: { id: "9" } } })
     );
-    useQualityControlUpdateMain.mockImplementation(() => ({
+    useQualityControlUpdateDomain.mockImplementation(() => ({
       trigger,
     }));
+    const user = userEvent.setup({ delay: null });
 
     const { container, queryByText, getByRole, getByText } = render(
       <TestFormWrapper context={context}>
@@ -98,14 +99,14 @@ describe("<QualityControlManageDomain />", () => {
 
     expect(getByRole("button", { name: "Update" })).toBeDisabled();
 
-    userEvent.click(getByRole("listbox"));
-    userEvent.click(getByRole("option", { name: "fooDomain" }));
+    await user.click(getByRole("listbox"));
+    await user.click(getByRole("option", { name: "fooDomain" }));
 
     await waitFor(() => {
       expect(getByRole("button", { name: "Update" })).toBeEnabled();
     });
 
-    userEvent.click(getByText("Update"));
+    await user.click(getByText(/update/i));
 
     await waitFor(() => expect(trigger).toHaveBeenCalledTimes(1));
     await waitFor(() => expect(handleOpen).toHaveBeenCalledTimes(1));

package/src/components/qualityControls/events/getParsedEvents.js

@@ -30,10 +30,10 @@ const getDomainNames = (path) => (event) =>
 const getPayloadFromDomainChange = (event) => {
   if (_.has("payload.changes.domains")(event)) {
     const changedDomainNames = _.join(", ")(
-      getDomainNames("payload.changes.domains")(event)
+      getDomainNames("payload.changes.domains")(event),
     );
     const currentDomainNames = _.join(", ")(
-      getDomainNames("payload.current_domains")(event)
+      getDomainNames("payload.current_domains")(event),
     );
     return [
       [
@@ -88,7 +88,7 @@ const getPayloadFromScoreCriteriaChange = (event) => {
             b: bold,
           },
         ];
-      })
+      }),
     )(event?.payload?.changes?.score_criteria);
   }
   return [];
@@ -120,7 +120,7 @@ const getPayloadFromDynamicContentChange = (event) => {
       _.map(([field, value]) => [
         { id: "quality_controls.events.action_dynamic_field_changed" },
         { field, value: normalizeValue(value?.value), b: bold },
-      ])
+      ]),
     )(content);
   }
   return [];
@@ -150,7 +150,7 @@ const getPayloadFromRegularFields = (event) => {
       _.map(([field, value]) => [
         { id: "quality_controls.events.action_field_changed" },
         { field, value: normalizeValue(value), b: bold },
-      ])
+      ]),
     )(event?.payload?.changes);
   }
   return [];

package/src/hooks/useQualityControls.js

@@ -12,6 +12,7 @@ import {
   API_QUALITY_CONTROL_DRAFT,
   API_QUALITY_CONTROL_STATUS,
   API_QUALITY_CONTROL_MAIN,
+  API_QUALITY_CONTROL_DOMAIN,
   API_QUALITY_CONTROL_SEARCH,
   API_QUALITY_CONTROL_FILTERS,
   API_QUALITY_CONTROL_QUERIES,
@@ -53,6 +54,11 @@ export const useQualityControlUpdateMain = (id) => {
   return useSWRMutations(url, (url, { arg }) => apiJsonPatch(url, arg));
 };
 
+export const useQualityControlUpdateDomain = (id) => {
+  const url = compile(API_QUALITY_CONTROL_DOMAIN)({ id: `${id}` });
+  return useSWRMutations(url, (url, { arg }) => apiJsonPatch(url, arg));
+};
+
 export const useQualityControlDelete = (qualityControl) => {
   const id = qualityControl?.id || 0;
   const version = qualityControl?.version || 0;