@truedat/qx 7.5.7 → 7.5.9

package/src/components/qualityControls/__tests__/QualityBadge.spec.js

@@ -101,25 +101,25 @@ describe("<QualityBadgeForSearch />", () => {
     expect(container).toMatchSnapshot();
   });
 
-  it("matches the latest snapshot for error_count", () => {
+  it("matches the latest snapshot for count", () => {
     const scoreCriteria = {
       goal: 78,
       maximum: 90,
     };
     const latestScore = {
       executed_at: "2025-03-25T05:34:21.438113Z",
-      error_count_content: {
-        error_count: 200,
+      count_content: {
+        count: 200,
       },
       result: 200,
       result_message: "under_threshold",
       status: "succeeded",
-      type: "error_count",
+      type: "count",
     };
 
     const { container } = render(
       <QualityBadgeForSearch
-        controlMode={"error_count"}
+        controlMode={"count"}
         criteria={scoreCriteria}
         latestScore={latestScore}
       />,
@@ -161,7 +161,7 @@ describe("<QualityBadgeForSearch />", () => {
     };
     const { container } = render(
       <QualityBadgeForSearch
-        controlMode={"error_count"}
+        controlMode={"count"}
         criteria={scoreCriteria}
         latestScore={latestScore}
       />,

package/src/components/qualityControls/__tests__/QualityControlEditor.spec.js

@@ -270,7 +270,7 @@ describe("<QualityControlEditor />", () => {
     userEvent.click(getByText(/Select source/));
     userEvent.click(getByRole("option", { name: /external_source_id/i }));
 
-    userEvent.click(getByRole("option", { name: /Error count/i }));
+    userEvent.click(getByRole("option", { name: /^count$/i }));
 
     // Fill in the 'Goal' field
     userEvent.type(getByPlaceholderText("Goal"), "25");

package/src/components/qualityControls/__tests__/QualityControlQueryModal.spec.js

@@ -28,7 +28,7 @@ const data = {
         },
         action: "count",
         __type__: "query",
-        query_ref: "error_count",
+        query_ref: "count",
       },
     ],
     resources_lookup: {

package/src/components/qualityControls/__tests__/ScoreCriteria.spec.js

@@ -21,9 +21,9 @@ describe("<ScoreCriteria />", () => {
     expect(container).toMatchSnapshot();
   });
 
-  it("matches the latest snapshot for error_count", () => {
+  it("matches the latest snapshot for count", () => {
     const defaultValues = {
-      control_mode: "error_count",
+      control_mode: "count",
     };
     const { container } = render(
       <TestFormWrapper defaultValues={defaultValues}>
@@ -63,7 +63,7 @@ describe("<ScoreCriteria />", () => {
   [
     { controlMode: "deviation", expectedValue: { goal: null, maximum: null } },
     {
-      controlMode: "error_count",
+      controlMode: "count",
       expectedValue: { goal: null, maximum: null },
     },
     { controlMode: "percentage", expectedValue: { goal: null, minimum: null } },

package/src/components/qualityControls/__tests__/ScoreCriteriaView.spec.js

@@ -32,9 +32,25 @@ describe("<ScoreCriteriaView />", () => {
     expect(queryByText(/5/i)).toBeInTheDocument();
   });
 
-  it("view for error count", () => {
+  it("view for error_count", () => {
     const qc = qualityControlData({
       control_mode: "error_count",
+      score_criteria: {
+        goal: 5,
+        maximum: 30,
+      },
+    });
+    const { queryByText } = render(
+      <ScoreCriteriaView qualityControl={qc} />,
+      renderOpts
+    );
+
+    expect(queryByText(/5/i)).toBeInTheDocument();
+  });
+
+  it("view for count", () => {
+    const qc = qualityControlData({
+      control_mode: "count",
       score_criteria: {
         goal: 15,
         maximum: 40,
@@ -49,7 +65,7 @@ describe("<ScoreCriteriaView />", () => {
 
   it("view for empty score_criteria", () => {
     const qc = qualityControlData({
-      control_mode: "error_count",
+      control_mode: "count",
       score_criteria: undefined,
     });
     const { queryByText } = render(

package/src/components/qualityControls/__tests__/__fixtures__/qualityControlHelper.js

@@ -156,7 +156,7 @@ const qualityControl = {
           type: "data_structure",
         },
       },
-      control_mode: "error_count",
+      control_mode: "count",
       dynamic_content: {
         control_de_calidad: {
           origin: "user",

package/src/components/qualityControls/__tests__/__snapshots__/ControlProperties.spec.js.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`<ControlProperties /> matches the latest snapshot with error count 1`] = `
+exports[`<ControlProperties /> matches the latest snapshot with count 1`] = `
 <div>
   <div
     class="ui segment"

package/src/components/qualityControls/__tests__/__snapshots__/ControlPropertiesView.spec.js.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`<ControlPropertiesView /> matches the latest snapshot for empty control properties 1`] = `
+exports[`<ControlPropertiesView /> matches the latest snapshot for count 1`] = `
 <div>
   <h3
     class="ui header"
@@ -18,12 +18,42 @@ exports[`<ControlPropertiesView /> matches the latest snapshot for empty control
   <div
     class="ui segment"
   >
-    Empty control properties
+    <div
+      class="ui list"
+      role="list"
+    >
+      <div
+        class="item"
+        role="listitem"
+      >
+        <div
+          class="header"
+        >
+          Dataset
+        </div>
+        <div
+          class="content"
+        >
+          <div
+            class="description"
+          >
+            <div
+              class="ui horizontal label"
+            >
+              Data Structure
+            </div>
+            <div
+              class="ui blue label"
+            />
+          </div>
+        </div>
+      </div>
+    </div>
   </div>
 </div>
 `;
 
-exports[`<ControlPropertiesView /> matches the latest snapshot for empty errors_resource 1`] = `
+exports[`<ControlPropertiesView /> matches the latest snapshot for empty control properties 1`] = `
 <div>
   <h3
     class="ui header"
@@ -41,31 +71,12 @@ exports[`<ControlPropertiesView /> matches the latest snapshot for empty errors_
   <div
     class="ui segment"
   >
-    <div
-      class="ui list"
-      role="list"
-    >
-      <div
-        class="item"
-        role="listitem"
-      >
-        <div
-          class="header"
-        >
-          Dataset
-        </div>
-        <div
-          class="content"
-        >
-          Empty Dataset
-        </div>
-      </div>
-    </div>
+    Empty control properties
   </div>
 </div>
 `;
 
-exports[`<ControlPropertiesView /> matches the latest snapshot for empty ratio validation and resource 1`] = `
+exports[`<ControlPropertiesView /> matches the latest snapshot for empty errors_resource 1`] = `
 <div>
   <h3
     class="ui header"
@@ -99,22 +110,7 @@ exports[`<ControlPropertiesView /> matches the latest snapshot for empty ratio v
         <div
           class="content"
         >
-          Empty resource
-        </div>
-      </div>
-      <div
-        class="item"
-        role="listitem"
-      >
-        <div
-          class="header"
-        >
-          Validation
-        </div>
-        <div
-          class="content"
-        >
-          Empty validation
+          Empty Dataset
         </div>
       </div>
     </div>
@@ -122,7 +118,7 @@ exports[`<ControlPropertiesView /> matches the latest snapshot for empty ratio v
 </div>
 `;
 
-exports[`<ControlPropertiesView /> matches the latest snapshot for error count 1`] = `
+exports[`<ControlPropertiesView /> matches the latest snapshot for empty ratio validation and resource 1`] = `
 <div>
   <h3
     class="ui header"
@@ -156,18 +152,22 @@ exports[`<ControlPropertiesView /> matches the latest snapshot for error count 1
         <div
           class="content"
         >
-          <div
-            class="description"
-          >
-            <div
-              class="ui horizontal label"
-            >
-              Data Structure
-            </div>
-            <div
-              class="ui blue label"
-            />
-          </div>
+          Empty resource
+        </div>
+      </div>
+      <div
+        class="item"
+        role="listitem"
+      >
+        <div
+          class="header"
+        >
+          Validation
+        </div>
+        <div
+          class="content"
+        >
+          Empty validation
         </div>
       </div>
     </div>

package/src/components/qualityControls/__tests__/__snapshots__/EditQualityControl.spec.js.snap

@@ -298,7 +298,20 @@ exports[`<EditQualityControl /> matches the latest snapshot 1`] = `
                 <span
                   class="text"
                 >
-                  Error count
+                  quality_control.control_mode.error_count
+                </span>
+              </div>
+              <div
+                aria-checked="false"
+                aria-selected="false"
+                class="item"
+                role="option"
+                style="pointer-events: all;"
+              >
+                <span
+                  class="text"
+                >
+                  count
                 </span>
               </div>
             </div>

package/src/components/qualityControls/__tests__/__snapshots__/NewDraftQualityControl.spec.js.snap

@@ -298,7 +298,20 @@ exports[`<NewDraftQualityControl /> matches the latest snapshot 1`] = `
                 <span
                   class="text"
                 >
-                  Error count
+                  quality_control.control_mode.error_count
+                </span>
+              </div>
+              <div
+                aria-checked="false"
+                aria-selected="false"
+                class="item"
+                role="option"
+                style="pointer-events: all;"
+              >
+                <span
+                  class="text"
+                >
+                  count
                 </span>
               </div>
             </div>

package/src/components/qualityControls/__tests__/__snapshots__/NewQualityControl.spec.js.snap

@@ -295,7 +295,20 @@ exports[`<NewQualityControl /> matches the latest snapshot 1`] = `
                 <span
                   class="text"
                 >
-                  Error count
+                  quality_control.control_mode.error_count
+                </span>
+              </div>
+              <div
+                aria-checked="false"
+                aria-selected="false"
+                class="item"
+                role="option"
+                style="pointer-events: all;"
+              >
+                <span
+                  class="text"
+                >
+                  count
                 </span>
               </div>
             </div>

package/src/components/qualityControls/__tests__/__snapshots__/QualityBadge.spec.js.snap

@@ -20,7 +20,7 @@ exports[`<QualityBadgeForSearch /> matches the latest snapshot for deviation 1`]
 </div>
 `;
 
-exports[`<QualityBadgeForSearch /> matches the latest snapshot for error_count 1`] = `
+exports[`<QualityBadgeForSearch /> matches the latest snapshot for count 1`] = `
 <div>
   <i
     aria-hidden="true"

package/src/components/qualityControls/__tests__/__snapshots__/QualityControl.spec.js.snap

@@ -77,8 +77,7 @@ exports[`<QualityControl /> matches the latest snapshot 1`] = `
           <div
             class="description"
           >
-            20
-            %
+            20%
           </div>
         </div>
       </div>
@@ -101,8 +100,7 @@ exports[`<QualityControl /> matches the latest snapshot 1`] = `
           <div
             class="description"
           >
-            10
-            %
+            10%
           </div>
         </div>
       </div>

package/src/components/qualityControls/__tests__/__snapshots__/QualityControlEditor.spec.js.snap

@@ -270,7 +270,20 @@ exports[`<QualityControlEditor /> matches the latest snapshot for creation 1`] =
             <span
               class="text"
             >
-              Error count
+              quality_control.control_mode.error_count
+            </span>
+          </div>
+          <div
+            aria-checked="false"
+            aria-selected="false"
+            class="item"
+            role="option"
+            style="pointer-events: all;"
+          >
+            <span
+              class="text"
+            >
+              count
             </span>
           </div>
         </div>
@@ -580,7 +593,20 @@ exports[`<QualityControlEditor /> matches the latest snapshot for edition 1`] =
             <span
               class="text"
             >
-              Error count
+              quality_control.control_mode.error_count
+            </span>
+          </div>
+          <div
+            aria-checked="false"
+            aria-selected="false"
+            class="item"
+            role="option"
+            style="pointer-events: all;"
+          >
+            <span
+              class="text"
+            >
+              count
             </span>
           </div>
         </div>

package/src/components/qualityControls/__tests__/__snapshots__/ScoreCriteria.spec.js.snap

@@ -63,7 +63,7 @@ exports[`<ScoreCriteria /> matches the latest snapshot for deviation 1`] = `
 
 exports[`<ScoreCriteria /> matches the latest snapshot for empty controlMode 1`] = `<div />`;
 
-exports[`<ScoreCriteria /> matches the latest snapshot for error_count 1`] = `
+exports[`<ScoreCriteria /> matches the latest snapshot for count 1`] = `
 <div>
   <div
     class="ui segment"

package/src/components/qualityControls/__tests__/__snapshots__/ScoreCriteriaView.spec.js.snap

@@ -41,8 +41,7 @@ exports[`<ScoreCriteriaView /> matches the latest snapshot for percentage 1`] =
           <div
             class="description"
           >
-            20
-            %
+            20%
           </div>
         </div>
       </div>
@@ -65,8 +64,7 @@ exports[`<ScoreCriteriaView /> matches the latest snapshot for percentage 1`] =
           <div
             class="description"
           >
-            10
-            %
+            10%
           </div>
         </div>
       </div>

package/src/components/qualityControls/__tests__/qualityByControlMode.spec.js

@@ -154,13 +154,13 @@ describe("qualityByControlMode", () => {
     expect(qualityByControlMode(score)).toEqual(result);
   });
 
-  it("returns correct object when controlMode is error_count with green", () => {
+  it("returns correct object when controlMode is count with green", () => {
     const score = scoreData({
       score_content: {
-        error_count: 10,
+        count: 10,
       },
       quality_control: {
-        control_mode: "error_count",
+        control_mode: "count",
         score_criteria: {
           maximum: 30,
           goal: 20,
@@ -169,8 +169,8 @@ describe("qualityByControlMode", () => {
     });
     const result = {
       color: "green",
-      label1: "quality_control.score_criteria.error_count.goal",
-      label2: "quality_control.score_criteria.error_count.maximum",
+      label1: "quality_control.score_criteria.count.goal",
+      label2: "quality_control.score_criteria.count.maximum",
       text: 10,
       value1: 20,
       value2: 30,
@@ -178,13 +178,13 @@ describe("qualityByControlMode", () => {
     expect(qualityByControlMode(score)).toEqual(result);
   });
 
-  it("returns correct object when controlMode is error_count with yellow", () => {
+  it("returns correct object when controlMode is count with yellow", () => {
     const score = scoreData({
       score_content: {
-        error_count: 20,
+        count: 20,
       },
       quality_control: {
-        control_mode: "error_count",
+        control_mode: "count",
 
         score_criteria: {
           maximum: 30,
@@ -194,8 +194,8 @@ describe("qualityByControlMode", () => {
     });
     const result = {
       color: "yellow",
-      label1: "quality_control.score_criteria.error_count.goal",
-      label2: "quality_control.score_criteria.error_count.maximum",
+      label1: "quality_control.score_criteria.count.goal",
+      label2: "quality_control.score_criteria.count.maximum",
       text: 20,
       value1: 20,
       value2: 30,
@@ -203,13 +203,13 @@ describe("qualityByControlMode", () => {
     expect(qualityByControlMode(score)).toEqual(result);
   });
 
-  it("returns correct object when controlMode is error_count with red", () => {
+  it("returns correct object when controlMode is count with red", () => {
     const score = scoreData({
       score_content: {
-        error_count: 40,
+        count: 40,
       },
       quality_control: {
-        control_mode: "error_count",
+        control_mode: "count",
 
         score_criteria: {
           maximum: 30,
@@ -219,8 +219,8 @@ describe("qualityByControlMode", () => {
     });
     const result = {
       color: "red",
-      label1: "quality_control.score_criteria.error_count.goal",
-      label2: "quality_control.score_criteria.error_count.maximum",
+      label1: "quality_control.score_criteria.count.goal",
+      label2: "quality_control.score_criteria.count.maximum",
       text: 40,
       value1: 20,
       value2: 30,
@@ -231,7 +231,7 @@ describe("qualityByControlMode", () => {
   it("returns correct object when controlMode is not defined", () => {
     const score = scoreData({
       score_content: {
-        error_count: 10,
+        count: 10,
       },
       quality_control: {
         control_mode: "foo",

package/src/components/qualityControls/controlProperties/{ErrorCount.js → Count.js}

@@ -10,7 +10,7 @@ import { useDataViews } from "@truedat/qx/hooks/useDataViews";
 import { useFunctions } from "@truedat/qx/hooks/useFunctions";
 import ResourceSelector from "@truedat/qx/components/common/ResourceSelector";
 
-export default function ErrorCount() {
+export default function Count() {
   const { field } = useContext(QxContext);
   const { watch } = useFormContext();
 
@@ -48,7 +48,7 @@ export default function ErrorCount() {
       >
         <ResourceSelector
           required
-          labelId="quality_control.form.control_properties.error_count.errors_resource"
+          labelId="quality_control.form.control_properties.count.errors_resource"
         />
       </QxContext.Provider>
     </>

package/src/components/qualityControls/controlProperties/__tests__/{ErrorCount.spec.js → Count.spec.js}

@@ -3,7 +3,7 @@ import { render } from "@truedat/test/render";
 import { waitFor } from "@testing-library/react";
 import { REFERENCE_DATASETS_HEADERS_QUERY } from "@truedat/dd/api/queries";
 import TestFormWrapper from "@truedat/qx/components/common/TestFormWrapper";
-import ErrorCount from "../ErrorCount";
+import Count from "../Count";
 
 jest.mock("@truedat/qx/hooks/useDataViews", () => {
   const originalModule = jest.requireActual("@truedat/qx/hooks/useDataViews");
@@ -36,20 +36,9 @@ const referenceDatasetsMock = {
   result: { data: { referenceDatasets: [dataSet], loading: false } },
 };
 
-const messages = {
-  en: {
-    "quality_control.form.control_properties.error_count.errors_resource":
-      "Dataset",
-    "queryables.resource.type": "Resource type",
-    "queryables.resource.type.data_structure": "Data structures",
-    "queryables.resource.type.reference_dataset": "Reference datasets",
-  },
-};
-
 const renderOpts = {
   mocks: [referenceDatasetsMock],
   fallback: "lazy",
-  messages,
 };
 
 const context = {
@@ -65,11 +54,11 @@ const context = {
   ],
 };
 
-describe("<ErrorCount />", () => {
+describe("<Count />", () => {
   it("matches the latest snapshot", async () => {
     const { container, queryByText } = render(
       <TestFormWrapper context={context}>
-        <ErrorCount />
+        <Count />
       </TestFormWrapper>,
       renderOpts
     );

package/src/components/qualityControls/controlProperties/__tests__/__snapshots__/{ErrorCount.spec.js.snap → Count.spec.js.snap}

@@ -1,12 +1,12 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`<ErrorCount /> matches the latest snapshot 1`] = `
+exports[`<Count /> matches the latest snapshot 1`] = `
 <div>
   <div
     class="required field"
   >
     <label>
-      Dataset
+      quality_control.form.control_properties.count.errors_resource
     </label>
     <div
       aria-expanded="false"
@@ -20,7 +20,7 @@ exports[`<ErrorCount /> matches the latest snapshot 1`] = `
         class="divider default text"
         role="alert"
       >
-        Resource type
+        queryables.resource.type
       </div>
       <i
         aria-hidden="true"
@@ -39,7 +39,7 @@ exports[`<ErrorCount /> matches the latest snapshot 1`] = `
           <span
             class="text"
           >
-            Data structures
+            queryables.resource.type.data_structure
           </span>
         </div>
         <div
@@ -52,7 +52,7 @@ exports[`<ErrorCount /> matches the latest snapshot 1`] = `
           <span
             class="text"
           >
-            Reference datasets
+            queryables.resource.type.reference_dataset
           </span>
         </div>
       </div>