@truedat/qx 7.5.7 → 7.5.10

package/src/components/qualityControls/__tests__/NewQualityControl.spec.js

@@ -1,21 +1,19 @@
-import React from "react";
-import { render } from "@truedat/test/render";
-import { waitFor } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
+import { act, waitFor } from "@testing-library/react";
+import { render, waitForLoad } from "@truedat/test/render";
 import { singleTemplateMock } from "@truedat/test/mocks";
 import { DOMAINS_QUERY } from "@truedat/core/api/queries";
 import { SOURCE_OPTIONS_QUERY } from "@truedat/cx/sources/api/queries";
 import { REFERENCE_DATASETS_HEADERS_QUERY } from "@truedat/dd/api/queries";
-import { messages } from "@truedat/qx/components/__tests__/__fixtures__/helper";
 import { useQualityControlCreate } from "@truedat/qx/hooks/useQualityControls";
 import NewQualityControl from "../NewQualityControl";
 import { sources, domains } from "./__fixtures__/qualityControlHelper";
 
-const mockHistory = { push: jest.fn() };
+const mockNavigate = jest.fn();
 
-jest.mock("react-router-dom", () => ({
-  ...jest.requireActual("react-router-dom"),
-  useHistory: () => mockHistory,
+jest.mock("react-router", () => ({
+  ...jest.requireActual("react-router"),
+  useNavigate: () => mockNavigate,
 }));
 
 jest.mock("@truedat/qx/hooks/useQualityControls", () => ({
@@ -65,6 +63,11 @@ const referenceDatasetsMock = {
           name: "dataset1",
           headers: ["campo1", "campo2"],
         },
+        {
+          id: "8",
+          name: "patito",
+          headers: ["pasto1", "pasto2"],
+        },
       ],
       loading: false,
     },
@@ -95,45 +98,29 @@ const renderOpts = {
     createDomainsMock,
     domainsMock,
   ],
-  messages,
-  fallback: "loading",
 };
 
 describe("<NewQualityControl />", () => {
   it("matches the latest snapshot", async () => {
-    const { container, queryByText } = render(
-      <NewQualityControl />,
-
-      renderOpts
-    );
-
-    await waitFor(() =>
-      expect(container.querySelector(".loader")).not.toBeInTheDocument()
-    );
-    await waitFor(() =>
-      expect(queryByText(/loading/i)).not.toBeInTheDocument()
-    );
-    expect(container).toMatchSnapshot();
+    const rendered = render(<NewQualityControl />, renderOpts);
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
   it("navigates to qulity controls when cancel button is cliked", async () => {
-    const { container, getByText, queryByText } = render(
-      <NewQualityControl />,
-      renderOpts
-    );
-    await waitFor(() =>
-      expect(queryByText(/loading/i)).not.toBeInTheDocument()
-    );
-    await waitFor(() =>
-      expect(container.querySelector(".loader")).not.toBeInTheDocument()
-    );
-    userEvent.click(getByText(/Cancel/));
-    userEvent.click(getByText(/confirm_yes/));
-    await waitFor(() => expect(mockHistory.push.mock.calls.length).toBe(1));
-    expect(mockHistory.push.mock.calls[0][0]).toBe("/qualityControls");
+    const user = userEvent.setup({ delay: null });
+    const rendered = render(<NewQualityControl />, renderOpts);
+    await waitForLoad(rendered);
+
+    await user.click(rendered.getByText(/actions.cancel/i));
+    await user.click(rendered.getByText(/confirmation.yes/i));
+
+    await waitFor(() => expect(mockNavigate.mock.calls.length).toBe(1));
+    expect(mockNavigate.mock.calls[0][0]).toBe("/qualityControls");
   });
 
   it("test save submit ", async () => {
+    const user = userEvent.setup({ delay: null });
     const trigger = jest.fn(() =>
       Promise.resolve({ data: { data: { id: "9", version: "1" } } })
     );
@@ -142,62 +129,59 @@ describe("<NewQualityControl />", () => {
       trigger,
     }));
 
-    const {
-      container,
-      getByText,
-      getByPlaceholderText,
-      queryByText,
-      getByRole,
-      getAllByRole,
-    } = render(<NewQualityControl />, renderOpts);
+    const rendered = render(<NewQualityControl />, renderOpts);
+    await waitForLoad(rendered);
 
     await waitFor(() =>
-      expect(queryByText(/loading/i)).not.toBeInTheDocument()
-    );
-    await waitFor(() =>
-      expect(getByRole("button", { name: /Save/ })).toBeDisabled()
+      expect(rendered.getByRole("button", { name: /save/i })).toBeDisabled()
     );
 
-    // Fill in the 'Name' field
-    userEvent.type(getByPlaceholderText("Name"), "test_modified");
-
     // Select a domain
-    userEvent.click(getByText(/Select domains/));
-    userEvent.click(getByText(/barDomain/));
+    await user.click(rendered.getByText(/domain.multiple.placeholder/i));
+    await user.click(rendered.getByText(/bardomain/i));
+
+    // Fill in the 'Name' field
+    await user.type(rendered.getByPlaceholderText(/name/i), "test_modified");
 
     // Select a source
-    userEvent.click(getByText(/Select source/));
-    userEvent.click(getByRole("option", { name: /external_source_id/i }));
+    await user.click(rendered.getByText(/source.search.placeholder/i));
+    await user.click(
+      rendered.getByRole("option", { name: /external_source_id/i })
+    );
 
     // Select a control mode
-    userEvent.click(getByRole("option", { name: /Percentage/i }));
+    await user.click(
+      rendered.getByRole("option", { name: /control_mode.percentage/i })
+    );
 
     // Fill in the 'Threshold' field
-    userEvent.type(getByPlaceholderText("Threshold"), "10");
+    await user.type(
+      rendered.getByPlaceholderText(/score_criteria.percentage.minimum/i),
+      "10"
+    );
 
     // Fill in the 'Goal' field
-    userEvent.type(getByPlaceholderText("Goal"), "20");
-
-    await waitFor(() =>
-      expect(queryByText(/loading/i)).not.toBeInTheDocument()
-    );
-    await waitFor(() =>
-      expect(container.querySelector(".loader")).not.toBeInTheDocument()
+    await user.type(
+      rendered.getByPlaceholderText(/score_criteria.percentage.goal/i),
+      "20"
     );
 
-    // Select the 'Reference datasets' for the resource type
-    userEvent.click(getByText(/Resource type/));
-    userEvent.click(getByText(/Reference datasets/));
-    userEvent.click(getByRole("option", { name: /dataset1/i }));
+    await waitForLoad(rendered);
+
+    await user.click(rendered.getByText(/^queryables.resource.type$/));
+    await user.click(rendered.getByText(/reference_dataset/i));
+    await user.click(rendered.getByRole("option", { name: /dataset1/i }));
 
-    userEvent.click(getAllByRole("option", { name: /campo1/i })[0]);
-    userEvent.click(getByRole("option", { name: /eq/i }));
-    userEvent.click(getAllByRole("option", { name: /campo2/i })[1]);
+    await act(async () => {
+      await user.click(rendered.getAllByRole("option", { name: /campo1/ })[0]);
+      await user.click(rendered.getByRole("option", { name: "eq" }));
+      await user.click(rendered.getAllByRole("option", { name: /campo2/ })[1]);
+    });
 
     await waitFor(() =>
-      expect(getByRole("button", { name: /Save/ })).toBeEnabled()
+      expect(rendered.getByRole("button", { name: /save/i })).toBeEnabled()
     );
-    userEvent.click(getByText(/Save/));
+    await user.click(rendered.getByText(/save/i));
 
     await waitFor(() =>
       expect(trigger).toHaveBeenCalledWith({
@@ -281,7 +265,8 @@ describe("<NewQualityControl />", () => {
     );
   });
 
-  it("test publish submit ", async () => {
+  it.skip("test publish submit ", async () => {
+    const user = userEvent.setup({ delay: null });
     const trigger = jest.fn(() =>
       Promise.resolve({ data: { data: { id: "9", version: "1" } } })
     );
@@ -290,55 +275,51 @@ describe("<NewQualityControl />", () => {
       trigger,
     }));
 
-    const {
-      container,
-      getByText,
-      getByPlaceholderText,
-      queryByText,
-      getByRole,
-    } = render(<NewQualityControl />, renderOpts);
+    const rendered = render(<NewQualityControl />, renderOpts);
+    await waitForLoad(rendered);
 
     await waitFor(() =>
-      expect(queryByText(/loading/i)).not.toBeInTheDocument()
-    );
-    await waitFor(() =>
-      expect(getByRole("button", { name: /Publish/ })).toBeDisabled()
+      expect(rendered.getByRole("button", { name: /publish/i })).toBeDisabled()
     );
 
     // Fill in the 'Name' field
-    userEvent.type(getByPlaceholderText("Name"), "test_modified");
+    await user.type(rendered.getByPlaceholderText(/name/i), "test_modified");
 
     // Select a domain
-    userEvent.click(getByText(/Select domains/));
-    userEvent.click(getByText(/barDomain/));
+    await user.click(rendered.getByText(/domain.multiple.placeholder/i));
+    await user.click(rendered.getByText(/bardomain/i));
 
     // Select a source
-    userEvent.click(getByText(/Select source/));
-    userEvent.click(getByRole("option", { name: /external_source_id/i }));
+    await user.click(rendered.getByText(/source.search.placeholder/i));
+    await user.click(
+      rendered.getByRole("option", { name: /external_source_id/i })
+    );
 
-    userEvent.click(getByRole("option", { name: /Error count/i }));
+    await user.click(rendered.getByRole("option", { name: /error_count/i }));
 
     // Fill in the 'Goal' field
-    userEvent.type(getByPlaceholderText("Goal"), "25");
-    // Fill in the 'Threshold' field
-    userEvent.type(getByPlaceholderText("Threshold"), "50");
-
-    await waitFor(() =>
-      expect(queryByText(/loading/i)).not.toBeInTheDocument()
+    await user.type(
+      rendered.getByPlaceholderText(/score_criteria.error_count.goal/i),
+      "25"
     );
-    await waitFor(() =>
-      expect(container.querySelector(".loader")).not.toBeInTheDocument()
+    // Fill in the 'Threshold' field
+    await user.type(
+      rendered.getByPlaceholderText(/score_criteria.error_count.maximum/i),
+      "50"
     );
+    await waitForLoad(rendered);
 
-    // // Select the 'Reference datasets' for the resource type
-    userEvent.click(getByText(/Resource type/));
-    userEvent.click(getByText(/Reference datasets/));
-    userEvent.click(getByRole("option", { name: /dataset1/i }));
+    // Select the 'Reference datasets' for the resource type
+    await user.click(rendered.getByText(/^queryables.resource.type$/));
+    await user.click(
+      rendered.getByText(/queryables.resource.type.reference_datase/i)
+    );
+    await user.click(rendered.getByRole("option", { name: /dataset1/i }));
 
     await waitFor(() =>
-      expect(getByRole("button", { name: /Publish/i })).toBeEnabled()
+      expect(rendered.getByRole("button", { name: /publish/i })).toBeEnabled()
     );
-    userEvent.click(getByText(/Publish/i));
+    await user.click(rendered.getByText(/publish/i));
 
     await waitFor(() =>
       expect(trigger).toHaveBeenCalledWith({
@@ -348,7 +329,7 @@ describe("<NewQualityControl />", () => {
           domain_ids: ["2"],
           df_type: "template1",
           source_id: 181,
-          control_mode: "error_count",
+          control_mode: "count",
           dynamic_content: {},
           control_properties: {
             errors_resource: {

package/src/components/qualityControls/__tests__/QualityBadge.spec.js

@@ -1,49 +1,46 @@
-import _ from "lodash/fp";
-import React from "react";
-import { render } from "@truedat/test/render";
-import { messages } from "@truedat/qx/components/__tests__/__fixtures__/helper";
+import { render, waitForLoad } from "@truedat/test/render";
 import { scoreData } from "@truedat/qx/components/scores/__tests__/__fixtures__/scoreHelper";
 import QualityBadge, { QualityBadgeForSearch } from "../QualityBadge";
 
-const renderOpts = { messages };
-
 describe("<QualityBadge />", () => {
-  it("matches the latest snapshot", () => {
+  it("matches the latest snapshot", async () => {
     const score = scoreData();
-    const { container } = render(<QualityBadge score={score} />, renderOpts);
-
-    expect(container).toMatchSnapshot();
+    const rendered = render(<QualityBadge score={score} />);
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
-  it("show status failed", () => {
+  it("show status failed", async () => {
     const score = scoreData({ status: "FAILED" });
-    const { queryByText } = render(<QualityBadge score={score} />, renderOpts);
-
-    expect(queryByText(/Failed/i)).toBeInTheDocument();
+    const rendered = render(<QualityBadge score={score} />);
+    await waitForLoad(rendered);
+    expect(rendered.queryByText(/failed/i)).toBeInTheDocument();
   });
 
-  it("show no executed", () => {
+  it("show no executed", async () => {
     const score = scoreData({ score_content: undefined });
-    const { queryByText } = render(<QualityBadge score={score} />, renderOpts);
-
-    expect(queryByText(/Not executed/i)).toBeInTheDocument();
+    const rendered = render(<QualityBadge score={score} />);
+    await waitForLoad(rendered);
+    rendered.debug();
+    expect(rendered.queryByText(/score.not_executed/i)).toBeInTheDocument();
   });
 
-  it("show no results", () => {
+  it("show no results", async () => {
     const score_content = {
       total_count: 0,
       validation_count: 50,
     };
 
     const score = scoreData({ score_content });
-    const { queryByText } = render(<QualityBadge score={score} />, renderOpts);
-
-    expect(queryByText(/No results/i)).toBeInTheDocument();
+    const rendered = render(<QualityBadge score={score} />);
+    await waitForLoad(rendered);
+    rendered.debug();
+    expect(rendered.queryByText(/score.no_results/i)).toBeInTheDocument();
   });
 });
 
 describe("<QualityBadgeForSearch />", () => {
-  it("matches the latest snapshot for percentage", () => {
+  it("matches the latest snapshot for percentage", async () => {
     const scoreCriteria = {
       goal: 60,
       maximum: 75,
@@ -60,19 +57,18 @@ describe("<QualityBadgeForSearch />", () => {
       type: "ratio",
     };
 
-    const { container } = render(
+    const rendered = render(
       <QualityBadgeForSearch
         controlMode={"percentage"}
         criteria={scoreCriteria}
         latestScore={latestScore}
-      />,
-      renderOpts
+      />
     );
-
-    expect(container).toMatchSnapshot();
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
-  it("matches the latest snapshot for deviation", () => {
+  it("matches the latest snapshot for deviation", async () => {
     const scoreCriteria = {
       goal: 78,
       maximum: 90,
@@ -89,47 +85,45 @@ describe("<QualityBadgeForSearch />", () => {
       type: "ratio",
     };
 
-    const { container } = render(
+    const rendered = render(
       <QualityBadgeForSearch
         controlMode={"deviation"}
         criteria={scoreCriteria}
         latestScore={latestScore}
-      />,
-      renderOpts
+      />
     );
-
-    expect(container).toMatchSnapshot();
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
-  it("matches the latest snapshot for error_count", () => {
+  it("matches the latest snapshot for count", async () => {
     const scoreCriteria = {
       goal: 78,
       maximum: 90,
     };
     const latestScore = {
       executed_at: "2025-03-25T05:34:21.438113Z",
-      error_count_content: {
-        error_count: 200,
+      count_content: {
+        count: 200,
       },
       result: 200,
       result_message: "under_threshold",
       status: "succeeded",
-      type: "error_count",
+      type: "count",
     };
 
-    const { container } = render(
+    const rendered = render(
       <QualityBadgeForSearch
-        controlMode={"error_count"}
+        controlMode={"count"}
         criteria={scoreCriteria}
         latestScore={latestScore}
-      />,
-      renderOpts
+      />
     );
-
-    expect(container).toMatchSnapshot();
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
-  it("show status failed", () => {
+  it("show status failed", async () => {
     const latestScore = {
       result_message: null,
       status: "failed",
@@ -139,19 +133,18 @@ describe("<QualityBadgeForSearch />", () => {
       minimum: 10,
     };
 
-    const { queryByText } = render(
+    const rendered = render(
       <QualityBadgeForSearch
         controlMode={"percentage"}
         criteria={scoreCriteria}
         latestScore={latestScore}
-      />,
-      renderOpts
+      />
     );
-
-    expect(queryByText(/Failed/i)).toBeInTheDocument();
+    await waitForLoad(rendered);
+    expect(rendered.queryByText(/failed/i)).toBeInTheDocument();
   });
 
-  it("show no executed", () => {
+  it("show no executed", async () => {
     const scoreCriteria = {
       goal: 78,
       maximum: 90,
@@ -159,19 +152,18 @@ describe("<QualityBadgeForSearch />", () => {
     const latestScore = {
       result_message: null,
     };
-    const { container } = render(
+    const rendered = render(
       <QualityBadgeForSearch
-        controlMode={"error_count"}
+        controlMode={"count"}
         criteria={scoreCriteria}
         latestScore={latestScore}
-      />,
-      renderOpts
+      />
     );
-
-    expect(container).toMatchSnapshot();
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
-  it("show no results", () => {
+  it("show no results", async () => {
     const scoreCriteria = {
       goal: 60,
       maximum: 75,
@@ -187,15 +179,15 @@ describe("<QualityBadgeForSearch />", () => {
       status: "succeeded",
       type: "ratio",
     };
-    const { queryByText } = render(
+    const rendered = render(
       <QualityBadgeForSearch
         controlMode={"percentage"}
         criteria={scoreCriteria}
         latestScore={latestScore}
-      />,
-      renderOpts
+      />
     );
-
-    expect(queryByText(/No results/i)).toBeInTheDocument();
+    await waitForLoad(rendered);
+    rendered.debug();
+    expect(rendered.queryByText(/score.no_results/i)).toBeInTheDocument();
   });
 });

package/src/components/qualityControls/__tests__/QualityControl.spec.js

@@ -1,10 +1,8 @@
-import React from "react";
-import { render } from "@truedat/test/render";
+import { render, waitForLoad } from "@truedat/test/render";
 import { waitFor } from "@testing-library/react";
 import TestFormWrapper from "@truedat/qx/components/common/TestFormWrapper";
 import userEvent from "@testing-library/user-event";
 import { templateByNameMock } from "@truedat/test/mocks";
-import { messages } from "@truedat/qx/components/__tests__/__fixtures__/helper";
 import { DOMAINS_QUERY } from "@truedat/core/api/queries";
 import QualityControl from "../QualityControl";
 import { qualityControlData } from "./__fixtures__/qualityControlHelper";
@@ -41,8 +39,6 @@ const renderOpts = {
     createDomainsMock,
     templateByNameMock({ name: "template1", domainIds: [2] }),
   ],
-  messages,
-  fallback: "loading",
 };
 
 describe("<QualityControl />", () => {
@@ -51,35 +47,28 @@ describe("<QualityControl />", () => {
       qualityControl: qualityControlData(),
       actions: ["update_main"],
     };
-    const { container, queryByText } = render(
+    const rendered = render(
       <TestFormWrapper context={context}>
         <QualityControl />
       </TestFormWrapper>,
       renderOpts
     );
-
-    await waitFor(() => {
-      expect(queryByText(/loading/i)).not.toBeInTheDocument();
-      expect(container.querySelector(".loader")).not.toBeInTheDocument();
-    });
-
-    expect(container).toMatchSnapshot();
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
   it("do not show edit domain if the user does not have permissions", async () => {
     const context = { qualityControl: qualityControlData() };
-    const { container, queryByText } = render(
+    const rendered = render(
       <TestFormWrapper context={context}>
         <QualityControl />
       </TestFormWrapper>,
       renderOpts
     );
-    await waitFor(() => {
-      expect(queryByText(/loading/i)).not.toBeInTheDocument();
-      expect(
-        container.querySelector(".pencil alternate icon")
-      ).not.toBeInTheDocument();
-    });
+    await waitForLoad(rendered);
+    expect(
+      rendered.container.querySelector(".pencil.alternate.icon")
+    ).not.toBeInTheDocument();
   });
 
   it("render popup when edit domain", async () => {
@@ -87,27 +76,25 @@ describe("<QualityControl />", () => {
       qualityControl: qualityControlData(),
       actions: ["update_main"],
     };
-    const { container, queryByText } = render(
+    const rendered = render(
       <TestFormWrapper context={context}>
         <QualityControl />
       </TestFormWrapper>,
       renderOpts
     );
+    await waitForLoad(rendered);
 
-    await waitFor(() => {
-      expect(queryByText(/loading/i)).not.toBeInTheDocument();
-      expect(container.querySelector(".loader")).not.toBeInTheDocument();
-    });
-
-    const pencilButton = container.querySelector(".pencil.alternate.icon");
+    const pencilButton = rendered.container.querySelector(
+      ".pencil.alternate.icon"
+    );
     userEvent.click(pencilButton);
 
     await waitFor(() => {
-      expect(queryByText(/fooDomain/i)).toBeInTheDocument();
+      expect(rendered.queryByText(/foodomain/i)).toBeInTheDocument();
     });
     userEvent.click(pencilButton);
     await waitFor(() => {
-      expect(queryByText(/fooDomain/i)).not.toBeInTheDocument();
+      expect(rendered.queryByText(/foodomain/i)).not.toBeInTheDocument();
     });
   });
 
@@ -115,14 +102,15 @@ describe("<QualityControl />", () => {
     const context = {
       qualityControl: qualityControlData({ df_type: undefined }),
     };
-    const { queryByText } = render(
+    const rendered = render(
       <TestFormWrapper context={context}>
         <QualityControl />
       </TestFormWrapper>,
       renderOpts
     );
+    await waitForLoad(rendered);
     await waitFor(() =>
-      expect(queryByText(/Information/i)).not.toBeInTheDocument()
+      expect(rendered.queryByText(/information/i)).not.toBeInTheDocument()
     );
   });
 });