@truedat/qx 7.4.0 → 7.4.1

package/src/components/qualityControls/__tests__/QualityBadge.spec.js

@@ -1,8 +1,9 @@
+import _ from "lodash/fp";
 import React from "react";
 import { render } from "@truedat/test/render";
 import { messages } from "@truedat/qx/components/__tests__/__fixtures__/helper";
 import { scoreData } from "@truedat/qx/components/scores/__tests__/__fixtures__/scoreHelper";
-import QualityBadge from "../QualityBadge";
+import QualityBadge, { QualityBadgeForSearch } from "../QualityBadge";
 
 const renderOpts = { messages };
 
@@ -21,10 +22,180 @@ describe("<QualityBadge />", () => {
     expect(queryByText(/Failed/i)).toBeInTheDocument();
   });
 
-  it("show no results", () => {
+  it("show no executed", () => {
     const score = scoreData({ score_content: undefined });
     const { queryByText } = render(<QualityBadge score={score} />, renderOpts);
 
+    expect(queryByText(/Not executed/i)).toBeInTheDocument();
+  });
+
+  it("show no results", () => {
+    const score_content = {
+      total_count: 0,
+      validation_count: 50,
+    };
+
+    const score = scoreData({ score_content });
+    const { queryByText } = render(<QualityBadge score={score} />, renderOpts);
+
+    expect(queryByText(/No results/i)).toBeInTheDocument();
+  });
+});
+
+describe("<QualityBadgeForSearch />", () => {
+  it("matches the latest snapshot for percentage", () => {
+    const scoreCriteria = {
+      goal: 60,
+      maximum: 75,
+    };
+    const latestScore = {
+      executed_at: "2025-03-25T05:34:21.438113Z",
+      ratio_content: {
+        total_count: 100,
+        validation_count: 100,
+      },
+      result: 100,
+      result_message: "meets_goal",
+      status: "succeeded",
+      type: "ratio",
+    };
+
+    const { container } = render(
+      <QualityBadgeForSearch
+        controlMode={"percentage"}
+        criteria={scoreCriteria}
+        latestScore={latestScore}
+      />,
+      renderOpts
+    );
+
+    expect(container).toMatchSnapshot();
+  });
+
+  it("matches the latest snapshot for deviation", () => {
+    const scoreCriteria = {
+      goal: 78,
+      maximum: 90,
+    };
+    const latestScore = {
+      executed_at: "2025-03-25T05:34:21.438113Z",
+      ratio_content: {
+        total_count: 100,
+        validation_count: 5,
+      },
+      result: 100,
+      result_message: "under_goal",
+      status: "succeeded",
+      type: "ratio",
+    };
+
+    const { container } = render(
+      <QualityBadgeForSearch
+        controlMode={"deviation"}
+        criteria={scoreCriteria}
+        latestScore={latestScore}
+      />,
+      renderOpts
+    );
+
+    expect(container).toMatchSnapshot();
+  });
+
+  it("matches the latest snapshot for error_count", () => {
+    const scoreCriteria = {
+      goal: 78,
+      maximum: 90,
+    };
+    const latestScore = {
+      executed_at: "2025-03-25T05:34:21.438113Z",
+      error_count_content: {
+        error_count: 200,
+      },
+      result: 200,
+      result_message: "under_threshold",
+      status: "succeeded",
+      type: "error_count",
+    };
+
+    const { container } = render(
+      <QualityBadgeForSearch
+        controlMode={"error_count"}
+        criteria={scoreCriteria}
+        latestScore={latestScore}
+      />,
+      renderOpts
+    );
+
+    expect(container).toMatchSnapshot();
+  });
+
+  it("show status failed", () => {
+    const latestScore = {
+      result_message: null,
+      status: "failed",
+    };
+    const scoreCriteria = {
+      goal: 20,
+      minimum: 10,
+    };
+
+    const { queryByText } = render(
+      <QualityBadgeForSearch
+        controlMode={"percentage"}
+        criteria={scoreCriteria}
+        latestScore={latestScore}
+      />,
+      renderOpts
+    );
+
+    expect(queryByText(/Failed/i)).toBeInTheDocument();
+  });
+
+  it("show no executed", () => {
+    const scoreCriteria = {
+      goal: 78,
+      maximum: 90,
+    };
+    const latestScore = {
+      result_message: null,
+    };
+    const { container } = render(
+      <QualityBadgeForSearch
+        controlMode={"error_count"}
+        criteria={scoreCriteria}
+        latestScore={latestScore}
+      />,
+      renderOpts
+    );
+
+    expect(container).toMatchSnapshot();
+  });
+
+  it("show no results", () => {
+    const scoreCriteria = {
+      goal: 60,
+      maximum: 75,
+    };
+    const latestScore = {
+      executed_at: "2025-03-25T05:34:21.438113Z",
+      ratio_content: {
+        total_count: 0,
+        validation_count: 80,
+      },
+      result: null,
+      result_message: "no_results",
+      status: "succeeded",
+      type: "ratio",
+    };
+    const { queryByText } = render(
+      <QualityBadgeForSearch
+        controlMode={"percentage"}
+        criteria={scoreCriteria}
+        latestScore={latestScore}
+      />,
+      renderOpts
+    );
+
     expect(queryByText(/No results/i)).toBeInTheDocument();
   });
 });

package/src/components/qualityControls/__tests__/QualityControlActions.spec.js

@@ -37,6 +37,11 @@ jest.mock("@truedat/qx/hooks/useQualityControls", () => {
       isMutating: false,
       loading: false,
     })),
+    useQualityControlDelete: jest.fn(() => ({
+      trigger: jest.fn(() => Promise.resolve()),
+      data: qualityControlData(),
+      loading: false,
+    })),
   };
 });
 
@@ -159,11 +164,11 @@ describe("<QualityControlActions />", () => {
 
     expect(getByText(/Create Draft/i).closest("a")).toHaveAttribute(
       "href",
-      `/qualityControls/${qualityControl.id}/new_draft`
+      `/qualityControls/${qualityControl.id}/version/${qualityControl.version}/new_draft`
     );
     expect(getByText(/Edit/i).closest("a")).toHaveAttribute(
       "href",
-      `/qualityControls/${qualityControl.id}/edit`
+      `/qualityControls/${qualityControl.id}/version/${qualityControl.version}/edit`
     );
   });
 

package/src/components/qualityControls/__tests__/QualityControlHeader.spec.js

@@ -7,7 +7,7 @@ import { qualityControlData } from "./__fixtures__/qualityControlHelper";
 
 jest.mock("react-router-dom", () => ({
   ...jest.requireActual("react-router-dom"),
-  useParams: () => ({ id: "8" }),
+  useParams: () => ({ id: "8", version: "1" }),
 }));
 
 jest.mock("@truedat/qx/hooks/useQualityControls", () => {
@@ -26,6 +26,7 @@ jest.mock("@truedat/qx/hooks/useQualityControls", () => {
           "delete_score",
           "update_main",
           "execute",
+          "delete",
         ],
       },
       loading: false,
@@ -41,6 +42,11 @@ jest.mock("@truedat/qx/hooks/useQualityControls", () => {
       data: { ...qualityControlData(), status: "published" },
       loading: false,
     })),
+    useQualityControlDelete: jest.fn(() => ({
+      trigger: jest.fn(() => Promise.resolve()),
+      data: qualityControlData(),
+      loading: false,
+    })),
   };
 });
 

package/src/components/qualityControls/__tests__/QualityControlRow.spec.js

@@ -1,7 +1,5 @@
 import React from "react";
 import { render } from "@truedat/test/render";
-import { waitFor } from "@testing-library/react";
-import userEvent from "@testing-library/user-event";
 import { messages } from "@truedat/qx/components/__tests__/__fixtures__/helper";
 import { columns } from "../QualityControlsTable";
 import QualityControlRow from "../QualityControlRow";
@@ -68,7 +66,7 @@ describe("<QualityControlRow />", () => {
       renderOpts
     );
     const link = queryByText("test");
-    expect(link).toHaveAttribute("href", "/qualityControls/8");
+    expect(link).toHaveAttribute("href", "/qualityControls/8/version/1");
   });
 
   it("renders empty table columns are empty", () => {

package/src/components/qualityControls/__tests__/QualityControlScores.spec.js

@@ -14,7 +14,7 @@ import { qualityControlData } from "./__fixtures__/qualityControlHelper";
 
 jest.mock("react-router-dom", () => ({
   ...jest.requireActual("react-router-dom"),
-  useParams: () => ({ id: "8" }),
+  useParams: () => ({ id: "8", version: "1" }),
 }));
 
 jest.mock("@truedat/qx/hooks/useScores", () => {

package/src/components/qualityControls/__tests__/QualityControlTabs.spec.js

@@ -5,8 +5,8 @@ import QualityControlTabs from "../QualityControlTabs";
 
 jest.mock("react-router-dom", () => ({
   ...jest.requireActual("react-router-dom"),
-  useParams: () => ({ id: "8" }),
-  useLocation: () => ({ pathname: "/qualityControls/8" }),
+  useParams: () => ({ id: "8", version: "1" }),
+  useLocation: () => ({ pathname: "/qualityControls/8/version/1" }),
 }));
 
 const renderOpts = { messages };

package/src/components/qualityControls/__tests__/QualityControls.spec.js

@@ -34,7 +34,7 @@ const searchProps = {
   searchMust: "",
   hiddenFilters: "",
   searchData: {
-    data: [qualityControlData({ status: "published" })],
+    data: [qualityControlData({ id: 1, status: "published" })],
     actions: { execute: true },
   },
   defaultFilters: { status: "published" },
@@ -85,19 +85,19 @@ describe("<QualityControls />", () => {
     ).toBeEnabled();
 
     expect(
-      container.querySelector("#row-checkbox-8").parentElement
+      container.querySelector("#row-checkbox-1").parentElement
     ).not.toHaveClass("checked");
 
     userEvent.click(container.querySelector("#selectQualityControl"));
 
     expect(
-      container.querySelector("#row-checkbox-8").parentElement
+      container.querySelector("#row-checkbox-1").parentElement
     ).toHaveClass("checked");
 
-    userEvent.click(container.querySelector("#row-checkbox-8"));
+    userEvent.click(container.querySelector("#row-checkbox-1"));
 
     expect(
-      container.querySelector("#row-checkbox-8").parentElement
+      container.querySelector("#row-checkbox-1").parentElement
     ).not.toHaveClass("checked");
 
     userEvent.click(container.querySelector("#execute_checkbox"));
@@ -106,7 +106,7 @@ describe("<QualityControls />", () => {
       filter: "for_execution",
     });
 
-    expect(container.querySelector("#row-checkbox-8")).not.toBeInTheDocument();
+    expect(container.querySelector("#row-checkbox-1")).not.toBeInTheDocument();
   });
 
   it("submit execution with search", async () => {
@@ -177,7 +177,7 @@ describe("<QualityControls />", () => {
     userEvent.click(container.querySelector("#selectQualityControl"));
 
     expect(
-      container.querySelector("#row-checkbox-8").parentElement
+      container.querySelector("#row-checkbox-1").parentElement
     ).toHaveClass("checked");
 
     userEvent.click(getByRole("button", { name: /Execute quality control/i }));
@@ -195,7 +195,7 @@ describe("<QualityControls />", () => {
         df_type: "template1",
         dynamic_content: {},
       },
-      ids: [13],
+      ids: [1],
     });
   });
 });

package/src/components/qualityControls/__tests__/QualityControlsTable.spec.js

@@ -5,7 +5,10 @@ import SearchContext from "@truedat/core/search/SearchContext";
 import QualityControlsTable from "../QualityControlsTable";
 import { qualityControlData } from "./__fixtures__/qualityControlHelper";
 
-const data = [qualityControlData(), qualityControlData({ id: 9, name: "Foo" })];
+const data = [
+  qualityControlData(),
+  qualityControlData({ id: 9, name: "Foo", quality_control_id: 9 }),
+];
 
 const searchProps = {
   sortColumn: "updated_at",

package/src/components/qualityControls/__tests__/__fixtures__/qualityControlHelper.js

@@ -25,6 +25,7 @@ const qualityControl = {
   updated_at: "2024-11-28T12:14:57.004822Z",
   status: "draft",
   version: 1,
+  quality_control_id: 8,
   versions: [
     {
       name: "tests v1",
@@ -33,6 +34,7 @@ const qualityControl = {
       updated_at: "2024-11-28T17:03:22.037798Z",
       df_type: "template1",
       queries: null,
+      quality_control_id: 8,
       control_properties: {
         resource: {
           id: 11859650,
@@ -138,10 +140,7 @@ const qualityControl = {
         },
       },
       version_id: 1,
-      score_criteria: {
-        goal: 20,
-        minimum: 10,
-      },
+      score_criteria: { goal: 20, minimum: 10 },
     },
     {
       name: "test",
@@ -150,6 +149,7 @@ const qualityControl = {
       updated_at: "2024-11-28T17:03:22.040875Z",
       df_type: "template1",
       queries: null,
+      quality_control_id: 8,
       control_properties: {
         errors_resource: {
           id: 11859650,
@@ -164,10 +164,7 @@ const qualityControl = {
         },
       },
       version_id: 2,
-      score_criteria: {
-        maximum: 20,
-        goal: 10,
-      },
+      score_criteria: { maximum: 20, goal: 10 },
     },
   ],
   domain_ids: [2],
@@ -269,9 +266,17 @@ const qualityControl = {
     },
   },
   version_id: 13,
-  score_criteria: {
-    goal: 20,
-    minimum: 10,
+  score_criteria: { goal: 20, minimum: 10 },
+  latest_score: {
+    executed_at: "2025-03-25T05:34:21.438113Z",
+    ratio_content: {
+      total_count: 100,
+      validation_count: 100,
+    },
+    result: 100,
+    result_message: "meets_goal",
+    status: "succeeded",
+    type: "ratio",
   },
 };
 

package/src/components/qualityControls/__tests__/__snapshots__/QualityBadge.spec.js.snap

@@ -9,3 +9,35 @@ exports[`<QualityBadge /> matches the latest snapshot 1`] = `
   50%
 </div>
 `;
+
+exports[`<QualityBadgeForSearch /> matches the latest snapshot for deviation 1`] = `
+<div>
+  <i
+    aria-hidden="true"
+    class="yellow circle icon"
+  />
+  100%
+</div>
+`;
+
+exports[`<QualityBadgeForSearch /> matches the latest snapshot for error_count 1`] = `
+<div>
+  <i
+    aria-hidden="true"
+    class="red circle icon"
+  />
+  200
+</div>
+`;
+
+exports[`<QualityBadgeForSearch /> matches the latest snapshot for percentage 1`] = `
+<div>
+  <i
+    aria-hidden="true"
+    class="green circle icon"
+  />
+  100%
+</div>
+`;
+
+exports[`<QualityBadgeForSearch /> show no executed 1`] = `<div />`;

package/src/components/qualityControls/__tests__/__snapshots__/QualityControlActions.spec.js.snap

@@ -34,7 +34,6 @@ exports[`<QualityControlActions /> matches the latest snapshot with actions for
       >
         <div
           aria-checked="false"
-          aria-disabled="false"
           aria-selected="true"
           class="selected item"
           role="option"
@@ -52,10 +51,9 @@ exports[`<QualityControlActions /> matches the latest snapshot with actions for
         </div>
         <a
           aria-checked="false"
-          aria-disabled="false"
           aria-selected="false"
           class="item"
-          href="/qualityControls/8/new_draft"
+          href="/qualityControls/8/version/1/new_draft"
           role="option"
           style="pointer-events: all;"
         >

package/src/components/qualityControls/__tests__/__snapshots__/QualityControlHeader.spec.js.snap

@@ -112,7 +112,7 @@ exports[`<QualityControlHeader /> matches the latest snapshot with control quali
                 aria-checked="false"
                 aria-selected="false"
                 class="item"
-                href="/qualityControls/8/new_draft"
+                href="/qualityControls/8/version/1/new_draft"
                 role="option"
                 style="pointer-events: all;"
               >
@@ -135,6 +135,15 @@ exports[`<QualityControlHeader /> matches the latest snapshot with control quali
                 />
                 Disable
               </button>
+              <button
+                class="ui button"
+              >
+                <i
+                  aria-hidden="true"
+                  class="trash alternate outline icon"
+                />
+                quality_controls.actions.delete
+              </button>
             </div>
           </div>
         </div>
@@ -150,19 +159,19 @@ exports[`<QualityControlHeader /> matches the latest snapshot with control quali
     >
       <a
         class="item"
-        href="/qualityControls/8"
+        href="/qualityControls/8/version/1"
       >
         Detail
       </a>
       <a
         class="item"
-        href="/qualityControls/8/history"
+        href="/qualityControls/8/version/1/history"
       >
         History
       </a>
       <a
         class="item"
-        href="/qualityControls/8/scores"
+        href="/qualityControls/8/version/1/scores"
       >
         Scores
       </a>

package/src/components/qualityControls/__tests__/__snapshots__/QualityControlHistory.spec.js.snap

@@ -37,7 +37,11 @@ exports[`<QualityControlsHistory /> matches the latest snapshot 1`] = `
         <td
           class=""
         >
-          tests v1
+          <a
+            href="/qualityControls/8/version/1"
+          >
+            tests v1
+          </a>
         </td>
         <td
           class=""
@@ -56,7 +60,11 @@ exports[`<QualityControlsHistory /> matches the latest snapshot 1`] = `
         <td
           class=""
         >
-          test
+          <a
+            href="/qualityControls/8/version/2"
+          >
+            test
+          </a>
         </td>
         <td
           class=""

package/src/components/qualityControls/__tests__/__snapshots__/QualityControlRow.spec.js.snap

@@ -11,7 +11,7 @@ exports[`<QualityControlRow /> matches the latest snapshot 1`] = `
           class=""
         >
           <a
-            href="/qualityControls/8"
+            href="/qualityControls/8/version/1"
           >
             test
           </a>
@@ -31,6 +31,15 @@ exports[`<QualityControlRow /> matches the latest snapshot 1`] = `
         >
           Draft
         </td>
+        <td
+          class=""
+        >
+          <i
+            aria-hidden="true"
+            class="green circle icon"
+          />
+          100%
+        </td>
         <td
           class="center aligned"
         >
@@ -77,7 +86,7 @@ exports[`<QualityControlRow /> withCheck set to true 1`] = `
           class=""
         >
           <a
-            href="/qualityControls/8"
+            href="/qualityControls/8/version/1"
           >
             test
           </a>
@@ -97,6 +106,15 @@ exports[`<QualityControlRow /> withCheck set to true 1`] = `
         >
           Draft
         </td>
+        <td
+          class=""
+        >
+          <i
+            aria-hidden="true"
+            class="green circle icon"
+          />
+          100%
+        </td>
         <td
           class="center aligned"
         >

package/src/components/qualityControls/__tests__/__snapshots__/QualityControlScores.spec.js.snap

@@ -52,7 +52,7 @@ exports[`<QualityControlScores /> matches the latest snapshot 1`] = `
         >
           <a
             class="ui active ribbon label"
-            href="/qualityControls/8/history"
+            href="/qualityControls/8/version/1/history"
           >
             Version: 1
           </a>
@@ -96,7 +96,7 @@ exports[`<QualityControlScores /> matches the latest snapshot 1`] = `
         <td
           class=""
         >
-          Versioned
+          Published
         </td>
         <td
           class=""
@@ -149,7 +149,7 @@ exports[`<QualityControlScores /> matches the latest snapshot 1`] = `
         <td
           class=""
         >
-          Versioned
+          Published
         </td>
         <td
           class=""

package/src/components/qualityControls/__tests__/__snapshots__/QualityControlTabs.spec.js.snap

@@ -7,19 +7,19 @@ exports[`<QualityControlTabs /> matches the latest snapshot 1`] = `
   >
     <a
       class="active item"
-      href="/qualityControls/8"
+      href="/qualityControls/8/version/1"
     >
       Detail
     </a>
     <a
       class="item"
-      href="/qualityControls/8/history"
+      href="/qualityControls/8/version/1/history"
     >
       History
     </a>
     <a
       class="item"
-      href="/qualityControls/8/scores"
+      href="/qualityControls/8/version/1/scores"
     >
       Scores
     </a>