@truedat/qx 7.13.9 → 7.14.0

package/src/components/dataViews/__tests__/DataViews.spec.js

@@ -2,7 +2,10 @@ import React from "react";
 import { render, waitForLoad } from "@truedat/test/render";
 import userEvent from "@testing-library/user-event";
 import DataViews from "../DataViews";
-import { useDataViews, useDataViewDelete } from "@truedat/qx/hooks/useDataViews";
+import {
+  useDataViews,
+  useDataViewDelete,
+} from "@truedat/qx/hooks/useDataViews";
 
 const mockFormatMessage = jest.fn(({ id }) => id);
 
@@ -23,7 +26,6 @@ jest.mock("@truedat/qx/hooks/useDataViews", () => ({
   useDataViewDelete: jest.fn(),
 }));
 
-
 describe("<DataViews />", () => {
   beforeEach(() => {
     useDataViewDelete.mockReturnValue({
@@ -45,10 +47,14 @@ describe("<DataViews />", () => {
     const rendered = render(<DataViews />);
     await waitForLoad(rendered);
 
-    expect(rendered.getByRole("heading", { name: /dataViews.header/i })).toBeInTheDocument();
+    expect(
+      rendered.getByRole("heading", { name: /dataViews.header/i })
+    ).toBeInTheDocument();
     expect(rendered.getByText(/dataViews.empty_list/i)).toBeInTheDocument();
 
-    expect(rendered.getByRole("button", { name: /dataViews.action.new/i })).toBeInTheDocument();
+    expect(
+      rendered.getByRole("button", { name: /dataViews.action.new/i })
+    ).toBeInTheDocument();
     expect(rendered.container).toMatchSnapshot();
   });
 
@@ -56,8 +62,18 @@ describe("<DataViews />", () => {
     useDataViews.mockReturnValue({
       data: {
         data: [
-          { id: 2, name: "Inventory", description: "Stock levels", mode: "advanced" },
-          { id: 1, name: "Users Spain", description: "Active users in Spain", mode: "guided" },
+          {
+            id: 2,
+            name: "Inventory",
+            description: "Stock levels",
+            mode: "advanced",
+          },
+          {
+            id: 1,
+            name: "Users Spain",
+            description: "Active users in Spain",
+            mode: "guided",
+          },
         ],
       },
       loading: false,
@@ -70,16 +86,21 @@ describe("<DataViews />", () => {
     expect(rendered.getByText("Users Spain")).toBeInTheDocument();
     expect(rendered.getByText("Inventory")).toBeInTheDocument();
 
-  
-    const guidedIcon = rendered.container.querySelector(".dataViews\\.mode\\.icon\\.guided.icon");
-    const advancedIcon = rendered.container.querySelector(".dataViews\\.mode\\.icon\\.advanced.icon");
+    const guidedIcon = rendered.container.querySelector(
+      ".dataViews\\.mode\\.icon\\.guided.icon"
+    );
+    const advancedIcon = rendered.container.querySelector(
+      ".dataViews\\.mode\\.icon\\.advanced.icon"
+    );
     expect(guidedIcon).toBeInTheDocument();
     expect(advancedIcon).toBeInTheDocument();
 
-    const dataViewLinks = rendered.container.querySelectorAll('a[href^="/dataviews/"]');
+    const dataViewLinks = rendered.container.querySelectorAll(
+      'a[href^="/dataviews/"]'
+    );
     expect(dataViewLinks.length).toBe(3);
-    
-    const hrefs = Array.from(dataViewLinks).map(a => a.getAttribute("href"));
+
+    const hrefs = Array.from(dataViewLinks).map((a) => a.getAttribute("href"));
     expect(hrefs).toContain("/dataviews/1");
     expect(hrefs).toContain("/dataviews/2");
     expect(rendered.container).toMatchSnapshot();
@@ -90,9 +111,24 @@ describe("<DataViews />", () => {
     useDataViews.mockReturnValue({
       data: {
         data: [
-          { id: 1, name: "Revenue Report", description: "Monthly KPIs", mode: "advanced" },
-          { id: 2, name: "Users", description: "Active users in Spain", mode: "guided" },
-          { id: 3, name: "Inventory", description: "Stock and SKUs", mode: "advanced" },
+          {
+            id: 1,
+            name: "Revenue Report",
+            description: "Monthly KPIs",
+            mode: "advanced",
+          },
+          {
+            id: 2,
+            name: "Users",
+            description: "Active users in Spain",
+            mode: "guided",
+          },
+          {
+            id: 3,
+            name: "Inventory",
+            description: "Stock and SKUs",
+            mode: "advanced",
+          },
         ],
       },
       loading: false,
@@ -117,7 +153,9 @@ describe("<DataViews />", () => {
 
   it("shows untitled message when name is missing", async () => {
     useDataViews.mockReturnValue({
-      data: { data: [{ id: 1, name: "", description: "desc", mode: "guided" }] },
+      data: {
+        data: [{ id: 1, name: "", description: "desc", mode: "guided" }],
+      },
       loading: false,
     });
 
@@ -135,7 +173,9 @@ describe("<DataViews />", () => {
 
     const rendered = render(<DataViews />);
 
-    const newBtn = rendered.getByRole("button", { name: /dataViews.action.new/i });
+    const newBtn = rendered.getByRole("button", {
+      name: /dataViews.action.new/i,
+    });
     expect(newBtn).toBeInTheDocument();
     expect(newBtn.getAttribute("href")).toBe("/dataviews/new");
   });

package/src/components/dataViews/__tests__/SimpleDataViewEditor.spec.js

@@ -6,8 +6,8 @@ import SimpleDataViewEditor from "../simpleForm/SimpleDataViewEditor";
 // Keep intl messages simple (just echo the id)
 const mockFormatMessage = jest.fn(({ id }) => id);
 jest.mock("react-intl", () => ({
-    ...jest.requireActual("react-intl"),
-    useIntl: () => ({ formatMessage: mockFormatMessage }),
+  ...jest.requireActual("react-intl"),
+  useIntl: () => ({ formatMessage: mockFormatMessage }),
 }));
 
 // We DO NOT mock child forms; they will render as-is.
@@ -15,150 +15,149 @@ jest.mock("react-intl", () => ({
 
 // Helpers
 const baseSelected = {
-    id: undefined,
-    name: "",
-    description: "",
-    mode: "guided",
-    queryables: [{ alias: "a", type: "from", properties: { resource: 1 } }],
-    select: { type: "select" },
+  id: undefined,
+  name: "",
+  description: "",
+  mode: "guided",
+  queryables: [{ alias: "a", type: "from", properties: { resource: 1 } }],
+  select: { type: "select" },
 };
 const baseContext = {
-    dataViews: [],
-    referenceDatasets: [],
-    functions: [],
-    currentDataViewId: undefined,
+  dataViews: [],
+  referenceDatasets: [],
+  functions: [],
+  currentDataViewId: undefined,
 };
 
 describe("<SimpleDataViewEditor /> (own rendering only, no child mocks)", () => {
-    beforeEach(() => {
-        jest.clearAllMocks();
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it("returns null when selectedDataView is not provided", async () => {
+    const rendered = render(
+      <SimpleDataViewEditor
+        selectedDataView={undefined}
+        context={baseContext}
+        onSubmit={jest.fn()}
+        onCancel={jest.fn()}
+        isSubmitting={false}
+        mode="guided"
+      />
+    );
+    await waitForLoad(rendered);
+    expect(rendered.container).toBeEmptyDOMElement();
+  });
+
+  it("renders step headers and the forward action on initial step", async () => {
+    const rendered = render(
+      <SimpleDataViewEditor
+        selectedDataView={{ ...baseSelected, source_id: 10 }}
+        context={baseContext}
+        onSubmit={jest.fn()}
+        onCancel={jest.fn()}
+        isSubmitting={false}
+        mode="guided"
+      />
+    );
+    await waitForLoad(rendered);
+
+    // Step titles (they come from this component via formatMessage)
+    expect(
+      rendered.getByText("dataViews.form.step.information.title")
+    ).toBeInTheDocument();
+    expect(
+      rendered.getByText("dataViews.form.step.dataset.title")
+    ).toBeInTheDocument();
+    expect(
+      rendered.getByText("dataViews.form.step.aggregations.title")
+    ).toBeInTheDocument();
+    expect(
+      rendered.getByText("dataViews.form.step.select.title")
+    ).toBeInTheDocument();
+
+    // Initial actions: Cancel exists; Forward exists; Back should not (step 0)
+    expect(
+      screen.getByRole("button", { name: /dataViews\.action\.forward/i })
+    ).toBeInTheDocument();
+    expect(
+      screen.queryByRole("button", { name: /dataViews\.action\.back/i })
+    ).not.toBeInTheDocument();
+
+    // Save button only appears on last step → not present yet
+    expect(
+      screen.queryByRole("button", { name: /actions\.save/i })
+    ).not.toBeInTheDocument();
+  });
+
+  it("disables the forward action (and keeps back hidden) when isSubmitting is true on step 0", async () => {
+    const rendered = render(
+      <SimpleDataViewEditor
+        selectedDataView={{ ...baseSelected, source_id: 10 }}
+        context={baseContext}
+        onSubmit={jest.fn()}
+        onCancel={jest.fn()}
+        isSubmitting={true}
+        mode="guided"
+      />
+    );
+    await waitForLoad(rendered);
+
+    const forward = screen.getByRole("button", {
+      name: /dataViews\.action\.forward/i,
     });
-
-    it("returns null when selectedDataView is not provided", async () => {
-        const rendered = render(
-            <SimpleDataViewEditor
-                selectedDataView={undefined}
-                context={baseContext}
-                onSubmit={jest.fn()}
-                onCancel={jest.fn()}
-                isSubmitting={false}
-                mode="guided"
-            />
-        );
-        await waitForLoad(rendered);
-        expect(rendered.container).toBeEmptyDOMElement();
-    });
-
-    it("renders step headers and the forward action on initial step", async () => {
-        const rendered = render(
-            <SimpleDataViewEditor
-                selectedDataView={{ ...baseSelected, source_id: 10 }}
-                context={baseContext}
-                onSubmit={jest.fn()}
-                onCancel={jest.fn()}
-                isSubmitting={false}
-                mode="guided"
-            />
-        );
-        await waitForLoad(rendered);
-
-        // Step titles (they come from this component via formatMessage)
-        expect(
-            rendered.getByText("dataViews.form.step.information.title")
-        ).toBeInTheDocument();
-        expect(
-            rendered.getByText("dataViews.form.step.dataset.title")
-        ).toBeInTheDocument();
-        expect(
-            rendered.getByText("dataViews.form.step.aggregations.title")
-        ).toBeInTheDocument();
-        expect(
-            rendered.getByText("dataViews.form.step.select.title")
-        ).toBeInTheDocument();
-
-        // Initial actions: Cancel exists; Forward exists; Back should not (step 0)
-        expect(
-            screen.getByRole("button", { name: /dataViews\.action\.forward/i })
-        ).toBeInTheDocument();
-        expect(
-            screen.queryByRole("button", { name: /dataViews\.action\.back/i })
-        ).not.toBeInTheDocument();
-
-        // Save button only appears on last step → not present yet
-        expect(
-            screen.queryByRole("button", { name: /actions\.save/i })
-        ).not.toBeInTheDocument();
-    });
-
-
-    it("disables the forward action (and keeps back hidden) when isSubmitting is true on step 0", async () => {
-        const rendered = render(
-            <SimpleDataViewEditor
-                selectedDataView={{ ...baseSelected, source_id: 10 }}
-                context={baseContext}
-                onSubmit={jest.fn()}
-                onCancel={jest.fn()}
-                isSubmitting={true}
-                mode="guided"
-            />
-        );
-        await waitForLoad(rendered);
-
-        const forward = screen.getByRole("button", {
-            name: /dataViews\.action\.forward/i,
-        });
-        expect(forward).toBeDisabled();
-
-        expect(
-            screen.queryByRole("button", { name: /dataViews\.action\.back/i })
-        ).not.toBeInTheDocument();
-    });
-
-    it("renders Cancel and Forward buttons consistently on initial render", async () => {
-        const rendered = render(
-            <SimpleDataViewEditor
-                selectedDataView={{ ...baseSelected, source_id: 123 }}
-                context={baseContext}
-                onSubmit={jest.fn()}
-                onCancel={jest.fn()}
-                isSubmitting={false}
-                mode="guided"
-            />
-        );
-        await waitForLoad(rendered);
-
-        expect(rendered.getByText(/cancel/i)).toBeInTheDocument();
-
-        const forward = rendered.getByRole("button", {
-            name: /dataViews\.action\.forward/i,
-        });
-        expect(forward).toBeInTheDocument();
-    });
-
-    it("renders step descriptions (from this component) regardless of child internals", async () => {
-        const rendered = render(
-            <SimpleDataViewEditor
-                selectedDataView={{ ...baseSelected, source_id: 10 }}
-                context={baseContext}
-                onSubmit={jest.fn()}
-                onCancel={jest.fn()}
-                isSubmitting={false}
-                mode="guided"
-            />
-        );
-        await waitForLoad(rendered);
-
-        expect(
-            rendered.getByText("dataViews.form.step.information.description")
-        ).toBeInTheDocument();
-        expect(
-            rendered.getByText("dataViews.form.step.dataset.description")
-        ).toBeInTheDocument();
-        expect(
-            rendered.getByText("dataViews.form.step.aggregations.description")
-        ).toBeInTheDocument();
-        expect(
-            rendered.getByText("dataViews.form.step.select.description")
-        ).toBeInTheDocument();
+    expect(forward).toBeDisabled();
+
+    expect(
+      screen.queryByRole("button", { name: /dataViews\.action\.back/i })
+    ).not.toBeInTheDocument();
+  });
+
+  it("renders Cancel and Forward buttons consistently on initial render", async () => {
+    const rendered = render(
+      <SimpleDataViewEditor
+        selectedDataView={{ ...baseSelected, source_id: 123 }}
+        context={baseContext}
+        onSubmit={jest.fn()}
+        onCancel={jest.fn()}
+        isSubmitting={false}
+        mode="guided"
+      />
+    );
+    await waitForLoad(rendered);
+
+    expect(rendered.getByText(/cancel/i)).toBeInTheDocument();
+
+    const forward = rendered.getByRole("button", {
+      name: /dataViews\.action\.forward/i,
     });
+    expect(forward).toBeInTheDocument();
+  });
+
+  it("renders step descriptions (from this component) regardless of child internals", async () => {
+    const rendered = render(
+      <SimpleDataViewEditor
+        selectedDataView={{ ...baseSelected, source_id: 10 }}
+        context={baseContext}
+        onSubmit={jest.fn()}
+        onCancel={jest.fn()}
+        isSubmitting={false}
+        mode="guided"
+      />
+    );
+    await waitForLoad(rendered);
+
+    expect(
+      rendered.getByText("dataViews.form.step.information.description")
+    ).toBeInTheDocument();
+    expect(
+      rendered.getByText("dataViews.form.step.dataset.description")
+    ).toBeInTheDocument();
+    expect(
+      rendered.getByText("dataViews.form.step.aggregations.description")
+    ).toBeInTheDocument();
+    expect(
+      rendered.getByText("dataViews.form.step.select.description")
+    ).toBeInTheDocument();
+  });
 });