@truedat/dq 7.5.7 → 7.5.10

package/src/components/__tests__/RuleCrumbs.spec.js

@@ -1,10 +1,9 @@
-import React from "react";
-import { useParams } from "react-router-dom";
-import { shallow } from "enzyme";
+import { useParams } from "react-router";
+import { render, waitForLoad } from "@truedat/test/render";
 import { RuleCrumbs } from "../RuleCrumbs";
 
-jest.mock("react-router-dom", () => ({
-  ...jest.requireActual("react-router-dom"),
+jest.mock("react-router", () => ({
+  ...jest.requireActual("react-router"),
   useParams: jest.fn(),
 }));
 
@@ -13,18 +12,19 @@ afterEach(() => {
 });
 
 describe("<RuleCrumbs />", () => {
-  it("matches the latest snapshot", () => {
+  it("matches the latest snapshot", async () => {
     const props = {
       rule: { id: 1, name: "foo" },
       ruleImplementation: { id: 2, implementation_key: "ri" },
     };
     useParams.mockImplementation(() => ({}));
 
-    const wrapper = shallow(<RuleCrumbs {...props} />);
-    expect(wrapper).toMatchSnapshot();
+    const rendered = render(<RuleCrumbs {...props} />);
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
-  it("matches a snapshot with resultId", () => {
+  it("matches a snapshot with resultId", async () => {
     const props = {
       rule: { id: 1, name: "foo" },
       ruleImplementation: {
@@ -48,7 +48,8 @@ describe("<RuleCrumbs />", () => {
       rule_result_id: 1000,
     }));
 
-    const wrapper = shallow(<RuleCrumbs {...props} />);
-    expect(wrapper).toMatchSnapshot();
+    const rendered = render(<RuleCrumbs {...props} />);
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 });

package/src/components/__tests__/RuleEventDecorator.spec.js

@@ -1,4 +1,3 @@
-import React from "react";
 import { render } from "@truedat/test/render";
 import { RuleEventDecorator } from "../RuleEventDecorator";
 

package/src/components/__tests__/RuleEventRow.spec.js

@@ -1,4 +1,3 @@
-import React from "react";
 import { render } from "@truedat/test/render";
 import { RuleEventRow } from "../RuleEventRow";
 

package/src/components/__tests__/RuleEvents.spec.js

@@ -1,4 +1,3 @@
-import React from "react";
 import { render } from "@truedat/test/render";
 import { RuleEvents } from "../RuleEvents";
 import { getParsedEvents } from "../../selectors/getParsedEvents";

package/src/components/__tests__/RuleForm.spec.js

@@ -1,10 +1,7 @@
-import React from "react";
-import { waitFor } from "@testing-library/react";
-import { render } from "@truedat/test/render";
 import userEvent from "@testing-library/user-event";
+import { render, waitForLoad } from "@truedat/test/render";
 import { domainsMock, multipleTemplatesMock } from "@truedat/test/mocks";
 import RuleForm from "../RuleForm";
-import en from "../../messages/en";
 import { globalState } from "./__fixtures__/RuleForm";
 
 const data = {
@@ -63,30 +60,6 @@ const rule = {
   current_business_concept_version: { name: "My Concept" },
 };
 
-const messages = {
-  en: {
-    ...en,
-    "concepts.status.undefined": "undefined",
-    "search.save_filters": "save filters",
-    "search.clear_filters": "clear filters",
-    "search.applied_filters": "apply filters",
-    "search.placeholder": "Search concepts...",
-    "actions.save": "Save",
-    "actions.cancel": "Cancel",
-    "actions.delete": "Delete",
-    "template.selector.placeholder": "Select a template...",
-    "domain.selector.placeholder": "Select a domain...",
-    "domain.selector.label": "Domain",
-    loading: "loading...",
-    "concepts.props.status": "Status",
-    "concepts.props.domain": "Domain",
-    "concepts.props.name": "Term",
-    "template.form.validation.empty_required": "Empty required field",
-    "template.selector.label": "Template",
-    "concepts.search.results.empty": "No concepts found",
-  },
-};
-
 const state = {
   domains: [{ id: 1, name: "domain1" }],
 };
@@ -94,56 +67,44 @@ const state = {
 const renderOpts = {
   mocks: [
     domainsMock({ action: "manageQualityRule" }),
+    multipleTemplatesMock({ scope: "dq", domainIds: null }),
     multipleTemplatesMock({ scope: "dq", domainIds: [1] }),
+    multipleTemplatesMock({ scope: "dq", domainIds: [2] }),
   ],
   state,
-  messages,
-  fallback: "lazy",
 };
 
 describe("<RuleForm />", () => {
   it("matches the latest snapshot", async () => {
     const props = { onSubmit: jest.fn() };
-    const { container, findByText, queryByText } = render(
-      <RuleForm {...props} />,
-      renderOpts
-    );
-    await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
-    await findByText(/draft/i);
-    expect(container).toMatchSnapshot();
+    const rendered = render(<RuleForm {...props} />, renderOpts);
+    await waitForLoad(rendered);
+    await rendered.findByText(/draft/i);
+    expect(rendered.container).toMatchSnapshot();
   });
 
   it("matches the latest snapshot (edit mode)", async () => {
     const props = { onSubmit: jest.fn(), editMode: true };
-    const { container, queryByText } = render(<RuleForm {...props} />, {
+    const rendered = render(<RuleForm {...props} />, {
       ...renderOpts,
       state: { ...state, rule },
     });
-    await waitFor(() => expect(queryByText(/lazy/i)).not.toBeInTheDocument());
-    await waitFor(() =>
-      expect(queryByText(/loading/i)).not.toBeInTheDocument()
-    );
-    await waitFor(() => {
-      expect(container.querySelector(".loading")).toBeNull();
-    });
-
-    expect(container).toMatchSnapshot();
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
   it("enables save button after name and domain are specified", async () => {
     const props = { onSubmit: jest.fn() };
-    const { getByRole, findByText } = render(
-      <RuleForm {...props} />,
-      renderOpts
+    const rendered = render(<RuleForm {...props} />, renderOpts);
+    await waitForLoad(rendered);
+    expect(rendered.getByRole("button", { name: /save/i })).toBeDisabled();
+    const user = userEvent.setup({ delay: null });
+    await user.click(await rendered.findByText(/bardomain/i));
+    await user.type(
+      rendered.getByRole("textbox", { name: /rule.props.name.placeholder/i }),
+      "rule1"
     );
-    await waitFor(() =>
-      expect(getByRole("button", { name: /save/i })).toBeDisabled()
-    );
-    userEvent.click(await findByText("barDomain"));
-    userEvent.type(getByRole("textbox", { name: /rule name/i }), "rule1");
-    await waitFor(() => {
-      expect(getByRole("button", { name: /save/i })).not.toBeDisabled();
-    });
+    expect(rendered.getByRole("button", { name: /save/i })).not.toBeDisabled();
   });
 
   it("submit rule data", async () => {
@@ -155,25 +116,21 @@ describe("<RuleForm />", () => {
         multipleTemplatesMock({ scope: "dq", domainIds: [1] }),
       ],
       state: globalState,
-      fallback: "lazy",
     };
 
-    const { getByRole, findByText } = render(
-      <RuleForm onSubmit={onSubmit} />,
-      renderOpts
-    );
-    await waitFor(() =>
-      expect(getByRole("button", { name: /save/i })).toBeDisabled()
-    );
-    userEvent.click(await findByText("barDomain"));
-    const ruleNameTextbox = getByRole("textbox", { name: /rule name/i });
-    userEvent.paste(ruleNameTextbox, "rule1");
-    expect(ruleNameTextbox).toHaveValue("rule1");
-    await waitFor(() => {
-      expect(getByRole("button", { name: /save/i })).not.toBeDisabled();
+    const rendered = render(<RuleForm onSubmit={onSubmit} />, renderOpts);
+    await waitForLoad(rendered);
+    expect(rendered.getByRole("button", { name: /save/i })).toBeDisabled();
+    const user = userEvent.setup({ delay: null });
+    await user.click(await rendered.findByText(/bardomain/i));
+    const ruleNameTextbox = rendered.getByRole("textbox", {
+      name: /rule.props.name.placeholder/i,
     });
+    await user.type(ruleNameTextbox, "rule1");
+    expect(ruleNameTextbox).toHaveValue("rule1");
+    expect(rendered.getByRole("button", { name: /save/i })).not.toBeDisabled();
 
-    userEvent.click(await getByRole("button", { name: /save/i }));
+    await user.click(rendered.getByRole("button", { name: /save/i }));
 
     expect(onSubmit).toHaveBeenCalledWith({
       ids: {},

package/src/components/__tests__/RuleFormImplementations.spec.js

@@ -1,12 +1,6 @@
-import React from "react";
-import { shallow } from "enzyme";
-import { intl } from "@truedat/test/intl-stub";
+import { render, waitForLoad } from "@truedat/test/render";
 import { RuleFormImplementations } from "../RuleFormImplementations";
 
-// workaround for enzyme issue with React.useContext
-// see https://github.com/airbnb/enzyme/issues/2176#issuecomment-532361526
-jest.spyOn(React, "useContext").mockImplementation(() => intl);
-
 describe("<RuleFormImplementations />", () => {
   const rule = { id: 1, name: "rule name" };
   const updateDeletionQuery = jest.fn();
@@ -16,20 +10,25 @@ describe("<RuleFormImplementations />", () => {
     deletedRender: false,
   };
 
-  it("matches the latest snapshot", () => {
-    const wrapper = shallow(<RuleFormImplementations {...props} />);
-    expect(wrapper).toMatchSnapshot();
+  it("matches the latest snapshot", async () => {
+    const rendered = render(<RuleFormImplementations {...props} />);
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
-  it("renders null when rule is empty", () => {
-    const wrapper = shallow(
+  it("renders null when rule is empty", async () => {
+    const rendered = render(
       <RuleFormImplementations {...{ ...props, rule: {} }} />
     );
-    expect(wrapper.type()).toEqual(null);
+    await waitForLoad(rendered);
+    expect(rendered.container.firstChild).toBeNull();
   });
 
-  it("renders RuleFormImplementations when rule is not empty", () => {
-    const wrapper = shallow(<RuleFormImplementations {...props} />);
-    expect(wrapper.find("Connect(RuleImplementationsTable)").length).toBe(1);
+  it("renders RuleFormImplementations when rule is not empty", async () => {
+    const rendered = render(<RuleFormImplementations {...props} />);
+    await waitForLoad(rendered);
+    expect(
+      rendered.container.querySelector(".implementation-actions")
+    ).toBeInTheDocument();
   });
 });

package/src/components/__tests__/RuleImplementation.spec.js

@@ -1,5 +1,4 @@
-import React from "react";
-import { render } from "@truedat/test/render";
+import { render, waitForLoad } from "@truedat/test/render";
 import RuleImplementation from "../RuleImplementation";
 
 const state = {
@@ -37,38 +36,32 @@ const stateNoExecutePermission = {
   },
 };
 
-const renderOptsNoExecutePermission = {
-  state: stateNoExecutePermission,
-};
-
-const renderOptsExecutePermission = {
-  state: stateExecutePermission,
-};
-
 describe("<RuleImplementation />", () => {
-  it("matches the latest snapshot", () => {
-    const { container } = render(
-      <RuleImplementation />,
-      renderOptsExecutePermission
-    );
-    expect(container).toMatchSnapshot();
+  it("matches the latest snapshot", async () => {
+    const rendered = render(<RuleImplementation />, {
+      state: stateExecutePermission,
+    });
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
-  it("presence of execute permissions enables the execute button", () => {
-    const { queryByText } = render(
-      <RuleImplementation />,
-      renderOptsExecutePermission
-    );
-    const button = queryByText(/execute/i);
-    expect(button).toBeInTheDocument();
+  it("presence of execute permissions enables the execute button", async () => {
+    const rendered = render(<RuleImplementation />, {
+      state: stateExecutePermission,
+    });
+    await waitForLoad(rendered);
+    expect(
+      rendered.getByText(/implementations.actions.do_execution/i)
+    ).toBeInTheDocument();
   });
 
-  it("lack of execute permissions disables the execute button", () => {
-    const { queryByText } = render(
-      <RuleImplementation />,
-      renderOptsNoExecutePermission
-    );
-    const button = queryByText(/execute/i);
-    expect(button).not.toBeInTheDocument();
+  it("lack of execute permissions disables the execute button", async () => {
+    const rendered = render(<RuleImplementation />, {
+      state: stateNoExecutePermission,
+    });
+    await waitForLoad(rendered);
+    expect(
+      rendered.queryByText(/implementations.actions.do_execution/i)
+    ).not.toBeInTheDocument();
   });
 });

package/src/components/__tests__/RuleImplementationEvents.spec.js

@@ -1,4 +1,3 @@
-import React from "react";
 import { render } from "@truedat/test/render";
 import { RuleImplementationEvents } from "../RuleImplementationEvents";
 

package/src/components/__tests__/RuleImplementationHistory.spec.js

@@ -1,31 +1,30 @@
-import React from "react";
 import { render } from "@truedat/test/render";
 import { RuleImplementationHistory } from "../RuleImplementationHistory";
 
 describe("<RuleImplementationHistory", () => {
-  const implementation_id = 23;
+  const implementation_id = "23";
   const props = {
     implementation: {
       id: implementation_id,
       versions: [
         {
-          id: 34,
+          id: "34",
           implementation_key: "some implementation key 34",
-          version: 3,
+          version: "3",
           status: "draft",
           updated_at: "2022-02-10T15:22:07Z",
         },
         {
           id: implementation_id,
           implementation_key: "some implementation key " + implementation_id,
-          version: 2,
+          version: "2",
           status: "published",
           updated_at: "2022-02-10T15:22:07Z",
         },
         {
-          id: 22,
+          id: "22",
           implementation_key: "some implementation key 22",
-          version: 1,
+          version: "1",
           status: "versioned",
           updated_at: "2022-02-10T15:22:07Z",
         },
@@ -33,22 +32,8 @@ describe("<RuleImplementationHistory", () => {
     },
   };
 
-  const renderOpts = {
-    messages: {
-      en: {
-        "ruleImplementations.props.implementation_key": "key",
-        "ruleImplementations.props.status": "status",
-        "ruleImplementations.props.version": "version",
-        "ruleImplementations.props.last_change_at": "change",
-      },
-    },
-  };
-
   it("matches the latest snapshot", () => {
-    const { container } = render(
-      <RuleImplementationHistory {...props} />,
-      renderOpts
-    );
+    const { container } = render(<RuleImplementationHistory {...props} />);
     expect(container).toMatchSnapshot();
   });
 });

package/src/components/__tests__/RuleImplementationLoader.spec.js

@@ -1,10 +1,9 @@
-import React from "react";
 import { render } from "@truedat/test/render";
 import { RuleImplementationLoader } from "../RuleImplementationLoader";
 
 const implementation_id = 234;
-jest.mock("react-router-dom", () => ({
-  ...jest.requireActual("react-router-dom"),
+jest.mock("react-router", () => ({
+  ...jest.requireActual("react-router"),
   useParams: () => ({ implementation_id: implementation_id }),
 }));
 

package/src/components/__tests__/RuleImplementationProperties.spec.js

@@ -1,93 +1,67 @@
-import React from "react";
-import { shallowWithIntl } from "@truedat/test/intl-stub";
+import { render, waitForLoad } from "@truedat/test/render";
 import { RuleImplementationProperties } from "../RuleImplementationProperties";
 
 describe("<RuleImplementationProperties />", () => {
-  it("matches the latest snapshot", () => {
-    const props = {
-      rule: {
-        business_concept_id: "2D2B3",
-        description: "desc1",
-        rule_type: { name: "type1" },
-      },
-      ruleImplementation: {
-        id: 10,
-        executable: true,
-        name: "NameRule2",
-        type: "integer_values_range",
-        status: "published",
-        system_params: {
-          table: { name: "aaaxxx" },
-          column: {
-            id: 2876,
-            name: "% Abandono de Clientes ac. año / Cartera Clientes",
-            path: [
-              "CRM",
-              "Objetos Públicos",
-              "Informes",
-              "Validación",
-              "ACGC - 01.00 Análisis General Compañía",
-            ],
-          },
+  const props = {
+    rule: {
+      business_concept_id: "2D2B3",
+      description: "desc1",
+      rule_type: { name: "type1" },
+    },
+    ruleImplementation: {
+      id: 10,
+      executable: true,
+      name: "NameRule2",
+      type: "integer_values_range",
+      status: "published",
+      system_params: {
+        table: { name: "aaaxxx" },
+        column: {
+          id: 2876,
+          name: "% Abandono de Clientes ac. año / Cartera Clientes",
+          path: [
+            "CRM",
+            "Objetos Públicos",
+            "Informes",
+            "Validación",
+            "ACGC - 01.00 Análisis General Compañía",
+          ],
         },
-        goal: 10,
-        minimum: 1,
-        result_type: "percentage",
       },
-      ruleImplementationResults: [
-        { date: "2019-08-12T02:00:00Z", result: 34 },
-        { date: "2019-08-12T01:00:00Z", result: 33 },
-      ],
-    };
-    const wrapper = shallowWithIntl(
-      <RuleImplementationProperties {...props} />
-    );
-    expect(wrapper).toMatchSnapshot();
+      goal: 10,
+      minimum: 1,
+      result_type: "percentage",
+    },
+    ruleImplementationResults: [
+      { date: "2019-08-12T02:00:00Z", result: 34 },
+      { date: "2019-08-12T01:00:00Z", result: 33 },
+    ],
+  };
+
+  it("matches the latest snapshot", async () => {
+    const rendered = render(<RuleImplementationProperties {...props} />);
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 
-  it("renders label for executable field", () => {
-    const props = {
-      rule: {
-        business_concept_id: "2D2B3",
-        description: "desc1",
-        rule_type: { name: "type1" },
-      },
-      ruleImplementation: {
-        id: 10,
-        executable: true,
-        name: "NameRule2",
-        type: "integer_values_range",
-        status: "published",
-        system_params: {
-          table: { name: "aaaxxx" },
-          column: {
-            id: 2876,
-            name: "% Abandono de Clientes ac. año / Cartera Clientes",
-            path: [
-              "CRM",
-              "Objetos Públicos",
-              "Informes",
-              "Validación",
-              "ACGC - 01.00 Análisis General Compañía",
-            ],
-          },
-        },
-        goal: 10,
-        minimum: 1,
-        result_type: "percentage",
-      },
-      ruleImplementationResults: [
-        { date: "2019-08-12T02:00:00Z", result: 34 },
-        { date: "2019-08-12T01:00:00Z", result: 33 },
-      ],
+  it("renders label for executable field", async () => {
+    const rendered = render(<RuleImplementationProperties {...props} />);
+    await waitForLoad(rendered);
+    expect(
+      rendered.container.querySelector(".olive.label")
+    ).toBeInTheDocument();
+
+    const nonExecutableProps = {
+      ...props,
+      ruleImplementation: { ...props.ruleImplementation, executable: false },
     };
-    const wrapper = shallowWithIntl(
-      <RuleImplementationProperties {...props} />
+
+    const renderedNonExecutable = render(
+      <RuleImplementationProperties {...nonExecutableProps} />
     );
-    expect(wrapper.find("Label").at(1).prop("color")).toEqual("olive");
-    wrapper.setProps({
-      ruleImplementation: { ...props.ruleImplementation, executable: false },
-    });
-    expect(wrapper.find("Label").at(1).prop("color")).toEqual("teal");
+    await waitForLoad(renderedNonExecutable);
+    expect(
+      renderedNonExecutable.container.querySelector(".teal.label")
+    ).toBeInTheDocument();
   });
 });

package/src/components/__tests__/RuleImplementationResultTabs.spec.js

@@ -1,17 +1,7 @@
-import React from "react";
-import { render } from "@truedat/test/render";
-import messages from "@truedat/dq/messages";
+import { render, waitForLoad } from "@truedat/test/render";
 import { RuleImplementationResultTabs } from "../RuleImplementationResultTabs";
 
 describe("<RuleImplementationResultTabs />", () => {
-  const renderOpts = {
-    messages: {
-      en: {
-        ...messages.en,
-      },
-    },
-  };
-
   const props = {
     rule: { id: 8 },
     ruleImplementation: { id: 1 },
@@ -20,11 +10,9 @@ describe("<RuleImplementationResultTabs />", () => {
     ruleResult: { id: 2 },
     authCreateRemediation: true,
   };
-  it("matches the latest snapshot", () => {
-    const { container } = render(
-      <RuleImplementationResultTabs {...props} />,
-      renderOpts
-    );
-    expect(container).toMatchSnapshot();
+  it("matches the latest snapshot", async () => {
+    const rendered = render(<RuleImplementationResultTabs {...props} />);
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 });

package/src/components/__tests__/RuleImplementationResults.spec.js

@@ -1,5 +1,4 @@
 import _ from "lodash/fp";
-import React from "react";
 import { render } from "@truedat/test/render";
 import RuleImplementationResults, {
   getCustomColumnsWithData,
@@ -8,8 +7,8 @@ import RuleImplementationResults, {
 
 import { implementationResultsMock } from "./__fixtures__/implementationResultsMocks";
 
-jest.mock("react-router-dom", () => ({
-  ...jest.requireActual("react-router-dom"),
+jest.mock("react-router", () => ({
+  ...jest.requireActual("react-router"),
   useParams: () => ({ implementation_id: "2" }),
 }));
 

package/src/components/__tests__/RuleImplementationResultsLink.spec.js

@@ -1,12 +1,12 @@
-import React from "react";
-import { shallow } from "enzyme";
+import { render, waitForLoad } from "@truedat/test/render";
 import { RuleImplementationResultsLink } from "../RuleImplementationResultsLink";
 
 describe("<RuleImplementationResultsLink />", () => {
   const props = { id: 123, implementation_key: "foo", rule_id: 4 };
 
-  it("matches the latest snapshot", () => {
-    const wrapper = shallow(<RuleImplementationResultsLink {...props} />);
-    expect(wrapper).toMatchSnapshot();
+  it("matches the latest snapshot", async () => {
+    const rendered = render(<RuleImplementationResultsLink {...props} />);
+    await waitForLoad(rendered);
+    expect(rendered.container).toMatchSnapshot();
   });
 });

package/src/components/__tests__/RuleImplementationTabs.spec.js

@@ -1,4 +1,3 @@
-import React from "react";
 import { render } from "@truedat/test/render";
 import { RuleImplementationTabs } from "../RuleImplementationTabs";