@truedat/dq 7.14.1 → 7.14.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@truedat/dq",
-  "version": "7.14.1",
+  "version": "7.14.3",
   "description": "Truedat Web Data Quality Module",
   "sideEffects": false,
   "module": "src/index.js",
@@ -53,7 +53,7 @@
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
-    "@truedat/test": "7.14.1",
+    "@truedat/test": "7.14.3",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.7.0",
     "redux-saga-test-plan": "^4.0.6"
@@ -86,5 +86,5 @@
     "semantic-ui-react": "^3.0.0-beta.2",
     "swr": "^2.3.3"
   },
-  "gitHead": "afc55f553bb99ed37bfcc85fc83ba815d48b4769"
+  "gitHead": "f8b2f517aa25cf1eab47a89b17e0b08dfe6c8a26"
 }

package/src/components/ImplementationStructuresNew.js

@@ -16,7 +16,18 @@ export const ImplementationStructuresNew = ({
   creatingImplementationStructure,
   implementation,
   createImplementationStructure,
+  canCreateLink,
 }) => {
+  if (!canCreateLink) {
+    window.location.replace(
+      linkTo.IMPLEMENTATION_STRUCTURES({
+        id: implementation.rule_id,
+        implementation_id: implementation.id,
+      })
+    );
+    return null;
+  }
+
   const { formatMessage } = useIntl();
   const [selectedTarget, setSelectedTarget] = useState(null);
   const [type, setType] = useState("dataset");
@@ -80,12 +91,14 @@ export const ImplementationStructuresNew = ({
                 key="datasetSelector"
                 onSelect={handleTargetSelected}
                 defaultFilters={{ "class.raw": ["table"] }}
+                withLinkStructures={true}
               />
             ) : (
               <StructureSelector
                 key="nonDatasetSelector"
                 onSelect={handleTargetSelected}
                 defaultFilters={{ "class.raw": ["field"] }}
+                withLinkStructures={true}
               />
             )
           }
@@ -112,11 +125,13 @@ ImplementationStructuresNew.propTypes = {
   implementation: PropTypes.object,
   creatingImplementationStructure: PropTypes.bool,
   createImplementationStructure: PropTypes.func,
+  canCreateLink: PropTypes.bool,
 };
 
 const mapStateToProps = (state) => ({
   creatingImplementationStructure: state.creatingImplementationStructure,
   implementation: state.ruleImplementation,
+  canCreateLink: _.propOr(false, "link_structure")(state.implementationActions),
 });
 
 export default connect(mapStateToProps, { createImplementationStructure })(

package/src/components/__tests__/ImplementationStructureLinksActions.spec.js

@@ -0,0 +1,34 @@
+import { render, waitForLoad } from "@truedat/test/render";
+import { ImplementationStructureLinksActions } from "../ImplementationStructureLinksActions";
+
+describe("<ImplementationStructureLinksActions />", () => {
+    it("renders button when implementation_id is present and canCreateLink is true", async () => {
+        const props = {
+            implementation_id: 1,
+            canCreateLink: true,
+        };
+        const rendered = render(<ImplementationStructureLinksActions {...props} />);
+        await waitForLoad(rendered);
+        expect(rendered.getByText("links.actions.create")).toBeInTheDocument();
+    });
+
+    it("does not render button when canCreateLink is false", async () => {
+        const props = {
+            implementation_id: 1,
+            canCreateLink: false,
+        };
+        const rendered = render(<ImplementationStructureLinksActions {...props} />);
+        await waitForLoad(rendered);
+        expect(rendered.queryByText("links.actions.create")).not.toBeInTheDocument();
+    });
+
+    it("does not render button when implementation_id is missing", async () => {
+        const props = {
+            implementation_id: null,
+            canCreateLink: true,
+        };
+        const rendered = render(<ImplementationStructureLinksActions {...props} />);
+        await waitForLoad(rendered);
+        expect(rendered.queryByText("links.actions.create")).not.toBeInTheDocument();
+    });
+});

package/src/components/__tests__/ImplementationStructuresNew.spec.js

@@ -1,6 +1,15 @@
 import { render, waitForLoad } from "@truedat/test/render";
 import { ImplementationStructuresNew } from "../ImplementationStructuresNew";
 
+jest.mock("@truedat/core/routes", () => ({
+  linkTo: {
+    IMPLEMENTATION_STRUCTURES: jest.fn(
+      ({ id, implementation_id }) =>
+        `/implementations/${id}/structures/${implementation_id}`
+    ),
+  },
+}));
+
 jest.mock("@truedat/dd/hooks/useStructures", () => {
   const originalModule = jest.requireActual("@truedat/dd/hooks/useStructures");
   const structures = [1, 2, 3].map((id) => ({
@@ -41,14 +50,46 @@ jest.mock("@truedat/dd/hooks/useStructures", () => {
 });
 
 describe("<ImplementationStructuresNew />", () => {
+  const originalLocation = window.location;
+
+  beforeAll(() => {
+    delete window.location;
+    window.location = { replace: jest.fn() };
+  });
+
+  afterAll(() => {
+    window.location = originalLocation;
+  });
+
+  afterEach(() => {
+    jest.clearAllMocks();
+  });
+
   it("matches the latest snapshot", async () => {
     const props = {
       implementation: {},
       creatingImplementationStructure: false,
       createImplementationStructure: jest.fn(),
+      canCreateLink: true,
     };
     const rendered = render(<ImplementationStructuresNew {...props} />);
     await waitForLoad(rendered);
     expect(rendered.container).toMatchSnapshot();
   });
+
+  it("redirects when canCreateLink is false", () => {
+    const props = {
+      implementation: { id: 100, rule_id: 200 },
+      creatingImplementationStructure: false,
+      createImplementationStructure: jest.fn(),
+      canCreateLink: false,
+    };
+
+    const rendered = render(<ImplementationStructuresNew {...props} />);
+
+    expect(window.location.replace).toHaveBeenCalledWith(
+      "/implementations/200/structures/100"
+    );
+    expect(rendered.container).toBeEmptyDOMElement();
+  });
 });